[GitHub] DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition
DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373545553 @fmaximus @rafaelweingartner @marcaurele @rhtyd @ustcweizhou , can we please have further reviews for this? (or mpre discussion) Of couse a flyway kind of solution need to be our long term solution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition
DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373390590 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition
DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373366839 Discussion seems to go stale, are we now done with all comments @ernjvr ? @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition
DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-371131289 @ernjvr I think you want to address @rafaelweingartner instead of Rafael. Better change on reaction. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition
DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-365283716 @ustcweizhou I ran into that issue as well. adding the required items from java seems a feasible way to make them idempotent indeed. another solution would be to query the table description before adding This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition
DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-364879178 @ustcweizhou I agree that something like that would be preferable but someone has to take the heat on implementing that. And nobody is taking the time for such a technical/non-functional improvement. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
