[GitHub] DaanHoogland commented on issue #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector
DaanHoogland commented on issue #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382645213 so @brettKK @lujiefsi @rafaelweingartner (@rhtyd @swill @wido ) and of course all others are we waiting for this to be rebased against 4.11 or do we merge to master? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector
DaanHoogland commented on issue #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382353436 trying to get a new ci run This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector
DaanHoogland commented on issue #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382353181 @lujiefsi what do you mean by, "does not associate"? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2573: Cloudstack 10356
DaanHoogland commented on issue #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382345484 @brettKK what @rafaelweingartner is refering to is the following procedure: $ git checkout -b 4.11 origin/4.11 $ git pull # may not be needed anymore ;) $ git checkout -b CLOUDSTACK-10356-4.11 $ git cherry-pick dc8f4ef \# other cherry picks in order of your choice but make sure you have them all $ git cherry-pick 2856781 \# alternatively you can squash all changes first and do a siingle cherry-pick \# google for a howto \# and then $ git branch -m CLOUDSTACK-10356 CLOUDSTACK-10356-master $ git branch -m CLOUDSTACK-10356-4.11 CLOUDSTACK-10356 $ git push --force brettkk CLOUDSTACK-10356 # or whatever alias you use for your own fork. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2573: Cloudstack 10356
DaanHoogland commented on issue #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382345761 i reset the base to master in case someone accidentally would merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2573: Cloudstack 10356
DaanHoogland commented on issue #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382345484 @brettKK what @rafaelweingartner is refering to is the following procedure: $ git checkout -b 4.11 origin/4.11 $ git pull # may not be needed anymore ;) $ git checkout -b CLOUDSTACK-10356-4.11 $ git cherry-pick dc8f4ef # other cherry picks in order of your choice but make sure you have them all $ git cherry-pick 2856781 # alternatively you can squash all changes first and do a siingle cherry-pick # google for a howto # and then $ git branch -m CLOUDSTACK-10356 CLOUDSTACK-10356-master $ git branch -m CLOUDSTACK-10356-4.11 CLOUDSTACK-10356 $ git push --force brettkk CLOUDSTACK-10356 # or whatever alias you use for your own fork. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2573: Cloudstack 10356
DaanHoogland commented on issue #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382310815 @brettKK this can not be merged, I think you based on master and then pointed the pull request at 4.11. I think you need to rebase your changes on the branch you want to merge to. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2573: Cloudstack 10356
DaanHoogland commented on issue #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-381499966 removed a few tab chars @brettKK , sorry to not PR them but github failed at that This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
