[GitHub] khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper
khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper URL: https://github.com/apache/cloudstack/pull/2343#issuecomment-407467361 Sure, closed it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper
khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper URL: https://github.com/apache/cloudstack/pull/2343#issuecomment-407458030 @rafaelweingartner yes, I still think this would make sense to go forward with, but since I created a couple of docker `cloudstack-builder` containers, both for RPM and DEB, and since there are more tooling required to have an actual build (besides maven itself) we might be able to let this one go. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper
khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper URL: https://github.com/apache/cloudstack/pull/2343#issuecomment-367390167 @rafaelweingartner actually I noticed that going forward with this PR depends on #2433, because they both touch building and packaging scripts (mostly). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper
khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper URL: https://github.com/apache/cloudstack/pull/2343#issuecomment-367112605 @rafaelweingartner I already rebased today after I saw your comment, but the thing is this PR is really in WIP and I haven't completed it yet. I'll try to do it Soon! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper
khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper URL: https://github.com/apache/cloudstack/pull/2343#issuecomment-348077470 @rafaelweingartner that defeats the whole point of using `mvnw`. And I totally agree we should never check in jar files but this is the only generally accepted exception. Modern maven or gradle based projects usually have this, to name a few: - [Spring boot](https://github.com/spring-projects/spring-boot/) - [Netflix Eureka](https://github.com/Netflix/eureka) - [Hibernate](https://github.com/hibernate/hibernate-orm) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper
khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper URL: https://github.com/apache/cloudstack/pull/2343#issuecomment-347904651 IMO It's not just replacing one tool with another, it: - requires less dependency to packages installed on ones machine, given that there's no universal way to install Maven even in one specific OS/distro and one specific version of maven itself. - gives consistency, kind of the same way we have `.java-version` and `.python-version`. So everyone has and uses the exact same version of maven, everywhere, everytime. - and gives us control of that version. If -for whatever reason- Maven needs to be upgraded we will only need to change one jar file and one properties in the codebase itself. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
