[GitHub] nathanejohnson commented on issue #3133: feature: add libvirt / qemu io bursting
nathanejohnson commented on issue #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#issuecomment-458641564 @GabrielBrascher this error seems to be occurring because blue orangutan doesn't have the marvin version that would have been created by this PR. it included an updated configuration, and the "ioburst" key is missing. Maybe someone from shape blue could weigh in? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nathanejohnson commented on issue #3133: feature: add libvirt / qemu io bursting
nathanejohnson commented on issue #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#issuecomment-457402065 @mike-tutkowski still very keen to get your input on the point raised above, I would not want to break any of your functionality if this gets merged This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nathanejohnson commented on issue #3133: feature: add libvirt / qemu io bursting
nathanejohnson commented on issue #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#issuecomment-457401730 @GabrielBrascher @rafaelweingartner sorry this has taken so long to get back to, I've been transitioning to a new laptop and getting everything moved over, and then trying to play catchup on all of the other things that slipped while I was getting all set back up. I know not all of the points have been addressed, but I have at least fixed the conflict and refactored some of the lower hanging fruit that was mentioned. Overall, I do think some good points were made by Rafael. I know that overall code quality is important, and the current shape of the code sometimes serves as a deterrent to new developers. However, I would also say that if every time a new feature is added or a bug is fixed, that all surrounding code must also be cleaned up serves as a deterrent to existing developers wishing to contribute back. I am all for finding a happy balance, and I certainly don't want to make the code worse with my contributions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nathanejohnson commented on issue #3133: feature: add libvirt / qemu io bursting
nathanejohnson commented on issue #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#issuecomment-455014910 it looks like blue orangutan didn't get my updated marvin test_data.py from this PR. is it possible it didn't reinstall marvin from this branch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
