[GitHub] rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type

2017-11-30 Thread GitBox
rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private 
the traffic_type
URL: https://github.com/apache/cloudstack/pull/2128#issuecomment-348324514
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type

2017-12-01 Thread GitBox
rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private 
the traffic_type
URL: https://github.com/apache/cloudstack/pull/2128#issuecomment-348454682
 
 
   @jayapalu please fix the conflicts and build failures


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type

2017-12-11 Thread GitBox
rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private 
the traffic_type
URL: https://github.com/apache/cloudstack/pull/2128#issuecomment-350786439
 
 
   @jayapalu can you fix conflicts and move sql related changes to appropriate 
4.10->4.11 path?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type

2017-12-17 Thread GitBox
rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private 
the traffic_type
URL: https://github.com/apache/cloudstack/pull/2128#issuecomment-352288277
 
 
   @jayapalu ping? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type

2017-12-18 Thread GitBox
rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private 
the traffic_type
URL: https://github.com/apache/cloudstack/pull/2128#issuecomment-352660881
 
 
   @jayapalu this is marked as a blocker, can you help fix this? Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type

2017-12-18 Thread GitBox
rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private 
the traffic_type
URL: https://github.com/apache/cloudstack/pull/2128#issuecomment-352288277
 
 
   @jayapalu ping? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type

2017-12-22 Thread GitBox
rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private 
the traffic_type
URL: https://github.com/apache/cloudstack/pull/2128#issuecomment-353558683
 
 
   Ping @jayapalu can you please respond? This issue is marked as blocker in 
jira. /cc @karuturi @sateesh-chodapuneedi @priyankparihar @yvsubhash and others 
at Accelerite who may want to work with the community on this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type

2018-01-02 Thread GitBox
rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private 
the traffic_type
URL: https://github.com/apache/cloudstack/pull/2128#issuecomment-354761775
 
 
   ping @jayapalu 
   
   I'll remove this from 4.11 milestone due to lack of engagement, response 
from the author and discussions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type

2018-10-08 Thread GitBox
rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private 
the traffic_type
URL: https://github.com/apache/cloudstack/pull/2128#issuecomment-427854111
 
 
   Essentially, the private gateway from a user point of view is still a kind 
guest network type providing access for guest VMs. I started by 
extending/fixing this PR but found it to be not necessary to add a new traffic 
type to fix this which will also require codebase-wide refactoring and 
additional checks wherever `TrafficType.Guest` is used throughout the codebase.
   
   In https://github.com/apache/cloudstack/pull/2888 the VR nics are aggregated 
and programmed by the nic device order and in the VR the `ip_association` is 
handled such that the device order is found by referencing the mac address for 
an ipaddress than the device id from the json. /cc @PaulAngus 
   
   I'm still able to reproduce the issue 
https://issues.apache.org/jira/browse/CLOUDSTACK-9885 in case of rVRs but I 
think it's solvable by adding a new boolean to say whether a guest network nic 
is a private gateway and handle that case in VR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type

2018-01-07 Thread GitBox
rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private 
the traffic_type
URL: https://github.com/apache/cloudstack/pull/2128#issuecomment-355818317
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type

2018-01-07 Thread GitBox
rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private 
the traffic_type
URL: https://github.com/apache/cloudstack/pull/2128#issuecomment-355819906
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type

2018-01-07 Thread GitBox
rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private 
the traffic_type
URL: https://github.com/apache/cloudstack/pull/2128#issuecomment-355901271
 
 
   @jayapalu can you address outstanding questions and look at failures?
   @ustcweizhou since you've had fixed the issue in a different way, can you 
help review the PR? Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type

2018-01-09 Thread GitBox
rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private 
the traffic_type
URL: https://github.com/apache/cloudstack/pull/2128#issuecomment-356214216
 
 
   Given there is no engagement from the author and this issue is a specific 
case, does not block the release I'll move this to 4.12 milestone. /cc 
@jayapalu 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services