[GitHub] rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency

2017-12-18 Thread GitBox
rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency
URL: https://github.com/apache/cloudstack/pull/2348#issuecomment-352514405
 
 
   @rafaelweingartner do we have a jira ID for this? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency

2017-12-17 Thread GitBox
rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency
URL: https://github.com/apache/cloudstack/pull/2348#issuecomment-352248615
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency

2017-12-17 Thread GitBox
rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency
URL: https://github.com/apache/cloudstack/pull/2348#issuecomment-352241942
 
 
   LGTM
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency

2017-12-17 Thread GitBox
rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency
URL: https://github.com/apache/cloudstack/pull/2348#issuecomment-352241679
 
 
   @rafaelweingartner thanks, no need to squash yourself. I'll squash merge 
using Github. I'll re-review the changes, and kick another round of tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency

2017-12-15 Thread GitBox
rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency
URL: https://github.com/apache/cloudstack/pull/2348#issuecomment-352159107
 
 
   LGTM, test LGTM as well. The failures are known issues.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency

2017-12-15 Thread GitBox
rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency
URL: https://github.com/apache/cloudstack/pull/2348#issuecomment-352159483
 
 
   @rafaelweingartner can you address outstanding queries, following which we 
can merge this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency

2017-12-15 Thread GitBox
rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency
URL: https://github.com/apache/cloudstack/pull/2348#issuecomment-352159107
 
 
   LGTM, test LGTM as well. The failures are known issues. Based on reviews and 
test results, I'll merge this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency

2017-12-15 Thread GitBox
rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency
URL: https://github.com/apache/cloudstack/pull/2348#issuecomment-352053303
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency

2017-12-15 Thread GitBox
rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency
URL: https://github.com/apache/cloudstack/pull/2348#issuecomment-352047216
 
 
   @blueorangutan package
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency

2017-12-15 Thread GitBox
rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency
URL: https://github.com/apache/cloudstack/pull/2348#issuecomment-352004902
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency

2017-12-15 Thread GitBox
rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency
URL: https://github.com/apache/cloudstack/pull/2348#issuecomment-351995414
 
 
   @rafaelweingartner can you fix the conflicts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency

2017-12-11 Thread GitBox
rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency
URL: https://github.com/apache/cloudstack/pull/2348#issuecomment-350778042
 
 
   Good cleanup, we'll need some extended testing on this one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services