[GitHub] rhtyd commented on issue #2628: Create upgrade path from 4.9.3.1 to 4.11.1.0

2018-05-07 Thread GitBox
rhtyd commented on issue #2628: Create upgrade path from 4.9.3.1 to 4.11.1.0
URL: https://github.com/apache/cloudstack/pull/2628#issuecomment-387275991
 
 
   Merging this based on code reviews, lgtms by majority and manual tests and 
travis.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2628: Create upgrade path from 4.9.3.1 to 4.11.1.0

2018-05-07 Thread GitBox
rhtyd commented on issue #2628: Create upgrade path from 4.9.3.1 to 4.11.1.0
URL: https://github.com/apache/cloudstack/pull/2628#issuecomment-387114781
 
 
   @rafaelweingartner I can accept this without unit tests. Travis and 
packaging has passed along with manual testing. Since this is purely db+upgrade 
change, travis is enough to validate the change, no need for a trillian test 
run.
   
   If there are no objections, I'll merge this by tomorrow eod.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2628: Create upgrade path from 4.9.3.1 to 4.11.1.0

2018-05-07 Thread GitBox
rhtyd commented on issue #2628: Create upgrade path from 4.9.3.1 to 4.11.1.0
URL: https://github.com/apache/cloudstack/pull/2628#issuecomment-387059540
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services