Re: [PR] Show in which primary storage volumes are allocated in instance details page and volume migration pop-ups [cloudstack]
DaanHoogland merged PR #8835: URL: https://github.com/apache/cloudstack/pull/8835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Show in which primary storage volumes are allocated in instance details page and volume migration pop-ups [cloudstack]
blueorangutan commented on PR #8835: URL: https://github.com/apache/cloudstack/pull/8835#issuecomment-2022266912 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8835 (QA-JID-308) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Show in which primary storage volumes are allocated in instance details page and volume migration pop-ups [cloudstack]
blueorangutan commented on PR #8835: URL: https://github.com/apache/cloudstack/pull/8835#issuecomment-2022237398 @sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Show in which primary storage volumes are allocated in instance details page and volume migration pop-ups [cloudstack]
sureshanaparti commented on PR #8835: URL: https://github.com/apache/cloudstack/pull/8835#issuecomment-2022236575 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Show in which primary storage volumes are allocated in instance details page and volume migration pop-ups [cloudstack]
GaOrtiga commented on code in PR #8835: URL: https://github.com/apache/cloudstack/pull/8835#discussion_r1539808276 ## ui/public/locales/en.json: ## @@ -585,6 +585,7 @@ "label.currency": "Currency", "label.current": "Current", "label.currentpassword": "Current password", +"label.current.storage": "Current storage", Review Comment: @winterhazel Shouldn't this come before `label.currentpassword`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Show in which primary storage volumes are allocated in instance details page and volume migration pop-ups [cloudstack]
codecov[bot] commented on PR #8835: URL: https://github.com/apache/cloudstack/pull/8835#issuecomment-2020485690 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8835?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `0%` with `3 lines` in your changes are missing coverage. Please review. > Project coverage is 4.34%. Comparing base [(`e44c17e`)](https://app.codecov.io/gh/apache/cloudstack/commit/e44c17e07703ac0ceda7326585f433fe33b37ca4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b2f9dfb`)](https://app.codecov.io/gh/apache/cloudstack/pull/8835?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8835?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [ui/src/components/view/VolumesTab.vue](https://app.codecov.io/gh/apache/cloudstack/pull/8835?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL2NvbXBvbmVudHMvdmlldy9Wb2x1bWVzVGFiLnZ1ZQ==) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8835?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8835 +/- ## - Coverage 30.93% 4.34% -26.60% Files 5404 361 -5043 Lines380309 29007 -351302 Branches 555075093-50414 - Hits 1176581260 -116398 + Misses 247041 27607 -219434 + Partials 15610 140-15470 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8835/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8835/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8835/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.34% <0.00%> (-0.01%)` | :arrow_down: | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8835/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8835?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Show in which primary storage volumes are allocated in instance details page and volume migration pop-ups [cloudstack]
winterhazel opened a new pull request, #8835:
URL: https://github.com/apache/cloudstack/pull/8835
### Description
This PR changes the volume tab in the instance details page, the volume
migration pop-up and the instance migration with volumes pop-up to show admins
in which primary storage the volumes are allocated.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [X] Minor
### Screenshots (if appropriate):
Volumes tab in the instance details page
Volume migration pop-up
Instance migration with volumes pop-up
### How Has This Been Tested?
1. In the root admin account, I accessed an instance's page and verified
that the volumes tab showed the `Storage` column.
2. In an account that did not have permission to view the storage a volume
is allocated, I accessed an instance's page and verified that the volumes tab
did not show the `Storage` column.
3. In the root admin account, I opened the volume migration pop-up and
verified that it showed the volume's current storage;
4. In the root admin account, I opened the instance migration with volumes
pop-up and verified that it showed the current storage volumes were allocated
in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
