Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
rohityadavcloud merged PR #9177: URL: https://github.com/apache/cloudstack/pull/9177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2166868850 [SF] Trillian test result (tid-10430) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43903 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9177-t10430-kvm-centos7.zip Smoke tests completed. 130 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_trigger_shutdown | `Failure` | 341.76 | test_safe_shutdown.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2165107857 @rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2165106120 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2165072113 [SF] Trillian Build Failed (tid-10429) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164998307 @rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164993799 Requesting re-review as code has changed a bit @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164831630 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164644255 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9177 (QA-JID-373) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164591956 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164590083 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164582100 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2164580635 Amusing, we're going in circles now and obstinately determined about it. I've tried my part, got non-technical and discourteous reasons to block the PR, coerced to unrelated agenda. I'm also flattered some want my attention and validation so bad. I'm gonna sit on the fence on this one, for now; save my time and energy. `list.vm.default.details.stats` defaults to true now. @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
GutoVeronezi commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2163430400 @rohityadavcloud, I did not judge your change of opinion. If you read it carefully, you will see that what I am doing is pointing out that there was no consensus on the change of the default behavior in the whole discussion. There were no direct attacks on anyone, I am just making the timeline clear. We would like to introduce some breaking changes and changes to default behavior, but we do not have a documented process for this, and doing it on a case-by-case basis is prone to heated discussions and unfair decisions. Discussion #8970 is there to make these processes well-defined and documented so we can avoid this kind of discussions in the future. > * I don't think it makes sense to block this change till we decide on [Define a release schedule for the project #8970](https://github.com/apache/cloudstack/discussions/8970). It deals with wider discussion and there are no clear outcomes in the past 45 days or so @shwstppr If more people interact there, we can get some outcomes :smiley: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2162393074 @GutoVeronezi by your own admission I changed my stand, closed my PR to support Joao's, and built support and consensus with others on Joao's PR and merge his PR. I also don't appreciate some of your remarks and behaviour towards me. It's unfair to me when I'm genuinely trying to help and support everybody and anybody in the community. I don't see anything wrong with somebody changing their stand when presented with new information or convincing arguments. My reason for changing my stand wrt the default behaviour is that most users don't consume stats (outside of UI) via the list APIs, but many integrations such as Terraform provider, k8s-provider, CAPC, users ansible scripts etc (point of note that these integrations can't be changed) call the list VM APIs and can benefit from any potential speed up. @GutoVeronezi @JoaoJandre and anyone else - what are your reasons of changing your stand wrt the default behaviour now? For example, look at the two user reported issues that also contributed to change my stand: https://github.com/apache/cloudstack/issues/8975 https://github.com/apache/cloudstack/issues/7910 I think we introduced the behaviour, and we can discuss and agree if we want to change that if that is largely beneficial to users. I don't think it would detrimental for large number of users if they have gain speedups and still had a global setting to change the behaviour. That said, I don't have the energy or bandwidth to fight over this, if this is the only thing blocking this I can change the global setting. Have a look, review and advise - @JoaoJandre @DaanHoogland @weizhouapache @sureshanaparti @GutoVeronezi @shwstppr and others... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
GutoVeronezi commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2161243596 > @GutoVeronezi , I understand your point, but we do not have a simple usable procedure yet. The implicit procedure was "we don't introduce any backwards incompatability, .. unless we all agree". And so in this case you are right. That does not remove the need to decide on individual issues. Maybe @rohityadavcloud is a bit quick art the gun, but it makes sense to first introduce a setting and than later reverse the default. We have done it like that in the past. Maybe we can add this to #8970 (if it is not included yet). > > So how do you propose we take this forward? cc @JoaoJandre @sureshanaparti @weizhouapache As we already have a configuration to change the behavior, we should keep the current behavior and guide people through the release notes on how to change it. Then, we should continue the #8970 discussion. Once a process is defined and documented, we can look back to the configuration and change the default according to the policy we defined (or even remove the configuration if we decide so). Other systems do that way, like GitLab and OpenStack; the problem is that we do not have this defined and documented yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
DaanHoogland commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2160625659 @GutoVeronezi , I understand your point, but we do not have a simple usable procedure yet. The implicit procedure was "we don't introduce any backwards incompatability, .. unless we all agree". And so in this case you are right. That does not remove the need to decide on individual issues. Maybe @rohityadavcloud is a bit quick art the gun, but it makes sense to first introduce a setting and than later reverse the default. We have done it like that in the past. Maybe we can add this to #8970 (if it is not included yet). So how do you propose we take this forward? cc @JoaoJandre @sureshanaparti @weizhouapache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
GutoVeronezi commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2158201023 @rohityadavcloud, let me build the story line for you: - at first, you said that the default behavior should not be changed and a configuration should be introduced: https://github.com/apache/cloudstack/pull/8782#issuecomment-1997341885 - @JoaoJandre argued against that and nobody answered: https://github.com/apache/cloudstack/pull/8782#issuecomment-1997435998 - then, you created a PR to do the same thing that @JoaoJandre proposed: https://github.com/apache/cloudstack/pull/8985 - we (the community) discussed and @JoaoJandre agreed on adding the configuration to keep the current behavior: https://github.com/apache/cloudstack/pull/8782#issuecomment-2096632612 - you proposed to @JoaoJandre to change the default behavior, which he was against, pointing to the [discussion](https://github.com/apache/cloudstack/discussions/8970) about disruptive changes: https://github.com/apache/cloudstack/pull/8782#discussion_r1595448901 - finally, you merged @JoaoJandre's PR and opened this PR to change the default behavior: https://github.com/apache/cloudstack/pull/9177 We (the community) did not agree on changing the default behavior, and I am -1 because of that. What bothers me in this whole situation is that we do not have a well-defined and documented policy for introducing disruptive features, removing deprecated methods, technologies, and designs, changing default behaviors, and so on. It is insane that some disruptive changes are introduced while others are not just because some few wants; it is not a well-defined and documented process, it is a subjective process that is confusing, volatile, unpredictable, and not scalable, which is not healthy for a community. We are having a discussion about it at https://github.com/apache/cloudstack/discussions/8970 (which almost everybody seems to ignore). Thus, it is important for everybody to participate so the community can agree on something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2158019038 @GutoVeronezi this isn't a vote, could you explain why you're opposing now that the default value change when we've agreed in #8782 to address this via documentation of the change in release notes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
GutoVeronezi commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2154233759 -1 on changing the `list.vm.default.details.stats` default value. Refer to the discussion in #8782. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2153440394 [SF] Trillian test result (tid-10375) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49031 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9177-t10375-kvm-centos7.zip Smoke tests completed. 131 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
codecov[bot] commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2151672639 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9177?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 15.67%. Comparing base [(`631d6ad`)](https://app.codecov.io/gh/apache/cloudstack/commit/631d6ad09bc5e175492973de9f2958456db4488e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`68b1779`)](https://app.codecov.io/gh/apache/cloudstack/commit/68b177978b7359e48bf9c6bb493a6b12ccd604d6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19#9177 +/- ## + Coverage 14.96% 15.67% +0.71% - Complexity1099110992 +1 Files 5373 5010 -363 Lines469203 439900 -29303 Branches 6022554619-5606 - Hits 7019868942-1256 + Misses 391232 363326 -27906 + Partials 7773 7632 -141 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9177/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `15.67% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9177?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2151588735 @rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2151587878 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2149968171 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
blueorangutan commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2149721270 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2149717245 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
rohityadavcloud opened a new pull request, #9177:
URL: https://github.com/apache/cloudstack/pull/9177
### Description
- Changes behaviour of details param handling via global setting:
- listVirtualMachines API: when the details param is not provided, it
returns `all` details excluding/including `stats` which is controllable by a
new global setting `list.vm.default.details.stats`
- listVirtualMachinesMetrics API: when the details param is not provided,
it uses `all` details including `stats`
- Users who are affected by the stats related change, can have backward
compatibility at the higher-cost of listVirtualMachines API response time by
setting `list.vm.default.details.stats` to true
- Remove ConfigKey vm.stats.increment.metrics.in.memory which was renamed to
`vm.stats.increment.metrics` in #5984 and also remove unused/unnecessary global
settings via upgrade path
- Changes default value of VM stats accumulation setting
`vm.stats.increment.metrics` to false until a better solution emerges. Since
#5984, this is true and during the execution of listVM APIs the stats are
clubbed/calculated which can immensely slow down list VM API calls.
- Fix UI that uses listVirtualMachinesMetrics to not call `stats` detail
when in list view without metrics selected.
### Types of changes
- [x] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [x] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
