Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2243940975 [LL]Trillian test result (tid-6962) Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8 Total time taken: 46628 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9163-t6962-kvm-alma8.zip Smoke tests completed. 135 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py test_02_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py test_04_autoscale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py test_06_delete_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py test_10_vpc_tier_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py test_11_test_unmanaged_cluster_lifecycle | `Error` | 0.00 | test_kubernetes_clusters.py test_06_purge_expunged_vm_background_task | `Failure` | 322.81 | test_purge_expunged_vms.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2242462837 @DaanHoogland a [LL] Trillian-Jenkins test job (alma8 mgmt + kvm-alma8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
DaanHoogland commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2242459909 @blueorangutan LLtest alma8 kvm-alma8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2242345762 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2242214893 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
shwstppr commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2242212622 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2165905723 [SF] Trillian Build Failed (tid-10435) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
weizhouapache commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2165812577 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2165816766 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2165618633 [SF] Trillian test result (tid-10424) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 65335 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9163-t10424-kvm-centos7.zip Smoke tests completed. 128 look OK, 6 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_list_system_vms_metrics_history | `Failure` | 0.24 | test_metrics_api.py test_02_trigger_shutdown | `Failure` | 346.76 | test_safe_shutdown.py test_01_sys_vm_start | `Failure` | 240.43 | test_secondary_storage.py test_11_destroy_ssvm | `Failure` | 917.02 | test_ssvm.py test_12_destroy_cpvm | `Failure` | 913.26 | test_ssvm.py test_04_deploy_vnf_appliance | `Error` | 112.90 | test_vnf_templates.py test_04_deploy_vnf_appliance | `Error` | 112.90 | test_vnf_templates.py test_05_delete_vnf_template | `Error` | 1.08 | test_vnf_templates.py ContextSuite context=TestVnfTemplates>:teardown | `Error` | 2.20 | test_vnf_templates.py test_hostha_enable_ha_when_host_disabled | `Error` | 5.96 | test_hostha_kvm.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 306.10 | test_hostha_kvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2163636740 @shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
shwstppr commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2163635744 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157924675 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
weizhouapache commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157768742 > @weizhouapache added tests Currently only used in KVM VM definitions. I couldn't find any reference in other hypervisor plugins thanks code lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157762172 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
shwstppr commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157760876 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
shwstppr commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157742504 @weizhouapache added tests Currently only used in KVM VM definitions. I couldn't find any reference in other hypervisor plugins -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
weizhouapache commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157581319 > @rohityadavcloud marked it ready > > A note about cloud-init behaviour is added in the global config descriptions and in the doc PR thanks @shwstppr overall looks good to me - is it implemented for kvm ? - can you add a unit test for it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
shwstppr commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157568535 @rohityadavcloud marked it ready A note about cloud-init behaviour is added in the global config descriptions and in the doc PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157557647 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157404760 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
rohityadavcloud commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2157402665 @shwstppr is this ready for review or still need some work (as the PR is in draft) @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
rohityadavcloud closed pull request #9163: orchestration,hypervisor: allow custom manufacturer, product for vm metadata URL: https://github.com/apache/cloudstack/pull/9163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2149968165 Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2149703435 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
shwstppr commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2149702799 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]
shwstppr commented on code in PR #9163:
URL: https://github.com/apache/cloudstack/pull/9163#discussion_r1627660626
##
engine/api/src/main/java/com/cloud/vm/VirtualMachineManager.java:
##
@@ -87,6 +87,20 @@ public interface VirtualMachineManager extends Manager {
ConfigKey MetadataCustomCloudName = new ConfigKey<>("Advanced",
String.class, "metadata.custom.cloud.name", "",
"If provided, a custom cloud-name in cloud-init metadata", true,
ConfigKey.Scope.Zone);
+ConfigKey VmMetadataManufacturer = new ConfigKey<>("Advanced",
String.class,
+"vm.metadata.manufacturer", "",
+"If provided, a custom manufacturer will be used in the instance
metadata. When an empty" +
+"value is set then default manufacturer will be 'Apache
Software Foundation'. " +
+"A custom manufacturer may break cloud-init functionality
with CloudStack datasource. Please " +
+"refer documentation", true, ConfigKey.Scope.Zone);
+ConfigKey VmMetadataProductName = new ConfigKey<>("Advanced",
String.class,
+"vm.metadata.product", "",
+"If provided, a custom product name will be used in the instance
metadata. When an empty" +
+"value is set then default product name will be
'CloudStack Hypervisor'. " +
+"A custom product name may break cloud-init functionality
with CloudStack datasource. Please " +
+"refer documentation",
+true, ConfigKey.Scope.Zone);
+
Review Comment:
done
##
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java:
##
@@ -1262,6 +1262,8 @@ public void orchestrateStart(final String vmUuid, final
Map
