[GitHub] [cloudstack] rohityadavcloud commented on pull request #7956: UI: Admin, account and project dashboard improvements
rohityadavcloud commented on PR #7956: URL: https://github.com/apache/cloudstack/pull/7956#issuecomment-1733057938 @blueorangutan package @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] MartinEmrich commented on issue #7946: Default Domain Admin role not working after migration
MartinEmrich commented on issue #7946: URL: https://github.com/apache/cloudstack/issues/7946#issuecomment-1733058647 I ran the script before the upgrade (with the `-D` option, as I never edited my command.properties), but also multiple times after the upgrade in an attempt to get it to work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7956: UI: Admin, account and project dashboard improvements
blueorangutan commented on PR #7956: URL: https://github.com/apache/cloudstack/pull/7956#issuecomment-1733059162 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7956: UI: Admin, account and project dashboard improvements
blueorangutan commented on PR #7956: URL: https://github.com/apache/cloudstack/pull/7956#issuecomment-1733059146 @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with@blueorangutan ui SystemVM template(s). I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7956: UI: Admin, account and project dashboard improvements
blueorangutan commented on PR #7956: URL: https://github.com/apache/cloudstack/pull/7956#issuecomment-1733076900 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7956 (QA-JID-191) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #7645: api: remove powermock from tests
rohityadavcloud merged PR #7645: URL: https://github.com/apache/cloudstack/pull/7645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch main updated: api: remove powermock from tests (#7645)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 9c65767f95b api: remove powermock from tests (#7645)
9c65767f95b is described below
commit 9c65767f95bca0c3b31db8e8504242139b5171fb
Author: Vishesh
AuthorDate: Mon Sep 25 13:15:54 2023 +0530
api: remove powermock from tests (#7645)
---
.../admin/account/CreateAccountCmdTest.java| 5 +-
.../admin/annotation/AddAnnotationCmdTest.java | 10 +-
.../admin/systemvm/PatchSystemVMCmdTest.java | 43 +++---
.../api/command/admin/user/CreateUserCmdTest.java | 5 +-
.../api/command/test/ResetVMUserDataCmdTest.java | 54
.../firewall/CreateEgressFirewallRuleCmdTest.java | 149 ++---
.../user/userdata/DeleteUserDataCmdTest.java | 42 +++---
.../userdata/LinkUserDataToTemplateCmdTest.java| 49 +++
.../command/user/userdata/ListUserDataCmdTest.java | 19 +--
.../user/userdata/RegisterUserDataCmdTest.java | 48 +++
.../api/command/user/vpc/CreateVPCCmdTest.java | 32 +++--
.../api/command/user/vpc/UpdateVPCCmdTest.java | 15 ++-
.../org.mockito.plugins.MockMaker | 1 +
13 files changed, 255 insertions(+), 217 deletions(-)
diff --git
a/api/src/test/java/org/apache/cloudstack/api/command/admin/account/CreateAccountCmdTest.java
b/api/src/test/java/org/apache/cloudstack/api/command/admin/account/CreateAccountCmdTest.java
index ee942a22913..d26065da21c 100644
---
a/api/src/test/java/org/apache/cloudstack/api/command/admin/account/CreateAccountCmdTest.java
+++
b/api/src/test/java/org/apache/cloudstack/api/command/admin/account/CreateAccountCmdTest.java
@@ -52,9 +52,11 @@ public class CreateAccountCmdTest {
private Integer accountType = 1;
private Long domainId = 1L;
+private AutoCloseable closeable;
+
@Before
public void setUp() throws Exception {
-MockitoAnnotations.initMocks(this);
+closeable = MockitoAnnotations.openMocks(this);
ReflectionTestUtils.setField(createAccountCmd, "domainId", domainId);
ReflectionTestUtils.setField(createAccountCmd, "accountType",
accountType);
CallContext.register(Mockito.mock(User.class),
Mockito.mock(Account.class));
@@ -62,6 +64,7 @@ public class CreateAccountCmdTest {
@After
public void tearDown() throws Exception {
+closeable.close();
CallContext.unregister();
}
diff --git
a/api/src/test/java/org/apache/cloudstack/api/command/admin/annotation/AddAnnotationCmdTest.java
b/api/src/test/java/org/apache/cloudstack/api/command/admin/annotation/AddAnnotationCmdTest.java
index 06656868994..443460f2fff 100644
---
a/api/src/test/java/org/apache/cloudstack/api/command/admin/annotation/AddAnnotationCmdTest.java
+++
b/api/src/test/java/org/apache/cloudstack/api/command/admin/annotation/AddAnnotationCmdTest.java
@@ -18,6 +18,7 @@
*/
package org.apache.cloudstack.api.command.admin.annotation;
+import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.mockito.MockitoAnnotations;
@@ -26,9 +27,16 @@ public class AddAnnotationCmdTest {
private AddAnnotationCmd addAnnotationCmd = new AddAnnotationCmd();
+private AutoCloseable closeable;
+
@Before
public void setUp() throws Exception {
-MockitoAnnotations.initMocks(this);
+closeable = MockitoAnnotations.openMocks(this);
+}
+
+@After
+public void tearDown() throws Exception {
+closeable.close();
}
@Test (expected = IllegalStateException.class)
diff --git
a/api/src/test/java/org/apache/cloudstack/api/command/admin/systemvm/PatchSystemVMCmdTest.java
b/api/src/test/java/org/apache/cloudstack/api/command/admin/systemvm/PatchSystemVMCmdTest.java
index 125c8b56665..4f58bd6d391 100644
---
a/api/src/test/java/org/apache/cloudstack/api/command/admin/systemvm/PatchSystemVMCmdTest.java
+++
b/api/src/test/java/org/apache/cloudstack/api/command/admin/systemvm/PatchSystemVMCmdTest.java
@@ -20,23 +20,20 @@ import com.cloud.server.ManagementService;
import com.cloud.user.Account;
import com.cloud.utils.Pair;
import org.apache.cloudstack.context.CallContext;
+import org.junit.After;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
+import org.mockito.MockedStatic;
import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;
-import org.powermock.api.mockito.PowerMockito;
-import org.powermock.core.classloader.annotations.PowerMockIgnore;
-import org.powermock.core.classloader.annotations.PrepareForTest;
-import org.powermock.modules.junit4.PowerMockRunner;
+import org.mockito.junit.MockitoJUnitRunner;
import org.springframework.test.util.ReflectionTestUtils;
-@RunWit
[GitHub] [cloudstack] blueorangutan commented on pull request #7956: UI: Admin, account and project dashboard improvements
blueorangutan commented on PR #7956: URL: https://github.com/apache/cloudstack/pull/7956#issuecomment-1733109316 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch contributers created (now 9f5b2ef9925)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch contributers in repository https://gitbox.apache.org/repos/asf/cloudstack.git at 9f5b2ef9925 contributor-howto This branch includes the following new commits: new 9f5b2ef9925 contributor-howto The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[cloudstack] 01/01: contributor-howto
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch contributers in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 9f5b2ef992579c0ae0cfb2dfce7b96a7856edae2 Author: Daan Hoogland AuthorDate: Mon Sep 25 09:54:31 2023 +0200 contributor-howto --- README.md | 7 +++ 1 file changed, 7 insertions(+) diff --git a/README.md b/README.md index 2519c6cd273..f36c4da2514 100644 --- a/README.md +++ b/README.md @@ -83,6 +83,13 @@ contribution. Note that you do not have to be a developer in order to contribute to Apache CloudStack. We need folks to help with documentation, translation, promotion etc. See our contribution [page](http://cloudstack.apache.org/contribute.html). +If you are a frequent contributors, you can request to be added as collaborators +(see https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-AssigningexternalcollaboratorswiththetriageroleonGitHub) +to our Github repos. This allows you to use project Github with ability to report +issue with tags, and be assigned to issues and PRs. This is done via the .asf.yaml +file in this repo. +You may do so by sharing your github users ID or raise a Github issue. + If you're interested in learning more or participating in the Apache CloudStack project, the mailing lists are the best way to do that. While the project has several communications channels, the [mailing lists](http://cloudstack.apache.org/mailing-lists.html) are the most active and the
[GitHub] [cloudstack] DaanHoogland opened a new pull request, #7995: contributor-howto
DaanHoogland opened a new pull request, #7995: URL: https://github.com/apache/cloudstack/pull/7995 ### Description This PR adds contributers info to the Readme.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7878: Publish event for VM.STOP when out of band stop is detected
DaanHoogland merged PR #7878: URL: https://github.com/apache/cloudstack/pull/7878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 4.18 updated: Publish event for VM.STOP when out of band stop is detected (#7878)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch 4.18
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.18 by this push:
new 3071ad69f62 Publish event for VM.STOP when out of band stop is
detected (#7878)
3071ad69f62 is described below
commit 3071ad69f627d77c6edbe7a05cc20a23f18fe062
Author: Marcus Sorensen
AuthorDate: Mon Sep 25 02:02:08 2023 -0600
Publish event for VM.STOP when out of band stop is detected (#7878)
Signed-off-by: Marcus Sorensen
---
.../src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java| 5 +
1 file changed, 5 insertions(+)
diff --git
a/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
b/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
index cf188cbf58d..ca453ed0de1 100755
---
a/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
+++
b/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
@@ -47,6 +47,7 @@ import javax.inject.Inject;
import javax.naming.ConfigurationException;
import javax.persistence.EntityExistsException;
+import com.cloud.event.ActionEventUtils;
import org.apache.cloudstack.affinity.dao.AffinityGroupVMMapDao;
import org.apache.cloudstack.annotation.AnnotationService;
import org.apache.cloudstack.annotation.dao.AnnotationDao;
@@ -4804,6 +4805,8 @@ public class VirtualMachineManagerImpl extends
ManagerBase implements VirtualMac
VM_SYNC_ALERT_SUBJECT, "VM " + vm.getHostName() + "(" +
vm.getInstanceName() + ") state is sync-ed (" + vm.getState()
+ " -> Running) from out-of-context transition. VM network
environment may need to be reset");
+ActionEventUtils.onActionEvent(User.UID_SYSTEM,
Account.ACCOUNT_ID_SYSTEM, vm.getDomainId(),
+EventTypes.EVENT_VM_START, "Out of band VM power on",
vm.getId(), ApiCommandResourceType.VirtualMachine.toString());
s_logger.info("VM " + vm.getInstanceName() + " is sync-ed to at
Running state according to power-on report from hypervisor");
break;
@@ -4837,6 +4840,8 @@ public class VirtualMachineManagerImpl extends
ManagerBase implements VirtualMac
case Stopping:
case Running:
case Stopped:
+ActionEventUtils.onActionEvent(User.UID_SYSTEM,
Account.ACCOUNT_ID_SYSTEM,vm.getDomainId(),
+EventTypes.EVENT_VM_STOP, "Out of band VM power off",
vm.getId(), ApiCommandResourceType.VirtualMachine.toString());
case Migrating:
if (s_logger.isInfoEnabled()) {
s_logger.info(
[GitHub] [cloudstack] harikrishna-patnala opened a new pull request, #7996: Oauth2 integration with CloudStack
harikrishna-patnala opened a new pull request, #7996:
URL: https://github.com/apache/cloudstack/pull/7996
### Description
With this PR we will be having Oauth integration in CloudStack
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7964: Allow configkey to set 'cloud-name' cloud-init metadata
DaanHoogland commented on PR #7964: URL: https://github.com/apache/cloudstack/pull/7964#issuecomment-1733127211 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6812: Normalize encryption on global configurations values
DaanHoogland commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1733128315 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7964: Allow configkey to set 'cloud-name' cloud-init metadata
blueorangutan commented on PR #7964: URL: https://github.com/apache/cloudstack/pull/7964#issuecomment-1733131101 @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7995: contributor-howto
codecov[bot] commented on PR #7995: URL: https://github.com/apache/cloudstack/pull/7995#issuecomment-1733131882 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7995?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#7995](https://app.codecov.io/gh/apache/cloudstack/pull/7995?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9f5b2ef) into [main](https://app.codecov.io/gh/apache/cloudstack/commit/9c65767f95bca0c3b31db8e8504242139b5171fb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9c65767) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ##main #7995 +/- ## = Coverage 4.87% 4.87% = Files342 342 Lines 25650 25650 Branches44144414 = Hits12501250 Misses 24267 24267 Partials 133 133 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/7995/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/7995/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.87% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #7946: Default Domain Admin role not working after migration
DaanHoogland commented on issue #7946: URL: https://github.com/apache/cloudstack/issues/7946#issuecomment-1733144215 ok, I'll try to reproduce in a lab env -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7996: Oauth2 integration with CloudStack
codecov[bot] commented on PR #7996: URL: https://github.com/apache/cloudstack/pull/7996#issuecomment-1733145667 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7996?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#7996](https://app.codecov.io/gh/apache/cloudstack/pull/7996?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b634000) into [main](https://app.codecov.io/gh/apache/cloudstack/commit/9c65767f95bca0c3b31db8e8504242139b5171fb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9c65767) will **decrease** coverage by `12.52%`. > The diff coverage is `0.00%`. ```diff @@ Coverage Diff @@ ## main #7996 +/- ## - Coverage 17.36% 4.85% -12.52% Files 4966 342 -4624 Lines336428 25747 -310681 Branches 483444419-43925 - Hits 584351250-57185 + Misses 269709 24364 -245345 + Partials 8284 133 -8151 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/7996/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/7996/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/7996/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.85% <0.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/apache/cloudstack/pull/7996?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [ui/src/api/index.js](https://app.codecov.io/gh/apache/cloudstack/pull/7996?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL2FwaS9pbmRleC5qcw==) | `25.00% <0.00%> (-11.37%)` | :arrow_down: | | [ui/src/config/router.js](https://app.codecov.io/gh/apache/cloudstack/pull/7996?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL2NvbmZpZy9yb3V0ZXIuanM=) | `1.61% <0.00%> (-0.03%)` | :arrow_down: | | [ui/src/config/section/config.js](https://app.codecov.io/gh/apache/cloudstack/pull/7996?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL2NvbmZpZy9zZWN0aW9uL2NvbmZpZy5qcw==) | `0.00% <ø> (ø)` | | | [ui/src/main.js](https://app.codecov.io/gh/apache/cloudstack/pull/7996?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL21haW4uanM=) | `0.00% <0.00%> (ø)` | | | [ui/src/permission.js](https://app.codecov.io/gh/apache/cloudstack/pull/7996?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL3Blcm1pc3Npb24uanM=) | `0.00% <0.00%> (ø)` | | | [ui/src/store/modules/user.js](https://app.codecov.io/gh/apache/cloudstack/pull/7996?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL3N0b3JlL21vZHVsZXMvdXNlci5qcw==) | `4.26% <0.00%> (-0.83%)` | :arrow_down: | | [ui/src/views/auth/Login.vue](https://app.codecov.io/gh/apache/cloudstack/pull/7996?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL3ZpZXdzL2F1dGgvTG9naW4udnVl) | `0.00% <0.00%> (ø)` | | | [ui/src/views/iam/AddUser.vue](https://app.codecov.io/gh/apache/cloudstack/pull/7996?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL3ZpZXdzL2lhbS9BZGRVc2VyLnZ1ZQ==) | `0.00% <ø> (ø)` | | ... and [4624 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7996/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=
[cloudstack] branch main updated (9c65767f95b -> f539c4b81ad)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 9c65767f95b api: remove powermock from tests (#7645) add 3071ad69f62 Publish event for VM.STOP when out of band stop is detected (#7878) new f539c4b81ad Merge release branch 4.18 to main The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java| 5 + 1 file changed, 5 insertions(+)
[cloudstack] 01/01: Merge release branch 4.18 to main
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit f539c4b81ad7f132dc27e6713d345eedb2fdd7f0 Merge: 9c65767f95b 3071ad69f62 Author: Daan Hoogland AuthorDate: Mon Sep 25 10:20:57 2023 +0200 Merge release branch 4.18 to main * 4.18: Publish event for VM.STOP when out of band stop is detected (#7878) .../src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java| 5 + 1 file changed, 5 insertions(+)
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7919: NSX integration
github-actions[bot] commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1733165872 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 6778-if-kafka-is-turned-on-internal-subs-dont-work updated (f743be4f1f5 -> 0e9bef5b74f)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 6778-if-kafka-is-turned-on-internal-subs-dont-work in repository https://gitbox.apache.org/repos/asf/cloudstack.git from f743be4f1f5 extra logging add 0e9bef5b74f spring-reg No new revisions were added by this update. Summary of changes: .../spring-framework-event-core-context.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) copy plugins/acl/project-role-based/src/main/resources/META-INF/cloudstack/acl-project-role-based/spring-acl-project-role-based-context.xml => framework/events/src/main/resources/META-INF.cloudstack.core/spring-framework-event-core-context.xml (87%)
[GitHub] [cloudstack] blueorangutan commented on pull request #7964: Allow configkey to set 'cloud-name' cloud-init metadata
blueorangutan commented on PR #7964: URL: https://github.com/apache/cloudstack/pull/7964#issuecomment-1733211632 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 6778-if-kafka-is-turned-on-internal-subs-dont-work updated (0e9bef5b74f -> c2a25096d5c)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 6778-if-kafka-is-turned-on-internal-subs-dont-work in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 0e9bef5b74f spring-reg add c2a25096d5c publish to list No new revisions were added by this update. Summary of changes: .../cloudstack/framework/events/EventDistributor.java | 8 .../cloudstack/framework/events/EventDistributorImpl.java | 14 -- server/src/main/java/com/cloud/api/ApiServer.java | 2 +- 3 files changed, 21 insertions(+), 3 deletions(-)
[GitHub] [cloudstack] DaanHoogland commented on pull request #7964: Allow configkey to set 'cloud-name' cloud-init metadata
DaanHoogland commented on PR #7964: URL: https://github.com/apache/cloudstack/pull/7964#issuecomment-1733223523 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7964: Allow configkey to set 'cloud-name' cloud-init metadata
blueorangutan commented on PR #7964: URL: https://github.com/apache/cloudstack/pull/7964#issuecomment-1733224075 @DaanHoogland a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vishesh92 opened a new pull request, #7997: Fixup CheckedReservationTest
vishesh92 opened a new pull request, #7997:
URL: https://github.com/apache/cloudstack/pull/7997
### Description
This PR...
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7956: UI: Admin, account and project dashboard improvements
rohityadavcloud commented on code in PR #7956:
URL: https://github.com/apache/cloudstack/pull/7956#discussion_r1335624664
##
ui/package.json:
##
@@ -34,13 +34,13 @@
"test:unit": "vue-cli-service test:unit"
},
"dependencies": {
-"@fortawesome/fontawesome-svg-core": "^1.3.0",
-"@fortawesome/free-brands-svg-icons": "^5.15.2",
-"@fortawesome/free-solid-svg-icons": "^5.15.2",
-"@fortawesome/vue-fontawesome": "^3.0.0-4",
+"@fortawesome/fontawesome-svg-core": "^6.4.2",
+"@fortawesome/free-brands-svg-icons": "^6.4.2",
+"@fortawesome/free-solid-svg-icons": "^6.4.2",
+"@fortawesome/vue-fontawesome": "^3.0.3",
"@vue-js-cron/ant": "^1.1.3",
"@vue-js-cron/core": "^3.7.1",
-"ant-design-vue": "^3.2.9",
+"ant-design-vue": "^3.2.20",
Review Comment:
cc @borisstoyanov @vladimirpetrov @kiranchavala tbd if full UI smoketest is
required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7997: Fixup CheckedReservationTest
vishesh92 commented on code in PR #7997:
URL: https://github.com/apache/cloudstack/pull/7997#discussion_r1335628515
##
server/src/test/java/com/cloud/resourcelimit/CheckedReservationTest.java:
##
@@ -70,14 +72,16 @@ public void tearDown() throws Exception {
@Test
public void getId() {
when(account.getDomainId()).thenReturn(4l);
-boolean fail = false;
-try (CheckedReservation cr = new CheckedReservation(account,
Resource.ResourceType.user_vm,1l, reservationDao, resourceLimitService); ) {
+// Some weird behaviour depending on whether the database is up or not.
+
lenient().when(reservationDao.persist(Mockito.any())).thenReturn(reservation);
Review Comment:
Added lenient because if the database is up, this show up as unused stubs.
##
server/src/test/java/com/cloud/resourcelimit/CheckedReservationTest.java:
##
@@ -70,14 +72,16 @@ public void tearDown() throws Exception {
@Test
public void getId() {
when(account.getDomainId()).thenReturn(4l);
-boolean fail = false;
-try (CheckedReservation cr = new CheckedReservation(account,
Resource.ResourceType.user_vm,1l, reservationDao, resourceLimitService); ) {
+// Some weird behaviour depending on whether the database is up or not.
+
lenient().when(reservationDao.persist(Mockito.any())).thenReturn(reservation);
Review Comment:
Added lenient because if the database is not up, this show up as unused
stubs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7990: registry of message busses
blueorangutan commented on PR #7990: URL: https://github.com/apache/cloudstack/pull/7990#issuecomment-1733310628 Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7997: Fixup CheckedReservationTest
codecov[bot] commented on PR #7997: URL: https://github.com/apache/cloudstack/pull/7997#issuecomment-1733312814 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7997?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#7997](https://app.codecov.io/gh/apache/cloudstack/pull/7997?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ccd3739) into [main](https://app.codecov.io/gh/apache/cloudstack/commit/f539c4b81ad7f132dc27e6713d345eedb2fdd7f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f539c4b) will **decrease** coverage by `23.96%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## main #7997 +/- ## - Coverage 28.82% 4.87% -23.96% Files 5100 342 -4758 Lines358326 25650 -332676 Branches 523084414-47894 - Hits 1032881250 -102038 + Misses 240788 24267 -216521 + Partials 14250 133-14117 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/7997/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/7997/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/7997/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.87% <ø> (ø)` | | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/7997/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 4758 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7997/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7997: Fixup CheckedReservationTest
harikrishna-patnala commented on PR #7997: URL: https://github.com/apache/cloudstack/pull/7997#issuecomment-1733319456 @vishesh92 not sure how this is calculating but report looks wrong to me  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vishesh92 commented on pull request #7997: Fixup CheckedReservationTest
vishesh92 commented on PR #7997: URL: https://github.com/apache/cloudstack/pull/7997#issuecomment-1733325646 @harikrishna-patnala all the coverage tests haven't completed that is why it's wrong. Check the flags for specific details.  > @vishesh92 not sure how this is calculating but report looks wrong to me > >  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7956: UI: Admin, account and project dashboard improvements
rohityadavcloud commented on PR #7956: URL: https://github.com/apache/cloudstack/pull/7956#issuecomment-1733349168 @blueorangutan package @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7956: UI: Admin, account and project dashboard improvements
blueorangutan commented on PR #7956: URL: https://github.com/apache/cloudstack/pull/7956#issuecomment-1733350565 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7956: UI: Admin, account and project dashboard improvements
blueorangutan commented on PR #7956: URL: https://github.com/apache/cloudstack/pull/7956#issuecomment-1733350572 @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with@blueorangutan ui SystemVM template(s). I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7997: Fixup CheckedReservationTest
harikrishna-patnala commented on PR #7997: URL: https://github.com/apache/cloudstack/pull/7997#issuecomment-1733354283 > @harikrishna-patnala all the coverage tests haven't completed that is why it's wrong. Check the flags for specific details. > >  > > > @vishesh92 not sure how this is calculating but report looks wrong to me > >  got it, thanks @vishesh92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7345: [HEALTH] 4.18 LTS Health Check, please don't merge this!
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1733369442 @andrijapanicsb a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7956: UI: Admin, account and project dashboard improvements
blueorangutan commented on PR #7956: URL: https://github.com/apache/cloudstack/pull/7956#issuecomment-1733371915 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7956 (QA-JID-192) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7956: UI: Admin, account and project dashboard improvements
blueorangutan commented on PR #7956: URL: https://github.com/apache/cloudstack/pull/7956#issuecomment-1733406973 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Hossein4185 commented on issue #7993: Cloudstack management does not display the list of instances
Hossein4185 commented on issue #7993: URL: https://github.com/apache/cloudstack/issues/7993#issuecomment-1733416029 I tested this command in cloudmonkey but show nothing 'list virtualmachines listall=true ' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on issue #7968: VR webserver apache2 failing to start
harikrishna-patnala commented on issue #7968: URL: https://github.com/apache/cloudstack/issues/7968#issuecomment-1733428433 @weizhouapache I've tried the similar that you have mentioned in a VPC (creating and destroying tiers with VM in tier) but apache server is running fine. Anything I need to consider to reproduce ?  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez opened a new issue, #7998: [UI] Vmware deploy-as-is instances are not receiving the properties values
nvazquez opened a new issue, #7998: URL: https://github.com/apache/cloudstack/issues/7998 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ 4.17, 4.18 ~~~ # CONFIGURATION Register a VMware vApp template selecting the option 'Read settings from OVA'. Deploy VM and input property values # OS / ENVIRONMENT Vmware vApps containing properties # SUMMARY vApp properties values are not passed to the deployVirtualMachine API after the Vue3 upgrade on: https://github.com/apache/cloudstack/pull/5151 # STEPS TO REPRODUCE ~~~ - Register a vApp template containing vApp properties on CloudStack, selecting the 'Read setting from OVA' option - On the Deploy Instance wizard, select the template and complete the values for the vApp properties - Deploy VM ~~~ # EXPECTED RESULTS ~~~ The deployVirtualMachine API includes the properties set ~~~  # ACTUAL RESULTS ~~~ The properties parameter is not set for the deployVirtualMachine API ~~~  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch nsx-integration updated: ui: fix password field, and backend changes
This is an automated email from the ASF dual-hosted git repository.
pearl11594 pushed a commit to branch nsx-integration
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/nsx-integration by this push:
new 4f4bd2ac433 ui: fix password field, and backend changes
4f4bd2ac433 is described below
commit 4f4bd2ac433fc345ee5926f03865b0d4a6c4593a
Author: Pearl Dsilva
AuthorDate: Mon Sep 25 07:55:40 2023 -0400
ui: fix password field, and backend changes
---
.../apache/cloudstack/resource/NsxResource.java| 42 +++---
.../infra/zone/ZoneWizardNetworkSetupStep.vue | 3 +-
2 files changed, 32 insertions(+), 13 deletions(-)
diff --git
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/resource/NsxResource.java
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/resource/NsxResource.java
index 266d3bc23b3..65192d00cef 100644
---
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/resource/NsxResource.java
+++
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/resource/NsxResource.java
@@ -37,7 +37,6 @@ import com.vmware.nsx_policy.infra.Tier1s;
import com.vmware.nsx_policy.infra.sites.EnforcementPoints;
import com.vmware.nsx_policy.infra.tier_0s.LocaleServices;
import com.vmware.nsx_policy.model.ApiError;
-import com.vmware.nsx_policy.model.ChildLocaleServices;
import com.vmware.nsx_policy.model.EnforcementPointListResult;
import com.vmware.nsx_policy.model.LocaleServicesListResult;
import com.vmware.nsx_policy.model.Segment;
@@ -244,7 +243,7 @@ public class NsxResource implements ServerResource {
throw new InvalidParameterValueException(String.format("VPC
network with name %s exists in NSX zone: %s and account %s", name,
cmd.getZoneName(), cmd.getAccountName()));
}
-List localeServices =
getTier0LocalServices(tier0Gateway);
+
String tier0GatewayPath = TIER_0_GATEWAY_PATH_PREFIX + tier0Gateway;
Tier1s tier1service = (Tier1s) nsxService.apply(Tier1s.class);
@@ -256,17 +255,19 @@ public class NsxResource implements ServerResource {
.setFailoverMode(PREEMPTIVE.name())
.setId(name)
.setDisplayName(name)
-.setChildren(
-List.of(new
ChildLocaleServices.Builder("ChildLocaleServices")
-.setLocaleServices(
-new
com.vmware.nsx_policy.model.LocaleServices.Builder()
-
.setEdgeClusterPath(localeServices.get(0).getEdgeClusterPath())
-
.setParentPath(TIER_1_GATEWAY_PATH_PREFIX + getTier1GatewayName(cmd))
-
.setResourceType("LocaleServices")
-.build()
-).build())).build();
+//.setChildren(
+//List.of(new
ChildLocaleServices.Builder("ChildLocaleServices")
+//.setLocaleServices(
+//new
com.vmware.nsx_policy.model.LocaleServices.Builder()
+//
.setEdgeClusterPath(localeServices.get(0).getEdgeClusterPath())
+//
.setParentPath(TIER_1_GATEWAY_PATH_PREFIX + getTier1GatewayName(cmd))
+//
.setResourceType("LocaleServices")
+//.build()
+//).build()))
+.build();
try {
tier1service.patch(name, tier1);
+createTier1LocaleServices(name, edgeCluster);
} catch (Error error) {
ApiError ae = error.getData()._convertTo(ApiError.class);
return new NsxAnswer(cmd, new
CloudRuntimeException(ae.getErrorMessage()));
@@ -274,6 +275,23 @@ public class NsxResource implements ServerResource {
return new NsxAnswer(cmd, true, "");
}
+/**
+ * To instantiate Tier-1 in Edge Cluster
+ * @return
+ */
+private boolean createTier1LocaleServices(String tier1Id, String
edgeCluster) {
+try {
+List localeServices =
getTier0LocalServices(tier0Gateway);
+com.vmware.nsx_policy.infra.tier_1s.LocaleServices
tier1LocalService = (com.vmware.nsx_policy.infra.tier_1s.LocaleServices)
nsxService.apply(com.vmware.nsx_policy.infra.tier_1s.LocaleServices.class);
+com.vmware.nsx_policy.model.LocaleServices localeService = new
com.vmware.nsx_policy.model.LocaleServices.Builder()
+
.setEdgeClusterPath(localeServices.get(0).getEdgeClusterPath()).build();
+
[cloudstack] branch nsx-integration updated (4f4bd2ac433 -> eae9c4784e5)
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch nsx-integration in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 4f4bd2ac433 ui: fix password field, and backend changes add 4bdff06acd3 Updating pom.xml version numbers for release 4.18.1.0 add 246bb24b0fc Updating pom.xml version numbers for release 4.18.2.0-SNAPSHOT add b8c8e17318c upgrade: fix debian/changelog add 0bfef5d9da4 Merge commit 'b8c8e17318cc28e57d1b38f2aa2f0b456c9bac52' add edcd0da62ed UI: update versions to 4.19.0 add f049d4d189f Increase reserve on ScaleIO disk formatting for fragmentation (#7955) add 45616aaf614 Merge remote-tracking branch 'origin/4.18' add 4eb110af736 Remove unneeded duplicate words (#7850) add d25521e96fa Fix issues in VM Scheduler (#7782) add c428d3bb341 Add and improve logs in snapshot scheduling (#6925) add 9c9b17885ff upgrade: fix upgrade from 4.18.1.0 to 4.18.2.0-SNAPSHOT (#7959) add 09ae0499b21 ldap trust map cleanup on domain delete (#7915) add 0375714ded5 Merge release branch 4.18 to main add 481d2bd9c3f Remove powermock from core (#7978) add 84277e783b5 remove powermock from engine (#7975) add e721f3b379b Remove powermock from server (#7986) add c69e3c5f42d Remove powermock from engine/storage/configdrive (#7988) add 9c65767f95b api: remove powermock from tests (#7645) add 3071ad69f62 Publish event for VM.STOP when out of band stop is detected (#7878) add f539c4b81ad Merge release branch 4.18 to main add eae9c4784e5 Merge branch 'main' of https://github.com/apache/cloudstack into nsx-integration No new revisions were added by this update. Summary of changes: .../java/com/cloud/server/ManagementService.java | 2 +- .../api/command/user/vm/ListNicsCmd.java | 2 +- .../com/cloud/agent/api/storage/OVFHelperTest.java | 2 +- .../admin/account/CreateAccountCmdTest.java| 5 +- .../admin/annotation/AddAnnotationCmdTest.java | 10 +- .../admin/systemvm/PatchSystemVMCmdTest.java | 43 +- .../api/command/admin/user/CreateUserCmdTest.java | 5 +- .../api/command/test/ResetVMUserDataCmdTest.java | 54 +- .../firewall/CreateEgressFirewallRuleCmdTest.java | 149 +++-- .../user/userdata/DeleteUserDataCmdTest.java | 42 +- .../userdata/LinkUserDataToTemplateCmdTest.java| 49 +- .../command/user/userdata/ListUserDataCmdTest.java | 19 +- .../user/userdata/RegisterUserDataCmdTest.java | 48 +- .../api/command/user/vpc/CreateVPCCmdTest.java | 32 +- .../api/command/user/vpc/UpdateVPCCmdTest.java | 15 +- .../org.mockito.plugins.MockMaker | 0 .../com/cloud/resource/ServerResourceBaseTest.java | 162 +++--- .../cloud/storage/template/OVAProcessorTest.java | 51 +- .../cloud/storage/template/QCOW2ProcessorTest.java | 8 +- .../cloud/storage/template/VhdProcessorTest.java | 8 +- .../org.mockito.plugins.MockMaker | 0 .../main/java/com/cloud/event/UsageEventUtils.java | 2 +- .../java/com/cloud/ha/HighAvailabilityManager.java | 2 +- .../com/cloud/network/NetworkStateListener.java| 2 +- .../main/java/com/cloud/storage/StorageUtil.java | 2 +- .../com/cloud/vm/VirtualMachineManagerImpl.java| 5 + .../engine/orchestration/NetworkOrchestrator.java | 2 +- .../com/cloud/upgrade/DatabaseUpgradeChecker.java | 4 + .../cloud/upgrade/DatabaseVersionHierarchy.java| 9 + .../java/com/cloud/upgrade/dao/Upgrade218to22.java | 2 +- .../main/resources/META-INF/db/schema-21to22.sql | 2 +- .../main/resources/META-INF/db/schema-2214to30.sql | 2 +- .../main/resources/META-INF/db/schema-410to420.sql | 2 +- .../as/dao/AutoScaleVmGroupDaoImplTest.java| 19 +- .../dao/AutoScaleVmGroupStatisticsDaoImplTest.java | 31 +- .../as/dao/AutoScaleVmGroupVmMapDaoImplTest.java | 27 +- .../com/cloud/network/dao/NetworkDaoImplTest.java | 35 +- .../storage/dao/StoragePoolTagsDaoImplTest.java| 4 +- .../cloud/upgrade/DatabaseUpgradeCheckerTest.java | 23 +- .../java/com/cloud/upgrade/GuestOsMapperTest.java | 16 +- .../upgrade/dao/DatabaseAccessObjectTest.java | 18 +- .../com/cloud/upgrade/dao/DbUpgradeUtilsTest.java | 14 +- .../cloud/usage/dao/UsageStorageDaoImplTest.java | 46 +- .../datastore/db/PrimaryDataStoreDaoImplTest.java | 15 +- .../org.mockito.plugins.MockMaker | 0 .../storage/configdrive/ConfigDriveBuilder.java| 25 +- .../configdrive/ConfigDriveBuilderTest.java| 601 ++--- .../org.mockito.plugins.MockMaker | 0 .../motion/AncientDataMotionStrategyTest.java | 12 +- .../snapshot/SnapshotDataFactoryImplTest.java | 57 +- .../storage/snapshot/SnapshotServiceImplTest.java | 30 +- .../vmsnapshot/VMSnapshotStrategyKVMTest.java | 3 - .../org.mockito.plugins.MockMaker
[GitHub] [cloudstack] blueorangutan commented on pull request #7990: registry of message busses
blueorangutan commented on PR #7990: URL: https://github.com/apache/cloudstack/pull/7990#issuecomment-1733522809 Packaging result [LL]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7968: VR webserver apache2 failing to start
weizhouapache commented on issue #7968: URL: https://github.com/apache/cloudstack/issues/7968#issuecomment-1733556308 > > does hypervisor type matters here ? I tried with VMware hosts > > I think it shouldn't @harikrishna-patnala (by the look of @weizhouapache 's changes in #7982) @DaanHoogland I discussed with @harikrishna-patnala offline. The key point of the issue is, the VPC VRs are redundant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 6778-if-kafka-is-turned-on-internal-subs-dont-work updated (c2a25096d5c -> 001f60c39c3)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 6778-if-kafka-is-turned-on-internal-subs-dont-work in repository https://gitbox.apache.org/repos/asf/cloudstack.git from c2a25096d5c publish to list add 001f60c39c3 cleanup No new revisions were added by this update. Summary of changes: server/src/main/java/com/cloud/api/ApiServer.java | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-)
[GitHub] [cloudstack] harikrishna-patnala opened a new issue, #7999: Sync storage pool failed on VMware datastore cluster primary storage
harikrishna-patnala opened a new issue, #7999: URL: https://github.com/apache/cloudstack/issues/7999 # ISSUE TYPE * Bug Report * Improvement Request * Enhancement Request * Feature Idea * Documentation Report * Other # COMPONENT NAME ~~~ datastore cluster, vmware ~~~ # CLOUDSTACK VERSION ~~~ 4.17, could be before as well ~~~ # SUMMARY Sync storage pool operation failed on Datastore cluster primary storage after putting the primary storage in maintenance and cancelling the maintenance. The reason behind this is, while putting the datastore cluster in maintenance mode cloud.uuid on the child datastore are updated to invalid UUID without hyphens.  # STEPS TO REPRODUCE ~~~ 1. create Datastore cluster in vCenter and add it as primary storage in CloudStack. 2. put the storage in maintenance mode and cancel it 3. try to do sync storage pool operation and it will fail. All other volume operations are working fine. I've created VMFS datastores in the cluster. NFS datastores seems to be fine, but need to double check. ~~~ # EXPECTED RESULTS ~~~ Sync operation should success ~~~ # ACTUAL RESULTS ~~~ Sync operation fails ~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #7919: NSX integration
Pearl1594 commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1733602106 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7919: NSX integration
blueorangutan commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1733606751 @Pearl1594 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7919: NSX integration
blueorangutan commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1733709046 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vishesh92 opened a new pull request, #8000: Remove powermock from pom.xml
vishesh92 opened a new pull request, #8000:
URL: https://github.com/apache/cloudstack/pull/8000
### Description
This PR...
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #8000: Remove powermock from pom.xml
codecov[bot] commented on PR #8000: URL: https://github.com/apache/cloudstack/pull/8000#issuecomment-1733780648 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8000?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#8000](https://app.codecov.io/gh/apache/cloudstack/pull/8000?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d46e8df) into [main](https://app.codecov.io/gh/apache/cloudstack/commit/f539c4b81ad7f132dc27e6713d345eedb2fdd7f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f539c4b) will **decrease** coverage by `23.96%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## main #8000 +/- ## - Coverage 28.82% 4.87% -23.96% Files 5100 342 -4758 Lines358326 25650 -332676 Branches 523084414-47894 - Hits 1032881250 -102038 + Misses 240788 24267 -216521 + Partials 14250 133-14117 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8000/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8000/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8000/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.87% <ø> (ø)` | | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8000/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 4758 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/8000/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #7946: Default Domain Admin role not working after migration
DaanHoogland commented on issue #7946: URL: https://github.com/apache/cloudstack/issues/7946#issuecomment-1733789715 Not sure if I reproduced your issue @MartinEmrich , but on installing a 4.11 env, `dynamic.apichecker.enabled` is `true` by default. When I set it to `false` login fails even as root-admin. setting it back to `true` login succeeds again. Can you check that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #8000: Remove powermock from pom.xml
DaanHoogland commented on PR #8000: URL: https://github.com/apache/cloudstack/pull/8000#issuecomment-1733810260 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #8000: Remove powermock from pom.xml
blueorangutan commented on PR #8000: URL: https://github.com/apache/cloudstack/pull/8000#issuecomment-1733812566 @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7990: registry of message busses
blueorangutan commented on PR #7990: URL: https://github.com/apache/cloudstack/pull/7990#issuecomment-1733830403 Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #8000: Remove powermock from pom.xml
blueorangutan commented on PR #8000: URL: https://github.com/apache/cloudstack/pull/8000#issuecomment-1733852774 Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 7097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #7997: Fixup CheckedReservationTest
rohityadavcloud merged PR #7997: URL: https://github.com/apache/cloudstack/pull/7997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch main updated: Fixup CheckedReservationTest (#7997)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new b614a74027d Fixup CheckedReservationTest (#7997)
b614a74027d is described below
commit b614a74027d6743a3256ee5b02d79f096bb62dd5
Author: Vishesh
AuthorDate: Mon Sep 25 20:20:45 2023 +0530
Fixup CheckedReservationTest (#7997)
---
.../com/cloud/resourcelimit/CheckedReservationTest.java | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git
a/server/src/test/java/com/cloud/resourcelimit/CheckedReservationTest.java
b/server/src/test/java/com/cloud/resourcelimit/CheckedReservationTest.java
index 0b7a384050d..b8b35e2ce87 100644
--- a/server/src/test/java/com/cloud/resourcelimit/CheckedReservationTest.java
+++ b/server/src/test/java/com/cloud/resourcelimit/CheckedReservationTest.java
@@ -31,12 +31,14 @@ import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Mock;
+import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;
import org.mockito.junit.MockitoJUnitRunner;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.fail;
+import static org.mockito.Mockito.lenient;
import static org.mockito.Mockito.when;
@RunWith(MockitoJUnitRunner.class)
@@ -70,14 +72,16 @@ public class CheckedReservationTest {
@Test
public void getId() {
when(account.getDomainId()).thenReturn(4l);
-boolean fail = false;
-try (CheckedReservation cr = new CheckedReservation(account,
Resource.ResourceType.user_vm,1l, reservationDao, resourceLimitService); ) {
+// Some weird behaviour depending on whether the database is up or not.
+
lenient().when(reservationDao.persist(Mockito.any())).thenReturn(reservation);
+lenient().when(reservation.getId()).thenReturn(1L);
+try (CheckedReservation cr = new CheckedReservation(account,
Resource.ResourceType.user_vm,1l, reservationDao, resourceLimitService) ) {
long id = cr.getId();
-assertEquals(1l, id);
+assertEquals(1L, id);
} catch (NullPointerException npe) {
fail("NPE caught");
} catch (ResourceAllocationException rae) {
-// this does not work on all plafroms because of the static
methods being used in the global lock mechanism
+// this does not work on all platforms because of the static
methods being used in the global lock mechanism
// normally one would
// throw new CloudRuntimeException(rae);
// but we'll ignore this for platforms that can not humour the
static bits of the system.
@@ -88,8 +92,7 @@ public class CheckedReservationTest {
@Test
public void getNoAmount() {
-boolean fail = false;
-try (CheckedReservation cr = new CheckedReservation(account,
Resource.ResourceType.cpu,-11l, reservationDao, resourceLimitService); ) {
+try (CheckedReservation cr = new CheckedReservation(account,
Resource.ResourceType.cpu,-11l, reservationDao, resourceLimitService) ) {
Long amount = cr.getReservedAmount();
assertNull(amount);
} catch (NullPointerException npe) {
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7987: KVM Agent config to reserve dom0 CPUs
rohityadavcloud commented on PR #7987: URL: https://github.com/apache/cloudstack/pull/7987#issuecomment-1733882327 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7987: KVM Agent config to reserve dom0 CPUs
blueorangutan commented on PR #7987: URL: https://github.com/apache/cloudstack/pull/7987#issuecomment-1733885231 @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7972: Fix 2FA becoming enabled when the user inputs the wrong code during setup
rohityadavcloud commented on PR #7972: URL: https://github.com/apache/cloudstack/pull/7972#issuecomment-1733885672 ping @harikrishna-patnala can you review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #7958: VR live patching: Allow live patch of VPC VRs even if networks are in allocated / shutdown state
rohityadavcloud merged PR #7958: URL: https://github.com/apache/cloudstack/pull/7958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 4.18 updated: VR live patching: Allow live patch of VPC VRs even if networks are in allocated / shutdown state (#7958)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.18
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.18 by this push:
new 951ba04cf0e VR live patching: Allow live patch of VPC VRs even if
networks are in allocated / shutdown state (#7958)
951ba04cf0e is described below
commit 951ba04cf0eae3f48207306f0035a2292b55506d
Author: Pearl Dsilva
AuthorDate: Mon Sep 25 11:04:23 2023 -0400
VR live patching: Allow live patch of VPC VRs even if networks are in
allocated / shutdown state (#7958)
---
.../cloudstack/engine/orchestration/NetworkOrchestrator.java | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git
a/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
b/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
index 82e13b5c5b8..11e27de8e99 100644
---
a/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
+++
b/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
@@ -28,6 +28,7 @@ import java.util.LinkedHashMap;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
+import java.util.Objects;
import java.util.Set;
import java.util.UUID;
import java.util.concurrent.Executors;
@@ -3516,7 +3517,12 @@ public class NetworkOrchestrator extends ManagerBase
implements NetworkOrchestra
setRestartRequired(network, restartRequired);
return status;
} else if (livePatch) {
-List domainRouters =
routerDao.listByNetworkAndRole(network.getId(),
VirtualRouter.Role.VIRTUAL_ROUTER, VirtualRouter.Role.INTERNAL_LB_VM);
+List domainRouters;
+if (Objects.nonNull(network.getVpcId())) {
+domainRouters = routerDao.listByVpcId(network.getVpcId());
+} else {
+domainRouters =
routerDao.listByNetworkAndRole(network.getId(),
VirtualRouter.Role.VIRTUAL_ROUTER, VirtualRouter.Role.INTERNAL_LB_VM);
+}
for (DomainRouterVO router: domainRouters) {
try {
VMInstanceVO instanceVO = _vmDao.findById(router.getId());
[cloudstack] branch patch-vpc-with-non-implemented-nws deleted (was 9158057d60d)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch patch-vpc-with-non-implemented-nws in repository https://gitbox.apache.org/repos/asf/cloudstack.git was 9158057d60d VR live patching: Allow live patch of VPC VRs even if networks are in allocated / shutdown state The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7923: kvm: fix error when enable SSL for kvm agent
rohityadavcloud commented on PR #7923: URL: https://github.com/apache/cloudstack/pull/7923#issuecomment-1733907850 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7923: kvm: fix error when enable SSL for kvm agent
blueorangutan commented on PR #7923: URL: https://github.com/apache/cloudstack/pull/7923#issuecomment-1733910790 @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7345: [HEALTH] 4.18 LTS Health Check, please don't merge this!
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1733910716 @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7987: KVM Agent config to reserve dom0 CPUs
blueorangutan commented on PR #7987: URL: https://github.com/apache/cloudstack/pull/7987#issuecomment-1734035141 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch nsx-integration updated: add route advertisement
This is an automated email from the ASF dual-hosted git repository.
pearl11594 pushed a commit to branch nsx-integration
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/nsx-integration by this push:
new 33a29dce036 add route advertisement
33a29dce036 is described below
commit 33a29dce036da702f04039d003864bc70e40b33e
Author: Pearl Dsilva
AuthorDate: Mon Sep 25 12:09:14 2023 -0400
add route advertisement
---
.../main/java/org/apache/cloudstack/resource/NsxResource.java | 3 +++
.../java/org/apache/cloudstack/utils/NsxApiClientUtils.java| 10 ++
.../java/com/cloud/configuration/ConfigurationManagerImpl.java | 10 +-
ui/src/views/infra/zone/ZoneWizardLaunchZone.vue | 2 +-
ui/src/views/infra/zone/ZoneWizardNetworkSetupStep.vue | 2 +-
5 files changed, 20 insertions(+), 7 deletions(-)
diff --git
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/resource/NsxResource.java
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/resource/NsxResource.java
index 65192d00cef..f918b3f0e9f 100644
---
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/resource/NsxResource.java
+++
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/resource/NsxResource.java
@@ -63,6 +63,8 @@ import java.util.function.Function;
import java.util.stream.Collectors;
import static java.util.Objects.isNull;
+import static
org.apache.cloudstack.utils.NsxApiClientUtils.RouteAdvertisementType.TIER1_CONNECTED;
+import static
org.apache.cloudstack.utils.NsxApiClientUtils.RouteAdvertisementType.TIER1_IPSEC_LOCAL_ENDPOINT;
import static
org.apache.cloudstack.utils.NsxApiClientUtils.HAMode.ACTIVE_STANDBY;
import static
org.apache.cloudstack.utils.NsxApiClientUtils.FailoverMode.PREEMPTIVE;
import static
org.apache.cloudstack.utils.NsxApiClientUtils.PoolAllocation.ROUTING;
@@ -253,6 +255,7 @@ public class NsxResource implements ServerResource {
.setPoolAllocation(ROUTING.name())
.setHaMode(ACTIVE_STANDBY.name())
.setFailoverMode(PREEMPTIVE.name())
+.setRouteAdvertisementTypes(List.of(TIER1_CONNECTED.name(),
TIER1_IPSEC_LOCAL_ENDPOINT.name()))
.setId(name)
.setDisplayName(name)
//.setChildren(
diff --git
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/utils/NsxApiClientUtils.java
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/utils/NsxApiClientUtils.java
index 4a05122e91a..26aad6ad635 100644
---
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/utils/NsxApiClientUtils.java
+++
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/utils/NsxApiClientUtils.java
@@ -64,6 +64,16 @@ public class NsxApiClientUtils {
OVERLAY,
VLAN
}
+
+public enum RouteAdvertisementType {
+TIER1_STATIC_ROUTES,
+TIER1_CONNECTED,
+TIER1_NAT,
+TIER1_LB_VIP,
+TIER1_LB_SNAT,
+TIER1_DNS_FORWARDER_IP,
+TIER1_IPSEC_LOCAL_ENDPOINT
+}
public static ApiClient createApiClient(String hostname, String port,
String username, char[] password) {
String controllerUrl = String.format("https://%s:%s";, hostname, port);
HttpConfiguration.SslConfiguration.Builder sslConfigBuilder = new
HttpConfiguration.SslConfiguration.Builder();
diff --git
a/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
b/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
index c249c7081b0..5e0fd8d4196 100644
--- a/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
+++ b/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
@@ -2531,14 +2531,14 @@ public class ConfigurationManagerImpl extends
ManagerBase implements Configurati
}
// we should actually find the mapping and remove if it exists
// but we don't know about vmware/plugin/hypervisors at this
point
-NsxProviderVO nsxProvider =
nsxProviderDao.findByZoneId(zoneId);
-if (Objects.nonNull(nsxProvider)) {
-nsxProviderDao.remove(nsxProvider.getId());
-}
-
final boolean success = _zoneDao.remove(zoneId);
if (success) {
+NsxProviderVO nsxProvider =
nsxProviderDao.findByZoneId(zoneId);
+if (Objects.nonNull(nsxProvider)) {
+nsxProviderDao.remove(nsxProvider.getId());
+}
+
// delete template refs for this zone
templateZoneDao.deleteByZoneId(zoneId);
// delete all capacity records for the zone
diff --git a/ui/src/views/infra/zone/ZoneWizardLaunchZone.vue
b/ui/src/views/infra/zone/ZoneWi
[GitHub] [cloudstack] blueorangutan commented on pull request #7923: kvm: fix error when enable SSL for kvm agent
blueorangutan commented on PR #7923: URL: https://github.com/apache/cloudstack/pull/7923#issuecomment-1734057903 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #7919: NSX integration
Pearl1594 commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1734061726 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7919: NSX integration
blueorangutan commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1734062133 @Pearl1594 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7919: NSX integration
blueorangutan commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1734156463 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vishesh92 commented on pull request #8000: Remove powermock from pom.xml
vishesh92 commented on PR #8000: URL: https://github.com/apache/cloudstack/pull/8000#issuecomment-1734182218 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #8000: Remove powermock from pom.xml
blueorangutan commented on PR #8000: URL: https://github.com/apache/cloudstack/pull/8000#issuecomment-1734183611 @vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vishesh92 closed pull request #8000: Remove powermock from pom.xml
vishesh92 closed pull request #8000: Remove powermock from pom.xml URL: https://github.com/apache/cloudstack/pull/8000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
JoaoJandre commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1734244152 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
blueorangutan commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1734246504 @JoaoJandre a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #8000: Remove powermock from pom.xml
blueorangutan commented on PR #8000: URL: https://github.com/apache/cloudstack/pull/8000#issuecomment-1734259441 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
blueorangutan commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1734326090 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7964: Allow configkey to set 'cloud-name' cloud-init metadata
blueorangutan commented on PR #7964: URL: https://github.com/apache/cloudstack/pull/7964#issuecomment-1734408453 [SF] Trillian test result (tid-7710) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39352 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7964-t7710-xenserver-71.zip Smoke tests completed. 113 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1734413009 [SF] Trillian test result (tid-7707) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43049 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6812-t7707-xenserver-71.zip Smoke tests completed. 112 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 428.79 | test_vpc_redundant.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7964: Allow configkey to set 'cloud-name' cloud-init metadata
blueorangutan commented on PR #7964: URL: https://github.com/apache/cloudstack/pull/7964#issuecomment-1734435739 [SF] Trillian test result (tid-7712) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40535 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7964-t7712-kvm-centos7.zip Smoke tests completed. 113 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1734496519 [SF] Trillian test result (tid-7709) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47138 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6812-t7709-kvm-centos7.zip Smoke tests completed. 110 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_10_reboot_cpvm_forced | `Error` | 6.25 | test_ssvm.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 732.28 | test_kubernetes_clusters.py test_01_vpc_site2site_vpn | `Error` | 273.77 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] oscaralvaro opened a new pull request, #8001: fix units labels for max storage of volume
oscaralvaro opened a new pull request, #8001:
URL: https://github.com/apache/cloudstack/pull/8001
### Description
This PR...
Change units from Gigabyte to Gibibyte for maximum size for a volume
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] itsayushpandey commented on pull request #7712: Extend import/export unmanaged instances to KVM
itsayushpandey commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1734816087 @rohityadavcloud @DaanHoogland Apologies for the delay. I'm completing my mid term exams this week and commit the changes by end of Wednesday this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] meisammaleki commented on issue #7992: API connection issue between Cloudstack 4.17.2 and whmcs
meisammaleki commented on issue #7992: URL: https://github.com/apache/cloudstack/issues/7992#issuecomment-1734822700 We did a version upgrade from 4.13 to 4.17 around 1 month ago. After the upgrade, ACS Works fine but the Compute/instances response was a little slow. but now it can't list instances at all. I think there is a problem with DB. I think the query stuck on VM stats table -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1734827284 [SF] Trillian test result (tid-7708) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 73236 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6812-t7708-vmware-67u3.zip Smoke tests completed. 111 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_list_vms_metrics_admin | `Error` | 3616.48 | test_metrics_api.py test_list_vms_metrics_history | `Error` | 7.72 | test_metrics_api.py test_list_volumes_metrics_history | `Error` | 3616.05 | test_metrics_api.py test_01_deploy_vm_on_specific_host | `Error` | 3602.67 | test_vm_deployment_planner.py test_02_deploy_vm_on_specific_cluster | `Error` | 18.72 | test_vm_deployment_planner.py test_03_deploy_vm_on_specific_pod | `Error` | 3601.80 | test_vm_deployment_planner.py test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 1.35 | test_vm_deployment_planner.py test_05_deploy_vm_on_cluster_override_pod | `Error` | 4.40 | test_vm_deployment_planner.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] kiranchavala commented on pull request #7858: Keep deleted projects name
kiranchavala commented on PR #7858: URL: https://github.com/apache/cloudstack/pull/7858#issuecomment-1734894524 @DaanHoogland I have tested the corner cases and its working fine 1. recreating a project with the same name 2. search functionality -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #7946: Default Domain Admin role not working after migration
DaanHoogland commented on issue #7946: URL: https://github.com/apache/cloudstack/issues/7946#issuecomment-1734912622 I can give you a dump of the role and role permission tables of a stock lab environment, but other than that, yes, I think closing is the most expedient course of action ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vishesh92 opened a new pull request, #8002: fix: cleanup directory if empty after removal of snapshot
vishesh92 opened a new pull request, #8002:
URL: https://github.com/apache/cloudstack/pull/8002
### Description
This PR removes the directory of snapshot if it's empty after removal of
snapshot.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[cloudstack] branch contributers updated (9f5b2ef9925 -> 3e196c18245)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch contributers in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 9f5b2ef9925 contributor-howto add 3e196c18245 style No new revisions were added by this update. Summary of changes: README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[GitHub] [cloudstack] alamintech commented on issue #7961: Multicast traffic problem
alamintech commented on issue #7961: URL: https://github.com/apache/cloudstack/issues/7961#issuecomment-1734925946 now ACS 4.18.1 version is running, This version is enable IGMP by default? or any other settings needed. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7858: Keep deleted projects name
DaanHoogland commented on PR #7858: URL: https://github.com/apache/cloudstack/pull/7858#issuecomment-1734932250 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7858: Keep deleted projects name
blueorangutan commented on PR #7858: URL: https://github.com/apache/cloudstack/pull/7858#issuecomment-1734933115 @DaanHoogland a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
