Re: [PR] add procedures procedure [cloudstack]
blueorangutan commented on PR #9385: URL: https://github.com/apache/cloudstack/pull/9385#issuecomment-2227233633 [SF] Trillian test result (tid-10821) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43258 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9385-t10821-kvm-centos7.zip Smoke tests completed. 131 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_condensed_drs_algorithm | `Failure` | 173.39 | test_cluster_drs.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IPv4 Static Routing (Routed mode) [cloudstack]
weizhouapache commented on PR #9346: URL: https://github.com/apache/cloudstack/pull/9346#issuecomment-2227234702 @blueorangutan test rocky8 vmware-80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IPv4 Static Routing (Routed mode) [cloudstack]
blueorangutan commented on PR #9346: URL: https://github.com/apache/cloudstack/pull/9346#issuecomment-2227235523 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + vmware-80) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Ignore non-managed pools for storage pool access preparation [cloudstack]
sureshanaparti merged PR #9376: URL: https://github.com/apache/cloudstack/pull/9376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: Ignore non-managed pools for storage pool access preparation (#9376)
This is an automated email from the ASF dual-hosted git repository.
sureshanaparti pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new d9f77b841c5 Ignore non-managed pools for storage pool access
preparation (#9376)
d9f77b841c5 is described below
commit d9f77b841c5c19d92bea82caf65e9adbf18fbe00
Author: Suresh Kumar Anaparti
AuthorDate: Sun Jul 14 14:50:26 2024 +0530
Ignore non-managed pools for storage pool access preparation (#9376)
---
server/src/main/java/com/cloud/storage/StorageManagerImpl.java | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
b/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
index 74b19b61fd4..73b9ac8960d 100644
--- a/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
+++ b/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
@@ -2788,14 +2788,10 @@ public class StorageManagerImpl extends ManagerBase
implements StorageManager, C
@Override
public boolean canHostPrepareStoragePoolAccess(Host host, StoragePool
pool) {
-if (host == null || pool == null) {
+if (host == null || pool == null || !pool.isManaged()) {
return false;
}
-if (!pool.isManaged()) {
-return true;
-}
-
DataStoreProvider storeProvider =
_dataStoreProviderMgr.getDataStoreProvider(pool.getStorageProviderName());
DataStoreDriver storeDriver = storeProvider.getDataStoreDriver();
return storeDriver instanceof PrimaryDataStoreDriver &&
((PrimaryDataStoreDriver)storeDriver).canHostPrepareStoragePoolAccess(host,
pool);
Re: [I] CPVM/SSVM fails to start on KVM/Ubuntu 22.04 with 4.19.1 RC1 using local storage [cloudstack]
sureshanaparti closed issue #9371: CPVM/SSVM fails to start on KVM/Ubuntu 22.04 with 4.19.1 RC1 using local storage URL: https://github.com/apache/cloudstack/issues/9371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] CPVM/SSVM fails to start on KVM/Ubuntu 22.04 with 4.19.1 RC1 using local storage [cloudstack]
sureshanaparti commented on issue #9371: URL: https://github.com/apache/cloudstack/issues/9371#issuecomment-2227278376 Fixed in #9376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix snapshot deletion on template creation failure [cloudstack]
sureshanaparti commented on PR #9239: URL: https://github.com/apache/cloudstack/pull/9239#issuecomment-2227278734 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix snapshot deletion on template creation failure [cloudstack]
blueorangutan commented on PR #9239: URL: https://github.com/apache/cloudstack/pull/9239#issuecomment-2227278975 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine-schema,cks: fix finding non-removed network vms [cloudstack]
sureshanaparti commented on PR #9339: URL: https://github.com/apache/cloudstack/pull/9339#issuecomment-2227279267 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine-schema,cks: fix finding non-removed network vms [cloudstack]
blueorangutan commented on PR #9339: URL: https://github.com/apache/cloudstack/pull/9339#issuecomment-2227279473 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix: Switch back to CLOUD_DB after purging usage records [cloudstack]
sureshanaparti merged PR #9367: URL: https://github.com/apache/cloudstack/pull/9367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.18 updated: Switch back to CLOUD_DB after purging usage records (#9367)
This is an automated email from the ASF dual-hosted git repository.
sureshanaparti pushed a commit to branch 4.18
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.18 by this push:
new 22ef08154dc Switch back to CLOUD_DB after purging usage records (#9367)
22ef08154dc is described below
commit 22ef08154dc89ccce27121578cabfa3b5030220d
Author: Vishesh
AuthorDate: Sun Jul 14 14:58:36 2024 +0530
Switch back to CLOUD_DB after purging usage records (#9367)
---
.../java/com/cloud/usage/dao/UsageDaoImpl.java | 35 --
1 file changed, 20 insertions(+), 15 deletions(-)
diff --git a/engine/schema/src/main/java/com/cloud/usage/dao/UsageDaoImpl.java
b/engine/schema/src/main/java/com/cloud/usage/dao/UsageDaoImpl.java
index 4553ed822b4..038d17a85a3 100644
--- a/engine/schema/src/main/java/com/cloud/usage/dao/UsageDaoImpl.java
+++ b/engine/schema/src/main/java/com/cloud/usage/dao/UsageDaoImpl.java
@@ -28,6 +28,7 @@ import com.cloud.utils.db.QueryBuilder;
import com.cloud.utils.db.SearchCriteria;
import com.cloud.utils.db.Transaction;
import com.cloud.utils.db.TransactionCallback;
+import com.cloud.utils.db.TransactionCallbackNoReturn;
import com.cloud.utils.db.TransactionLegacy;
import com.cloud.utils.db.TransactionStatus;
import com.cloud.utils.exception.CloudRuntimeException;
@@ -469,21 +470,25 @@ public class UsageDaoImpl extends GenericDaoBase implements Usage
@Override
public void removeOldUsageRecords(int days) {
-String sql = DELETE_ALL_BY_INTERVAL;
-TransactionLegacy txn =
TransactionLegacy.open(TransactionLegacy.USAGE_DB);
-PreparedStatement pstmt = null;
-try {
-txn.start();
-pstmt = txn.prepareAutoCloseStatement(sql);
-pstmt.setLong(1, days);
-pstmt.executeUpdate();
-txn.commit();
-} catch (Exception ex) {
-txn.rollback();
-s_logger.error("error removing old cloud_usage records for
interval: " + days);
-} finally {
-txn.close();
-}
+Transaction.execute(TransactionLegacy.USAGE_DB, new
TransactionCallbackNoReturn() {
+@Override
+public void doInTransactionWithoutResult(TransactionStatus status)
{
+TransactionLegacy txn = TransactionLegacy.currentTxn();
+PreparedStatement pstmt = null;
+try {
+txn.start();
+pstmt =
txn.prepareAutoCloseStatement(DELETE_ALL_BY_INTERVAL);
+pstmt.setLong(1, days);
+pstmt.executeUpdate();
+txn.commit();
+} catch (Exception ex) {
+txn.rollback();
+s_logger.error("error removing old cloud_usage records for
interval: " + days);
+} finally {
+txn.close();
+}
+}
+});
}
public UsageVO persistUsage(final UsageVO usage) {
Re: [PR] saml: purge token after first response and improve setting description [cloudstack]
sureshanaparti commented on PR #9377: URL: https://github.com/apache/cloudstack/pull/9377#issuecomment-2227281241 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] saml: purge token after first response and improve setting description [cloudstack]
blueorangutan commented on PR #9377: URL: https://github.com/apache/cloudstack/pull/9377#issuecomment-2227281376 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Refactor KubernetesClusterResourceModifierActionWorker [cloudstack]
blueorangutan commented on PR #8801: URL: https://github.com/apache/cloudstack/pull/8801#issuecomment-2227292603 [SF] Trillian test result (tid-10825) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 50289 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8801-t10825-kvm-alma9.zip Smoke tests completed. 137 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix snapshot deletion on template creation failure [cloudstack]
blueorangutan commented on PR #9239: URL: https://github.com/apache/cloudstack/pull/9239#issuecomment-2227295207 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [4.20] VR: fix issue if userdata is binary data [cloudstack]
blueorangutan commented on PR #8739: URL: https://github.com/apache/cloudstack/pull/8739#issuecomment-2227296056 [SF] Trillian test result (tid-10823) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 51389 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8739-t10823-kvm-alma9.zip Smoke tests completed. 136 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_06_purge_expunged_vm_background_task | `Failure` | 332.40 | test_purge_expunged_vms.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine-schema,cks: fix finding non-removed network vms [cloudstack]
blueorangutan commented on PR #9339: URL: https://github.com/apache/cloudstack/pull/9339#issuecomment-2227296117 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Quota tariff order [cloudstack]
blueorangutan commented on PR #8347: URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2227297553 [SF] Trillian test result (tid-10824) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 51626 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8347-t10824-kvm-alma9.zip Smoke tests completed. 136 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_06_purge_expunged_vm_background_task | `Failure` | 337.45 | test_purge_expunged_vms.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add procedures procedure [cloudstack]
DaanHoogland commented on PR #9385: URL: https://github.com/apache/cloudstack/pull/9385#issuecomment-2227359602 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add procedures procedure [cloudstack]
blueorangutan commented on PR #9385: URL: https://github.com/apache/cloudstack/pull/9385#issuecomment-2227360358 @DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Refactor KubernetesClusterResourceModifierActionWorker [cloudstack]
DaanHoogland merged PR #8801: URL: https://github.com/apache/cloudstack/pull/8801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Refactor KubernetesClusterResourceModifierActionWorker [cloudstack]
boring-cyborg[bot] commented on PR #8801: URL: https://github.com/apache/cloudstack/pull/8801#issuecomment-2227360372 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated: Refactor KubernetesClusterResourceModifierActionWorker (#8801)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new a87778be9a4 Refactor KubernetesClusterResourceModifierActionWorker
(#8801)
a87778be9a4 is described below
commit a87778be9a41182719d8435869b18598abda0932
Author: Felipe <124818914+felipem...@users.noreply.github.com>
AuthorDate: Sun Jul 14 11:02:04 2024 -0300
Refactor KubernetesClusterResourceModifierActionWorker (#8801)
Co-authored-by: dahn
---
.../user/firewall/CreateFirewallRuleCmd.java | 24 +++
.../command/user/network/CreateNetworkACLCmd.java | 31 +++-
.../cloudstack/api/command/user/vm/StartVMCmd.java | 4 +
.../api/command/user/volume/ResizeVolumeCmd.java | 8 +
...ernetesClusterResourceModifierActionWorker.java | 199 ++---
.../cloud/network/vpc/NetworkACLServiceImpl.java | 4 +-
6 files changed, 158 insertions(+), 112 deletions(-)
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
index 24b5a78c085..56c818f832b 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
@@ -94,11 +94,35 @@ public class CreateFirewallRuleCmd extends
BaseAsyncCreateCmd implements Firewal
return ipAddressId;
}
+public void setIpAddressId(Long ipAddressId) {
+this.ipAddressId = ipAddressId;
+}
+
@Override
public String getProtocol() {
return protocol.trim();
}
+public void setProtocol(String protocol) {
+this.protocol = protocol;
+}
+
+public Integer getPublicStartPort() {
+return publicStartPort;
+}
+
+public void setPublicStartPort(Integer publicStartPort) {
+this.publicStartPort = publicStartPort;
+}
+
+public Integer getPublicEndPort() {
+return publicEndPort;
+}
+
+public void setPublicEndPort(Integer publicEndPort) {
+this.publicEndPort = publicEndPort;
+}
+
@Override
public List getSourceCidrList() {
if (cidrlist != null) {
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkACLCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkACLCmd.java
index 127661b1820..8d8e598bcab 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkACLCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkACLCmd.java
@@ -113,6 +113,10 @@ public class CreateNetworkACLCmd extends
BaseAsyncCreateCmd {
return p;
}
+public void setProtocol(String protocol) {
+this.protocol = protocol;
+}
+
public List getSourceCidrList() {
if (cidrlist != null) {
return cidrlist;
@@ -136,6 +140,9 @@ public class CreateNetworkACLCmd extends BaseAsyncCreateCmd
{
throw new InvalidParameterValueException("Invalid traffic type " +
trafficType);
}
+public void setTrafficType(String trafficType) {
+this.trafficType = trafficType;
+}
// ///
// / API Implementation///
// ///
@@ -144,15 +151,23 @@ public class CreateNetworkACLCmd extends
BaseAsyncCreateCmd {
return action;
}
+public void setAction(String action) {
+this.action = action;
+}
+
public Integer getNumber() {
return number;
}
-public Integer getSourcePortStart() {
+public Integer getPublicStartPort() {
return publicStartPort;
}
-public Integer getSourcePortEnd() {
+public void setPublicStartPort(Integer publicStartPort) {
+this.publicStartPort = publicStartPort;
+}
+
+public Integer getPublicEndPort() {
if (publicEndPort == null) {
if (publicStartPort != null) {
return publicStartPort;
@@ -164,10 +179,18 @@ public class CreateNetworkACLCmd extends
BaseAsyncCreateCmd {
return null;
}
+public void setPublicEndPort(Integer publicEndPort) {
+this.publicEndPort = publicEndPort;
+}
+
public Long getNetworkId() {
return networkId;
}
+public void setNetworkId(Long networkId) {
+this.networkId = networkId;
+}
+
@Override
public long getEntityOwnerId() {
Account caller = CallContext.current().getCallingAccount();
@@ -207,6 +230,10 @@ public class CreateNetworkACLCmd extends
BaseAsyncCreateCmd {
return aclId;
}
+public void setAclId(Long acl
Re: [PR] Quota tariff order [cloudstack]
DaanHoogland merged PR #8347: URL: https://github.com/apache/cloudstack/pull/8347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated: Quota tariff order (#8347)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new b9c7275c253 Quota tariff order (#8347)
b9c7275c253 is described below
commit b9c7275c2539a9e7a7de803eb2173ab61e0723f2
Author: João Jandre <48719461+joaojan...@users.noreply.github.com>
AuthorDate: Sun Jul 14 11:05:15 2024 -0300
Quota tariff order (#8347)
---
.../resources/META-INF/db/schema-41910to42000.sql | 4 +
.../apache/cloudstack/quota/QuotaManagerImpl.java | 20 ++-
.../activationrule/presetvariables/Tariff.java | 33
.../apache/cloudstack/quota/vo/QuotaTariffVO.java | 14 ++
.../cloudstack/quota/QuotaManagerImplTest.java | 53 +--
.../api/command/QuotaTariffCreateCmd.java | 12 ++
.../api/command/QuotaTariffUpdateCmd.java | 12 ++
.../api/response/QuotaResponseBuilderImpl.java | 18 ++-
.../api/response/QuotaTariffResponse.java | 13 ++
.../api/response/QuotaResponseBuilderImplTest.java | 18 ++-
.../integration/plugins/test_quota_tariff_order.py | 175 +
11 files changed, 351 insertions(+), 21 deletions(-)
diff --git
a/engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql
b/engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql
index 295ad147a99..f59eda5c06c 100644
--- a/engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql
+++ b/engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql
@@ -150,3 +150,7 @@ SET
WHERE
name IN ("quota.usage.smtp.useStartTLS", "quota.usage.smtp.useAuth",
"alert.smtp.useAuth", "project.smtp.useAuth")
AND value NOT IN ("true", "y", "t", "1", "on", "yes");
+
+
+-- Quota inject tariff result into subsequent ones
+CALL `cloud_usage`.`IDEMPOTENT_ADD_COLUMN`('cloud_usage.quota_tariff',
'position', 'bigint(20) NOT NULL DEFAULT 1 COMMENT "Position in the execution
sequence for tariffs of the same type"');
diff --git
a/framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaManagerImpl.java
b/framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaManagerImpl.java
index ded35338aea..226a47bb7df 100644
---
a/framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaManagerImpl.java
+++
b/framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaManagerImpl.java
@@ -20,6 +20,7 @@ import java.math.BigDecimal;
import java.math.RoundingMode;
import java.util.ArrayList;
import java.util.Arrays;
+import java.util.Comparator;
import java.util.Date;
import java.util.HashMap;
import java.util.LinkedHashSet;
@@ -36,6 +37,7 @@ import
org.apache.cloudstack.framework.config.dao.ConfigurationDao;
import
org.apache.cloudstack.quota.activationrule.presetvariables.GenericPresetVariable;
import
org.apache.cloudstack.quota.activationrule.presetvariables.PresetVariableHelper;
import
org.apache.cloudstack.quota.activationrule.presetvariables.PresetVariables;
+import org.apache.cloudstack.quota.activationrule.presetvariables.Tariff;
import org.apache.cloudstack.quota.constant.QuotaConfig;
import org.apache.cloudstack.quota.constant.QuotaTypes;
import org.apache.cloudstack.quota.dao.QuotaAccountDao;
@@ -371,9 +373,22 @@ public class QuotaManagerImpl extends ManagerBase
implements QuotaManager {
PresetVariables presetVariables =
getPresetVariables(hasAnyQuotaTariffWithActivationRule, usageRecord);
BigDecimal aggregatedQuotaTariffsValue = BigDecimal.ZERO;
+quotaTariffs.sort(Comparator.comparing(QuotaTariffVO::getPosition));
+
+List lastTariffs = new ArrayList<>();
+
+
for (QuotaTariffVO quotaTariff : quotaTariffs) {
if (isQuotaTariffInPeriodToBeApplied(usageRecord, quotaTariff,
accountToString)) {
-aggregatedQuotaTariffsValue =
aggregatedQuotaTariffsValue.add(getQuotaTariffValueToBeApplied(quotaTariff,
jsInterpreter, presetVariables));
+
+BigDecimal tariffValue =
getQuotaTariffValueToBeApplied(quotaTariff, jsInterpreter, presetVariables,
lastTariffs);
+
+aggregatedQuotaTariffsValue =
aggregatedQuotaTariffsValue.add(tariffValue);
+
+Tariff tariffPresetVariable = new Tariff();
+tariffPresetVariable.setId(quotaTariff.getUuid());
+tariffPresetVariable.setValue(tariffValue);
+lastTariffs.add(tariffPresetVariable);
}
}
@@ -401,7 +416,7 @@ public class QuotaManagerImpl extends ManagerBase
implements QuotaManager {
* If the activation rule result in something else, returns {@link
BigDecimal#ZERO}.
*
*/
-protected BigDecimal getQuotaTariffValueToBeApplied(QuotaTariffVO
quotaTariff, JsInterpreter jsInterpreter, PresetVariables presetVariables) {
+protected BigDecimal getQuotaTariffValueToBeApplied(QuotaTariffVO
quotaTariff, JsInterprete
Re: [PR] add procedures procedure [cloudstack]
blueorangutan commented on PR #9385: URL: https://github.com/apache/cloudstack/pull/9385#issuecomment-2227367635 [SF] Trillian Build Failed (tid-10830) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IPv4 Static Routing (Routed mode) [cloudstack]
weizhouapache commented on PR #9346: URL: https://github.com/apache/cloudstack/pull/9346#issuecomment-2227428327 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IPv4 Static Routing (Routed mode) [cloudstack]
blueorangutan commented on PR #9346: URL: https://github.com/apache/cloudstack/pull/9346#issuecomment-2227428812 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IPv4 Static Routing (Routed mode) [cloudstack]
blueorangutan commented on PR #9346: URL: https://github.com/apache/cloudstack/pull/9346#issuecomment-2227429208 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix snapshot deletion on template creation failure [cloudstack]
sureshanaparti commented on PR #9239: URL: https://github.com/apache/cloudstack/pull/9239#issuecomment-2227449925 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix snapshot deletion on template creation failure [cloudstack]
blueorangutan commented on PR #9239: URL: https://github.com/apache/cloudstack/pull/9239#issuecomment-2227450019 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KVM incremental snapshot feature [cloudstack]
github-actions[bot] commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2227450810 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support user resource name / displaytext with emoji, unicode chars, and some sql exception msg improvements [cloudstack]
github-actions[bot] commented on PR #9340: URL: https://github.com/apache/cloudstack/pull/9340#issuecomment-2227450813 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] LibvirtOvsFetchInterfaceCommandWrapperTest fix (test fails in mac) - skip it if no interfaces with eth and wl [cloudstack]
sureshanaparti commented on PR #9382: URL: https://github.com/apache/cloudstack/pull/9382#issuecomment-2227457676 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] LibvirtOvsFetchInterfaceCommandWrapperTest fix (test fails in mac) - skip it if no interfaces with eth and wl [cloudstack]
blueorangutan commented on PR #9382: URL: https://github.com/apache/cloudstack/pull/9382#issuecomment-2227458185 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] LibvirtOvsFetchInterfaceCommandWrapperTest fix (test fails in mac) - skip it if no interfaces with eth and wl [cloudstack]
sureshanaparti merged PR #9382: URL: https://github.com/apache/cloudstack/pull/9382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.18 updated: LibvirtOvsFetchInterfaceCommandWrapperTest fix (test fails in mac) - skip it if no interfaces with eth and wl (#9382)
This is an automated email from the ASF dual-hosted git repository.
sureshanaparti pushed a commit to branch 4.18
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.18 by this push:
new 877c4d9a64b LibvirtOvsFetchInterfaceCommandWrapperTest fix (test fails
in mac) - skip it if no interfaces with eth and wl (#9382)
877c4d9a64b is described below
commit 877c4d9a64b11ec1a692d5afd1cad9f6d17dab75
Author: Suresh Kumar Anaparti
AuthorDate: Mon Jul 15 00:56:23 2024 +0530
LibvirtOvsFetchInterfaceCommandWrapperTest fix (test fails in mac) - skip
it if no interfaces with eth and wl (#9382)
* test fix (fails in mac) - skip it if no interfaces with eth and wl
* review comments
---
.../wrapper/LibvirtOvsFetchInterfaceCommandWrapperTest.java | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
a/plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsFetchInterfaceCommandWrapperTest.java
b/plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsFetchInterfaceCommandWrapperTest.java
index fbc9c2bcb4b..b0df5519467 100644
---
a/plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsFetchInterfaceCommandWrapperTest.java
+++
b/plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsFetchInterfaceCommandWrapperTest.java
@@ -26,6 +26,7 @@ import java.util.List;
import java.util.UUID;
import org.junit.Assert;
+import org.junit.Assume;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Spy;
@@ -51,8 +52,7 @@ public class LibvirtOvsFetchInterfaceCommandWrapperTest {
while(interfaces.hasMoreElements()) {
NetworkInterface networkInterface = interfaces.nextElement();
if (networkInterface.getInetAddresses().hasMoreElements() &&
-(networkInterface.getName().startsWith("eth") ||
-networkInterface.getName().startsWith("wl"))) {
+networkInterface.getName().matches("^(eth|wl|en).*")) {
interfaceName = networkInterface.getName();
Enumeration addresses =
networkInterface.getInetAddresses();
while(addresses.hasMoreElements()) {
@@ -62,9 +62,13 @@ public class LibvirtOvsFetchInterfaceCommandWrapperTest {
break;
};
}
+if (StringUtils.isNotBlank(interfaceName) &&
StringUtils.isNotBlank(ipAddress)) {
+break;
+}
}
}
} catch (SocketException ignored) {}
+Assume.assumeTrue(StringUtils.isNotBlank(interfaceName));
Ternary result = null;
try {
result = wrapper.getInterfaceDetails(interfaceName);
(cloudstack) branch 4.19 updated (d9f77b841c5 -> 7f8f1137099)
This is an automated email from the ASF dual-hosted git repository. sureshanaparti pushed a change to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from d9f77b841c5 Ignore non-managed pools for storage pool access preparation (#9376) add 22ef08154dc Switch back to CLOUD_DB after purging usage records (#9367) add 877c4d9a64b LibvirtOvsFetchInterfaceCommandWrapperTest fix (test fails in mac) - skip it if no interfaces with eth and wl (#9382) new 7f8f1137099 Merge branch '4.18' into 4.19 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../java/com/cloud/usage/dao/UsageDaoImpl.java | 35 -- ...LibvirtOvsFetchInterfaceCommandWrapperTest.java | 8 +++-- 2 files changed, 26 insertions(+), 17 deletions(-)
(cloudstack) 01/01: Merge branch '4.18' into 4.19
This is an automated email from the ASF dual-hosted git repository. sureshanaparti pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 7f8f113709983cf088a684be8d149c62264f8afc Merge: d9f77b841c5 877c4d9a64b Author: Suresh Kumar Anaparti AuthorDate: Mon Jul 15 00:59:06 2024 +0530 Merge branch '4.18' into 4.19 .../java/com/cloud/usage/dao/UsageDaoImpl.java | 35 -- ...LibvirtOvsFetchInterfaceCommandWrapperTest.java | 8 +++-- 2 files changed, 26 insertions(+), 17 deletions(-)
(cloudstack) branch healthcheck-4.19 updated (bba7abf9ef6 -> 2e81d15873f)
This is an automated email from the ASF dual-hosted git repository. sureshanaparti pushed a change to branch healthcheck-4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard bba7abf9ef6 DO NOT MERGE add c71ab9598e3 test: refactor ActionEventInterceptorTest to prevent failures (#9384) add d9f77b841c5 Ignore non-managed pools for storage pool access preparation (#9376) add 22ef08154dc Switch back to CLOUD_DB after purging usage records (#9367) add 877c4d9a64b LibvirtOvsFetchInterfaceCommandWrapperTest fix (test fails in mac) - skip it if no interfaces with eth and wl (#9382) add 7f8f1137099 Merge branch '4.18' into 4.19 add 2e81d15873f DO NOT MERGE This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (bba7abf9ef6) \ N -- N -- N refs/heads/healthcheck-4.19 (2e81d15873f) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../java/com/cloud/usage/dao/UsageDaoImpl.java | 35 ++ ...LibvirtOvsFetchInterfaceCommandWrapperTest.java | 8 +++-- .../java/com/cloud/storage/StorageManagerImpl.java | 6 +--- .../cloud/event/ActionEventInterceptorTest.java| 41 +++--- 4 files changed, 48 insertions(+), 42 deletions(-)
(cloudstack) branch healthcheck-4.18 updated (770e4fda424 -> 73d04be40c1)
This is an automated email from the ASF dual-hosted git repository. sureshanaparti pushed a change to branch healthcheck-4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard 770e4fda424 DO NOT MERGE add 22ef08154dc Switch back to CLOUD_DB after purging usage records (#9367) add 877c4d9a64b LibvirtOvsFetchInterfaceCommandWrapperTest fix (test fails in mac) - skip it if no interfaces with eth and wl (#9382) add 73d04be40c1 DO NOT MERGE This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (770e4fda424) \ N -- N -- N refs/heads/healthcheck-4.18 (73d04be40c1) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../java/com/cloud/usage/dao/UsageDaoImpl.java | 35 -- ...LibvirtOvsFetchInterfaceCommandWrapperTest.java | 8 +++-- 2 files changed, 26 insertions(+), 17 deletions(-)
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
sureshanaparti commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2227460620 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]
sureshanaparti commented on PR #9317: URL: https://github.com/apache/cloudstack/pull/9317#issuecomment-2227460700 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9317: URL: https://github.com/apache/cloudstack/pull/9317#issuecomment-2227461081 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2227461087 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IPv4 Static Routing (Routed mode) [cloudstack]
blueorangutan commented on PR #9346: URL: https://github.com/apache/cloudstack/pull/9346#issuecomment-2227468968 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] LibvirtOvsFetchInterfaceCommandWrapperTest fix (test fails in mac) - skip it if no interfaces with eth and wl [cloudstack]
blueorangutan commented on PR #9382: URL: https://github.com/apache/cloudstack/pull/9382#issuecomment-2227473785 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9317: URL: https://github.com/apache/cloudstack/pull/9317#issuecomment-2227476238 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2227476237 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
sureshanaparti commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2227476749 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
sureshanaparti commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2227477147 @blueorangutan test alma8 kvm-alma8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]
sureshanaparti commented on PR #9317: URL: https://github.com/apache/cloudstack/pull/9317#issuecomment-2227477288 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9317: URL: https://github.com/apache/cloudstack/pull/9317#issuecomment-2227477470 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2227477473 @sureshanaparti a [SL] Trillian-Jenkins test job (alma8 mgmt + kvm-alma8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2227478692 [SF] Trillian Build Failed (tid-10836) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IPv4 Static Routing (Routed mode) [cloudstack]
blueorangutan commented on PR #9346: URL: https://github.com/apache/cloudstack/pull/9346#issuecomment-2227510880 [SF] Trillian test result (tid-10826) Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8 Total time taken: 51766 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9346-t10826-vmware-80.zip Smoke tests completed. 135 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_deploy_more_vms_than_limit_allows | `Error` | 134.06 | test_deploy_vms_in_parallel.py test_06_purge_expunged_vm_background_task | `Failure` | 341.39 | test_purge_expunged_vms.py test_02_restore_vm_with_disk_offering | `Error` | 65.33 | test_restore_vm.py test_03_restore_vm_with_disk_offering_custom_size | `Error` | 57.10 | test_restore_vm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] saml: purge token after first response and improve setting description [cloudstack]
blueorangutan commented on PR #9377: URL: https://github.com/apache/cloudstack/pull/9377#issuecomment-2227512002 [SF] Trillian test result (tid-10827) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47305 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9377-t10827-kvm-centos7.zip Smoke tests completed. 132 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add procedures procedure [cloudstack]
blueorangutan commented on PR #9385: URL: https://github.com/apache/cloudstack/pull/9385#issuecomment-2227626566 [SF] Trillian test result (tid-10828) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45251 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9385-t10828-xenserver-71.zip Smoke tests completed. 132 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI assorted fixes [cloudstack]
rohityadavcloud commented on PR #9381: URL: https://github.com/apache/cloudstack/pull/9381#issuecomment-2227667398 @DaanHoogland as the copy button isn't what most people want (they could just click the console button), I find that duplicated and annoying; so only keep the button in the actions button-bar. The info card is supposed for quick/common use-case so console button is still there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] UI: Network 'not found' when displaynetwork=false even when logged in as admin [cloudstack]
rohityadavcloud commented on issue #9386: URL: https://github.com/apache/cloudstack/issues/9386#issuecomment-2227670033 @kohrar this is by design; you need to pass the `displaynetwork=true` in the cmk/API which only the root-admin can pass. As a UI hack you can in the network URL, pass this; for example: http://:8080/client/#/guestnetwork?page=1&pagesize=20&displaynetwork=true -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Copy console UI button does not work [cloudstack]
rohityadavcloud closed issue #9368: Copy console UI button does not work URL: https://github.com/apache/cloudstack/issues/9368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI assorted fixes [cloudstack]
rohityadavcloud merged PR #9381: URL: https://github.com/apache/cloudstack/pull/9381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: UI assorted fixes (#9381)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new 50586a94816 UI assorted fixes (#9381)
50586a94816 is described below
commit 50586a948165a995a64e1bfe40e2ee6e6fb4c595
Author: Rohit Yadav
AuthorDate: Mon Jul 15 09:44:39 2024 +0530
UI assorted fixes (#9381)
* config.json: make configuration names consistent with other
Makes login related config param to be consistent with the original
`loginFooter`. Group them together.
Signed-off-by: Rohit Yadav
* ui: assorted UI fixes and copy console URL fix
This brings in related buttons across some infra views and new columns
which are missing. Also fixes the copy console URL issue on some
browsers.
Signed-off-by: Rohit Yadav
-
Signed-off-by: Rohit Yadav
---
ui/public/config.json| 4 ++--
ui/public/index.html | 4 ++--
ui/public/locales/en.json| 1 +
ui/src/components/view/InfoCard.vue | 12
ui/src/components/widgets/Console.vue| 9 +
ui/src/config/section/account.js | 24
ui/src/config/section/domain.js | 16
ui/src/config/section/infra/hosts.js | 2 +-
ui/src/config/section/infra/managementServers.js | 4 ++--
9 files changed, 49 insertions(+), 27 deletions(-)
diff --git a/ui/public/config.json b/ui/public/config.json
index 57d120aed5e..639ed4f97f1 100644
--- a/ui/public/config.json
+++ b/ui/public/config.json
@@ -10,12 +10,12 @@
"docBase": "http://docs.cloudstack.apache.org/en/latest";,
"appTitle": "CloudStack",
"footer": "Licensed under the Apache License, Version 2.0.",
+ "loginTitle": "CloudStack",
+ "loginFavicon": "assets/logo.svg",
"loginFooter": "",
"logo": "assets/logo.svg",
"minilogo": "assets/mini-logo.svg",
"banner": "assets/banner.svg",
- "loginPageTitle": "CloudStack",
- "loginPageFavicon": "assets/logo.svg",
"error": {
"403": "assets/403.png",
"404": "assets/404.png",
diff --git a/ui/public/index.html b/ui/public/index.html
index 1a09e46a4e0..0e6521418cb 100644
--- a/ui/public/index.html
+++ b/ui/public/index.html
@@ -58,8 +58,8 @@
fetch('./config.json')
.then(response => response.json())
.then(data => {
-document.getElementById("favicon").setAttribute("href",
data.loginPageFavicon);
-document.getElementById("title").innerHTML = data.loginPageTitle;
+document.getElementById("favicon").setAttribute("href",
data.loginFavicon);
+document.getElementById("title").innerHTML = data.loginTitle;
}).catch((err) => {});
diff --git a/ui/public/locales/en.json b/ui/public/locales/en.json
index c5d87d208b4..3931dae598f 100644
--- a/ui/public/locales/en.json
+++ b/ui/public/locales/en.json
@@ -1891,6 +1891,7 @@
"label.service.connectivity.distributedroutercapabilitycheckbox": "Distributed
router",
"label.service.connectivity.regionlevelvpccapabilitycheckbox": "Region level
VPC",
"label.service.group": "Service group",
+"label.serviceip": "Service IP",
"label.service.lb.elasticlbcheckbox": "Elastic LB",
"label.service.lb.inlinemodedropdown": "Mode",
"label.service.lb.lbisolationdropdown": "LB isolation",
diff --git a/ui/src/components/view/InfoCard.vue
b/ui/src/components/view/InfoCard.vue
index 6a0329ada8f..bb6726d75f1 100644
--- a/ui/src/components/view/InfoCard.vue
+++ b/ui/src/components/view/InfoCard.vue
@@ -104,18 +104,6 @@
v-if="resource.id"
/>
-
-
- {{ $t('label.copy.consoleurl') }}
-
-
-
diff --git a/ui/src/components/widgets/Console.vue
b/ui/src/components/widgets/Console.vue
index ae0a034de02..6c16c7546a7 100644
--- a/ui/src/components/widgets/Console.vue
+++ b/ui/src/components/widgets/Console.vue
@@ -56,17 +56,10 @@ export default {
this.url = (json && json.createconsoleendpointresponse) ?
json.createconsoleendpointresponse.consoleendpoint.url : '#/exception/404'
if (json.createconsoleendpointresponse.consoleendpoint.success) {
if (this.copyUrlToClipboard) {
+this.$copyText(this.url)
this.$message.success({
content: this.$t('label.copied.clipboard')
})
-const hiddenElement = document.createElement('textarea')
-hiddenElement.value = this.url
-document.body.appendChild(hiddenElement)
-hiddenElement.focus()
-hiddenElement.select()
-
-document.execCommand('copy')
-document.body.removeChild(hidd
Re: [I] Copy console UI button does not work [cloudstack]
rohityadavcloud closed issue #9368: Copy console UI button does not work URL: https://github.com/apache/cloudstack/issues/9368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] saml: purge token after first response and improve setting description [cloudstack]
rohityadavcloud merged PR #9377: URL: https://github.com/apache/cloudstack/pull/9377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: saml: purge token after first response and improve setting description (#9377)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new 2cfb541a1d7 saml: purge token after first response and improve setting
description (#9377)
2cfb541a1d7 is described below
commit 2cfb541a1d7875d1beb25b2199303683d472ddcd
Author: Rohit Yadav
AuthorDate: Mon Jul 15 09:45:28 2024 +0530
saml: purge token after first response and improve setting description
(#9377)
* saml: purge token after first response and improve setting description
This improves the description of a saml signature checking global
setting, and purges the SAML token upon handling the first SAML
response.
Signed-off-by: Rohit Yadav
* fix failing unit test
Signed-off-by: Rohit Yadav
-
Signed-off-by: Rohit Yadav
---
.../api/command/SAML2LoginAPIAuthenticatorCmd.java| 1 +
.../org/apache/cloudstack/saml/SAML2AuthManager.java | 19 ++-
.../apache/cloudstack/saml/SAML2AuthManagerImpl.java | 7 +++
.../command/SAML2LoginAPIAuthenticatorCmdTest.java| 4 ++--
4 files changed, 20 insertions(+), 11 deletions(-)
diff --git
a/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
b/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
index fd4da7a59b2..332e0602784 100644
---
a/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
+++
b/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
@@ -228,6 +228,7 @@ public class SAML2LoginAPIAuthenticatorCmd extends BaseCmd
implements APIAuthent
"Received SAML response for a SSO request that we
may not have made or has expired, please try logging in again",
params, responseType));
}
+samlAuthManager.purgeToken(token);
// Set IdpId for this session
session.setAttribute(SAMLPluginConstants.SAML_IDPID,
issuer.getValue());
diff --git
a/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManager.java
b/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManager.java
index 27f17cee6b1..3a4030f9c0d 100644
---
a/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManager.java
+++
b/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManager.java
@@ -71,16 +71,17 @@ public interface SAML2AuthManager extends
PluggableAPIAuthenticator, PluggableSe
"SAML2 IDP Metadata refresh interval in seconds, minimum value is
set to 300", true);
ConfigKey SAMLCheckSignature = new ConfigKey("Advanced",
Boolean.class, "saml2.check.signature", "true",
-"Whether SAML2 signature must be checked, when enforced and when
the SAML response does not have a signature would lead to login exception",
true);
+"When enabled (default and recommended), SAML2 signature checks
are enforced and lack of signature in the SAML SSO response will cause login
exception. Disabling this is not advisable but provided for backward
compatibility for users who are able to accept the risks.", false);
-public SAMLProviderMetadata getSPMetadata();
-public SAMLProviderMetadata getIdPMetadata(String entityId);
-public Collection getAllIdPMetadata();
+SAMLProviderMetadata getSPMetadata();
+SAMLProviderMetadata getIdPMetadata(String entityId);
+Collection getAllIdPMetadata();
-public boolean isUserAuthorized(Long userId, String entityId);
-public boolean authorizeUser(Long userId, String entityId, boolean enable);
+boolean isUserAuthorized(Long userId, String entityId);
+boolean authorizeUser(Long userId, String entityId, boolean enable);
-public void saveToken(String authnId, String domain, String entity);
-public SAMLTokenVO getToken(String authnId);
-public void expireTokens();
+void saveToken(String authnId, String domain, String entity);
+SAMLTokenVO getToken(String authnId);
+void purgeToken(SAMLTokenVO token);
+void expireTokens();
}
diff --git
a/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
b/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
index 3ecebf4d185..dfa76414fb7 100644
---
a/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
+++
b/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
@@ -487,6 +487,1
(cloudstack) branch 4.19 updated: engine-schema,cks: fix finding non removed network vms (#9339)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new 6a8494be3be engine-schema,cks: fix finding non removed network vms
(#9339)
6a8494be3be is described below
commit 6a8494be3be37c58f2b9ff1fb8f8d76d186cc987
Author: Abhishek Kumar
AuthorDate: Mon Jul 15 09:46:29 2024 +0530
engine-schema,cks: fix finding non removed network vms (#9339)
Fixes #9331
Only those VMs should be considered network VM which have a NIC entry
that is not marked removed.
Signed-off-by: Abhishek Kumar
---
engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java | 1 +
1 file changed, 1 insertion(+)
diff --git
a/engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java
b/engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java
index e41c706a9cb..a1bd25c2fbc 100755
--- a/engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java
+++ b/engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java
@@ -856,6 +856,7 @@ public class VMInstanceDaoImpl extends
GenericDaoBase implem
SearchBuilder nicSearch = nicDao.createSearchBuilder();
nicSearch.and("networkId", nicSearch.entity().getNetworkId(),
SearchCriteria.Op.EQ);
+nicSearch.and("removed", nicSearch.entity().getRemoved(),
SearchCriteria.Op.NULL);
NetworkTypeSearch = createSearchBuilder();
NetworkTypeSearch.and("types",
NetworkTypeSearch.entity().getType(), SearchCriteria.Op.IN);
Re: [PR] engine-schema,cks: fix finding non-removed network vms [cloudstack]
rohityadavcloud merged PR #9339: URL: https://github.com/apache/cloudstack/pull/9339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] unable to delete k8s cluster when we add k8s cluster network with a instance and removed it [cloudstack]
rohityadavcloud closed issue #9331: unable to delete k8s cluster when we add k8s cluster network with a instance and removed it URL: https://github.com/apache/cloudstack/issues/9331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] unable to delete k8s cluster when we add k8s cluster network with a instance and removed it [cloudstack]
rohityadavcloud commented on issue #9331: URL: https://github.com/apache/cloudstack/issues/9331#issuecomment-2227673662 Fixed by https://github.com/apache/cloudstack/pull/9339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: Fix radio buttons in instance migration pop-up (#8836)
This is an automated email from the ASF dual-hosted git repository.
vishesh pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new 7db83db3dd9 Fix radio buttons in instance migration pop-up (#8836)
7db83db3dd9 is described below
commit 7db83db3dd9b1d85f3a30e4807e1353d572a69cb
Author: Fabricio Duarte
AuthorDate: Sat Jul 13 16:32:19 2024 -0300
Fix radio buttons in instance migration pop-up (#8836)
---
ui/src/views/compute/MigrateVMStorage.vue | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/src/views/compute/MigrateVMStorage.vue
b/ui/src/views/compute/MigrateVMStorage.vue
index a67e7a5244f..139ff856a2a 100644
--- a/ui/src/views/compute/MigrateVMStorage.vue
+++ b/ui/src/views/compute/MigrateVMStorage.vue
@@ -24,7 +24,7 @@
{{ $t('label.migrate.instance.single.storage') }}
[I] Reset the VM password without needing to shut it down [cloudstack]
tuanhoangth1603 opened a new issue, #9387: URL: https://github.com/apache/cloudstack/issues/9387 Hello everyone, Can CloudStack v19 reset the VM password without needing to shut it down? Or is there any other way to accomplish this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Reset the VM password without needing to shut it down [cloudstack]
rohityadavcloud commented on issue #9387: URL: https://github.com/apache/cloudstack/issues/9387#issuecomment-2227733800 By design it is not possible currently @tuanhoangth1603 because we don't run any agent in the guest VMs that can get real-time changes; the VM only get the password/metadata (via cloud-init etc.) from the config drive or VR when the VM boots. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
sureshanaparti commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2227743571 @blueorangutan test alma8 kvm-alma8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2227745425 @sureshanaparti a [SL] Trillian-Jenkins test job (alma8 mgmt + kvm-alma8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2227758434 [SF] Trillian Build Failed (tid-10840) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
DaanHoogland commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2227763114 @blueorangutan test alma9 kvm-alma9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2227763834 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Reset the VM password without needing to shut it down [cloudstack]
DaanHoogland closed issue #9387: Reset the VM password without needing to shut it down URL: https://github.com/apache/cloudstack/issues/9387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for network data in Config Drive [cloudstack]
vishesh92 commented on PR #9329: URL: https://github.com/apache/cloudstack/pull/9329#issuecomment-2227772539 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch configdrive-network-data updated (09ba861b35d -> 9c0e5ba0dea)
This is an automated email from the ASF dual-hosted git repository. vishesh pushed a change to branch configdrive-network-data in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard 09ba861b35d Address comments add 9c0e5ba0dea Address comments This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (09ba861b35d) \ N -- N -- N refs/heads/configdrive-network-data (9c0e5ba0dea) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../engine/orchestration/NetworkOrchestrator.java | 15 ++- .../network/element/ConfigDriveNetworkElementTest.java| 2 -- 2 files changed, 10 insertions(+), 7 deletions(-)
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2227782328 [SF] Trillian Build Failed (tid-10841) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add limit configuration for number of projects [cloudstack]
DaanHoogland commented on PR #9172: URL: https://github.com/apache/cloudstack/pull/9172#issuecomment-2227801391 setting the limit to 1 an error occurs on creating the second:  after deleting the first prj the second gets created. setting for a domain to two  a second user can create their own prj:  good work @my-code-AL , totally out of scope but I was wondering if there is any reason this setting is not dynamic (i.e. can be changed without restart) work for another day maybe ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add limit configuration for number of projects [cloudstack]
DaanHoogland merged PR #9172: URL: https://github.com/apache/cloudstack/pull/9172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Add limit configuration for number of projects per domain/account and add UI function for configuring limits [cloudstack]
DaanHoogland closed issue #9127: Add limit configuration for number of projects per domain/account and add UI function for configuring limits URL: https://github.com/apache/cloudstack/issues/9127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add limit configuration for number of projects [cloudstack]
boring-cyborg[bot] commented on PR #9172: URL: https://github.com/apache/cloudstack/pull/9172#issuecomment-2227801755 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated (b9c7275c253 -> afdf4d7d46c)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from b9c7275c253 Quota tariff order (#8347) add afdf4d7d46c Add limit configuration for number of projects (#9172) No new revisions were added by this update. Summary of changes: .../java/com/cloud/user/ResourceLimitService.java | 4 + .../user/resource/UpdateResourceLimitCmd.java | 1 + .../main/java/com/cloud/configuration/Config.java | 9 ++ .../resourcelimit/ResourceLimitManagerImpl.java| 6 +- .../ResourceLimitManagerImplTest.java | 98 ++ 5 files changed, 117 insertions(+), 1 deletion(-)
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2227808498 [SF] Trillian Build Failed (tid-10843) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for network data in Config Drive [cloudstack]
harikrishna-patnala commented on PR #9329: URL: https://github.com/apache/cloudstack/pull/9329#issuecomment-2227809002 @vishesh92 can you please add how this has been tested. Helpful for anyone who wants to test this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IPv4 Static Routing (Routed mode) [cloudstack]
weizhouapache commented on PR #9346: URL: https://github.com/apache/cloudstack/pull/9346#issuecomment-2227810993 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IPv4 Static Routing (Routed mode) [cloudstack]
blueorangutan commented on PR #9346: URL: https://github.com/apache/cloudstack/pull/9346#issuecomment-2227812988 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
