Re: [PR] PowerFlex/ScaleIO - MDM and host SDC connection enhancements [cloudstack]
blueorangutan commented on PR #11047: URL: https://github.com/apache/cloudstack/pull/11047#issuecomment-3076097770 [SF] Trillian test result (tid-13779) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 57482 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11047-t13779-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] make vlan check conditional on management network for xen [cloudstack]
blueorangutan commented on PR #11193: URL: https://github.com/apache/cloudstack/pull/11193#issuecomment-3076487157 [SF] Trillian test result (tid-13775) Environment: xcpng83 (x2), Advanced Networking with Mgmt server ol9 Total time taken: 68299 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11193-t13775-xcpng83.zip Smoke tests completed. 141 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_prepare_and_cancel_maintenance | `Error` | 0.17 | test_ms_maintenance_and_safe_shutdown.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Issue with managing instances created via VMware. [cloudstack]
nimbustech-lab commented on issue #11052: URL: https://github.com/apache/cloudstack/issues/11052#issuecomment-3076517782 Hi @DaanHoogland & @nvazquez Good news. My team rebuilt the CloudStack environment with the new version 4.20.1 according to the documentation with a little different setup than what I complained which is a seperate NFS server, 2 seperate management server and also a seperate database / SQL server. I can manage and unmanage instances and also to create VMs with disk offerings that are tagged with the tagged datastores. Everything is working according to the tags somehow. I wanted to thank you both for helping me with this issue. It is now solved somehow. Maybe there a was a little different thing I did compared to before when deploying or it was fixed in 4.20.1. Is it okay for us to close this, then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Refactor Quota Summary API [cloudstack]
winterhazel commented on code in PR #10505:
URL: https://github.com/apache/cloudstack/pull/10505#discussion_r2208936937
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaSummaryCmd.java:
##
@@ -16,60 +16,81 @@
//under the License.
package org.apache.cloudstack.api.command;
-import com.cloud.user.Account;
import com.cloud.utils.Pair;
+
+import org.apache.cloudstack.api.ACL;
import org.apache.cloudstack.api.APICommand;
import org.apache.cloudstack.api.ApiConstants;
import org.apache.cloudstack.api.BaseListCmd;
import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.AccountResponse;
import org.apache.cloudstack.api.response.DomainResponse;
-import org.apache.cloudstack.api.response.ListResponse;
import org.apache.cloudstack.api.response.QuotaResponseBuilder;
import org.apache.cloudstack.api.response.QuotaSummaryResponse;
-import org.apache.cloudstack.context.CallContext;
+import org.apache.cloudstack.api.response.ProjectResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.quota.QuotaAccountStateFilter;
+import org.apache.cloudstack.quota.QuotaService;
+import org.apache.commons.lang3.ObjectUtils;
+import org.apache.commons.lang3.StringUtils;
+
import java.util.List;
import javax.inject.Inject;
-@APICommand(name = "quotaSummary", responseObject =
QuotaSummaryResponse.class, description = "Lists balance and quota usage for
all accounts", since = "4.7.0", requestHasSensitiveInfo = false,
responseHasSensitiveInfo = false)
+@APICommand(name = "quotaSummary", responseObject =
QuotaSummaryResponse.class, description = "Lists accounts' balance summary.",
since = "4.7.0",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
public class QuotaSummaryCmd extends BaseListCmd {
+@Inject
+QuotaResponseBuilder quotaResponseBuilder;
+
+@Inject
+QuotaService quotaService;
+
+@ACL
+@Parameter(name = ApiConstants.ACCOUNT_ID, type = CommandType.UUID,
entityType = AccountResponse.class, description = "ID of the account for which
balance will be listed. Can not be specified with projectId.")
Review Comment:
Add `since`
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaSummaryCmd.java:
##
@@ -16,60 +16,81 @@
//under the License.
package org.apache.cloudstack.api.command;
-import com.cloud.user.Account;
import com.cloud.utils.Pair;
+
+import org.apache.cloudstack.api.ACL;
import org.apache.cloudstack.api.APICommand;
import org.apache.cloudstack.api.ApiConstants;
import org.apache.cloudstack.api.BaseListCmd;
import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.AccountResponse;
import org.apache.cloudstack.api.response.DomainResponse;
-import org.apache.cloudstack.api.response.ListResponse;
import org.apache.cloudstack.api.response.QuotaResponseBuilder;
import org.apache.cloudstack.api.response.QuotaSummaryResponse;
-import org.apache.cloudstack.context.CallContext;
+import org.apache.cloudstack.api.response.ProjectResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.quota.QuotaAccountStateFilter;
+import org.apache.cloudstack.quota.QuotaService;
+import org.apache.commons.lang3.ObjectUtils;
+import org.apache.commons.lang3.StringUtils;
+
import java.util.List;
import javax.inject.Inject;
-@APICommand(name = "quotaSummary", responseObject =
QuotaSummaryResponse.class, description = "Lists balance and quota usage for
all accounts", since = "4.7.0", requestHasSensitiveInfo = false,
responseHasSensitiveInfo = false)
+@APICommand(name = "quotaSummary", responseObject =
QuotaSummaryResponse.class, description = "Lists accounts' balance summary.",
since = "4.7.0",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
public class QuotaSummaryCmd extends BaseListCmd {
+@Inject
+QuotaResponseBuilder quotaResponseBuilder;
+
+@Inject
+QuotaService quotaService;
+
+@ACL
+@Parameter(name = ApiConstants.ACCOUNT_ID, type = CommandType.UUID,
entityType = AccountResponse.class, description = "ID of the account for which
balance will be listed. Can not be specified with projectId.")
+private Long accountId;
+
@Parameter(name = ApiConstants.ACCOUNT, type = CommandType.STRING,
required = false, description = "Optional, Account Id for which statement needs
to be generated")
private String accountName;
@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID,
required = false, entityType = DomainResponse.class, description = "Optional,
If domain Id is given and the caller is domain admin then the statement is
generated for domain.")
private Long domainId;
-@Parameter(name = ApiConstants.LIST_ALL, type = CommandType.BOOLEAN,
required = false, description = "Optional, to list all accounts irrespective of
th
Re: [I] Error while trying to create a volume from a volume snapshot that sometimes result in snapshot loss [cloudstack]
winterhazel commented on issue #9538: URL: https://github.com/apache/cloudstack/issues/9538#issuecomment-3076608543 > [@winterhazel](https://github.com/winterhazel) , this sounds like a critical bug. Any idea of the likelyhood and/or the cause? @DaanHoogland I did not look into what was causing this issue back then, but I remember that I was only able to reproduce this when attempting to create a volume from a Macchinina root disk volume snapshot. I recall that I also executed the described procedure for root disks with Ubuntu and CentOS, but did not get any error. Perhaps it is related to the volume snapshot's size? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix to create instances with smaller templates (< 8 GB) on PowerFlex/ScaleIO storage [cloudstack]
sureshanaparti opened a new pull request, #11211:
URL: https://github.com/apache/cloudstack/pull/11211
### Description
This PR allows create instances with smaller templates (< 8 GB) on
PowerFlex/ScaleIO storage (it's regression after #9008).
Fixes #10981
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Deployed instance using the template
(http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-kvm.qcow2.bz2) on
PowerFlex storage.
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix to create instances with smaller templates (< 8 GB) on PowerFlex/ScaleIO storage [cloudstack]
codecov[bot] commented on PR #11211: URL: https://github.com/apache/cloudstack/pull/11211#issuecomment-3076698869 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11211?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.00%. Comparing base [(`9688cbb`)](https://app.codecov.io/gh/apache/cloudstack/commit/9688cbb0953494346a519a661c7bb4374688cb7d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`321564c`)](https://app.codecov.io/gh/apache/cloudstack/commit/321564c198a9d57c923a3f3811fa64cefc3f5d89?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (9688cbb) and HEAD (321564c). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (9688cbb) | HEAD (321564c) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.20 #11211 +/- ## = - Coverage 16.15%4.00% -12.16% = Files 5656 402 -5254 Lines49772832612 -465116 Branches 60360 5791-54569 = - Hits 80420 1305-79115 + Misses 40835731158 -377199 + Partials 8951 149 -8802 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11211/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11211/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.00% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11211/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11211?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix to create instances with smaller templates (< 8 GB) on PowerFlex/ScaleIO storage [cloudstack]
blueorangutan commented on PR #11211: URL: https://github.com/apache/cloudstack/pull/11211#issuecomment-3076697898 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow custom NTP servers for CPVM [cloudstack]
rohityadavcloud commented on code in PR #11210:
URL: https://github.com/apache/cloudstack/pull/11210#discussion_r2209203875
##
systemvm/debian/opt/cloud/bin/setup/common.sh:
##
@@ -683,7 +683,7 @@ getPublicIp() {
setup_ntp() {
log_it "Setting up NTP"
-NTP_CONF_FILE="/etc/ntp.conf"
+NTP_CONF_FILE="/etc/ntpsec/ntp.conf"
Review Comment:
Probably a good idea - if this is also applicable to 4.20 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[I] Unable to add more than 2 volume or network to a vm deployed from a UEFI image [cloudstack]
kiranchavala opened a new issue, #11212: URL: https://github.com/apache/cloudstack/issues/11212 ### problem Unable to add more than 2 volume or network to a vm deployed from a UEFI image ### versions ACS 4.20.1 ### The steps to reproduce the bug 1. Register a UEFI image Template https://cloud-images.ubuntu.com/noble/current/noble-server-cloudimg-amd64.img 2. Deploy the vm by enabling UEFI secure mode in advanced settings https://github.com/user-attachments/assets/bb1449a9-74c7-4ce8-a5bf-e94d7446ab88"; /> 3. Once the vm is in running state , attach multiple volumes , Exception observed Logs ``` 2025-07-16 04:28:28,947 DEBUG [kvm.storage.KVMStorageProcessor] (AgentRequest-Handler-3:[]) (logid:) Attaching device: c6ef61d1300f442a86e5 2025-07-16 04:28:28,953 WARN [kvm.storage.KVMStorageProcessor] (AgentRequest-Handler-3:[]) (logid:) Failed to attach device to i-2-653-VM: internal error: No more available PCI slots 2025-07-16 04:28:28,953 DEBUG [kvm.storage.KVMStorageProcessor] (AgentRequest-Handler-3:[]) (logid:) Failed to attach volume [id: 394, uuid: c6ef61d1-300f-442a-86e5-e31f482b64ab, name: test2, path: c6ef61d1-300f-442a-86e5-e31f482b64ab], due to org.libvirt.LibvirtException: internal error: No more available PCI slots ``` 4. Try to attach multiple networks, Exception observed ``` 2025-07-16 04:36:02,019 DEBUG [kvm.resource.BridgeVifDriver] (AgentRequest-Handler-1:[]) (logid:) Successfully executed process [2045246] for command [/usr/share/cloudstack-common/scripts/vm/network/vnet/modifyvlan.sh -v 2144 -p eth1 -b breth1-2144 -o add ]. 2025-07-16 04:36:02,021 WARN [resource.wrapper.LibvirtPlugNicCommandWrapper] (AgentRequest-Handler-1:[]) (logid:) Plug Nic failed due to org.libvirt.LibvirtException: internal error: No more available PCI slots org.libvirt.LibvirtException: internal error: No more available PCI slots at org.libvirt.ErrorHandler.processError(Unknown Source) at org.libvirt.ErrorHandler.processError(Unknown Source) ``` Workaround Change the following settings on the vm after stopping nicAdapter to e1000 or rtl813 rootDiskController to scsi or sata https://prnt.sc/9wSS5uX0tVYX ### What to do about it? If the Template is a UEFI enabled , Cloudstack should check if the template is UEFI enabled or not and populated the necessary settings for root disk and nic adapter yum install libguestfs-tools virt-inspector --format=raw -a noble-server-cloudimg-amd64.img 2>/dev/null | grep -i 'true' virt-inspector -a AlmaLinux-8-GenericCloud-UEFI-latest.x86_64.qcow2 2>/dev/null | grep -i 'true' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Consider Quota settings during processing [cloudstack]
DaanHoogland commented on PR #10892: URL: https://github.com/apache/cloudstack/pull/10892#issuecomment-3077026359 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Consider Quota settings during processing [cloudstack]
DaanHoogland commented on code in PR #10892:
URL: https://github.com/apache/cloudstack/pull/10892#discussion_r2209360806
##
framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaManagerImpl.java:
##
@@ -340,12 +349,41 @@ protected List
createQuotaUsagesAccordingToQuotaTariffs(AccountVO
}
protected boolean shouldCalculateUsageRecord(AccountVO accountVO, UsageVO
usageRecord) {
-if
(Boolean.FALSE.equals(QuotaConfig.QuotaAccountEnabled.valueIn(accountVO.getAccountId(
{
+boolean calculateUsageRecord = findConfigurationValue(accountVO,
QuotaConfig.QuotaAccountEnabled);
+if (!calculateUsageRecord && usageRecord != null) {
logger.debug("Considering usage record [{}] as calculated and
skipping it because account [{}] has the quota plugin disabled.",
usageRecord.toString(usageAggregationTimeZone),
accountVO.reflectionToString());
return false;
}
-return true;
+return calculateUsageRecord;
+}
+
+@Override
+public boolean findConfigurationValue(AccountVO accountVO,
ConfigKey key) {
+logger.trace("Searching configuration [{}] of account [{}] in its
settings.", key.key(), accountVO);
+AccountDetailVO accountDetail =
accountDetailsDao.findDetail(accountVO.getAccountId(), key.key());
+if (accountDetail != null) {
+boolean result = Boolean.parseBoolean(accountDetail.getValue());
+logger.trace("Using value [{}] found in account [{}] settings to
configuration [{}].", result, accountVO, key.key());
+return result;
+}
+
+if
(Boolean.parseBoolean(_configDao.getValue("enable.account.settings.for.domain")))
{
+logger.trace("Searching for configuration [{}] of account [{}] in
its domain [{}] settings.", key.key(), accountVO, accountVO.getDomainId());
+DomainDetailVO domainDetail =
domainDetailsDao.findDetail(accountVO.getDomainId(), key.key());
+if (domainDetail != null) {
+boolean result = Boolean.parseBoolean(domainDetail.getValue());
+logger.trace("Using value [{}] found in domain [{}] settings
to configuration [{}].", result, accountVO.getDomainId(), key.key());
+return result;
+}
+}
+boolean result =
Boolean.parseBoolean(getConfigValueOrDefaultValue(key));
+logger.trace("Using default value [{}] to configuration [{}].",
result, key.key());
+return result;
+}
Review Comment:
ok, let’s go for it like this, thanks for investigating @julien-vaz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Consider Quota settings during processing [cloudstack]
blueorangutan commented on PR #10892: URL: https://github.com/apache/cloudstack/pull/10892#issuecomment-3077032277 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Issue with managing instances created via VMware. [cloudstack]
DaanHoogland closed issue #11052: Issue with managing instances created via VMware. URL: https://github.com/apache/cloudstack/issues/11052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Issue with managing instances created via VMware. [cloudstack]
DaanHoogland commented on issue #11052: URL: https://github.com/apache/cloudstack/issues/11052#issuecomment-3077106118 @nimbustech-lab , we can close as I don’t think we found anything we can improve. Thanks for letting us know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] make vlan check conditional on management network for xen [cloudstack]
UAnton commented on PR #11193: URL: https://github.com/apache/cloudstack/pull/11193#issuecomment-3077116408 > @UAnton can you test if this satisfies your use-case, please? I can't. Too much time has passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow custom NTP servers for CPVM [cloudstack]
DaanHoogland commented on code in PR #11210: URL: https://github.com/apache/cloudstack/pull/11210#discussion_r2209437687 ## server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java: ## @@ -258,6 +258,9 @@ public class ConsoleProxyManagerImpl extends ManagerBase implements ConsoleProxy protected Set availableVmStateOnAssignProxy = new HashSet<>(Arrays.asList(State.Starting, State.Running, State.Stopping, State.Migrating)); +static final ConfigKey CPVMNTPServerConfig = new ConfigKey(String.class, "cpvm.ntp.server.list", "Advanced", null, Review Comment: I am not in favour of having separate ntp servers. let’s use the same config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] make vlan check conditional on management network for xen [cloudstack]
DaanHoogland commented on PR #11193: URL: https://github.com/apache/cloudstack/pull/11193#issuecomment-3077099922 @UAnton can you test if this satisfies your use-case, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Error while trying to create a volume from a volume snapshot that sometimes result in snapshot loss [cloudstack]
DaanHoogland commented on issue #9538: URL: https://github.com/apache/cloudstack/issues/9538#issuecomment-3077115116 ah, that small template has been giving more problems, maybe we should try increasing the size of(in spite of it not needing it) just to see. In the mean while I think we do not need this issue as macchinina is not for anything but testing. cc @NuxRo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix to create instances with smaller templates (< 1 GB) on PowerFlex/ScaleIO storage [cloudstack]
sureshanaparti commented on PR #11211: URL: https://github.com/apache/cloudstack/pull/11211#issuecomment-3077143269 > clgtm, but includes a change in the storpool adaptor. @slavkap can you have a look? @DaanHoogland I noticed an NPE in storpool adaptor, check the log in the issue #10981. cc @slavkap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] KVM Disk-only VM Snapshots [cloudstack]
DaanHoogland closed issue #9524: KVM Disk-only VM Snapshots URL: https://github.com/apache/cloudstack/issues/9524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Volume Snapshots of an Instance in a Powered Off State [cloudstack]
DaanHoogland closed issue #9496: Volume Snapshots of an Instance in a Powered Off State URL: https://github.com/apache/cloudstack/issues/9496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] File-based disk-only VM snapshot with KVM as hypervisor [cloudstack]
DaanHoogland merged PR #10632: URL: https://github.com/apache/cloudstack/pull/10632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Feature: Add support for GPU with KVM hosts [cloudstack]
blueorangutan commented on PR #11143: URL: https://github.com/apache/cloudstack/pull/11143#issuecomment-3076792533 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Feature: Add support for GPU with KVM hosts [cloudstack]
vishesh92 commented on PR #11143: URL: https://github.com/apache/cloudstack/pull/11143#issuecomment-3076789119 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix to create instances with smaller templates (< 1 GB) on PowerFlex/ScaleIO storage [cloudstack]
blueorangutan commented on PR #11211: URL: https://github.com/apache/cloudstack/pull/11211#issuecomment-3076883597 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix to create instances with smaller templates (< 8 GB) on PowerFlex/ScaleIO storage [cloudstack]
sureshanaparti commented on PR #11211: URL: https://github.com/apache/cloudstack/pull/11211#issuecomment-3076692904 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Unable to create instance on PowerFlex storage (with smaller templates) [cloudstack]
sureshanaparti commented on issue #10981: URL: https://github.com/apache/cloudstack/issues/10981#issuecomment-3076692002 > [@sureshanaparti](https://github.com/sureshanaparti) [@weizhouapache](https://github.com/weizhouapache) is this really a blocker? do we know of any users hindered by this (other than cloud developers using ridiculous small templates) @DaanHoogland it's regression due to https://github.com/apache/cloudstack/pull/9008, only effects PowerFlex users. They wouldn't be able to create instances with smaller templates (< 8 GB). Fix PR is ready, so better include it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Refactor `listTemplates` and `listIsos` workflows [cloudstack]
DaanHoogland commented on issue #11209: URL: https://github.com/apache/cloudstack/issues/11209#issuecomment-3077038469 this is one of the methods that suffers this quality. I am now working on `listDataCentersInternal`. it fortunately takes the cmd object but is 200 lines as well. I am refactorring it to be able to troubleshoot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CKS] Simplify logic for scaling CKS cluster service offerings [cloudstack]
DaanHoogland merged PR #11063: URL: https://github.com/apache/cloudstack/pull/11063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated: [CKS] Simplify logic for scaling CKS cluster service offerings (#11063)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 84b8071 [CKS] Simplify logic for scaling CKS cluster service
offerings (#11063)
84b8071 is described below
commit 84b80715b8398ebefd1f554f579bb05b14b4
Author: Nicolas Vazquez
AuthorDate: Wed Jul 16 03:23:33 2025 -0300
[CKS] Simplify logic for scaling CKS cluster service offerings (#11063)
---
.../KubernetesClusterScaleWorker.java | 85 +++---
1 file changed, 44 insertions(+), 41 deletions(-)
diff --git
a/plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterScaleWorker.java
b/plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterScaleWorker.java
index bfc553f6afa..3461d5c0634 100644
---
a/plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterScaleWorker.java
+++
b/plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterScaleWorker.java
@@ -532,6 +532,8 @@ public class KubernetesClusterScaleWorker extends
KubernetesClusterResourceModif
}
scaleTimeoutTime = System.currentTimeMillis() +
KubernetesClusterService.KubernetesClusterScaleTimeout.value() * 1000;
final long originalClusterSize = kubernetesCluster.getNodeCount();
+
+// DEFAULT node type means only the global service offering has been
set for the Kubernetes cluster
boolean scaleClusterDefaultOffering =
serviceOfferingNodeTypeMap.containsKey(DEFAULT.name());
if (scaleClusterDefaultOffering) {
final ServiceOffering existingServiceOffering =
serviceOfferingDao.findById(kubernetesCluster.getServiceOfferingId());
@@ -546,38 +548,37 @@ public class KubernetesClusterScaleWorker extends
KubernetesClusterResourceModif
ServiceOffering defaultServiceOffering =
serviceOfferingNodeTypeMap.getOrDefault(DEFAULT.name(), null);
for (KubernetesClusterNodeType nodeType : Arrays.asList(CONTROL, ETCD,
WORKER)) {
-boolean isWorkerNodeOrAllNodes = WORKER == nodeType;
-final long newVMRequired = (!isWorkerNodeOrAllNodes || clusterSize
== null) ? 0 : clusterSize - originalClusterSize;
+boolean isWorkerNode = WORKER == nodeType;
+final long newVMRequired = (!isWorkerNode || clusterSize == null)
? 0 : clusterSize - originalClusterSize;
if (!scaleClusterDefaultOffering &&
!serviceOfferingNodeTypeMap.containsKey(nodeType.name()) && newVMRequired == 0)
{
continue;
}
-Long existingNodeTypeOfferingId =
getKubernetesClusterNodeTypeOfferingId(kubernetesCluster, nodeType);
-boolean clusterHasExistingOfferingForNodeType =
existingNodeTypeOfferingId != null;
-boolean serviceOfferingScalingNeeded =
isServiceOfferingScalingNeededForNodeType(nodeType, serviceOfferingNodeTypeMap,
kubernetesCluster);
-ServiceOffering serviceOffering =
serviceOfferingNodeTypeMap.getOrDefault(nodeType.name(),
defaultServiceOffering);
-boolean updateNodeOffering =
serviceOfferingNodeTypeMap.containsKey(nodeType.name()) ||
-scaleClusterDefaultOffering &&
clusterHasExistingOfferingForNodeType;
-boolean updateClusterOffering = isWorkerNodeOrAllNodes &&
scaleClusterDefaultOffering;
-if (isWorkerNodeOrAllNodes && autoscalingChanged) {
+ServiceOffering existingServiceOffering =
getExistingServiceOfferingForNodeType(nodeType, kubernetesCluster);
+ServiceOffering scalingServiceOffering =
serviceOfferingNodeTypeMap.getOrDefault(nodeType.name(),
defaultServiceOffering);
+boolean isNodeOfferingScalingNeeded =
isServiceOfferingScalingNeededForNodeType(existingServiceOffering,
scalingServiceOffering);
+boolean updateNodeOffering =
serviceOfferingNodeTypeMap.containsKey(nodeType.name()) ||
isNodeOfferingScalingNeeded;
+
+boolean updateClusterOffering = isWorkerNode &&
scaleClusterDefaultOffering;
+if (isWorkerNode && autoscalingChanged) {
boolean autoScaled =
autoscaleCluster(this.isAutoscalingEnabled, minSize, maxSize);
-if (autoScaled && serviceOfferingScalingNeeded) {
-scaleKubernetesClusterOffering(nodeType, serviceOffering,
updateNodeOffering, updateClusterOffering);
+if (autoScaled && isNodeOfferingScalingNeeded) {
+scaleKubernetesClusterOffering(nodeType,
scalingServiceOffering, updateNodeOffering, updateClusterOffering);
}
stateTransitTo(kubernetesCluster.getId(),
KubernetesCluster.Ev
(cloudstack) branch main updated: PowerFlex/ScaleIO - MDM and host SDC connection enhancements (#11047)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 3220eb442a5 PowerFlex/ScaleIO - MDM and host SDC connection
enhancements (#11047)
3220eb442a5 is described below
commit 3220eb442a5b2a1416b2c44a1112dc029dd35708
Author: Suresh Kumar Anaparti
AuthorDate: Wed Jul 16 11:55:28 2025 +0530
PowerFlex/ScaleIO - MDM and host SDC connection enhancements (#11047)
* Cumulative enhancements fix for ScaleIO: MDM add/remove, Host
prepare/unprepare, validate Storage Pool can be created in Agent.
- Implemented validation to fail Host disconnect from Storage Pool if there
are Volumes attached and SDC client MDM removal requires scini service to be
restarted
- Implemented Storage Pool validation by checking whether MDM addresses
from configuration file and from memory (using CLI) matches, otherwise file
ModifyStoragePool command.
- Introduced configuration key to apply timeout after making MDM changes
for ScaleIO: powerflex.mdm.change.apply.timeout.ms (default 1000ms)
- Implemented logic to apply timeout after making MDM changes for ScaleIO
in prepare and unprepare logic
- Added detection of MDM removal support via CLI
- If MDM removal support via CLI supported then use CLI, fall back to edit
drv_cfg.txt and restart scini instead
Co-authored-by: Suresh Kumar Anaparti
Co-authored-by: mprokopchuk
---
.../cloud/agent/properties/AgentProperties.java| 2 +-
.../LibvirtModifyStoragePoolCommandWrapper.java| 16 +-
.../kvm/storage/ScaleIOStorageAdaptor.java | 174 --
.../kvm/storage/ScaleIOStorageAdaptorTest.java | 4 +
.../datastore/client/ScaleIOGatewayClient.java | 3 +
.../ScaleIOPrimaryDataStoreLifeCycle.java | 39 +--
.../datastore/manager/ScaleIOSDCManager.java | 37 +++
.../datastore/manager/ScaleIOSDCManagerImpl.java | 58 +++-
.../datastore/provider/ScaleIOHostListener.java| 12 +-
.../storage/datastore/util/ScaleIOUtil.java| 351 ++---
.../main/java/com/cloud/utils/script/Script.java | 20 ++
11 files changed, 611 insertions(+), 105 deletions(-)
diff --git
a/agent/src/main/java/com/cloud/agent/properties/AgentProperties.java
b/agent/src/main/java/com/cloud/agent/properties/AgentProperties.java
index 69537621673..b6e90160c07 100644
--- a/agent/src/main/java/com/cloud/agent/properties/AgentProperties.java
+++ b/agent/src/main/java/com/cloud/agent/properties/AgentProperties.java
@@ -833,7 +833,7 @@ public class AgentProperties{
private T defaultValue;
private Class typeClass;
-Property(String name, T value) {
+public Property(String name, T value) {
init(name, value);
}
diff --git
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtModifyStoragePoolCommandWrapper.java
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtModifyStoragePoolCommandWrapper.java
index 06883c708d9..990cefda8f3 100644
---
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtModifyStoragePoolCommandWrapper.java
+++
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtModifyStoragePoolCommandWrapper.java
@@ -31,6 +31,7 @@ import com.cloud.hypervisor.kvm.storage.KVMStoragePoolManager;
import com.cloud.resource.CommandWrapper;
import com.cloud.resource.ResourceWrapper;
import com.cloud.storage.template.TemplateProp;
+import com.cloud.utils.exception.CloudRuntimeException;
@ResourceWrapper(handles = ModifyStoragePoolCommand.class)
public final class LibvirtModifyStoragePoolCommandWrapper extends
CommandWrapper {
@@ -49,11 +50,16 @@ public final class LibvirtModifyStoragePoolCommandWrapper
extends CommandWrapper
return answer;
}
-final KVMStoragePool storagepool =
-storagePoolMgr.createStoragePool(command.getPool().getUuid(),
command.getPool().getHost(), command.getPool().getPort(),
command.getPool().getPath(), command.getPool()
-.getUserInfo(), command.getPool().getType(),
command.getDetails());
-if (storagepool == null) {
-return new Answer(command, false, " Failed to create storage
pool");
+final KVMStoragePool storagepool;
+try {
+storagepool =
+
storagePoolMgr.createStoragePool(command.getPool().getUuid(),
command.getPool().getHost(), command.getPool().getPort(),
command.getPool().getPath(), command.getPool()
+.getUserInfo(), command.getPool().getType(),
command.getDetails());
+if (storagepool == null) {
+return new Answer(command, false, " Failed to create storage
pool");
+
Re: [PR] PowerFlex/ScaleIO - MDM and host SDC connection enhancements [cloudstack]
DaanHoogland merged PR #11047: URL: https://github.com/apache/cloudstack/pull/11047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] kvm: implement Hyper-V enlightnements correctly [cloudstack]
rohityadavcloud opened a new pull request, #11213:
URL: https://github.com/apache/cloudstack/pull/11213
This implements Hyper-V enlightenments as per the RHEL docs:
https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/10/html/configuring_and_managing_windows_virtual_machines/optimizing-windows-virtual-machines#enabling-hyper-v-enlightenments
This is enabled only when the guest OS is set to Windows PV.
This PR is followup of findings and improvements from
https://github.com/apache/cloudstack/issues/10650#issuecomment-3073443483
Tested on: ACS 4.20.1 with Ubuntu 22.04/KVM with Windows 10 ISO, installed
Windows 10 VM
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Feature: Add support for GPU with KVM hosts [cloudstack]
blueorangutan commented on PR #11143: URL: https://github.com/apache/cloudstack/pull/11143#issuecomment-3077082455 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Usage parsers refactoring [cloudstack]
DaanHoogland merged PR #11097: URL: https://github.com/apache/cloudstack/pull/11097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated (3220eb442a5 -> bb75abcffa2)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 3220eb442a5 PowerFlex/ScaleIO - MDM and host SDC connection enhancements (#11047) add bb75abcffa2 Usage parsers refactoring (#11097) No new revisions were added by this update. Summary of changes: .../java/com/cloud/usage/UsageManagerImpl.java | 130 ++--- .../com/cloud/usage/parser/BackupUsageParser.java | 32 ++--- .../com/cloud/usage/parser/BucketUsageParser.java | 33 ++ .../cloud/usage/parser/IPAddressUsageParser.java | 45 +++ .../usage/parser/LoadBalancerUsageParser.java | 46 +++- .../usage/parser/NetworkOfferingUsageParser.java | 46 +++- .../com/cloud/usage/parser/NetworkUsageParser.java | 41 ++- .../cloud/usage/parser/NetworksUsageParser.java| 34 ++ .../usage/parser/PortForwardingUsageParser.java| 44 +++ .../usage/parser/SecurityGroupUsageParser.java | 44 +++ .../com/cloud/usage/parser/StorageUsageParser.java | 44 +++ .../java/com/cloud/usage/parser/UsageParser.java | 31 +++-- .../cloud/usage/parser/VMInstanceUsageParser.java | 42 +++ .../usage/parser/VMSnapshotOnPrimaryParser.java| 48 +++- .../cloud/usage/parser/VMSnapshotUsageParser.java | 48 +++- .../com/cloud/usage/parser/VPNUserUsageParser.java | 44 +++ .../com/cloud/usage/parser/VmDiskUsageParser.java | 41 ++- .../com/cloud/usage/parser/VolumeUsageParser.java | 44 +++ .../com/cloud/usage/parser/VpcUsageParser.java | 33 ++ 19 files changed, 254 insertions(+), 616 deletions(-)
Re: [PR] kvm: implement Hyper-V enlightnements correctly [cloudstack]
codecov[bot] commented on PR #11213: URL: https://github.com/apache/cloudstack/pull/11213#issuecomment-3077098177 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11213?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.00%. Comparing base [(`c61a5eb`)](https://app.codecov.io/gh/apache/cloudstack/commit/c61a5eb430a8ced2b10d7cec9948a8704c2c52ac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`f1510c6`)](https://app.codecov.io/gh/apache/cloudstack/commit/f1510c63f4b81f3134474e900a4dbd8c9013704e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 30 commits behind head on 4.20. > :exclamation: There is a different number of reports uploaded between BASE (c61a5eb) and HEAD (f1510c6). Click for more details. > > HEAD has 3 uploads less than BASE > >| Flag | BASE (c61a5eb) | HEAD (f1510c6) | >|--|--|--| >|uitests|2|1| >|unittests|2|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.20 #11213 +/- ## = - Coverage 16.14%4.00% -12.15% = Files 5656 402 -5254 Lines49789332612 -465281 Branches 60374 5791-54583 = - Hits 80394 1305-79089 + Misses 40853931158 -377381 + Partials 8960 149 -8811 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11213/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11213/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.00% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11213/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11213?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Usage parsers refactoring [cloudstack]
blueorangutan commented on PR #11097: URL: https://github.com/apache/cloudstack/pull/11097#issuecomment-3072286342 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
DaanHoogland commented on PR #9: URL: https://github.com/apache/cloudstack/pull/9#issuecomment-3072875977 looks good, will do some extra testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OVM deprecation [cloudstack]
DaanHoogland commented on PR #11196: URL: https://github.com/apache/cloudstack/pull/11196#issuecomment-3072891831 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] API to list console sessions [cloudstack]
blueorangutan commented on PR #11016: URL: https://github.com/apache/cloudstack/pull/11016#issuecomment-3072985673 [SF] Trillian test result (tid-13766) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 89291 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11016-t13766-kvm-ubuntu22.zip Smoke tests completed. 130 look OK, 11 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_nic_secondaryip_add_remove | `Error` | 1518.38 | test_multipleips_per_nic.py ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | test_nested_virtualization.py ContextSuite context=TestNetworkACL>:setup | `Error` | 0.00 | test_network_acl.py ContextSuite context=TestIpv6Network>:setup | `Error` | 0.00 | test_network_ipv6.py test_delete_account | `Error` | 1517.97 | test_network.py test_delete_network_while_vm_on_it | `Error` | 1.23 | test_network.py test_deploy_vm_l2network | `Error` | 1.25 | test_network.py test_l2network_restart | `Error` | 2.36 | test_network.py ContextSuite context=TestPortForwarding>:setup | `Error` | 3.73 | test_network.py ContextSuite context=TestPublicIP>:setup | `Error` | 11.89 | test_network.py test_reboot_router | `Failure` | 0.09 | test_network.py test_releaseIP | `Error` | 5.81 | test_network.py test_releaseIP_using_IP | `Error` | 5.98 | test_network.py ContextSuite context=TestRouterRules>:setup | `Error` | 6.06 | test_network.py ContextSuite context=TestSharedNetworkWithConfigDrive>:setup | `Error` | 1523.90 | test_network.py ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py ContextSuite context=TestNonStrictAffinityGroups>:setup | `Error` | 0.00 | test_nonstrict_affinity_group.py ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py ContextSuite context=TestProjectSuspendActivate>:setup | `Error` | 1529.67 | test_projects.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Issue with managing instances created via VMware. [cloudstack]
nimbustech-lab commented on issue #11052: URL: https://github.com/apache/cloudstack/issues/11052#issuecomment-3072991418 Hi @DaanHoogland I meant managing an unmanaged instance when I said "tried to map a VM". My colleague tried to import VM from vCenter to CloudStack using the storage path, rather than the storage name / datastore name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow counters to be created with same name, provider and source as a deleted one [cloudstack]
blueorangutan commented on PR #10223: URL: https://github.com/apache/cloudstack/pull/10223#issuecomment-3072987487 [SF] Trillian test result (tid-13771) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 54061 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10223-t13771-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] API to list console sessions [cloudstack]
DaanHoogland commented on PR #11016: URL: https://github.com/apache/cloudstack/pull/11016#issuecomment-3073146273 btw, I think this PR is good to merge, @sureshanaparti !? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI fix api in project view [cloudstack]
blueorangutan commented on PR #11191: URL: https://github.com/apache/cloudstack/pull/11191#issuecomment-3073150869 @vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI fix api in project view [cloudstack]
vishesh92 commented on PR #11191: URL: https://github.com/apache/cloudstack/pull/11191#issuecomment-3073148354 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] API to list console sessions [cloudstack]
DaanHoogland commented on PR #11016: URL: https://github.com/apache/cloudstack/pull/11016#issuecomment-307314 we have no more credits with github to upload files. We’l have to find ways to auto-clean them to keep working as we were used to. sorry @bernardodemarco -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Switch to jdk18on bouncycastle jars [cloudstack]
harikrishna-patnala opened a new pull request, #11201:
URL: https://github.com/apache/cloudstack/pull/11201
### Description
This PR fixes https://github.com/apache/cloudstack/issues/10954
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Updated my environment with the newer jars and everything seems fine
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(cloudstack) branch main updated (fb6adacc512 -> e8ab0ae70a7)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from fb6adacc512 GUI whitelabel runtime system (#8942) add e8ab0ae70a7 CPU to Memory weight based algorithm to order cluster (#10997) No new revisions were added by this update. Summary of changes: .../org/apache/cloudstack/api/ApiConstants.java| 5 + .../cloud/configuration/ConfigurationManager.java | 6 + .../java/com/cloud/capacity/dao/CapacityDao.java | 10 +- .../com/cloud/capacity/dao/CapacityDaoImpl.java| 62 +- .../resources/META-INF/db/schema-42010to42100.sql | 6 + .../cloud/capacity/dao/CapacityDaoImplTest.java| 226 - .../implicitplanner/ImplicitPlannerTest.java | 2 +- .../manager/allocator/impl/FirstFitAllocator.java | 45 +++- .../main/java/com/cloud/configuration/Config.java | 5 +- .../configuration/ConfigurationManagerImpl.java| 3 +- .../java/com/cloud/deploy/FirstFitPlanner.java | 125 ++-- .../allocator/impl/FirstFitAllocatorTest.java | 62 ++ .../java/com/cloud/vm/FirstFitPlannerTest.java | 142 - 13 files changed, 661 insertions(+), 38 deletions(-)
Re: [PR] Switch to jdk18on bouncycastle jars [cloudstack]
harikrishna-patnala commented on PR #11201: URL: https://github.com/apache/cloudstack/pull/11201#issuecomment-3073185943 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Refactor of Allocator classes [cloudstack]
github-actions[bot] commented on PR #9074: URL: https://github.com/apache/cloudstack/pull/9074#issuecomment-3073189669 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow deploy of VRs on dedicated resources [cloudstack]
github-actions[bot] commented on PR #9531: URL: https://github.com/apache/cloudstack/pull/9531#issuecomment-3073189723 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Guest OS rules [cloudstack]
github-actions[bot] commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-3073189786 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
rohityadavcloud merged PR #10997: URL: https://github.com/apache/cloudstack/pull/10997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GUI whitelabel runtime system [cloudstack]
sureshanaparti commented on PR #8942: URL: https://github.com/apache/cloudstack/pull/8942#issuecomment-3073193036 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack-documentation) branch main updated: Add cluster ordering by host capacityType doc (#524)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git The following commit(s) were added to refs/heads/main by this push: new 05e083d Add cluster ordering by host capacityType doc (#524) 05e083d is described below commit 05e083d208e9c9e19d4a7b4d655888d4377dccf0 Author: Manoj Kumar AuthorDate: Tue Jul 15 16:41:14 2025 +0530 Add cluster ordering by host capacityType doc (#524) --- source/adminguide/vm_volume_allocators.rst | 61 +- 1 file changed, 60 insertions(+), 1 deletion(-) diff --git a/source/adminguide/vm_volume_allocators.rst b/source/adminguide/vm_volume_allocators.rst index 3844279..c15ebd8 100644 --- a/source/adminguide/vm_volume_allocators.rst +++ b/source/adminguide/vm_volume_allocators.rst @@ -77,4 +77,63 @@ firstfitleastconsumed Selects the first storage pool after sorting elig **volume.allocation.algorithm**: random (default) - Before 4.21.0, **vm.allocation.algorithm** was used for both VM as well as Volume allocation. \ No newline at end of file + Before 4.21.0, **vm.allocation.algorithm** was used for both VM as well as Volume allocation. + + +Cluster, Pod and Host Ordering +== + +Overview + + +`The host.capacityType.to.order.clusters` is a global advanced configuration parameter in Apache CloudStack that controls how pods, clusters, +and hosts are prioritized during Instance deployment, based on available CPU, RAM, or a weighted combination of both in Host. +This configuration is specifically leveraged when the VM allocation algorithm is set to `firstfitleastconsumed`. + +Configuration +- + +Key: `host.capacityType.to.order.clusters` + +.. cssclass:: table-striped table-bordered table-hover + += +Value Behavior += +CPU Prioritizes resources with the most available CPU. +RAM Prioritizes resources with the most available memory. +COMBINED Uses a weighted formula to balance CPU and RAM in prioritization. += + +**Additional Configuration for COMBINED** + +- Key: `host.capacityType.to.order.clusters.cputomemoryweight` +- Type: Float(0.0 to 1.0) +- Default: 0.5 +- Purpose: Determines the weight of CPU vs RAM in the combined capacity calculation. + +Capacity calculation formula: + +.. code:: bash + + capacity = (host.capacityType.to.order.clusters.cputomemoryweight * CPU) + ((1 - host.capacityType.to.order.clusters.cputomemoryweight) * RAM) + + +This allows flexible tuning of prioritization depending on workload sensitivity. + +Example Configuration +- + +.. code:: bash + + host.capacityType.to.order.clusters: COMBINED + host.capacityType.to.order.clusters.cputomemoryweight: 0.7 + +Above config prioritizes CPU at 70% weight and RAM at 30% when ranking pods, clusters, and hosts. + +.. note:: + - `host.capacityType.to.order.clusters` is only respected for host ordering when: + .. code:: bash + + vm.allocation.algorithm: firstfitleastconsumed + - When using COMBINED, make sure to tune cpu.to.memory.capacity.weight to reflect your environment’s resource constraints and workload profiles.
Re: [PR] GUI whitelabel runtime system [cloudstack]
blueorangutan commented on PR #8942: URL: https://github.com/apache/cloudstack/pull/8942#issuecomment-3073194185 @sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Switch to jdk18on bouncycastle jars [cloudstack]
blueorangutan commented on PR #11201: URL: https://github.com/apache/cloudstack/pull/11201#issuecomment-3073191235 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix update resource count failure for domains [cloudstack]
sonarqubecloud[bot] commented on PR #11138: URL: https://github.com/apache/cloudstack/pull/11138#issuecomment-3073197040 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11138) **Quality Gate failed** Failed conditions  [7.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11138&metric=new_coverage&view=list) (required ≥ 40%) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11138) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GUI whitelabel runtime system [cloudstack]
blueorangutan commented on PR #8942: URL: https://github.com/apache/cloudstack/pull/8942#issuecomment-3073197308 UI build failed: :heavy_multiplication_x: (SL-JID-668) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI fix api in project view [cloudstack]
blueorangutan commented on PR #11191: URL: https://github.com/apache/cloudstack/pull/11191#issuecomment-3073203436 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11191 (QA-JID-667) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Switch to jdk18on bouncycastle jars [cloudstack]
codecov[bot] commented on PR #11201: URL: https://github.com/apache/cloudstack/pull/11201#issuecomment-3073204381 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11201?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.28%. Comparing base [(`06c80cd`)](https://app.codecov.io/gh/apache/cloudstack/commit/06c80cdbe9149abdf86a20df27b620b379e5e1b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`4fc2abe`)](https://app.codecov.io/gh/apache/cloudstack/commit/4fc2abe6c67bb218caf54ab4cbf987bf35146b62?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (06c80cd) and HEAD (4fc2abe). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (06c80cd) | HEAD (4fc2abe) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #11201 +/- ## = - Coverage 15.18%4.28% -10.91% = Files 5415 372 -5043 Lines47588829743 -446145 Branches 58094 5229-52865 = - Hits 72256 1274-70982 + Misses 39554628324 -367222 + Partials 8086 145 -7941 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11201/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11201/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.28% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11201/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11201?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: Use template's uuid if pool's downloadPath is null as resour… [cloudstack]
DaanHoogland commented on PR #11053: URL: https://github.com/apache/cloudstack/pull/11053#issuecomment-3073207221 > > @rp- @ghernadi you guys want this on main only? > > This should be in 4.19, 4.20 and 4.21/main. As it is basically a regression bug fix. ok, can you rebase? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Delay of connection to vm console [cloudstack]
SviridoffA commented on issue #10648: URL: https://github.com/apache/cloudstack/issues/10648#issuecomment-3073209395 @DaanHoogland Sounds great!!! > Are you saying that latency of 4.19.3 is yet higher than for 4.19.2? No, it's absolutely the same, and the growth is still the same. Just wanted to highlight that nothing has changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI fix api in project view [cloudstack]
blueorangutan commented on PR #11191: URL: https://github.com/apache/cloudstack/pull/11191#issuecomment-3073230356 @vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix local storage pool disconnect issue [cloudstack]
blueorangutan commented on PR #11200: URL: https://github.com/apache/cloudstack/pull/11200#issuecomment-3072800259 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow full clone volumes with thin provisioning [cloudstack]
slavkap commented on PR #11177: URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3073096971 For me, the code looks good, but my only concern here is that the configuration `create.full.clone` should come from the management service as an API parameter or a property of a volume/VM, or template (I'm not sure exactly where). This is in case the administrators want some volumes to be full cloned and others not. In that case, they should change the value of the configuration every time from the agent.properties file, and restart the agent service -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: Use template's uuid if pool's downloadPath is null as resour… [cloudstack]
DaanHoogland commented on PR #11053: URL: https://github.com/apache/cloudstack/pull/11053#issuecomment-3073110721 @rp- @ghernadi you guys want this on main only? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] schema, refactor: rename cloud.user_vm_details to cloud.vm_instance_details [cloudstack]
DaanHoogland commented on PR #10736: URL: https://github.com/apache/cloudstack/pull/10736#issuecomment-3073122360 @shwstppr can you look at the conflicts? @sureshanaparti can we try to get this in? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: Use template's uuid if pool's downloadPath is null as resour… [cloudstack]
rp- commented on PR #11053: URL: https://github.com/apache/cloudstack/pull/11053#issuecomment-3073136370 > @rp- @ghernadi you guys want this on main only? This should be in 4.19, 4.20 and 4.21/main. As it is basically a regression bug fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Delay of connection to vm console [cloudstack]
DaanHoogland commented on issue #10648: URL: https://github.com/apache/cloudstack/issues/10648#issuecomment-3073132612 @SviridoffA, we are in the process of updating the noVNC version. It might help your issue. Are you saying that latency of 4.19.3 is yet higher than for 4.19.2? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] API to list console sessions [cloudstack]
bernardodemarco commented on PR #11016: URL: https://github.com/apache/cloudstack/pull/11016#issuecomment-3073295436 > edit: except for the conflict @bernardodemarco @DaanHoogland, done! > btw, I think this PR is good to merge, @sureshanaparti !? Yes, I agree. The integration tests ran here https://github.com/apache/cloudstack/pull/11016#issuecomment-3057111018, an unrelated test returned an error and, after that, no other changes were added to the PR (except for merging it with the updated `main` branch) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
rohityadavcloud commented on PR #9: URL: https://github.com/apache/cloudstack/pull/9#issuecomment-3073292309 I've public rpm repo here for anyone wanting to try/test this https://build.yadav.cloud/cloudstack/pr/9/el8/4.21/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] AJAX console does not work [cloudstack]
rohityadavcloud commented on issue #11194: URL: https://github.com/apache/cloudstack/issues/11194#issuecomment-3073295277 Yes it does not work, that's the issue reported :) I'll try to check if it works if VNC/TLS is disabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [cloud_usage] vm_instance_id is null for volume usage (usage_type = 6) [cloudstack]
sudo87 commented on issue #10985: URL: https://github.com/apache/cloudstack/issues/10985#issuecomment-3073332787 @DaanHoogland we have similar ticket https://github.com/apache/cloudstack/issues/7399 and based on prior discussion on that ticket, it will require functional definition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI fix api in project view [cloudstack]
vishesh92 commented on PR #11191: URL: https://github.com/apache/cloudstack/pull/11191#issuecomment-3073336093 > code looks good and reviewed the deploy instance from image dropdown. To be clear @vishesh92 this is a regression on 4.21-HEAD only right? none of the functionality existed in 4.20? Yes. This is in main branch only as of now and didn't exist in 4.20. Also, we will need to fix the api calls after forward merging UI related changes from previous versions. Some of the bugs @rosi-shapeblue shared with me were: * Cannot Remove Host Tag from UI Once Set * Instances are not visible when deployed in project -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Delay of connection to vm console [cloudstack]
SviridoffA commented on issue #10648: URL: https://github.com/apache/cloudstack/issues/10648#issuecomment-3072884086 Just a small, useless update :). I upgraded Cloudstack to 4.19.3 two weeks ago. I upgraded all management servers and upgraded agents on the KVM nodes. I didn’t upgrade qemu and libvirt this time around. Over the past two weeks, latency on one of the nodes has increased to three seconds, and on another to two seconds, while the rest remain without latency issues. Unfortunately, I still haven’t found anything suspicious in the logs or connections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Create new Instance from VM backup [cloudstack]
rosi-shapeblue commented on PR #10140: URL: https://github.com/apache/cloudstack/pull/10140#issuecomment-3072825101 ### QA Verification Summary for **Create Instance from Backup** Feature All major workflows, APIs, and edge cases have been verified successfully on multiple environments (including cross-version restore and creation of an instance from a backup). ### High-level Overview by Test Areas: **Backup Creation / Create Instance from Backup** - Tested backup creation via API (create backup) and UI. - Verified full instance configuration captured in backup metadata. - Verified scheduled and manual backup workflows through API. - Confirmed usage tracking per backup offering. - Fully tested create vmfrombackup API for: - Standard scenarios. - Create an instance from backup when the original instance is expunged. - Configuration overrides (compute offering, disk offering, network, ssh keys, etc.). - Restore with preserve IP option. - Restore of a single volume. - Verified error handling for missing resources and broken metadata. - Confirmed API responses include correct instance/backup references. **Plugin Support** - Verified Dummy, NAS (NFS, CIFS, CephFS), and Veeam plugin workflows via API and UI. - Tested NAS host dependencies and storage configurations. - Verified Veeam plugin integration for backup/restore. - Verified restore/create instance (on v4.21) from a backup created at v4.20 **UI Behavior** - Checked metadata display, restore config prefill, and override options. - Verified restore type selection and plugin visibility. **Alerts & System Integrity** - Tested alerts on storage thresholds and manual capacity configuration. - Ensured backups and restored instances persist after expunge. - Confirmed audit logging and system stability under normal load. **Negative & Edge Cases** - Blocked invalid API calls (e.g., missing offering, broken metadata,). - Handled backup plugin unavailability and full storage gracefully. - Verified no orphaned volumes remain after cleanup. ### Detailed Overview of the Test Cases Execution [REPORT_TEST_CASE_EXECUTION_PDF_2025-07-15T09_10_10.534.pdf](https://github.com/user-attachments/files/21229617/REPORT_TEST_CASE_EXECUTION_PDF_2025-07-15T09_10_10.534.pdf) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix local storage pool disconnect issue [cloudstack]
codecov[bot] commented on PR #11200: URL: https://github.com/apache/cloudstack/pull/11200#issuecomment-3072822578 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11200?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 3.91%. Comparing base [(`6059724`)](https://app.codecov.io/gh/apache/cloudstack/commit/6059724189759470208a8e135744314119323534?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`26dcad9`)](https://app.codecov.io/gh/apache/cloudstack/commit/26dcad9a55b22d3fc7f91acf3aa123c64acf32a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 1 commits behind head on main. > :exclamation: There is a different number of reports uploaded between BASE (6059724) and HEAD (26dcad9). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (6059724) | HEAD (26dcad9) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11200 +/- ## = - Coverage 16.58%3.91% -12.67% = Files 5745 416 -5329 Lines51075733848 -476909 Branches 62144 6078-56066 = - Hits 84690 1324-83366 + Misses 41659832366 -384232 + Partials 9469 158 -9311 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11200/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11200/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.91% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11200/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11200?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OVM deprecation [cloudstack]
JoaoJandre commented on PR #11196: URL: https://github.com/apache/cloudstack/pull/11196#issuecomment-3073253537 > @sureshanaparti @JoaoJandre, can you guys have a look please? Will do, soon ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI fix api in project view [cloudstack]
vishesh92 commented on PR #11191: URL: https://github.com/apache/cloudstack/pull/11191#issuecomment-3073228079 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] File-based disk-only VM snapshot with KVM as hypervisor [cloudstack]
JoaoJandre commented on PR #10632:
URL: https://github.com/apache/cloudstack/pull/10632#issuecomment-3073264257
> I checked the debian build in the background. There is nothing wrong. It
was one of those timing unit-test that failed
>
> ```
> 18:11:30 [ERROR]
ConfigKeyScheduledExecutionWrapperTest.scheduleDynamicTest:110 Runnable ran
four times per second
> 18:11:30 Expected: one of {<7>, <8>}
> 18:11:30 but: was <6>
> ```
>
> I think we should modify those to be more robust to virtualised
environments.
Thanks for checking. I agree we should make these tests more robust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] linstor: Use template's uuid if pool's downloadPath is null as resour… [cloudstack]
github-actions[bot] commented on PR #11053: URL: https://github.com/apache/cloudstack/pull/11053#issuecomment-3073265260 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: Use template's uuid if pool's downloadPath is null as resour… [cloudstack]
rp- commented on PR #11053: URL: https://github.com/apache/cloudstack/pull/11053#issuecomment-3073266958 > > > @rp- @ghernadi you guys want this on main only? > > > > > > This should be in 4.19, 4.20 and 4.21/main. As it is basically a regression bug fix. > > ok, can you rebase? Oh sorry, I thought this was already on 4.19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] File-based disk-only VM snapshot with KVM as hypervisor [cloudstack]
DaanHoogland commented on PR #10632: URL: https://github.com/apache/cloudstack/pull/10632#issuecomment-3073269404 > > I checked the debian build in the background. There is nothing wrong. It was one of those timing unit-test that failed fyi I ran the build in the background and it passes without issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow full clone volumes with thin provisioning [cloudstack]
weizhouapache commented on PR #11177: URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3073269483 > For me, the code looks good, but my only concern here is that the configuration `create.full.clone` should come from the management service as an API parameter or a property of a volume/VM, or template (I'm not sure exactly where). This is in case the administrators want some volumes to be full cloned and others not. In that case, they should change the value of the configuration every time from the agent.properties file, and restart the agent service makes sense -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: Use template's uuid if pool's downloadPath is null as resour… [cloudstack]
DaanHoogland commented on PR #11053: URL: https://github.com/apache/cloudstack/pull/11053#issuecomment-3073271676 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: Use template's uuid if pool's downloadPath is null as resour… [cloudstack]
blueorangutan commented on PR #11053: URL: https://github.com/apache/cloudstack/pull/11053#issuecomment-3073274115 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI fix api in project view [cloudstack]
blueorangutan commented on PR #11191: URL: https://github.com/apache/cloudstack/pull/11191#issuecomment-3073281471 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11191 (QA-JID-669) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix local storage pool disconnect issue [cloudstack]
harikrishna-patnala opened a new pull request, #11200:
URL: https://github.com/apache/cloudstack/pull/11200
### Description
This PR fixes the issue #11104 which is a regression from
https://github.com/apache/cloudstack/pull/10381. Prior to the PR
https://github.com/apache/cloudstack/pull/10381 local storage connection
management is skipped in StoragePoolMonitor. Here in this PR, added the same
workflow.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### How Has This Been Tested?
1. Had an environment with a KVM host and local storage
2. Tried restarting the KVM agent
3. Before this fix, local storage is disconnected on host, so was unable to
use the local storage even though it shows in UI. Now with the fix, storage
connection remains the same and I'm able to use the storage for volume
provisioning.
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix local storage pool disconnect issue [cloudstack]
harikrishna-patnala commented on PR #11200: URL: https://github.com/apache/cloudstack/pull/11200#issuecomment-3072798490 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OVM deprecation [cloudstack]
DaanHoogland commented on PR #11196: URL: https://github.com/apache/cloudstack/pull/11196#issuecomment-3072894349 @sureshanaparti @JoaoJandre, can you guys have a look please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OVM deprecation [cloudstack]
blueorangutan commented on PR #11196: URL: https://github.com/apache/cloudstack/pull/11196#issuecomment-3072902868 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OVM deprecation [cloudstack]
DaanHoogland commented on PR #11196: URL: https://github.com/apache/cloudstack/pull/11196#issuecomment-3072896938 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix HTML license; standardize HTML code [cloudstack]
codecov[bot] commented on PR #11067: URL: https://github.com/apache/cloudstack/pull/11067#issuecomment-3073026020 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11067?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 17.47%. Comparing base [(`5b7c3b4`)](https://app.codecov.io/gh/apache/cloudstack/commit/5b7c3b475e39eed3872a9f8f9dc8cb68ddd21302?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`d64428a`)](https://app.codecov.io/gh/apache/cloudstack/commit/d64428ab417135346314d33b3eaccb3766fc875b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 34 commits behind head on main. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11067 +/- ## + Coverage 16.57% 17.47% +0.89% - Complexity1396713968 +1 Files 5743 5329 -414 Lines510468 476724 -33744 Branches 6207355999-6074 - Hits 8461683296-1320 + Misses 416390 384121 -32269 + Partials 9462 9307 -155 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11067/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11067/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11067/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `17.47% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11067?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch ghi11100-resource-count updated (9d01e3b5fb0 -> 84577e8ae70)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch ghi11100-resource-count in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard 9d01e3b5fb0 Revert "Fix update resource count failure for domains" discard f23b774575e make sure account is only considered when given (and deal with some warnings) add 76b9a75955e make sure account is only considered when given (and deal with some warnings) add 84577e8ae70 Revert "Fix update resource count failure for domains" This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (9d01e3b5fb0) \ N -- N -- N refs/heads/ghi11100-resource-count (84577e8ae70) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../java/com/cloud/resourcelimit/ResourceLimitManagerImpl.java | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)
(cloudstack) branch ghi11100-resource-count updated (504cdb8549c -> 9d01e3b5fb0)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch ghi11100-resource-count in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 504cdb8549c Fix update resource count failure for domains add f23b774575e make sure account is only considered when given (and deal with some warnings) add 9d01e3b5fb0 Revert "Fix update resource count failure for domains" No new revisions were added by this update. Summary of changes: .../resourcelimit/ResourceLimitManagerImpl.java| 102 ++--- ui/src/config/section/domain.js| 5 +- 2 files changed, 49 insertions(+), 58 deletions(-)
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
github-actions[bot] commented on PR #10997: URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-3073022788 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] API to list console sessions [cloudstack]
github-actions[bot] commented on PR #11016: URL: https://github.com/apache/cloudstack/pull/11016#issuecomment-3073022840 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
