svn commit: r747427 - /commons/proper/commons-parent/trunk/pom.xml

2009-02-24 Thread dennisl
Author: dennisl
Date: Tue Feb 24 16:52:15 2009
New Revision: 747427

URL: http://svn.apache.org/viewvc?rev=747427view=rev
Log:
o Improve manifest in javadoc jar, by adding implementation and specification 
entries

Modified:
commons/proper/commons-parent/trunk/pom.xml

Modified: commons/proper/commons-parent/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=747427r1=747426r2=747427view=diff
==
--- commons/proper/commons-parent/trunk/pom.xml (original)
+++ commons/proper/commons-parent/trunk/pom.xml Tue Feb 24 16:52:15 2009
@@ -166,6 +166,12 @@
   artifactIdmaven-javadoc-plugin/artifactId
   version2.5/version
   configuration
+archive
+  manifest
+
addDefaultImplementationEntriestrue/addDefaultImplementationEntries
+
addDefaultSpecificationEntriestrue/addDefaultSpecificationEntries
+  /manifest
+/archive
 encoding${commons.encoding}/encoding
 docEncoding${commons.docEncoding}/docEncoding
   /configuration




svn commit: r747449 - in /commons/sandbox/dbutils/bugfixing/src: java/org/apache/commons/dbutils/QueryRunner.java test/org/apache/commons/dbutils/QueryRunnerTest.java

2009-02-24 Thread dfabulich
Author: dfabulich
Date: Tue Feb 24 17:30:59 2009
New Revision: 747449

URL: http://svn.apache.org/viewvc?rev=747449view=rev
Log:
fillStatementWithBean: tweaked exception handling, added unit test

Added:

commons/sandbox/dbutils/bugfixing/src/test/org/apache/commons/dbutils/QueryRunnerTest.java
Modified:

commons/sandbox/dbutils/bugfixing/src/java/org/apache/commons/dbutils/QueryRunner.java

Modified: 
commons/sandbox/dbutils/bugfixing/src/java/org/apache/commons/dbutils/QueryRunner.java
URL: 
http://svn.apache.org/viewvc/commons/sandbox/dbutils/bugfixing/src/java/org/apache/commons/dbutils/QueryRunner.java?rev=747449r1=747448r2=747449view=diff
==
--- 
commons/sandbox/dbutils/bugfixing/src/java/org/apache/commons/dbutils/QueryRunner.java
 (original)
+++ 
commons/sandbox/dbutils/bugfixing/src/java/org/apache/commons/dbutils/QueryRunner.java
 Tue Feb 24 17:30:59 2009
@@ -19,6 +19,8 @@
 import java.beans.IntrospectionException;
 import java.beans.Introspector;
 import java.beans.PropertyDescriptor;
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
 import java.sql.Connection;
 import java.sql.ParameterMetaData;
 import java.sql.PreparedStatement;
@@ -212,16 +214,19 @@
 for (int i = 0; i  properties.length; i++) {
 PropertyDescriptor property = properties[i];
 Object value = null;
+Method method = property.getReadMethod();
+if (method == null)
+throw new RuntimeException(No read method for bean property 
++ bean.getClass() +   + property.getName());
 try {
-if (property.getReadMethod().getParameterTypes().length  0) {
-throw new SQLException(
-Can't use an indexed bean property as a SQL 
parameter: 
-+ property.getName());
-}
-value = property.getReadMethod().invoke(bean, new Object[0]);
-} catch (Exception e) {
-throw new RuntimeException(e);
-}
+value = method.invoke(bean, new Object[0]);
+} catch (InvocationTargetException e) {
+throw new RuntimeException(Couldn't invoke method:  + 
method, e);
+} catch (IllegalArgumentException e) {
+throw new RuntimeException(Couldn't invoke method with 0 
arguments:  + method, e);
+} catch (IllegalAccessException e) {
+throw new RuntimeException(Couldn't invoke method:  + 
method, e);
+} 
 params[i] = value;
 }
 fillStatement(stmt, params);
@@ -249,14 +254,13 @@
 descriptors = Introspector.getBeanInfo(bean.getClass())
 .getPropertyDescriptors();
 } catch (IntrospectionException e) {
-throw new RuntimeException(e);
+throw new RuntimeException(Couldn't introspect bean  + 
bean.getClass().toString(), e);
 }
 PropertyDescriptor[] sorted = new 
PropertyDescriptor[propertyNames.length];
 for (int i = 0; i  propertyNames.length; i++) {
 String propertyName = propertyNames[i];
 if (propertyName == null)
-throw new NullPointerException(propertyName can't be null: 
-+ i);
+throw new NullPointerException(propertyName can't be null:  
+ i);
 boolean found = false;
 for (int j = 0; j  descriptors.length; j++) {
 PropertyDescriptor descriptor = descriptors[j];

Added: 
commons/sandbox/dbutils/bugfixing/src/test/org/apache/commons/dbutils/QueryRunnerTest.java
URL: 
http://svn.apache.org/viewvc/commons/sandbox/dbutils/bugfixing/src/test/org/apache/commons/dbutils/QueryRunnerTest.java?rev=747449view=auto
==
--- 
commons/sandbox/dbutils/bugfixing/src/test/org/apache/commons/dbutils/QueryRunnerTest.java
 (added)
+++ 
commons/sandbox/dbutils/bugfixing/src/test/org/apache/commons/dbutils/QueryRunnerTest.java
 Tue Feb 24 17:30:59 2009
@@ -0,0 +1,124 @@
+package org.apache.commons.dbutils;
+
+import java.beans.IndexedPropertyDescriptor;
+import java.beans.PropertyDescriptor;
+import java.lang.reflect.InvocationHandler;
+import java.lang.reflect.Method;
+import java.sql.PreparedStatement;
+import java.sql.SQLException;
+import java.util.Arrays;
+
+import junit.framework.TestCase;
+
+public class QueryRunnerTest extends TestCase {
+QueryRunner runner;
+PreparedStatement stmt;
+
+public void setUp() {
+runner = new QueryRunner();
+stmt = fakePreparedStatement();
+}
+
+public void testFillStatementWithBean() throws SQLException {
+TestBean tb = new TestBean();
+tb.setOne(uno);
+tb.setTwo(dos);
+tb.setThree(tres);

svn commit: r747452 - in /commons/sandbox/dbutils/java5: ./ src/java/org/apache/commons/dbutils/QueryRunner.java src/test/org/apache/commons/dbutils/QueryRunnerTest.java

2009-02-24 Thread dfabulich
Author: dfabulich
Date: Tue Feb 24 17:35:05 2009
New Revision: 747452

URL: http://svn.apache.org/viewvc?rev=747452view=rev
Log:
merged from bugfixing branch

Added:

commons/sandbox/dbutils/java5/src/test/org/apache/commons/dbutils/QueryRunnerTest.java
  - copied, changed from r747450, 
commons/sandbox/dbutils/bugfixing/src/test/org/apache/commons/dbutils/QueryRunnerTest.java
Modified:
commons/sandbox/dbutils/java5/   (props changed)

commons/sandbox/dbutils/java5/src/java/org/apache/commons/dbutils/QueryRunner.java

Propchange: commons/sandbox/dbutils/java5/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Feb 24 17:35:05 2009
@@ -1 +1,4 @@
-/commons/sandbox/dbutils/bugfixing:741988-743293
+/commons/commons/proper/dbutils/trunk:560657
+/commons/proper/dbutils/trunk:560660-741986
+/commons/sandbox/dbutils/bugfixing:741987-747450
+/jakarta/commons/proper/dbutils/trunk:141655-560656,560658-560659

Modified: 
commons/sandbox/dbutils/java5/src/java/org/apache/commons/dbutils/QueryRunner.java
URL: 
http://svn.apache.org/viewvc/commons/sandbox/dbutils/java5/src/java/org/apache/commons/dbutils/QueryRunner.java?rev=747452r1=747451r2=747452view=diff
==
--- 
commons/sandbox/dbutils/java5/src/java/org/apache/commons/dbutils/QueryRunner.java
 (original)
+++ 
commons/sandbox/dbutils/java5/src/java/org/apache/commons/dbutils/QueryRunner.java
 Tue Feb 24 17:35:05 2009
@@ -19,6 +19,8 @@
 import java.beans.IntrospectionException;
 import java.beans.Introspector;
 import java.beans.PropertyDescriptor;
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
 import java.sql.Connection;
 import java.sql.ParameterMetaData;
 import java.sql.PreparedStatement;
@@ -212,16 +214,19 @@
 for (int i = 0; i  properties.length; i++) {
 PropertyDescriptor property = properties[i];
 Object value = null;
+Method method = property.getReadMethod();
+if (method == null)
+throw new RuntimeException(No read method for bean property 
++ bean.getClass() +   + property.getName());
 try {
-if (property.getReadMethod().getParameterTypes().length  0) {
-throw new SQLException(
-Can't use an indexed bean property as a SQL 
parameter: 
-+ property.getName());
-}
-value = property.getReadMethod().invoke(bean, new Object[0]);
-} catch (Exception e) {
-throw new RuntimeException(e);
-}
+value = method.invoke(bean, new Object[0]);
+} catch (InvocationTargetException e) {
+throw new RuntimeException(Couldn't invoke method:  + 
method, e);
+} catch (IllegalArgumentException e) {
+throw new RuntimeException(Couldn't invoke method with 0 
arguments:  + method, e);
+} catch (IllegalAccessException e) {
+throw new RuntimeException(Couldn't invoke method:  + 
method, e);
+} 
 params[i] = value;
 }
 fillStatement(stmt, params);
@@ -249,14 +254,13 @@
 descriptors = Introspector.getBeanInfo(bean.getClass())
 .getPropertyDescriptors();
 } catch (IntrospectionException e) {
-throw new RuntimeException(e);
+throw new RuntimeException(Couldn't introspect bean  + 
bean.getClass().toString(), e);
 }
 PropertyDescriptor[] sorted = new 
PropertyDescriptor[propertyNames.length];
 for (int i = 0; i  propertyNames.length; i++) {
 String propertyName = propertyNames[i];
 if (propertyName == null)
-throw new NullPointerException(propertyName can't be null: 
-+ i);
+throw new NullPointerException(propertyName can't be null:  
+ i);
 boolean found = false;
 for (int j = 0; j  descriptors.length; j++) {
 PropertyDescriptor descriptor = descriptors[j];

Copied: 
commons/sandbox/dbutils/java5/src/test/org/apache/commons/dbutils/QueryRunnerTest.java
 (from r747450, 
commons/sandbox/dbutils/bugfixing/src/test/org/apache/commons/dbutils/QueryRunnerTest.java)
URL: 
http://svn.apache.org/viewvc/commons/sandbox/dbutils/java5/src/test/org/apache/commons/dbutils/QueryRunnerTest.java?p2=commons/sandbox/dbutils/java5/src/test/org/apache/commons/dbutils/QueryRunnerTest.javap1=commons/sandbox/dbutils/bugfixing/src/test/org/apache/commons/dbutils/QueryRunnerTest.javar1=747450r2=747452rev=747452view=diff
==
--- 
commons/sandbox/dbutils/bugfixing/src/test/org/apache/commons/dbutils/QueryRunnerTest.java
 

svn commit: r747469 - /commons/sandbox/validator2/tags/old_validator/

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:21:01 2009
New Revision: 747469

URL: http://svn.apache.org/viewvc?rev=747469view=rev
Log:
creating a directory of the old validator project under the tags directory

Added:
commons/sandbox/validator2/tags/old_validator/



svn commit: r747472 - /commons/sandbox/validator2/tags/old_validator/trunk/

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:23:55 2009
New Revision: 747472

URL: http://svn.apache.org/viewvc?rev=747472view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/trunk/
  - copied from r747471, commons/sandbox/validator2/trunk/



svn commit: r747473 - /commons/sandbox/validator2/tags/old_validator/trunk/

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:25:34 2009
New Revision: 747473

URL: http://svn.apache.org/viewvc?rev=747473view=rev
Log:
Correcting a copy error

Removed:
commons/sandbox/validator2/tags/old_validator/trunk/



svn commit: r747474 - /commons/sandbox/validator2/tags/old_validator/trunk/

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:26:24 2009
New Revision: 747474

URL: http://svn.apache.org/viewvc?rev=747474view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/trunk/
  - copied from r747473, commons/sandbox/validator2/trunk/



svn commit: r747475 - /commons/sandbox/validator2/tags/old_validator/trunk/

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:26:49 2009
New Revision: 747475

URL: http://svn.apache.org/viewvc?rev=747475view=rev
Log:
Correcting a copy error

Removed:
commons/sandbox/validator2/tags/old_validator/trunk/



svn commit: r747478 - /commons/sandbox/validator2/tags/old_validator/trunk/

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:32:56 2009
New Revision: 747478

URL: http://svn.apache.org/viewvc?rev=747478view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/trunk/
  - copied from r747477, commons/sandbox/validator2/trunk/



svn commit: r747482 - /commons/sandbox/validator2/tags/old_validator/LICENSE.txt

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:40:36 2009
New Revision: 747482

URL: http://svn.apache.org/viewvc?rev=747482view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/LICENSE.txt
  - copied unchanged from r747481, 
commons/sandbox/validator2/tags/old_validator/trunk/LICENSE.txt



svn commit: r747484 - /commons/sandbox/validator2/tags/old_validator/NOTICE.txt

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:43:31 2009
New Revision: 747484

URL: http://svn.apache.org/viewvc?rev=747484view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/NOTICE.txt
  - copied unchanged from r747482, 
commons/sandbox/validator2/tags/old_validator/trunk/NOTICE.txt



svn commit: r747485 - /commons/sandbox/validator2/tags/old_validator/PROPOSAL.html

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:45:32 2009
New Revision: 747485

URL: http://svn.apache.org/viewvc?rev=747485view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/PROPOSAL.html
  - copied unchanged from r747484, 
commons/sandbox/validator2/tags/old_validator/trunk/PROPOSAL.html



svn commit: r747486 - /commons/sandbox/validator2/tags/old_validator/RELEASE-NOTES.txt

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:46:40 2009
New Revision: 747486

URL: http://svn.apache.org/viewvc?rev=747486view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/RELEASE-NOTES.txt
  - copied unchanged from r747485, 
commons/sandbox/validator2/tags/old_validator/trunk/RELEASE-NOTES.txt



svn commit: r747487 - /commons/sandbox/validator2/tags/old_validator/STATUS.html

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:47:17 2009
New Revision: 747487

URL: http://svn.apache.org/viewvc?rev=747487view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/STATUS.html
  - copied unchanged from r747486, 
commons/sandbox/validator2/tags/old_validator/trunk/STATUS.html



svn commit: r747488 - /commons/sandbox/validator2/tags/old_validator/build-javascript.xml

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:48:09 2009
New Revision: 747488

URL: http://svn.apache.org/viewvc?rev=747488view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/build-javascript.xml
  - copied unchanged from r747487, 
commons/sandbox/validator2/tags/old_validator/trunk/build-javascript.xml



svn commit: r747490 - /commons/sandbox/validator2/tags/old_validator/build.properties.sample

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:48:57 2009
New Revision: 747490

URL: http://svn.apache.org/viewvc?rev=747490view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/build.properties.sample
  - copied unchanged from r747489, 
commons/sandbox/validator2/tags/old_validator/trunk/build.properties.sample



svn commit: r747491 - /commons/sandbox/validator2/tags/old_validator/build.xml

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:50:03 2009
New Revision: 747491

URL: http://svn.apache.org/viewvc?rev=747491view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/build.xml
  - copied unchanged from r747490, 
commons/sandbox/validator2/tags/old_validator/trunk/build.xml



svn commit: r747493 - /commons/sandbox/validator2/tags/old_validator/checkstyle.xml

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:50:43 2009
New Revision: 747493

URL: http://svn.apache.org/viewvc?rev=747493view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/checkstyle.xml
  - copied unchanged from r747491, 
commons/sandbox/validator2/tags/old_validator/trunk/checkstyle.xml



svn commit: r747494 - /commons/sandbox/validator2/tags/old_validator/doap_validator.rdf

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:51:14 2009
New Revision: 747494

URL: http://svn.apache.org/viewvc?rev=747494view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/doap_validator.rdf
  - copied unchanged from r747493, 
commons/sandbox/validator2/tags/old_validator/trunk/doap_validator.rdf



svn commit: r747498 - /commons/sandbox/validator2/tags/old_validator/maven.xml

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:52:57 2009
New Revision: 747498

URL: http://svn.apache.org/viewvc?rev=747498view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/maven.xml
  - copied unchanged from r747497, 
commons/sandbox/validator2/tags/old_validator/trunk/maven.xml



svn commit: r747499 - /commons/sandbox/validator2/tags/old_validator/pom.xml

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:53:23 2009
New Revision: 747499

URL: http://svn.apache.org/viewvc?rev=747499view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/pom.xml
  - copied unchanged from r747498, 
commons/sandbox/validator2/tags/old_validator/trunk/pom.xml



svn commit: r747500 - /commons/sandbox/validator2/tags/old_validator/project.properties

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:54:37 2009
New Revision: 747500

URL: http://svn.apache.org/viewvc?rev=747500view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/project.properties
  - copied unchanged from r747499, 
commons/sandbox/validator2/tags/old_validator/trunk/project.properties



svn commit: r747501 - /commons/sandbox/validator2/tags/old_validator/project.xml

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:56:14 2009
New Revision: 747501

URL: http://svn.apache.org/viewvc?rev=747501view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/project.xml
  - copied unchanged from r747500, 
commons/sandbox/validator2/tags/old_validator/trunk/project.xml



svn commit: r747502 - /commons/sandbox/validator2/tags/old_validator/src/

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:56:42 2009
New Revision: 747502

URL: http://svn.apache.org/viewvc?rev=747502view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/src/
  - copied from r747501, 
commons/sandbox/validator2/tags/old_validator/trunk/src/



svn commit: r747497 - /commons/sandbox/validator2/tags/old_validator/license-header.txt

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 18:52:26 2009
New Revision: 747497

URL: http://svn.apache.org/viewvc?rev=747497view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/license-header.txt
  - copied unchanged from r747496, 
commons/sandbox/validator2/tags/old_validator/trunk/license-header.txt



svn commit: r747513 - /commons/sandbox/validator2/tags/old_validator/xdocs/

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 19:22:14 2009
New Revision: 747513

URL: http://svn.apache.org/viewvc?rev=747513view=rev
Log:
copying the contents of the old validator code into the new directory under 
tags/old_validator

Added:
commons/sandbox/validator2/tags/old_validator/xdocs/
  - copied from r747512, 
commons/sandbox/validator2/tags/old_validator/trunk/xdocs/



svn commit: r747516 - /commons/sandbox/validator2/tags/old_validator/trunk/

2009-02-24 Thread mnour
Author: mnour
Date: Tue Feb 24 19:23:42 2009
New Revision: 747516

URL: http://svn.apache.org/viewvc?rev=747516view=rev
Log:
Correcting a copy error

Removed:
commons/sandbox/validator2/tags/old_validator/trunk/



svn commit: r747544 - in /commons/proper/math/trunk/src/java/org/apache/commons/math: MessagesResources_fr.java linear/RealVectorImpl.java linear/SparseRealVector.java

2009-02-24 Thread luc
Author: luc
Date: Tue Feb 24 20:59:41 2009
New Revision: 747544

URL: http://svn.apache.org/viewvc?rev=747544view=rev
Log:
minor code cleanups
(error messages, javadoc, avoiding array copies, final attributes ...)

Modified:

commons/proper/math/trunk/src/java/org/apache/commons/math/MessagesResources_fr.java

commons/proper/math/trunk/src/java/org/apache/commons/math/linear/RealVectorImpl.java

commons/proper/math/trunk/src/java/org/apache/commons/math/linear/SparseRealVector.java

Modified: 
commons/proper/math/trunk/src/java/org/apache/commons/math/MessagesResources_fr.java
URL: 
http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/MessagesResources_fr.java?rev=747544r1=747543r2=747544view=diff
==
--- 
commons/proper/math/trunk/src/java/org/apache/commons/math/MessagesResources_fr.java
 (original)
+++ 
commons/proper/math/trunk/src/java/org/apache/commons/math/MessagesResources_fr.java
 Tue Feb 24 20:59:41 2009
@@ -69,6 +69,7 @@
   Nombre maximal d''it\u00e9rations ({0}) d\u00e9pass\u00e9 },
 
 // org.apache.commons.math.DimensionMismatchException
+// org.apache.commons.math.optimization.LeastSquaresConverter
 { dimension mismatch {0} != {1},
   dimensions incompatibles {0} != {1} },
 
@@ -105,7 +106,7 @@
 { Conversion Exception in Transformation: {0},
   Exception de conversion dans une transformation : {0} },
 
-// org.apache.commons.math.estimation.AbstractEstimator
+// org.apache.commons.math.optimization.general.AbstractEstimator
 { maximal number of evaluations exceeded ({0}),
   nombre maximal d''\u00e9valuations d\u00e9pass\u00e9 ({0}) },
 { unable to compute covariances: singular problem,
@@ -113,11 +114,11 @@
 { no degrees of freedom ({0} measurements, {1} parameters),
   aucun degr\u00e9 de libert\u00e9 ({0} mesures, {1} param\u00e8tres) },
 
-// org.apache.commons.math.estimation.GaussNewtonEstimator
+// org.apache.commons.math.optimization.general.GaussNewtonEstimator
 { unable to solve: singular problem,
   r\u00e9solution impossible : probl\u00e8me singulier },
 
-// org.apache.commons.math.estimation.LevenbergMarquardtEstimator
+// org.apache.commons.math.optimization.general.LevenbergMarquardtEstimator
 { cost relative tolerance is too small ({0}), no further reduction in the 
sum of squares is possible,
   trop petite tol\u00e9rance relative sur le co\u00fbt ({0}), aucune 
r\u00e9duction de la somme des carr\u00e9s n''est possible },
 { parameters relative tolerance is too small ({0}), no further 
improvement in the approximate solution is possible,
@@ -167,11 +168,11 @@
   intervalle d''int\u00e9gration trop petit : {0} },
 
 // org.apache.commons.math.ode.ContinuousOutputModel
-// org.apache.commons.math.optimization.DirectSearchOptimizer
+// org.apache.commons.math.optimization.direct.DirectSearchOptimizer
 { unexpected exception caught,
   exception inattendue lev\u00e9e },
 
-// org.apache.commons.math.optimization.DirectSearchOptimizer
+// org.apache.commons.math.optimization.direct.DirectSearchOptimizer
 { none of the {0} start points lead to convergence,
   aucun des {0} points de d\u00e9part n''aboutit \u00e0 une convergence  
},
 
@@ -198,14 +199,27 @@
 // org.apache.commons.math.linear.decomposition.LUDecompositionImpl
 // org.apache.commons.math.linear.decomposition.QRDecompositionImpl
 // 
org.apache.commons.math.linear.decomposition.SingularValueDecompositionImpl
-{ vector length mismatch: got {0} but expected {1},
-  dimension de vecteur erronn\u00e9e : {0} \u00e0 la place de {1} },
 { dimensions mismatch: got {0}x{1} but expected {2}x{3},
   dimensions erronn\u00e9es : {0}x{1} \u00e0 la place de {2}x{3} },
+
+// org.apache.commons.math.linear.decomposition.CholeskyDecompositionImpl
+// org.apache.commons.math.linear.decomposition.EigenDecompositionImpl
+// org.apache.commons.math.linear.decomposition.LUDecompositionImpl
+// org.apache.commons.math.linear.decomposition.QRDecompositionImpl
+// 
org.apache.commons.math.linear.decomposition.SingularValueDecompositionImpl
+// org.apache.commons.math.linear.RealVectorImpl
+// org.apache.commons.math.linear.SparseRealVector
+{ vector length mismatch: got {0} but expected {1},
+  dimension de vecteur erronn\u00e9e : {0} \u00e0 la place de {1} },
   
 // org.apache.commons.math.linear.RealVectorImpl
+// org.apache.commons.math.linear.SparseRealVector
 { index {0} out of allowed range [{1}, {2}],
   index {0} hors de la plage autoris\u00e9e [{1}, {2}] },
+{ vector must have at least one element,
+  un vecteur doit comporter au moins un \u00e9l\u00e9ment },
+{ position {0} and size {1} don't fit to the size of the input array {2},
+  la position {0} et la taille {1} sont 

svn commit: r747557 - /commons/proper/exec/trunk/src/assembly/src.xml

2009-02-24 Thread sgoeschl
Author: sgoeschl
Date: Tue Feb 24 21:43:59 2009
New Revision: 747557

URL: http://svn.apache.org/viewvc?rev=747557view=rev
Log:
Added the findbugs configuration file to build the whole project from the 
source distribution.

Modified:
commons/proper/exec/trunk/src/assembly/src.xml

Modified: commons/proper/exec/trunk/src/assembly/src.xml
URL: 
http://svn.apache.org/viewvc/commons/proper/exec/trunk/src/assembly/src.xml?rev=747557r1=747556r2=747557view=diff
==
--- commons/proper/exec/trunk/src/assembly/src.xml (original)
+++ commons/proper/exec/trunk/src/assembly/src.xml Tue Feb 24 21:43:59 2009
@@ -29,6 +29,7 @@
 includeNOTICE.txt/include
 includepom.xml/include
 includeSTATUS/include
+includefindbugs-exclude-filter.xml/include
 /includes
 /fileSet
 fileSet




svn commit: r747558 - /commons/proper/exec/trunk/pom.xml

2009-02-24 Thread sgoeschl
Author: sgoeschl
Date: Tue Feb 24 21:45:27 2009
New Revision: 747558

URL: http://svn.apache.org/viewvc?rev=747558view=rev
Log:
Rolling back the release candidate

Modified:
commons/proper/exec/trunk/pom.xml

Modified: commons/proper/exec/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/commons/proper/exec/trunk/pom.xml?rev=747558r1=747557r2=747558view=diff
==
--- commons/proper/exec/trunk/pom.xml (original)
+++ commons/proper/exec/trunk/pom.xml Tue Feb 24 21:45:27 2009
@@ -27,7 +27,7 @@
   nameCommons Exec/name
   groupIdorg.apache.commons/groupId
   artifactIdcommons-exec/artifactId
-  version1.0.1-SNAPSHOT/version
+  version1.0.0-SNAPSHOT/version
   descriptionA library to reliably execute external processes from within 
the JVM/description
   urlhttp://commons.apache.org/exec//url  
   
@@ -186,7 +186,7 @@
 commons.jira.pid12310814/commons.jira.pid
 commons.release.version1.0.0/commons.release.version
 !-- The RC version used in the staging repository URL. --
-commons.rc.versionRC4/commons.rc.version
+commons.rc.versionRC5/commons.rc.version
   /properties
 
 /project




svn commit: r747581 - in /commons/proper/email/trunk: src/java/org/apache/commons/mail/Email.java xdocs/changes.xml

2009-02-24 Thread sgoeschl
Author: sgoeschl
Date: Tue Feb 24 22:21:25 2009
New Revision: 747581

URL: http://svn.apache.org/viewvc?rev=747581view=rev
Log:
[EMAIL-71]  Email.getHostName() throws NullPointerException

Modified:
commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java
commons/proper/email/trunk/xdocs/changes.xml

Modified: commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java
URL: 
http://svn.apache.org/viewvc/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java?rev=747581r1=747580r2=747581view=diff
==
--- commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java 
(original)
+++ commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java Tue 
Feb 24 22:21:25 2009
@@ -1239,10 +1239,11 @@
 {
 return this.hostName;
 }
-else
+else if (this.session != null)
 {
 return this.session.getProperty(MAIL_HOST);
 }
+return null;
 }
 
 /**
@@ -1256,10 +1257,11 @@
 {
 return this.smtpPort;
 }
-else
+else if (this.session != null)
 {
 return this.session.getProperty(MAIL_PORT);
 }
+return null;
 }
 
 /**
@@ -1339,10 +1341,11 @@
 {
 return this.sslSmtpPort;
 }
-else
+else if (this.session != null)
 {
 return this.session.getProperty(MAIL_SMTP_SOCKET_FACTORY_PORT);
 }
+return null;
 }
 
 /**

Modified: commons/proper/email/trunk/xdocs/changes.xml
URL: 
http://svn.apache.org/viewvc/commons/proper/email/trunk/xdocs/changes.xml?rev=747581r1=747580r2=747581view=diff
==
--- commons/proper/email/trunk/xdocs/changes.xml (original)
+++ commons/proper/email/trunk/xdocs/changes.xml Tue Feb 24 22:21:25 2009
@@ -24,6 +24,12 @@
   body
 
 release version=1.2-SNAPSHOT date=as in SVN
+  action dev=sgoeschl type=fix issue=EMAIL-71 date=2009-02-22 
due-to=Teemu Lang, Corey Scott
+If setHostName() has not been called, getHostName() tries to return
+this.session.getProperty(MAIL_HOST). If mail session has not been
+  created yet, this will throw a NullPointerException. Now 
getHostName()
+  checks that this.session is not null before trying to access it. 
 
+  /action
   action dev=sgoeschl type=fix issue=EMAIL-81 date=2009-02-22 
due-to=Travis Reader, Corey Scott
 Add getTo and getReplyTo to Email class.
   /action




svn commit: r747603 - /commons/proper/email/trunk/xdocs/changes.xml

2009-02-24 Thread sgoeschl
Author: sgoeschl
Date: Tue Feb 24 23:12:22 2009
New Revision: 747603

URL: http://svn.apache.org/viewvc?rev=747603view=rev
Log:
Corrected types - not all of the stuff was actually a fix

Modified:
commons/proper/email/trunk/xdocs/changes.xml

Modified: commons/proper/email/trunk/xdocs/changes.xml
URL: 
http://svn.apache.org/viewvc/commons/proper/email/trunk/xdocs/changes.xml?rev=747603r1=747602r2=747603view=diff
==
--- commons/proper/email/trunk/xdocs/changes.xml (original)
+++ commons/proper/email/trunk/xdocs/changes.xml Tue Feb 24 23:12:22 2009
@@ -24,7 +24,7 @@
   body
 
 release version=1.2-SNAPSHOT date=as in SVN
-  action dev=sgoeschl type=fix issue=EMAIL-74 date=2009-02-22 
due-to=Jim McCabe, Corey Scott
+  action dev=sgoeschl type=add issue=EMAIL-74 date=2009-02-22 
due-to=Jim McCabe, Corey Scott
 Create an overridable method in Email.java to create the MimeMessage 
instance.
   /action
   action dev=sgoeschl type=fix issue=EMAIL-71 date=2009-02-22 
due-to=Teemu Lang, Corey Scott
@@ -33,7 +33,7 @@
 created yet, this will throw a NullPointerException. Now getHostName()
 checks that this.session is not null before trying to access it.
   /action
-  action dev=sgoeschl type=fix issue=EMAIL-81 date=2009-02-22 
due-to=Travis Reader, Corey Scott
+  action dev=sgoeschl type=add issue=EMAIL-81 date=2009-02-22 
due-to=Travis Reader, Corey Scott
 Add getTo and getReplyTo to Email class.
   /action
   action dev=sgoeschl type=fix issue=EMAIL-78 date=2009-02-08 
due-to=Aaron Digulla, Corey Scott




svn commit: r747604 - in /commons/proper/email/trunk: src/java/org/apache/commons/mail/Email.java xdocs/changes.xml

2009-02-24 Thread sgoeschl
Author: sgoeschl
Date: Tue Feb 24 23:14:57 2009
New Revision: 747604

URL: http://svn.apache.org/viewvc?rev=747604view=rev
Log:
[EMAIL-84] Created additional methods to support timeouts

Modified:
commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java
commons/proper/email/trunk/xdocs/changes.xml

Modified: commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java
URL: 
http://svn.apache.org/viewvc/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java?rev=747604r1=747603r2=747604view=diff
==
--- commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java 
(original)
+++ commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java Tue 
Feb 24 23:14:57 2009
@@ -104,6 +104,21 @@
 public static final String MAIL_SMTP_SOCKET_FACTORY_CLASS = 
mail.smtp.socketFactory.class;
 /** */
 public static final String MAIL_SMTP_SOCKET_FACTORY_PORT = 
mail.smtp.socketFactory.port;
+
+   
+/**
+ * Socket connection timeout value in milliseconds. Default is infinite 
timeout.
+ * @since 1.2
+ */
+public static final String MAIL_SMTP_CONNECTIONTIMEOUT = 
mail.smtp.connectiontimeout;
+
+/**
+ * Socket I/O timeout value in milliseconds. Default is infinite timeout.
+ * @since 1.2  
+ */
+public static final String MAIL_SMTP_TIMEOUT = mail.smtp.timeout;
+
+
 /** */
 public static final String SMTP = smtp;
 /** */
@@ -220,6 +235,11 @@
 /** does the current transport use SSL encryption? */
 protected boolean ssl;
 
+/** socket I/O timeout value in milliseconds */
+protected int socketTimeout;
+/** socket connection timeout value in milliseconds */
+protected int socketConnectionTimeout;
+
 /** The Session to mail with */
 private Session session;
 
@@ -505,6 +525,16 @@
 properties.setProperty(MAIL_SMTP_FROM, this.bounceAddress);
 }
 
+if (this.socketTimeout  0)
+{
+properties.setProperty(MAIL_SMTP_TIMEOUT, 
Integer.toString(this.socketTimeout));
+}
+
+if (this.socketConnectionTimeout  0)
+{
+properties.setProperty(MAIL_SMTP_CONNECTIONTIMEOUT, 
Integer.toString(this.socketConnectionTimeout));
+}
+
 // changed this (back) to getInstance due to security exceptions
 // caused when testing using maven
 this.session =
@@ -1410,5 +1440,49 @@
 return this.replyList;
 }
 
+/**
+ * Get the socket connection timeout value in milliseconds.
+ *
+ * @return the timeout in milliseconds.
+ * @since 1.2
+ */
+public int getSocketConnectionTimeout()
+{
+return this.socketConnectionTimeout;
+}
+
+/**
+ * Set the socket connection timeout value in milliseconds.
+ * Default is infinite timeout.
+ *
+ * @param socketConnectionTimeout the connection timeout
+ * @since 1.2
+ */
+public void setSocketConnectionTimeout( int socketConnectionTimeout )
+{
+this.socketConnectionTimeout = socketConnectionTimeout;
+}
+
+/**
+ * Get the socket I/O timeout value in milliseconds.
+ *
+ * @return the socket I/O timeout
+ * @since 1.2
+ */
+public int getSocketTimeout()
+{
+return this.socketTimeout;
+}
 
+/**
+ * Set the socket I/O timeout value in milliseconds.
+ * Default is infinite timeout.
+ *
+ * @param socketTimeout the socket I/O timeout
+ * @since 1.2
+ */
+public void setSocketTimeout( int socketTimeout )
+{
+this.socketTimeout = socketTimeout;
+}
 }

Modified: commons/proper/email/trunk/xdocs/changes.xml
URL: 
http://svn.apache.org/viewvc/commons/proper/email/trunk/xdocs/changes.xml?rev=747604r1=747603r2=747604view=diff
==
--- commons/proper/email/trunk/xdocs/changes.xml (original)
+++ commons/proper/email/trunk/xdocs/changes.xml Tue Feb 24 23:14:57 2009
@@ -24,6 +24,9 @@
   body
 
 release version=1.2-SNAPSHOT date=as in SVN
+  action dev=sgoeschl type=add issue=EMAIL-84 date=2009-02-22 
due-to=Claudio Miranda
+Created additional methods to support timeouts.
+  /action
   action dev=sgoeschl type=add issue=EMAIL-74 date=2009-02-22 
due-to=Jim McCabe, Corey Scott
 Create an overridable method in Email.java to create the MimeMessage 
instance.
   /action




svn commit: r747617 - in /commons/proper/dbcp/trunk/src: java/org/apache/commons/dbcp/datasources/ test/org/apache/commons/dbcp/

2009-02-24 Thread sebb
Author: sebb
Date: Wed Feb 25 00:01:58 2009
New Revision: 747617

URL: http://svn.apache.org/viewvc?rev=747617view=rev
Log:
Javadoc corrections

Modified:

commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/CPDSConnectionFactory.java

commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/KeyedCPDSConnectionFactory.java

commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestConnectionPool.java
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java

Modified: 
commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/CPDSConnectionFactory.java
URL: 
http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/CPDSConnectionFactory.java?rev=747617r1=747616r2=747617view=diff
==
--- 
commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/CPDSConnectionFactory.java
 (original)
+++ 
commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/CPDSConnectionFactory.java
 Wed Feb 25 00:01:58 2009
@@ -110,10 +110,10 @@
 
 
 /**
- * Sets the {*link ConnectionFactory} from which to obtain base
- * {*link Connection}s.
- * @param connFactory the {*link ConnectionFactory} from which to obtain
- *base {*link Connection}s
+ * Sets the {...@link ConnectionPoolDataSource} from which to obtain base
+ * {...@link Connection}s.
+ * @param cpds the {...@link ConnectionPoolDataSource} from which to obtain
+ *base {...@link Connection}s
  */
 public synchronized void setCPDS(ConnectionPoolDataSource cpds) {
 _cpds = cpds;

Modified: 
commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/KeyedCPDSConnectionFactory.java
URL: 
http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/KeyedCPDSConnectionFactory.java?rev=747617r1=747616r2=747617view=diff
==
--- 
commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/KeyedCPDSConnectionFactory.java
 (original)
+++ 
commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources/KeyedCPDSConnectionFactory.java
 Wed Feb 25 00:01:58 2009
@@ -92,7 +92,7 @@
  * Create a new ttKeyedPoolableConnectionFactory/tt.
  * @param cpds the ConnectionPoolDataSource from which to obtain
  * PooledConnections
- * @param pool the {...@link ObjectPool} in which to pool those
+ * @param pool the {...@link KeyedObjectPool} in which to pool those
  * {...@link Connection}s
  * @param validationQuery a query to use to {...@link #validateObject 
validate}
  * {...@link Connection}s.  Should return at least one row. May be 
ttnull/tt
@@ -108,8 +108,8 @@
 }
 
 /**
- * Sets the {...@link ConnectionFactory} from which to obtain base 
{...@link Connection}s.
- * @param connFactory the {*link ConnectionFactory} from which to obtain 
base {...@link Connection}s
+ * Sets the {...@link ConnectionPoolDataSource} from which to obtain base 
{...@link Connection}s.
+ * @param cpds the {...@link ConnectionPoolDataSource} from which to 
obtain base {...@link Connection}s
  */
 synchronized public void setCPDS(ConnectionPoolDataSource cpds) {
 _cpds = cpds;

Modified: 
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestConnectionPool.java
URL: 
http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestConnectionPool.java?rev=747617r1=747616r2=747617view=diff
==
--- 
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestConnectionPool.java
 (original)
+++ 
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestConnectionPool.java
 Wed Feb 25 00:01:58 2009
@@ -447,7 +447,7 @@
 conn3.close();
 }
 
-/** @see http://issues.apache.org/bugzilla/show_bug.cgi?id=12400 */
+/** @see http://issues.apache.org/bugzilla/show_bug.cgi?id=12400; */
 public void testConnectionsAreDistinct() throws Exception {
 Connection[] conn = new Connection[getMaxActive()];
 for(int i=0;iconn.length;i++) {

Modified: 
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java
URL: 
http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java?rev=747617r1=747616r2=747617view=diff
==
--- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java 
(original)
+++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java 
Wed Feb 25 00:01:58 2009
@@ -87,7 +87,7 @@
 }
 
 
-/** @see http://issues.apache.org/bugzilla/show_bug.cgi?id=28912 */
+/** @see 

svn commit: r747619 - in /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp: TestPoolableConnection.java datasources/TestPerUserPoolDataSource.java

2009-02-24 Thread sebb
Author: sebb
Date: Wed Feb 25 00:05:40 2009
New Revision: 747619

URL: http://svn.apache.org/viewvc?rev=747619view=rev
Log:
Unused imports

Modified:

commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPoolableConnection.java

commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java

Modified: 
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPoolableConnection.java
URL: 
http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPoolableConnection.java?rev=747619r1=747618r2=747619view=diff
==
--- 
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPoolableConnection.java
 (original)
+++ 
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPoolableConnection.java
 Wed Feb 25 00:05:40 2009
@@ -18,7 +18,6 @@
 package org.apache.commons.dbcp;
 
 import java.sql.Connection;
-import java.sql.PreparedStatement;
 import java.sql.SQLException;
 
 import junit.framework.Test;

Modified: 
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java
URL: 
http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java?rev=747619r1=747618r2=747619view=diff
==
--- 
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java
 (original)
+++ 
commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java
 Wed Feb 25 00:05:40 2009
@@ -26,8 +26,6 @@
 import java.io.ByteArrayOutputStream;
 import java.io.ObjectInputStream;
 import java.io.ObjectOutputStream;
-import java.io.Serializable;
-
 import javax.sql.DataSource;
 
 import junit.framework.Test;




svn commit: r747650 - /commons/proper/math/trunk/src/java/org/apache/commons/math/linear/SparseRealVector.java

2009-02-24 Thread billbarker
Author: billbarker
Date: Wed Feb 25 03:32:52 2009
New Revision: 747650

URL: http://svn.apache.org/viewvc?rev=747650view=rev
Log:
epsilon needs to be set before calling isZero, plus copy epsilon for append

Modified:

commons/proper/math/trunk/src/java/org/apache/commons/math/linear/SparseRealVector.java

Modified: 
commons/proper/math/trunk/src/java/org/apache/commons/math/linear/SparseRealVector.java
URL: 
http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/SparseRealVector.java?rev=747650r1=747649r2=747650view=diff
==
--- 
commons/proper/math/trunk/src/java/org/apache/commons/math/linear/SparseRealVector.java
 (original)
+++ 
commons/proper/math/trunk/src/java/org/apache/commons/math/linear/SparseRealVector.java
 Wed Feb 25 03:32:52 2009
@@ -79,7 +79,7 @@
 protected SparseRealVector(SparseRealVector v, int resize) {
 virtualSize = v.getDimension() + resize;
 entries = new OpenIntToDoubleHashMap(v.entries);
-epsilon = DEFAULT_ZERO_TOLERANCE;
+epsilon = v.getEpsilon();
 }
 
 /**
@@ -121,13 +121,13 @@
 public SparseRealVector(double[] values, double epsilon) {
 virtualSize = values.length;
 entries = new OpenIntToDoubleHashMap(0.0);
+this.epsilon = epsilon;
 for (int key = 0; key  values.length; key++) {
 double value = values[key];
 if (!isZero(value)) {
 entries.put(key, value);
 }
 }
-this.epsilon = epsilon;
 }
 
 /**
@@ -148,13 +148,13 @@
 public SparseRealVector(Double[] values, double epsilon) {
 virtualSize = values.length;
 entries = new OpenIntToDoubleHashMap(0.0);
+this.epsilon = epsilon;
 for (int key = 0; key  values.length; key++) {
 double value = values[key].doubleValue();
 if (!isZero(value)) {
 entries.put(key, value);
 }
 }
-this.epsilon = epsilon;
 }
 
 /**
@@ -174,13 +174,13 @@
 public SparseRealVector(RealVector v) {
 virtualSize = v.getDimension();
 entries = new OpenIntToDoubleHashMap(0.0);
+epsilon = DEFAULT_ZERO_TOLERANCE;
 for (int key = 0; key  virtualSize; key++) {
 double value = v.getEntry(key);
 if (!isZero(value)) {
 entries.put(key, value);
 }
 }
-epsilon = DEFAULT_ZERO_TOLERANCE;
 }
 
 /**