svn commit: r1385386 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive: ./ moment/ summary/
Author: psteitz Date: Sun Sep 16 22:11:15 2012 New Revision: 1385386 URL: http://svn.apache.org/viewvc?rev=1385386&view=rev Log: Added missing throws declarations and fixed javadoc to match what is actually thrown. JIRA: MATH-854. Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/DescriptiveStatistics.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/moment/SemiVariance.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/moment/StandardDeviation.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/summary/Product.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/summary/Sum.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/summary/SumOfLogs.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/summary/SumOfSquares.java Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/DescriptiveStatistics.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/DescriptiveStatistics.java?rev=1385386&r1=1385385&r2=1385386&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/DescriptiveStatistics.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/DescriptiveStatistics.java Sun Sep 16 22:11:15 2012 @@ -175,9 +175,15 @@ public class DescriptiveStatistics imple /** * Removes the most recent value from the dataset. + * + * @throws MathIllegalStateException if there are no elements stored */ -public void removeMostRecentValue() { -eDA.discardMostRecentElements(1); +public void removeMostRecentValue() throws MathIllegalStateException { +try { +eDA.discardMostRecentElements(1); +} catch (MathIllegalArgumentException ex) { +throw new MathIllegalStateException(LocalizedFormats.NO_DATA); +} } /** @@ -186,8 +192,9 @@ public class DescriptiveStatistics imple * * @param v the value to replace the most recent stored value * @return replaced value + * @throws MathIllegalStateException if there are no elements stored */ -public double replaceMostRecentValue(double v) { +public double replaceMostRecentValue(double v) throws MathIllegalStateException { return eDA.substituteMostRecentElement(v); } @@ -407,7 +414,7 @@ public class DescriptiveStatistics imple * * Preconditions: * 0 < p ≤ 100 (otherwise an - * IllegalArgumentException is thrown) + * MathIllegalArgumentException is thrown) * at least one value must be stored (returns Double.NaN * otherwise) * @@ -416,8 +423,9 @@ public class DescriptiveStatistics imple * @return An estimate for the pth percentile of the stored data * @throws MathIllegalStateException if percentile implementation has been * overridden and the supplied implementation does not support setQuantile + * @throws MathIllegalArgumentException if p is not a valid quantile */ -public double getPercentile(double p) throws MathIllegalStateException { +public double getPercentile(double p) throws MathIllegalStateException, MathIllegalArgumentException { if (percentileImpl instanceof Percentile) { ((Percentile) percentileImpl).setQuantile(p); } else { @@ -459,6 +467,7 @@ public class DescriptiveStatistics imple outBuffer.append("std dev: ").append(getStandardDeviation()) .append(endl); try { +// No catch for MIAE because actual parameter is valid below outBuffer.append("median: ").append(getPercentile(50)).append(endl); } catch (MathIllegalStateException ex) { outBuffer.append("median: unavailable").append(endl); Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/moment/SemiVariance.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/moment/SemiVariance.java?rev=1385386&r1=1385385&r2=1385386&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/moment/SemiVariance.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/moment/SemiVariance.java Sun Sep 16 22:11:15 2012 @@ -213,14 +213,15 @@ public class SemiVariance extends Abstra * instance properties variancDirection and biasCorrection. * * Returns NaN if th
svn commit: r1385335 [4/4] - in /commons/proper/functor/branches/generators-FUNCTOR-14: ./ src/changes/ src/main/java/org/apache/commons/functor/generator/range/ src/site/xdoc/ src/test/java/org/apach
Modified: commons/proper/functor/branches/generators-FUNCTOR-14/src/test/java/org/apache/commons/functor/generator/range/TestLongRange.java URL: http://svn.apache.org/viewvc/commons/proper/functor/branches/generators-FUNCTOR-14/src/test/java/org/apache/commons/functor/generator/range/TestLongRange.java?rev=1385335&r1=1385334&r2=1385335&view=diff == --- commons/proper/functor/branches/generators-FUNCTOR-14/src/test/java/org/apache/commons/functor/generator/range/TestLongRange.java (original) +++ commons/proper/functor/branches/generators-FUNCTOR-14/src/test/java/org/apache/commons/functor/generator/range/TestLongRange.java Sun Sep 16 18:08:31 2012 @@ -17,13 +17,22 @@ package org.apache.commons.functor.generator.range; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.Collections; import java.util.List; import org.apache.commons.functor.BaseFunctorTest; -import org.apache.commons.functor.generator.range.LongRange; +import org.apache.commons.functor.UnaryFunction; +import org.apache.commons.functor.UnaryProcedure; +import org.apache.commons.functor.generator.Generator; +import org.junit.After; +import org.junit.Before; import org.junit.Test; /** @@ -31,19 +40,47 @@ import org.junit.Test; */ public class TestLongRange extends BaseFunctorTest { +// A base range with all longs between -6 and 6 +private final List fullRange = Collections.unmodifiableList(Arrays +.asList(-6L, -5L, -4L, -3L, -2L, -1L, 0L, 1L, 2L, 3L, 4L, 5L, 6L)); + +// Attributes +// +private LongRange ascLongRange = null; +private LongRange descLongRange = null; +private Collection expectedAsc = null; +private Collection expectedDesc = null; + +// Test set up +// +@Before +public void setUp() { +ascLongRange = Ranges.longRange(0L, 10L); +descLongRange = Ranges.longRange(10L, 0L); +expectedAsc = Arrays.asList(0L, 1L, 2L, 3L, 4L, 5L, 6L, 7L, 8L, 9L); +expectedDesc = Arrays.asList(10L, 9L, 8L, 7L, 6L, 5L, 4L, 3L, 2L, 1L); +} + +@After +public void tearDown() { +ascLongRange = null; +descLongRange = null; +} + @Override -protected Object makeFunctor() throws Exception { -return new LongRange(10, 20); +protected Object makeFunctor() +throws Exception { +return Ranges.longRange(10, 20); } -// Tests +// Generator tests // @Test public void testGenerateListExample() { // generates a collection of Integers from 0 (inclusive) to 10 (exclusive) { -List list = (List)(new LongRange(0,10).to(new ArrayList())); +List list = (List)(Ranges.longRange(0,10).to(new ArrayList())); for (int i=0;i<10;i++) { assertEquals(new Long(i),list.get(i)); } @@ -51,7 +88,7 @@ public class TestLongRange extends BaseF // generates a collection of Integers from 10 (inclusive) to 0 (exclusive) { -List list = (List)(new LongRange(10,0).to(new ArrayList())); +List list = (List)(Ranges.longRange(10,0).to(new ArrayList())); for (int i=10;i>0;i--) { assertEquals(new Long(i),list.get(10-i)); } @@ -61,34 +98,34 @@ public class TestLongRange extends BaseF @Test public void testStepChecking() { { -new LongRange(2, 2, 0); // step of 0 is ok when range is empty +Ranges.longRange(2, 2, 0); // step of 0 is ok when range is empty } { -new LongRange(2, 2, 1); // positive step is ok when range is empty +Ranges.longRange(2, 2, 1); // positive step is ok when range is empty } { -new LongRange(2, 2, -1); // negative step is ok when range is empty +Ranges.longRange(2, 2, -1); // negative step is ok when range is empty } { -new LongRange(0, 1, 10); // big steps are ok +Ranges.longRange(0, 1, 10); // big steps are ok } { -new LongRange(1, 0, -10); // big steps are ok +Ranges.longRange(1, 0, -10); // big steps are ok } try { -new LongRange(0, 1, 0); +Ranges.longRange(0, 1, 0); fail("Expected IllegalArgumentException"); } catch(IllegalArgumentException e) { // expected } try { -new LongRange(0, 1,
svn commit: r1385318 - /commons/proper/math/trunk/src/changes/changes.xml
Author: tn Date: Sun Sep 16 16:54:20 2012 New Revision: 1385318 URL: http://svn.apache.org/viewvc?rev=1385318&view=rev Log: [MATH-666] added to changes.xml. Modified: commons/proper/math/trunk/src/changes/changes.xml Modified: commons/proper/math/trunk/src/changes/changes.xml URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/changes/changes.xml?rev=1385318&r1=1385317&r2=1385318&view=diff == --- commons/proper/math/trunk/src/changes/changes.xml (original) +++ commons/proper/math/trunk/src/changes/changes.xml Sun Sep 16 16:54:20 2012 @@ -52,6 +52,9 @@ If the output is not quite correct, chec + +Deprecated "FieldVector#getData()" in favor of "toArray()". + Fixed an error in rectangular Cholesky decomposition.
svn commit: r1385316 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear: FieldVector.java SparseFieldVector.java
Author: tn Date: Sun Sep 16 16:50:32 2012 New Revision: 1385316 URL: http://svn.apache.org/viewvc?rev=1385316&view=rev Log: [MATH-666] make FieldVector#getData() method deprecated in favor of toArray(), minor formatting, move implementation of SparseFieldVector#getData() to toArray(). Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/FieldVector.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/SparseFieldVector.java Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/FieldVector.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/FieldVector.java?rev=1385316&r1=1385315&r2=1385316&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/FieldVector.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/FieldVector.java Sun Sep 16 16:50:32 2012 @@ -66,8 +66,7 @@ public interface FieldVector add(FieldVector v) throws DimensionMismatchException; @@ -75,8 +74,7 @@ public interface FieldVector subtract(FieldVector v) throws DimensionMismatchException; @@ -154,8 +152,7 @@ public interface FieldVector mapInv() throws MathArithmeticException; @@ -172,8 +169,7 @@ public interface FieldVector ebeMultiply(FieldVector v) throws DimensionMismatchException; @@ -182,8 +178,7 @@ public interface FieldVector ebeDivide(FieldVector v) @@ -192,23 +187,24 @@ public interface FieldVector v) throws DimensionMismatchException; -/** Find the orthogonal projection of this vector onto another vector. +/** + * Find the orthogonal projection of this vector onto another vector. * @param v vector onto which {@code this} must be projected * @return projection of {@code this} onto {@code v} - * @throws DimensionMismatchException if {@code v} is not the same size as - * {@code this} + * @throws DimensionMismatchException if {@code v} is not the same size as {@code this} * @throws MathArithmeticException if {@code v} is the null vector. */ FieldVector projection(FieldVector v) Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/SparseFieldVector.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/SparseFieldVector.java?rev=1385316&r1=1385315&r2=1385316&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/SparseFieldVector.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/SparseFieldVector.java Sun Sep 16 16:50:32 2012 @@ -202,7 +202,7 @@ public class SparseFieldVector copy() { return new SparseFieldVector(this); - } +} /** {@inheritDoc} */ public T dotProduct(FieldVector v) throws DimensionMismatchException { @@ -242,34 +242,33 @@ public class SparseFieldVector.Iterator iter = entries.iterator(); -while (iter.hasNext()) { -iter.advance(); -res[iter.key()] = iter.value(); -} -return res; - } +/** + * {@inheritDoc} + * + * @deprecated as of 3.1, to be removed in 4.0. Please use the {@link #toArray()} method instead. + */ +@Deprecated +public T[] getData() { +return toArray(); +} - /** {@inheritDoc} */ - public int getDimension() { +/** {@inheritDoc} */ +public int getDimension() { return virtualSize; } - /** {@inheritDoc} */ - public T getEntry(int index) throws OutOfRangeException { +/** {@inheritDoc} */ +public T getEntry(int index) throws OutOfRangeException { checkIndex(index); return entries.get(index); } - /** {@inheritDoc} */ - public Field getField() { +/** {@inheritDoc} */ +public Field getField() { return field; } - /** {@inheritDoc} */ +/** {@inheritDoc} */ public FieldVector getSubVector(int index, int n) throws OutOfRangeException, NotPositiveException { if (n < 0) { @@ -290,26 +289,26 @@ public class SparseFieldVector mapAdd(T d) throws NullArgumentException { +/** {@inheritDoc} */ +public FieldVector mapAdd(T d) throws NullArgumentException { return copy().mapAddToSelf(d); - } +} - /** {@inheritDoc} */ - public FieldVector mapAddToSelf(T d) throws NullArgumentException { +/** {@inheritDoc} */ +public FieldVector mapAddToSelf(T d) throws NullArgumentException { for (int i = 0; i < virtualSize; i++) { setEntry(i, getEntry(i).add(d)); } return this; } - /** {@inheritDoc} */ +/** {@inheritDoc} */ public FieldVector mapDivide(T d) throws NullArgumentE
svn commit: r1385315 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/differentiation/DSCompiler.java
Author: tn Date: Sun Sep 16 16:37:34 2012 New Revision: 1385315 URL: http://svn.apache.org/viewvc?rev=1385315&view=rev Log: Removed trailing spaces. Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/differentiation/DSCompiler.java Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/differentiation/DSCompiler.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/differentiation/DSCompiler.java?rev=1385315&r1=1385314&r2=1385315&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/differentiation/DSCompiler.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/differentiation/DSCompiler.java Sun Sep 16 16:37:34 2012 @@ -1034,7 +1034,6 @@ public class DSCompiler { */ public void log1p(final double[] operand, final int operandOffset, final double[] result, final int resultOffset) { - // create the function value and derivatives double[] function = new double[1 + order]; @@ -1062,7 +1061,6 @@ public class DSCompiler { */ public void log10(final double[] operand, final int operandOffset, final double[] result, final int resultOffset) { - // create the function value and derivatives double[] function = new double[1 + order]; @@ -1713,7 +1711,7 @@ public class DSCompiler { } /** Evaluate Taylor expansion of a derivative structure. - * @param ds array holding the derivative structure + * @param ds array holding the derivative structure * @param dsOffset offset of the derivative structure in its array * @param delta parameters offsets (Δx, Δy, ...) * @return value of the Taylor expansion at x + Δx, y + Δy, ...
svn commit: r1385314 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/interpolation/TricubicSplineInterpolatingFunction.java
Author: tn Date: Sun Sep 16 16:35:49 2012 New Revision: 1385314 URL: http://svn.apache.org/viewvc?rev=1385314&view=rev Log: Javadoc formatting and fixes. Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/interpolation/TricubicSplineInterpolatingFunction.java Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/interpolation/TricubicSplineInterpolatingFunction.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/interpolation/TricubicSplineInterpolatingFunction.java?rev=1385314&r1=1385313&r2=1385314&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/interpolation/TricubicSplineInterpolatingFunction.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/interpolation/TricubicSplineInterpolatingFunction.java Sun Sep 16 16:35:49 2012 @@ -123,25 +123,16 @@ public class TricubicSplineInterpolating * @param y Sample values of the y-coordinate, in increasing order. * @param z Sample values of the y-coordinate, in increasing order. * @param f Values of the function on every grid point. - * @param dFdX Values of the partial derivative of function with respect - * to x on every grid point. - * @param dFdY Values of the partial derivative of function with respect - * to y on every grid point. - * @param dFdZ Values of the partial derivative of function with respect - * to z on every grid point. - * @param d2FdXdY Values of the cross partial derivative of function on - * every grid point. - * @param d2FdXdZ Values of the cross partial derivative of function on - * every grid point. - * @param d2FdYdZ Values of the cross partial derivative of function on - * every grid point. - * @param d3FdXdYdZ Values of the cross partial derivative of function on - * every grid point. + * @param dFdX Values of the partial derivative of function with respect to x on every grid point. + * @param dFdY Values of the partial derivative of function with respect to y on every grid point. + * @param dFdZ Values of the partial derivative of function with respect to z on every grid point. + * @param d2FdXdY Values of the cross partial derivative of function on every grid point. + * @param d2FdXdZ Values of the cross partial derivative of function on every grid point. + * @param d2FdYdZ Values of the cross partial derivative of function on every grid point. + * @param d3FdXdYdZ Values of the cross partial derivative of function on every grid point. * @throws NoDataException if any of the arrays has zero length. - * @throws DimensionMismatchException if the various arrays do not contain - * the expected number of elements. - * @throws Exception if {@code x}, {@code y} or {@code z} - * are not strictly increasing. + * @throws DimensionMismatchException if the various arrays do not contain the expected number of elements. + * @throws NonMonotonicSequenceException if {@code x}, {@code y} or {@code z} are not strictly increasing. */ public TricubicSplineInterpolatingFunction(double[] x, double[] y, @@ -310,8 +301,7 @@ public class TricubicSplineInterpolating /** * {@inheritDoc} * - * @throws OutOfRangeException if any of the variables is outside its - * interpolation range. + * @throws OutOfRangeException if any of the variables is outside its interpolation range. */ public double value(double x, double y, double z) throws OutOfRangeException { @@ -338,9 +328,8 @@ public class TricubicSplineInterpolating /** * @param c Coordinate. * @param val Coordinate samples. - * @return the index in {@code val} corresponding to the interval - * containing {@code c}, or {@code -1} if {@code c} is out of the - * range defined by the end values of {@code val}. + * @return the index in {@code val} corresponding to the interval containing {@code c}, or {@code -1} + * if {@code c} is out of the range defined by the end values of {@code val}. */ private int searchIndex(double c, double[] val) { if (c < val[0]) { @@ -402,8 +391,7 @@ public class TricubicSplineInterpolating * where the subscripts indicate the partial derivative with respect to * the corresponding variable(s). * - * @param beta List of function values and function partial derivatives - * values. + * @param beta List of function values and function partial derivatives values. * @return the spline coefficients. */ private double[] computeSplineCoefficients(double[] beta) {
svn commit: r1385313 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/interpolation: BicubicSplineInterpolator.java DividedDifferenceInterpolator.java
Author: tn Date: Sun Sep 16 16:35:23 2012 New Revision: 1385313 URL: http://svn.apache.org/viewvc?rev=1385313&view=rev Log: Removed unused imports. Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/interpolation/BicubicSplineInterpolator.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/interpolation/DividedDifferenceInterpolator.java Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/interpolation/BicubicSplineInterpolator.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/interpolation/BicubicSplineInterpolator.java?rev=1385313&r1=1385312&r2=1385313&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/interpolation/BicubicSplineInterpolator.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/interpolation/BicubicSplineInterpolator.java Sun Sep 16 16:35:23 2012 @@ -20,7 +20,6 @@ import org.apache.commons.math3.analysis import org.apache.commons.math3.analysis.polynomials.PolynomialSplineFunction; import org.apache.commons.math3.exception.DimensionMismatchException; import org.apache.commons.math3.exception.NoDataException; -import org.apache.commons.math3.exception.NumberIsTooSmallException; import org.apache.commons.math3.exception.NonMonotonicSequenceException; import org.apache.commons.math3.util.MathArrays; Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/interpolation/DividedDifferenceInterpolator.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/interpolation/DividedDifferenceInterpolator.java?rev=1385313&r1=1385312&r2=1385313&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/interpolation/DividedDifferenceInterpolator.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/interpolation/DividedDifferenceInterpolator.java Sun Sep 16 16:35:23 2012 @@ -20,7 +20,6 @@ import java.io.Serializable; import org.apache.commons.math3.analysis.polynomials.PolynomialFunctionLagrangeForm; import org.apache.commons.math3.analysis.polynomials.PolynomialFunctionNewtonForm; import org.apache.commons.math3.exception.DimensionMismatchException; -import org.apache.commons.math3.exception.NoDataException; import org.apache.commons.math3.exception.NumberIsTooSmallException; import org.apache.commons.math3.exception.NonMonotonicSequenceException;
svn commit: r1385310 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/
Author: tn Date: Sun Sep 16 16:32:10 2012 New Revision: 1385310 URL: http://svn.apache.org/viewvc?rev=1385310&view=rev Log: Javadoc cleanup of transform package, removed unnecessary paragraph tags. Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/DctNormalization.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/DftNormalization.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/DstNormalization.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/FastCosineTransformer.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/FastFourierTransformer.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/FastHadamardTransformer.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/FastSineTransformer.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/RealTransformer.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/TransformUtils.java Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/DctNormalization.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/DctNormalization.java?rev=1385310&r1=1385309&r2=1385310&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/DctNormalization.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/DctNormalization.java Sun Sep 16 16:32:10 2012 @@ -27,7 +27,6 @@ package org.apache.commons.math3.transfo */ public enum DctNormalization { /** - * * Should be passed to the constructor of {@link FastCosineTransformer} * to use the standard normalization convention. The standard * DCT-I normalization convention is defined as follows @@ -43,12 +42,10 @@ public enum DctNormalization { * yn cos[π nk / (N - 1)], * * where N is the size of the data sample. - * */ STANDARD_DCT_I, /** - * * Should be passed to the constructor of {@link FastCosineTransformer} * to use the orthogonal normalization convention. The orthogonal * DCT-I normalization convention is defined as follows Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/DftNormalization.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/DftNormalization.java?rev=1385310&r1=1385309&r2=1385310&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/DftNormalization.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/DftNormalization.java Sun Sep 16 16:32:10 2012 @@ -27,7 +27,6 @@ package org.apache.commons.math3.transfo */ public enum DftNormalization { /** - * * Should be passed to the constructor of {@link FastFourierTransformer} * to use the standard normalization convention. This normalization * convention is defined as follows @@ -38,12 +37,10 @@ public enum DftNormalization { * ∑n=0N-1 yn exp(2πi n k / N), * * where N is the size of the data sample. - * */ STANDARD, /** - * * Should be passed to the constructor of {@link FastFourierTransformer} * to use the unitary normalization convention. This normalization * convention is defined as follows @@ -55,7 +52,6 @@ public enum DftNormalization { * ∑n=0N-1 yn exp(2πi n k / N), * * which makes the transform unitary. N is the size of the data sample. - * */ UNITARY; } Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/DstNormalization.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/DstNormalization.java?rev=1385310&r1=1385309&r2=1385310&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/DstNormalization.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/transform/DstNormalization.java Sun Sep 16 16:32:10 2012 @@ -27,7 +27,6 @@ package org.apache.commons.math3.transfo */ public enum DstNormalization { /** - * * Should be passed to the constructor of {@link FastSineTransformer} to * use the standard normalization convention. The standard DST-I * normalization convention is defined as follows @@ -38,12 +37,10 @@ public enum DstNormalization { * ∑n=0N-1 yn sin(π nk / N),
svn commit: r1385307 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/
Author: tn Date: Sun Sep 16 16:19:55 2012 New Revision: 1385307 URL: http://svn.apache.org/viewvc?rev=1385307&view=rev Log: Javadoc cleanup of linear optimization package. Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/AbstractLinearOptimizer.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/LinearConstraint.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/LinearObjectiveFunction.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/LinearOptimizer.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/NoFeasibleSolutionException.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/Relationship.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/SimplexSolver.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/SimplexTableau.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/UnboundedSolutionException.java Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/AbstractLinearOptimizer.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/AbstractLinearOptimizer.java?rev=1385307&r1=1385306&r2=1385307&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/AbstractLinearOptimizer.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/AbstractLinearOptimizer.java Sun Sep 16 16:19:55 2012 @@ -27,11 +27,12 @@ import org.apache.commons.math3.optimiza /** * Base class for implementing linear optimizers. - * This base class handles the boilerplate methods associated to thresholds - * settings and iterations counters. + * + * This base class handles the boilerplate methods associated to thresholds + * settings and iterations counters. + * * @version $Id$ * @since 2.0 - * */ public abstract class AbstractLinearOptimizer implements LinearOptimizer { @@ -68,7 +69,8 @@ public abstract class AbstractLinearOpti /** Number of iterations already performed. */ private int iterations; -/** Simple constructor with default settings. +/** + * Simple constructor with default settings. * The maximal number of evaluation is set to its default value. */ protected AbstractLinearOptimizer() { @@ -118,9 +120,9 @@ public abstract class AbstractLinearOpti return iterations; } -/** Increment the iterations counter by 1. - * @exception MaxCountExceededException if the maximal number - * of iterations is exceeded +/** + * Increment the iterations counter by 1. + * @exception MaxCountExceededException if the maximal number of iterations is exceeded */ protected void incrementIterationsCounter() throws MaxCountExceededException { @@ -131,9 +133,9 @@ public abstract class AbstractLinearOpti /** {@inheritDoc} */ public PointValuePair optimize(final LinearObjectiveFunction f, - final Collection constraints, - final GoalType goalType, final boolean restrictToNonNegative) - throws MathIllegalStateException { + final Collection constraints, + final GoalType goalType, final boolean restrictToNonNegative) +throws MathIllegalStateException { // store linear problem characteristics this.function = f; @@ -148,12 +150,12 @@ public abstract class AbstractLinearOpti } -/** Perform the bulk of optimization algorithm. +/** + * Perform the bulk of optimization algorithm. * @return the point/value pair giving the optimal value for objective function * @exception MathIllegalStateException if no solution fulfilling the constraints * can be found in the allowed number of iterations */ -protected abstract PointValuePair doOptimize() -throws MathIllegalStateException; +protected abstract PointValuePair doOptimize() throws MathIllegalStateException; } Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/LinearConstraint.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/LinearConstraint.java?rev=1385307&r1=1385306&r2=1385307&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/
svn commit: r1385301 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math3: optimization/direct/BaseAbstractMultivariateVectorOptimizer.java stat/descriptive/rank/Median.java
Author: tn Date: Sun Sep 16 16:11:53 2012 New Revision: 1385301 URL: http://svn.apache.org/viewvc?rev=1385301&view=rev Log: Javadoc fixes. Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/direct/BaseAbstractMultivariateVectorOptimizer.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/rank/Median.java Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/direct/BaseAbstractMultivariateVectorOptimizer.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/direct/BaseAbstractMultivariateVectorOptimizer.java?rev=1385301&r1=1385300&r2=1385301&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/direct/BaseAbstractMultivariateVectorOptimizer.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/direct/BaseAbstractMultivariateVectorOptimizer.java Sun Sep 16 16:11:53 2012 @@ -114,8 +114,8 @@ public abstract class BaseAbstractMultiv * ∑weighti(objectivei - targeti)2 * * @param f Objective function. - * @param target Target value for the objective functions at optimum. - * @param weight Weights for the least squares cost computation. + * @param t Target value for the objective functions at optimum. + * @param w Weights for the least squares cost computation. * @param startPoint Start point for optimization. * @return the point/value pair giving the optimal value for objective * function. Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/rank/Median.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/rank/Median.java?rev=1385301&r1=1385300&r2=1385301&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/rank/Median.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/descriptive/rank/Median.java Sun Sep 16 16:11:53 2012 @@ -50,7 +50,7 @@ public class Median extends Percentile i * to the {@code original} * * @param original the {@code Median} instance to copy - * @throws NullArgumentException if original is null + * @throws NullArgumentException if original is null */ public Median(Median original) throws NullArgumentException { super(original);
svn commit: r1385299 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/ChiSquaredDistribution.java
Author: tn Date: Sun Sep 16 16:09:17 2012 New Revision: 1385299 URL: http://svn.apache.org/viewvc?rev=1385299&view=rev Log: Replace deprecated method call. Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/ChiSquaredDistribution.java Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/ChiSquaredDistribution.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/ChiSquaredDistribution.java?rev=1385299&r1=1385298&r2=1385299&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/ChiSquaredDistribution.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/ChiSquaredDistribution.java Sun Sep 16 16:09:17 2012 @@ -89,7 +89,7 @@ public class ChiSquaredDistribution exte * @return the degrees of freedom. */ public double getDegreesOfFreedom() { -return gamma.getAlpha() * 2.0; +return gamma.getShape() * 2.0; } /** {@inheritDoc} */
svn commit: r1385298 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/RealDistribution.java
Author: tn Date: Sun Sep 16 16:09:00 2012 New Revision: 1385298 URL: http://svn.apache.org/viewvc?rev=1385298&view=rev Log: Remove trailing spaces in javadoc. Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/RealDistribution.java Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/RealDistribution.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/RealDistribution.java?rev=1385298&r1=1385297&r2=1385298&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/RealDistribution.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/RealDistribution.java Sun Sep 16 16:09:00 2012 @@ -142,7 +142,7 @@ public interface RealDistribution { * {@code density(getSupportLowerBound())} returns a non-NaN, non-infinite * value. * - * @return true if the lower bound of support is finite and the density + * @return true if the lower bound of support is finite and the density * function returns a non-NaN, non-infinite value there * @deprecated to be removed in 4.0 */ @@ -154,7 +154,7 @@ public interface RealDistribution { * {@code density(getSupportUpperBound())} returns a non-NaN, non-infinite * value. * - * @return true if the upper bound of support is finite and the density + * @return true if the upper bound of support is finite and the density * function returns a non-NaN, non-infinite value there * @deprecated to be removed in 4.0 */
svn commit: r1385297 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/
Author: tn Date: Sun Sep 16 16:05:57 2012 New Revision: 1385297 URL: http://svn.apache.org/viewvc?rev=1385297&view=rev Log: [MATH-854] fill throws clause for genetics package. Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/AbstractListChromosome.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/BinaryChromosome.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/BinaryMutation.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/CrossoverPolicy.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/CycleCrossover.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/ElitisticListPopulation.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/FixedElapsedTime.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/FixedGenerationCount.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/GeneticAlgorithm.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/ListPopulation.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/MutationPolicy.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/NPointCrossover.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/OnePointCrossover.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/OrderedCrossover.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/Population.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/RandomKey.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/RandomKeyMutation.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/SelectionPolicy.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/TournamentSelection.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/UniformCrossover.java Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/AbstractListChromosome.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/AbstractListChromosome.java?rev=1385297&r1=1385296&r2=1385297&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/AbstractListChromosome.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/AbstractListChromosome.java Sun Sep 16 16:05:57 2012 @@ -38,7 +38,7 @@ public abstract class AbstractListChromo * @param representation inner representation of the chromosome * @throws InvalidRepresentationException iff the representation can not represent a valid chromosome */ -public AbstractListChromosome(final List representation) { +public AbstractListChromosome(final List representation) throws InvalidRepresentationException { checkValidity(representation); this.representation = Collections.unmodifiableList(new ArrayList (representation)); } @@ -46,8 +46,9 @@ public abstract class AbstractListChromo /** * Constructor. * @param representation inner representation of the chromosome + * @throws InvalidRepresentationException iff the representation can not represent a valid chromosome */ -public AbstractListChromosome(final T[] representation) { +public AbstractListChromosome(final T[] representation) throws InvalidRepresentationException { this(Arrays.asList(representation)); } Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/BinaryChromosome.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/BinaryChromosome.java?rev=1385297&r1=1385296&r2=1385297&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/BinaryChromosome.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/BinaryChromosome.java Sun Sep 16 16:05:57 2012 @@ -34,7 +34,7 @@ public abstract class BinaryChromosome e * @param representation list of {0,1} values representing the chromosome * @throws InvalidRepresentationException iff the representation can not represent a valid chromosome */ -public BinaryChromosome(List representation) { +public BinaryChromosome(List representation) throws InvalidRepresentationException { super(representation); } @@ -43,7 +43,7 @@ public abstract class BinaryChromosome e * @param repr
svn commit: r1385284 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/
Author: tn Date: Sun Sep 16 15:19:55 2012 New Revision: 1385284 URL: http://svn.apache.org/viewvc?rev=1385284&view=rev Log: Javadoc cleanup of genetics package. Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/AbstractListChromosome.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/BinaryChromosome.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/BinaryMutation.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/Chromosome.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/ChromosomePair.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/CrossoverPolicy.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/ElitisticListPopulation.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/Fitness.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/FixedElapsedTime.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/FixedGenerationCount.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/GeneticAlgorithm.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/ListPopulation.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/NPointCrossover.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/OnePointCrossover.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/OrderedCrossover.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/PermutationChromosome.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/Population.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/RandomKey.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/RandomKeyMutation.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/StoppingCondition.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/TournamentSelection.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/UniformCrossover.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/package-info.java Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/AbstractListChromosome.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/AbstractListChromosome.java?rev=1385284&r1=1385283&r2=1385284&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/AbstractListChromosome.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/genetics/AbstractListChromosome.java Sun Sep 16 15:19:55 2012 @@ -36,8 +36,7 @@ public abstract class AbstractListChromo /** * Constructor. * @param representation inner representation of the chromosome - * @throws InvalidRepresentationException iff the representation can not represent - * a valid chromosome + * @throws InvalidRepresentationException iff the representation can not represent a valid chromosome */ public AbstractListChromosome(final List representation) { checkValidity(representation); @@ -53,11 +52,10 @@ public abstract class AbstractListChromo } /** - * * Asserts that representation can represent a valid chromosome. + * * @param chromosomeRepresentation representation of the chromosome - * @throws InvalidRepresentationException iff the representation can not represent - * a valid chromosome + * @throws InvalidRepresentationException iff the representation can not represent a valid chromosome */ protected abstract void checkValidity(List chromosomeRepresentation) throws InvalidRepresentationException; @@ -78,23 +76,17 @@ public abstract class AbstractListChromo } /** - * Creates a new instance of the same class as this is, with a - * given arrayRepresentation. This is needed in crossover and - * mutation operators, where we need a new instance of the same class, but - * with different array representation. - * + * Creates a new instance of the same class as this is, with a given arrayRepresentation. + * This is needed in crossover and mutation operators, where we need a new instance of the same class, but with + * different array representation. + * * Usually, this method just calls a constructor of the class. * - * @param chromosomeRepresentation - *the inner array representation of the new chr
svn commit: r1385279 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/differentiation/DerivativeStructure.java
Author: tn Date: Sun Sep 16 15:06:06 2012 New Revision: 1385279 URL: http://svn.apache.org/viewvc?rev=1385279&view=rev Log: Javadoc fixes. Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/differentiation/DerivativeStructure.java Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/differentiation/DerivativeStructure.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/differentiation/DerivativeStructure.java?rev=1385279&r1=1385278&r2=1385279&view=diff == --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/differentiation/DerivativeStructure.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/analysis/differentiation/DerivativeStructure.java Sun Sep 16 15:06:06 2012 @@ -79,7 +79,6 @@ public class DerivativeStructure impleme /** Build an instance representing a constant value. * @param parameters number of free parameters - * @param parameters number of variables * @param order derivation order * @param value value of the constant * @see #DerivativeStructure(int, int, int, double) @@ -180,7 +179,7 @@ public class DerivativeStructure impleme } /** Copy constructor. - * @param instance to copy + * @param ds instance to copy */ private DerivativeStructure(final DerivativeStructure ds) { this.compiler = ds.compiler;