svn commit: r1526817 - in /commons/proper/lang/trunk/src: changes/changes.xml main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java test/java/org/apache/commons/lang3/builder/HashCodeBuilder
Author: britter
Date: Fri Sep 27 07:49:02 2013
New Revision: 1526817
URL: http://svn.apache.org/r1526817
Log:
LANG-804 - Redundant check for zero in HashCodeBuilder ctor. Patch provided by
Allon Mureinik via github.
Modified:
commons/proper/lang/trunk/src/changes/changes.xml
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java
Modified: commons/proper/lang/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/changes/changes.xml?rev=1526817r1=1526816r2=1526817view=diff
==
--- commons/proper/lang/trunk/src/changes/changes.xml (original)
+++ commons/proper/lang/trunk/src/changes/changes.xml Fri Sep 27 07:49:02 2013
@@ -22,6 +22,7 @@
body
release version=3.2 date=TBA description=Next release
+action issue=LANG-804 type=update dev=britter due-to=Allon
MureinikRedundant check for zero in HashCodeBuilder ctor/action
action issue=LANG-893 type=add dev=oheger due-to=Woonsan
KoStrSubstitutor now supports default values for variables/action
action issue=LANG-913 type=add dev=britter due-to=Allon
MureinikAdding .gitignore to commons-lang/action
action issue=LANG-837 type=addAdd ObjectUtils.toIdentityString
methods that support StringBuilder, StrBuilder, and Appendable/action
Modified:
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java?rev=1526817r1=1526816r2=1526817view=diff
==
---
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java
(original)
+++
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java
Fri Sep 27 07:49:02 2013
@@ -520,7 +520,7 @@ public class HashCodeBuilder implements
/**
* p
- * Two randomly chosen, non-zero, odd numbers must be passed in. Ideally
these should be different for each class,
+ * Two randomly chosen, odd numbers must be passed in. Ideally these
should be different for each class,
* however this is not vital.
* /p
*
@@ -528,28 +528,22 @@ public class HashCodeBuilder implements
* Prime numbers are preferred, especially for the multiplier.
* /p
*
- * @param initialNonZeroOddNumber
- *a non-zero, odd number used as the initial value
- * @param multiplierNonZeroOddNumber
- *a non-zero, odd number used as the multiplier
+ * @param initialOddNumber
+ *am odd number used as the initial value
+ * @param multiplierOddNumber
+ *an odd number used as the multiplier
* @throws IllegalArgumentException
- * if the number is zero or even
+ * if the number is even
*/
-public HashCodeBuilder(final int initialNonZeroOddNumber, final int
multiplierNonZeroOddNumber) {
-if (initialNonZeroOddNumber == 0) {
-throw new IllegalArgumentException(HashCodeBuilder requires a non
zero initial value);
-}
-if (initialNonZeroOddNumber % 2 == 0) {
+public HashCodeBuilder(final int initialOddNumber, final int
multiplierOddNumber) {
+if (initialOddNumber % 2 == 0) {
throw new IllegalArgumentException(HashCodeBuilder requires an
odd initial value);
}
-if (multiplierNonZeroOddNumber == 0) {
-throw new IllegalArgumentException(HashCodeBuilder requires a non
zero multiplier);
-}
-if (multiplierNonZeroOddNumber % 2 == 0) {
+if (multiplierOddNumber % 2 == 0) {
throw new IllegalArgumentException(HashCodeBuilder requires an
odd multiplier);
}
-iConstant = multiplierNonZeroOddNumber;
-iTotal = initialNonZeroOddNumber;
+iConstant = multiplierOddNumber;
+iTotal = initialOddNumber;
}
/**
Modified:
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java?rev=1526817r1=1526816r2=1526817view=diff
==
---
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java
(original)
+++
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java
Fri Sep 27 07:49:02 2013
@@ -55,15 +55,20 @@ public class HashCodeBuilderTest {
// ---
svn commit: r1526818 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java
Author: britter Date: Fri Sep 27 07:53:53 2013 New Revision: 1526818 URL: http://svn.apache.org/r1526818 Log: Fix typo Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java?rev=1526818r1=1526817r2=1526818view=diff == --- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java (original) +++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java Fri Sep 27 07:53:53 2013 @@ -529,7 +529,7 @@ public class HashCodeBuilder implements * /p * * @param initialOddNumber - *am odd number used as the initial value + *an odd number used as the initial value * @param multiplierOddNumber *an odd number used as the multiplier * @throws IllegalArgumentException
svn commit: r1526903 - /commons/proper/csv/trunk/src/site/xdoc/index.xml
Author: sebb
Date: Fri Sep 27 13:53:47 2013
New Revision: 1526903
URL: http://svn.apache.org/r1526903
Log:
Must not advertise nightly builds to general public
Modified:
commons/proper/csv/trunk/src/site/xdoc/index.xml
Modified: commons/proper/csv/trunk/src/site/xdoc/index.xml
URL:
http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/site/xdoc/index.xml?rev=1526903r1=1526902r2=1526903view=diff
==
--- commons/proper/csv/trunk/src/site/xdoc/index.xml (original)
+++ commons/proper/csv/trunk/src/site/xdoc/index.xml Fri Sep 27 13:53:47 2013
@@ -36,7 +36,7 @@ for (CSVRecord record : records) {
/section
section name=Getting the code
- pThere are currently no official downloads, and will not be until version
1.0 is released, but nightly builds may be available from a
href=http://people.apache.org/builds/commons/nightly/commons-csv/;http://people.apache.org/builds/commons/nightly/commons-csv//a.
/p
+ pThere are currently no official downloads, and will not be until version
1.0 is released./p
pThe latest code can be checked out from our Subversion repository at a
href=http://svn.apache.org/repos/asf/commons/proper/csv/trunk/;http://svn.apache.org/repos/asf/commons/proper/csv/trunk//a.
/p
pYou can build the component using Apache Maven. For example: mvn clean
package./p
/section
svn commit: r1527032 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java
Author: bodewig Date: Fri Sep 27 19:02:38 2013 New Revision: 1527032 URL: http://svn.apache.org/r1527032 Log: note on 7z's limitations is outdated Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java?rev=1527032r1=1527031r2=1527032view=diff == --- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java (original) +++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java Fri Sep 27 19:02:38 2013 @@ -39,16 +39,8 @@ import org.apache.commons.compress.utils * The 7z file format is a flexible container * that can contain many compression and * encryption types, but at the moment only - * only Copy, LZMA2, BZIP2, and AES-256 + SHA-256 - * are supported, and archive header compression - * (when it uses the unsupported LZMA - * compression) isn't. So the only archives - * that can be read are the following: - * pre - * 7z a -mhc=off [-mhe=on] -mx=0 [-ppassword] archive.7z files - * 7z a -mhc=off [-mhe=on] -m0=LZMA2 [-ppassword] archive.7z files - * 7z a -mhc=off [-mhe=on] -m0=BZIP2 [-ppassword] archive.7z files - * /pre + * only Copy, LZMA, LZMA2, BZIP2, and AES-256 + SHA-256 + * are supported. * p * The format is very Windows/Intel specific, * so it uses little-endian byte order,
