commons-compress git commit: Add missing default serialVersionUID.
Repository: commons-compress Updated Branches: refs/heads/master 1014dffca -> 76390c0b5 Add missing default serialVersionUID. Project: http://git-wip-us.apache.org/repos/asf/commons-compress/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-compress/commit/76390c0b Tree: http://git-wip-us.apache.org/repos/asf/commons-compress/tree/76390c0b Diff: http://git-wip-us.apache.org/repos/asf/commons-compress/diff/76390c0b Branch: refs/heads/master Commit: 76390c0b54bf145f65532ffe1e7b24639f108247 Parents: 1014dff Author: Gary Gregory Authored: Mon May 1 23:59:13 2017 -0700 Committer: Gary Gregory Committed: Mon May 1 23:59:13 2017 -0700 -- .../java/org/apache/commons/compress/MemoryLimitException.java | 2 ++ 1 file changed, 2 insertions(+) -- http://git-wip-us.apache.org/repos/asf/commons-compress/blob/76390c0b/src/main/java/org/apache/commons/compress/MemoryLimitException.java -- diff --git a/src/main/java/org/apache/commons/compress/MemoryLimitException.java b/src/main/java/org/apache/commons/compress/MemoryLimitException.java index 122edb1..1c5ec07 100644 --- a/src/main/java/org/apache/commons/compress/MemoryLimitException.java +++ b/src/main/java/org/apache/commons/compress/MemoryLimitException.java @@ -30,6 +30,8 @@ import java.io.IOException; */ public class MemoryLimitException extends IOException { +private static final long serialVersionUID = 1L; + //long instead of int to account for overflow for corrupt files private final long memoryNeededInKb; private final int memoryLimitInKb;
commons-compress git commit: Fix Javadoc bugs.
Repository: commons-compress Updated Branches: refs/heads/master 65184bc08 -> 1014dffca Fix Javadoc bugs. Project: http://git-wip-us.apache.org/repos/asf/commons-compress/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-compress/commit/1014dffc Tree: http://git-wip-us.apache.org/repos/asf/commons-compress/tree/1014dffc Diff: http://git-wip-us.apache.org/repos/asf/commons-compress/diff/1014dffc Branch: refs/heads/master Commit: 1014dffca96bf61b69f4446c3ab2d22786b49924 Parents: 65184bc Author: Gary Gregory Authored: Mon May 1 23:58:16 2017 -0700 Committer: Gary Gregory Committed: Mon May 1 23:58:16 2017 -0700 -- .../commons/compress/compressors/CompressorStreamFactory.java| 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/commons-compress/blob/1014dffc/src/main/java/org/apache/commons/compress/compressors/CompressorStreamFactory.java -- diff --git a/src/main/java/org/apache/commons/compress/compressors/CompressorStreamFactory.java b/src/main/java/org/apache/commons/compress/compressors/CompressorStreamFactory.java index f3433d9..b12fc1a 100644 --- a/src/main/java/org/apache/commons/compress/compressors/CompressorStreamFactory.java +++ b/src/main/java/org/apache/commons/compress/compressors/CompressorStreamFactory.java @@ -584,8 +584,8 @@ public class CompressorStreamFactory implements CompressorStreamProvider { * * @param name *the compressor name, i.e. {@value #GZIP}, {@value #BZIP2}, - *{@value #XZ}, {@value #PACK200}, {@value SNAPPY_FRAMED}, - *{@value LZ4_BLOCK}, {@value LZ4_FRAMED} + *{@value #XZ}, {@value #PACK200}, {@value #SNAPPY_FRAMED}, + *{@value #LZ4_BLOCK}, {@value #LZ4_FRAMED} *or {@value #DEFLATE} * @param out *the output stream
[Math] Change on branch "master": Commons Math MasterBranch - Build # 32 - Successful
The Apache Jenkins build system has built Commons Math MasterBranch (build #32) Status: Successful Check console output at https://builds.apache.org/job/Commons%20Math%20MasterBranch/32/ to view the results.
[math] MATH-1382: Unnecessary copying.
Repository: commons-math Updated Branches: refs/heads/master b645f5d08 -> dff1a0953 MATH-1382: Unnecessary copying. Thanks to Stefan Bunk for the report and fix. Closes #42 Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/dff1a095 Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/dff1a095 Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/dff1a095 Branch: refs/heads/master Commit: dff1a0953d97d46290750a46d01be1e1519ae698 Parents: b645f5d Author: Gilles Authored: Tue May 2 01:18:35 2017 +0200 Committer: Gilles Committed: Tue May 2 01:18:35 2017 +0200 -- src/changes/changes.xml | 4 .../math4/distribution/MultivariateNormalDistribution.java | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/commons-math/blob/dff1a095/src/changes/changes.xml -- diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 3a9ac48..d8dbd44 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -54,6 +54,10 @@ If the output is not quite correct, check for invisible trailing spaces! + +"MultivariateNormalDistribution": performance improvement (by +removing unnecessary copying). + "KolmogorovSmirnovTest": bug in "fixTies". http://git-wip-us.apache.org/repos/asf/commons-math/blob/dff1a095/src/main/java/org/apache/commons/math4/distribution/MultivariateNormalDistribution.java -- diff --git a/src/main/java/org/apache/commons/math4/distribution/MultivariateNormalDistribution.java b/src/main/java/org/apache/commons/math4/distribution/MultivariateNormalDistribution.java index 097caa0..52df408 100644 --- a/src/main/java/org/apache/commons/math4/distribution/MultivariateNormalDistribution.java +++ b/src/main/java/org/apache/commons/math4/distribution/MultivariateNormalDistribution.java @@ -211,7 +211,7 @@ public class MultivariateNormalDistribution private double getExponentTerm(final double[] values) { final double[] centered = new double[values.length]; for (int i = 0; i < centered.length; i++) { -centered[i] = values[i] - getMeans()[i]; +centered[i] = values[i] - means[i]; } final double[] preMultiplied = covarianceMatrixInverse.preMultiply(centered); double sum = 0;
commons-compress git commit: Update Powermock tests from 1.6.4 to 1.6.6.
Repository: commons-compress Updated Branches: refs/heads/master 6dc03d613 -> 65184bc08 Update Powermock tests from 1.6.4 to 1.6.6. Project: http://git-wip-us.apache.org/repos/asf/commons-compress/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-compress/commit/65184bc0 Tree: http://git-wip-us.apache.org/repos/asf/commons-compress/tree/65184bc0 Diff: http://git-wip-us.apache.org/repos/asf/commons-compress/diff/65184bc0 Branch: refs/heads/master Commit: 65184bc08140c7695ed6b39aa0e77b0dba61be92 Parents: 6dc03d6 Author: Gary Gregory Authored: Mon May 1 13:26:23 2017 -0700 Committer: Gary Gregory Committed: Mon May 1 13:26:23 2017 -0700 -- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/commons-compress/blob/65184bc0/pom.xml -- diff --git a/pom.xml b/pom.xml index bb77018..9745d1b 100644 --- a/pom.xml +++ b/pom.xml @@ -45,7 +45,7 @@ jar, tar, zip, dump, 7z, arj. ${project.version} RC1 -1.6.4 +1.6.6 3.7
svn commit: r1793387 - /commons/proper/codec/trunk/pom.xml
Author: ggregory Date: Mon May 1 18:00:25 2017 New Revision: 1793387 URL: http://svn.apache.org/viewvc?rev=1793387&view=rev Log: Update commons-parent from 41 to 42. Modified: commons/proper/codec/trunk/pom.xml Modified: commons/proper/codec/trunk/pom.xml URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/pom.xml?rev=1793387&r1=1793386&r2=1793387&view=diff == --- commons/proper/codec/trunk/pom.xml (original) +++ commons/proper/codec/trunk/pom.xml Mon May 1 18:00:25 2017 @@ -25,7 +25,7 @@ limitations under the License. org.apache.commons commons-parent -41 +42 commons-codec commons-codec
commons-io git commit: IO-367: Add convenience methods for copyToDirectory (closes #34, closes #18)
Repository: commons-io Updated Branches: refs/heads/master ffcbfdc80 -> bfd83b00e IO-367: Add convenience methods for copyToDirectory (closes #34, closes #18) based on patch supplied by James Sawle Project: http://git-wip-us.apache.org/repos/asf/commons-io/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-io/commit/bfd83b00 Tree: http://git-wip-us.apache.org/repos/asf/commons-io/tree/bfd83b00 Diff: http://git-wip-us.apache.org/repos/asf/commons-io/diff/bfd83b00 Branch: refs/heads/master Commit: bfd83b00eb5743ad4ad0d24957f84b61ef9f5f79 Parents: ffcbfdc Author: Pascal Schumacher Authored: Sun Apr 23 21:02:29 2017 +0200 Committer: pascalschumacher Committed: Mon May 1 17:03:54 2017 +0200 -- src/changes/changes.xml | 3 + .../java/org/apache/commons/io/FileUtils.java | 69 +++ .../apache/commons/io/FileUtilsTestCase.java| 89 3 files changed, 161 insertions(+) -- http://git-wip-us.apache.org/repos/asf/commons-io/blob/bfd83b00/src/changes/changes.xml -- diff --git a/src/changes/changes.xml b/src/changes/changes.xml index bb4e37e..a395005 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -47,6 +47,9 @@ The type attribute can be add,update,fix,remove. + +Add convenience methods for copyToDirectory + Javadoc contradictory for FileFilterUtils.ageFileFilter(cutoff) and the filter it constructs: AgeFileFilter(cutoff) http://git-wip-us.apache.org/repos/asf/commons-io/blob/bfd83b00/src/main/java/org/apache/commons/io/FileUtils.java -- diff --git a/src/main/java/org/apache/commons/io/FileUtils.java b/src/main/java/org/apache/commons/io/FileUtils.java index 51f82d7..10f39b9 100644 --- a/src/main/java/org/apache/commons/io/FileUtils.java +++ b/src/main/java/org/apache/commons/io/FileUtils.java @@ -1531,6 +1531,75 @@ public class FileUtils { } } +/** + * Copies a file or directory to within another directory preserving the file dates. + * + * This method copies the source file or directory, along all its contents, to a + * directory of the same name in the specified destination directory. + * + * The destination directory is created if it does not exist. + * If the destination directory did exist, then this method merges + * the source with the destination, with the source taking precedence. + * + * Note: This method tries to preserve the files' last + * modified date/times using {@link File#setLastModified(long)}, however + * it is not guaranteed that those operations will succeed. + * If the modification operation fails, no indication is provided. + * + * @param src an existing file or directory to copy, must not be {@code null} + * @param destDir the directory to place the copy in, must not be {@code null} + * + * @throws NullPointerException if source or destination is {@code null} + * @throws IOException if source or destination is invalid + * @throws IOException if an IO error occurs during copying + * @see #copyDirectoryToDirectory(File, File) + * @see #copyFileToDirectory(File, File) + * @since 2.6 + */ +public static void copyToDirectory(final File src, final File destDir) throws IOException { +if (src == null) { +throw new NullPointerException("Source must not be null"); +} +if (src.isFile()) { +copyFileToDirectory(src, destDir); +} else if (src.isDirectory()) { +copyDirectoryToDirectory(src, destDir); +} else { +throw new IOException("The source " + src + " does not exist"); +} +} + +/** + * Copies a files to a directory preserving each file's date. + * + * This method copies the contents of the specified source files + * to a file of the same name in the specified destination directory. + * The destination directory is created if it does not exist. + * If the destination file exists, then this method will overwrite it. + * + * Note: This method tries to preserve the file's last + * modified date/times using {@link File#setLastModified(long)}, however + * it is not guaranteed that the operation will succeed. + * If the modification operation fails, no indication is provided. + * + * @param srcs a existing files to copy, must not be {@code null} + * @param destDir the directory to place the copy in, must not be {@code null} + * + * @throws NullPointerException if source or destination is null + * @throws IOException if source or destination is invalid + * @throws
[2/2] [lang] Merge branch 'pr/266'
Merge branch 'pr/266' This closes #266 Thanks! Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/7ddfc8ae Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/7ddfc8ae Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/7ddfc8ae Branch: refs/heads/master Commit: 7ddfc8ae1c4d712b0e52d2595b36743700940873 Parents: 88da5f4 6d74e8f Author: Bruno P. Kinoshita Authored: Mon May 1 21:54:51 2017 +1200 Committer: Bruno P. Kinoshita Committed: Mon May 1 21:54:51 2017 +1200 -- src/main/java/org/apache/commons/lang3/StringUtils.java | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/commons-lang/blob/7ddfc8ae/src/main/java/org/apache/commons/lang3/StringUtils.java --
[1/2] [lang] javadocs - fixed faulty samples of isNoneEmpty/isNoneBlank and added new ones to isAnyEmpty/isNoneEmpty/isAnyBlank/isNoneBlank for better understanding
Repository: commons-lang Updated Branches: refs/heads/master 88da5f49b -> 7ddfc8ae1 javadocs - fixed faulty samples of isNoneEmpty/isNoneBlank and added new ones to isAnyEmpty/isNoneEmpty/isAnyBlank/isNoneBlank for better understanding Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/6d74e8f8 Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/6d74e8f8 Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/6d74e8f8 Branch: refs/heads/master Commit: 6d74e8f83e96f536cbbad98cd4fe6fbd1cd67663 Parents: c8e648b Author: Basha Authored: Sun Apr 30 00:10:32 2017 +0530 Committer: Basha Committed: Sun Apr 30 00:13:06 2017 +0530 -- src/main/java/org/apache/commons/lang3/StringUtils.java | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/commons-lang/blob/6d74e8f8/src/main/java/org/apache/commons/lang3/StringUtils.java -- diff --git a/src/main/java/org/apache/commons/lang3/StringUtils.java b/src/main/java/org/apache/commons/lang3/StringUtils.java index bd660bc..3385c64 100644 --- a/src/main/java/org/apache/commons/lang3/StringUtils.java +++ b/src/main/java/org/apache/commons/lang3/StringUtils.java @@ -240,6 +240,8 @@ public class StringUtils { * StringUtils.isAnyEmpty(" bob ", null) = true * StringUtils.isAnyEmpty(" ", "bar") = false * StringUtils.isAnyEmpty("foo", "bar") = false + * StringUtils.isAnyEmpty(new String[]{}) = false + * StringUtils.isAnyEmpty(new String[]{""}) = true * * * @param css the CharSequences to check, may be null or empty @@ -267,7 +269,8 @@ public class StringUtils { * StringUtils.isNoneEmpty("", "bar")= false * StringUtils.isNoneEmpty("bob", "")= false * StringUtils.isNoneEmpty(" bob ", null) = false - * StringUtils.isNoneEmpty(new String[] {}) = false + * StringUtils.isNoneEmpty(new String[] {}) = true + * StringUtils.isNoneEmpty(new String[]{""}) = false * StringUtils.isNoneEmpty(" ", "bar") = true * StringUtils.isNoneEmpty("foo", "bar") = true * @@ -379,6 +382,7 @@ public class StringUtils { * StringUtils.isAnyBlank(" bob ", null) = true * StringUtils.isAnyBlank(" ", "bar") = true * StringUtils.isAnyBlank(new String[] {}) = false + * StringUtils.isAnyBlank(new String[]{""}) = true * StringUtils.isAnyBlank("foo", "bar") = false * * @@ -411,7 +415,8 @@ public class StringUtils { * StringUtils.isNoneBlank("bob", "")= false * StringUtils.isNoneBlank(" bob ", null) = false * StringUtils.isNoneBlank(" ", "bar") = false - * StringUtils.isNoneBlank(new String[] {}) = false + * StringUtils.isNoneBlank(new String[] {}) = true + * StringUtils.isNoneBlank(new String[]{""}) = false * StringUtils.isNoneBlank("foo", "bar") = true * * @@ -1065,7 +1070,7 @@ public class StringUtils { * @see String#compareTo(String) * @param str1 the String to compare from * @param str2 the String to compare to - * @return < 0, 0, > 0, if {@code str1} is respectively less, equal ou greater than {@code str2} + * @return < 0, 0, > 0, if {@code str1} is respectively less, equal or greater than {@code str2} * @since 3.5 */ public static int compare(final String str1, final String str2) {
[2/4] [lang] Adding testcase to cover a missing branch.
Adding testcase to cover a missing branch. Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/9766e22b Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/9766e22b Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/9766e22b Branch: refs/heads/master Commit: 9766e22b42b7b3f3923cb9c2502dfc2dd5d0a5b0 Parents: ece2f25 Author: Basha Authored: Sat Apr 29 20:05:58 2017 +0530 Committer: Basha Committed: Sat Apr 29 20:06:31 2017 +0530 -- .../commons/lang3/builder/ToStringBuilderTest.java| 14 ++ 1 file changed, 14 insertions(+) -- http://git-wip-us.apache.org/repos/asf/commons-lang/blob/9766e22b/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java -- diff --git a/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java b/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java index b218329..8e32287 100644 --- a/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java +++ b/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java @@ -17,6 +17,7 @@ package org.apache.commons.lang3.builder; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertNull; import static org.junit.Assert.assertSame; import static org.junit.Assume.assumeFalse; @@ -838,6 +839,19 @@ public class ToStringBuilderTest { assertEquals(baseStr + "[]", new ToStringBuilder(base).append(null, (boolean[]) null, false).toString()); assertEquals(baseStr + "[]", new ToStringBuilder(base).append(null, array, false).toString()); } + +@Test +public void testConstructToStringBuilder(){ +ToStringBuilder stringBuilder1 = new ToStringBuilder(base, null, null); +ToStringBuilder stringBuilder2 = new ToStringBuilder(base, ToStringStyle.DEFAULT_STYLE, new StringBuffer(1024)); +assertEquals(ToStringStyle.DEFAULT_STYLE, stringBuilder1.getStyle()); +assertNotNull(stringBuilder1.getStringBuffer()); +assertNotNull(stringBuilder1.toString()); +assertEquals(ToStringStyle.DEFAULT_STYLE, stringBuilder2.getStyle()); +assertNotNull(stringBuilder2.getStringBuffer()); +assertNotNull(stringBuilder2.toString()); +} + @Test public void testObject() {
[3/4] [lang] Merge branch 'pr/265'
Merge branch 'pr/265' This closes #265 Thanks Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/af323712 Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/af323712 Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/af323712 Branch: refs/heads/master Commit: af323712479ba1e2a5b8e519030d021915228c48 Parents: 610caab 9766e22 Author: Bruno P. Kinoshita Authored: Mon May 1 21:45:25 2017 +1200 Committer: Bruno P. Kinoshita Committed: Mon May 1 21:45:25 2017 +1200 -- .../lang3/builder/ToStringBuilderTest.java | 239 +++ 1 file changed, 239 insertions(+) --
[1/4] [lang] Increase test coverage of ToStringBuilder class to 100%
Repository: commons-lang Updated Branches: refs/heads/master 610caab59 -> 88da5f49b Increase test coverage of ToStringBuilder class to 100% Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/ece2f255 Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/ece2f255 Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/ece2f255 Branch: refs/heads/master Commit: ece2f255eed8ad9eff6e236152de65e804c6adb5 Parents: 331d2f2 Author: Basha Authored: Sat Apr 29 18:11:13 2017 +0530 Committer: Basha Committed: Sat Apr 29 19:22:59 2017 +0530 -- .../lang3/builder/ToStringBuilderTest.java | 225 +++ 1 file changed, 225 insertions(+) -- http://git-wip-us.apache.org/repos/asf/commons-lang/blob/ece2f255/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java -- diff --git a/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java b/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java index eba610a..b218329 100644 --- a/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java +++ b/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java @@ -615,6 +615,231 @@ public class ToStringBuilderTest { } @Test +public void testAppendAsObjectToString() { +String objectToAppend1 = ""; +Boolean objectToAppend2 = Boolean.TRUE; +Object objectToAppend3 = new Object(); + +assertEquals(baseStr + "[" + toBaseString(objectToAppend1) + "]", +new ToStringBuilder(base).appendAsObjectToString(objectToAppend1).toString()); +assertEquals(baseStr + "[" + toBaseString(objectToAppend2) + "]", +new ToStringBuilder(base).appendAsObjectToString(objectToAppend2).toString()); +assertEquals(baseStr + "[" + toBaseString(objectToAppend3) + "]", +new ToStringBuilder(base).appendAsObjectToString(objectToAppend3).toString()); +} + +@Test +public void testAppendBooleanArrayWithFieldName() { +boolean[] array = new boolean[] { true, false, false }; +assertEquals(baseStr + "[flags={true,false,false}]", +new ToStringBuilder(base).append("flags", array).toString()); +assertEquals(baseStr + "[flags=]", +new ToStringBuilder(base).append("flags", (boolean[]) null).toString()); +assertEquals(baseStr + "[]", new ToStringBuilder(base).append(null, (boolean[]) null).toString()); +assertEquals(baseStr + "[{true,false,false}]", new ToStringBuilder(base).append(null, array).toString()); +} + +@Test +public void testAppendBooleanArrayWithFieldNameAndFullDetatil() { +boolean[] array = new boolean[] { true, false, false }; +assertEquals(baseStr + "[flags={true,false,false}]", +new ToStringBuilder(base).append("flags", array, true).toString()); +assertEquals(baseStr + "[length=]", +new ToStringBuilder(base).append("length", array, false).toString()); +assertEquals(baseStr + "[flags=]", +new ToStringBuilder(base).append("flags", (boolean[]) null, true).toString()); +assertEquals(baseStr + "[]", new ToStringBuilder(base).append(null, (boolean[]) null, false).toString()); +assertEquals(baseStr + "[]", new ToStringBuilder(base).append(null, array, false).toString()); + } + +@Test +public void testAppendCharArrayWithFieldName() { +char[] array = new char[] { 'A', '2', '_', 'D' }; +assertEquals(baseStr + "[chars={A,2,_,D}]", new ToStringBuilder(base).append("chars", array).toString()); +assertEquals(baseStr + "[letters={A,2,_,D}]", new ToStringBuilder(base).append("letters", array).toString()); +assertEquals(baseStr + "[flags=]", +new ToStringBuilder(base).append("flags", (boolean[]) null).toString()); +assertEquals(baseStr + "[]", new ToStringBuilder(base).append(null, (boolean[]) null).toString()); +assertEquals(baseStr + "[{A,2,_,D}]", new ToStringBuilder(base).append(null, array).toString()); +} + +@Test +public void testAppendCharArrayWithFieldNameAndFullDetatil() { +char[] array = new char[] { 'A', '2', '_', 'D' }; +assertEquals(baseStr + "[chars={A,2,_,D}]", new ToStringBuilder(base).append("chars", array, true).toString()); +assertEquals(baseStr + "[letters=]", +new ToStringBuilder(base).append("letters", array, false).toString()); +assertEquals(baseStr + "[flags=]", +new ToStringBuilder(base).append("flags", (boolean[]) null, true).toString()); +assertEquals(baseStr + "[]", new ToStringBuilder(ba
[4/4] [lang] LANG-1325: update changes.xml
LANG-1325: update changes.xml Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/88da5f49 Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/88da5f49 Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/88da5f49 Branch: refs/heads/master Commit: 88da5f49bcaf798712274d60d378ddaebfaa20c2 Parents: af32371 Author: Bruno P. Kinoshita Authored: Mon May 1 21:48:04 2017 +1200 Committer: Bruno P. Kinoshita Committed: Mon May 1 21:48:04 2017 +1200 -- src/changes/changes.xml | 1 + 1 file changed, 1 insertion(+) -- http://git-wip-us.apache.org/repos/asf/commons-lang/blob/88da5f49/src/changes/changes.xml -- diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 6c3957a..dc6b795 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -46,6 +46,7 @@ The type attribute can be add,update,fix,remove. +Increase test coverage of ToStringBuilder class to 100% Add a method in StringUtils to extract only digits out of input string Implement HashSetvBitSetTest using JMH Add JMH maven dependencies
[1/2] [lang] LANG-1307: Added getDigits method to StringUtils (closes #225)
Repository: commons-lang Updated Branches: refs/heads/master c8e648b92 -> 610caab59 LANG-1307: Added getDigits method to StringUtils (closes #225) Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/9b3257e4 Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/9b3257e4 Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/9b3257e4 Branch: refs/heads/master Commit: 9b3257e4d1a63e0a4d971a331eaf7b9a08d98040 Parents: c8e648b Author: Arshad Basha Authored: Tue Jan 3 00:14:33 2017 +0530 Committer: pascalschumacher Committed: Mon May 1 11:05:45 2017 +0200 -- .../org/apache/commons/lang3/StringUtils.java | 36 .../apache/commons/lang3/StringUtilsTest.java | 11 ++ 2 files changed, 47 insertions(+) -- http://git-wip-us.apache.org/repos/asf/commons-lang/blob/9b3257e4/src/main/java/org/apache/commons/lang3/StringUtils.java -- diff --git a/src/main/java/org/apache/commons/lang3/StringUtils.java b/src/main/java/org/apache/commons/lang3/StringUtils.java index bd660bc..6ab1118 100644 --- a/src/main/java/org/apache/commons/lang3/StringUtils.java +++ b/src/main/java/org/apache/commons/lang3/StringUtils.java @@ -7157,6 +7157,42 @@ public class StringUtils { } /** + * Checks if a String {@code str} contains Unicode digits, + * if yes then concatenate all the digits in {@code str} and return it as a String. + * + * An empty ("") String will be returned if no digits found in {@code str}. + * + * + * StringUtils.getDigits(null) = null + * StringUtils.getDigits("")= "" + * StringUtils.getDigits("abc") = "" + * StringUtils.getDigits("1000$") = "1000" + * StringUtils.getDigits("1123~45") = "12345" + * StringUtils.getDigits("(541) 754-3010") = "5417543010" + * StringUtils.getDigits("\u0967\u0968\u0969") = "\u0967\u0968\u0969" + * + * + * @param str the String to extract digits from, may be null + * @return String with only digits, + * or an empty ("") String if no digits found, + * or {@code null} String if {@code str} is null + */ +public static String getDigits(final String str) { +if (isEmpty(str)) { +return str; +} +final int sz = str.length(); +final StringBuilder strDigits = new StringBuilder(sz); +for (int i = 0; i < sz; i++) { +final char tempChar = str.charAt(i); +if (Character.isDigit(tempChar)) { +strDigits.append(tempChar); +} +} +return strDigits.toString(); +} + +/** * Checks if the CharSequence contains only whitespace. * * Whitespace is defined by {@link Character#isWhitespace(char)}. http://git-wip-us.apache.org/repos/asf/commons-lang/blob/9b3257e4/src/test/java/org/apache/commons/lang3/StringUtilsTest.java -- diff --git a/src/test/java/org/apache/commons/lang3/StringUtilsTest.java b/src/test/java/org/apache/commons/lang3/StringUtilsTest.java index b776b3b..3051b47 100644 --- a/src/test/java/org/apache/commons/lang3/StringUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/StringUtilsTest.java @@ -3206,4 +3206,15 @@ public class StringUtilsTest { assertNull(StringUtils.toCodePoints(null)); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, StringUtils.toCodePoints("")); } + +@Test +public void testGetDigits() { +assertEquals(null, StringUtils.getDigits(null)); +assertEquals("", StringUtils.getDigits("")); +assertEquals("", StringUtils.getDigits("abc")); +assertEquals("1000", StringUtils.getDigits("1000$")); +assertEquals("12345", StringUtils.getDigits("123password45")); +assertEquals("5417543010", StringUtils.getDigits("(541) 754-3010")); +assertEquals("\u0967\u0968\u0969", StringUtils.getDigits("\u0967\u0968\u0969")); +} }
[2/2] [lang] LANG-1307: Add getDigits method to StringUtils
LANG-1307: Add getDigits method to StringUtils add since javadoc tag and changes.xml entry Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/610caab5 Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/610caab5 Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/610caab5 Branch: refs/heads/master Commit: 610caab590fe224c02c8f509431f6428fe8e1063 Parents: 9b3257e Author: pascalschumacher Authored: Mon May 1 11:08:10 2017 +0200 Committer: pascalschumacher Committed: Mon May 1 11:08:10 2017 +0200 -- src/changes/changes.xml | 1 + src/main/java/org/apache/commons/lang3/StringUtils.java | 1 + 2 files changed, 2 insertions(+) -- http://git-wip-us.apache.org/repos/asf/commons-lang/blob/610caab5/src/changes/changes.xml -- diff --git a/src/changes/changes.xml b/src/changes/changes.xml index a679df8..6c3957a 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -46,6 +46,7 @@ The type attribute can be add,update,fix,remove. +Add a method in StringUtils to extract only digits out of input string Implement HashSetvBitSetTest using JMH Add JMH maven dependencies Add null filter to ReflectionToStringBuilder http://git-wip-us.apache.org/repos/asf/commons-lang/blob/610caab5/src/main/java/org/apache/commons/lang3/StringUtils.java -- diff --git a/src/main/java/org/apache/commons/lang3/StringUtils.java b/src/main/java/org/apache/commons/lang3/StringUtils.java index 6ab1118..cf398d1 100644 --- a/src/main/java/org/apache/commons/lang3/StringUtils.java +++ b/src/main/java/org/apache/commons/lang3/StringUtils.java @@ -7176,6 +7176,7 @@ public class StringUtils { * @return String with only digits, * or an empty ("") String if no digits found, * or {@code null} String if {@code str} is null + * @since 3.6 */ public static String getDigits(final String str) { if (isEmpty(str)) {