[commons-parent] branch master updated: Update copyright to 2020.

2020-02-12 Thread ggregory
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-parent.git


The following commit(s) were added to refs/heads/master by this push:
 new 1bcbd1e  Update copyright to 2020.
1bcbd1e is described below

commit 1bcbd1edcb55cc2cf086ebd5783aa89c93a1396c
Author: Gary Gregory 
AuthorDate: Wed Feb 12 20:42:09 2020 -0500

Update copyright to 2020.
---
 NOTICE.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/NOTICE.txt b/NOTICE.txt
index b0aaacb..23fe308 100644
--- a/NOTICE.txt
+++ b/NOTICE.txt
@@ -1,5 +1,5 @@
 Apache Commons Parent
-Copyright 2006-2019 The Apache Software Foundation
+Copyright 2006-2020 The Apache Software Foundation
 
 This product includes software developed at
 The Apache Software Foundation (http://www.apache.org/).



[commons-parent] branch master updated: commons.spotbugs.version 3.1.6 -> 3.1.12.2.

2020-02-12 Thread ggregory
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-parent.git


The following commit(s) were added to refs/heads/master by this push:
 new f8b4f8d  commons.spotbugs.version 3.1.6 -> 3.1.12.2.
f8b4f8d is described below

commit f8b4f8d84dc564b2744a18a46bfebe8df5149af6
Author: Gary Gregory 
AuthorDate: Wed Feb 12 20:41:01 2020 -0500

commons.spotbugs.version 3.1.6 -> 3.1.12.2.
---
 pom.xml | 2 +-
 src/changes/changes.xml | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 782cc0e..da2730c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -173,7 +173,7 @@
 -->
 3.8.2
 3.2.1
-3.1.6
+3.1.12.2
 2.22.2
 2.22.2
 3.3.4
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 6522384..422a0fc 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -65,6 +65,7 @@ The  type attribute can be add,update,fix,remove.
 JApiCmp 0.14.1 -> 
0.14.3.
 maven-enforcer-plugin 
3.0.0-M2 -> 3.0.0-M3.
 maven-source-plugin 3.2.0 -> 
3.2.1.
+commons.spotbugs.version 
3.1.6 -> 3.1.12.2. 
 
 
 

[commons-csv] branch master updated: Replace FindBugs with SpotBugs #56.

2020-02-12 Thread ggregory
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-csv.git


The following commit(s) were added to refs/heads/master by this push:
 new 493616e  Replace FindBugs with SpotBugs #56.
493616e is described below

commit 493616e35cab307ec9b56d5138483e81e0354ddf
Author: Gary Gregory 
AuthorDate: Wed Feb 12 16:16:20 2020 -0500

Replace FindBugs with SpotBugs #56.
---
 src/changes/changes.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 688f4c9..638d893 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -40,6 +40,7 @@
   
 
   Add 
testcases for CSVRecord with get(Enum) and toString. #54.
+  Replace FindBugs with SpotBugs #56.
 
 

[commons-csv] branch master updated: replace findbugs with spotbugs (#56)

2020-02-12 Thread ggregory
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-csv.git


The following commit(s) were added to refs/heads/master by this push:
 new d83dab4  replace findbugs with spotbugs (#56)
d83dab4 is described below

commit d83dab4b0950e1cd8b13d29c470714e816c992a4
Author: Amey Jadiye 
AuthorDate: Thu Feb 13 02:44:28 2020 +0530

replace findbugs with spotbugs (#56)
---
 pom.xml| 31 +-
 .../spotbugs/spotbugs-exclude-filter.xml}  | 22 +++
 2 files changed, 22 insertions(+), 31 deletions(-)

diff --git a/pom.xml b/pom.xml
index 870eda2..01959d5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -168,7 +168,7 @@
   
 
   
-clean verify apache-rat:check clirr:check 
javadoc:javadoc
+clean verify apache-rat:check clirr:check checkstyle:check 
spotbugs:check javadoc:javadoc
 
   
 maven-compiler-plugin
@@ -208,15 +208,12 @@
   
${basedir}/src/main/resources/checkstyle/checkstyle-suppressions.xml
 
   
-  
   
-org.codehaus.mojo
-findbugs-maven-plugin
-${commons.findbugs.version}
+com.github.spotbugs
+spotbugs-maven-plugin
+${commons.spotbugs.version}
 
-  Normal
-  Default
-  
${basedir}/src/main/resources/findbugs/findbugs-exclude-filter.xml
+  
${basedir}/src/site/resources/spotbugs/spotbugs-exclude-filter.xml
 
   
   
@@ -288,6 +285,14 @@
 
   
   
+com.github.spotbugs
+spotbugs-maven-plugin
+${commons.spotbugs.version}
+
+  
${basedir}/src/site/resources/spotbugs/spotbugs-exclude-filter.xml
+
+  
+  
 org.apache.maven.plugins
 maven-pmd-plugin
 ${pmd.version}
@@ -302,16 +307,6 @@
   
   
 org.codehaus.mojo
-findbugs-maven-plugin
-${commons.findbugs.version}
-
-  Normal
-  Default
-  
${basedir}/src/main/resources/findbugs/findbugs-exclude-filter.xml
-
-  
-  
-org.codehaus.mojo
 taglist-maven-plugin
 2.4
 
diff --git a/src/main/resources/findbugs/findbugs-exclude-filter.xml 
b/src/site/resources/spotbugs/spotbugs-exclude-filter.xml
similarity index 57%
rename from src/main/resources/findbugs/findbugs-exclude-filter.xml
rename to src/site/resources/spotbugs/spotbugs-exclude-filter.xml
index da2896a..4af22bc 100644
--- a/src/main/resources/findbugs/findbugs-exclude-filter.xml
+++ b/src/site/resources/spotbugs/spotbugs-exclude-filter.xml
@@ -1,4 +1,3 @@
-
 
-
-
 https://github.com/spotbugs/filter/3.0.0;
-xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
-xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 
https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd;>
+xmlns="https://github.com/spotbugs/filter/3.0.0;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 
https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd;>
+
 
   
-
-
-
+
+  
+  
+  
+
   
 
 



[commons-numbers] 01/03: NUMBERS-40: fixing inconsistent exception behavior in RegularizedGamma.P.value(); fixing and adding exception javadocs

2020-02-12 Thread erans
This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit 0521c5e0c02411c40c5b8dcc5ac77b9a2bc7298f
Author: Matt Juntunen 
AuthorDate: Fri Feb 7 21:55:52 2020 -0500

NUMBERS-40: fixing inconsistent exception behavior in 
RegularizedGamma.P.value(); fixing and adding exception javadocs
---
 .../org/apache/commons/numbers/arrays/CosAngle.java  |  1 +
 .../apache/commons/numbers/arrays/CosAngleTest.java  | 11 +++
 .../numbers/combinatorics/BinomialCoefficient.java   |  2 +-
 .../combinatorics/BinomialCoefficientDouble.java |  4 +---
 .../combinatorics/LogBinomialCoefficient.java|  2 --
 .../numbers/complex/streams/ComplexUtils.java| 20 ++--
 .../apache/commons/numbers/fraction/BigFraction.java | 10 +++---
 .../apache/commons/numbers/fraction/Fraction.java| 16 
 .../apache/commons/numbers/gamma/ErfDifference.java  |  1 +
 .../apache/commons/numbers/gamma/GammaException.java |  2 --
 .../commons/numbers/gamma/RegularizedGamma.java  |  9 -
 .../org/apache/commons/numbers/quaternion/Slerp.java |  2 +-
 .../commons/numbers/rootfinder/BrentSolver.java  |  5 +
 13 files changed, 62 insertions(+), 23 deletions(-)

diff --git 
a/commons-numbers-arrays/src/main/java/org/apache/commons/numbers/arrays/CosAngle.java
 
b/commons-numbers-arrays/src/main/java/org/apache/commons/numbers/arrays/CosAngle.java
index dbddbbc..e728d21 100644
--- 
a/commons-numbers-arrays/src/main/java/org/apache/commons/numbers/arrays/CosAngle.java
+++ 
b/commons-numbers-arrays/src/main/java/org/apache/commons/numbers/arrays/CosAngle.java
@@ -32,6 +32,7 @@ public final class CosAngle {
  * @param v1 Cartesian coordinates of the first vector.
  * @param v2 Cartesian coordinates of the second vector.
  * @return the cosine of the angle between the vectors.
+ * @throws IllegalArgumentException if the sizes of the input arrays are 
different
  */
 public static double value(double[] v1,
double[] v2) {
diff --git 
a/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/CosAngleTest.java
 
b/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/CosAngleTest.java
index ffef55c..758ee3f 100644
--- 
a/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/CosAngleTest.java
+++ 
b/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/CosAngleTest.java
@@ -23,6 +23,7 @@ import org.junit.jupiter.api.Test;
  * Test cases for the {@link CosAngle} class.
  */
 public class CosAngleTest {
+
 @Test
 public void testCosAngle2D() {
 double expected;
@@ -77,4 +78,14 @@ public class CosAngleTest {
 expected = 0;
 Assertions.assertEquals(expected, CosAngle.value(v1, v3), 1e-15);
 }
+
+@Test
+public void testCosAngle_dimensionMismatch() {
+final double[] a = {1.0};
+final double[] b = {1.0, 2.0};
+
+Assertions.assertThrows(IllegalArgumentException.class, () -> {
+CosAngle.value(a, b);
+});
+}
 }
diff --git 
a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/BinomialCoefficient.java
 
b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/BinomialCoefficient.java
index 801669e..d19f592 100644
--- 
a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/BinomialCoefficient.java
+++ 
b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/BinomialCoefficient.java
@@ -33,7 +33,7 @@ public final class BinomialCoefficient {
 }
 
 /**
- * Computes de binomial coefficient.
+ * Computes the binomial coefficient.
  * The largest value of {@code n} for which all coefficients can
  * fit into a {@code long} is 66.
  *
diff --git 
a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientDouble.java
 
b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientDouble.java
index b0b276e..bd95280 100644
--- 
a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientDouble.java
+++ 
b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientDouble.java
@@ -31,7 +31,7 @@ public final class BinomialCoefficientDouble {
 }
 
 /**
- * Computes de binomial coefficient.
+ * Computes the binomial coefficient.
  * The largest value of {@code n} for which all coefficients can
  * fit into a {@code long} is 66.
  *
@@ -40,8 +40,6 @@ public final class BinomialCoefficientDouble {
  * @return {@code n choose k}.
  * @throws IllegalArgumentException if {@code n < 0}.
  * @throws 

[commons-numbers] branch master updated (97b2499 -> b792580)

2020-02-12 Thread erans
This is an automated email from the ASF dual-hosted git repository.

erans pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git.


from 97b2499  Use final.
 new 0521c5e  NUMBERS-40: fixing inconsistent exception behavior in 
RegularizedGamma.P.value(); fixing and adding exception javadocs
 new b095358  Javadoc.
 new b792580  Merge branch 'NUMBERS-40__Matt'

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../org/apache/commons/numbers/arrays/CosAngle.java  |  1 +
 .../apache/commons/numbers/arrays/CosAngleTest.java  | 11 +++
 .../numbers/combinatorics/BinomialCoefficient.java   |  2 +-
 .../combinatorics/BinomialCoefficientDouble.java |  4 +---
 .../combinatorics/LogBinomialCoefficient.java|  2 --
 .../numbers/complex/streams/ComplexUtils.java| 20 ++--
 .../apache/commons/numbers/fraction/BigFraction.java | 10 +++---
 .../apache/commons/numbers/fraction/Fraction.java| 16 
 .../apache/commons/numbers/gamma/ErfDifference.java  |  1 +
 .../apache/commons/numbers/gamma/GammaException.java |  2 --
 .../commons/numbers/gamma/RegularizedGamma.java  |  9 -
 .../org/apache/commons/numbers/quaternion/Slerp.java |  2 +-
 .../commons/numbers/rootfinder/BrentSolver.java  |  7 +++
 13 files changed, 64 insertions(+), 23 deletions(-)



[commons-numbers] 03/03: Merge branch 'NUMBERS-40__Matt'

2020-02-12 Thread erans
This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit b7925803fda67fe27fbb2175c0773e6efba435ba
Merge: 97b2499 b095358
Author: Gilles Sadowski 
AuthorDate: Wed Feb 12 20:58:13 2020 +0100

Merge branch 'NUMBERS-40__Matt'

Closes #74.

 .../org/apache/commons/numbers/arrays/CosAngle.java  |  1 +
 .../apache/commons/numbers/arrays/CosAngleTest.java  | 11 +++
 .../numbers/combinatorics/BinomialCoefficient.java   |  2 +-
 .../combinatorics/BinomialCoefficientDouble.java |  4 +---
 .../combinatorics/LogBinomialCoefficient.java|  2 --
 .../numbers/complex/streams/ComplexUtils.java| 20 ++--
 .../apache/commons/numbers/fraction/BigFraction.java | 10 +++---
 .../apache/commons/numbers/fraction/Fraction.java| 16 
 .../apache/commons/numbers/gamma/ErfDifference.java  |  1 +
 .../apache/commons/numbers/gamma/GammaException.java |  2 --
 .../commons/numbers/gamma/RegularizedGamma.java  |  9 -
 .../org/apache/commons/numbers/quaternion/Slerp.java |  2 +-
 .../commons/numbers/rootfinder/BrentSolver.java  |  7 +++
 13 files changed, 64 insertions(+), 23 deletions(-)



[commons-numbers] 02/03: Javadoc.

2020-02-12 Thread erans
This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit b09535852dd45c066a506963eb51b581098b55e2
Author: Gilles Sadowski 
AuthorDate: Wed Feb 12 20:56:53 2020 +0100

Javadoc.
---
 .../org/apache/commons/numbers/rootfinder/BrentSolver.java   | 12 +++-
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git 
a/commons-numbers-rootfinder/src/main/java/org/apache/commons/numbers/rootfinder/BrentSolver.java
 
b/commons-numbers-rootfinder/src/main/java/org/apache/commons/numbers/rootfinder/BrentSolver.java
index 4fd4165..4b7c3c3 100644
--- 
a/commons-numbers-rootfinder/src/main/java/org/apache/commons/numbers/rootfinder/BrentSolver.java
+++ 
b/commons-numbers-rootfinder/src/main/java/org/apache/commons/numbers/rootfinder/BrentSolver.java
@@ -66,8 +66,9 @@ public class BrentSolver {
  * @param min Lower bound.
  * @param max Upper bound.
  * @return the root.
- * @throws IllegalArgumentException if {@code min}  {@code max}.
- * @throws IllegalArgumentException if the given interval does not bracket 
the root.
+ * @throws IllegalArgumentException if {@code min > max}.
+ * @throws IllegalArgumentException if the given interval does
+ * not bracket the root.
  */
 public double findRoot(DoubleUnaryOperator func,
double min,
@@ -84,9 +85,10 @@ public class BrentSolver {
  * @param initial Initial guess.
  * @param max Upper bound.
  * @return the root.
- * @throws IllegalArgumentException if {@code min}  {@code max} or
- *  {@code initial} is not in the range {@code (min, max)}.
- * @throws IllegalArgumentException if the given interval does not bracket 
the root.
+ * @throws IllegalArgumentException if {@code min > max} or
+ * {@code initial} is not in the {@code [min, max]} interval.
+ * @throws IllegalArgumentException if the given interval does
+ * not bracket the root.
  */
 public double findRoot(DoubleUnaryOperator func,
double min,