[commons-ognl] branch dependabot/maven/org.codehaus.mojo-build-helper-maven-plugin-3.2.0 created (now 06e3974)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.codehaus.mojo-build-helper-maven-plugin-3.2.0 in repository https://gitbox.apache.org/repos/asf/commons-ognl.git. at 06e3974 Bump build-helper-maven-plugin from 1.7 to 3.2.0 No new revisions were added by this update.
[commons-fileupload] branch master updated: Bump maven-pmd-plugin from 3.13.0 to 3.14.0 #48.
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git The following commit(s) were added to refs/heads/master by this push: new 6edc12f Bump maven-pmd-plugin from 3.13.0 to 3.14.0 #48. new a6d4eac Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-fileupload.git 6edc12f is described below commit 6edc12f3ab551806a26eb32e0423dffee4e78ecd Author: Gary Gregory AuthorDate: Sun Dec 20 14:44:41 2020 -0500 Bump maven-pmd-plugin from 3.13.0 to 3.14.0 #48. --- src/changes/changes.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index eaf7664..962a42e 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -54,6 +54,7 @@ The type attribute can be add,update,fix,remove. Update tests from commons-io:commons-io 2.6 to 2.7. Update junit-jupiter from 5.5.2 to 5.6.2 #31. Slight optim: resuse the index position instead of recomputing it #49. + Bump maven-pmd-plugin from 3.13.0 to 3.14.0 #48. Don't create un-needed resources in FileUploadBase.java
[commons-dbcp] branch master updated: [DBCP-567] making abort synchronous (#80)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
The following commit(s) were added to refs/heads/master by this push:
new f3f41f6 [DBCP-567] making abort synchronous (#80)
f3f41f6 is described below
commit f3f41f604c3b6723ef8bdbc981400c9df6389e8a
Author: Romain Manni-Bucau
AuthorDate: Mon Dec 28 23:49:30 2020 +0100
[DBCP-567] making abort synchronous (#80)
---
.../commons/dbcp2/PoolableConnectionFactory.java | 31 ++
1 file changed, 2 insertions(+), 29 deletions(-)
diff --git
a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
index a0c053d..9fcbc1c 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
@@ -17,16 +17,11 @@
package org.apache.commons.dbcp2;
-import java.security.AccessController;
-import java.security.PrivilegedAction;
import java.sql.Connection;
import java.sql.SQLException;
import java.sql.Statement;
import java.util.Collection;
import java.util.Objects;
-import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Executors;
-import java.util.concurrent.ThreadFactory;
import java.util.concurrent.atomic.AtomicLong;
import javax.management.ObjectName;
@@ -49,26 +44,6 @@ import
org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig;
*/
public class PoolableConnectionFactory implements
PooledObjectFactory, AutoCloseable {
-/**
- * Thread factory that creates daemon threads, with the context class
loader from this class.
- */
-private static class AbortThreadFactory implements ThreadFactory {
-
-private static final AbortThreadFactory INSTANCE = new
AbortThreadFactory();
-
-@Override
-public Thread newThread(final Runnable runnable) {
-final Thread thread = new Thread(null, runnable,
"commons-dbcp-abort-thread");
-thread.setDaemon(true); // POOL-363 - Required for applications
using Runtime.addShutdownHook().
-AccessController.doPrivileged((PrivilegedAction) () -> {
-
thread.setContextClassLoader(AbortThreadFactory.class.getClassLoader());
-return null;
-});
-
-return thread;
-}
-}
-
private static final Log log =
LogFactory.getLog(PoolableConnectionFactory.class);
/**
@@ -120,8 +95,6 @@ public class PoolableConnectionFactory implements
PooledObjectFactory p, final
DestroyMode mode) throws Exception {
if (mode != null && mode.equals(DestroyMode.ABANDONED)) {
-p.getObject().getInnermostDelegate().abort(executor);
+p.getObject().getInnermostDelegate().abort(Runnable::run);
} else {
p.getObject().reallyClose();
}
[commons-dbcp] 01/01: [DBCP-567] making abort synchronous
This is an automated email from the ASF dual-hosted git repository.
rmannibucau pushed a commit to branch DBCP-567
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
commit 3d84591c1596908c6095c8670fd13e04f8a92012
Author: Romain Manni-Bucau
AuthorDate: Mon Dec 28 19:20:50 2020 +0100
[DBCP-567] making abort synchronous
---
.../commons/dbcp2/PoolableConnectionFactory.java | 31 ++
1 file changed, 2 insertions(+), 29 deletions(-)
diff --git
a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
index a0c053d..9fcbc1c 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
@@ -17,16 +17,11 @@
package org.apache.commons.dbcp2;
-import java.security.AccessController;
-import java.security.PrivilegedAction;
import java.sql.Connection;
import java.sql.SQLException;
import java.sql.Statement;
import java.util.Collection;
import java.util.Objects;
-import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Executors;
-import java.util.concurrent.ThreadFactory;
import java.util.concurrent.atomic.AtomicLong;
import javax.management.ObjectName;
@@ -49,26 +44,6 @@ import
org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig;
*/
public class PoolableConnectionFactory implements
PooledObjectFactory, AutoCloseable {
-/**
- * Thread factory that creates daemon threads, with the context class
loader from this class.
- */
-private static class AbortThreadFactory implements ThreadFactory {
-
-private static final AbortThreadFactory INSTANCE = new
AbortThreadFactory();
-
-@Override
-public Thread newThread(final Runnable runnable) {
-final Thread thread = new Thread(null, runnable,
"commons-dbcp-abort-thread");
-thread.setDaemon(true); // POOL-363 - Required for applications
using Runtime.addShutdownHook().
-AccessController.doPrivileged((PrivilegedAction) () -> {
-
thread.setContextClassLoader(AbortThreadFactory.class.getClassLoader());
-return null;
-});
-
-return thread;
-}
-}
-
private static final Log log =
LogFactory.getLog(PoolableConnectionFactory.class);
/**
@@ -120,8 +95,6 @@ public class PoolableConnectionFactory implements
PooledObjectFactory p, final
DestroyMode mode) throws Exception {
if (mode != null && mode.equals(DestroyMode.ABANDONED)) {
-p.getObject().getInnermostDelegate().abort(executor);
+p.getObject().getInnermostDelegate().abort(Runnable::run);
} else {
p.getObject().reallyClose();
}
[commons-dbcp] branch DBCP-567 created (now 3d84591)
This is an automated email from the ASF dual-hosted git repository. rmannibucau pushed a change to branch DBCP-567 in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git. at 3d84591 [DBCP-567] making abort synchronous This branch includes the following new commits: new 3d84591 [DBCP-567] making abort synchronous The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[commons-dbcp] branch master updated: [DBCP-567] Use abort rather than close to destroy abandoned connections #68.
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git The following commit(s) were added to refs/heads/master by this push: new 330a90d [DBCP-567] Use abort rather than close to destroy abandoned connections #68. 330a90d is described below commit 330a90dd2970f5aba521f7f070e704b8ab1d37fb Author: Gary Gregory AuthorDate: Mon Dec 28 12:38:34 2020 -0500 [DBCP-567] Use abort rather than close to destroy abandoned connections #68. --- src/changes/changes.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 66cd029..417db70 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -83,6 +83,9 @@ The type attribute can be add,update,fix,remove. Bump maven-pmd-plugin from 3.13.0 to 3.14.0 #76. + + Use abort rather than close to clean up abandoned connections. +
[commons-dbcp] branch master updated: Sort members.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
The following commit(s) were added to refs/heads/master by this push:
new ea019c8 Sort members.
ea019c8 is described below
commit ea019c89dd32de7165d0d41096e137fd6a1d848a
Author: Gary Gregory
AuthorDate: Mon Dec 28 12:33:20 2020 -0500
Sort members.
---
.../commons/dbcp2/PoolableConnectionFactory.java | 84 +++---
1 file changed, 42 insertions(+), 42 deletions(-)
diff --git
a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
index ce239e4..a0c053d 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
@@ -49,6 +49,26 @@ import
org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig;
*/
public class PoolableConnectionFactory implements
PooledObjectFactory, AutoCloseable {
+/**
+ * Thread factory that creates daemon threads, with the context class
loader from this class.
+ */
+private static class AbortThreadFactory implements ThreadFactory {
+
+private static final AbortThreadFactory INSTANCE = new
AbortThreadFactory();
+
+@Override
+public Thread newThread(final Runnable runnable) {
+final Thread thread = new Thread(null, runnable,
"commons-dbcp-abort-thread");
+thread.setDaemon(true); // POOL-363 - Required for applications
using Runtime.addShutdownHook().
+AccessController.doPrivileged((PrivilegedAction) () -> {
+
thread.setContextClassLoader(AbortThreadFactory.class.getClassLoader());
+return null;
+});
+
+return thread;
+}
+}
+
private static final Log log =
LogFactory.getLog(PoolableConnectionFactory.class);
/**
@@ -142,6 +162,14 @@ public class PoolableConnectionFactory implements
PooledObjectFactory p) throws
Exception {
p.getObject().reallyClose();
@@ -289,7 +317,6 @@ public class PoolableConnectionFactory implements
PooledObjectFactory getPool() {
return pool;
}
-
/**
* @return Whether to pool statements.
* @since Made public in 2.6.0.
@@ -313,6 +339,7 @@ public class PoolableConnectionFactory implements
PooledObjectFactory sqls = connectionInitSqls;
if (conn.isClosed()) {
@@ -473,6 +501,17 @@ public class PoolableConnectionFactory implements
PooledObjectFactory
connectionInitSqls) {
this.connectionInitSqls = connectionInitSqls;
}
-
/**
* Sets the default "auto commit" setting for borrowed {@link Connection}s
*
@@ -506,6 +544,7 @@ public class PoolableConnectionFactory implements
PooledObjectFactory) () -> {
-
thread.setContextClassLoader(AbortThreadFactory.class.getClassLoader());
-return null;
-});
-
-return thread;
-}
-}
}
[commons-dbcp] branch master updated: [DBCP-567] Use abort rather than close to destroy abandoned connections #68.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
The following commit(s) were added to refs/heads/master by this push:
new 7529c24 [DBCP-567] Use abort rather than close to destroy abandoned
connections #68.
7529c24 is described below
commit 7529c2476e4a53073ebe183eebc34c49e6eadd8c
Author: Gary Gregory
AuthorDate: Mon Dec 28 12:32:25 2020 -0500
[DBCP-567] Use abort rather than close to destroy abandoned connections
#68.
- Add missing since Javadoc tags.
---
.../java/org/apache/commons/dbcp2/PoolableConnectionFactory.java| 6 ++
1 file changed, 6 insertions(+)
diff --git
a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
index 2433cad..ce239e4 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
@@ -147,6 +147,9 @@ public class PoolableConnectionFactory implements
PooledObjectFactory p, final
DestroyMode mode) throws Exception {
if (mode != null && mode.equals(DestroyMode.ABANDONED)) {
@@ -686,6 +689,9 @@ public class PoolableConnectionFactory implements
PooledObjectFactory
[commons-dbcp] branch master updated: [DBCP-567] Use abort rather than close to destroy abandoned connections #68.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
The following commit(s) were added to refs/heads/master by this push:
new 0099390 [DBCP-567] Use abort rather than close to destroy abandoned
connections #68.
0099390 is described below
commit 009939097c02c3022506df93cee6f6269514f489
Author: Gary Gregory
AuthorDate: Mon Dec 28 12:29:34 2020 -0500
[DBCP-567] Use abort rather than close to destroy abandoned connections
#68.
- Add missing override annotation.
- Add missing since Javadoc tag.
---
src/main/java/org/apache/commons/dbcp2/PoolableConnection.java | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
b/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
index 3f109cc..d075d99 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
@@ -236,7 +236,10 @@ public class PoolableConnection extends
DelegatingConnection impleme
/**
* Abort my underlying {@link Connection}.
+ *
+ * @since 2.9.0
*/
+@Override
public void abort(Executor executor) throws SQLException {
if (jmxObjectName != null) {
jmxObjectName.unregisterMBean();
[commons-dbcp] branch master updated: [DBCP-567] Use abort rather than close to destroy abandoned connections #68.
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git The following commit(s) were added to refs/heads/master by this push: new 8a0dc02 [DBCP-567] Use abort rather than close to destroy abandoned connections #68. 8a0dc02 is described below commit 8a0dc0273b3dfc72f3a605ce826a28098a811c79 Author: Gary Gregory AuthorDate: Mon Dec 28 12:28:13 2020 -0500 [DBCP-567] Use abort rather than close to destroy abandoned connections #68. Create and use a singleton. --- src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java index e1c3d06..2433cad 100644 --- a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java +++ b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java @@ -100,7 +100,7 @@ public class PoolableConnectionFactory implements PooledObjectFactory
[commons-dbcp] branch master updated: [DBCP-567] Use abort rather than close to destroy abandoned connections #68.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
The following commit(s) were added to refs/heads/master by this push:
new c11ddde [DBCP-567] Use abort rather than close to destroy abandoned
connections #68.
c11ddde is described below
commit c11ddde8f032e660377d12bf7597c20136a0ff92
Author: Gary Gregory
AuthorDate: Mon Dec 28 12:22:43 2020 -0500
[DBCP-567] Use abort rather than close to destroy abandoned connections
#68.
Simpler type cast.
---
src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java
b/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java
index 8fd75b3..3458c93 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java
@@ -78,7 +78,7 @@ public class PoolingDataSource
implements DataSource, Auto
public void close() throws RuntimeException, SQLException {
try {
if (pool instanceof GenericObjectPool) {
-((PoolableConnectionFactory) ((GenericObjectPool)
pool).getFactory()).close();
+((AutoCloseable) ((GenericObjectPool)
pool).getFactory()).close();
}
pool.close();
} catch (final RuntimeException rte) {
[commons-dbcp] branch master updated: Use abort rather than close to destroy abandoned connections. Fixes DBCP-567. (#68)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
The following commit(s) were added to refs/heads/master by this push:
new cbf77a0 Use abort rather than close to destroy abandoned connections.
Fixes DBCP-567. (#68)
cbf77a0 is described below
commit cbf77a08b7c64c1df3e2b2d2ee5e1415c9a885a1
Author: Phil Steitz
AuthorDate: Mon Dec 28 10:17:43 2020 -0700
Use abort rather than close to destroy abandoned connections. Fixes
DBCP-567. (#68)
---
.../org/apache/commons/dbcp2/BasicDataSource.java | 1 +
.../apache/commons/dbcp2/DelegatingConnection.java | 1 -
.../apache/commons/dbcp2/PoolableConnection.java | 11 ++
.../commons/dbcp2/PoolableConnectionFactory.java | 42 +-
.../apache/commons/dbcp2/PoolingDataSource.java| 3 ++
.../dbcp2/TestAbandonedBasicDataSource.java| 3 ++
.../org/apache/commons/dbcp2/TesterConnection.java | 10 +-
7 files changed, 68 insertions(+), 3 deletions(-)
diff --git a/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
b/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
index 5fdbb2c..68235e7 100644
--- a/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
+++ b/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
@@ -428,6 +428,7 @@ public class BasicDataSource implements DataSource,
BasicDataSourceMXBean, MBean
*/
private void closeConnectionPool() {
final GenericObjectPool oldPool = connectionPool;
+((PoolableConnectionFactory) connectionPool.getFactory()).close();
connectionPool = null;
try {
if (oldPool != null) {
diff --git a/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java
b/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java
index 3f6d46b..11438f3 100644
--- a/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java
+++ b/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java
@@ -964,7 +964,6 @@ public class DelegatingConnection
extends AbandonedTrace i
@Override
public void abort(final Executor executor) throws SQLException {
-checkOpen();
try {
Jdbc41Bridge.abort(connection, executor);
} catch (final SQLException e) {
diff --git a/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
b/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
index 0cd0ee0..3f109cc 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
@@ -22,6 +22,7 @@ import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.Collection;
+import java.util.concurrent.Executor;
import javax.management.InstanceAlreadyExistsException;
import javax.management.MBeanRegistrationException;
@@ -234,6 +235,16 @@ public class PoolableConnection extends
DelegatingConnection impleme
}
/**
+ * Abort my underlying {@link Connection}.
+ */
+public void abort(Executor executor) throws SQLException {
+if (jmxObjectName != null) {
+jmxObjectName.unregisterMBean();
+}
+super.abort(executor);
+}
+
+/**
* Expose the {@link #toString()} method via a bean getter so it can be
read as a property via JMX.
*/
@Override
diff --git
a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
index 8d47df1..e1c3d06 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
@@ -17,17 +17,23 @@
package org.apache.commons.dbcp2;
+import java.security.AccessController;
+import java.security.PrivilegedAction;
import java.sql.Connection;
import java.sql.SQLException;
import java.sql.Statement;
import java.util.Collection;
import java.util.Objects;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ThreadFactory;
import java.util.concurrent.atomic.AtomicLong;
import javax.management.ObjectName;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
+import org.apache.commons.pool2.DestroyMode;
import org.apache.commons.pool2.KeyedObjectPool;
import org.apache.commons.pool2.ObjectPool;
import org.apache.commons.pool2.PooledObject;
@@ -41,7 +47,7 @@ import
org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig;
*
* @since 2.0
*/
-public class PoolableConnectionFactory implements
PooledObjectFactory {
+public class PoolableConnectionFactory implements
PooledObjectFactory, AutoCloseable {
private static final Log log =
LogFactory.getLog(PoolableConnectionFactory.class);
@@ -94,6 +100,8 @@ public class
[commons-dbcp] branch master updated: Bump actions/checkout from v2.3.3 to v2.3.4 #74.
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git The following commit(s) were added to refs/heads/master by this push: new b6bdcdd Bump actions/checkout from v2.3.3 to v2.3.4 #74. new 9539444 Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-dbcp.git b6bdcdd is described below commit b6bdcdd529c877ca566b0f6463284a6d9725a806 Author: Gary Gregory AuthorDate: Mon Dec 28 11:51:38 2020 -0500 Bump actions/checkout from v2.3.3 to v2.3.4 #74. --- src/changes/changes.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 87c94ed..66cd029 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -66,7 +66,7 @@ The type attribute can be add,update,fix,remove. Update mockito-core from 3.5.11 to 3.5.15 #66, #72. -Update actions/checkout from v2.3.2 to v2.3.3 #65. +Update actions/checkout from v2.3.2 to v2.3.4 #65, #74. Update commons-pool2 from 2.8.1 to 2.9.0.
[commons-dbcp] branch master updated: Bump actions/checkout from v2.3.3 to v2.3.4 (#74)
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git The following commit(s) were added to refs/heads/master by this push: new 3ac3f58 Bump actions/checkout from v2.3.3 to v2.3.4 (#74) 3ac3f58 is described below commit 3ac3f5816dc1d0177e1ef49bcd648d5a4bb881ae Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> AuthorDate: Mon Dec 28 11:51:03 2020 -0500 Bump actions/checkout from v2.3.3 to v2.3.4 (#74) Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.3 to v2.3.4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v2.3.3...5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f) Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/maven.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml index b6bfea1..c0d6005 100644 --- a/.github/workflows/maven.yml +++ b/.github/workflows/maven.yml @@ -31,7 +31,7 @@ jobs: experimental: true steps: -- uses: actions/checkout@v2.3.3 +- uses: actions/checkout@v2.3.4 - uses: actions/cache@v2 with: path: ~/.m2/repository
[commons-dbcp] branch master updated: Bump maven-pmd-plugin from 3.13.0 to 3.14.0 #76.
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git The following commit(s) were added to refs/heads/master by this push: new 9312e9b Bump maven-pmd-plugin from 3.13.0 to 3.14.0 #76. 9312e9b is described below commit 9312e9ba1cfb1ae36813098e957363efd444ddab Author: Gary Gregory AuthorDate: Mon Dec 28 11:50:49 2020 -0500 Bump maven-pmd-plugin from 3.13.0 to 3.14.0 #76. --- src/changes/changes.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 7050afa..87c94ed 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -80,6 +80,9 @@ The type attribute can be add,update,fix,remove. Bump mockito-core from 3.5.15 to 3.6.28 #77. + + Bump maven-pmd-plugin from 3.13.0 to 3.14.0 #76. +
[commons-dbcp] branch master updated: Bump maven-pmd-plugin from 3.13.0 to 3.14.0 (#76)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
The following commit(s) were added to refs/heads/master by this push:
new 754cced Bump maven-pmd-plugin from 3.13.0 to 3.14.0 (#76)
754cced is described below
commit 754cced03948e1d615676b11f7f6079075c9623e
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AuthorDate: Mon Dec 28 11:49:57 2020 -0500
Bump maven-pmd-plugin from 3.13.0 to 3.14.0 (#76)
Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from
3.13.0 to 3.14.0.
- [Release notes](https://github.com/apache/maven-pmd-plugin/releases)
-
[Commits](https://github.com/apache/maven-pmd-plugin/compare/maven-pmd-plugin-3.13.0...maven-pmd-plugin-3.14.0)
Signed-off-by: dependabot[bot]
Co-authored-by: dependabot[bot]
<49699333+dependabot[bot]@users.noreply.github.com>
---
pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pom.xml b/pom.xml
index c163802..e5f247b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -503,7 +503,7 @@
maven-pmd-plugin
-3.13.0
+3.14.0
${maven.compiler.target}
[commons-dbcp] branch master updated: Bump mockito-core from 3.5.15 to 3.6.28 #77.
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git The following commit(s) were added to refs/heads/master by this push: new def4d7c Bump mockito-core from 3.5.15 to 3.6.28 #77. def4d7c is described below commit def4d7c17d32bcbed5e16ebeee35ff695b954ea6 Author: Gary Gregory AuthorDate: Mon Dec 28 11:49:40 2020 -0500 Bump mockito-core from 3.5.15 to 3.6.28 #77. --- src/changes/changes.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index a720ec2..7050afa 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -77,6 +77,9 @@ The type attribute can be add,update,fix,remove. Bump japicmp-maven-plugin from 0.14.3 to 0.14.4 #71. + + Bump mockito-core from 3.5.15 to 3.6.28 #77. +
[commons-dbcp] branch master updated (3b37562 -> 77c4864)
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git. from 3b37562 Fix spelling in Javadoc. add 77c4864 Bump mockito-core from 3.5.15 to 3.6.28 (#77) No new revisions were added by this update. Summary of changes: pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[commons-cli] branch master updated: Bump maven-checkstyle-plugin from 2.15 to 3.1.1 #41.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-cli.git
The following commit(s) were added to refs/heads/master by this push:
new d83153e Bump maven-checkstyle-plugin from 2.15 to 3.1.1 #41.
d83153e is described below
commit d83153e81bfbcf3107653d941ed7dab4071a8fc6
Author: Gary Gregory
AuthorDate: Mon Dec 28 10:58:37 2020 -0500
Bump maven-checkstyle-plugin from 2.15 to 3.1.1 #41.
---
pom.xml | 4 ++--
src/changes/changes.xml | 5 -
src/conf/checkstyle.xml | 18 ++
3 files changed, 12 insertions(+), 15 deletions(-)
diff --git a/pom.xml b/pom.xml
index 00fe404..c2e4fc6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -233,7 +233,7 @@
org.apache.maven.plugins
maven-checkstyle-plugin
- 2.15
+ ${commons.checkstyle-plugin.version}
${basedir}/src/conf/checkstyle.xml
false
@@ -269,7 +269,7 @@
org.apache.maven.plugins
maven-checkstyle-plugin
-2.15
+${commons.checkstyle-plugin.version}
${basedir}/src/conf/checkstyle.xml
false
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 19aa92f..76a9da1 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -73,7 +73,10 @@
Bump maven-antrun-plugin from 1.7 to 3.0.0 #43.
-
+
+
+Bump maven-checkstyle-plugin from 2.15 to 3.1.1 #41.
+
diff --git a/src/conf/checkstyle.xml b/src/conf/checkstyle.xml
index 1daf46a..f469667 100644
--- a/src/conf/checkstyle.xml
+++ b/src/conf/checkstyle.xml
@@ -17,8 +17,8 @@ limitations under the License.
-->
http://www.puppycrawl.com/dtds/configuration_1_1.dtd;>
+"-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
+"https://checkstyle.org/dtds/configuration_1_3.dtd;>
@@ -47,16 +47,16 @@ limitations under the License.
-
+
+
+
-
+
-
-
@@ -85,9 +85,6 @@ limitations under the License.
-
-
-
@@ -135,9 +132,6 @@ limitations under the License.
-
-
-
[commons-cli] branch master updated: Bump maven-antrun-plugin from 1.7 to 3.0.0 #43.
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-cli.git The following commit(s) were added to refs/heads/master by this push: new 3ef0b69 Bump maven-antrun-plugin from 1.7 to 3.0.0 #43. 3ef0b69 is described below commit 3ef0b69f94b337e2f7b301130c5aeb073e0545f4 Author: Gary Gregory AuthorDate: Mon Dec 28 10:46:34 2020 -0500 Bump maven-antrun-plugin from 1.7 to 3.0.0 #43. --- src/changes/changes.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 5a25ed4..19aa92f 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -71,6 +71,9 @@ Minor Improvements #57. + +Bump maven-antrun-plugin from 1.7 to 3.0.0 #43. +
[commons-cli] branch master updated (081e37b -> 9faafe0)
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-cli.git. from 081e37b Minor Improvements #57. add 9faafe0 Bump maven-antrun-plugin from 1.7 to 3.0.0 (#43) No new revisions were added by this update. Summary of changes: pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[commons-cli] branch master updated: Minor Improvements #57.
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-cli.git The following commit(s) were added to refs/heads/master by this push: new 081e37b Minor Improvements #57. 081e37b is described below commit 081e37b50894dac96e2f5a5376cd6d974f5b8970 Author: Gary Gregory AuthorDate: Mon Dec 28 10:45:13 2020 -0500 Minor Improvements #57. --- src/changes/changes.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 8457ee3..5a25ed4 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -68,6 +68,9 @@ Option Javadocs grammar nits #55. + +Minor Improvements #57. +
[commons-cli] branch master updated: Minor Improvements: (#57)
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-cli.git The following commit(s) were added to refs/heads/master by this push: new c672752 Minor Improvements: (#57) c672752 is described below commit c67275279176504a6f5fc556cfa247e1df02a580 Author: Arturo Bernal AuthorDate: Mon Dec 28 16:44:02 2020 +0100 Minor Improvements: (#57) * Unused import * Add final * License header should be a plain comment --- .../commons/cli/AlreadySelectedException.java | 30 ++-- .../commons/cli/AmbiguousOptionException.java | 30 ++-- .../java/org/apache/commons/cli/BasicParser.java | 30 ++-- .../java/org/apache/commons/cli/CommandLine.java | 30 ++-- .../org/apache/commons/cli/CommandLineParser.java | 30 ++-- .../java/org/apache/commons/cli/DefaultParser.java | 30 ++-- .../java/org/apache/commons/cli/GnuParser.java | 30 ++-- .../java/org/apache/commons/cli/HelpFormatter.java | 30 ++-- .../commons/cli/MissingArgumentException.java | 30 ++-- .../apache/commons/cli/MissingOptionException.java | 30 ++-- src/main/java/org/apache/commons/cli/Option.java | 30 ++-- .../java/org/apache/commons/cli/OptionBuilder.java | 30 ++-- .../java/org/apache/commons/cli/OptionGroup.java | 30 ++-- .../org/apache/commons/cli/OptionValidator.java| 30 ++-- src/main/java/org/apache/commons/cli/Options.java | 30 ++-- .../org/apache/commons/cli/ParseException.java | 30 ++-- src/main/java/org/apache/commons/cli/Parser.java | 30 ++-- .../apache/commons/cli/PatternOptionBuilder.java | 30 ++-- .../java/org/apache/commons/cli/PosixParser.java | 30 ++-- .../java/org/apache/commons/cli/TypeHandler.java | 32 +++--- .../commons/cli/UnrecognizedOptionException.java | 30 ++-- src/main/java/org/apache/commons/cli/Util.java | 30 ++-- .../org/apache/commons/cli/ApplicationTest.java| 30 ++-- .../apache/commons/cli/ArgumentIsOptionTest.java | 30 ++-- .../org/apache/commons/cli/BasicParserTest.java| 30 ++-- .../org/apache/commons/cli/CommandLineTest.java| 30 ++-- .../org/apache/commons/cli/DefaultParserTest.java | 30 ++-- .../commons/cli/DisablePartialMatchingTest.java| 31 ++--- .../java/org/apache/commons/cli/GnuParserTest.java | 30 ++-- .../org/apache/commons/cli/HelpFormatterTest.java | 30 ++-- .../org/apache/commons/cli/OptionBuilderTest.java | 30 ++-- .../org/apache/commons/cli/OptionGroupTest.java| 30 ++-- .../java/org/apache/commons/cli/OptionsTest.java | 30 ++-- .../org/apache/commons/cli/ParserTestCase.java | 30 ++-- .../commons/cli/PatternOptionBuilderTest.java | 30 ++-- .../org/apache/commons/cli/PosixParserTest.java| 30 ++-- .../org/apache/commons/cli/TypeHandlerTest.java| 30 ++-- src/test/java/org/apache/commons/cli/UtilTest.java | 30 ++-- .../java/org/apache/commons/cli/ValueTest.java | 30 ++-- .../java/org/apache/commons/cli/ValuesTest.java| 30 ++-- .../org/apache/commons/cli/bug/BugCLI133Test.java | 30 ++-- .../org/apache/commons/cli/bug/BugCLI148Test.java | 30 ++-- .../org/apache/commons/cli/bug/BugCLI162Test.java | 2 +- .../org/apache/commons/cli/bug/BugCLI18Test.java | 30 ++-- 44 files changed, 647 insertions(+), 648 deletions(-) diff --git a/src/main/java/org/apache/commons/cli/AlreadySelectedException.java b/src/main/java/org/apache/commons/cli/AlreadySelectedException.java index 2959d43..28548ae 100644 --- a/src/main/java/org/apache/commons/cli/AlreadySelectedException.java +++ b/src/main/java/org/apache/commons/cli/AlreadySelectedException.java @@ -1,18 +1,18 @@ -/** - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS"
[commons-crypto] branch master updated: Bump jna from 5.5.0 to 5.6.0 #123.
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-crypto.git The following commit(s) were added to refs/heads/master by this push: new 52d2baf Bump jna from 5.5.0 to 5.6.0 #123. 52d2baf is described below commit 52d2baf470df71dba9b6fc46fd7b52e900665061 Author: Gary Gregory AuthorDate: Mon Dec 28 10:41:20 2020 -0500 Bump jna from 5.5.0 to 5.6.0 #123. --- src/changes/changes.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 6060f6f..bf60f94 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -62,10 +62,11 @@ - Update commons.jacoco.version 0.8.5 to 0.8.6 (Fixes Java 15 builds). + Update commons.jacoco.version 0.8.5 to 0.8.6 (Fixes Java 15 builds). License header should be plain a comment #113. Minor improvement #115, #125. Migrate to Junit 5 #114. + Bump jna from 5.5.0 to 5.6.0 #123. Support Galois/Counter Mode (GCM).
[commons-crypto] branch master updated (5c04600 -> 8c4be70)
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-crypto.git. from 5c04600 More minor improvements #125. add 1192d37 Bump jna from 5.5.0 to 5.6.0 add 8c4be70 Merge pull request #123 from apache/dependabot/maven/net.java.dev.jna-jna-5.6.0 No new revisions were added by this update. Summary of changes: pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[commons-collections] branch master updated: Fix typo erroring -> erring #202.
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-collections.git The following commit(s) were added to refs/heads/master by this push: new 6722481 Fix typo erroring -> erring #202. 6722481 is described below commit 67224814f6f62db72cf20473d4d3f4b55abfa6f5 Author: Gary Gregory AuthorDate: Mon Dec 28 10:33:49 2020 -0500 Fix typo erroring -> erring #202. --- src/changes/changes.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index fc23e73..3b5840f 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -229,6 +229,9 @@ Minor Improvements #203. + + Fix typo erroring -> erring #202. +
[commons-collections] branch master updated: fix typo erroring -> erring (#202)
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-collections.git The following commit(s) were added to refs/heads/master by this push: new 8f1983c fix typo erroring -> erring (#202) 8f1983c is described below commit 8f1983c9829945567be711b6d6cfd28d47d52a14 Author: 石头 <1027926...@qq.com> AuthorDate: Mon Dec 28 23:32:41 2020 +0800 fix typo erroring -> erring (#202) --- src/main/java/org/apache/commons/collections4/list/package-info.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/apache/commons/collections4/list/package-info.java b/src/main/java/org/apache/commons/collections4/list/package-info.java index 91c0121..fc59a5c 100644 --- a/src/main/java/org/apache/commons/collections4/list/package-info.java +++ b/src/main/java/org/apache/commons/collections4/list/package-info.java @@ -31,7 +31,7 @@ * Transformed - transforms each element added * FixedSize - ensures that the size of the list cannot change * Lazy - creates objects in the list on demand - * Growth - grows the list instead of erroring when set/add used with index beyond the list size + * Growth - grows the list instead of erring when set/add used with index beyond the list size * SetUnique - a list that avoids duplicate entries like a Set * *
[commons-collections] branch master updated: Minor Improvements #203.
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-collections.git The following commit(s) were added to refs/heads/master by this push: new 5a0b581 Minor Improvements #203. 5a0b581 is described below commit 5a0b58139db4a403aef14c61ecce25feddcfe3c4 Author: Gary Gregory AuthorDate: Mon Dec 28 10:31:11 2020 -0500 Minor Improvements #203. --- src/changes/changes.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 4f487dc..fc23e73 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -226,6 +226,9 @@ Fix flaky CollectionUtilsTest.getFromMap() #200. + + Minor Improvements #203. +
[commons-collections] branch master updated: Minor Improvement: (#203)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git
The following commit(s) were added to refs/heads/master by this push:
new 2e492e9 Minor Improvement: (#203)
2e492e9 is described below
commit 2e492e94a56f2548bd57c49461c5aa525c500fdc
Author: Arturo Bernal
AuthorDate: Mon Dec 28 16:29:07 2020 +0100
Minor Improvement: (#203)
* Add final
* Unnecessary semicolon ';'
---
.../org/apache/commons/collections4/SplitMapUtils.java | 2 +-
.../apache/commons/collections4/bidimap/TreeBidiMap.java | 4 ++--
.../collections4/bloomfilter/AbstractBloomFilter.java| 4 ++--
.../bloomfilter/hasher/function/MD5Cyclic.java | 2 +-
.../collections4/comparators/FixedOrderComparator.java | 2 +-
.../apache/commons/collections4/map/DefaultedMap.java| 2 +-
.../java/org/apache/commons/collections4/map/LRUMap.java | 2 +-
.../commons/collections4/trie/AbstractPatriciaTrie.java | 2 +-
.../java/org/apache/commons/collections4/BulkTest.java | 2 +-
.../apache/commons/collections4/CollectionUtilsTest.java | 2 +-
.../apache/commons/collections4/FluentIterableTest.java | 2 +-
.../apache/commons/collections4/IterableUtilsTest.java | 4 ++--
.../org/apache/commons/collections4/ListUtilsTest.java | 2 +-
.../collections4/junit/AbstractAvailableLocalesTest.java | 2 +-
.../apache/commons/collections4/list/GrowthListTest.java | 4 ++--
.../apache/commons/collections4/map/Flat3MapTest.java| 16
.../multimap/ArrayListValuedHashMapTest.java | 4 ++--
.../collections4/multimap/HashSetValuedHashMapTest.java | 8
.../collections4/set/AbstractNavigableSetTest.java | 8
.../commons/collections4/set/AbstractSortedSetTest.java | 6 +++---
20 files changed, 40 insertions(+), 40 deletions(-)
diff --git a/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
b/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
index 2a1a9e9..899306d 100644
--- a/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
+++ b/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
@@ -127,7 +127,7 @@ public class SplitMapUtils {
@Override
public MapIterator mapIterator() {
-MapIterator it;
+final MapIterator it;
if (get instanceof IterableGet) {
it = ((IterableGet) get).mapIterator();
} else {
diff --git
a/src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java
b/src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java
index 511aab0..d363789 100644
--- a/src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java
+++ b/src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java
@@ -623,7 +623,7 @@ public class TreeBidiMap, V extends
Comparable>
* @return the specified node
*/
private Node nextGreater(final Node node, final DataElement
dataElement) {
-Node rval;
+final Node rval;
if (node == null) {
rval = null;
} else if (node.getRight(dataElement) != null) {
@@ -658,7 +658,7 @@ public class TreeBidiMap, V extends
Comparable>
* @return the specified node
*/
private Node nextSmaller(final Node node, final DataElement
dataElement) {
-Node rval;
+final Node rval;
if (node == null) {
rval = null;
} else if (node.getLeft(dataElement) != null) {
diff --git
a/src/main/java/org/apache/commons/collections4/bloomfilter/AbstractBloomFilter.java
b/src/main/java/org/apache/commons/collections4/bloomfilter/AbstractBloomFilter.java
index 85d66b6..18e1fee 100644
---
a/src/main/java/org/apache/commons/collections4/bloomfilter/AbstractBloomFilter.java
+++
b/src/main/java/org/apache/commons/collections4/bloomfilter/AbstractBloomFilter.java
@@ -179,8 +179,8 @@ public abstract class AbstractBloomFilter implements
BloomFilter {
verifyShape(other);
final long[] mine = getBits();
final long[] theirs = other.getBits();
-long[] small;
-long[] big;
+final long[] small;
+final long[] big;
if (mine.length > theirs.length) {
big = mine;
small = theirs;
diff --git
a/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/function/MD5Cyclic.java
b/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/function/MD5Cyclic.java
index 7bf4e86..8e07793 100644
---
a/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/function/MD5Cyclic.java
+++
b/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/function/MD5Cyclic.java
@@ -69,7 +69,7 @@ public final class MD5Cyclic implements HashFunction {
public long apply(final byte[] buffer, final int seed) {
if (seed == 0) {
-
[commons-cli] branch master updated: Let GitHub build reuse the Maven default goal.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-cli.git
The following commit(s) were added to refs/heads/master by this push:
new d687ec9 Let GitHub build reuse the Maven default goal.
d687ec9 is described below
commit d687ec917e84dea7591a01546d4c52611597c3ce
Author: Gary Gregory
AuthorDate: Mon Dec 28 10:26:26 2020 -0500
Let GitHub build reuse the Maven default goal.
---
.github/workflows/maven.yml | 2 +-
pom.xml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index f513316..c0d6005 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -43,4 +43,4 @@ jobs:
with:
java-version: ${{ matrix.java }}
- name: Build with Maven
- run: mvn -V apache-rat:check package --file pom.xml
--no-transfer-progress
+ run: mvn -V --file pom.xml --no-transfer-progress
diff --git a/pom.xml b/pom.xml
index 52fdb83..8ab286d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -194,7 +194,7 @@
-clean verify apache-rat:check clirr:check checkstyle:check
findbugs:check javadoc:javadoc
+clean package apache-rat:check clirr:check checkstyle:check
findbugs:check javadoc:javadoc
maven-assembly-plugin
[commons-crypto] branch master updated: More minor improvements #125.
This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-crypto.git The following commit(s) were added to refs/heads/master by this push: new 5c04600 More minor improvements #125. 5c04600 is described below commit 5c04600aa078a32c0412289e9f5f4bd1350aad71 Author: Gary Gregory AuthorDate: Mon Dec 28 10:15:44 2020 -0500 More minor improvements #125. --- src/changes/changes.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 0a2d732..6060f6f 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -64,7 +64,7 @@ Update commons.jacoco.version 0.8.5 to 0.8.6 (Fixes Java 15 builds). License header should be plain a comment #113. - Minor improvement #115. + Minor improvement #115, #125. Migrate to Junit 5 #114.
[commons-crypto] branch master updated: More minor improvement:
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-crypto.git
The following commit(s) were added to refs/heads/master by this push:
new 3d9116a More minor improvement:
new 661d2a2 Merge pull request #125 from
arturobernalg/feature/minor_improvement
3d9116a is described below
commit 3d9116aa5956d3962d1ae877eba5eb9c26aeb928
Author: Arturo Bernal
AuthorDate: Mon Dec 28 10:02:45 2020 +0100
More minor improvement:
* Add final
---
.../commons/crypto/cipher/OpenSslCommonMode.java | 2 +-
.../crypto/cipher/OpenSslGaloisCounterMode.java| 10 +-
.../commons/crypto/jna/OpenSslJnaCipher.java | 2 +-
.../crypto/stream/PositionedCryptoInputStream.java | 2 +-
.../commons/crypto/utils/ReflectionUtils.java | 4 ++--
.../apache/commons/crypto/AbstractBenchmark.java | 22 +++---
.../commons/crypto/cipher/GcmCipherTest.java | 8
.../commons/crypto/cipher/OpenSslCipherTest.java | 2 +-
.../crypto/random/CryptoRandomFactoryTest.java | 6 +++---
.../commons/crypto/random/OsCryptoRandomTest.java | 2 +-
.../crypto/stream/AbstractCipherStreamTest.java| 2 +-
.../commons/crypto/stream/CtrCryptoStreamTest.java | 2 +-
12 files changed, 32 insertions(+), 32 deletions(-)
diff --git
a/src/main/java/org/apache/commons/crypto/cipher/OpenSslCommonMode.java
b/src/main/java/org/apache/commons/crypto/cipher/OpenSslCommonMode.java
index 61a01de..6ca17bb 100644
--- a/src/main/java/org/apache/commons/crypto/cipher/OpenSslCommonMode.java
+++ b/src/main/java/org/apache/commons/crypto/cipher/OpenSslCommonMode.java
@@ -41,7 +41,7 @@ class OpenSslCommonMode extends OpenSslFeedbackCipher {
public void init(final int mode, final byte[] key, final
AlgorithmParameterSpec params)
throws InvalidAlgorithmParameterException {
this.cipherMode = mode;
-byte[] iv;
+final byte[] iv;
if (params instanceof IvParameterSpec) {
iv = ((IvParameterSpec) params).getIV();
} else {
diff --git
a/src/main/java/org/apache/commons/crypto/cipher/OpenSslGaloisCounterMode.java
b/src/main/java/org/apache/commons/crypto/cipher/OpenSslGaloisCounterMode.java
index 52a236a..5129a29 100644
---
a/src/main/java/org/apache/commons/crypto/cipher/OpenSslGaloisCounterMode.java
+++
b/src/main/java/org/apache/commons/crypto/cipher/OpenSslGaloisCounterMode.java
@@ -62,7 +62,7 @@ class OpenSslGaloisCounterMode extends OpenSslFeedbackCipher {
}
this.cipherMode = mode;
-byte[] iv;
+final byte[] iv;
if (params instanceof GCMParameterSpec) {
final GCMParameterSpec gcmParam = (GCMParameterSpec) params;
iv = gcmParam.getIV();
@@ -85,7 +85,7 @@ class OpenSslGaloisCounterMode extends OpenSslFeedbackCipher {
processAAD();
-int len;
+final int len;
if (this.cipherMode == OpenSsl.DECRYPT_MODE) {
// store internally until doFinal(decrypt) is called because
// spec mentioned that only return recovered data after tag
@@ -137,7 +137,7 @@ class OpenSslGaloisCounterMode extends
OpenSslFeedbackCipher {
// and the retrieve the trailing tag from input
int inputOffsetFinal = inputOffset;
int inputLenFinal = inputLen;
-byte[] inputFinal;
+final byte[] inputFinal;
if (inBuffer != null && inBuffer.size() > 0) {
inBuffer.write(input, inputOffset, inputLen);
inputFinal = inBuffer.toByteArray();
@@ -171,7 +171,7 @@ class OpenSslGaloisCounterMode extends
OpenSslFeedbackCipher {
// Keep the similar behavior as JCE, append the tag to end of output
if (this.cipherMode == OpenSsl.ENCRYPT_MODE) {
-ByteBuffer tag;
+final ByteBuffer tag;
tag = ByteBuffer.allocate(getTagLen());
evpCipherCtxCtrl(context,
OpenSslEvpCtrlValues.AEAD_GET_TAG.getValue(), getTagLen(), tag);
tag.get(output, outputLength - getTagLen(), getTagLen());
@@ -251,7 +251,7 @@ class OpenSslGaloisCounterMode extends
OpenSslFeedbackCipher {
// Keep the similar behavior as JCE, append the tag to end of output
if (this.cipherMode == OpenSsl.ENCRYPT_MODE) {
-ByteBuffer tag;
+final ByteBuffer tag;
tag = ByteBuffer.allocate(getTagLen());
evpCipherCtxCtrl(context,
OpenSslEvpCtrlValues.AEAD_GET_TAG.getValue(), getTagLen(), tag);
output.put(tag);
diff --git a/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java
b/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java
index 90f1a5c..6cddba5 100644
--- a/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java
+++
[commons-ognl] 01/01: Merge pull request #26 from apache/dependabot/maven/com.h2database-h2-1.4.200
This is an automated email from the ASF dual-hosted git repository. lukaszlenart pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-ognl.git commit 27a7dd63e998552a95701e30bc286e58159b58ac Merge: ca2e298 70d91aa Author: Lukasz Lenart AuthorDate: Mon Dec 28 09:19:40 2020 +0100 Merge pull request #26 from apache/dependabot/maven/com.h2database-h2-1.4.200 Bump h2 from 1.3.158 to 1.4.200 pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[commons-ognl] branch master updated (ca2e298 -> 27a7dd6)
This is an automated email from the ASF dual-hosted git repository. lukaszlenart pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-ognl.git. from ca2e298 Merge pull request #25 from apache/dependabot/maven/org.apache.maven.plugins-maven-checkstyle-plugin-3.1.1 add 70d91aa Bump h2 from 1.3.158 to 1.4.200 new 27a7dd6 Merge pull request #26 from apache/dependabot/maven/com.h2database-h2-1.4.200 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[commons-ognl] branch master updated (f3fdb72 -> ca2e298)
This is an automated email from the ASF dual-hosted git repository. lukaszlenart pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-ognl.git. from f3fdb72 Merge pull request #24 from apache/dependabot/maven/org.apache.maven.plugins-maven-pmd-plugin-3.14.0 add 4913d4d Bump maven-checkstyle-plugin from 2.7 to 3.1.1 add ca2e298 Merge pull request #25 from apache/dependabot/maven/org.apache.maven.plugins-maven-checkstyle-plugin-3.1.1 No new revisions were added by this update. Summary of changes: pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[commons-ognl] branch master updated (3f53245 -> f3fdb72)
This is an automated email from the ASF dual-hosted git repository. lukaszlenart pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-ognl.git. from 3f53245 Merge pull request #23 from apache/dependabot/maven/org.apache.maven.plugins-maven-jar-plugin-3.2.0 add 8e9fa0a Bump maven-pmd-plugin from 2.3 to 3.14.0 add f3fdb72 Merge pull request #24 from apache/dependabot/maven/org.apache.maven.plugins-maven-pmd-plugin-3.14.0 No new revisions were added by this update. Summary of changes: pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[commons-ognl] branch master updated (a6e9cbe -> 3f53245)
This is an automated email from the ASF dual-hosted git repository. lukaszlenart pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-ognl.git. from a6e9cbe Merge pull request #22 from apache/dependabot/maven/com.carrotsearch-junit-benchmarks-jdk15-0.7.2 add 136c674 Bump maven-jar-plugin from 3.1.0 to 3.2.0 add 3f53245 Merge pull request #23 from apache/dependabot/maven/org.apache.maven.plugins-maven-jar-plugin-3.2.0 No new revisions were added by this update. Summary of changes: pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[commons-ognl] branch master updated (1fde2af -> a6e9cbe)
This is an automated email from the ASF dual-hosted git repository. lukaszlenart pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-ognl.git. from 1fde2af Removes misleading a reference to JIRA ticket add 756952a Bump junit-benchmarks from 0.3.0 to 0.7.2 add a6e9cbe Merge pull request #22 from apache/dependabot/maven/com.carrotsearch-junit-benchmarks-jdk15-0.7.2 No new revisions were added by this update. Summary of changes: pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[commons-ognl] branch dependabot/maven/com.h2database-h2-1.4.200 created (now 70d91aa)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.h2database-h2-1.4.200 in repository https://gitbox.apache.org/repos/asf/commons-ognl.git. at 70d91aa Bump h2 from 1.3.158 to 1.4.200 No new revisions were added by this update.
[commons-ognl] branch dependabot/maven/org.apache.maven.plugins-maven-checkstyle-plugin-3.1.1 created (now 4913d4d)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.maven.plugins-maven-checkstyle-plugin-3.1.1 in repository https://gitbox.apache.org/repos/asf/commons-ognl.git. at 4913d4d Bump maven-checkstyle-plugin from 2.7 to 3.1.1 No new revisions were added by this update.
[commons-ognl] branch dependabot/maven/org.apache.maven.plugins-maven-pmd-plugin-3.14.0 created (now 8e9fa0a)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.maven.plugins-maven-pmd-plugin-3.14.0 in repository https://gitbox.apache.org/repos/asf/commons-ognl.git. at 8e9fa0a Bump maven-pmd-plugin from 2.3 to 3.14.0 No new revisions were added by this update.
[commons-ognl] branch dependabot/maven/org.apache.maven.plugins-maven-jar-plugin-3.2.0 created (now 136c674)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.maven.plugins-maven-jar-plugin-3.2.0 in repository https://gitbox.apache.org/repos/asf/commons-ognl.git. at 136c674 Bump maven-jar-plugin from 3.1.0 to 3.2.0 No new revisions were added by this update.
[commons-ognl] branch dependabot/maven/com.carrotsearch-junit-benchmarks-jdk15-0.7.2 created (now 756952a)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.carrotsearch-junit-benchmarks-jdk15-0.7.2 in repository https://gitbox.apache.org/repos/asf/commons-ognl.git. at 756952a Bump junit-benchmarks from 0.3.0 to 0.7.2 No new revisions were added by this update.
