No need for an ivar here. Project: http://git-wip-us.apache.org/repos/asf/commons-dbcp/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-dbcp/commit/f433a996 Tree: http://git-wip-us.apache.org/repos/asf/commons-dbcp/tree/f433a996 Diff: http://git-wip-us.apache.org/repos/asf/commons-dbcp/diff/f433a996
Branch: refs/heads/release Commit: f433a99608baf7ce378478ad212754e9a386d5b5 Parents: 0a928ca Author: Gary Gregory <garydgreg...@gmail.com> Authored: Mon Jun 11 17:45:26 2018 -0600 Committer: Gary Gregory <garydgreg...@gmail.com> Committed: Mon Jun 11 17:45:26 2018 -0600 ---------------------------------------------------------------------- .../java/org/apache/commons/dbcp2/managed/ManagedDataSource.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/f433a996/src/main/java/org/apache/commons/dbcp2/managed/ManagedDataSource.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/dbcp2/managed/ManagedDataSource.java b/src/main/java/org/apache/commons/dbcp2/managed/ManagedDataSource.java index a73db72..5e3b784 100644 --- a/src/main/java/org/apache/commons/dbcp2/managed/ManagedDataSource.java +++ b/src/main/java/org/apache/commons/dbcp2/managed/ManagedDataSource.java @@ -77,8 +77,6 @@ public class ManagedDataSource<C extends Connection> extends PoolingDataSource<C throw new IllegalStateException("TransactionRegistry has not been set"); } - final Connection connection = new ManagedConnection<>(getPool(), transactionRegistry, - isAccessToUnderlyingConnectionAllowed()); - return connection; + return new ManagedConnection<>(getPool(), transactionRegistry, isAccessToUnderlyingConnectionAllowed()); } }
