[GitHub] jcall92 commented on issue #210: CB-12367: Modernize styling of iOS InAppBrowser view

[GitBox]

jcall92 commented on issue #210: CB-12367: Modernize styling of iOS 
InAppBrowser view
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/210#issuecomment-345140375
 
 
   Hi, can we get this pushed into production? Not being able to change the 
link color is a major pain point.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-android] 01/01: Merge pull request #417 from DavidStrausz/master

[bowserj]

This is an automated email from the ASF dual-hosted git repository.

bowserj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git

commit 64047801867946fb000ed1b52d9182da5d42abbc
Merge: 3760616 5d99e50
Author: Joe Bowser 
AuthorDate: Thu Nov 16 10:13:50 2017 -0800

Merge pull request #417 from DavidStrausz/master

CB-13580: (android) fix build for multiple apks (different product flavors)

 bin/templates/cordova/lib/builders/GenericBuilder.js | 19 +--
 bin/templates/project/build.gradle   |  2 ++
 2 files changed, 19 insertions(+), 2 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
"commits@cordova.apache.org" .

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-android] branch master updated (3760616 -> 6404780)

[bowserj]

This is an automated email from the ASF dual-hosted git repository.

bowserj pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git.


from 3760616  Merge pull request #416 from infil00p/bintray_fix
 add aaeb630  CB-13580: fix build for multiple apks (different product 
flavors)
 add 5d99e50  CB-13580: (android) fix lint errors
 new 6404780  Merge pull request #417 from DavidStrausz/master

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 bin/templates/cordova/lib/builders/GenericBuilder.js | 19 +--
 bin/templates/project/build.gradle   |  2 ++
 2 files changed, 19 insertions(+), 2 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
['"commits@cordova.apache.org" '].

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] infil00p closed pull request #417: CB-13580: (android) fix build for multiple apks (different product flavors)

[GitBox]

infil00p closed pull request #417: CB-13580: (android) fix build for multiple 
apks (different product flavors)
URL: https://github.com/apache/cordova-android/pull/417
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bin/templates/cordova/lib/builders/GenericBuilder.js 
b/bin/templates/cordova/lib/builders/GenericBuilder.js
index 770911b7c..6515533af 100644
--- a/bin/templates/cordova/lib/builders/GenericBuilder.js
+++ b/bin/templates/cordova/lib/builders/GenericBuilder.js
@@ -93,6 +93,14 @@ GenericBuilder.prototype.extractRealProjectNameFromManifest 
= function () {
 module.exports = GenericBuilder;
 
 function apkSorter (fileA, fileB) {
+// De-prioritize arch specific builds
+var archSpecificRE = /-x86|-arm/;
+if (archSpecificRE.exec(fileA)) {
+return 1;
+} else if (archSpecificRE.exec(fileB)) {
+return -1;
+}
+
 // De-prioritize unsigned builds
 var unsignedRE = /-unsigned/;
 if (unsignedRE.exec(fileA)) {
@@ -101,7 +109,7 @@ function apkSorter (fileA, fileB) {
 return -1;
 }
 
-var timeDiff = fs.statSync(fileA).mtime - fs.statSync(fileB).mtime;
+var timeDiff = fs.statSync(fileB).mtime - fs.statSync(fileA).mtime;
 return timeDiff === 0 ? fileA.length - fileB.length : timeDiff;
 }
 
@@ -109,7 +117,14 @@ function findOutputApksHelper (dir, build_type, arch) {
 var shellSilent = shell.config.silent;
 shell.config.silent = true;
 
-var ret = shell.ls(path.join(dir, build_type, '*.apk')).filter(function 
(candidate) {
+// list directory recursively
+var ret = shell.ls('-R', dir).map(function (file) {
+// ls does not include base directory
+return path.join(dir, file);
+}).filter(function (file) {
+// find all APKs
+return file.match(/\.apk?$/i);
+}).filter(function (candidate) {
 var apkName = path.basename(candidate);
 // Need to choose between release and debug .apk.
 if (build_type === 'debug') {
diff --git a/bin/templates/project/build.gradle 
b/bin/templates/project/build.gradle
index 76496b7f5..b870dc41b 100644
--- a/bin/templates/project/build.gradle
+++ b/bin/templates/project/build.gradle
@@ -184,6 +184,8 @@ android {
 buildToolsVersion cdvBuildToolsVersion
 
 if (Boolean.valueOf(cdvBuildMultipleApks)) {
+flavorDimensions "default"
+
 productFlavors {
 armv7 {
 versionCode defaultConfig.versionCode*10 + 2


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] heymartinadams closed pull request #763: See PR #722

[GitBox]

heymartinadams closed pull request #763: See PR #722
URL: https://github.com/apache/cordova-docs/pull/763
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/www/docs/en/dev/guide/platforms/android/index.md 
b/www/docs/en/dev/guide/platforms/android/index.md
index 99688b243..971b7a626 100644
--- a/www/docs/en/dev/guide/platforms/android/index.md
+++ b/www/docs/en/dev/guide/platforms/android/index.md
@@ -317,7 +317,7 @@ To sign an app, you need the following parameters:
 These parameters can be specified using the command line arguments above to
 the [Cordova CLI][cli_reference] `build` or `run` commands.
 
-__Note__: You should use double `--` to indicate that these are 
platform-specific arguments, for example:
+__Note__: You should use double `--` (`--` followed by a space) to indicate 
that these are platform-specific arguments, for example:
 
 `cordova run android --release -- --keystore=../my-release-key.keystore 
--storePassword=password --alias=alias_name --password=password`.
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] heymartinadams closed pull request #764: See PR #722

[GitBox]

heymartinadams closed pull request #764: See PR #722
URL: https://github.com/apache/cordova-docs/pull/764
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/www/docs/en/7.x/guide/platforms/android/index.md 
b/www/docs/en/7.x/guide/platforms/android/index.md
index 0a773ae83..b94006e12 100644
--- a/www/docs/en/7.x/guide/platforms/android/index.md
+++ b/www/docs/en/7.x/guide/platforms/android/index.md
@@ -311,7 +311,7 @@ To sign an app, you need the following parameters:
 These parameters can be specified using the command line arguments above to
 the [Cordova CLI][cli_reference] `build` or `run` commands.
 
-__Note__: You should use double `--` to indicate that these are 
platform-specific arguments, for example:
+__Note__: You should use double `--` (`--` followed by a space) to indicate 
that these are platform-specific arguments, for example:
 
 `cordova run android --release -- --keystore=../my-release-key.keystore 
--storePassword=password --alias=alias_name --password=password`.
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] armandn opened a new pull request #765: Add SparkChess to ShowCase

[GitBox]

armandn opened a new pull request #765: Add SparkChess to ShowCase
URL: https://github.com/apache/cordova-docs/pull/765
 
 
   Added SparkChess to the Showcase. SparkChess is an an app with over 100K 
users available for both iOS and Android, built with Cordova. (it's also 
available online). Thank you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-paramedic] branch improve-readme created (now 918b3ee)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch improve-readme
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git.


  at 918b3ee  Improve README

This branch includes the following new commits:

 new 918b3ee  Improve README

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


-- 
To stop receiving notification emails like this one, please contact
['"commits@cordova.apache.org" '].

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jay-b commented on issue #87: CB-13311: (iOS) Statusbar does not overlay correctly on iPhone X

[GitBox]

jay-b commented on issue #87: CB-13311: (iOS) Statusbar does not overlay 
correctly on iPhone X
URL: 
https://github.com/apache/cordova-plugin-statusbar/pull/87#issuecomment-344926270
 
 
   @jcesarmobile Updating Ionic to `1.3.5` did the trick. It's perfect now, 
many thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile commented on issue #87: CB-13311: (iOS) Statusbar does not overlay correctly on iPhone X

[GitBox]

jcesarmobile commented on issue #87: CB-13311: (iOS) Statusbar does not overlay 
correctly on iPhone X
URL: 
https://github.com/apache/cordova-plugin-statusbar/pull/87#issuecomment-344893663
 
 
   Update cordova-plugin-statusbar to 2.3.0 and ionic to 1.3.5


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #239: CB-13175: fixing windows8.1 crash on startup

[GitBox]

janpio commented on issue #239: CB-13175: fixing windows8.1 crash on startup
URL: https://github.com/apache/cordova-windows/pull/239#issuecomment-344869018
 
 
   > And sadly there still is no new npm package version..
   
   What exactly do you mean by that? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on a change in pull request #722: Update index.md

[GitBox]

janpio commented on a change in pull request #722: Update index.md
URL: https://github.com/apache/cordova-docs/pull/722#discussion_r151362073
 
 

 ##
 File path: www/docs/en/6.x/guide/platforms/android/index.md
 ##
 @@ -310,7 +310,7 @@ To sign an app, you need the following parameters:
 These parameters can be specified using the command line arguments above to
 the [Cordova CLI][cli_reference] `build` or `run` commands.
 
-__Note__: You should use double `--` to indicate that these are 
platform-specific arguments, for example:
+__Note__: You should use double `--` (followed by a space) to indicate that 
these are platform-specific arguments, for example:
 
 Review comment:
   They do, but content is strange now (doesn't really make sense).
   
   Because your original branch/fork is gone, you should create a new branch in 
your current fork, edit all 3 files in that fork (you can do that manually in 
the UI) and then create a Pull Request from that fork. That should then add 
these 3 commits to one Pull Request.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on a change in pull request #722: Update index.md

[GitBox]

janpio commented on a change in pull request #722: Update index.md
URL: https://github.com/apache/cordova-docs/pull/722#discussion_r151362073
 
 

 ##
 File path: www/docs/en/6.x/guide/platforms/android/index.md
 ##
 @@ -310,7 +310,7 @@ To sign an app, you need the following parameters:
 These parameters can be specified using the command line arguments above to
 the [Cordova CLI][cli_reference] `build` or `run` commands.
 
-__Note__: You should use double `--` to indicate that these are 
platform-specific arguments, for example:
+__Note__: You should use double `--` (followed by a space) to indicate that 
these are platform-specific arguments, for example:
 
 Review comment:
   They do, but content is strange now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #760: CB-13543 : updated instructions/documentation around travis build/dep?

[GitBox]

janpio commented on issue #760: CB-13543 : updated instructions/documentation 
around travis build/dep?
URL: https://github.com/apache/cordova-docs/pull/760#issuecomment-344867258
 
 
   @audreyso Last commit 
https://github.com/apache/cordova-docs/pull/760/commits/0c88aee30c7b574a35d26fa0b1fe52fe724dd297
 looks unwanted/broken.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] spacepope commented on issue #239: CB-13175: fixing windows8.1 crash on startup

[GitBox]

spacepope commented on issue #239: CB-13175: fixing windows8.1 crash on startup
URL: https://github.com/apache/cordova-windows/pull/239#issuecomment-344862937
 
 
   ? 
   I also ran into this issue and i can't understand why this is not already 
merged, as the PR fix for splashscreen was merged 6 month ago!
   And sadly there still is no new npm package version..


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-paramedic] branch master updated: Bump Safari version on Sauce

[alsorokin]

This is an automated email from the ASF dual-hosted git repository.

alsorokin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git


The following commit(s) were added to refs/heads/master by this push:
 new aa940aa  Bump Safari version on Sauce
aa940aa is described below

commit aa940aad3ecedf327ef412ee04baa205e2474966
Author: Alexander Sorokin 
AuthorDate: Thu Nov 16 11:24:06 2017 +0300

Bump Safari version on Sauce
---
 conf/periodic/browser-safari.config.json | 2 +-
 conf/pr/browser-safari.config.json   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/conf/periodic/browser-safari.config.json 
b/conf/periodic/browser-safari.config.json
index 1befee7..28f5f67 100644
--- a/conf/periodic/browser-safari.config.json
+++ b/conf/periodic/browser-safari.config.json
@@ -4,5 +4,5 @@
 "cleanUpAfterRun": true,
 "verbose": true,
 "sauceDeviceName": "safari",
-"saucePlatformVersion": "10.0"
+"saucePlatformVersion": "11.0"
 }
diff --git a/conf/pr/browser-safari.config.json 
b/conf/pr/browser-safari.config.json
index 9c90238..e26b2d3 100644
--- a/conf/pr/browser-safari.config.json
+++ b/conf/pr/browser-safari.config.json
@@ -4,5 +4,5 @@
 "cleanUpAfterRun": true,
 "verbose": true,
 "sauceDeviceName": "safari",
-"saucePlatformVersion": "10.0"
+"saucePlatformVersion": "11.0"
 }

-- 
To stop receiving notification emails like this one, please contact
['"commits@cordova.apache.org" '].

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org