[cordova-osx] branch master updated: Test Framework Implementation Improvements (#67)
This is an automated email from the ASF dual-hosted git repository.
erisu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-osx.git
The following commit(s) were added to refs/heads/master by this push:
new dcdea9a Test Framework Implementation Improvements (#67)
dcdea9a is described below
commit dcdea9a58860769066ffe08a465162851d640d47
Author: エリス
AuthorDate: Tue Oct 2 14:24:48 2018 +0900
Test Framework Implementation Improvements (#67)
* Improve Test Framework Implementation & Structure
- Restructure Test Files
- Added NYC Test Coverage
- Udpated .gitignore to Exclude Test Coverage and Vscode
* Refactor Test Code
---
.gitignore |4 +
package-lock.json | 1697 +++
package.json| 18 +-
tests/spec/component.json |8 +
tests/spec/{ => component}/create.spec.js | 42 +-
tests/spec/{ => component}/platform.spec.js | 52 +-
tests/spec/coverage.json|9 +
tests/spec/objc.json|8 +
tests/spec/{ => objc}/cordovalib.spec.js| 28 +-
9 files changed, 1597 insertions(+), 269 deletions(-)
diff --git a/.gitignore b/.gitignore
index e6e7ca5..1dba852 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,5 +1,6 @@
.DS_Store
.*.sw?
+.vscode
*.cso
tmp
*.mode1v3
@@ -8,3 +9,6 @@ xcuserdata
*.xcworkspace
console.log
node_modules
+coverage/
+npm-debug.log
+.nyc_output/
diff --git a/package-lock.json b/package-lock.json
index 61bc0fd..f537113 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,9 +1,118 @@
{
"name": "cordova-osx",
- "version": "4.1.0-dev",
+ "version": "5.0.0-dev",
"lockfileVersion": 1,
"requires": true,
"dependencies": {
+"@babel/code-frame": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-vXHZsZKvl435FYKdOdQJRFZDmgw=",
+ "dev": true,
+ "requires": {
+"@babel/highlight": "7.0.0-beta.51"
+ }
+},
+"@babel/generator": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/generator/-/generator-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-bHV1/952HQdIXgS67cA5LG2eMPY=",
+ "dev": true,
+ "requires": {
+"@babel/types": "7.0.0-beta.51",
+"jsesc": "^2.5.1",
+"lodash": "^4.17.5",
+"source-map": "^0.5.0",
+"trim-right": "^1.0.1"
+ }
+},
+"@babel/helper-function-name": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/helper-function-name/-/helper-function-name-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-IbSHSiJ8+Z7K/MMKkDAtpaJkBWE=",
+ "dev": true,
+ "requires": {
+"@babel/helper-get-function-arity": "7.0.0-beta.51",
+"@babel/template": "7.0.0-beta.51",
+"@babel/types": "7.0.0-beta.51"
+ }
+},
+"@babel/helper-get-function-arity": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/helper-get-function-arity/-/helper-get-function-arity-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-MoGy0EWvlcFyzpGyCCXYXqRnZBE=",
+ "dev": true,
+ "requires": {
+"@babel/types": "7.0.0-beta.51"
+ }
+},
+"@babel/helper-split-export-declaration": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/helper-split-export-declaration/-/helper-split-export-declaration-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-imw/ZsTSZTUvwHdIT59ugKUauXg=",
+ "dev": true,
+ "requires": {
+"@babel/types": "7.0.0-beta.51"
+ }
+},
+"@babel/highlight": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/highlight/-/highlight-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-6IRK4loVlcz9QriWI7Q3bKBtIl0=",
+ "dev": true,
+ "requires": {
+"chalk": "^2.0.0",
+"esutils": "^2.0.2",
+"js-tokens": "^3.0.0"
+ }
+},
+"@babel/parser": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/parser/-/parser-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-J87C30Cd9gr1gnDtj2qlVAnqhvY=",
+ "dev": true
+},
+"@babel/template": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/template/-/template-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-lgKkCuvPNXrpZ34lMu9fyBD1+/8=",
+ "dev": true,
+ "requires": {
+"@babel/code-frame": "7.0.0-beta.51",
+"@babel/parser": "7.0.0-beta.51",
+"@babel/types": "7.0.0-beta.51",
+"lodash": "^4.17.5"
+ }
+},
+"@babel/traverse": {
+ "version": "7.0.0-beta.51",
+ "resolved":
[GitHub] erisu closed pull request #67: Test Framework Implementation Improvements
erisu closed pull request #67: Test Framework Implementation Improvements
URL: https://github.com/apache/cordova-osx/pull/67
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.gitignore b/.gitignore
index e6e7ca59..1dba852f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,5 +1,6 @@
.DS_Store
.*.sw?
+.vscode
*.cso
tmp
*.mode1v3
@@ -8,3 +9,6 @@ xcuserdata
*.xcworkspace
console.log
node_modules
+coverage/
+npm-debug.log
+.nyc_output/
diff --git a/package-lock.json b/package-lock.json
index 61bc0fd6..f5371133 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,9 +1,118 @@
{
"name": "cordova-osx",
- "version": "4.1.0-dev",
+ "version": "5.0.0-dev",
"lockfileVersion": 1,
"requires": true,
"dependencies": {
+"@babel/code-frame": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-vXHZsZKvl435FYKdOdQJRFZDmgw=",
+ "dev": true,
+ "requires": {
+"@babel/highlight": "7.0.0-beta.51"
+ }
+},
+"@babel/generator": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/generator/-/generator-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-bHV1/952HQdIXgS67cA5LG2eMPY=",
+ "dev": true,
+ "requires": {
+"@babel/types": "7.0.0-beta.51",
+"jsesc": "^2.5.1",
+"lodash": "^4.17.5",
+"source-map": "^0.5.0",
+"trim-right": "^1.0.1"
+ }
+},
+"@babel/helper-function-name": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/helper-function-name/-/helper-function-name-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-IbSHSiJ8+Z7K/MMKkDAtpaJkBWE=",
+ "dev": true,
+ "requires": {
+"@babel/helper-get-function-arity": "7.0.0-beta.51",
+"@babel/template": "7.0.0-beta.51",
+"@babel/types": "7.0.0-beta.51"
+ }
+},
+"@babel/helper-get-function-arity": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/helper-get-function-arity/-/helper-get-function-arity-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-MoGy0EWvlcFyzpGyCCXYXqRnZBE=",
+ "dev": true,
+ "requires": {
+"@babel/types": "7.0.0-beta.51"
+ }
+},
+"@babel/helper-split-export-declaration": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/helper-split-export-declaration/-/helper-split-export-declaration-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-imw/ZsTSZTUvwHdIT59ugKUauXg=",
+ "dev": true,
+ "requires": {
+"@babel/types": "7.0.0-beta.51"
+ }
+},
+"@babel/highlight": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/highlight/-/highlight-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-6IRK4loVlcz9QriWI7Q3bKBtIl0=",
+ "dev": true,
+ "requires": {
+"chalk": "^2.0.0",
+"esutils": "^2.0.2",
+"js-tokens": "^3.0.0"
+ }
+},
+"@babel/parser": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/parser/-/parser-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-J87C30Cd9gr1gnDtj2qlVAnqhvY=",
+ "dev": true
+},
+"@babel/template": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/template/-/template-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-lgKkCuvPNXrpZ34lMu9fyBD1+/8=",
+ "dev": true,
+ "requires": {
+"@babel/code-frame": "7.0.0-beta.51",
+"@babel/parser": "7.0.0-beta.51",
+"@babel/types": "7.0.0-beta.51",
+"lodash": "^4.17.5"
+ }
+},
+"@babel/traverse": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/traverse/-/traverse-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-mB2vLOw0emIx06odnhgDsDqqpKg=",
+ "dev": true,
+ "requires": {
+"@babel/code-frame": "7.0.0-beta.51",
+"@babel/generator": "7.0.0-beta.51",
+"@babel/helper-function-name": "7.0.0-beta.51",
+"@babel/helper-split-export-declaration": "7.0.0-beta.51",
+"@babel/parser": "7.0.0-beta.51",
+"@babel/types": "7.0.0-beta.51",
+"debug": "^3.1.0",
+"globals": "^11.1.0",
+"invariant": "^2.2.0",
+"lodash": "^4.17.5"
+ }
+},
+"@babel/types": {
+ "version": "7.0.0-beta.51",
+ "resolved":
"https://registry.npmjs.org/@babel/types/-/types-7.0.0-beta.51.tgz;,
+ "integrity": "sha1-2AK3tUO1g2x3iqaReXq/APPZfqk=",
+ "dev": true,
+ "requires": {
+"esutils": "^2.0.2",
+"lodash": "^4.17.5",
+"to-fast-properties":
[GitHub] premtemp1 opened a new issue #258: Not seeing any files on the android device
premtemp1 opened a new issue #258: Not seeing any files on the android device
URL: https://github.com/apache/cordova-plugin-file/issues/258
Hello,
I trying to read android folder and show the user a list of files but I am
NOT seeing any files that I have uploaded in any folders.
var localURLs = [
cordova.file.applicationDirectory,
cordova.file.applicationStorageDirectory,
cordova.file.cacheDirectory,
cordova.file.dataDirectory,
cordova.file.externalRootDirectory ,
cordova.file.externalApplicationStorageDirectory,
cordova.file.externalCacheDirectory,
cordova.file.externalDataDirectory
];
var index = 0;
var i;
var errorStr = '';
var fileList = [];
var addFileEntry = function (entry) {
var dirReader = entry.createReader();
dirReader.readEntries(
function (entries) {
var i;
for (i = 0; i < entries.length; i++) {
if (entries[i].isDirectory === true) {
// Recursive -- call back into this
subdirectory
addFileEntry(entries[i]);
} else {
var ext = entries[i].name.split('.').pop();
if (ext === 'doc' || ext === 'docx' ||
ext === 'rdf' || ext === 'pdf' || ext
=== 'txt' ||
ext === 'odt') {
fileList.push(entries[i]); // << replace
with something useful
}
index++;
}
}
},
function (error) {
console.log('readEntries error: ' + error.code);
errorStr += 'readEntries error: ' + error.code +
'';
}
);
};
var addError = function (error) {
console.log('getDirectory error: ' + error.code);
errorStr += 'getDirectory error: ' + error.code + ', ' +
error.message + '';
};
for (i = 0; i < localURLs.length; i++) {
if (localURLs[i] === null || localURLs[i].length === 0) {
continue; // skip blank / non-existent paths for this
platform
}
window.resolveLocalFileSystemURL(localURLs[i], addFileEntry,
addError);
}
$scope.fileList = fileList;
$scope.localFileError = errorStr;
Can you please let me know how to fix this issue.
Thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] premtemp1 commented on issue #254: Cordova plugin file does not work
premtemp1 commented on issue #254: Cordova plugin file does not work URL: https://github.com/apache/cordova-plugin-file/issues/254#issuecomment-426105096 I am having same issue. These are folders that I am traversing var localURLs = [ cordova.file.applicationDirectory, cordova.file.applicationStorageDirectory, cordova.file.cacheDirectory, cordova.file.dataDirectory, cordova.file.externalRootDirectory , cordova.file.externalApplicationStorageDirectory, cordova.file.externalCacheDirectory, cordova.file.externalDataDirectory ]; Anyone has a solution. This works in api 22 broke >22 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] Ravenstine commented on issue #114: Not working on Android devices
Ravenstine commented on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-426101408 On my Samsung Galaxy S5, the issue has to do with Wi-Fi scanning being enabled. Turning this feature off immediately allows the geolocation to work. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #198: Updated README for Android file uploads.
janpio commented on issue #198: Updated README for Android file uploads. URL: https://github.com/apache/cordova-plugin-file-transfer/pull/198#issuecomment-426071073 Thanks for following up, was suspecting something like this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] shamilovtim closed pull request #198: Updated README for Android file uploads.
shamilovtim closed pull request #198: Updated README for Android file uploads. URL: https://github.com/apache/cordova-plugin-file-transfer/pull/198 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index b637446..fecb881 100644 --- a/README.md +++ b/README.md @@ -103,7 +103,7 @@ __Parameters__: - __httpMethod__: The HTTP method to use - either `PUT` or `POST`. Defaults to `POST`. (DOMString) - __mimeType__: The mime type of the data to upload. Defaults to `image/jpeg`. (DOMString) - __params__: A set of optional key/value pairs to pass in the HTTP request. (Object, key/value - DOMString) - - __chunkedMode__: Whether to upload the data in chunked streaming mode. Defaults to `true`. (Boolean) + - __chunkedMode__: Whether to upload the data in chunked streaming mode. This must be set to false in order to upload an image on Android. Defaults to `true`. (Boolean) - __headers__: A map of header name/header values. Use a hash to specify one or more than one value. On iOS, FireOS, and Android, if a header named Content-Type is present, multipart form data will NOT be used. (Object) - __trustAllHosts__: Optional parameter, defaults to `false`. If set to `true`, it accepts all security certificates. Not recommended for production use. Supported on iOS. _(boolean)_ @@ -200,6 +200,10 @@ A `FileUploadResult` object is passed to the success callback of the - Does not support uploads of an empty file with __chunkedMode=true__ and `multipartMode=false`. +### Android Quirks + +- Does not support uploads without explicitly specifying __chunkedMode=false__. + ### Browser Quirks - __withCredentials__: _boolean_ that tells the browser to set the withCredentials flag on the XMLHttpRequest This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] shamilovtim commented on issue #198: Updated README for Android file uploads.
shamilovtim commented on issue #198: Updated README for Android file uploads. URL: https://github.com/apache/cordova-plugin-file-transfer/pull/198#issuecomment-426070505 Further research leads me to believe that this is an issue with Flask rather than Android. Closing This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] shamilovtim edited a comment on issue #198: Updated README for Android file uploads.
shamilovtim edited a comment on issue #198: Updated README for Android file uploads. URL: https://github.com/apache/cordova-plugin-file-transfer/pull/198#issuecomment-426068611 @janpio Thanks for your answer. I was trying to send a simple .jpg avatar from an Android application to our Flask REST API. This was succeeding without a clear error but no image resulted on the server. After lots of headache, I discovered it was this variable. At the time I could have explained better. However this link seems to describe the issue: https://stackoverflow.com/questions/12071266/how-do-i-explicitly-disable-chunked-streaming-mode-for-http-connections-in-andro. It seems this is related to POST requests? If the variable is not set, it seems as though the request completed but it did not. And checking the server shows the image was never actually transferred. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] shamilovtim commented on issue #198: Updated README for Android file uploads.
shamilovtim commented on issue #198: Updated README for Android file uploads. URL: https://github.com/apache/cordova-plugin-file-transfer/pull/198#issuecomment-426068611 @janpio Thanks for your answer. I was trying to send a simple .jpg avatar from an Android application to our Flask REST API. This was failing without a clear error. After lots of headache, I discovered it was this variable. At the time I could have explained better. However this link seems to describe the issue: https://stackoverflow.com/questions/12071266/how-do-i-explicitly-disable-chunked-streaming-mode-for-http-connections-in-andro. It seems this is related to POST requests? If the variable is not set, it seems as though the request completed but it did not. And checking the server shows the image was never actually transferred. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #197: CB-12551: (android) Patch Security Provider to support TLS 1.2
janpio commented on issue #197: CB-12551: (android) Patch Security Provider to support TLS 1.2 URL: https://github.com/apache/cordova-plugin-file-transfer/pull/197#issuecomment-426063702 I just submitted a fix to master, if you rebase on that your tests might pass (or at least fail less). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #159: CB-13690 : (browser) Add src change to method to Media object
janpio commented on issue #159: CB-13690 : (browser) Add src change to method to Media object URL: https://github.com/apache/cordova-plugin-media/pull/159#issuecomment-426056733 Tests are now passing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio closed pull request #199: Fix js error "The parameter is incorrect"
janpio closed pull request #199: Fix js error "The parameter is incorrect"
URL: https://github.com/apache/cordova-plugin-file-transfer/pull/199
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/windows/FileTransferProxy.js b/src/windows/FileTransferProxy.js
index 5d1363f..01e6e7b 100644
--- a/src/windows/FileTransferProxy.js
+++ b/src/windows/FileTransferProxy.js
@@ -499,6 +499,10 @@ exec(win, fail, 'FileTransfer', 'upload',
if (!response) {
resolve(new FTErr(FTErr.CONNECTION_ERR,
source, target));
} else {
+if (download.progress.bytesReceived === 0) {
+resolve(new
FTErr(FTErr.FILE_NOT_FOUND_ERR, source, target, response.statusCode, null,
error));
+return;
+}
var reader = new
Windows.Storage.Streams.DataReader(download.getResultStreamAt(0));
reader.loadAsync(download.progress.bytesReceived).then(function (bytesLoaded) {
var payload =
reader.readString(bytesLoaded);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-plugin-file-transfer] branch master updated (2e4539d -> 6c99dfa)
This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-file-transfer.git. from 2e4539d also accept android sdk terms for android-27 add 6c99dfa [windows] Fix js error "The parameter is incorrect" (#199) No new revisions were added by this update. Summary of changes: src/windows/FileTransferProxy.js | 4 1 file changed, 4 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-plugin-file-transfer] branch master updated (b7de6f9 -> 2e4539d)
This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-file-transfer.git. from b7de6f9 CB-13826 Incremented plugin version. add 2e4539d also accept android sdk terms for android-27 No new revisions were added by this update. Summary of changes: .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #198: Updated README for Android file uploads.
janpio commented on issue #198: Updated README for Android file uploads. URL: https://github.com/apache/cordova-plugin-file-transfer/pull/198#issuecomment-426054895 Can you provide some context? Is this true for all upload or just for some configuration? What happens if one doesn't set the option? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #233: bug: filesystemName is undefined
janpio commented on issue #233: bug: filesystemName is undefined URL: https://github.com/apache/cordova-plugin-file/pull/233#issuecomment-426052331 Oh what platform does this problem occur? Can you post the error message you are getting? What is the code needed to reproduce this? (Both for encountering the error first, and later the fixed code?) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-plugin-file] branch master updated: CB-13850: Fix spelling in typed-file: property name filesystem (wrong… (#229)
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-plugin-file.git
The following commit(s) were added to refs/heads/master by this push:
new 4642fde CB-13850: Fix spelling in typed-file: property name
filesystem (wrong… (#229)
4642fde is described below
commit 4642fde47ff24f6a2a38ef5f812cca04e1c23a1a
Author: Beutlin
AuthorDate: Mon Oct 1 22:23:58 2018 +0200
CB-13850: Fix spelling in typed-file: property name filesystem (wrong…
(#229)
### Platforms affected
-
### What does this PR do?
The DefinitelyTyped file has a wrong attribute for an Entry object. It is
"fileSystem" but should be "filesystem". The consequence of this is that the
syntax checker of an IDE might give an false warning.
### What testing has been done on this change?
Looked at file www/Entry.js. Obviously the naming is here "filesystem".
### Checklist
- [ x ] [Reported an
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ x ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- Automated tests are not possible, because this bug is related to a
DefinitelyTyped file, which provides only syntax checking for IDEs.
---
types/index.d.ts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/types/index.d.ts b/types/index.d.ts
index 40f1a82..9353cfe 100644
--- a/types/index.d.ts
+++ b/types/index.d.ts
@@ -63,7 +63,7 @@ interface Entry {
/** The full absolute path from the root to the entry. */
fullPath: string;
/** The file system on which the entry resides. */
-fileSystem: FileSystem;
+filesystem: FileSystem;
nativeURL: string;
/**
* Look up metadata about this entry.
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio closed pull request #229: CB-13850: Fix spelling in typed-file: property name filesystem (wrong…
janpio closed pull request #229: CB-13850: Fix spelling in typed-file: property
name filesystem (wrong…
URL: https://github.com/apache/cordova-plugin-file/pull/229
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/types/index.d.ts b/types/index.d.ts
index c748e3da..ba17a43d 100644
--- a/types/index.d.ts
+++ b/types/index.d.ts
@@ -63,7 +63,7 @@ interface Entry {
/** The full absolute path from the root to the entry. */
fullPath: string;
/** The file system on which the entry resides. */
-fileSystem: FileSystem;
+filesystem: FileSystem;
nativeURL: string;
/**
* Look up metadata about this entry.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-plugin-file] branch master updated: CB-13960: fix FileWriter.write argument type definition for typescript (#231)
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-plugin-file.git
The following commit(s) were added to refs/heads/master by this push:
new 5353b84 CB-13960: fix FileWriter.write argument type definition for
typescript (#231)
5353b84 is described below
commit 5353b847270d55f8caedfc992393137514c59992
Author: vldmr-bus <35266226+vldmr-...@users.noreply.github.com>
AuthorDate: Mon Oct 1 15:23:39 2018 -0500
CB-13960: fix FileWriter.write argument type definition for typescript
(#231)
Fix FileWriter.write argument type definition for typescript
---
types/index.d.ts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/types/index.d.ts b/types/index.d.ts
index c748e3d..40f1a82 100644
--- a/types/index.d.ts
+++ b/types/index.d.ts
@@ -294,9 +294,9 @@ interface FileWriter extends FileSaver {
length: number;
/**
* Write the supplied data to the file at position.
- * @param {Blob} data The blob to write.
+ * @param {Blob|string} data The blob to write.
*/
-write(data: Blob): void;
+write(data: Blob|string): void;
/**
* The file position at which the next write will occur.
* @param offset If nonnegative, an absolute byte offset into the file.
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] anupamgovind1981 opened a new issue #422: App crashes on iOS 12.0
anupamgovind1981 opened a new issue #422: App crashes on iOS 12.0 URL: https://github.com/apache/cordova-ios/issues/422 Description: App start crashes on iPad after upgrade to iOS 12.0. [ERROR] An error occurred while running subprocess cordova. Steps to Reproduce: Upgrade iOS to 12.0 Already install Ionic app launch start crash. Output: [cordova] error: process launch failed: Unspecified [cordova] (lldb) safequit [cordova] [cordova] Application has not been launched [cordova] [cordova] CordovaError: Promise rejected with non-error: 'Error code 1 for command: ios-deploy with args: --justlaunch,--no-wifi,-d,-b,/Users/agovind/Anupam/IonicWorkspace/cueapp/platforms/ios/build/device/MPT.app' [cordova] at cli.catch.err (/usr/local/lib/node_modules/cordova/bin/cordova:30:15) [cordova] at [cordova] at process._tickCallback (internal/process/next_tick.js:188:7) [ERROR] An error occurred while running subprocess cordova. My ionic info: Ionic: ionic (Ionic CLI) : 4.0.3 (/usr/local/lib/node_modules/ionic) Ionic Framework : ionic-angular 3.9.2 @ionic/app-scripts : 3.1.9 Cordova: cordova (Cordova CLI) : 8.1.1 (cordova-lib@8.1.0) Cordova Platforms : android 7.0.0, browser 5.0.3, ios 4.5.5 System: ios-deploy : 1.9.2 NodeJS : v8.9.4 (/usr/local/bin/node) npm : 5.8.0 OS : macOS High Sierra Xcode : Xcode 10.0 Build version 10A255 Environment: ANDROID_HOME : not set This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio closed pull request #231: CB-13960: fix FileWriter.write argument type definition for typescript
janpio closed pull request #231: CB-13960: fix FileWriter.write argument type
definition for typescript
URL: https://github.com/apache/cordova-plugin-file/pull/231
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/types/index.d.ts b/types/index.d.ts
index c748e3da..40f1a822 100644
--- a/types/index.d.ts
+++ b/types/index.d.ts
@@ -294,9 +294,9 @@ interface FileWriter extends FileSaver {
length: number;
/**
* Write the supplied data to the file at position.
- * @param {Blob} data The blob to write.
+ * @param {Blob|string} data The blob to write.
*/
-write(data: Blob): void;
+write(data: Blob|string): void;
/**
* The file position at which the next write will occur.
* @param offset If nonnegative, an absolute byte offset into the file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #133: Added LaunchImageFileCustom for hybrid app and multiples Launch Images
janpio commented on issue #133: Added LaunchImageFileCustom for hybrid app and multiples Launch Images URL: https://github.com/apache/cordova-plugin-splashscreen/pull/133#issuecomment-426044606 Hey, I just fixed the problem that caused Android tests to fail in master. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #242: CB-11714: (windows) added check for encoding in savePhoto() without height/width
janpio commented on issue #242: CB-11714: (windows) added check for encoding in savePhoto() without height/width URL: https://github.com/apache/cordova-plugin-camera/pull/242#issuecomment-426043765 Thanks @DisruptiveMind. Tests are now failing because of ``` /Users/travis/build/apache/cordova-plugin-camera/src/windows/CameraProxy.js 790:67 error Strings must use singlequote quotes ✖ 1 problem (1 error, 0 warnings) 1 error, 0 warnings potentially fixable with the `--fix` option. ``` This doesn't make too much sense to me, especially as line 790 contains no quotes at all. Can you maybe rebase on `master`? I hope this will go away with more recent test configuration. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio edited a comment on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
janpio edited a comment on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-425728887 Simplest answer: Because the testing setup for plugins is all messed up, see a WIP issue here: https://github.com/apache/cordova/issues/28 I am working my way through these, but it is _very_ slow going. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-paramedic] branch janpio-add_plugin_package.json deleted (was 2b24b0a)
This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-add_plugin_package.json in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git. was 2b24b0a most rudimentary package.json for plugins and plugin tests possible The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-paramedic] branch master updated (5bed039 -> c78d74a)
This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git. from 5bed039 decrease to 9 min to work around 10min command limit on travis: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received add c78d74a Add package.json files to plugins and plugin tests (#34) No new revisions were added by this update. Summary of changes: spec/build-fail-plugin/package.json | 11 +++ spec/build-success-plugin/package.json | 11 +++ spec/sh-read-input-plugin/package.json | 11 +++ spec/testable-plugin/package.json | 14 ++ spec/testable-plugin/tests/package.json | 11 +++ 5 files changed, 58 insertions(+) create mode 100644 spec/build-fail-plugin/package.json create mode 100644 spec/build-success-plugin/package.json create mode 100644 spec/sh-read-input-plugin/package.json create mode 100644 spec/testable-plugin/package.json create mode 100644 spec/testable-plugin/tests/package.json - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] PieterVanPoyer edited a comment on issue #74: CB-12035 (android) Fix bug [cordova-plugin-network-information] connection info is not reliable on Android 6
PieterVanPoyer edited a comment on issue #74: CB-12035 (android) Fix bug [cordova-plugin-network-information] connection info is not reliable on Android 6 URL: https://github.com/apache/cordova-plugin-network-information/pull/74#issuecomment-426035590 I triggered a new build. (I did change some logging for a new commit). The travis build is now successfull! Are there any comments, questions, remarks for this pull request? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] PieterVanPoyer commented on issue #74: CB-12035 (android) Fix bug [cordova-plugin-network-information] connection info is not reliable on Android 6
PieterVanPoyer commented on issue #74: CB-12035 (android) Fix bug [cordova-plugin-network-information] connection info is not reliable on Android 6 URL: https://github.com/apache/cordova-plugin-network-information/pull/74#issuecomment-426035590 I triggered a new build. (I did change some logging for a new commit). Are there any comments, questions, remarks for this pull request? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] PieterVanPoyer removed a comment on issue #74: CB-12035 (android) Fix bug [cordova-plugin-network-information] connection info is not reliable on Android 6
PieterVanPoyer removed a comment on issue #74: CB-12035 (android) Fix bug [cordova-plugin-network-information] connection info is not reliable on Android 6 URL: https://github.com/apache/cordova-plugin-network-information/pull/74#issuecomment-426029809 @janpio Hey janpio, the travis-ci build keeps failing. Can I restart the travis build? I 've seen that https://github.com/apache/cordova-plugin-media-capture/issues/105 is closed now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] PieterVanPoyer commented on issue #74: CB-12035 (android) Fix bug [cordova-plugin-network-information] connection info is not reliable on Android 6
PieterVanPoyer commented on issue #74: CB-12035 (android) Fix bug [cordova-plugin-network-information] connection info is not reliable on Android 6 URL: https://github.com/apache/cordova-plugin-network-information/pull/74#issuecomment-426029809 @janpio Hey janpio, the travis-ci build keeps failing. Can I restart the travis build? I 've seen that https://github.com/apache/cordova-plugin-media-capture/issues/105 is closed now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #286: CB-13307: (Android) Fixed issue when unable to load image with mime t…
janpio commented on issue #286: CB-13307: (Android) Fixed issue when unable to load image with mime t… URL: https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-426024101 Jippieh! I removed some unwanted changes to README that somehow made their way into this via merge/rebase. Now "only" waiting for review and merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] DavidBriglio commented on issue #286: CB-13307: (Android) Fixed issue when unable to load image with mime t…
DavidBriglio commented on issue #286: CB-13307: (Android) Fixed issue when unable to load image with mime t… URL: https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-426020724 @janpio Tests are now passing! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #286: CB-13307: (Android) Fixed issue when unable to load image with mime t…
janpio commented on issue #286: CB-13307: (Android) Fixed issue when unable to load image with mime t… URL: https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-425996898 And another rebase/merge from `master` to get those tests passing @DavidBriglio? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] StevenMapes commented on issue #114: Not working on Android devices
StevenMapes commented on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-425990735 I had the same problem with Phonegap and every version of this plugin since 2.4.3 (tested on a OnePlus5). Though even that version is incredibly unstable when it comes to gathering location data. Sometimes it will work first time, then a minute later you can have it try and retry upon failure (high, then low accuracy with 30 second, 20 second, 15 second, 10 second, 5 second) timeouts and it'll fail all 5 times so a total of 1 minute 20 seconds of trying. It's extremely frustrating as it use to just work This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] charlesverge commented on issue #268: CB-12873: Add customization options for caputre button, resizing of v…
charlesverge commented on issue #268: CB-12873: Add customization options for caputre button, resizing of v… URL: https://github.com/apache/cordova-plugin-camera/pull/268#issuecomment-425989962 @janpio I've rebased the commit, the changes since the last rebase do not affect this code and everything looks good. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio opened a new issue #38: [Plugins] Test current platforms
janpio opened a new issue #38: [Plugins] Test current platforms URL: https://github.com/apache/cordova/issues/38 iOS 11 and 12? Android 7.1 and 8? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] sanjeetnonia opened a new issue #107: captureAudio Does not work on oreo
sanjeetnonia opened a new issue #107: captureAudio Does not work on oreo URL: https://github.com/apache/cordova-plugin-media-capture/issues/107 App crash on oreo device when we give pemission for audio record This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio edited a comment on issue #320: Get applicationId from package name
janpio edited a comment on issue #320: Get applicationId from package name
URL:
https://github.com/apache/cordova-plugin-camera/pull/320#issuecomment-425946523
Well, review first ;)
(Just noticed the merge _is_ a bit messed up as it pulled in all the changes
into your branch individually, but your actual change is simple enough:
```diff
-this.applicationId = (String)
BuildHelper.getBuildConfigValue(cordova.getActivity(), "APPLICATION_ID");
-this.applicationId = preferences.getString("applicationId",
this.applicationId);
+this.applicationId = cordova.getContext().getPackageName();
```
I looked into the history of that code you removed:
Initially added here:
https://github.com/squallstar/cordova-plugin-camera/commit/00e0a7dc469133faf92b46f0d72112d4d873844e#diff-f2e83abdaf34884df7e74b6493cf2dd7L134
The value used later in these 2 locations:
https://github.com/squallstar/cordova-plugin-camera/commit/00e0a7dc469133faf92b46f0d72112d4d873844e#diff-f2e83abdaf34884df7e74b6493cf2dd7R294
https://github.com/squallstar/cordova-plugin-camera/commit/00e0a7dc469133faf92b46f0d72112d4d873844e#diff-f2e83abdaf34884df7e74b6493cf2dd7L794
Then modified here:
https://github.com/squallstar/cordova-plugin-camera/commit/61064ae3ed6c520e6de6646566b83772854d0fea
Correct that this value (plus `.provider` added at the end) is mainly used
for getting a file name?
I don't know anything about Android, is what and where you are getting the
value from identical?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #320: Get applicationId from package name
janpio commented on issue #320: Get applicationId from package name
URL:
https://github.com/apache/cordova-plugin-camera/pull/320#issuecomment-425946523
(Just noticed the merge _is_ a bit messed up as it pulled in all the changes
into your branch individually, but your actual change is simple enough:
```diff
-this.applicationId = (String)
BuildHelper.getBuildConfigValue(cordova.getActivity(), "APPLICATION_ID");
-this.applicationId = preferences.getString("applicationId",
this.applicationId);
+this.applicationId = cordova.getContext().getPackageName();
```
I looked into the history of that code you removed:
Initially added here:
https://github.com/squallstar/cordova-plugin-camera/commit/00e0a7dc469133faf92b46f0d72112d4d873844e#diff-f2e83abdaf34884df7e74b6493cf2dd7L134
The value used later in these 2 locations:
https://github.com/squallstar/cordova-plugin-camera/commit/00e0a7dc469133faf92b46f0d72112d4d873844e#diff-f2e83abdaf34884df7e74b6493cf2dd7R294
https://github.com/squallstar/cordova-plugin-camera/commit/00e0a7dc469133faf92b46f0d72112d4d873844e#diff-f2e83abdaf34884df7e74b6493cf2dd7L794
Then modified here:
https://github.com/squallstar/cordova-plugin-camera/commit/61064ae3ed6c520e6de6646566b83772854d0fea
Correct that this value (plus `.provider` added at the end) is mainly used
for getting a file name? I don't know anything about Android, is what and where
you are getting the value from identical?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425941320 Noticed one more thing in our failing test run on Saucelabs:  For the successful dialogs plugin this is just:  Does this maybe indicate a failure/timeout in that step that stops execution? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425941092 Observation on the Saucelabs "Commands" tab: No red border for "POST element" line:  Then a red border for our failing inappbrowser:  But also a red border for the dialogs plugin:  So this probably just means that it couldn'T find the element (remember: This is looking for an "Allow" button to click). Which is also why `dialogs` doesn't have the ` POST element/1/click ` line that geolocation does. Remains the question: Why does nothing happen here on inAppBrowser? These are the steps that should follow but never do:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425938899 So probably better comparison is `cordova-plugin-dialogs`: https://travis-ci.org/apache/cordova-plugin-dialogs/jobs/435622691 https://saucelabs.com/beta/tests/1473fce577824bf89398aae88369dc1c/watch#10 Tests run, then a few seconds nothing and then the test finishes. No permission prompt. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425937979 Watching the video of the test run at https://saucelabs.com/beta/tests/7e834da3d10d4f08b614d05fcccdfa39/watch#5 confirm that the tests are actually run during the first 35seconds of the video, then just nothing happens any more for the rest of the video. Test successful test run for geolocation also executes the tests right from the beginning, but then gets an actual permission prompt that can be allowed:  https://saucelabs.com/beta/tests/86c40977eac144848f0342e4b7cfb048/watch#7 This happens, and then the test finishes after ~40 seconds. This means, that geolocation is probably not a good comparison. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] squallstar commented on issue #320: Get applicationId from package name
squallstar commented on issue #320: Get applicationId from package name URL: https://github.com/apache/cordova-plugin-camera/pull/320#issuecomment-425938679 Great! Feel free to merge anytime. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425937979 Watching the video of the test run at https://saucelabs.com/beta/tests/7e834da3d10d4f08b614d05fcccdfa39/watch#5 confirm that the tests are actually run during the first 35seconds of the video, then just nothing happens any more for the rest of the video. Test successful test run for geolocation also executes the tests right from the beginning, but then gets an actual permission prompt that can be allowed:  https://saucelabs.com/beta/tests/86c40977eac144848f0342e4b7cfb048/watch#7 This happens, and then the test finishes after ~40 seconds. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] cjpearson commented on issue #88: CB-12479: Add loading spinner for android
cjpearson commented on issue #88: CB-12479: Add loading spinner for android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/88#issuecomment-425937808 @janpio No problem, I had to make another change anyway. The latest commit replaces the deprecated ProgressDialog with a ProgressBar. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] CesarBalzer commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
CesarBalzer commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-425935703 Changing the configuration in xcode to legacy did not work, setting the flag cordova build ios --buildFlag = '- UseModernBuildSystem = 0' did not work and creating the build.json file with the flags also did not work. **I downgrade the Cordova version to 7 and it works normal.** thank you Quentin Valmori This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #88: CB-12479: Add loading spinner for android
janpio commented on issue #88: CB-12479: Add loading spinner for android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/88#issuecomment-425935160 Thanks for the rebase, and sorry I didn't check what repo this PR was in before writing this: `cordova-plugin-inappbrowser` has another test problem. You can follow my progress understanding it here: https://github.com/apache/cordova-plugin-inappbrowser/issues/307 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #136: Add dots spinner loader for android
janpio commented on issue #136: Add dots spinner loader for android URL: https://github.com/apache/cordova-plugin-splashscreen/pull/136#issuecomment-425934760 `rebase` is git command that takes your changes from your branch, which was created in the past and with an old state of code, and moves it to present to the current code. Your changes stay here, but you get all the changes that happened in between. In this case, this would mean the fixes for the tests. Here are 2 tutorials: https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request https://stackoverflow.com/a/46148801/252627 Looks pretty complicated, but is _very_ simple if you understood it (and you don't have any merge conflict - but your change won't). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #320: Get applicationId from package name
janpio commented on issue #320: Get applicationId from package name URL: https://github.com/apache/cordova-plugin-camera/pull/320#issuecomment-425932701 Yes, Travis now happy This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425932393 (Maybe the test is actually already run - and Appium is trying to take care of other stuff) In the successful run for `geolocation`, I noticed that after clicking that button it does somethign with `window_handles`. Turns out, that is actually some code specifically there for inappbrowser: https://github.com/apache/cordova-paramedic/blob/5bed039d6dfbb758a19e066d27a2aa1c1739b2f5/lib/appium/helpers/wdHelper.js#L217-L227 (But as this code is not even run in the failing tests, this of course can not be the reason for the failure.) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425930838 ### Preliminary result This code here hangs: https://github.com/apache/cordova-paramedic/blob/5bed039d6dfbb758a19e066d27a2aa1c1739b2f5/lib/appium/helpers/wdHelper.js#L281-L284 Either it doesn't find the button or is blocked somehow else. Then after the timeout is over, the tests return and fail. (I don't understand why the final screenshot for the failing test after the timeout shows successful Jasmin test run though - makes no sense to me.) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] airstep commented on issue #136: Add dots spinner loader for android
airstep commented on issue #136: Add dots spinner loader for android URL: https://github.com/apache/cordova-plugin-splashscreen/pull/136#issuecomment-425930572 What you mean about rebase? How to do it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are
failing
URL:
https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425929064
Similar situation in the Appium Server log as before in the normal Appium
log: First 281 lines are identical, ending with this:
```
...
2018-10-01 13:26:30:209 - [debug] [MJSONWP] Calling
AppiumDriver.findElement() with args:
["xpath","//android.widget.Button[translate(@text, \"alow\",
\"ALOW\")=\"ALLOW\"]","2e31ca5a-b13c-4abe-af4b-5e94c0b560c1"]
2018-10-01 13:26:30:210 - [debug] [BaseDriver] Valid locator strategies for
this request: xpath, id, class name, accessibility id, -android uiautomator
2018-10-01 13:26:30:211 - [debug] [BaseDriver] Valid locator strategies for
this request: xpath, id, class name, accessibility id, -android uiautomator
2018-10-01 13:26:30:211 - [debug] [BaseDriver] Waiting up to 0 ms for
condition
2018-10-01 13:26:30:215 - [debug] [AndroidBootstrap] Sending command to
android:
{"cmd":"action","action":"find","params":{"strategy":"xpath","selector":"//android.widget.Button[translate(@text,
\"alow\", \"ALOW\")=\"ALLOW\"]","context":"","multiple":false}}
2018-10-01 13:26:30:217 - [AndroidBootstrap] [BOOTSTRAP LOG] [debug] Got
data from client:
{"cmd":"action","action":"find","params":{"strategy":"xpath","selector":"//android.widget.Button[translate(@text,
\"alow\", \"ALOW\")=\"ALLOW\"]","context":"","multiple":false}}
2018-10-01 13:26:30:217 - [AndroidBootstrap] [BOOTSTRAP LOG] [debug] Got
command of type ACTION
2018-10-01 13:26:30:218 - [AndroidBootstrap] [BOOTSTRAP LOG] [debug] Got
command action: find
2018-10-01 13:26:30:218 - [AndroidBootstrap] [BOOTSTRAP LOG] [debug] Finding
'//android.widget.Button[translate(@text, "alow", "ALOW")="ALLOW"]' using
'XPATH' with the contextId: '' multiple: false
```
then our failing run is just this:
```
2018-10-01 13:31:30:186 - [HTTP] <-- POST
/wd/hub/session/2e31ca5a-b13c-4abe-af4b-5e94c0b560c1/element - - ms - -
2018-10-01 13:31:30:326 - [HTTP] --> POST
/wd/hub/session/2e31ca5a-b13c-4abe-af4b-5e94c0b560c1/context
{"name":"WEBVIEW_io.cordova.hellocordova"}
2018-10-01 13:31:30:327 - [debug] [MJSONWP] Calling
AppiumDriver.setContext() with args:
["WEBVIEW_io.cordova.hellocordova","2e31ca5a-b13c-4abe-af4b-5e94c0b560c1"]
```
(note the 5 minutes time difference here - so just _nothing_ happened for 5
minutes)
while the succeeding one continues:
```2018-10-01 13:52:46:540 - [AndroidBootstrap] [BOOTSTRAP LOG] [debug]
Using: UiSelector[CLASS=android.widget.Button, INSTANCE=1]
2018-10-01 13:52:46:542 - [debug] [AndroidBootstrap] Received command result
from bootstrap
2018-10-01 13:52:46:544 - [debug] [MJSONWP] Responding to client with
driver.findElement() result: {"ELEMENT":"1"}
2018-10-01 13:52:46:544 - [HTTP] <-- POST
/wd/hub/session/36a4d6ba-50d0-4135-8adb-5bd90b912d45/element 200 29 ms - 87
2018-10-01 13:52:46:545 - [AndroidBootstrap] [BOOTSTRAP LOG] [debug]
Returning result: {"status":0,"value":{"ELEMENT":"1"}}
2018-10-01 13:52:47:176 - [HTTP] --> POST
/wd/hub/session/36a4d6ba-50d0-4135-8adb-5bd90b912d45/element/1/click {}
2018-10-01 13:52:47:176 - [debug] [MJSONWP] Calling AppiumDriver.click()
with args: ["1","36a4d6ba-50d0-4135-8adb-5bd90b912d45"]
2018-10-01 13:52:47:177 - [debug] [AndroidBootstrap] Sending command to
android: {"cmd":"action","action":"element:click","params":{"elementId":"1"}}
2018-10-01 13:52:47:178 - [AndroidBootstrap] [BOOTSTRAP LOG] [debug] Got
data from client:
{"cmd":"action","action":"element:click","params":{"elementId":"1"}}
2018-10-01 13:52:47:181 - [AndroidBootstrap] [BOOTSTRAP LOG] [debug] Got
command of type ACTION
2018-10-01 13:52:47:181 - [AndroidBootstrap] [BOOTSTRAP LOG] [debug] Got
command action: click
2018-10-01 13:52:50:282 - [debug] [AndroidBootstrap] Received command result
from bootstrap
2018-10-01 13:52:50:284 - [AndroidBootstrap] [BOOTSTRAP LOG] [debug]
Returning result: {"status":0,"value":true}
2018-10-01 13:52:50:284 - [debug] [MJSONWP] Responding to client with
driver.click() result: true
2018-10-01 13:52:50:285 - [HTTP] <-- POST
/wd/hub/session/36a4d6ba-50d0-4135-8adb-5bd90b912d45/element/1/click 200 3109
ms - 76
2018-10-01 13:52:50:841 - [HTTP] --> POST
/wd/hub/session/36a4d6ba-50d0-4135-8adb-5bd90b912d45/context
{"name":"WEBVIEW_io.cordova.hellocordova"}
2018-10-01 13:52:50:842 - [debug] [MJSONWP] Calling
AppiumDriver.setContext() with args:
["WEBVIEW_io.cordova.hellocordova","36a4d6ba-50d0-4135-8adb-5bd90b912d45"]
2018-10-01 13:52:50:842 - [debug] [AndroidDriver] Getting a list of
available webviews
2018-10-01 13:52:50:843 - [debug] [ADB] Getting connected devices...
2018-10-01 13:52:50:852 - [debug] [ADB] 1 device(s) connected
2018-10-01 13:52:50:852 - [debug] [ADB] Running
[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
URL:
https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425929064
Similar situation in the Appium Server log as before in the normal Appium
log: First 281 lines are identical, then our failing run is just this:
```
2018-10-01 13:31:30:186 - [HTTP] <-- POST
/wd/hub/session/2e31ca5a-b13c-4abe-af4b-5e94c0b560c1/element - - ms - -
2018-10-01 13:31:30:326 - [HTTP] --> POST
/wd/hub/session/2e31ca5a-b13c-4abe-af4b-5e94c0b560c1/context
{"name":"WEBVIEW_io.cordova.hellocordova"}
2018-10-01 13:31:30:327 - [debug] [MJSONWP] Calling
AppiumDriver.setContext() with args:
["WEBVIEW_io.cordova.hellocordova","2e31ca5a-b13c-4abe-af4b-5e94c0b560c1"]
```
while the succeeding one continues:
```2018-10-01 13:52:46:540 - [AndroidBootstrap] [BOOTSTRAP LOG] [debug]
Using: UiSelector[CLASS=android.widget.Button, INSTANCE=1]
2018-10-01 13:52:46:542 - [debug] [AndroidBootstrap] Received command result
from bootstrap
2018-10-01 13:52:46:544 - [debug] [MJSONWP] Responding to client with
driver.findElement() result: {"ELEMENT":"1"}
2018-10-01 13:52:46:544 - [HTTP] <-- POST
/wd/hub/session/36a4d6ba-50d0-4135-8adb-5bd90b912d45/element 200 29 ms - 87
2018-10-01 13:52:46:545 - [AndroidBootstrap] [BOOTSTRAP LOG] [debug]
Returning result: {"status":0,"value":{"ELEMENT":"1"}}
2018-10-01 13:52:47:176 - [HTTP] --> POST
/wd/hub/session/36a4d6ba-50d0-4135-8adb-5bd90b912d45/element/1/click {}
2018-10-01 13:52:47:176 - [debug] [MJSONWP] Calling AppiumDriver.click()
with args: ["1","36a4d6ba-50d0-4135-8adb-5bd90b912d45"]
2018-10-01 13:52:47:177 - [debug] [AndroidBootstrap] Sending command to
android: {"cmd":"action","action":"element:click","params":{"elementId":"1"}}
2018-10-01 13:52:47:178 - [AndroidBootstrap] [BOOTSTRAP LOG] [debug] Got
data from client:
{"cmd":"action","action":"element:click","params":{"elementId":"1"}}
2018-10-01 13:52:47:181 - [AndroidBootstrap] [BOOTSTRAP LOG] [debug] Got
command of type ACTION
2018-10-01 13:52:47:181 - [AndroidBootstrap] [BOOTSTRAP LOG] [debug] Got
command action: click
2018-10-01 13:52:50:282 - [debug] [AndroidBootstrap] Received command result
from bootstrap
2018-10-01 13:52:50:284 - [AndroidBootstrap] [BOOTSTRAP LOG] [debug]
Returning result: {"status":0,"value":true}
2018-10-01 13:52:50:284 - [debug] [MJSONWP] Responding to client with
driver.click() result: true
2018-10-01 13:52:50:285 - [HTTP] <-- POST
/wd/hub/session/36a4d6ba-50d0-4135-8adb-5bd90b912d45/element/1/click 200 3109
ms - 76
2018-10-01 13:52:50:841 - [HTTP] --> POST
/wd/hub/session/36a4d6ba-50d0-4135-8adb-5bd90b912d45/context
{"name":"WEBVIEW_io.cordova.hellocordova"}
2018-10-01 13:52:50:842 - [debug] [MJSONWP] Calling
AppiumDriver.setContext() with args:
["WEBVIEW_io.cordova.hellocordova","36a4d6ba-50d0-4135-8adb-5bd90b912d45"]
2018-10-01 13:52:50:842 - [debug] [AndroidDriver] Getting a list of
available webviews
2018-10-01 13:52:50:843 - [debug] [ADB] Getting connected devices...
2018-10-01 13:52:50:852 - [debug] [ADB] 1 device(s) connected
2018-10-01 13:52:50:852 - [debug] [ADB] Running
'/home/chef/android-sdk-linux/platform-tools/adb' with args:
["-P",5037,"-s","emulator-5554","shell","cat","/proc/net/unix"]
2018-10-01 13:52:50:863 - [debug] [AndroidDriver] WEBVIEW_3775 mapped to pid
3775
2018-10-01 13:52:50:864 - [debug] [AndroidDriver] Getting process name for
webview
2018-10-01 13:52:50:864 - [debug] [ADB] Getting connected devices...
2018-10-01 13:52:50:870 - [debug] [ADB] 1 device(s) connected
2018-10-01 13:52:50:870 - [debug] [ADB] Running
'/home/chef/android-sdk-linux/platform-tools/adb' with args:
["-P",5037,"-s","emulator-5554","shell","ps"]
2018-10-01 13:52:50:887 - [debug] [AndroidDriver] Parsed pid: 3775 pkg:
io.cordova.hellocordova!
2018-10-01 13:52:50:887 - [debug] [AndroidDriver] from:
u0_a72,3775,1361,2355300,113052,ep_poll,00,S,io.cordova.hellocordova
2018-10-01 13:52:50:889 - [debug] [AndroidDriver] returning process name:
io.cordova.hellocordova
2018-10-01 13:52:50:889 - [debug] [AndroidDriver] Found webviews:
["WEBVIEW_io.cordova.hellocordova"]
2018-10-01 13:52:50:890 - [debug] [AndroidDriver] Available contexts:
["NATIVE_APP","WEBVIEW_io.cordova.hellocordova"]
2018-10-01 13:52:50:890 - [debug] [AndroidDriver] Connecting to
chrome-backed webview context 'WEBVIEW_io.cordova.hellocordova'
...
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To
[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425926940 Unfortunately the logs for the last succeeding test run in _this_ repo are not archived on Saucelabs any more, so no way to check what was happening back then when it last succeeded. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] sgruhier commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
sgruhier commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-425926385 thanks I did it, I can run a build in xcode but I'm curious how I can use command line like others with --buildFlag :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425926266 Here is the commit that added the "permissions buster" for Android: https://github.com/apache/cordova-paramedic/commit/2e7d8da299d81214af22536baf22f482b38fcc36 And here it was adapted for Android 7: https://github.com/apache/cordova-paramedic/commit/cdb6a23c6b3239e838ca2a5fdfd0669476c222f7 This _does_ work on almost all plugins, just not this one. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
URL:
https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425924693
Turn out the successful test run in `cordova-plugin-geolocation` has the
same line with `alow` in it in line 146 the Appium logs - and all the lines
before it are identical to our failing test run.
There it results in this:
```
{
"screenshot": null,
"between_commands": 0.19422101974487305,
"suggestion_values": [],
"request": {
"using": "xpath",
"value": "//android.widget.Button[translate(@text, \"alow\",
\"ALOW\")=\"ALLOW\"]"
},
"HTTPStatus": 200,
"result": {
"ELEMENT": "1"
},
"suggestion": null,
"duration": 0.032217979431152344,
"path": "element",
"method": "POST",
"statusCode": 0,
"timelineSeconds": 18.396260023117065
},
```
And then the actual testing starts:
```
{
"screenshot": 1,
"between_commands": 0.6282658576965332,
"suggestion_values": [],
"request": {},
"HTTPStatus": 200,
"result": true,
"suggestion": null,
"duration": 3.1124610900878906,
"path": "element/1/click",
"method": "POST",
"statusCode": 0,
"timelineSeconds": 18.62269902229309
},
{
"screenshot": null,
"between_commands": 0.5536580085754395,
"suggestion_values": [],
"request": {
"name": "WEBVIEW_io.cordova.hellocordova"
},
"HTTPStatus": 200,
"result": null,
"suggestion": null,
"duration": 0.10723495483398438,
"path": "context",
"method": "POST",
"statusCode": 0,
"timelineSeconds": 22.363425970077515
},
...
```
So: Why is this failing for inappbrowser?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are
failing
URL:
https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425923522
Last 2 entries from ["Appium
Logs"](https://saucelabs.com/beta/tests/7e834da3d10d4f08b614d05fcccdfa39/logs#6):
```
...
{
"screenshot": null,
"between_commands": 0.21913504600524902,
"suggestion_values": [],
"request": {
"using": "xpath",
"value": "//android.widget.Button[translate(@text, \"alow\",
\"ALOW\")=\"ALLOW\"]"
},
"HTTPStatus": 500,
"result": "ERROR user closed connection while waiting for command to
complete",
"suggestion": null,
"duration": 299.9810121059418,
"path": "element",
"method": "POST",
"timelineSeconds": 20.475893020629883
},
{
"screenshot": 1,
"between_commands": 237.02974104881287,
"suggestion_values": [],
"request": null,
"HTTPStatus": 200,
"result": "",
"suggestion": null,
"duration": 0.00030684471130371094,
"path": "/session/7e834da3d10d4f08b614d05fcccdfa39",
"method": "DELETE",
"statusCode": 0,
"timelineSeconds": 320.6760401725769
}
]
```
I don't really understand what `"//android.widget.Button[translate(@text,
\"alow\", \"ALOW\")=\"ALLOW\"]"` does and where it comes from.
Update: Got it:
https://github.com/apache/cordova-paramedic/blob/31155dfd9287e9c53b034bc00dba4473f7c9bf5c/lib/appium/helpers/wdHelper.js#L282
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
URL:
https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425923522
Last 2 entries from "Appium Logs":
```
...
{
"screenshot": null,
"between_commands": 0.21913504600524902,
"suggestion_values": [],
"request": {
"using": "xpath",
"value": "//android.widget.Button[translate(@text, \"alow\",
\"ALOW\")=\"ALLOW\"]"
},
"HTTPStatus": 500,
"result": "ERROR user closed connection while waiting for command to
complete",
"suggestion": null,
"duration": 299.9810121059418,
"path": "element",
"method": "POST",
"timelineSeconds": 20.475893020629883
},
{
"screenshot": 1,
"between_commands": 237.02974104881287,
"suggestion_values": [],
"request": null,
"HTTPStatus": 200,
"result": "",
"suggestion": null,
"duration": 0.00030684471130371094,
"path": "/session/7e834da3d10d4f08b614d05fcccdfa39",
"method": "DELETE",
"statusCode": 0,
"timelineSeconds": 320.6760401725769
}
]
```
I don't really understand what `"//android.widget.Button[translate(@text,
\"alow\", \"ALOW\")=\"ALLOW\"]"` does and where it comes from.
Update: Got it:
https://github.com/apache/cordova-paramedic/blob/31155dfd9287e9c53b034bc00dba4473f7c9bf5c/lib/appium/helpers/wdHelper.js#L282
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425921890 Compare the failing test here, to a similarly configured one from another plugin: failing here: https://travis-ci.org/apache/cordova-plugin-inappbrowser/jobs/435601803 https://saucelabs.com/beta/tests/7e834da3d10d4f08b614d05fcccdfa39/metadata#6 succeeding over there: https://travis-ci.org/apache/cordova-plugin-geolocation/jobs/435617323 https://saucelabs.com/beta/tests/86c40977eac144848f0342e4b7cfb048/metadata#11 environment, version etc all seem identical. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425921890 Compare the failing test here, to a similarly configured one from another plugin: failing here: https://travis-ci.org/apache/cordova-plugin-inappbrowser/jobs/435601803 https://saucelabs.com/beta/tests/7e834da3d10d4f08b614d05fcccdfa39/metadata#6 succeeding over there: https://travis-ci.org/apache/cordova-plugin-geolocation/jobs/435617323 https://saucelabs.com/beta/tests/86c40977eac144848f0342e4b7cfb048/metadata#11 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #320: Get applicationId from package name
janpio commented on issue #320: Get applicationId from package name URL: https://github.com/apache/cordova-plugin-camera/pull/320#issuecomment-425919871 Yep, merge commit looks clean: https://github.com/apache/cordova-plugin-camera/pull/320/commits/d1516bd0966608736e62423f18bc1619b02e2cea We'll know in a bit if the tests succeed ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] squallstar commented on issue #320: Get applicationId from package name
squallstar commented on issue #320: Get applicationId from package name URL: https://github.com/apache/cordova-plugin-camera/pull/320#issuecomment-425917869 @janpio done, can you check if it's correct now? This is what I've done: ``` git remote add edx https://github.com/apache/cordova-plugin-camera.git git fetch edx git rebase edx/master git push -f ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio closed pull request #107: Remove docs translations
janpio closed pull request #107: Remove docs translations URL: https://github.com/apache/cordova-plugin-dialogs/pull/107 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-plugin-dialogs] branch remove-docs-translations deleted (was dad8fd5)
This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch remove-docs-translations in repository https://gitbox.apache.org/repos/asf/cordova-plugin-dialogs.git. was dad8fd5 remove docs translations The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-status] branch janpio-update deleted (was 58478df)
This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-update in repository https://gitbox.apache.org/repos/asf/cordova-status.git. was 58478df remove "Organization / Apache" The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-status] branch master updated: Generate table entries for all Cordova repositories (#13)
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-status.git The following commit(s) were added to refs/heads/master by this push: new d43dcc9 Generate table entries for all Cordova repositories (#13) d43dcc9 is described below commit d43dcc96b0110aa0d729c0d828061268e2148138 Author: Jan Piotrowski AuthorDate: Mon Oct 1 15:56:25 2018 +0200 Generate table entries for all Cordova repositories (#13) This PR uses the output of http://cordova.betamo.de/cordova-status_markdown.php to have entries for _all_ Cordova repositories (Use the "View" button in "Files changed" to see the rendered Markdown). The AppVeyor link is moved behind the badge, so both users can be checked - sometimes a project is available in one, both, or none of those although the badge shows a status. --- README.md | 123 +- 1 file changed, 73 insertions(+), 50 deletions(-) diff --git a/README.md b/README.md index a6d20ac..9316725 100644 --- a/README.md +++ b/README.md @@ -1,57 +1,80 @@ + -| Core Platform | Travis CI | AppVeyor | Code Coverage | +| Platforms | Travis CI | AppVeyor | Code Coverage | | :--- | :---: | :---: | :---: | -| [iOS](https://github.com/apache/cordova-ios) | [](https://travis-ci.org/apache/cordova-ios) | [](https://ci.appveyor.com/project/Humbedooh/cordova-ios/branch/master) |[](https://codecov.io/github/apache/cordova-ios?bra [...] -| [Android](https://github.com/apache/cordova-android) | [](https://travis-ci.org/apache/cordova-android) | [](https://ci.appveyor.com/project/Humbedooh/cordova-android/branch/master) | [](https://codecov.io/ [...] -| [Windows](https://github.com/apache/cordova-windows) | [](https://travis-ci.org/apache/cordova-windows) | [](https://ci.appveyor.com/project/Humbedooh/cordova-windows/branch/master) | [](https://codecov.io/gi [...] -| [Browser](https://github.com/apache/cordova-browser) | [](https://travis-ci.org/apache/cordova-browser) | [](https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-browser/branch/master) | missing | -| [OS X](https://github.com/apache/cordova-osx) | missing | missing | missing | +| Active Platforms | | | | +| [cordova-android](https://github.com/apache/cordova-android) | [](https://travis-ci.org/apache/cordova-android) |  [#1](https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-android/branch/master), [#2](https://ci.appveyor.com/project/Humbedooh/cordova-android/branch/master) | [![codeco [...] +| [cordova-ios](https://github.com/apache/cordova-ios) | [](https://travis-ci.org/apache/cordova-ios) |  [#1](https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-ios/branch/master), [#2](https://ci.appveyor.com/project/Humbedooh/cordova-ios/branch/master) | [ | [](https://travis-ci.org/apache/cordova-windows) |  [#1](https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-windows/branch/master), [#2](https://ci.appveyor.com/project/Humbedooh/cordova-windows/branch/master) | [![codeco [...] +| [cordova-browser](https://github.com/apache/cordova-browser) | [![Build
[GitHub] janpio closed pull request #117: Remove outdated doccs translations
janpio closed pull request #117: Remove outdated doccs translations URL: https://github.com/apache/cordova-plugin-geolocation/pull/117 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-plugin-geolocation] branch remove-docs-translation deleted (was 6a10456)
This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch remove-docs-translation in repository https://gitbox.apache.org/repos/asf/cordova-plugin-geolocation.git. was 6a10456 remove outdated doccs translations The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #88: CB-12479: Add loading spinner for android
janpio commented on issue #88: CB-12479: Add loading spinner for android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/88#issuecomment-425913364 Awesome. Unfortunately I have some more "work" for you: I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #265: CB-14024 Take into account statusbar height when toolbar is enabled
janpio commented on issue #265: CB-14024 Take into account statusbar height when toolbar is enabled URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/265#issuecomment-425913163 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #276: CB-14188: add beforeload event, catching navigation before it happens
janpio commented on issue #276: CB-14188: add beforeload event, catching navigation before it happens URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/276#issuecomment-425913068 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #275: CB-14190: (windows) Fix bug where double clicking `` exits app
janpio commented on issue #275: CB-14190: (windows) Fix bug where double clicking `` exits app URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/275#issuecomment-425913000 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #273: CB-NOBUG: (iOS) improvement for UI debugging/visualization
janpio commented on issue #273: CB-NOBUG: (iOS) improvement for UI debugging/visualization URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/273#issuecomment-425912933 I did @justf4st - you are of course right. I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #339: Localizing hardcoded messages
janpio commented on issue #339: Localizing hardcoded messages URL: https://github.com/apache/cordova-plugin-camera/pull/339#issuecomment-425912742 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #268: CB-12873: Add customization options for caputre button, resizing of v…
janpio commented on issue #268: CB-12873: Add customization options for caputre button, resizing of v… URL: https://github.com/apache/cordova-plugin-camera/pull/268#issuecomment-425912660 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #230: CB-13849: (android) getDirectory("") returns current path instead of / path
janpio commented on issue #230: CB-13849: (android) getDirectory("") returns
current path instead of / path
URL:
https://github.com/apache/cordova-plugin-file/pull/230#issuecomment-425912496
Hey, I just fixed the problem that caused Android tests to fail in `master`.
Could you rebase this PR please? This should get rid of the Android failures
and possibly fix all test failures for this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #311: CB-13836 Windows phone correct filename
janpio commented on issue #311: CB-13836 Windows phone correct filename URL: https://github.com/apache/cordova-plugin-camera/pull/311#issuecomment-425912543 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #320: Get applicationId from package name
janpio commented on issue #320: Get applicationId from package name URL: https://github.com/apache/cordova-plugin-camera/pull/320#issuecomment-425912588 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #217: CB-13245: (android) Fix bug caused by negative length reported for an asset
janpio commented on issue #217: CB-13245: (android) Fix bug caused by negative length reported for an asset URL: https://github.com/apache/cordova-plugin-file/pull/217#issuecomment-425912429 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #216: CB-13208: (windows) Fix `readAsBinaryString` to only read the requested range
janpio commented on issue #216: CB-13208: (windows) Fix `readAsBinaryString` to only read the requested range URL: https://github.com/apache/cordova-plugin-file/pull/216#issuecomment-425912291 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #211: CB-6938: (fix) on iOS, copyTo should overwrite any existing file
janpio commented on issue #211: CB-6938: (fix) on iOS, copyTo should overwrite any existing file URL: https://github.com/apache/cordova-plugin-file/pull/211#issuecomment-425912239 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #164: CB-13774: repair broken recording and playback functionality on Android
janpio commented on issue #164: CB-13774: repair broken recording and playback functionality on Android URL: https://github.com/apache/cordova-plugin-media/pull/164#issuecomment-425912074 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #156: CB-13633: (android) Propagate buffering start/stop events on Android.
janpio commented on issue #156: CB-13633: (android) Propagate buffering start/stop events on Android. URL: https://github.com/apache/cordova-plugin-media/pull/156#issuecomment-425911924 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #165: CB-13852: (iOS) Fix bug prevent error on getPosition
janpio commented on issue #165: CB-13852: (iOS) Fix bug prevent error on getPosition URL: https://github.com/apache/cordova-plugin-media/pull/165#issuecomment-425911880 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #155: CB-13632: (android) Allow UDP media streaming.
janpio commented on issue #155: CB-13632: (android) Allow UDP media streaming. URL: https://github.com/apache/cordova-plugin-media/pull/155#issuecomment-425911778 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] luisfernando-rf commented on issue #118: Geolocation Interval position
luisfernando-rf commented on issue #118: Geolocation Interval position URL: https://github.com/apache/cordova-plugin-geolocation/issues/118#issuecomment-425911492 ??? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #136: Add dots spinner loader for android
janpio commented on issue #136: Add dots spinner loader for android URL: https://github.com/apache/cordova-plugin-splashscreen/pull/136#issuecomment-425911693 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] luisfernando-rf commented on issue #115: Frequency/Interval feature for `watchPosition`
luisfernando-rf commented on issue #115: Frequency/Interval feature for `watchPosition` URL: https://github.com/apache/cordova-plugin-geolocation/issues/115#issuecomment-425911443 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] dominikse commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
dominikse commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-425911427 > when I run `ng run app:ionic-cordova-build --platform=ios --buildFlag="-UseModernBuildSystem=0"` I have > > ``` > Unknown option: '--buildFlag' > ``` > I'm using ng cli 6.2.3 > Any idea? > Thanks You need to change the build system in Xcode to legacy build system (see screenshots at pullet point 3 in first post). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] ansarikhurshid786 opened a new issue #309: pdf is not opening in android inappbrower using ionic 3.
ansarikhurshid786 opened a new issue #309: pdf is not opening in android
inappbrower using ionic 3.
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/309
I am using ionic 3 plugin to view pdf inappbrowser. It is working fine in
ios but not working in android.
I am using following code :
this.iab.create("pdfurlhere", "_blank").show();
I am getting any error and log in new window.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #137: CB-13460: Apply Android style to the splash screen
janpio commented on issue #137: CB-13460: Apply Android style to the splash screen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/137#issuecomment-425911395 Hey, I just fixed the problem that caused Android tests to fail. Rebasing on master should get rid of those and possibly remove all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #114: Canot open PDF file with inappbrowser ionic
janpio commented on issue #114: Canot open PDF file with inappbrowser ionic URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/114#issuecomment-425909813 Step 1: Open an issue instead of commenting on a closed PR. Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] ansarikhurshid786 commented on issue #114: Canot open PDF file with inappbrowser ionic
ansarikhurshid786 commented on issue #114: Canot open PDF file with inappbrowser ionic URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/114#issuecomment-425908219 I am also facing same issue in android only and it is working fine in ios. how to resolve in android This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio opened a new pull request #308: [WIP] remove unwanted information in README table
janpio opened a new pull request #308: [WIP] remove unwanted information in README table URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/308 ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-plugin-inappbrowser] 01/01: remove unwanted information in README table
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-remove_data_from_readme_table in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git commit 4dadf6e5890d46c5c9fd290fd5cfc2d79f7a431a Author: Jan Piotrowski AuthorDate: Mon Oct 1 15:15:20 2018 +0200 remove unwanted information in README table --- README.md | 5 - 1 file changed, 5 deletions(-) diff --git a/README.md b/README.md index eade58a..26ed518 100644 --- a/README.md +++ b/README.md @@ -24,11 +24,6 @@ description: Open an in-app browser window. |AppVeyor|Travis CI| |:-:|:-:| |[](https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-plugin-inappbrowser)|[](https://travis-ci.org/apache/cordova-plugin-inappbrowser)| -|npm install|npm install| -|eslint|eslint| -||browser (chrome, firefox, edge)| -||iOS (9.3) on Xcode 7.3| -||Android (4.4)| # cordova-plugin-inappbrowser - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-plugin-inappbrowser] branch janpio-remove_data_from_readme_table created (now 4dadf6e)
This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-remove_data_from_readme_table in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git. at 4dadf6e remove unwanted information in README table This branch includes the following new commits: new 4dadf6e remove unwanted information in README table The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
