[GitHub] brodybits commented on issue #47: Fix or remove undocumented plugin directory source-file behavior
brodybits commented on issue #47: Fix or remove undocumented plugin directory source-file behavior URL: https://github.com/apache/cordova/issues/47#issuecomment-439659371 > Should I file a bug issue for this on cordova-android? We need 2 new bug reports: * bug report on cordova-android * bug report on cordova-docs to get this feature documented > Or this is included in the scope of [apache/cordova-android#547](https://github.com/apache/cordova-android/issues/547) ? No. FYI If you just paste the link to a GitHub issue, GitHub will automatically show it the right way. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] brodybits closed issue #547: Compatibility of old plugins with non-Java source-file entries (individual files)
brodybits closed issue #547: Compatibility of old plugins with non-Java source-file entries (individual files) URL: https://github.com/apache/cordova-android/issues/547 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries (individual files)
brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries (individual files) URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439659153 Closing as this issue is resolved in both master and 7.1.x branches. 7.1.3 patch release with this issue resolved should be available this week. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] brodybits commented on issue #555: 7.1.3 patch updates
brodybits commented on issue #555: 7.1.3 patch updates URL: https://github.com/apache/cordova-android/pull/555#issuecomment-439658078 Thanks @jcesarmobile! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-android] branch 7.1.x updated (f86519b -> 442734d)
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch 7.1.x in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from f86519b Bump version to 7.1.3-dev add 00134cf Incorrect default sdk version issue fix (PR #495) add dbc99e8 Update comments (#496) add 9f6c332 Remove obsolete check for JellyBean (GH-534) (#544) add c0e9f25 Add a unit test to test source-file target-dir /app/src/main/… (PR #542) add 55f2986 unit test uninstall of with app dest (PR #542) add 4d151d3 GH-539 fix destination path fallback (PR #542) add f8584c6 unit test source-file with custom lib target-dir (PR #542) add 951ff55 unit test uninstall of with app dest (PR #542) add 717d768 GH-540 fix for source-file with app target-dir (PR #542) add 5222a0f Fix tests of plugin files with new app dir scheme (PR #542) add e3468c6 Check target-dir mapping of plugin xml source file (PR #550) add dea6846 Check old compat of other extension (CB-14125) (PR #550) add 9537e34 Test old plugin aidl & lib mapping - repros GH-547 (PR #550) add 07e1fe1 Cleanup getInstallDestination in pluginHandlers.js (PR #550) add 298f1e3 Fix comments in getInstallDestination (PR #550) add 9848aa8 GH-547 Fix for old plugins with non-Java sources (PR #550) add 0ebc9a6 add missing cast for cdvMinSdkVersion (GH-551) add 32e3eae GH-552 (android) check for build-extras.gradle in the app-parent directory (#553) new 442734d Merge pull request #555 from brodybits/7.1.3-patch-updates The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: bin/templates/cordova/lib/pluginHandlers.js| 32 -- bin/templates/project/app/build.gradle | 22 ++-- cordova-js-src/exec.js | 11 -- .../org.test.plugins.dummyplugin/plugin.xml| 12 +++ .../src/android/DummyPlugin2.java | 1 + .../src/android/TestAar.aar| 1 + .../src/android/jniLibs/x86/libnative.so | 1 + .../src/android/myapi.aidl | 1 + .../src/android/mysettings.xml | 1 + .../src/android/other.extension| 1 + .../src/android/testaar2.aar | 1 + .../src/android/testjar2.jar | 1 + spec/unit/pluginHandlers/handlers.spec.js | 115 + 13 files changed, 172 insertions(+), 28 deletions(-) create mode 100644 spec/fixtures/org.test.plugins.dummyplugin/src/android/DummyPlugin2.java create mode 100644 spec/fixtures/org.test.plugins.dummyplugin/src/android/TestAar.aar create mode 100644 spec/fixtures/org.test.plugins.dummyplugin/src/android/jniLibs/x86/libnative.so create mode 100644 spec/fixtures/org.test.plugins.dummyplugin/src/android/myapi.aidl create mode 100644 spec/fixtures/org.test.plugins.dummyplugin/src/android/mysettings.xml create mode 100644 spec/fixtures/org.test.plugins.dummyplugin/src/android/other.extension create mode 100644 spec/fixtures/org.test.plugins.dummyplugin/src/android/testaar2.aar create mode 100644 spec/fixtures/org.test.plugins.dummyplugin/src/android/testjar2.jar - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] brodybits closed pull request #555: 7.1.3 patch updates
brodybits closed pull request #555: 7.1.3 patch updates
URL: https://github.com/apache/cordova-android/pull/555
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/bin/templates/cordova/lib/pluginHandlers.js
b/bin/templates/cordova/lib/pluginHandlers.js
index a3ebed0eb..aaee3b3ee 100644
--- a/bin/templates/cordova/lib/pluginHandlers.js
+++ b/bin/templates/cordova/lib/pluginHandlers.js
@@ -34,7 +34,7 @@ var handlers = {
// a later plugins release. This is for legacy plugins to work
with Cordova.
if (options && options.android_studio === true) {
-dest = studioPathRemap(obj);
+dest = getInstallDestination(obj);
}
if (options && options.force) {
@@ -47,7 +47,7 @@ var handlers = {
var dest = path.join(obj.targetDir, path.basename(obj.src));
if (options && options.android_studio === true) {
-dest = studioPathRemap(obj);
+dest = getInstallDestination(obj);
}
// TODO: Add Koltin extension to uninstall, since they are handled
like Java files
@@ -317,15 +317,29 @@ function generateAttributeError (attribute, element, id) {
return 'Required attribute "' + attribute + '" not specified in <' +
element + '> element from plugin: ' + id;
}
-function studioPathRemap (obj) {
-// If a Java file is using the new directory structure, don't penalize it
-if (!obj.targetDir.includes('app/src/main')) {
-if (obj.src.endsWith('.java')) {
-return path.join('app/src/main/java', obj.targetDir.substring(4),
path.basename(obj.src));
+function getInstallDestination (obj) {
+var APP_MAIN_PREFIX = 'app/src/main';
+
+if (obj.targetDir.includes('app')) {
+// If any source file is using the new app directory structure,
+// don't penalize it
+return path.join(obj.targetDir, path.basename(obj.src));
+} else if (obj.src.endsWith('.java')) {
+return path.join(APP_MAIN_PREFIX, 'java', obj.targetDir.substring(4),
path.basename(obj.src));
+} else if (obj.src.endsWith('.aidl')) {
+return path.join(APP_MAIN_PREFIX, 'aidl', obj.targetDir.substring(4),
path.basename(obj.src));
+} else if (obj.targetDir.includes('libs')) {
+if (obj.src.endsWith('.so')) {
+return path.join(APP_MAIN_PREFIX, 'jniLibs',
obj.targetDir.substring(5), path.basename(obj.src));
} else {
-// For all other files, add 'app/src/main' to the targetDir if it
didn't have it already
-return path.join('app/src/main', obj.targetDir,
path.basename(obj.src));
+return path.join('app', obj.targetDir, path.basename(obj.src));
}
+} else if (obj.targetDir.includes('src/main')) {
+return path.join('app', obj.targetDir, path.basename(obj.src));
+} else {
+// For all other source files not using the new app directory
structure,
+// add 'app/src/main' to the targetDir
+return path.join(APP_MAIN_PREFIX, obj.targetDir,
path.basename(obj.src));
}
}
diff --git a/bin/templates/project/app/build.gradle
b/bin/templates/project/app/build.gradle
index b47fdf948..4830dd93e 100644
--- a/bin/templates/project/app/build.gradle
+++ b/bin/templates/project/app/build.gradle
@@ -69,7 +69,7 @@ ext {
if (!project.hasProperty('cdvBuildMultipleApks')) {
cdvBuildMultipleApks = null
}
-// Whether to append a 0 "abi digit" to versionCode when only a single APK
is build
+// Whether to append a 0 "abi digit" to versionCode when only a single APK
is build
if (!project.hasProperty('cdvVersionCodeForceAbiDigit')) {
cdvVersionCodeForceAbiDigit = null
}
@@ -93,11 +93,16 @@ ext {
// PLUGIN GRADLE EXTENSIONS START
// PLUGIN GRADLE EXTENSIONS END
-def hasBuildExtras = file('build-extras.gradle').exists()
-if (hasBuildExtras) {
+def hasBuildExtras1 = file('build-extras.gradle').exists()
+if (hasBuildExtras1) {
apply from: 'build-extras.gradle'
}
+def hasBuildExtras2 = file('../build-extras.gradle').exists()
+if (hasBuildExtras2) {
+apply from: '../build-extras.gradle'
+}
+
// Set property defaults after extension .gradle files.
if (ext.cdvCompileSdkVersion == null) {
ext.cdvCompileSdkVersion = privateHelpers.getProjectTarget()
@@ -117,7 +122,7 @@ if (ext.cdvReleaseSigningPropertiesFile == null &&
file('../release-signing.prop
// Cast to appropriate types.
ext.cdvBuildMultipleApks = cdvBuildMultipleApks == null ? false :
cdvBuildMultipleApks.toBoolean();
ext.cdvVersionCodeForceAbiDigit = cdvVersionCodeForceAbiDigit == null ? false
: cdvVersionCodeForceAbiDigit.toBoolean();
-ext.cdvMinSdkVersion = cdvMinSdkVersion == null ? null
[cordova-android] 01/01: Merge pull request #555 from brodybits/7.1.3-patch-updates
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch 7.1.x in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit 442734dc477031f36f318f4419209a6314aac0ab Merge: f86519b 32e3eae Author: Chris Brody AuthorDate: Sat Nov 17 19:32:57 2018 -0500 Merge pull request #555 from brodybits/7.1.3-patch-updates 7.1.3 patch updates bin/templates/cordova/lib/pluginHandlers.js| 32 -- bin/templates/project/app/build.gradle | 22 ++-- cordova-js-src/exec.js | 11 -- .../org.test.plugins.dummyplugin/plugin.xml| 12 +++ .../src/android/DummyPlugin2.java | 1 + .../src/android/TestAar.aar| 1 + .../src/android/jniLibs/x86/libnative.so | 1 + .../src/android/myapi.aidl | 1 + .../src/android/mysettings.xml | 1 + .../src/android/other.extension| 1 + .../src/android/testaar2.aar | 1 + .../src/android/testjar2.jar | 1 + spec/unit/pluginHandlers/handlers.spec.js | 115 + 13 files changed, 172 insertions(+), 28 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin (with `StatusBar.overlaysWebView(true)`) hides the input when the keyboard appears
tharunkumar0 commented on issue #110: Cordova Status Bar Plugin (with `StatusBar.overlaysWebView(true)`) hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439632925 Yeah okay :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] milankragujevic edited a comment on issue #165: issue on Samsung s9 plus.
milankragujevic edited a comment on issue #165: issue on Samsung s9 plus. URL: https://github.com/apache/cordova-plugin-splashscreen/issues/165#issuecomment-439631542 Same problem on Samsung A5, solved it by resizing the image to 1280x720/720x1280 respectively. Thanks @jachstet-sea! 😄 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] milankragujevic commented on issue #165: issue on Samsung s9 plus.
milankragujevic commented on issue #165: issue on Samsung s9 plus. URL: https://github.com/apache/cordova-plugin-splashscreen/issues/165#issuecomment-439631542 Same problem on Samsung A5, solved it by resizing the image to 1280x720/720x1280 respectively. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin (with `StatusBar.overlaysWebView(true)`) hides the input when the keyboard appears
janpio commented on issue #110: Cordova Status Bar Plugin (with `StatusBar.overlaysWebView(true)`) hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439622136 Oh, someone/I will have to look into iOS later as well then. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] itsonit edited a comment on issue #114: Not working on Android devices
itsonit edited a comment on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-439513362 @terminaltor ty for sharing. 1st Test set with several android devices works well. 2nd Test will follow.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
