[GitHub] [cordova-plugin-statusbar] breautek commented on issue #134: feat: get statusbar height (top-inset)
breautek commented on issue #134: feat: get statusbar height (top-inset) URL: https://github.com/apache/cordova-plugin-statusbar/pull/134#issuecomment-612903499 Before this can be merged we will need: - https://github.com/apache/cordova-plugin-statusbar/pull/134#discussion_r350545105 to be addressed - A second PMC member to vote in favour. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] breautek commented on issue #134: feat: get statusbar height (top-inset)
breautek commented on issue #134: feat: get statusbar height (top-inset) URL: https://github.com/apache/cordova-plugin-statusbar/pull/134#issuecomment-558462107 I think android looks fine. I'm not very knowledgeable on iOS development, but I think the `setKeepCallbackAsBool` usage might be out of place. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] breautek commented on issue #134: feat: get statusbar height (top-inset)
breautek commented on issue #134: feat: get statusbar height (top-inset) URL: https://github.com/apache/cordova-plugin-statusbar/pull/134#issuecomment-546088806 Things have changed since your PR and there is an outstanding merge conflict. Once that is resolved, I can look at the android side of things. Just tag me and I'll try to look at it within a week... and if I don't then feel free to ping me again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
