[GitHub] BuddyLReno commented on a change in pull request #197: Add durationUpdate callback
BuddyLReno commented on a change in pull request #197: Add durationUpdate
callback
URL:
https://github.com/apache/cordova-plugin-media/pull/197#discussion_r234709841
##
File path: README.md
##
@@ -237,6 +239,9 @@ var timerDur = setInterval(function() {
}, 100);
```
+ Android Quirk
+Newer versions of android have aggressive routines that limit background
processing. If you are trying to get duration while your app is in the
background longer than roughly 5 minutes, you will get more consistent results
by using the `mediaDurationUpdate` callback.
Review comment:
Love it! ❤️
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] BuddyLReno commented on a change in pull request #197: Add durationUpdate callback
BuddyLReno commented on a change in pull request #197: Add durationUpdate
callback
URL:
https://github.com/apache/cordova-plugin-media/pull/197#discussion_r234240286
##
File path: www/Media.js
##
@@ -35,16 +35,22 @@ var mediaObjects = {};
* @param errorCallback The callback to be called if there is an error.
* errorCallback(int errorCode) - OPTIONAL
* @param statusCallbackThe callback to be called when media status
has changed.
- * statusCallback(int statusCode) - OPTIONAL
Review comment:
Fixed!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] BuddyLReno commented on a change in pull request #197: Add durationUpdate callback
BuddyLReno commented on a change in pull request #197: Add durationUpdate
callback
URL:
https://github.com/apache/cordova-plugin-media/pull/197#discussion_r234239840
##
File path: www/Media.js
##
@@ -35,16 +35,22 @@ var mediaObjects = {};
* @param errorCallback The callback to be called if there is an error.
* errorCallback(int errorCode) - OPTIONAL
* @param statusCallbackThe callback to be called when media status
has changed.
- * statusCallback(int statusCode) - OPTIONAL
Review comment:
ah that was a mistake!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
