[GitHub] brodybits commented on issue #555: 7.1.3 patch updates
brodybits commented on issue #555: 7.1.3 patch updates URL: https://github.com/apache/cordova-android/pull/555#issuecomment-439658078 Thanks @jcesarmobile! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] brodybits commented on issue #555: 7.1.3 patch updates
brodybits commented on issue #555: 7.1.3 patch updates URL: https://github.com/apache/cordova-android/pull/555#issuecomment-439484841 I just updated the changes as follows: * moved a couple gradle updates to the end * added number of original PR on master where it was not present I also updated the description to list the changes in the same order as they appear in this PR. I hope this makes it easier to check what changes are in this PR. Thanks @jcesarmobile for your efforts to check the changes in both branches. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] brodybits commented on issue #555: 7.1.3 patch updates
brodybits commented on issue #555: 7.1.3 patch updates URL: https://github.com/apache/cordova-android/pull/555#issuecomment-439447665 I just put the changes in almost the same order as they appear in master and removed "[WIP]" from the title, think it should be merged now. Any objections? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] brodybits commented on issue #555: 7.1.3 patch updates
brodybits commented on issue #555: 7.1.3 patch updates URL: https://github.com/apache/cordova-android/pull/555#issuecomment-438990227 I just pushed a change to remove the GH-547 fix for aidl files. This means that plugins such as cordova-plugin-purchase would need to keep multiple aidl `source-file` entries to support both cordova-android@6 and cordova-android@latest. This is needed to avoid breaking plugins such as cordova-plugin-purchase in a patch release. I suspect we should push this change to master to avoid breaking plugins such as cordova-plugin-purchase in the foreseeable future. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] brodybits commented on issue #555: 7.1.3 patch updates
brodybits commented on issue #555: 7.1.3 patch updates URL: https://github.com/apache/cordova-android/pull/555#issuecomment-438911311 I just finished testing the patch updates with some plugins listed in the OP description, quick review would be appreciated. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
