[GitHub] erisu commented on a change in pull request #438: Add support for EnableGoogleServicesPlugin
erisu commented on a change in pull request #438: Add support for
EnableGoogleServicesPlugin
URL: https://github.com/apache/cordova-android/pull/438#discussion_r216195552
##
File path: bin/templates/project/app/build.gradle
##
@@ -30,6 +30,7 @@ buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:3.1.0'
+classpath 'com.google.gms:google-services:3.2.1'
Review comment:
@chemerisuk Yes, it seems `cordova.gradle` would need to be applied within
the scope so it becomes available.
```
dependencies {
apply from: '../CordovaLib/cordova.gradle'
classpath 'com.android.tools.build:gradle:3.1.0'
if(cdvHelpers.getConfigPreference('EnableGoogleServicesPlugin',
'false').toBoolean()) {
println 'Adding classpath "com.google.gms:google-services:3.2.1"'
classpath 'com.google.gms:google-services:3.2.1'
}
}
```
@dpogue Would you know off-hand if something like this would be problematic?
The `cordova.gradle` content seems to be only helper methods. Adding it seems
to solve the desire to make the classpaths conditional.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu commented on a change in pull request #438: Add support for EnableGoogleServicesPlugin
erisu commented on a change in pull request #438: Add support for
EnableGoogleServicesPlugin
URL: https://github.com/apache/cordova-android/pull/438#discussion_r215494090
##
File path: bin/templates/project/app/build.gradle
##
@@ -30,6 +30,7 @@ buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:3.1.0'
+classpath 'com.google.gms:google-services:3.2.1'
Review comment:
Would it be possible to wrap this `classpath` in an if condition, like how
the apply is done?
It would be nice to minimize the amount of downloading of build related
libraries if they are not needed.
```
if (cdvHelpers.getConfigPreference('EnableGoogleServicesPlugin',
'false').toBoolean()) {
classpath 'com.google.gms:google-services:3.2.1'
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
