[GitHub] fortunes-technology commented on issue #25: CB-13193: (ios) Fixed Lock iOS Landscape Orientation turn up-sidedown

2018-06-08 Thread GitBox
fortunes-technology commented on issue #25: CB-13193: (ios) Fixed Lock iOS 
Landscape Orientation turn up-sidedown
URL: 
https://github.com/apache/cordova-plugin-screen-orientation/pull/25#issuecomment-395776862
 
 
   @macdonst @purplecabbage @stevengill 
   Can someone review this PR please?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] fortunes-technology commented on issue #25: CB-13193: (ios) Fixed Lock iOS Landscape Orientation turn up-sidedown

2018-02-11 Thread GitBox
fortunes-technology commented on issue #25: CB-13193: (ios) Fixed Lock iOS 
Landscape Orientation turn up-sidedown
URL: 
https://github.com/apache/cordova-plugin-screen-orientation/pull/25#issuecomment-364814425
 
 
   The Merge conflict fixed. 
   This PR fixes, the landscape right and left issue.
   Also if you want to lock orientation to landscape (do not care when it is 
right or left) and it's already in landscape mode (whether it is right or 
left), we shouldn't be changing orientation.
   Right now, if we change orientation to landscape, it just change it to 
landscape left.
   So this is fixed with this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org