[GitHub] heidji edited a comment on issue #290: InAppBrowser will not close when invoking ref.close()

2018-11-16 Thread GitBox
heidji edited a comment on issue #290: InAppBrowser will not close when 
invoking ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439556413
 
 
   actually i was mistaken about _blank not closing, but it's because also in 
my app _blank doesn't work: the reason being that the external http location 
having a callback with myapp:// scheme to return to the app, but in _blank this 
call never gets through. yes your rep works, but _blank doesn't work for me, it 
has to be an external browser with _system in order to call the custom URL 
scheme.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] heidji edited a comment on issue #290: InAppBrowser will not close when invoking ref.close()

2018-11-16 Thread GitBox
heidji edited a comment on issue #290: InAppBrowser will not close when 
invoking ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439553520
 
 
   @janpio actually the behavior of _blank isn't useful to me, it opens inside 
the app itself and doesn't close either..
   i mean it uses the app as a browser


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] heidji edited a comment on issue #290: InAppBrowser will not close when invoking ref.close()

2018-10-30 Thread GitBox
heidji edited a comment on issue #290: InAppBrowser will not close when 
invoking ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-434439417
 
 
   ```
   import {InAppBrowser} from "@ionic-native/in-app-browser";
   
   let ref = window.open('https://www.example.com/', '_system');
   ref.close(); //does nothing
   
   ```
   yes, i had to install the plugin because in iOS window.open doesn't work 
without having InAppBrowser installed, so before the plugin ref.close() in this 
scenario would work. now it doesn't 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] heidji edited a comment on issue #290: InAppBrowser will not close when invoking ref.close()

2018-10-30 Thread GitBox
heidji edited a comment on issue #290: InAppBrowser will not close when 
invoking ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-434439417
 
 
   ```
   import {InAppBrowser} from "@ionic-native/in-app-browser";
   
   let ref = window.open('https://www.example.com/', '_system');
   ref.close(); //does nothing
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] heidji edited a comment on issue #290: InAppBrowser will not close when invoking ref.close()

2018-10-10 Thread GitBox
heidji edited a comment on issue #290: InAppBrowser will not close when 
invoking ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-428661776
 
 
   +1
   
   before installing inAppBrowser ref.close() would work on Android. Now it 
doesn't.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org