[GitHub] janpio commented on issue #136: Add dots spinner loader for android
janpio commented on issue #136: Add dots spinner loader for android URL: https://github.com/apache/cordova-plugin-splashscreen/pull/136#issuecomment-426718934 Closing and re-opening to trigger a new CI/test run with new PR merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #136: Add dots spinner loader for android
janpio commented on issue #136: Add dots spinner loader for android URL: https://github.com/apache/cordova-plugin-splashscreen/pull/136#issuecomment-425934760 `rebase` is git command that takes your changes from your branch, which was created in the past and with an old state of code, and moves it to present to the current code. Your changes stay here, but you get all the changes that happened in between. In this case, this would mean the fixes for the tests. Here are 2 tutorials: https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request https://stackoverflow.com/a/46148801/252627 Looks pretty complicated, but is _very_ simple if you understood it (and you don't have any merge conflict - but your change won't). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #136: Add dots spinner loader for android
janpio commented on issue #136: Add dots spinner loader for android URL: https://github.com/apache/cordova-plugin-splashscreen/pull/136#issuecomment-425911693 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
