[GitHub] janpio commented on issue #197: Add durationUpdate callback
janpio commented on issue #197: Add durationUpdate callback URL: https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-440286907 Sure, whatever you are comfortable with. Shouldn't be to hard to recreate with Cordova though later on. Maybe I can fork your app then and transform it to pure Cordova. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #197: Add durationUpdate callback
janpio commented on issue #197: Add durationUpdate callback URL: https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439521793 Ok, so https://github.com/apache/cordova-plugin-media#quick-example-2 doesn't actually work that well any more and one should use this new callback param instead on Android, correct? If so, best add this as an "Android Quirk" under the `getDuration` example in the README to make sure it gets noticed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #197: Add durationUpdate callback
janpio commented on issue #197: Add durationUpdate callback URL: https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439422019 (Thanks for the updates on the text, I cleaned up the comments a bit by hiding.) Interesting change. I understand both parts of what you wrote: > This particular change helps deal with the fact that Android shuts down webapps in the background after a few minutes. > You can subscribe to this callback and let the audio player report the duration to you when it's available instead of querying for it. But to be honest I don't really get how those are connected. Can you elaborate maybe? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #197: Add durationUpdate callback
janpio commented on issue #197: Add durationUpdate callback URL: https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439213524 Could you update the PR description, platform etc please? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
