[GitHub] jcesarmobile commented on issue #555: 7.1.3 patch updates

2018-11-16 Thread GitBox
jcesarmobile commented on issue #555: 7.1.3 patch updates
URL: https://github.com/apache/cordova-android/pull/555#issuecomment-439476178
 
 
   No, because master have a lot more fixes that won't go into 7.1.3, so you 
can't directly compare
   
   Also no to 7.2.0, this is supposedly a patch, and doing a minor bump will 
prevent the cli from getting this version that patches some bugs we caused in 
previous release
   
   Will review later tonight 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] jcesarmobile commented on issue #555: 7.1.3 patch updates

2018-11-15 Thread GitBox
jcesarmobile commented on issue #555: 7.1.3 patch updates
URL: https://github.com/apache/cordova-android/pull/555#issuecomment-438991918
 
 
   This PR is to cherry-pick master changes to 7.1.x, if you push changes here 
before being on master, then it's not a cherry-pick anymore.
   If the current patch for aidl files doesn't work well report an issue 
explaining it better (as by your comment I don't know what's wrong with this 
approach) and fix it in master first, and then we can cherry-pick on this 
branch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org