[GitHub] raphinesse commented on issue #437: CB-14038 (android): fix false positive detecting project type

2018-06-21 Thread GitBox
raphinesse commented on issue #437: CB-14038 (android): fix false positive 
detecting project type
URL: https://github.com/apache/cordova-android/pull/437#issuecomment-399133263
 
 
   Thanks for your answer.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] raphinesse commented on issue #437: CB-14038 (android): fix false positive detecting project type

2018-06-21 Thread GitBox
raphinesse commented on issue #437: CB-14038 (android): fix false positive 
detecting project type
URL: https://github.com/apache/cordova-android/pull/437#issuecomment-399058403
 
 
   @jcesarmobile Is there any WIP for the aforementioned refactor? Losing some 
dead weight would definitely be good. Furthermore, before I discovered this PR 
by accident, I already thought about starting to DRY the two very similar 
Builders, not knowing that removal of one of them is due.
   
   BTW: GradleBuilder is used by the Java unit test runner. Just to create a 
Gradle wrapper, so the dependency could be easily removed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org