[GitHub] stevengill commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit
stevengill commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-337678844 I managed to npm link common into android but then when i added my local android to a cordova project, the way it was being added and copied made it so it wasn't using my linked common. I think this is because when we add platforms to projects, we run npm install on them. So it would fetch the version that was listed in package.json instead of using the linked common i had. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] stevengill commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit
stevengill commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-337673585 Common PRs have been merged. When testing this locally, you have to go into package.json of cordova-android and change the version of cordova-common in your dependency object to point to your local version of cordova-common. Something like: ``` "cordova-common": "../cordova-common", ``` This is because when you add android as a platform, it copies cordova-common over This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
