[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1548: Front-end supplemental license

2019-12-24 Thread GitBox
break60 opened a new pull request #1548: Front-end supplemental license
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1548
 
 
   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review 
https://dolphinscheduler.apache.org/en-us/community/index.html before opening a 
pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds checkstyle plugin.)*
   
   ## Brief change log
   
   *(for example:)*
 - *Add maven-checkstyle-plugin to root pom.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please 
describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
 - *Added dolphinscheduler-dao tests for end-to-end.*
 - *Added CronUtilsTest to verify the change.*
 - *Manually verified the change by testing locally.*
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1549: Front-end supplemental license

2019-12-24 Thread GitBox
break60 opened a new pull request #1549: Front-end supplemental license
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1549
 
 
   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review 
https://dolphinscheduler.apache.org/en-us/community/index.html before opening a 
pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds checkstyle plugin.)*
   
   ## Brief change log
   
   *(for example:)*
 - *Add maven-checkstyle-plugin to root pom.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please 
describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
 - *Added dolphinscheduler-dao tests for end-to-end.*
 - *Added CronUtilsTest to verify the change.*
 - *Manually verified the change by testing locally.*
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1548: Front-end supplemental license

2019-12-24 Thread GitBox
codecov-io commented on issue #1548: Front-end supplemental license
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1548#issuecomment-568687947
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1548?src=pr&el=h1)
 Report
   > Merging 
[#1548](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1548?src=pr&el=desc)
 into 
[dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/27ce4ac71c8057d1dea66fc6dc52a0c26d9da129?src=pr&el=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1548/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1548?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff@@
   ## dev   #1548  +/-   ##
   
   - Coverage   7.79%   7.77%   -0.02% 
   
 Files272 272  
 Lines  13641   13641  
 Branches21662166  
   
   - Hits10631061   -2 
   - Misses 12506   12508   +2 
 Partials  72  72
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1548?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...ache/dolphinscheduler/common/enums/ZKNodeType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1548/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1pLTm9kZVR5cGUuamF2YQ==)
 | `0% <0%> (-100%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1548?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1548?src=pr&el=footer).
 Last update 
[27ce4ac...cbd5e91](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1548?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] modehuan opened a new issue #1550: 补数据按区间执行

2019-12-24 Thread GitBox
modehuan opened a new issue #1550: 补数据按区间执行
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1550
 
 
   在系统初始化数据时,针对一些大的流水表数据不需要按日增量的方式跑数,几年的数据,按天的补数太慢了.做成按时间段跑数据可以有效解决这个问题.比如按年 按月 
按周 或者自定义区间的每隔多少天执行一次.
   
例:定义补数区间从20160101-当前时间,每隔一年(或者一个月)时间跑一次任务.那就会在20170101跑一次前一年(20160101-20170101)数据.在20180101跑一次前一年(20170101-20180101)数据.一直跑到最新日期..补完历史所有数据.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] wenhemin opened a new pull request #1551: remove master server and worker server listening port (5566、7788)

2019-12-24 Thread GitBox
wenhemin opened a new pull request #1551: remove master server and worker 
server listening port (5566、7788)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1551
 
 
   1.remove unused packages
   `import com.google.common.collect.ArrayListMultimap; `
   
   2.set the swagger class to load only on the web server
   
   3.set the master server and worker server to starting on servletless mode
   
   4.update properties file
   
   issues: https://github.com/apache/incubator-dolphinscheduler/issues/1509


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] wjyheropk commented on issue #1506: wokerServer ShutdownHook: dataSource already closed excepiton

2019-12-24 Thread GitBox
wjyheropk commented on issue #1506: wokerServer ShutdownHook: dataSource 
already closed excepiton
URL: 
https://github.com/apache/incubator-dolphinscheduler/issues/1506#issuecomment-568700482
 
 
   I am not sure.
   In workerServer, alertDao is autowired by spring,
   but in master(ZKMasterClient), alertDao is created by DaoFactory,  why 
different?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-dolphinscheduler] branch 1.2.0-release updated: Front-end supplemental license (#1549)

2019-12-24 Thread lgcareer
This is an automated email from the ASF dual-hosted git repository.

lgcareer pushed a commit to branch 1.2.0-release
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git


The following commit(s) were added to refs/heads/1.2.0-release by this push:
 new 644c30c  Front-end supplemental license (#1549)
644c30c is described below

commit 644c30cfcbd807835649508d090ff79d84416a0e
Author: break60 <790061...@qq.com>
AuthorDate: Tue Dec 24 17:08:45 2019 +0800

Front-end supplemental license (#1549)

* Front-end compliance modification

* Front-end supplemental license

* Modify naming
---
 .../src/main/release-docs/LICENSE  | 15 
 .../release-docs/licenses/LICENSE-jquery-ui.txt| 45 ++
 dolphinscheduler-ui/package.json   |  8 ++--
 3 files changed, 57 insertions(+), 11 deletions(-)

diff --git 
a/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/LICENSE 
b/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/LICENSE
index ae3f723..b1b917b 100644
--- a/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/LICENSE
+++ b/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/LICENSE
@@ -211,21 +211,22 @@ licenses.
 
 MIT licenses
 
-vue2.5.17: https://github.com/vuejs/vueMIT
-jquery 1.12.4: https://github.com/jquery/jquery MIT
-vue-router 2.7.0: https://github.com/vuejs/vue-router MIT
-vuex 3.0.0: https://github.com/vuejs/vuex MIT
+ans-UI 0.0.22: https://github.com/analysys/ans-ui MIT
+axios 0.16.2: https://github.com/axios/axios MIT
 bootstrap 3.3.7: https://github.com/twbs/bootstrap MIT
 canvg 1.5.1: https://github.com/canvg/canvg MIT
 clipboard 2.0.1: https://github.com/zenorocha/clipboard.js MIT
 codemirror 5.43.0: https://github.com/codemirror/CodeMirror MIT
 dayjs 1.7.8: https://github.com/iamkun/dayjs MIT
 html2canvas 0.5.0-beta4: https://github.com/niklasvh/html2canvas MIT
+jquery 1.12.4: https://github.com/jquery/jquery MIT
+jquery-ui 1.12.1: https://github.com/jquery/jquery-ui MIT
+jsplumb 2.8.6: https://github.com/jsplumb/jsplumb MIT and GPLv2
 lodash 4.17.11: https://github.com/lodash/lodash MIT
+vue2.5.17: https://github.com/vuejs/vueMIT
+vue-router 2.7.0: https://github.com/vuejs/vue-router MIT
+vuex 3.0.0: https://github.com/vuejs/vuex MIT
 vuex-router-sync 4.1.2: https://github.com/vuejs/vuex-router-sync MIT
-ans-UI 0.0.22: https://github.com/analysys/ans-ui MIT
-axios 0.16.2: https://github.com/axios/axios MIT
-jsplumb 2.8.6: https://github.com/jsplumb/jsplumb MIT and GPLv2
 
 
 Apache 2.0 licenses
diff --git 
a/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-jquery-ui.txt
 
b/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-jquery-ui.txt
new file mode 100644
index 000..6b42d96
--- /dev/null
+++ 
b/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-jquery-ui.txt
@@ -0,0 +1,45 @@
+MIT License
+
+Copyright jQuery Foundation and other contributors, https://jquery.org/
+
+This software consists of voluntary contributions made by many
+individuals. For exact contribution history, see the revision history
+available at https://github.com/jquery/jquery-ui
+
+The following license applies to all parts of this software except as
+documented below:
+
+
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+
+
+Copyright and related rights for sample code are waived via CC0. Sample
+code is defined as all source code contained within the demos directory.
+
+CC0: http://creativecommons.org/publicdomain/zero/1.0/
+
+
+
+All files located in the node_modules and external directories are
+externally maintained librari

[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1549: Front-end supplemental license

2019-12-24 Thread GitBox
lgcareer merged pull request #1549: Front-end supplemental license
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1549
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1551: remove master server and worker server listening port (5566、7788)

2019-12-24 Thread GitBox
codecov-io commented on issue #1551: remove master server and worker server 
listening port (5566、7788)
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1551#issuecomment-568701257
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1551?src=pr&el=h1)
 Report
   > Merging 
[#1551](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1551?src=pr&el=desc)
 into 
[dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/6837bedce8cde10a3186d288bb7fb4d233507569?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1551/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1551?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## dev   #1551   +/-   ##
   =
 Coverage   7.79%   7.79%   
   =
 Files272 272   
 Lines  13641   13641   
 Branches21662166   
   =
 Hits10631063   
 Misses 12506   12506   
 Partials  72  72
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1551?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...e/dolphinscheduler/server/worker/WorkerServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1551/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9Xb3JrZXJTZXJ2ZXIuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...phinscheduler/api/configuration/SwaggerConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1551/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbmZpZ3VyYXRpb24vU3dhZ2dlckNvbmZpZy5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...onfiguration/ServiceModelToSwagger2MapperImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1551/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbmZpZ3VyYXRpb24vU2VydmljZU1vZGVsVG9Td2FnZ2VyMk1hcHBlckltcGwuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...che/dolphinscheduler/api/ApiApplicationServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1551/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL0FwaUFwcGxpY2F0aW9uU2VydmVyLmphdmE=)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...e/dolphinscheduler/server/master/MasterServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1551/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9NYXN0ZXJTZXJ2ZXIuamF2YQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1551?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1551?src=pr&el=footer).
 Last update 
[6837bed...dfa8083](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1551?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-dolphinscheduler] branch dev updated (6837bed -> 57aafc1)

2019-12-24 Thread lgcareer
This is an automated email from the ASF dual-hosted git repository.

lgcareer pushed a change to branch dev
in repository 
https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git.


from 6837bed  Front-end third-party js, css introduced using npm (#1546)
 add 57aafc1  Front-end supplemental license (#1548)

No new revisions were added by this update.

Summary of changes:
 dolphinscheduler-dist/release-docs/LICENSE  | 15 ---
 .../{LICENSE-lodash => LICENSE-jquery-ui.txt}   | 21 -
 dolphinscheduler-ui/package.json|  6 +++---
 3 files changed, 19 insertions(+), 23 deletions(-)
 copy dolphinscheduler-dist/release-docs/licenses/ui-licenses/{LICENSE-lodash 
=> LICENSE-jquery-ui.txt} (70%)



[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1548: Front-end supplemental license

2019-12-24 Thread GitBox
lgcareer merged pull request #1548: Front-end supplemental license
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1548
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #1550: 补数据按区间执行

2019-12-24 Thread GitBox
xingchun-chen commented on issue #1550: 补数据按区间执行
URL: 
https://github.com/apache/incubator-dolphinscheduler/issues/1550#issuecomment-568701768
 
 
   Please add the title in English, thanks
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #1547: [Feature] node text edit box supports full-screen magnification(节点文本编辑框支持全屏放大)

2019-12-24 Thread GitBox
xingchun-chen commented on issue #1547: [Feature] node text edit box supports 
full-screen magnification(节点文本编辑框支持全屏放大)
URL: 
https://github.com/apache/incubator-dolphinscheduler/issues/1547#issuecomment-568703422
 
 
   Thank you for your suggestion. For long texts, you can edit the files in the 
Resource Center-> File Management page. You can reference the resource files in 
the script


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in 
/escheduler-ui/src/lib/@fedor/io
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1231#issuecomment-568703787
 
 
   Dependabot tried to update this pull request, but something went wrong. 
We're looking into it, but in the meantime you can retry the update by 
commenting `@dependabot rebase`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in 
/escheduler-ui
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1230#issuecomment-568703785
 
 
   Dependabot tried to update this pull request, but something went wrong. 
We're looking into it, but in the meantime you can retry the update by 
commenting `@dependabot rebase`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in 
/escheduler-ui
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1232#issuecomment-568703784
 
 
   Dependabot tried to update this pull request, but something went wrong. 
We're looking into it, but in the meantime you can retry the update by 
commenting `@dependabot rebase`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] elonlo commented on issue #1547: [Feature] node text edit box supports full-screen magnification(节点文本编辑框支持全屏放大)

2019-12-24 Thread GitBox
elonlo commented on issue #1547: [Feature] node text edit box supports 
full-screen magnification(节点文本编辑框支持全屏放大)
URL: 
https://github.com/apache/incubator-dolphinscheduler/issues/1547#issuecomment-568704338
 
 
   Yes, this is one way. But there are many times when development is to write 
SQL or text directly in the node text edit box. In this case, can we make the 
user experience better?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] lgcareer opened a new pull request #1552: Add space or colon

2019-12-24 Thread GitBox
lgcareer opened a new pull request #1552: Add space or colon
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1552
 
 
   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review 
https://dolphinscheduler.apache.org/en-us/community/index.html before opening a 
pull request.*
   
   ## What is the purpose of the pull request
   
   *Add space or colon*
   
   ## Brief change log
   
   *Add space or colon*

   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1552: Add space or colon

2019-12-24 Thread GitBox
qiaozhanwei merged pull request #1552: Add space or colon
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1552
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-dolphinscheduler] branch 1.2.0-release updated: Add space or colon (#1552)

2019-12-24 Thread journey
This is an automated email from the ASF dual-hosted git repository.

journey pushed a commit to branch 1.2.0-release
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git


The following commit(s) were added to refs/heads/1.2.0-release by this push:
 new 5e93e7a  Add space or colon (#1552)
5e93e7a is described below

commit 5e93e7a5dcbf9718bbfba755a54b28385451ee3b
Author: lgcareer <18610854...@163.com>
AuthorDate: Tue Dec 24 17:26:19 2019 +0800

Add space or colon (#1552)
---
 .../dolphinscheduler-backend/src/main/release-docs/LICENSE | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/dolphinscheduler-dist/dolphinscheduler-backend/src/main/release-docs/LICENSE 
b/dolphinscheduler-dist/dolphinscheduler-backend/src/main/release-docs/LICENSE
index 9134986..53a89e6 100644
--- 
a/dolphinscheduler-dist/dolphinscheduler-backend/src/main/release-docs/LICENSE
+++ 
b/dolphinscheduler-dist/dolphinscheduler-backend/src/main/release-docs/LICENSE
@@ -242,7 +242,7 @@ The text of each license is also included at 
licenses/LICENSE-[project].txt.
 commons-collections4 4.1: 
https://mvnrepository.com/artifact/org.apache.commons/commons-collections4/4.1, 
Apache 2.0
 commons-compress 1.4.1: 
https://mvnrepository.com/artifact/org.apache.commons/commons-compress/1.4.1, 
Apache 2.0
 commons-configuration 1.10: 
https://mvnrepository.com/artifact/commons-configuration/commons-configuration/1.10,
 Apache 2.0
-commons-daemon 1.0.13 
https://mvnrepository.com/artifact/commons-daemon/commons-daemon/1.0.13, Apache 
2.0
+commons-daemon 1.0.13: 
https://mvnrepository.com/artifact/commons-daemon/commons-daemon/1.0.13, Apache 
2.0
 commons-dbcp 1.4: https://github.com/apache/commons-dbcp, Apache 2.0
 commons-email 1.5: https://github.com/apache/commons-email, Apache 2.0
 commons-httpclient 3.0.1: 
https://mvnrepository.com/artifact/commons-httpclient/commons-httpclient/3.0.1, 
Apache 2.0
@@ -275,7 +275,7 @@ The text of each license is also included at 
licenses/LICENSE-[project].txt.
 guava 20.0: 
https://mvnrepository.com/artifact/com.google.guava/guava/20.0, Apache 2.0
 guice 3.0: https://mvnrepository.com/artifact/com.google.inject/guice/3.0, 
Apache 2.0
 guice-servlet 3.0: 
https://mvnrepository.com/artifact/com.google.inject.extensions/guice-servlet/3.0,
 Apache 2.0
-hadoop-annotations 
2.7.3:https://mvnrepository.com/artifact/org.apache.hadoop/hadoop-annotations/2.7.3,
 Apache 2.0
+hadoop-annotations 2.7.3: 
https://mvnrepository.com/artifact/org.apache.hadoop/hadoop-annotations/2.7.3, 
Apache 2.0
 hadoop-auth 2.7.3: 
https://mvnrepository.com/artifact/org.apache.hadoop/hadoop-auth/2.7.3, Apache 
2.0
 hadoop-aws 2.7.3: 
https://mvnrepository.com/artifact/org.apache.hadoop/hadoop-aws/2.7.3, Apache 
2.0
 hadoop-client 2.7.3: 
https://mvnrepository.com/artifact/org.apache.hadoop/hadoop-client/2.7.3, 
Apache 2.0
@@ -348,7 +348,7 @@ The text of each license is also included at 
licenses/LICENSE-[project].txt.
 log4j-1.2-api 2.11.2: 
https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-1.2-api/2.11.2,
 Apache 2.0
 lz4 1.3.0: https://mvnrepository.com/artifact/net.jpountz.lz4/lz4/1.3.0, 
Apache 2.0
 mapstruct 1.2.0.Final: https://github.com/mapstruct/mapstruct, Apache 2.0
-mybatis 3.5.2 
https://mvnrepository.com/artifact/org.mybatis/mybatis/3.5.2, Apache 2.0
+mybatis 3.5.2: 
https://mvnrepository.com/artifact/org.mybatis/mybatis/3.5.2, Apache 2.0
 mybatis-plus 3.2.0: https://github.com/baomidou/mybatis-plus, Apache 2.0
 mybatis-plus-annotation 3.2.0: 
https://mvnrepository.com/artifact/com.baomidou/mybatis-plus-annotation/3.2.0, 
Apache 2.0
 mybatis-plus-boot-starter 3.2.0: 
https://mvnrepository.com/artifact/com.baomidou/mybatis-plus-boot-starter/3.2.0,
 Apache 2.0
@@ -444,7 +444,7 @@ CDDL licenses
 The following components are provided under the CDDL License. See project link 
for details.
 The text of each license is also included at licenses/LICENSE-[project].txt.
 
-activation 1.1: 
https://mvnrepository.com/artifact/javax.activation/activation/1.1 CDDL 1.0
+activation 1.1: 
https://mvnrepository.com/artifact/javax.activation/activation/1.1, CDDL 1.0
 javax.activation-api 1.2.0: 
https://mvnrepository.com/artifact/javax.activation/javax.activation-api/1.2.0, 
CDDL and LGPL 2.0
 javax.annotation-api 1.3.2: 
https://mvnrepository.com/artifact/javax.annotation/javax.annotation-api/1.3.2, 
CDDL + GPLv2
 javax.mail 1.6.2: 
https://mvnrepository.com/artifact/com.sun.mail/javax.mail/1.6.2, CDDL/GPLv2
@@ -467,7 +467,7 @@ EPL licenses
 The following components are provided under the EPL License. See project link 
for details.
 The text of each license is also included at licenses/LICENSE-[project].txt.
 
-aspectjweaver 
1.9.2:https://mvnrepository.com/artifact/org.aspectj/aspectjweaver/1.9.2, EPL 
1.0
+aspectjweaver 1.9.2: 
https://mvnrepos

[GitHub] [incubator-dolphinscheduler] huzhengfei001 opened a new issue #1553: [QUESTION] question title

2019-12-24 Thread GitBox
huzhengfei001 opened a new issue #1553: [QUESTION] question title
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1553
 
 
   1. Whether the workflow of HTTP interface is supported now   
2. The "groups" name does not exist when debugging the workserver. Do you 
support windows


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #1547: [Feature] node text edit box supports full-screen magnification(节点文本编辑框支持全屏放大)

2019-12-24 Thread GitBox
xingchun-chen commented on issue #1547: [Feature] node text edit box supports 
full-screen magnification(节点文本编辑框支持全屏放大)
URL: 
https://github.com/apache/incubator-dolphinscheduler/issues/1547#issuecomment-568705954
 
 
   Yes, the experience can indeed be optimized,thank you very much
    
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] Nivane opened a new pull request #1554: fix 'directory' spell bug

2019-12-24 Thread GitBox
Nivane opened a new pull request #1554: fix 'directory' spell bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1554
 
 
   ## What is the purpose of the pull request
   
This pull request fixes a spell bug
   
   ## Brief change log
   
 - fix directory spell bug
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] zhangdehai commented on issue #1476: dolphinscheduler version:1.2.0,start API in idea,Invalid server.port specified in application-dao.properties file,The startup

2019-12-24 Thread GitBox
zhangdehai commented on issue #1476: dolphinscheduler version:1.2.0,start API 
in idea,Invalid server.port specified in application-dao.properties file,The 
startup log is as follows:
URL: 
https://github.com/apache/incubator-dolphinscheduler/issues/1476#issuecomment-568710816
 
 
   very very


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] zhangdehai closed issue #1476: dolphinscheduler version:1.2.0,start API in idea,Invalid server.port specified in application-dao.properties file,The startup log i

2019-12-24 Thread GitBox
zhangdehai closed issue #1476: dolphinscheduler version:1.2.0,start API in 
idea,Invalid server.port specified in application-dao.properties file,The 
startup log is as follows:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1476
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1554: fix 'directory' spell bug

2019-12-24 Thread GitBox
codecov-io commented on issue #1554: fix 'directory' spell bug
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1554#issuecomment-568711726
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1554?src=pr&el=h1)
 Report
   > Merging 
[#1554](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1554?src=pr&el=desc)
 into 
[dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/57aafc1507d59190d826d92e1801d76cd608276f?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1554/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1554?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## dev   #1554   +/-   ##
   =
 Coverage   7.79%   7.79%   
   =
 Files272 272   
 Lines  13641   13641   
 Branches21662166   
   =
 Hits10631063   
 Misses 12506   12506   
 Partials  72  72
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1554?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...g/apache/dolphinscheduler/common/model/Server.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1554/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL1NlcnZlci5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1554?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1554?src=pr&el=footer).
 Last update 
[57aafc1...88a7235](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1554?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1555: 1.2.0 release

2019-12-24 Thread GitBox
break60 opened a new pull request #1555: 1.2.0 release
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1555
 
 
   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review 
https://dolphinscheduler.apache.org/en-us/community/index.html before opening a 
pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds checkstyle plugin.)*
   
   ## Brief change log
   
   *(for example:)*
 - *Add maven-checkstyle-plugin to root pom.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please 
describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
 - *Added dolphinscheduler-dao tests for end-to-end.*
 - *Added CronUtilsTest to verify the change.*
 - *Manually verified the change by testing locally.*
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1556: Repair license

2019-12-24 Thread GitBox
break60 opened a new pull request #1556: Repair license
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1556
 
 
   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review 
https://dolphinscheduler.apache.org/en-us/community/index.html before opening a 
pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds checkstyle plugin.)*
   
   ## Brief change log
   
   *(for example:)*
 - *Add maven-checkstyle-plugin to root pom.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please 
describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
 - *Added dolphinscheduler-dao tests for end-to-end.*
 - *Added CronUtilsTest to verify the change.*
 - *Manually verified the change by testing locally.*
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1556: Repair license

2019-12-24 Thread GitBox
codecov-io commented on issue #1556: Repair license
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1556#issuecomment-568715855
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1556?src=pr&el=h1)
 Report
   > Merging 
[#1556](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1556?src=pr&el=desc)
 into 
[dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/57aafc1507d59190d826d92e1801d76cd608276f?src=pr&el=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1556/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1556?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff@@
   ## dev   #1556  +/-   ##
   
   - Coverage   7.79%   7.77%   -0.02% 
   
 Files272 272  
 Lines  13641   13641  
 Branches21662166  
   
   - Hits10631061   -2 
   - Misses 12506   12508   +2 
 Partials  72  72
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1556?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...ache/dolphinscheduler/common/enums/ZKNodeType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1556/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1pLTm9kZVR5cGUuamF2YQ==)
 | `0% <0%> (-100%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1556?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1556?src=pr&el=footer).
 Last update 
[57aafc1...13c1d57](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1556?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1556: Repair license

2019-12-24 Thread GitBox
lgcareer merged pull request #1556: Repair license
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1556
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-dolphinscheduler] branch dev updated (57aafc1 -> 93b2235)

2019-12-24 Thread lgcareer
This is an automated email from the ASF dual-hosted git repository.

lgcareer pushed a change to branch dev
in repository 
https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git.


from 57aafc1  Front-end supplemental license (#1548)
 add 93b2235  Repair license (#1556)

No new revisions were added by this update.

Summary of changes:
 dolphinscheduler-dist/release-docs/LICENSE| 4 ++--
 .../licenses/ui-licenses/{LICENSE-jquery-ui.txt => LICENSE-jquery-ui} | 0
 2 files changed, 2 insertions(+), 2 deletions(-)
 rename 
dolphinscheduler-dist/release-docs/licenses/ui-licenses/{LICENSE-jquery-ui.txt 
=> LICENSE-jquery-ui} (100%)



[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in 
/escheduler-ui/src/lib/@fedor/io
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1231#issuecomment-568718872
 
 
   Dependabot tried to update this pull request, but something went wrong. 
We're looking into it, but in the meantime you can retry the update by 
commenting `@dependabot rebase`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in 
/escheduler-ui
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1232#issuecomment-568718870
 
 
   Dependabot tried to update this pull request, but something went wrong. 
We're looking into it, but in the meantime you can retry the update by 
commenting `@dependabot rebase`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in 
/escheduler-ui
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1230#issuecomment-568718869
 
 
   Dependabot tried to update this pull request, but something went wrong. 
We're looking into it, but in the meantime you can retry the update by 
commenting `@dependabot rebase`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-dolphinscheduler] branch dev updated: fix 'directory' spell bug

2019-12-24 Thread technoboy
This is an automated email from the ASF dual-hosted git repository.

technoboy pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
 new 88a7235  fix 'directory' spell bug
 new 553c88a  Merge pull request #1554 from Nivane/dev
88a7235 is described below

commit 88a7235ee2c75da48d393b06636eb926b12fc0e9
Author: lipan.zhao 
AuthorDate: Tue Dec 24 17:40:05 2019 +0800

fix 'directory' spell bug
---
 .../src/main/java/org/apache/dolphinscheduler/common/model/Server.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/model/Server.java
 
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/model/Server.java
index 29c96c1..706609d 100644
--- 
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/model/Server.java
+++ 
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/model/Server.java
@@ -40,7 +40,7 @@ public class Server {
 private int port;
 
 /**
- * master direcotry in zookeeper
+ * master directory in zookeeper
  */
 private String zkDirectory;
 



[GitHub] [incubator-dolphinscheduler] Technoboy- merged pull request #1554: fix 'directory' spell bug

2019-12-24 Thread GitBox
Technoboy- merged pull request #1554: fix 'directory' spell bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1554
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-dolphinscheduler] branch 1.2.0-release updated: 1.2.0 release (#1555)

2019-12-24 Thread lgcareer
This is an automated email from the ASF dual-hosted git repository.

lgcareer pushed a commit to branch 1.2.0-release
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git


The following commit(s) were added to refs/heads/1.2.0-release by this push:
 new f167d53  1.2.0 release (#1555)
f167d53 is described below

commit f167d5368265aa30d65c218d5703a5f86f9f2a46
Author: break60 <790061...@qq.com>
AuthorDate: Tue Dec 24 19:20:09 2019 +0800

1.2.0 release (#1555)

* Front-end compliance modification

* Front-end supplemental license

* Modify naming

* Repair license
---
 .../dolphinscheduler-front/src/main/release-docs/LICENSE  | 4 ++--
 .../licenses/{LICENSE-jquery-ui.txt => LICENSE-jquery-ui} | 0
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/LICENSE 
b/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/LICENSE
index b1b917b..43330d3 100644
--- a/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/LICENSE
+++ b/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/LICENSE
@@ -211,7 +211,7 @@ licenses.
 
 MIT licenses
 
-ans-UI 0.0.22: https://github.com/analysys/ans-ui MIT
+ans-UI 1.1.7: https://github.com/analysys/ans-ui MIT
 axios 0.16.2: https://github.com/axios/axios MIT
 bootstrap 3.3.7: https://github.com/twbs/bootstrap MIT
 canvg 1.5.1: https://github.com/canvg/canvg MIT
@@ -219,7 +219,7 @@ MIT licenses
 codemirror 5.43.0: https://github.com/codemirror/CodeMirror MIT
 dayjs 1.7.8: https://github.com/iamkun/dayjs MIT
 html2canvas 0.5.0-beta4: https://github.com/niklasvh/html2canvas MIT
-jquery 1.12.4: https://github.com/jquery/jquery MIT
+jquery 3.3.1: https://github.com/jquery/jquery MIT
 jquery-ui 1.12.1: https://github.com/jquery/jquery-ui MIT
 jsplumb 2.8.6: https://github.com/jsplumb/jsplumb MIT and GPLv2
 lodash 4.17.11: https://github.com/lodash/lodash MIT
diff --git 
a/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-jquery-ui.txt
 
b/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-jquery-ui
similarity index 100%
rename from 
dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-jquery-ui.txt
rename to 
dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-jquery-ui



[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1555: front-end add LICENSE

2019-12-24 Thread GitBox
lgcareer merged pull request #1555: front-end add LICENSE
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1555
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] nauu opened a new pull request #1557: Add FlinkArgsUtilsTest which is the UT of FlinkArgsUtils

2019-12-24 Thread GitBox
nauu opened a new pull request #1557: Add FlinkArgsUtilsTest which is the UT of 
FlinkArgsUtils
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1557
 
 
   ## What is the purpose of the pull request
   
   For #1465.
   
   1. Add FlinkArgsUtilsTest
   2. Optimize FlinkArgsUtils and fix bug, use StringUtils.isNotEmpty(queue) 
instead of StringUtils.isNotEmpty(others)
   
   3. Add the UT path in pom
   
   ## Brief change log
   
 - *Add FlinkArgsUtilsTest.java*
 - *Edit FlinkArgsUtils.java*
 - *Add UT path to root pom.xml*
   
   ## Verify this pull request
   
   This change added tests and can be verified as follows:
   
 - *Added FlinkArgsUtilsTest to verify the change.*
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] keduw opened a new issue #1558: [BUG] add dependency exceptions

2019-12-24 Thread GitBox
keduw opened a new issue #1558: [BUG] add dependency exceptions
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1558
 
 
   An option exception occurs when a dependency is added and removed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1557: Add FlinkArgsUtilsTest which is the UT of FlinkArgsUtils

2019-12-24 Thread GitBox
codecov-io commented on issue #1557: Add FlinkArgsUtilsTest which is the UT of 
FlinkArgsUtils
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1557#issuecomment-568733074
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557?src=pr&el=h1)
 Report
   > :exclamation: No coverage uploaded for pull request base (`dev@79ac38a`). 
[Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## dev   #1557   +/-   ##
   =
 Coverage   ?   8.13%   
   =
 Files  ? 272   
 Lines  ?   13649   
 Branches   ?2163   
   =
 Hits   ?1110   
 Misses ?   12462   
 Partials   ?  77
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../org/apache/dolphinscheduler/api/enums/Status.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2VudW1zL1N0YXR1cy5qYXZh)
 | `100% <ø> (ø)` | |
   | 
[...g/apache/dolphinscheduler/common/model/Server.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL1NlcnZlci5qYXZh)
 | `0% <ø> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557?src=pr&el=footer).
 Last update 
[79ac38a...949c468](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] Nivane opened a new pull request #1559: fix typos

2019-12-24 Thread GitBox
Nivane opened a new pull request #1559: fix typos
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1559
 
 
   ## What is the purpose of the pull request
   
   fix typos
   
   ## Brief change log
   
   fix typos in comments and strings
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1559: fix typos

2019-12-24 Thread GitBox
codecov-io commented on issue #1559: fix typos
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1559#issuecomment-568735703
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1559?src=pr&el=h1)
 Report
   > Merging 
[#1559](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1559?src=pr&el=desc)
 into 
[dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/553c88ae3c92bd6610dd40632465114a0ed09d42?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1559/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1559?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## dev   #1559   +/-   ##
   =
 Coverage   7.79%   7.79%   
   =
 Files272 272   
 Lines  13641   13641   
 Branches21662166   
   =
 Hits10631063   
 Misses 12506   12506   
 Partials  72  72
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1559?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...dolphinscheduler/common/enums/ExecutionStatus.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1559/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0V4ZWN1dGlvblN0YXR1cy5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...olphinscheduler/common/enums/TaskRecordStatus.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1559/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Rhc2tSZWNvcmRTdGF0dXMuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...che/dolphinscheduler/common/enums/CommandType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1559/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0NvbW1hbmRUeXBlLmphdmE=)
 | `0% <0%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1559?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1559?src=pr&el=footer).
 Last update 
[553c88a...d7fc79c](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1559?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] khadgarmage opened a new issue #1560: [CI/CD]Support docker compose and deploy the docker on github action

2019-12-24 Thread GitBox
khadgarmage opened a new issue #1560: [CI/CD]Support docker compose and deploy 
the docker on github action
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1560
 
 
   Track the root issue #1460 
   * Support docker compose, split into several different services, refer to: 
https://github.com/apache/skywalking/tree/master/docker
   * Deploy the servers on github action and check service availability, refer 
to:
   
https://github.com/apache/skywalking/blob/master/.github/workflows/docker-ci.yaml
   
   if you want to contribute, you may reply  "i want to implement it"
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] silvermissile commented on issue #546: EasyScheduler supports LDAP authentication, and Hive supports LDAP authentication.(EasyScheduler支持LDAP认证, Hive等连接支持LDAP认证)

2019-12-24 Thread GitBox
silvermissile commented on issue #546: EasyScheduler supports LDAP 
authentication, and Hive supports LDAP authentication.(EasyScheduler支持LDAP认证, 
Hive等连接支持LDAP认证)
URL: 
https://github.com/apache/incubator-dolphinscheduler/issues/546#issuecomment-568747570
 
 
   ladp is deeply depended in my bigdata ecosystem


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1532: fix MasterBaseTaskExecThread submit method bug

2019-12-24 Thread GitBox
Technoboy- commented on a change in pull request #1532: fix 
MasterBaseTaskExecThread submit method bug
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1532#discussion_r361170732
 
 

 ##
 File path: 
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java
 ##
 @@ -74,6 +74,9 @@ public TaskInstance getTaskInstance(){
 public Boolean submitWaitComplete() {
 Boolean result = false;
 this.taskInstance = submit();
+if(this.taskInstance == null){
+return result;
 
 Review comment:
   yes, I debug for submit fail test, process will end and be a failure state.
   it is satisfied the result.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1532: fix MasterBaseTaskExecThread submit method bug

2019-12-24 Thread GitBox
codecov-io edited a comment on issue #1532: fix MasterBaseTaskExecThread submit 
method bug
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1532#issuecomment-567894912
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532?src=pr&el=h1)
 Report
   > Merging 
[#1532](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532?src=pr&el=desc)
 into 
[dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/99fc87f9116f871fa89d985731fb579f0f41aa17?src=pr&el=desc)
 will **increase** coverage by `0.38%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff@@
   ## dev   #1532  +/-   ##
   
   + Coverage7.4%   7.78%   +0.38% 
   
 Files272 272  
 Lines  13643   13646   +3 
 Branches21702168   -2 
   
   + Hits10101063  +53 
   + Misses 12566   12511  -55 
   - Partials  67  72   +5
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...ler/server/master/runner/MasterTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyVGFza0V4ZWNUaHJlYWQuamF2YQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...server/master/runner/MasterBaseTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyQmFzZVRhc2tFeGVjVGhyZWFkLmphdmE=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...pache/dolphinscheduler/common/utils/FileUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0ZpbGVVdGlscy5qYXZh)
 | `18.47% <0%> (+1.64%)` | :arrow_up: |
   | 
[...apache/dolphinscheduler/api/enums/ExecuteType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2VudW1zL0V4ZWN1dGVUeXBlLmphdmE=)
 | `66.66% <0%> (+66.66%)` | :arrow_up: |
   | 
[.../dolphinscheduler/server/utils/SparkArgsUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1NwYXJrQXJnc1V0aWxzLmphdmE=)
 | `92.15% <0%> (+92.15%)` | :arrow_up: |
   | 
[...ache/dolphinscheduler/common/enums/ZKNodeType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1pLTm9kZVR5cGUuamF2YQ==)
 | `100% <0%> (+100%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532?src=pr&el=footer).
 Last update 
[99fc87f...16c29a0](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1532: fix MasterBaseTaskExecThread submit method bug

2019-12-24 Thread GitBox
qiaozhanwei merged pull request #1532: fix MasterBaseTaskExecThread submit 
method bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1532
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-dolphinscheduler] branch dev updated (553c88a -> 26d9893)

2019-12-24 Thread journey
This is an automated email from the ASF dual-hosted git repository.

journey pushed a change to branch dev
in repository 
https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git.


from 553c88a  Merge pull request #1554 from Nivane/dev
 add 26d9893  fix MasterBaseTaskExecThread submit method bug (#1532)

No new revisions were added by this update.

Summary of changes:
 .../master/runner/MasterBaseTaskExecThread.java| 26 +++---
 .../server/master/runner/MasterTaskExecThread.java |  4 
 2 files changed, 17 insertions(+), 13 deletions(-)



[incubator-dolphinscheduler] branch dev updated (26d9893 -> 5cc82c5)

2019-12-24 Thread journey
This is an automated email from the ASF dual-hosted git repository.

journey pushed a change to branch dev
in repository 
https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git.


from 26d9893  fix MasterBaseTaskExecThread submit method bug (#1532)
 add 5cc82c5  remove master server and worker server listening port 
(5566、7788) (#1551)

No new revisions were added by this update.

Summary of changes:
 .../java/org/apache/dolphinscheduler/api/ApiApplicationServer.java   | 1 -
 .../api/configuration/ServiceModelToSwagger2MapperImpl.java  | 3 ++-
 .../org/apache/dolphinscheduler/api/configuration/SwaggerConfig.java | 2 ++
 .../java/org/apache/dolphinscheduler/server/master/MasterServer.java | 5 +++--
 .../java/org/apache/dolphinscheduler/server/worker/WorkerServer.java | 5 +++--
 .../src/main/resources/application-master.properties | 5 +
 .../src/main/resources/application-worker.properties | 3 ---
 7 files changed, 11 insertions(+), 13 deletions(-)



[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1551: remove master server and worker server listening port (5566、7788)

2019-12-24 Thread GitBox
qiaozhanwei merged pull request #1551: remove master server and worker server 
listening port (5566、7788)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1551
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] blackberrier commented on issue #57: Wanted: Who is using DolphinScheduler

2019-12-24 Thread GitBox
blackberrier commented on issue #57: Wanted: Who is using DolphinScheduler
URL: 
https://github.com/apache/incubator-dolphinscheduler/issues/57#issuecomment-568755614
 
 
   组织:华为
   地点:中国杭州
   联系方式:2232076...@qq.com
   场景:调研大数据平台的任务调度系统


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] Yeleights commented on a change in pull request #1542: #1300 Add right alignment function in sql email content

2019-12-24 Thread GitBox
Yeleights commented on a change in pull request #1542: #1300 Add right 
alignment function in sql email content
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1542#discussion_r361172872
 
 

 ##
 File path: 
dolphinscheduler-alert/src/main/resources/mail_templates/alert_mail_template.ftl
 ##
 @@ -14,4 +14,40 @@
   ~ See the License for the specific language governing permissions and
   ~ limitations under the License.
 -->
-http://www.w3.org/TR/html4/loose.dtd'> 
dolphinschedulertable {
margin-top:0px;padding-top:0px;border:1px solid;
font-size: 14px;color: #33;border-width: 1px;   
 border-color: #66;border-collapse: collapse;}  
  table th {border-width: 1px;padding: 8px; 
   border-style: solid;border-color: #66;
background-color: #dedede;}table td {border-width: 
1px;padding: 8px;border-style: solid;
border-color: #66;background-color: #ff;
}<#if title??> 
${title}<#if content??> ${content}
\ No newline at end of file
+http://www.w3.org/TR/html4/loose.dtd'>
 
 Review comment:
   I cancel format file: alert.resources.mail_templates.alert_mail_template.ftl


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1541: remove duplicated code

2019-12-24 Thread GitBox
Technoboy- commented on issue #1541: remove duplicated code
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568755894
 
 
   > > > > > > how about keeping the code the same ?
   > > > > > > like : add TableField in Alert class
   > > > > > 
   > > > > > 
   > > > > > I don't know,@TableField annotation,It is need to retain? i think 
it's can remove for this project
   > > > > 
   > > > > 
   > > > > why did you keep it in AccessToken? I think we should keep the same 
manager .
   > > > 
   > > > 
   > > > this project has @TableField annotation already, I didn't add it
   > > 
   > > 
   > > I mean : try to add @TableField in Alert class to keep code in the same 
style.
   > 
   > ok!
   
   Hi, bro,  did you need any help ? you can send me a email


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] Technoboy- edited a comment on issue #1541: remove duplicated code

2019-12-24 Thread GitBox
Technoboy- edited a comment on issue #1541: remove duplicated code
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568755894
 
 
   > > > > > > how about keeping the code the same ?
   > > > > > > like : add TableField in Alert class
   > > > > > 
   > > > > > 
   > > > > > I don't know,@TableField annotation,It is need to retain? i think 
it's can remove for this project
   > > > > 
   > > > > 
   > > > > why did you keep it in AccessToken? I think we should keep the same 
manager .
   > > > 
   > > > 
   > > > this project has @TableField annotation already, I didn't add it
   > > 
   > > 
   > > I mean : try to add @TableField in Alert class to keep code in the same 
style.
   > 
   > ok!
   
   Hi, bro,  did you need any help ? you can send me an email


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-dolphinscheduler] branch dev updated: fix typos

2019-12-24 Thread technoboy
This is an automated email from the ASF dual-hosted git repository.

technoboy pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
 new d7fc79c  fix typos
 new 613e96e  Merge pull request #1559 from Nivane/dev
d7fc79c is described below

commit d7fc79c8fb1c7f09470c78d164b017e93d5b7821
Author: lipan.zhao 
AuthorDate: Tue Dec 24 19:58:56 2019 +0800

fix typos
---
 .../main/java/org/apache/dolphinscheduler/common/enums/CommandType.java | 2 +-
 .../java/org/apache/dolphinscheduler/common/enums/ExecutionStatus.java  | 2 +-
 .../java/org/apache/dolphinscheduler/common/enums/TaskRecordStatus.java | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/CommandType.java
 
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/CommandType.java
index d6ba6e3..352f6ef 100644
--- 
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/CommandType.java
+++ 
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/CommandType.java
@@ -49,7 +49,7 @@ public enum CommandType {
 REPEAT_RUNNING(7, "repeat running a process"),
 PAUSE(8, "pause a process"),
 STOP(9, "stop a process"),
-RECOVER_WAITTING_THREAD(10, "recover waitting thread");
+RECOVER_WAITTING_THREAD(10, "recover waiting thread");
 
 CommandType(int code, String descp){
 this.code = code;
diff --git 
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ExecutionStatus.java
 
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ExecutionStatus.java
index e86991f..f29b8a5 100644
--- 
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ExecutionStatus.java
+++ 
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ExecutionStatus.java
@@ -21,7 +21,7 @@ import com.baomidou.mybatisplus.annotation.EnumValue;
 import lombok.Getter;
 
 /**
- * runing status for workflow and task nodes
+ * running status for workflow and task nodes
  *
  */
 @Getter
diff --git 
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/TaskRecordStatus.java
 
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/TaskRecordStatus.java
index b3d5426..842fd75 100644
--- 
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/TaskRecordStatus.java
+++ 
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/TaskRecordStatus.java
@@ -25,7 +25,7 @@ public enum TaskRecordStatus {
 
 /**
  * status:
- * 0 sucess
+ * 0 success
  * 1 failure
  * 2 exception
  */



[GitHub] [incubator-dolphinscheduler] Technoboy- merged pull request #1559: fix typos

2019-12-24 Thread GitBox
Technoboy- merged pull request #1559: fix typos
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1559
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] elonlo commented on issue #546: EasyScheduler supports LDAP authentication, and Hive supports LDAP authentication.(EasyScheduler支持LDAP认证, Hive等连接支持LDAP认证)

2019-12-24 Thread GitBox
elonlo commented on issue #546: EasyScheduler supports LDAP authentication, and 
Hive supports LDAP authentication.(EasyScheduler支持LDAP认证, Hive等连接支持LDAP认证)
URL: 
https://github.com/apache/incubator-dolphinscheduler/issues/546#issuecomment-568766113
 
 
   I will implement ldap login authentication later


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1561: replace cookie.js with js-cookie, add js-cookie license

2019-12-24 Thread GitBox
break60 opened a new pull request #1561: replace cookie.js with js-cookie, add 
js-cookie license
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1561
 
 
   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review 
https://dolphinscheduler.apache.org/en-us/community/index.html before opening a 
pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds checkstyle plugin.)*
   
   ## Brief change log
   
   *(for example:)*
 - *Add maven-checkstyle-plugin to root pom.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please 
describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
 - *Added dolphinscheduler-dao tests for end-to-end.*
 - *Added CronUtilsTest to verify the change.*
 - *Manually verified the change by testing locally.*
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1562: replace cookie.js with js-cookie, add js-cookie license

2019-12-24 Thread GitBox
break60 opened a new pull request #1562: replace cookie.js with js-cookie, add 
js-cookie license
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1562
 
 
   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review 
https://dolphinscheduler.apache.org/en-us/community/index.html before opening a 
pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds checkstyle plugin.)*
   
   ## Brief change log
   
   *(for example:)*
 - *Add maven-checkstyle-plugin to root pom.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please 
describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
 - *Added dolphinscheduler-dao tests for end-to-end.*
 - *Added CronUtilsTest to verify the change.*
 - *Manually verified the change by testing locally.*
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1561: replace cookie.js with js-cookie, add js-cookie license

2019-12-24 Thread GitBox
codecov-io commented on issue #1561: replace cookie.js with js-cookie, add 
js-cookie license
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1561#issuecomment-568819771
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1561?src=pr&el=h1)
 Report
   > Merging 
[#1561](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1561?src=pr&el=desc)
 into 
[dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/31d0a71006e836a535f91b987d43c3cecc53a62a?src=pr&el=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1561/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1561?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff@@
   ## dev   #1561  +/-   ##
   
   - Coverage   7.79%   7.78%   -0.01% 
   
 Files272 272  
 Lines  13641   13646   +5 
 Branches21662168   +2 
   
 Hits10631063  
   - Misses 12506   12511   +5 
 Partials  72  72
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1561?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...e/dolphinscheduler/server/worker/WorkerServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1561/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9Xb3JrZXJTZXJ2ZXIuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...onfiguration/ServiceModelToSwagger2MapperImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1561/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbmZpZ3VyYXRpb24vU2VydmljZU1vZGVsVG9Td2FnZ2VyMk1hcHBlckltcGwuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...g/apache/dolphinscheduler/common/model/Server.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1561/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL1NlcnZlci5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...che/dolphinscheduler/api/ApiApplicationServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1561/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL0FwaUFwcGxpY2F0aW9uU2VydmVyLmphdmE=)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...phinscheduler/api/configuration/SwaggerConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1561/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbmZpZ3VyYXRpb24vU3dhZ2dlckNvbmZpZy5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...dolphinscheduler/common/enums/ExecutionStatus.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1561/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0V4ZWN1dGlvblN0YXR1cy5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...olphinscheduler/common/enums/TaskRecordStatus.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1561/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Rhc2tSZWNvcmRTdGF0dXMuamF2YQ==)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...e/dolphinscheduler/server/master/MasterServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1561/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9NYXN0ZXJTZXJ2ZXIuamF2YQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...server/master/runner/MasterBaseTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1561/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyQmFzZVRhc2tFeGVjVGhyZWFkLmphdmE=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...ler/server/master/runner/MasterTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1561/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyVGFza0V4ZWNUaHJlYWQuamF2YQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | ... and [1 
more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1561/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-

[GitHub] [incubator-dolphinscheduler] clay4444 commented on a change in pull request #1537: refactor zk client and zk config module

2019-12-24 Thread GitBox
clay commented on a change in pull request #1537: refactor zk client and zk 
config module
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1537#discussion_r361240166
 
 

 ##
 File path: 
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/zk/ZookeeperCachedOperator.java
 ##
 @@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dolphinscheduler.common.zk;
+
+import org.apache.curator.framework.recipes.cache.ChildData;
+import org.apache.curator.framework.recipes.cache.TreeCache;
+import org.apache.curator.framework.recipes.cache.TreeCacheListener;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.stereotype.Component;
+
+import java.nio.charset.StandardCharsets;
+import java.util.concurrent.ConcurrentHashMap;
+
+import static org.apache.dolphinscheduler.common.utils.Preconditions.*;
+import static 
org.apache.dolphinscheduler.common.utils.Preconditions.checkNotNull;
+
+@Component
+public class ZookeeperCachedOperator extends ZookeeperOperator {
+
+private final Logger logger = 
LoggerFactory.getLogger(ZookeeperCachedOperator.class);
+
+//kay is zk path, value is TreeCache
+private ConcurrentHashMap allCaches = new 
ConcurrentHashMap<>();
+
+/**
+ * @param cachePath zk path
+ * @param listener  operator
+ */
+public void registerListener(final String cachePath, final 
TreeCacheListener listener) {
 
 Review comment:
   yeah, I get it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1562: replace cookie.js with js-cookie, add js-cookie license

2019-12-24 Thread GitBox
lgcareer merged pull request #1562: replace cookie.js with js-cookie, add 
js-cookie license
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1562
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-dolphinscheduler] branch 1.2.0-release updated: replace cookie.js with js-cookie, add js-cookie license (#1562)

2019-12-24 Thread lgcareer
This is an automated email from the ASF dual-hosted git repository.

lgcareer pushed a commit to branch 1.2.0-release
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git


The following commit(s) were added to refs/heads/1.2.0-release by this push:
 new 449f83e  replace cookie.js with js-cookie, add js-cookie license 
(#1562)
449f83e is described below

commit 449f83ed2fec5a6d449efe44fd9670a09bbee864
Author: break60 <790061...@qq.com>
AuthorDate: Wed Dec 25 10:30:43 2019 +0800

replace cookie.js with js-cookie, add js-cookie license (#1562)

* Front-end compliance modification

* Front-end supplemental license

* Modify naming

* Repair license

* replace cookie.js with js-cookie, add js-cookie license
---
 .../src/main/release-docs/LICENSE  |  1 +
 .../main/release-docs/licenses/LICENSE-js-cookie   | 21 ++
 dolphinscheduler-ui/package.json   |  1 +
 .../pages/dag/_source/formModel/tasks/http.vue |  4 +-
 dolphinscheduler-ui/src/js/conf/login/App.vue  |  4 +-
 .../src/js/module/components/nav/nav.vue   |  6 +-
 dolphinscheduler-ui/src/js/module/i18n/index.js|  8 +-
 dolphinscheduler-ui/src/js/module/io/index.js  |  4 +-
 dolphinscheduler-ui/src/js/module/util/cookie.js   | 88 --
 9 files changed, 36 insertions(+), 101 deletions(-)

diff --git 
a/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/LICENSE 
b/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/LICENSE
index 43330d3..16b13ba 100644
--- a/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/LICENSE
+++ b/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/LICENSE
@@ -221,6 +221,7 @@ MIT licenses
 html2canvas 0.5.0-beta4: https://github.com/niklasvh/html2canvas MIT
 jquery 3.3.1: https://github.com/jquery/jquery MIT
 jquery-ui 1.12.1: https://github.com/jquery/jquery-ui MIT
+js-cookie 2.2.1: https://github.com/js-cookie/js-cookie MIT
 jsplumb 2.8.6: https://github.com/jsplumb/jsplumb MIT and GPLv2
 lodash 4.17.11: https://github.com/lodash/lodash MIT
 vue2.5.17: https://github.com/vuejs/vueMIT
diff --git 
a/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-js-cookie
 
b/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-js-cookie
new file mode 100644
index 000..69ed677
--- /dev/null
+++ 
b/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-js-cookie
@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2018 Copyright 2018 Klaus Hartl, Fagner Brack, GitHub 
Contributors
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
\ No newline at end of file
diff --git a/dolphinscheduler-ui/package.json b/dolphinscheduler-ui/package.json
index 748521b..1a3fcef 100644
--- a/dolphinscheduler-ui/package.json
+++ b/dolphinscheduler-ui/package.json
@@ -23,6 +23,7 @@
 "html2canvas": "^0.5.0-beta4",
 "jquery": "3.3.1",
 "jquery-ui": "^1.12.1",
+"js-cookie": "^2.2.1",
 "jsplumb": "^2.8.6",
 "lodash": "^4.17.11",
 "vue": "^2.5.17",
diff --git 
a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/http.vue
 
b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/http.vue
index 2617c44..adb5441 100644
--- 
a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/http.vue
+++ 
b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/http.vue
@@ -101,7 +101,7 @@
 

[incubator-dolphinscheduler] branch dev updated: replace cookie.js with js-cookie, add js-cookie license (#1561)

2019-12-24 Thread lgcareer
This is an automated email from the ASF dual-hosted git repository.

lgcareer pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
 new b4daa85  replace cookie.js with js-cookie, add js-cookie license 
(#1561)
b4daa85 is described below

commit b4daa85f20aa08006401a51f18ea94686acd093a
Author: break60 <790061...@qq.com>
AuthorDate: Wed Dec 25 10:32:17 2019 +0800

replace cookie.js with js-cookie, add js-cookie license (#1561)

* Password verification and v-for add key

* DAG automatic layout

* combo.js replacement

* combo.js replacement

* webpack upgrade to 4

* packjson has a file name that has not changed

* Solve jertty packing garbled

* Modify dashboard color

* Remove iconfont, awesome, replace with ans-ui icon

* Menu arrow style fix

* Script input box style fix

* console.log('Front-end third-party js, css introduced using npm

* Front-end supplemental license

* Modify naming

* Repair license

* replace cookie.js with js-cookie, add js-cookie license
---
 dolphinscheduler-dist/release-docs/LICENSE |  1 +
 .../licenses/ui-licenses/LICENSE-js-cookie | 21 ++
 dolphinscheduler-ui/package.json   |  1 +
 .../pages/dag/_source/formModel/tasks/http.vue |  4 +-
 dolphinscheduler-ui/src/js/conf/login/App.vue  |  4 +-
 .../src/js/module/components/nav/nav.vue   |  6 +-
 dolphinscheduler-ui/src/js/module/i18n/index.js|  8 +-
 dolphinscheduler-ui/src/js/module/io/index.js  |  4 +-
 dolphinscheduler-ui/src/js/module/util/cookie.js   | 88 --
 9 files changed, 36 insertions(+), 101 deletions(-)

diff --git a/dolphinscheduler-dist/release-docs/LICENSE 
b/dolphinscheduler-dist/release-docs/LICENSE
index 3341cc6..97946d1 100644
--- a/dolphinscheduler-dist/release-docs/LICENSE
+++ b/dolphinscheduler-dist/release-docs/LICENSE
@@ -515,6 +515,7 @@ MIT licenses
 html2canvas 0.5.0-beta4: https://github.com/niklasvh/html2canvas MIT
 jquery 3.3.1: https://github.com/jquery/jquery MIT
 jquery-ui 1.12.1: https://github.com/jquery/jquery-ui MIT
+js-cookie 2.2.1: https://github.com/js-cookie/js-cookie MIT
 jsplumb 2.8.6: https://github.com/jsplumb/jsplumb MIT and GPLv2
 lodash 4.17.11: https://github.com/lodash/lodash MIT
 vue2.5.17: https://github.com/vuejs/vueMIT
diff --git 
a/dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-js-cookie 
b/dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-js-cookie
new file mode 100644
index 000..69ed677
--- /dev/null
+++ b/dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-js-cookie
@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2018 Copyright 2018 Klaus Hartl, Fagner Brack, GitHub 
Contributors
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
\ No newline at end of file
diff --git a/dolphinscheduler-ui/package.json b/dolphinscheduler-ui/package.json
index 9d91b09..7827e5c 100644
--- a/dolphinscheduler-ui/package.json
+++ b/dolphinscheduler-ui/package.json
@@ -23,6 +23,7 @@
 "html2canvas": "^0.5.0-beta4",
 "jquery": "3.3.1",
 "jquery-ui": "^1.12.1",
+"js-cookie": "^2.2.1",
 "jsplumb": "^2.8.6",
 "lodash": "^4.17.11",
 "vue": "^2.5.17",
diff --git 
a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/http.vue
 
b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/http.vue
index 2617c44..adb5441 100644
--- 
a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/http.vue
+++ 
b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/http.vue
@@ -101,7 +101,7 @@
 

[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1561: replace cookie.js with js-cookie, add js-cookie license

2019-12-24 Thread GitBox
lgcareer merged pull request #1561: replace cookie.js with js-cookie, add 
js-cookie license
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1561
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in 
/escheduler-ui
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1230#issuecomment-568825623
 
 
   Dependabot tried to update this pull request, but something went wrong. 
We're looking into it, but in the meantime you can retry the update by 
commenting `@dependabot rebase`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in 
/escheduler-ui/src/lib/@fedor/io
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1231#issuecomment-568825627
 
 
   Dependabot tried to update this pull request, but something went wrong. 
We're looking into it, but in the meantime you can retry the update by 
commenting `@dependabot rebase`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in 
/escheduler-ui
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1232#issuecomment-568825624
 
 
   Dependabot tried to update this pull request, but something went wrong. 
We're looking into it, but in the meantime you can retry the update by 
commenting `@dependabot rebase`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1537: refactor zk client and zk config module

2019-12-24 Thread GitBox
qiaozhanwei merged pull request #1537: refactor zk client and zk config module
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1537
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-dolphinscheduler] branch dev updated (b4daa85 -> 4bbf31f)

2019-12-24 Thread journey
This is an automated email from the ASF dual-hosted git repository.

journey pushed a change to branch dev
in repository 
https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git.


from b4daa85  replace cookie.js with js-cookie, add js-cookie license 
(#1561)
 add 4bbf31f  refactor zk client and zk config module (#1537)

No new revisions were added by this update.

Summary of changes:
 .../api/service/MonitorService.java|   4 +-
 .../api/utils/ZookeeperMonitor.java|   7 +-
 dolphinscheduler-common/pom.xml|   5 +
 .../apache/dolphinscheduler/common/Constants.java  |  24 +-
 .../common/queue/TaskQueueZkImpl.java  |  47 +++-
 .../common/utils/Preconditions.java| 288 +
 .../common/zk/AbstractListener.java}   |  32 +--
 .../common/zk/AbstractZKClient.java| 121 ++---
 .../common/zk/DefaultEnsembleProvider.java}|  35 +--
 .../common/zk/ZookeeperCachedOperator.java |  82 ++
 .../common/zk/ZookeeperConfig.java |  71 +
 .../common/zk/ZookeeperOperator.java   | 232 +
 .../src/main/resources/zookeeper.properties|  19 +-
 .../server/master/MasterServer.java|   4 +-
 .../server/worker/WorkerServer.java|   4 +-
 .../dolphinscheduler/server/zk/ZKMasterClient.java | 148 +++
 .../dolphinscheduler/server/zk/ZKWorkerClient.java | 104 ++--
 17 files changed, 872 insertions(+), 355 deletions(-)
 create mode 100644 
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/Preconditions.java
 copy 
dolphinscheduler-common/src/{test/java/org/apache/dolphinscheduler/common/zk/TestZkServer.java
 => main/java/org/apache/dolphinscheduler/common/zk/AbstractListener.java} (55%)
 copy 
dolphinscheduler-common/src/{test/java/org/apache/dolphinscheduler/common/zk/TestZkServer.java
 => 
main/java/org/apache/dolphinscheduler/common/zk/DefaultEnsembleProvider.java} 
(62%)
 create mode 100644 
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/zk/ZookeeperCachedOperator.java
 create mode 100644 
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/zk/ZookeeperConfig.java
 create mode 100644 
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/zk/ZookeeperOperator.java



[GitHub] [incubator-dolphinscheduler] gaojun2048 opened a new pull request #1563: Added the maven profile to build rpm packages

2019-12-24 Thread GitBox
gaojun2048 opened a new pull request #1563: Added the maven profile to build 
rpm packages
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1563
 
 
   ## What is the purpose of the pull request
   **Hello , This pull request adds rpmbuild plugin**
   
   **The associated issue is Develops an Ambari plugin about DS : 
https://github.com/apache/incubator-dolphinscheduler/issues/1469**
   
   ## Brief change log
   
   *add rpmbuild plugin*
 - *Add maven-dependency-plugin and rpm-maven-plugion in root pom.xml*
   
 - *Add profile rpmbuild in dolphinscheduler-dist/pom.xml*
   
 - *Removed some duplicate operations in 
dolphinscheduler-dist/src/main/assembly/dolphinscheduler-binary.xml *
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in 
/escheduler-ui/src/lib/@fedor/io
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1231#issuecomment-568826769
 
 
   Dependabot tried to update this pull request, but something went wrong. 
We're looking into it, but in the meantime you can retry the update by 
commenting `@dependabot rebase`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in 
/escheduler-ui
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1230#issuecomment-568826772
 
 
   Dependabot tried to update this pull request, but something went wrong. 
We're looking into it, but in the meantime you can retry the update by 
commenting `@dependabot rebase`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in 
/escheduler-ui
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1232#issuecomment-568826757
 
 
   Dependabot tried to update this pull request, but something went wrong. 
We're looking into it, but in the meantime you can retry the update by 
commenting `@dependabot rebase`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1563: Added the maven profile to build rpm packages

2019-12-24 Thread GitBox
codecov-io commented on issue #1563: Added the maven profile to build rpm 
packages
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1563#issuecomment-568827020
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563?src=pr&el=h1)
 Report
   > :exclamation: No coverage uploaded for pull request base (`dev@4bbf31f`). 
[Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## dev   #1563   +/-   ##
   =
 Coverage   ?   7.63%   
   =
 Files  ? 278   
 Lines  ?   13750   
 Branches   ?2195   
   =
 Hits   ?1050   
 Misses ?   12630   
 Partials   ?  70
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563?src=pr&el=footer).
 Last update 
[4bbf31f...787d407](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1563?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] lgcareer opened a new pull request #1564: Fix spelling mistakes:aws-java-sdk, commons-net, 4.1.33.Final

2019-12-24 Thread GitBox
lgcareer opened a new pull request #1564: Fix spelling 
mistakes:aws-java-sdk,commons-net,4.1.33.Final
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1564
 
 
   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review 
https://dolphinscheduler.apache.org/en-us/community/index.html before opening a 
pull request.*
   
   ## What is the purpose of the pull request
   
   *Fix spelling mistakes:aws-java-sdk,commons-net,4.1.33.Final*
   
   ## Brief change log
   
   *Fix spelling mistakes:aws-java-sdk,commons-net,4.1.33.Final*
 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-dolphinscheduler] branch 1.2.0-release updated: Fix spelling mistakes:aws-java-sdk, commons-net, 4.1.33.Final (#1564)

2019-12-24 Thread journey
This is an automated email from the ASF dual-hosted git repository.

journey pushed a commit to branch 1.2.0-release
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git


The following commit(s) were added to refs/heads/1.2.0-release by this push:
 new be92626  Fix spelling mistakes:aws-java-sdk,commons-net,4.1.33.Final 
(#1564)
be92626 is described below

commit be9262674bd9cfae6f47fbeab41cf0e24b4ead55
Author: lgcareer <18610854...@163.com>
AuthorDate: Wed Dec 25 11:01:18 2019 +0800

Fix spelling mistakes:aws-java-sdk,commons-net,4.1.33.Final (#1564)

* Add space or colon

* Fix spelling mistakes:aws-java-sdk,commons-net,4.1.33.Final
---
 .../dolphinscheduler-backend/src/main/release-docs/LICENSE  | 6 +++---
 .../licenses/{LICENSE-aws-sdk-java.txt => LICENSE-aws-java-sdk.txt} | 0
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/dolphinscheduler-dist/dolphinscheduler-backend/src/main/release-docs/LICENSE 
b/dolphinscheduler-dist/dolphinscheduler-backend/src/main/release-docs/LICENSE
index 53a89e6..eaa2e3b 100644
--- 
a/dolphinscheduler-dist/dolphinscheduler-backend/src/main/release-docs/LICENSE
+++ 
b/dolphinscheduler-dist/dolphinscheduler-backend/src/main/release-docs/LICENSE
@@ -231,7 +231,7 @@ The text of each license is also included at 
licenses/LICENSE-[project].txt.
 api-util 1.0.0-M20: 
https://mvnrepository.com/artifact/org.apache.directory.api/api-util/1.0.0-M20, 
Apache 2.0
 audience-annotations 0.5.0: 
https://mvnrepository.com/artifact/org.apache.yetus/audience-annotations/0.5.0, 
Apache 2.0
 avro 1.7.4: https://github.com/apache/avro, Apache 2.0
-aws-sdk-java 1.7.4: 
https://mvnrepository.com/artifact/com.amazonaws/aws-java-sdk/1.7.4, Apache 2.0
+aws-java-sdk 1.7.4: 
https://mvnrepository.com/artifact/com.amazonaws/aws-java-sdk/1.7.4, Apache 2.0
 bonecp 0.8.0.RELEASE: https://github.com/wwadge/bonecp, Apache 2.0
 byte-buddy 1.9.10: 
https://mvnrepository.com/artifact/net.bytebuddy/byte-buddy/1.9.10, Apache 2.0
 classmate 1.4.0: 
https://mvnrepository.com/artifact/com.fasterxml/classmate/1.4.0, Apache 2.0
@@ -251,7 +251,7 @@ The text of each license is also included at 
licenses/LICENSE-[project].txt.
 commons-lang3 3.5: 
https://mvnrepository.com/artifact/org.apache.commons/commons-lang3/3.5, Apache 
2.0
 commons-logging 1.1.1: https://github.com/apache/commons-logging, Apache 
2.0
 commons-math3 3.1.1: https://github.com/apache/commons-math, Apache 2.0
-commans-net 3.1: https://github.com/apache/commons-net, Apache 2.0
+commons-net 3.1: https://github.com/apache/commons-net, Apache 2.0
 commons-pool 1.6: https://github.com/apache/commons-pool, Apache 2.0
 cron-utils 5.0.5: 
https://mvnrepository.com/artifact/com.cronutils/cron-utils/5.0.5, Apache 2.0
 curator-client 2.12.0: 
https://mvnrepository.com/artifact/org.apache.curator/curator-client/2.12.0, 
Apache 2.0
@@ -363,7 +363,7 @@ The text of each license is also included at 
licenses/LICENSE-[project].txt.
 netty-codec-http 4.1.33.Final: 
https://mvnrepository.com/artifact/io.netty/netty-codec-http/4.1.33.Final, 
Apache 2.0
 netty-codec-socks 4.1.33.Final: 
https://mvnrepository.com/artifact/io.netty/netty-codec-socks/4.1.33.Final, 
Apache 2.0
 netty-common 4.1.33.Final: 
https://mvnrepository.com/artifact/io.netty/netty-common/4.1.33.Final, Apache 
2.0
-netty-handler 4.1.33: 
https://mvnrepository.com/artifact/io.netty/netty-handler/4.1.33.Final, Apache 
2.0
+netty-handler 4.1.33.Final: 
https://mvnrepository.com/artifact/io.netty/netty-handler/4.1.33.Final, Apache 
2.0
 netty-handler-proxy 4.1.33.Final: 
https://mvnrepository.com/artifact/io.netty/netty-handler-proxy/4.1.33.Final, 
Apache 2.0
 netty-resolver 4.1.33.Final: 
https://mvnrepository.com/artifact/io.netty/netty-resolver/4.1.33.Final, Apache 
2.0
 netty-transport 4.1.33.Final: 
https://mvnrepository.com/artifact/io.netty/netty-transport/4.1.33.Final, 
Apache 2.0
diff --git 
a/dolphinscheduler-dist/dolphinscheduler-backend/src/main/release-docs/licenses/LICENSE-aws-sdk-java.txt
 
b/dolphinscheduler-dist/dolphinscheduler-backend/src/main/release-docs/licenses/LICENSE-aws-java-sdk.txt
similarity index 100%
rename from 
dolphinscheduler-dist/dolphinscheduler-backend/src/main/release-docs/licenses/LICENSE-aws-sdk-java.txt
rename to 
dolphinscheduler-dist/dolphinscheduler-backend/src/main/release-docs/licenses/LICENSE-aws-java-sdk.txt



[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1564: Fix spelling mistakes:aws-java-sdk, commons-net, 4.1.33.Final

2019-12-24 Thread GitBox
qiaozhanwei merged pull request #1564: Fix spelling 
mistakes:aws-java-sdk,commons-net,4.1.33.Final
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1564
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1565: License Corrected Version

2019-12-24 Thread GitBox
break60 opened a new pull request #1565: License Corrected Version
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1565
 
 
   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review 
https://dolphinscheduler.apache.org/en-us/community/index.html before opening a 
pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds checkstyle plugin.)*
   
   ## Brief change log
   
   *(for example:)*
 - *Add maven-checkstyle-plugin to root pom.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please 
describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
 - *Added dolphinscheduler-dao tests for end-to-end.*
 - *Added CronUtilsTest to verify the change.*
 - *Manually verified the change by testing locally.*
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1566: License Corrected Version

2019-12-24 Thread GitBox
break60 opened a new pull request #1566: License Corrected Version
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1566
 
 
   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review 
https://dolphinscheduler.apache.org/en-us/community/index.html before opening a 
pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds checkstyle plugin.)*
   
   ## Brief change log
   
   *(for example:)*
 - *Add maven-checkstyle-plugin to root pom.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please 
describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
 - *Added dolphinscheduler-dao tests for end-to-end.*
 - *Added CronUtilsTest to verify the change.*
 - *Manually verified the change by testing locally.*
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1565: License Corrected Version

2019-12-24 Thread GitBox
codecov-io commented on issue #1565: License Corrected Version
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1565#issuecomment-568830722
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=h1)
 Report
   > Merging 
[#1565](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=desc)
 into 
[dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/4bbf31f8076f0ba0c8722ea98738ee1c50f2b6ff?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## dev   #1565   +/-   ##
   =
 Coverage   7.63%   7.63%   
   =
 Files278 278   
 Lines  13750   13750   
 Branches21952195   
   =
 Hits10501050   
 Misses 12630   12630   
 Partials  70  70
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=footer).
 Last update 
[4bbf31f...395bcae](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1566: License Corrected Version

2019-12-24 Thread GitBox
lgcareer merged pull request #1566: License Corrected Version
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1566
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-dolphinscheduler] branch 1.2.0-release updated: License Corrected Version (#1566)

2019-12-24 Thread lgcareer
This is an automated email from the ASF dual-hosted git repository.

lgcareer pushed a commit to branch 1.2.0-release
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git


The following commit(s) were added to refs/heads/1.2.0-release by this push:
 new 6a82d46  License Corrected Version (#1566)
6a82d46 is described below

commit 6a82d4631bd70b37b33e1867a7503d1011a2f70e
Author: break60 <790061...@qq.com>
AuthorDate: Wed Dec 25 11:40:34 2019 +0800

License Corrected Version (#1566)

* Front-end compliance modification

* Front-end supplemental license

* Modify naming

* Repair license

* replace cookie.js with js-cookie, add js-cookie license

* License Corrected Version
---
 .../src/main/release-docs/licenses/LICENSE-axios   |   2 +-
 .../main/release-docs/licenses/LICENSE-bootstrap   |   3 +-
 .../src/main/release-docs/licenses/LICENSE-canvg   |  37 ++--
 .../src/main/release-docs/licenses/LICENSE-d3  |  39 ++--
 .../src/main/release-docs/licenses/LICENSE-dayjs   |   2 +-
 .../src/main/release-docs/licenses/LICENSE-echarts | 220 +++--
 .../src/main/release-docs/licenses/LICENSE-jquery  |  57 --
 .../main/release-docs/licenses/LICENSE-jquery-ui   |   4 +-
 .../src/main/release-docs/licenses/LICENSE-jsplumb |   2 +-
 .../src/main/release-docs/licenses/LICENSE-lodash  |   3 -
 .../src/main/release-docs/licenses/LICENSE-vue |   2 +-
 .../main/release-docs/licenses/LICENSE-vue-router  |  10 +-
 .../src/main/release-docs/licenses/LICENSE-vuex|   2 +-
 dolphinscheduler-ui/package.json   |   2 +-
 14 files changed, 292 insertions(+), 93 deletions(-)

diff --git 
a/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-axios
 
b/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-axios
index 2d8d66a..d2c1a12 100644
--- 
a/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-axios
+++ 
b/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-axios
@@ -1,4 +1,4 @@
-Copyright (c) 2014-present Matt Zabriskie
+Copyright (c) 2014 Matt Zabriskie
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
diff --git 
a/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-bootstrap
 
b/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-bootstrap
index 0d367cb..a80e8c2 100644
--- 
a/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-bootstrap
+++ 
b/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-bootstrap
@@ -1,7 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2011-2019 Twitter, Inc.
-Copyright (c) 2011-2019 The Bootstrap Authors
+Copyright (c) 2011-2016 Twitter, Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
diff --git 
a/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-canvg
 
b/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-canvg
index 9680fbd..40f19bd 100644
--- 
a/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-canvg
+++ 
b/dolphinscheduler-dist/dolphinscheduler-front/src/main/release-docs/licenses/LICENSE-canvg
@@ -1,21 +1,22 @@
-The MIT License (MIT)
+Copyright (c) 2010-2011 Gabe Lerner (gabeler...@gmail.com) - 
http://code.google.com/p/canvg/
 
-Copyright (c) 2010 - present Gabe Lerner (gabeler...@gmail.com) - 
https://github.com/canvg/canvg
+ Permission is hereby granted, free of charge, to any person
+ obtaining a copy of this software and associated documentation
+ files (the "Software"), to deal in the Software without
+ restriction, including without limitation the rights to use,
+ copy, modify, merge, publish, distribute, sublicense, and/or sell
+ copies of the Software, and to permit persons to whom the
+ Software is furnished to do so, subject to the following
+ conditions:
 
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
+ The above copyright notice and this permission notice shall be
+ included in all copies or substantial portions of the Software.
 
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT W

[GitHub] [incubator-dolphinscheduler] Technoboy- opened a new pull request #1567: delete lombok

2019-12-24 Thread GitBox
Technoboy- opened a new pull request #1567: delete lombok
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1567
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1565: License Corrected Version

2019-12-24 Thread GitBox
codecov-io edited a comment on issue #1565: License Corrected Version
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1565#issuecomment-568830722
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=h1)
 Report
   > Merging 
[#1565](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=desc)
 into 
[dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/4bbf31f8076f0ba0c8722ea98738ee1c50f2b6ff?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## dev   #1565   +/-   ##
   =
 Coverage   7.63%   7.63%   
   =
 Files278 278   
 Lines  13750   13750   
 Branches21952195   
   =
 Hits10501050   
 Misses 12630   12630   
 Partials  70  70
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=footer).
 Last update 
[4bbf31f...fe0685c](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1565: License Corrected Version

2019-12-24 Thread GitBox
codecov-io edited a comment on issue #1565: License Corrected Version
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1565#issuecomment-568830722
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=h1)
 Report
   > Merging 
[#1565](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=desc)
 into 
[dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/4bbf31f8076f0ba0c8722ea98738ee1c50f2b6ff?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## dev   #1565   +/-   ##
   =
 Coverage   7.63%   7.63%   
   =
 Files278 278   
 Lines  13750   13750   
 Branches21952195   
   =
 Hits10501050   
 Misses 12630   12630   
 Partials  70  70
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=footer).
 Last update 
[4bbf31f...fe0685c](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1565?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1567: delete lombok

2019-12-24 Thread GitBox
codecov-io commented on issue #1567: delete lombok
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1567#issuecomment-568832786
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1567?src=pr&el=h1)
 Report
   > Merging 
[#1567](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1567?src=pr&el=desc)
 into 
[dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/4bbf31f8076f0ba0c8722ea98738ee1c50f2b6ff?src=pr&el=desc)
 will **decrease** coverage by `0.04%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1567/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1567?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff@@
   ## dev   #1567  +/-   ##
   
   - Coverage   7.63%   7.58%   -0.05% 
   
 Files278 277   -1 
 Lines  13750   13743   -7 
 Branches21952194   -1 
   
   - Hits10501043   -7 
   - Misses 12630   12631   +1 
   + Partials  70  69   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1567?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...dolphinscheduler/common/queue/TaskQueueZkImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1567/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3F1ZXVlL1Rhc2tRdWV1ZVprSW1wbC5qYXZh)
 | `71.66% <100%> (-0.16%)` | :arrow_down: |
   | 
[...e/dolphinscheduler/common/utils/Preconditions.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1567/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1ByZWNvbmRpdGlvbnMuamF2YQ==)
 | `0% <0%> (-1.76%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1567?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1567?src=pr&el=footer).
 Last update 
[4bbf31f...f5de617](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1567?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1567: delete lombok

2019-12-24 Thread GitBox
qiaozhanwei merged pull request #1567: delete lombok
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1567
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-dolphinscheduler] branch dev updated: License Corrected Version (#1565)

2019-12-24 Thread journey
This is an automated email from the ASF dual-hosted git repository.

journey pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
 new 026fdd9  License Corrected Version (#1565)
026fdd9 is described below

commit 026fdd9e1c2fab944776c6cc09716d0b5b185baa
Author: break60 <790061...@qq.com>
AuthorDate: Wed Dec 25 12:26:28 2019 +0800

License Corrected Version (#1565)

* Password verification and v-for add key

* DAG automatic layout

* combo.js replacement

* combo.js replacement

* webpack upgrade to 4

* packjson has a file name that has not changed

* Solve jertty packing garbled

* Modify dashboard color

* Remove iconfont, awesome, replace with ans-ui icon

* Menu arrow style fix

* Script input box style fix

* console.log('Front-end third-party js, css introduced using npm

* Front-end supplemental license

* Modify naming

* Repair license

* replace cookie.js with js-cookie, add js-cookie license

* License Corrected Version

* License Corrected Version
---
 .../licenses/ui-licenses/LICENSE-axios |   2 +-
 .../licenses/ui-licenses/LICENSE-bootstrap |   3 +-
 .../licenses/ui-licenses/LICENSE-canvg |  37 ++--
 .../release-docs/licenses/ui-licenses/LICENSE-d3   |  39 ++--
 .../licenses/ui-licenses/LICENSE-dayjs |   2 +-
 .../licenses/ui-licenses/LICENSE-echarts   | 220 +++--
 .../licenses/ui-licenses/LICENSE-jquery|  57 --
 .../licenses/ui-licenses/LICENSE-jquery-ui |   4 +-
 .../licenses/ui-licenses/LICENSE-jsplumb   |   2 +-
 .../licenses/ui-licenses/LICENSE-lodash|   3 -
 .../release-docs/licenses/ui-licenses/LICENSE-vue  |   2 +-
 .../licenses/ui-licenses/LICENSE-vue-router|  10 +-
 .../release-docs/licenses/ui-licenses/LICENSE-vuex |   2 +-
 dolphinscheduler-ui/package.json   |   2 +-
 14 files changed, 292 insertions(+), 93 deletions(-)

diff --git 
a/dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-axios 
b/dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-axios
index 2d8d66a..d2c1a12 100644
--- a/dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-axios
+++ b/dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-axios
@@ -1,4 +1,4 @@
-Copyright (c) 2014-present Matt Zabriskie
+Copyright (c) 2014 Matt Zabriskie
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
diff --git 
a/dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-bootstrap 
b/dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-bootstrap
index 0d367cb..a80e8c2 100644
--- a/dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-bootstrap
+++ b/dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-bootstrap
@@ -1,7 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2011-2019 Twitter, Inc.
-Copyright (c) 2011-2019 The Bootstrap Authors
+Copyright (c) 2011-2016 Twitter, Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
diff --git 
a/dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-canvg 
b/dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-canvg
index 9680fbd..40f19bd 100644
--- a/dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-canvg
+++ b/dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-canvg
@@ -1,21 +1,22 @@
-The MIT License (MIT)
+Copyright (c) 2010-2011 Gabe Lerner (gabeler...@gmail.com) - 
http://code.google.com/p/canvg/
 
-Copyright (c) 2010 - present Gabe Lerner (gabeler...@gmail.com) - 
https://github.com/canvg/canvg
+ Permission is hereby granted, free of charge, to any person
+ obtaining a copy of this software and associated documentation
+ files (the "Software"), to deal in the Software without
+ restriction, including without limitation the rights to use,
+ copy, modify, merge, publish, distribute, sublicense, and/or sell
+ copies of the Software, and to permit persons to whom the
+ Software is furnished to do so, subject to the following
+ conditions:
 
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
+ The above copyright notice and this permission notice shall be
+ in

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1565: License Corrected Version

2019-12-24 Thread GitBox
qiaozhanwei merged pull request #1565: License Corrected Version
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1565
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-dolphinscheduler] branch dev updated: delete lombok (#1567)

2019-12-24 Thread journey
This is an automated email from the ASF dual-hosted git repository.

journey pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
 new 3e4c221  delete lombok (#1567)
3e4c221 is described below

commit 3e4c221463c62961a80a5a6a04e050f2af23
Author: Tboy 
AuthorDate: Wed Dec 25 12:25:40 2019 +0800

delete lombok (#1567)

* fix #1515

* sleep when resource in not satisfy. fix #1522

* add sleep 1s for no command

* fix MasterBaseTaskExecThread submit method bug

* updates

* add log

* delete lombok
---
 .../common/queue/TaskQueueZkImpl.java  | 26 ++--
 .../common/zk/ZookeeperConfig.java | 77 +-
 2 files changed, 69 insertions(+), 34 deletions(-)

diff --git 
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/queue/TaskQueueZkImpl.java
 
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/queue/TaskQueueZkImpl.java
index 9bc7359..5eca993 100644
--- 
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/queue/TaskQueueZkImpl.java
+++ 
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/queue/TaskQueueZkImpl.java
@@ -17,26 +17,16 @@
 package org.apache.dolphinscheduler.common.queue;
 
 
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Comparator;
-import java.util.HashSet;
-import java.util.Iterator;
-import java.util.List;
-import java.util.Set;
-import java.util.TreeSet;
-
 import org.apache.commons.configuration.Configuration;
 import org.apache.commons.configuration.ConfigurationException;
 import org.apache.commons.configuration.PropertiesConfiguration;
+import org.apache.curator.framework.CuratorFramework;
 import org.apache.curator.framework.CuratorFrameworkFactory;
 import org.apache.curator.retry.ExponentialBackoffRetry;
 import org.apache.dolphinscheduler.common.Constants;
 import org.apache.dolphinscheduler.common.utils.Bytes;
 import org.apache.dolphinscheduler.common.utils.IpUtils;
 import org.apache.dolphinscheduler.common.utils.OSUtils;
-import org.apache.dolphinscheduler.common.zk.AbstractZKClient;
-import org.apache.curator.framework.CuratorFramework;
 import org.apache.dolphinscheduler.common.zk.DefaultEnsembleProvider;
 import org.apache.dolphinscheduler.common.zk.ZookeeperConfig;
 import org.apache.zookeeper.CreateMode;
@@ -44,7 +34,7 @@ import org.apache.zookeeper.data.Stat;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import static 
org.apache.dolphinscheduler.common.utils.Preconditions.checkNotNull;
+import java.util.*;
 
 /**
  * A singleton of a task queue implemented with zookeeper
@@ -421,12 +411,11 @@ public class TaskQueueZkImpl implements ITaskQueue {
 logger.error("load zookeeper properties file failed, system exit");
 System.exit(-1);
 }
-zookeeperConfig = ZookeeperConfig.getFromConf(conf);
 
-zkClient = CuratorFrameworkFactory.builder().ensembleProvider(new 
DefaultEnsembleProvider(checkNotNull(zookeeperConfig.getServerList(), 
"zookeeper quorum can't be null")))
-.retryPolicy(new 
ExponentialBackoffRetry(zookeeperConfig.getBaseSleepTimeMs(), 
zookeeperConfig.getMaxRetries(), zookeeperConfig.getMaxSleepMs()))
-.sessionTimeoutMs(zookeeperConfig.getSessionTimeoutMs())
-.connectionTimeoutMs(zookeeperConfig.getConnectionTimeoutMs())
+zkClient = CuratorFrameworkFactory.builder().ensembleProvider(new 
DefaultEnsembleProvider(conf.getString("zookeeper.quorum")))
+.retryPolicy(new 
ExponentialBackoffRetry(conf.getInt("zookeeper.retry.base.sleep"), 
conf.getInt("zookeeper.retry.maxtime"), 
conf.getInt("zookeeper.retry.max.sleep")))
+.sessionTimeoutMs(conf.getInt("zookeeper.session.timeout"))
+
.connectionTimeoutMs(conf.getInt("zookeeper.connection.timeout"))
 .build();
 
 zkClient.start();
@@ -472,8 +461,7 @@ public class TaskQueueZkImpl implements ITaskQueue {
  * @return
  */
 public String getTasksPath(String key){
-return zookeeperConfig.getDsRoot() + Constants.SINGLE_SLASH + key;
+return "/dolphinscheduler" + Constants.SINGLE_SLASH + key;
 }
 
-
 }
diff --git 
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/zk/ZookeeperConfig.java
 
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/zk/ZookeeperConfig.java
index 6e471bb..a90a147 100644
--- 
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/zk/ZookeeperConfig.java
+++ 
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/zk/ZookeeperConfig.java
@@ -16,11 +16,6 @@
  */
 package org.apache.dolphinscheduler.common.zk;
 
-import lombok.AllArgsConstructor;
-import lomb

[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in 
/escheduler-ui/src/lib/@fedor/io
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1231#issuecomment-568836628
 
 
   Dependabot tried to update this pull request, but something went wrong. 
We're looking into it, but in the meantime you can retry the update by 
commenting `@dependabot rebase`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in 
/escheduler-ui
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1232#issuecomment-568836626
 
 
   Dependabot tried to update this pull request, but something went wrong. 
We're looking into it, but in the meantime you can retry the update by 
commenting `@dependabot rebase`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui

2019-12-24 Thread GitBox
dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in 
/escheduler-ui
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1230#issuecomment-568836627
 
 
   Dependabot tried to update this pull request, but something went wrong. 
We're looking into it, but in the meantime you can retry the update by 
commenting `@dependabot rebase`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1541: remove duplicated code

2019-12-24 Thread GitBox
Technoboy- commented on issue #1541: remove duplicated code
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568849254
 
 
   Hi bro, as we discuss, we want to remove lombok dependancy , so try to 
remove @Data annotation 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] gaojun2048 commented on issue #1563: Added the maven profile to build rpm packages

2019-12-24 Thread GitBox
gaojun2048 commented on issue #1563: Added the maven profile to build rpm 
packages
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1563#issuecomment-568849503
 
 
   > /opt/soft dir will auto create or not ?
   > 
   > by the way, how to build rpm package?
   
   1、The build command:
   mvn -U clean package -Prpmbuild -Dmaven.test.skip=true
   
   2、Sorry , I just add /opt/soft auto create code 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] Yeleights opened a new pull request #1568: #747 Worker Log desensitization(日志脱敏)

2019-12-24 Thread GitBox
Yeleights opened a new pull request #1568: #747 Worker Log desensitization(日志脱敏)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1568
 
 
   ## What is the purpose of the pull request
   *#747 Worker Data Source Log Desensitization*
   
   ## Brief change log
 - *Add DATASOURCE_PASSWORD_REGEX to Constants*
 - *Add SensitiveLogUtil, SensitiveDataConverter, SensitiveLogUtilTest, 
SensitiveDataConverterTest*
 - *Add conversionRule to worker_logback.xml*
   ## Verify this pull request
   This change added tests and can be verified as follows:
 - *Added SensitiveLogUtilTest and SensitiveDataConverterTest to verify the 
change.*
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] lgcareer opened a new pull request #1569: reset pom to version 1.2.0-SNAPSHOT

2019-12-24 Thread GitBox
lgcareer opened a new pull request #1569: reset pom to version 1.2.0-SNAPSHOT
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1569
 
 
   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review 
https://dolphinscheduler.apache.org/en-us/community/index.html before opening a 
pull request.*
   
   ## What is the purpose of the pull request
   
   *reset pom to version 1.2.0-SNAPSHOT*
   
   ## Brief change log
   
   *reset pom to version 1.2.0-SNAPSHOT*
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1568: #747 Worker Log desensitization(日志脱敏)

2019-12-24 Thread GitBox
codecov-io commented on issue #1568: #747 Worker Log desensitization(日志脱敏)
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1568#issuecomment-568850902
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=h1)
 Report
   > Merging 
[#1568](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=desc)
 into 
[dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/026fdd9e1c2fab944776c6cc09716d0b5b185baa?src=pr&el=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff@@
   ## dev   #1568  +/-   ##
   
   - Coverage   7.58%   7.57%   -0.02% 
   
 Files277 279   +2 
 Lines  13743   13763  +20 
 Branches21942197   +3 
   
 Hits10431043  
   - Misses 12631   12651  +20 
 Partials  69  69
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[...uler/server/worker/log/SensitiveDataConverter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9sb2cvU2Vuc2l0aXZlRGF0YUNvbnZlcnRlci5qYXZh)
 | `0% <0%> (ø)` | |
   | 
[...olphinscheduler/server/utils/SensitiveLogUtil.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1NlbnNpdGl2ZUxvZ1V0aWwuamF2YQ==)
 | `0% <0%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=footer).
 Last update 
[026fdd9...286768c](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


  1   2   >