[GitHub] [incubator-dolphinscheduler] zjcnb commented on issue #1421: Duplicate code for this project

2019-12-10 Thread GitBox
zjcnb commented on issue #1421: Duplicate code for this project
URL: 
https://github.com/apache/incubator-dolphinscheduler/issues/1421#issuecomment-564373521
 
 
   > > Hi, i found @DaTa annotation for this project. But it 's still has 
setter and getter method. i think it is duplicate code. I want to remove it! 
What do you think?
   > 
   > Hi brother, we discuss and confirm, it's duplicate code . so would you 
like to fix this issue?
   
   yes,i do


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] zjcnb commented on issue #1421: Duplicate code for this project

2019-12-10 Thread GitBox
zjcnb commented on issue #1421: Duplicate code for this project
URL: 
https://github.com/apache/incubator-dolphinscheduler/issues/1421#issuecomment-564373461
 
 
   yes,i do


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-dolphinscheduler] zjcnb commented on issue #1421: Duplicate code for this project

2019-12-09 Thread GitBox
zjcnb commented on issue #1421: Duplicate code for this project
URL: 
https://github.com/apache/incubator-dolphinscheduler/issues/1421#issuecomment-563189096
 
 
   OK,i will try
   
   
   
   ---Original---
   From: "bao liang"