Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]
doris-robot commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109341666 TPC-H: Total hot run time: 41995 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 4030e45bf2a226889d21505f94cf6d0a07bdf673, data reload: false -- Round 1 -- q1 6126426742534253 q2 627 202 183 183 q3 1389120611441144 q4 1027778 853 778 q5 2677270926692669 q6 224 139 137 137 q7 1072575 600 575 q8 1951216322792163 q9 6998680666936693 q10 4069391739153915 q11 370 253 245 245 q12 393 231 240 231 q13 16416 325131813181 q14 280 235 229 229 q15 532 493 489 489 q16 492 417 399 399 q17 989 708 745 708 q18 8210773177517731 q19 1594156115681561 q20 666 321 317 317 q21 5277411541914115 q22 360 279 287 279 Total cold run time: 61739 ms Total hot run time: 41995 ms - Round 2, with runtime_filter_mode=off - q1 4483434343344334 q2 380 263 266 263 q3 2983287528052805 q4 1951167616721672 q5 5524559754105410 q6 212 124 126 124 q7 2264191719201917 q8 3172332733063306 q9 8341835483878354 q10 3885368536923685 q11 587 486 489 486 q12 771 612 577 577 q13 11733 295229972952 q14 284 246 264 246 q15 517 473 474 473 q16 479 421 440 421 q17 1756146414631463 q18 7496757674607460 q19 1655159215111511 q20 1989175217651752 q21 4864488348434843 q22 563 484 476 476 Total cold run time: 65889 ms Total hot run time: 54530 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]
doris-robot commented on PR #34816: URL: https://github.com/apache/doris/pull/34816#issuecomment-2109337745 TPC-DS: Total hot run time: 187790 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit fcd69a9bd4e5a6eb30664da6f2b047f5447741c9, data reload: false query1 908 366 350 350 query2 7131239523902390 query3 6660209 219 209 query4 24120 21189 21472 21189 query5 4178416 410 410 query6 264 195 176 176 query7 4584289 288 288 query8 242 187 190 187 query9 8693243824282428 query10 438 273 252 252 query11 14920 14239 14208 14208 query12 144 91 91 91 query13 1651395 373 373 query14 8829870078147814 query15 259 175 170 170 query16 8181267 261 261 query17 1853549 539 539 query18 2089274 267 267 query19 206 145 146 145 query20 93 91 87 87 query21 199 138 128 128 query22 5029484448484844 query23 34289 33568 33601 33568 query24 11545 294129882941 query25 651 374 361 361 query26 1723153 156 153 query27 2971319 332 319 query28 7646206620562056 query29 987 627 598 598 query30 300 150 154 150 query31 974 764 729 729 query32 89 53 54 53 query33 749 254 245 245 query34 1056484 493 484 query35 800 689 662 662 query36 1071893 917 893 query37 157 68 66 66 query38 2914278628232786 query39 1629157415671567 query40 276 123 124 123 query41 41 40 42 40 query42 107 97 95 95 query43 578 579 555 555 query44 1228733 740 733 query45 267 253 251 251 query46 1061708 713 708 query47 1933187819151878 query48 402 310 295 295 query49 1172393 400 393 query50 769 396 388 388 query51 6858684566936693 query52 104 92 88 88 query53 346 283 277 277 query54 1008432 445 432 query55 76 74 72 72 query56 238 233 231 231 query57 1250115511511151 query58 250 195 202 195 query59 3575350230283028 query60 267 232 235 232 query61 93 94 88 88 query62 677 465 469 465 query63 318 285 283 283 query64 9743745473517351 query65 3132308530763076 query66 1387344 352 344 query67 15375 15299 15254 15254 query68 4620533 525 525 query69 482 314 308 308 query70 1197111810751075 query71 403 262 269 262 query72 7454255024062406 query73 708 326 320 320 query74 6577610161576101 query75 3447263826222622 query76 2863971 993 971 query77 389 258 260 258 query78 10646 10123 10102 10102 query79 2370517 511 511 query80 1037436 433 433 query81 519 224 216 216 query82 701 92 93 92 query83 234 159 161 159 query84 232 86 84 84 query85 1713273 267 267 query86 519 320 303 303 query87 3346311731303117 query88 4454248524642464 query89 482 383 388 383 query90 2027194 194 194 query91 135 109 111 109 query92 62 52 120 52 query93 1781506 497 497 query94 1161181 186 181 query95 391 296 293 293 query96 600 280 276 276 query97 3192302129602960 query98 229 228 218 218 query99 1121875 899 875 Total cold run time: 287845 ms Total hot run time: 187790 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]
doris-robot commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109334381 TeamCity be ut coverage result: Function Coverage: 35.66% (8980/25180) Line Coverage: 27.32% (74237/271751) Region Coverage: 26.55% (38348/144451) Branch Coverage: 23.37% (19564/83702) Coverage Report: http://coverage.selectdb-in.cc/coverage/a7a8710880b9e7266c673cea6b25be762ea2d12e_a7a8710880b9e7266c673cea6b25be762ea2d12e/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]
doris-robot commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109333158 TPC-DS: Total hot run time: 187183 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit a7a8710880b9e7266c673cea6b25be762ea2d12e, data reload: false query1 909 389 349 349 query2 7820225423302254 query3 6664206 217 206 query4 23180 21128 21263 21128 query5 4139443 407 407 query6 273 170 187 170 query7 4581297 294 294 query8 238 190 190 190 query9 8831241823872387 query10 442 247 268 247 query11 14838 14131 14122 14122 query12 138 93 107 93 query13 1648364 369 364 query14 9589851878357835 query15 271 165 168 165 query16 8178259 272 259 query17 1857564 539 539 query18 2092272 271 271 query19 242 143 149 143 query20 91 86 84 84 query21 211 136 125 125 query22 5058486148614861 query23 34296 33486 33550 33486 query24 11144 284729872847 query25 607 376 361 361 query26 1592153 148 148 query27 2942321 337 321 query28 7412206420512051 query29 946 610 596 596 query30 284 152 150 150 query31 977 774 745 745 query32 97 52 53 52 query33 758 252 249 249 query34 1064478 479 478 query35 806 691 669 669 query36 1098926 933 926 query37 133 68 65 65 query38 2885277227592759 query39 1618157015601560 query40 270 127 121 121 query41 40 38 38 38 query42 105 94 97 94 query43 560 548 550 548 query44 1218715 723 715 query45 274 255 227 227 query46 1080733 722 722 query47 1937186519111865 query48 367 296 289 289 query49 1163413 392 392 query50 780 380 384 380 query51 6822683868276827 query52 102 86 90 86 query53 348 282 291 282 query54 1023441 431 431 query55 73 74 72 72 query56 247 216 224 216 query57 1236114411651144 query58 219 203 205 203 query59 3555330831243124 query60 250 224 237 224 query61 90 87 86 86 query62 669 492 459 459 query63 314 280 283 280 query64 9775753774887488 query65 3157314230743074 query66 1399353 346 346 query67 15215 15134 14955 14955 query68 6085541 530 530 query69 546 298 302 298 query70 1124109310681068 query71 471 270 268 268 query72 8172267725452545 query73 723 318 319 318 query74 6592611961276119 query75 4048266926182618 query76 4141998 1038998 query77 641 261 257 257 query78 10805 10186 10050 10050 query79 3660501 512 501 query80 1112451 435 435 query81 508 222 218 218 query82 826 95 92 92 query83 194 167 162 162 query84 267 86 82 82 query85 1407267 258 258 query86 483 308 307 307 query87 3262308830513051 query88 4727236523472347 query89 473 373 371 371 query90 1974181 184 181 query91 131 96 98 96 query92 54 51 52 51 query93 4760527 499 499 query94 1145182 176 176 query95 393 289 297 289 query96 593 264 267 264 query97 3182296729992967 query98 240 224 214 214 query99 1265913 909 909 Total cold run time: 296241 ms Total hot run time: 187183 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]
doris-robot commented on PR #34816: URL: https://github.com/apache/doris/pull/34816#issuecomment-2109325705 TPC-H: Total hot run time: 40226 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit fcd69a9bd4e5a6eb30664da6f2b047f5447741c9, data reload: false -- Round 1 -- q1 17598 431042444244 q2 2037194 186 186 q3 10670 123512381235 q4 10581 845 806 806 q5 7889267926462646 q6 217 134 134 134 q7 1006599 581 581 q8 9312211320752075 q9 9424665866216621 q10 8988377938113779 q11 475 249 237 237 q12 395 220 227 220 q13 18581 308530833083 q14 256 233 221 221 q15 522 485 488 485 q16 565 389 377 377 q17 961 718 726 718 q18 7982738973447344 q19 1644150114991499 q20 626 297 298 297 q21 4995316239803162 q22 348 276 286 276 Total cold run time: 115072 ms Total hot run time: 40226 ms - Round 2, with runtime_filter_mode=off - q1 4300420142024201 q2 379 281 265 265 q3 3009275627612756 q4 1832159616131596 q5 5295526252955262 q6 211 124 127 124 q7 2226185818741858 q8 3202330933483309 q9 8345834383448343 q10 3881363836473638 q11 572 490 478 478 q12 747 613 628 613 q13 17807 295429272927 q14 278 274 270 270 q15 517 487 468 468 q16 470 402 429 402 q17 1744148114751475 q18 7622750173387338 q19 1719150615211506 q20 1958175117621751 q21 5057470548654705 q22 576 503 500 500 Total cold run time: 71747 ms Total hot run time: 53785 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]
xzj7019 commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109323649 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]
doris-robot commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109321613 TPC-H: Total hot run time: 40164 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a7a8710880b9e7266c673cea6b25be762ea2d12e, data reload: false -- Round 1 -- q1 17598 435242644264 q2 2027197 189 189 q3 10559 119912261199 q4 10283 769 753 753 q5 7507272226542654 q6 215 133 143 133 q7 1042595 582 582 q8 9382217221352135 q9 9271671666366636 q10 9888375137463746 q11 460 241 230 230 q12 482 220 218 218 q13 18839 297229872972 q14 268 207 225 207 q15 525 473 477 473 q16 495 393 373 373 q17 979 705 676 676 q18 8065744774587447 q19 4250155815261526 q20 651 309 304 304 q21 5226324131763176 q22 337 271 281 271 Total cold run time: 118349 ms Total hot run time: 40164 ms - Round 2, with runtime_filter_mode=off - q1 4351430442204220 q2 356 260 261 260 q3 3044274127842741 q4 1850158416271584 q5 5299524253145242 q6 207 124 124 124 q7 2230187618941876 q8 3211334533363336 q9 8378832583828325 q10 3855375937143714 q11 591 510 479 479 q12 769 596 592 592 q13 16382 296329642963 q14 287 270 261 261 q15 517 462 475 462 q16 454 407 414 407 q17 1765150614761476 q18 7711745774447444 q19 1646155815751558 q20 1979175217971752 q21 5077477548824775 q22 593 517 507 507 Total cold run time: 70552 ms Total hot run time: 54098 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](exchange) the sink could eos early when all queues have enough rows [doris]
zhangstar333 commented on PR #34541: URL: https://github.com/apache/doris/pull/34541#issuecomment-2109319409 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](exchange) the sink could eos early when all queues have enough rows [doris]
github-actions[bot] commented on PR #34541:
URL: https://github.com/apache/doris/pull/34541#issuecomment-2109318366
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/9074264655;) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In regression-test/pipeline/performance/run-clickbench.sh line 37:
source
"${teamcity_build_checkoutDir}"/regression-test/pipeline/common/doris-utils.sh
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore
if invoked indirectly).
In regression-test/pipeline/performance/run-clickbench.sh line 40:
source
"${teamcity_build_checkoutDir}"/regression-test/pipeline/common/github-utils.sh
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore
if invoked indirectly).
In regression-test/pipeline/performance/run-clickbench.sh line 43:
source
"${teamcity_build_checkoutDir}"/regression-test/pipeline/common/oss-utils.sh
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore
if invoked indirectly).
In regression-test/pipeline/performance/run-clickbench.sh line 45:
if ${DEBUG:-false}; then
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore
if invoked indirectly).
^-^ SC2317 (info): Command appears to be unreachable. Check
usage (or ignore if invoked indirectly).
In regression-test/pipeline/performance/run-clickbench.sh line 46:
pr_num_from_trigger="28431"
^-^ SC2317 (info): Command appears to be
unreachable. Check usage (or ignore if invoked indirectly).
In regression-test/pipeline/performance/run-clickbench.sh line 47:
commit_id_from_trigger="5f5c4c80564c76ff4267fc4ce6a5408498ed1ab5"
^-- SC2317 (info): Command appears to be unreachable. Check usage (or
ignore if invoked indirectly).
In regression-test/pipeline/performance/run-clickbench.sh line 48:
target_branch="master"
^^ SC2317 (info): Command appears to be unreachable.
Check usage (or ignore if invoked indirectly).
In regression-test/pipeline/performance/run-clickbench.sh line 50:
echo " Check env"
^---^ SC2317 (info): Command appears to be unreachable.
Check usage (or ignore if invoked indirectly).
In regression-test/pipeline/performance/run-clickbench.sh line 51:
if [[ -z "${teamcity_build_checkoutDir}" ]]; then echo "ERROR: env
teamcity_build_checkoutDir not set" && exit 1; fi
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore
if invoked indirectly).
^-- SC2317 (info): Command appears to be unreachable. Check usage (or
ignore if invoked indirectly).
^-- SC2317 (info): Command
appears to be unreachable. Check usage (or ignore if invoked indirectly).
^^ SC2317 (info): Command appears to be
unreachable. Check usage (or ignore if invoked indirectly).
In regression-test/pipeline/performance/run-clickbench.sh line 52:
if [[ -z "${pr_num_from_trigger}" ]]; then echo "ERROR: env
pr_num_from_trigger not set" && exit 1; fi
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore
if invoked indirectly).
^-- SC2317 (info): Command appears to be unreachable. Check usage (or
ignore if invoked indirectly).
^-- SC2317 (info): Command
appears to be unreachable. Check usage (or ignore if invoked indirectly).
^^ SC2317 (info): Command appears to be unreachable. Check
usage (or ignore if invoked indirectly).
In regression-test/pipeline/performance/run-clickbench.sh line 53:
if [[ -z "${commit_id_from_trigger}" ]]; then echo "ERROR: env
commit_id_from_trigger not set" && exit 1; fi
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore
if invoked indirectly).
^-- SC2317 (info): Command appears to be unreachable. Check usage (or
ignore if invoked indirectly).
^-- SC2317 (info): Command
appears to be unreachable. Check usage (or ignore if invoked indirectly).
^^ SC2317 (info): Command appears to be unreachable.
Check usage (or ignore if invoked indirectly).
In regression-test/pipeline/performance/run-clickbench.sh line 54:
if [[ -z "${target_branch}" ]]; then echo "ERROR: env target_branch not set"
&& exit 1; fi
^--
Re: [PR] [fix](IO) Fix async close's raii and lazily load jni's jvm max heap value [doris]
github-actions[bot] commented on code in PR #34799:
URL: https://github.com/apache/doris/pull/34799#discussion_r1599399596
##
be/src/io/fs/s3_file_writer.cpp:
##
@@ -242,7 +242,7 @@ Status S3FileWriter::_close_impl() {
}
Status S3FileWriter::appendv(const Slice* data, size_t data_cnt) {
Review Comment:
warning: function 'appendv' has cognitive complexity of 65 (threshold 50)
[readability-function-cognitive-complexity]
```cpp
Status S3FileWriter::appendv(const Slice* data, size_t data_cnt) {
^
```
Additional context
**be/src/io/fs/s3_file_writer.cpp:244:** +1, including nesting penalty of 0,
nesting level increased to 1
```cpp
if (state() != State::OPENED) [[unlikely]] {
^
```
**be/src/io/fs/s3_file_writer.cpp:249:** +1, including nesting penalty of 0,
nesting level increased to 1
```cpp
DBUG_EXECUTE_IF("s3_file_writer::appendv",
^
```
**be/src/util/debug_points.h:35:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) {
\
^
```
**be/src/io/fs/s3_file_writer.cpp:249:** +2, including nesting penalty of 1,
nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("s3_file_writer::appendv",
^
```
**be/src/util/debug_points.h:37:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) {
\
^
```
**be/src/io/fs/s3_file_writer.cpp:251:** +1, including nesting penalty of 0,
nesting level increased to 1
```cpp
for (size_t i = 0; i < data_cnt; i++) {
^
```
**be/src/io/fs/s3_file_writer.cpp:253:** +2, including nesting penalty of 1,
nesting level increased to 2
```cpp
for (size_t pos = 0, data_size_to_append = 0; pos < data_size; pos
+= data_size_to_append) {
^
```
**be/src/io/fs/s3_file_writer.cpp:254:** +3, including nesting penalty of 2,
nesting level increased to 3
```cpp
if (_failed) {
^
```
**be/src/io/fs/s3_file_writer.cpp:257:** +3, including nesting penalty of 2,
nesting level increased to 3
```cpp
if (!_pending_buf) {
^
```
**be/src/io/fs/s3_file_writer.cpp:261:** nesting level increased to 4
```cpp
[part_num = _cur_part_num,
this](UploadFileBuffer& buf) {
^
```
**be/src/io/fs/s3_file_writer.cpp:265:** nesting level increased to 4
```cpp
.set_sync_after_complete_task([this, part_num =
_cur_part_num](Status s) {
^
```
**be/src/io/fs/s3_file_writer.cpp:267:** +5, including nesting penalty of 4,
nesting level increased to 5
```cpp
if (!s.ok()) [[unlikely]] {
^
```
**be/src/io/fs/s3_file_writer.cpp:281:** nesting level increased to 4
```cpp
.set_is_cancelled([this]() { return _failed.load();
});
^
```
**be/src/io/fs/s3_file_writer.cpp:282:** +4, including nesting penalty of 3,
nesting level increased to 4
```cpp
if (_cache_builder != nullptr) {
^
```
**be/src/io/fs/s3_file_writer.cpp:294:** +4, including nesting penalty of 3,
nesting level increased to 4
```cpp
RETURN_IF_ERROR(builder.build(&_pending_buf));
^
```
**be/src/common/status.h:570:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do {\
^
```
**be/src/io/fs/s3_file_writer.cpp:294:** +5, including nesting penalty of 4,
nesting level increased to 5
```cpp
RETURN_IF_ERROR(builder.build(&_pending_buf));
^
```
**be/src/common/status.h:572:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/io/fs/s3_file_writer.cpp:303:** +3, including nesting penalty of 2,
nesting level increased to 3
```cpp
RETURN_IF_ERROR(_pending_buf->append_data(
^
```
**be/src/common/status.h:570:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do {\
^
```
**be/src/io/fs/s3_file_writer.cpp:303:** +4, including nesting penalty of 3,
nesting level increased to 4
```cpp
RETURN_IF_ERROR(_pending_buf->append_data(
^
```
**be/src/common/status.h:572:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/io/fs/s3_file_writer.cpp:309:** +3, including nesting penalty of 2,
nesting level increased to 3
```cpp
if
Re: [PR] [fix](IO) Fix async close's raii and lazily load jni's jvm max heap value [doris]
ByteYue commented on PR #34799: URL: https://github.com/apache/doris/pull/34799#issuecomment-2109310370 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids): clone the producer plan and put logicalAnchor generated by `Or_Expansion` above `logicalSink` [doris]
doris-robot commented on PR #34771: URL: https://github.com/apache/doris/pull/34771#issuecomment-2109307177 TPC-DS: Total hot run time: 187526 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 7af323279b4e0e77dcba60a73b496186ff3c922c, data reload: false query1 911 367 346 346 query2 6457236924192369 query3 6647214 212 212 query4 23123 21176 21128 21128 query5 4135421 421 421 query6 260 171 170 170 query7 4582293 288 288 query8 239 185 193 185 query9 8558245324322432 query10 444 250 271 250 query11 14683 14286 14237 14237 query12 143 89 86 86 query13 1647385 382 382 query14 10634 837084318370 query15 259 171 174 171 query16 8051268 257 257 query17 1856563 532 532 query18 1982273 260 260 query19 204 147 154 147 query20 91 81 85 81 query21 188 125 124 124 query22 5093483947724772 query23 34003 33733 33731 33731 query24 12027 279130342791 query25 645 366 358 358 query26 1746158 161 158 query27 2913318 320 318 query28 7128205220342034 query29 1020614 598 598 query30 307 148 150 148 query31 972 766 738 738 query32 92 54 53 53 query33 735 245 239 239 query34 1047483 496 483 query35 809 685 684 684 query36 1057919 961 919 query37 168 67 68 67 query38 2912275327582753 query39 1616156515561556 query40 271 130 123 123 query41 43 38 38 38 query42 102 95 100 95 query43 562 561 557 557 query44 1250727 745 727 query45 265 255 231 231 query46 1070718 720 718 query47 1954186218711862 query48 369 313 306 306 query49 1190399 396 396 query50 769 383 394 383 query51 6863682966836683 query52 98 93 89 89 query53 347 279 276 276 query54 958 431 438 431 query55 73 71 71 71 query56 242 231 221 221 query57 1247116511441144 query58 230 199 201 199 query59 3515311131633111 query60 255 238 237 237 query61 86 86 86 86 query62 657 482 464 464 query63 307 279 278 278 query64 9760739273977392 query65 3109305830643058 query66 1335342 329 329 query67 15693 14775 15321 14775 query68 4546526 527 526 query69 479 298 304 298 query70 1163104711561047 query71 405 270 256 256 query72 7261259923472347 query73 698 336 339 336 query74 6714615060596059 query75 3476262026252620 query76 2860994 994 994 query77 430 263 275 263 query78 10708 10136 10031 10031 query79 2548519 518 518 query80 1037428 480 428 query81 506 220 220 220 query82 865 96 98 96 query83 240 161 164 161 query84 239 82 87 82 query85 1305264 255 255 query86 443 290 291 290 query87 3293311231263112 query88 4126244024392439 query89 456 378 391 378 query90 1951185 183 183 query91 122 97 96 96 query92 62 47 49 47 query93 1642508 488 488 query94 1252179 185 179 query95 389 297 295 295 query96 588 277 272 272 query97 3137300729842984 query98 244 227 208 208 query99 1124890 922 890 Total cold run time: 286313 ms Total hot run time: 187526 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]
doris-robot commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2109303684 TPC-DS: Total hot run time: 186868 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 38d623b11a871eed01a23810d2318b10e69acac4, data reload: false query1 926 359 342 342 query2 6462243122062206 query3 6651212 210 210 query4 23194 21197 21090 21090 query5 4145425 420 420 query6 267 169 167 167 query7 4576289 299 289 query8 243 186 198 186 query9 8592242724502427 query10 437 256 266 256 query11 14856 14144 14301 14144 query12 139 95 92 92 query13 1660384 377 377 query14 10331 840376907690 query15 280 167 169 167 query16 8186265 262 262 query17 1856551 541 541 query18 2108278 268 268 query19 203 145 149 145 query20 92 83 87 83 query21 192 131 129 129 query22 5070489848594859 query23 34103 33626 33325 33325 query24 11588 287329332873 query25 644 370 367 367 query26 1726161 156 156 query27 2934320 343 320 query28 7675208320562056 query29 1001610 597 597 query30 306 151 156 151 query31 984 760 739 739 query32 97 55 54 54 query33 768 248 249 248 query34 1040496 506 496 query35 836 687 660 660 query36 1050881 905 881 query37 182 75 67 67 query38 2905276527632763 query39 1646158115521552 query40 274 123 124 123 query41 41 38 38 38 query42 107 98 99 98 query43 587 519 558 519 query44 1208722 736 722 query45 275 256 254 254 query46 1087753 727 727 query47 1976188418861884 query48 363 304 302 302 query49 1187397 390 390 query50 762 394 398 394 query51 6907680267256725 query52 97 94 89 89 query53 347 285 285 285 query54 914 434 439 434 query55 109 75 71 71 query56 235 224 223 223 query57 1252112411561124 query58 213 203 200 200 query59 3480325533523255 query60 263 245 240 240 query61 93 88 90 88 query62 674 470 487 470 query63 312 283 284 283 query64 9734742273397339 query65 3141313631003100 query66 1392338 343 338 query67 15535 15154 14938 14938 query68 4701535 529 529 query69 513 308 301 301 query70 1146113810911091 query71 419 281 270 270 query72 7950253623402340 query73 712 331 329 329 query74 6544608761136087 query75 3615266026332633 query76 34121021957 957 query77 625 267 258 258 query78 10630 10126 10070 10070 query79 1731513 518 513 query80 758 436 431 431 query81 507 219 219 219 query82 792 92 90 90 query83 263 160 161 160 query84 231 83 85 83 query85 1538273 262 262 query86 488 291 316 291 query87 3252311031123110 query88 4206248924622462 query89 473 380 388 380 query90 1975187 184 184 query91 132 99 104 99 query92 66 54 49 49 query93 1872510 492 492 query94 1209190 199 190 query95 388 303 303 303 query96 607 278 278 278 query97 3170298729852985 query98 244 226 228 226 query99 1123888 938 888 Total cold run time: 287808 ms Total hot run time: 186868 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]
doris-robot commented on PR #34816: URL: https://github.com/apache/doris/pull/34816#issuecomment-2109301537 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]
starocean999 commented on PR #34816: URL: https://github.com/apache/doris/pull/34816#issuecomment-2109301596 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]
starocean999 opened a new pull request, #34816: URL: https://github.com/apache/doris/pull/34816 ## Proposed changes The last param of AggregateExpression's constructor should be agg function in phase 3 or 4-phase agg ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids): clone the producer plan and put logicalAnchor generated by `Or_Expansion` above `logicalSink` [doris]
doris-robot commented on PR #34771: URL: https://github.com/apache/doris/pull/34771#issuecomment-2109296292 TPC-H: Total hot run time: 39923 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 7af323279b4e0e77dcba60a73b496186ff3c922c, data reload: false -- Round 1 -- q1 17673 436142334233 q2 2031196 198 196 q3 10591 121511971197 q4 10540 729 809 729 q5 7530272626702670 q6 223 138 137 137 q7 1010609 587 587 q8 9393211620742074 q9 9339667965906590 q10 9480375237433743 q11 454 250 245 245 q12 539 216 223 216 q13 17772 292229242922 q14 257 221 232 221 q15 522 484 482 482 q16 525 384 373 373 q17 962 643 692 643 q18 8038732473537324 q19 3882154814861486 q20 650 309 299 299 q21 5073398932763276 q22 353 280 291 280 Total cold run time: 116837 ms Total hot run time: 39923 ms - Round 2, with runtime_filter_mode=off - q1 4328422541674167 q2 385 274 267 267 q3 2972279127922791 q4 1868153116351531 q5 5316527652995276 q6 211 127 128 127 q7 2235187118981871 q8 3189334433463344 q9 8351835584178355 q10 3880368936793679 q11 584 489 496 489 q12 748 580 561 561 q13 16419 295029842950 q14 293 275 270 270 q15 511 474 469 469 q16 482 437 410 410 q17 1765151314621462 q18 7608757673657365 q19 1654149115751491 q20 1984177217541754 q21 4929484948904849 q22 570 478 481 478 Total cold run time: 70282 ms Total hot run time: 53956 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](prepare) fix datetimev2 return err when binary_row_format [doris]
eldenmoon commented on code in PR #34662:
URL: https://github.com/apache/doris/pull/34662#discussion_r1599385168
##
fe/fe-core/src/main/java/org/apache/doris/mysql/MysqlSerializer.java:
##
@@ -298,6 +298,8 @@ public int getMysqlDecimals(Type type) {
case DECIMAL64:
case DECIMAL128:
case DECIMAL256:
+case TIMEV2:
+case DATETIMEV2:
Review Comment:
should not be in `getMysqlDecimals` for TIMEV2 and DATETIMEV2, function used
for decimal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]
doris-robot commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2109293028 TPC-H: Total hot run time: 40653 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 38d623b11a871eed01a23810d2318b10e69acac4, data reload: false -- Round 1 -- q1 17606 423642114211 q2 2015182 186 182 q3 10587 132012671267 q4 10434 829 850 829 q5 7516271026242624 q6 221 140 141 140 q7 1033606 592 592 q8 9687210220972097 q9 8799650264976497 q10 8873373937293729 q11 431 232 237 232 q12 424 221 218 218 q13 17809 297129672967 q14 260 216 232 216 q15 516 473 473 473 q16 501 396 376 376 q17 962 667 682 667 q18 8111744073657365 q19 4481154614791479 q20 655 308 297 297 q21 5101391739933917 q22 342 281 278 278 Total cold run time: 116364 ms Total hot run time: 40653 ms - Round 2, with runtime_filter_mode=off - q1 4341419741864186 q2 367 273 281 273 q3 2980278527122712 q4 1894160015861586 q5 5235525552795255 q6 212 125 130 125 q7 2228187118381838 q8 31803347 q9 8356829882728272 q10 3862372836323632 q11 600 503 495 495 q12 764 624 591 591 q13 17433 296930002969 q14 303 250 265 250 q15 518 472 480 472 q16 515 434 431 431 q17 1790147214721472 q18 7717750473237323 q19 1639148915821489 q20 1933174217511742 q21 4989478948234789 q22 563 489 491 489 Total cold run time: 71419 ms Total hot run time: 53724 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](Nereids): lazy get expression map [doris]
XieJiann commented on PR #34753: URL: https://github.com/apache/doris/pull/34753#issuecomment-2109288060 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bump](fe)upgrade dependencies [doris]
CalvinKirs commented on PR #34800: URL: https://github.com/apache/doris/pull/34800#issuecomment-2109285402 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] FE/BE print the node start time at startup [doris]
rohitrs1983 commented on PR #34499: URL: https://github.com/apache/doris/pull/34499#issuecomment-2109285442 @LemonLiTree can u please review my PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]
doris-robot commented on PR #34814: URL: https://github.com/apache/doris/pull/34814#issuecomment-2109285271 TPC-DS: Total hot run time: 188082 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 12c5fd0dc6733e7c842abefa8238b1767c359651, data reload: false query1 912 371 340 340 query2 7246228024362280 query3 6657209 214 209 query4 23057 21233 21173 21173 query5 4149422 414 414 query6 262 172 172 172 query7 4591313 291 291 query8 234 191 180 180 query9 8482244924292429 query10 435 270 254 254 query11 14747 14353 14151 14151 query12 136 91 92 91 query13 1663386 387 386 query14 10657 774282317742 query15 228 171 171 171 query16 7985273 270 270 query17 1832567 559 559 query18 2025285 280 280 query19 195 160 159 159 query20 94 88 86 86 query21 193 136 125 125 query22 5136486848464846 query23 34096 33667 33816 33667 query24 11777 282329452823 query25 653 372 358 358 query26 1778164 154 154 query27 2994325 330 325 query28 7467206120552055 query29 1079637 597 597 query30 294 150 148 148 query31 966 747 740 740 query32 97 57 52 52 query33 751 248 254 248 query34 1102488 491 488 query35 841 668 682 668 query36 1107913 897 897 query37 276 68 67 67 query38 2922277927962779 query39 1608156515651565 query40 278 125 123 123 query41 41 38 37 37 query42 105 94 97 94 query43 573 532 526 526 query44 1232740 743 740 query45 264 245 246 245 query46 1065742 714 714 query47 1938190218801880 query48 379 303 300 300 query49 1187400 387 387 query50 764 404 394 394 query51 6855680968166809 query52 109 86 92 86 query53 348 283 293 283 query54 958 429 449 429 query55 74 72 74 72 query56 242 225 222 222 query57 1260116411261126 query58 224 206 200 200 query59 3457337931833183 query60 259 234 262 234 query61 90 92 86 86 query62 693 465 464 464 query63 308 281 281 281 query64 9740737573727372 query65 3161310431033103 query66 1385346 337 337 query67 15498 15293 15389 15293 query68 4670539 536 536 query69 478 302 306 302 query70 1122116111191119 query71 409 257 281 257 query72 7250257923502350 query73 706 327 326 326 query74 6586616561236123 query75 3507267326422642 query76 2998103610411036 query77 406 273 267 267 query78 10669 10220 10194 10194 query79 2507523 515 515 query80 899 431 432 431 query81 509 220 219 219 query82 873 93 90 90 query83 273 168 169 168 query84 291 88 84 84 query85 1544272 256 256 query86 463 322 308 308 query87 3277308830833083 query88 4377244924562449 query89 468 374 405 374 query90 2015187 195 187 query91 131 99 100 99 query92 58 51 50 50 query93 1761513 500 500 query94 1159185 187 185 query95 393 293 296 293 query96 591 278 269 269 query97 3234299529982995 query98 237 218 211 211 query99 1146905 918 905 Total cold run time: 288218 ms Total hot run time: 188082 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [regression-test](framework) fix trino connector download bug in multi be [doris]
shuke987 commented on PR #34806: URL: https://github.com/apache/doris/pull/34806#issuecomment-2109283634 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Pick "[fix](IO) Fix async close's raii and lazily load jni's jvm max heap value #34799" [doris]
github-actions[bot] commented on PR #34815: URL: https://github.com/apache/doris/pull/34815#issuecomment-2109279430 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Pick "[fix](IO) Fix async close's raii and lazily load jni's jvm max heap value #34799" [doris]
github-actions[bot] commented on PR #34815: URL: https://github.com/apache/doris/pull/34815#issuecomment-2109279404 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]
zhiqiang- commented on code in PR #34370:
URL: https://github.com/apache/doris/pull/34370#discussion_r1599375169
##
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##
@@ -1466,23 +1469,27 @@ public boolean shouldCancel(List
currentBackends) {
// fragment,
// if any, as well as all plan fragments on remote nodes.
public void cancel() {
-cancel(Types.PPlanFragmentCancelReason.USER_CANCEL);
+cancel(new Status(TStatusCode.CANCELLED, "query is cancelled by
user"));
if (queueToken != null) {
queueToken.signalForCancel();
}
}
@Override
-public void cancel(Types.PPlanFragmentCancelReason cancelReason) {
+public void cancel(Status cancelReason) {
lock();
+if (cancelReason.ok()) {
+throw new RuntimeException("Should use correct cancel reason, but
it is "
Review Comment:
`lock.unlock` before throw exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids): clone the producer plan and put logicalAnchor generated by `Or_Expansion` above `logicalSink` [doris]
XieJiann commented on PR #34771: URL: https://github.com/apache/doris/pull/34771#issuecomment-2109275454 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]
doris-robot commented on PR #34814: URL: https://github.com/apache/doris/pull/34814#issuecomment-2109274831 TPC-H: Total hot run time: 40233 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 12c5fd0dc6733e7c842abefa8238b1767c359651, data reload: false -- Round 1 -- q1 17610 438742854285 q2 2037191 182 182 q3 10508 118811491149 q4 10158 824 732 732 q5 7514265925942594 q6 216 131 133 131 q7 1011570 578 570 q8 9236211020472047 q9 8845652764656465 q10 8880368536893685 q11 449 247 236 236 q12 439 212 208 208 q13 18549 295029702950 q14 253 224 214 214 q15 507 473 481 473 q16 483 387 377 377 q17 961 720 765 720 q18 8196734373607343 q19 6834155515021502 q20 643 312 303 303 q21 5014379439943794 q22 338 273 281 273 Total cold run time: 118681 ms Total hot run time: 40233 ms - Round 2, with runtime_filter_mode=off - q1 4315418241854182 q2 366 264 275 264 q3 2955273627132713 q4 1850158015531553 q5 5255525452815254 q6 210 127 125 125 q7 2252182918881829 q8 3179334633523346 q9 8373830483268304 q10 3906373037263726 q11 577 486 471 471 q12 760 579 558 558 q13 16438 296129692961 q14 305 272 263 263 q15 521 485 466 466 q16 464 406 411 406 q17 1749149414651465 q18 7555748673747374 q19 1659157915011501 q20 1970175317741753 q21 4929469649944696 q22 579 488 489 488 Total cold run time: 70167 ms Total hot run time: 53698 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]
doris-robot commented on PR #34814: URL: https://github.com/apache/doris/pull/34814#issuecomment-2109272821 TeamCity be ut coverage result: Function Coverage: 35.67% (8982/25180) Line Coverage: 27.32% (74256/271756) Region Coverage: 26.56% (38371/144460) Branch Coverage: 23.38% (19570/83704) Coverage Report: http://coverage.selectdb-in.cc/coverage/12c5fd0dc6733e7c842abefa8238b1767c359651_12c5fd0dc6733e7c842abefa8238b1767c359651/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]
doris-robot commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109271182 TPC-DS: Total hot run time: 185826 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit d800e6e5ca1a9ea3d7a140b10a67836f71be69bd, data reload: false query1 913 363 338 338 query2 6473243323072307 query3 6671211 216 211 query4 23081 21063 21237 21063 query5 4174422 418 418 query6 258 174 173 173 query7 4590292 290 290 query8 242 194 189 189 query9 8390243324212421 query10 441 256 264 256 query11 14712 14148 14191 14148 query12 139 93 87 87 query13 1652390 381 381 query14 10675 828967856785 query15 250 163 162 162 query16 8149280 254 254 query17 1854553 543 543 query18 2089271 283 271 query19 242 154 147 147 query20 89 89 85 85 query21 204 133 127 127 query22 5007485748694857 query23 34193 33493 33565 33493 query24 11630 292428342834 query25 639 367 354 354 query26 1753153 150 150 query27 2939322 329 322 query28 7426205720532053 query29 993 610 589 589 query30 301 152 152 152 query31 976 748 744 744 query32 92 51 55 51 query33 741 265 245 245 query34 1050500 490 490 query35 817 684 692 684 query36 1074896 921 896 query37 171 66 67 66 query38 2905273627742736 query39 1637155515431543 query40 279 124 121 121 query41 43 38 37 37 query42 103 96 95 95 query43 563 510 536 510 query44 1207720 742 720 query45 268 254 250 250 query46 1085707 753 707 query47 1973187919051879 query48 371 300 309 300 query49 1190399 400 399 query50 776 392 397 392 query51 6774672767846727 query52 106 90 92 90 query53 352 284 285 284 query54 982 439 425 425 query55 74 73 72 72 query56 237 214 222 214 query57 1242113711431137 query58 231 194 198 194 query59 3395347732773277 query60 261 229 230 229 query61 90 85 86 85 query62 662 472 499 472 query63 303 279 286 279 query64 9768742773677367 query65 3120307130493049 query66 1372351 336 336 query67 15339 15243 14971 14971 query68 4654518 529 518 query69 474 302 311 302 query70 1151114510931093 query71 386 269 269 269 query72 7208251123792379 query73 705 326 322 322 query74 6668611060706070 query75 3395263425912591 query76 2820957 975 957 query77 394 264 260 260 query78 10810 10055 99069906 query79 2505513 504 504 query80 1093427 429 427 query81 515 215 217 215 query82 959 97 90 90 query83 234 162 167 162 query84 237 90 85 85 query85 1275268 278 268 query86 444 295 305 295 query87 3301308530883085 query88 4009248625272486 query89 458 373 381 373 query90 1976188 185 185 query91 124 96 96 96 query92 64 47 50 47 query93 1944507 491 491 query94 1268176 191 176 query95 395 300 304 300 query96 585 271 268 268 query97 3152301029722972 query98 226 220 207 207 query99 1125924 894 894 Total cold run time: 286352 ms Total hot run time: 185826 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [fix](short circurt) fix return default value issue [doris]
doris-robot commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2109266195 TPC-DS: Total hot run time: 186951 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 796ccaa8cb00f478d4ee0905bd3f9bb53de7753b, data reload: false query1 897 378 345 345 query2 6451231022522252 query3 6660201 211 201 query4 22863 21245 21101 21101 query5 4162409 416 409 query6 265 166 175 166 query7 4587296 292 292 query8 243 185 190 185 query9 8509243524532435 query10 424 246 241 241 query11 14809 14193 14199 14193 query12 135 92 86 86 query13 1646378 382 378 query14 9814765683947656 query15 271 166 170 166 query16 8166260 266 260 query17 1883548 525 525 query18 2118293 269 269 query19 261 150 152 150 query20 90 87 87 87 query21 194 133 126 126 query22 5102486749414867 query23 34424 33521 33545 33521 query24 7482287529502875 query25 586 359 363 359 query26 706 150 155 150 query27 2157314 329 314 query28 5405209020792079 query29 858 615 592 592 query30 288 148 150 148 query31 970 746 737 737 query32 96 50 54 50 query33 548 246 249 246 query34 886 487 476 476 query35 756 676 677 676 query36 1074878 899 878 query37 103 66 67 66 query38 2857279127492749 query39 1629155115491549 query40 225 129 123 123 query41 42 38 38 38 query42 102 93 97 93 query43 578 538 553 538 query44 1066725 745 725 query45 264 253 252 252 query46 1067750 716 716 query47 2001185818771858 query48 379 302 294 294 query49 1030398 400 398 query50 775 389 391 389 query51 6825677968166779 query52 99 94 92 92 query53 358 286 283 283 query54 535 429 441 429 query55 73 73 73 73 query56 242 219 222 219 query57 1237113011491130 query58 221 200 205 200 query59 3435317333073173 query60 253 244 271 244 query61 89 88 88 88 query62 632 480 480 480 query63 309 275 284 275 query64 8508735473197319 query65 3165306630823066 query66 820 349 344 344 query67 15650 15460 14928 14928 query68 4595526 530 526 query69 484 301 297 297 query70 1090116411271127 query71 383 263 263 263 query72 7220255623692369 query73 702 329 328 328 query74 6598607661256076 query75 3396263125952595 query76 24941015907 907 query77 442 263 258 258 query78 10548 10158 10079 10079 query79 2426523 511 511 query80 1149450 430 430 query81 536 226 218 218 query82 720 91 93 91 query83 242 171 172 171 query84 241 88 81 81 query85 1455329 365 329 query86 475 317 313 313 query87 3266317730863086 query88 4094245624572456 query89 466 380 399 380 query90 1950187 186 186 query91 120 97 97 97 query92 61 47 47 47 query93 1970503 496 496 query94 1192179 228 179 query95 380 290 299 290 query96 589 282 268 268 query97 3187299129812981 query98 224 218 214 214 query99 1216961 901 901 Total cold run time: 274266 ms Total hot run time: 186951 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]
github-actions[bot] commented on PR #34814: URL: https://github.com/apache/doris/pull/34814#issuecomment-2109263094 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]
yiguolei commented on code in PR #34812:
URL: https://github.com/apache/doris/pull/34812#discussion_r1599364710
##
be/src/runtime/fragment_mgr.cpp:
##
@@ -505,6 +505,7 @@ void
FragmentMgr::_exec_actual(std::shared_ptr fragment_ex
}
Status FragmentMgr::exec_plan_fragment(const TExecPlanFragmentParams& params) {
+DCHECK(config::enable_non_pipeline);
Review Comment:
不是加到这里，streamload 可能没走这里。
应该加到plan fragment executor 里
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]
doris-robot commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109260892 TPC-H: Total hot run time: 40244 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit d800e6e5ca1a9ea3d7a140b10a67836f71be69bd, data reload: false -- Round 1 -- q1 17957 438742094209 q2 2023187 188 187 q3 10471 122011971197 q4 10151 831 756 756 q5 7478265826172617 q6 217 133 136 133 q7 998 566 570 566 q8 9240208420412041 q9 8886650764426442 q10 8996368437133684 q11 455 247 238 238 q12 429 229 223 223 q13 17764 295829422942 q14 268 213 216 213 q15 510 475 465 465 q16 517 391 369 369 q17 959 658 731 658 q18 7984742973837383 q19 5272154314911491 q20 637 311 309 309 q21 5005394838403840 q22 331 281 282 281 Total cold run time: 116548 ms Total hot run time: 40244 ms - Round 2, with runtime_filter_mode=off - q1 4305421841924192 q2 383 276 264 264 q3 2973272727272727 q4 1839158915811581 q5 5220527553585275 q6 209 127 125 125 q7 2198184918941849 q8 3183333233233323 q9 8321834483408340 q10 3872361937033619 q11 585 502 477 477 q12 778 598 560 560 q13 16686 292929762929 q14 284 281 251 251 q15 506 461 459 459 q16 471 425 430 425 q17 1748149814591459 q18 7542749174297429 q19 1688158415031503 q20 1955175117881751 q21 4956478948894789 q22 590 469 466 466 Total cold run time: 70292 ms Total hot run time: 53793 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](block) add check type in block data type and column [doris]
github-actions[bot] commented on PR #34314: URL: https://github.com/apache/doris/pull/34314#issuecomment-2109260591 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]
hubgeter commented on PR #34814: URL: https://github.com/apache/doris/pull/34814#issuecomment-2109257886 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Pick "[fix](IO) Fix async close's raii and lazily load jni's jvm max heap value #34799" [doris]
doris-robot commented on PR #34815: URL: https://github.com/apache/doris/pull/34815#issuecomment-2109257869 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] Pick "[fix](IO) Fix async close's raii and lazily load jni's jvm max heap value #34799" [doris]
ByteYue opened a new pull request, #34815: URL: https://github.com/apache/doris/pull/34815 ## Proposed changes Issue Number: close #xxx same as master #34799 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]
doris-robot commented on PR #34814: URL: https://github.com/apache/doris/pull/34814#issuecomment-2109257763 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. [doris]
hubgeter opened a new pull request, #34814: URL: https://github.com/apache/doris/pull/34814 ## Proposed changes fix this bug: Scenario : iceberg table uses orc storage format sql : `select * from iceberg_orc;` When executing this sql, position delete filter is not performed. Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]
github-actions[bot] commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109255921 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](block) add check type in block data type and column [doris]
Mryange commented on PR #34314: URL: https://github.com/apache/doris/pull/34314#issuecomment-2109255678 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](short circurt) fix return default value issue [doris]
doris-robot commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2109256214 TPC-H: Total hot run time: 39770 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 796ccaa8cb00f478d4ee0905bd3f9bb53de7753b, data reload: false -- Round 1 -- q1 4949468542444244 q2 1829190 183 183 q3 1473115811541154 q4 1180727 733 727 q5 2660271326132613 q6 218 136 136 136 q7 952 528 526 526 q8 9261218621732173 q9 9212652864916491 q10 8974375037373737 q11 445 235 234 234 q12 392 208 215 208 q13 17763 292229462922 q14 265 234 224 224 q15 509 489 479 479 q16 474 386 390 386 q17 962 635 709 635 q18 8190744073607360 q19 6091154414891489 q20 644 303 308 303 q21 5035327033203270 q22 355 276 276 276 Total cold run time: 81833 ms Total hot run time: 39770 ms - Round 2, with runtime_filter_mode=off - q1 4335422841994199 q2 383 273 278 273 q3 2990275127072707 q4 1900160115931593 q5 5277531353065306 q6 218 123 125 123 q7 1782136513611361 q8 3182335933713359 q9 8337834683428342 q10 3867366136663661 q11 596 491 503 491 q12 758 602 596 596 q13 17127 293329762933 q14 290 253 245 245 q15 506 492 460 460 q16 477 404 408 404 q17 1785149014541454 q18 7646753475447534 q19 1661157615721572 q20 1972181917581758 q21 4913486947414741 q22 566 488 488 488 Total cold run time: 70568 ms Total hot run time: 53600 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]
doris-robot commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2109255399 TPC-DS: Total hot run time: 186804 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 38d623b11a871eed01a23810d2318b10e69acac4, data reload: false query1 902 360 352 352 query2 6443237423502350 query3 6686208 209 208 query4 24653 21240 21374 21240 query5 4212418 418 418 query6 265 174 175 174 query7 4587292 283 283 query8 239 187 197 187 query9 8670244424272427 query10 422 252 259 252 query11 14729 14139 14052 14052 query12 133 91 92 91 query13 1677392 381 381 query14 8791802475637563 query15 245 160 169 160 query16 8152262 268 262 query17 1858543 538 538 query18 2059283 263 263 query19 202 149 146 146 query20 93 82 83 82 query21 199 123 125 123 query22 5088488849464888 query23 34061 33392 33502 33392 query24 11636 289328932893 query25 651 367 375 367 query26 1778158 148 148 query27 3025311 326 311 query28 7322206020652060 query29 985 617 594 594 query30 294 149 146 146 query31 972 762 730 730 query32 94 53 54 53 query33 741 258 248 248 query34 1071474 491 474 query35 817 692 657 657 query36 1064920 902 902 query37 169 66 69 66 query38 2866277527772775 query39 1601155615651556 query40 279 123 124 123 query41 44 38 37 37 query42 105 92 103 92 query43 592 539 543 539 query44 1187719 737 719 query45 267 257 254 254 query46 1071714 698 698 query47 1982189819121898 query48 388 308 312 308 query49 1186399 405 399 query50 771 403 387 387 query51 7136675168136751 query52 103 92 94 92 query53 349 280 286 280 query54 891 436 422 422 query55 75 72 72 72 query56 242 217 223 217 query57 1225115111571151 query58 228 214 204 204 query59 3443309533623095 query60 257 234 234 234 query61 90 87 86 86 query62 671 462 497 462 query63 304 288 275 275 query64 9763747073477347 query65 3121306730763067 query66 1371346 329 329 query67 15509 14946 15034 14946 query68 4624524 538 524 query69 468 312 307 307 query70 1194104811771048 query71 391 277 284 277 query72 7322250623912391 query73 699 328 327 327 query74 6511616661396139 query75 3380261625672567 query76 2885940 1058940 query77 408 262 266 262 query78 10604 10190 10017 10017 query79 1877519 517 517 query80 1071435 430 430 query81 501 217 220 217 query82 691 91 91 91 query83 192 159 159 159 query84 264 83 83 83 query85 1389268 272 268 query86 450 307 308 307 query87 3269312030873087 query88 4252247024742470 query89 480 379 378 378 query90 1999195 189 189 query91 188 95 94 94 query92 56 51 47 47 query93 1741513 495 495 query94 1185177 179 177 query95 382 316 296 296 query96 579 271 268 268 query97 3198300730193007 query98 244 221 221 221 query99 1323908 920 908 Total cold run time: 285919 ms Total hot run time: 186804 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]
github-actions[bot] commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109255602 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_node… [doris]
doris-robot commented on PR #34808: URL: https://github.com/apache/doris/pull/34808#issuecomment-2109253558 ClickBench: Total hot run time: 30.64 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 22869ffc1801520ea18fa5ed8b18ffadf0cc156d, data reload: false query1 0.040.040.03 query2 0.080.040.04 query3 0.230.050.05 query4 1.680.070.07 query5 0.500.500.50 query6 1.130.730.73 query7 0.020.020.02 query8 0.060.040.04 query9 0.540.480.50 query10 0.540.540.54 query11 0.160.120.11 query12 0.150.120.12 query13 0.600.590.61 query14 0.790.770.78 query15 0.830.800.81 query16 0.350.360.36 query17 1.021.041.04 query18 0.230.240.25 query19 1.801.701.81 query20 0.010.010.01 query21 15.51 0.690.65 query22 4.097.252.01 query23 18.27 1.381.21 query24 1.950.190.21 query25 0.140.070.09 query26 0.260.160.16 query27 0.080.070.08 query28 13.33 1.011.02 query29 13.08 3.293.29 query30 0.250.060.06 query31 2.880.390.39 query32 3.270.470.47 query33 2.822.822.93 query34 17.12 4.434.45 query35 4.504.494.52 query36 0.650.460.47 query37 0.170.160.16 query38 0.150.140.13 query39 0.050.040.04 query40 0.160.150.15 query41 0.090.050.06 query42 0.050.050.05 query43 0.040.040.04 Total cold run time: 109.67 s Total hot run time: 30.64 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [debug](thrift rpc) debug thrift rpc [doris]
dataroaring commented on PR #34813: URL: https://github.com/apache/doris/pull/34813#issuecomment-2109253250 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [debug](thrift rpc) debug thrift rpc [doris]
doris-robot commented on PR #34813: URL: https://github.com/apache/doris/pull/34813#issuecomment-2109253215 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [debug](thrift rpc) debug thrift rpc [doris]
dataroaring opened a new pull request, #34813: URL: https://github.com/apache/doris/pull/34813 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](short circurt) fix return default value issue [doris]
github-actions[bot] commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2109252694 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]
doris-robot commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109252673 TPC-DS: Total hot run time: 186407 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 2dccaa74b8b674cabd4a0b226ea121e9b311f356, data reload: false query1 910 361 339 339 query2 6438238825312388 query3 6652209 207 207 query4 24452 21382 21259 21259 query5 4141411 418 411 query6 258 188 171 171 query7 4600303 285 285 query8 249 187 191 187 query9 8750241724122412 query10 434 256 252 252 query11 14844 14172 14155 14155 query12 136 91 87 87 query13 1644377 378 377 query14 8903780067586758 query15 208 172 176 172 query16 7802265 264 264 query17 1851591 532 532 query18 1917282 274 274 query19 198 145 147 145 query20 92 87 93 87 query21 195 130 128 128 query22 5025480048784800 query23 34527 33405 33541 33405 query24 11605 294829412941 query25 656 367 361 361 query26 1734166 153 153 query27 3035318 323 318 query28 7645206720602060 query29 1032619 601 601 query30 306 162 153 153 query31 1016760 726 726 query32 88 51 53 51 query33 744 252 254 252 query34 1058484 488 484 query35 815 695 672 672 query36 1078905 922 905 query37 144 63 65 63 query38 2894280427562756 query39 1632155915721559 query40 282 122 130 122 query41 41 35 35 35 query42 105 95 98 95 query43 583 545 540 540 query44 1235723 730 723 query45 267 243 254 243 query46 1080736 722 722 query47 1965189119151891 query48 378 311 295 295 query49 1158394 392 392 query50 776 416 380 380 query51 6824670967256709 query52 99 90 99 90 query53 348 281 273 273 query54 859 432 432 432 query55 73 75 72 72 query56 235 219 223 219 query57 1254116511651165 query58 224 195 197 195 query59 3440321131233123 query60 251 236 235 235 query61 87 88 90 88 query62 673 481 447 447 query63 310 282 280 280 query64 9789742773607360 query65 3118305830823058 query66 1080343 339 339 query67 15452 15365 15138 15138 query68 4614531 544 531 query69 495 292 306 292 query70 1176106211551062 query71 405 264 269 264 query72 7554255123922392 query73 713 330 333 330 query74 6577621060586058 query75 3369264726172617 query76 2844995 1008995 query77 459 263 261 261 query78 10576 10193 10120 10120 query79 2268507 503 503 query80 703 440 434 434 query81 499 216 220 216 query82 811 93 90 90 query83 184 157 163 157 query84 239 86 88 86 query85 1453274 263 263 query86 456 304 317 304 query87 3308310731373107 query88 4228245524532453 query89 464 387 385 385 query90 2019189 190 189 query91 134 109 108 108 query92 67 49 51 49 query93 1808507 493 493 query94 1161252 178 178 query95 383 293 296 293 query96 587 276 269 269 query97 3156300030073000 query98 235 222 217 217 query99 1190907 880 880 Total cold run time: 285829 ms Total hot run time: 186407 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]
Gabriel39 commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109250616 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](short circurt) fix return default value issue [doris]
github-actions[bot] commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2109250432 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]
doris-robot commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109250438 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [conf](pipeline) Disable non-pipeline engine [doris]
Gabriel39 opened a new pull request, #34812: URL: https://github.com/apache/doris/pull/34812 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_node… [doris]
doris-robot commented on PR #34808: URL: https://github.com/apache/doris/pull/34808#issuecomment-2109248120 TPC-DS: Total hot run time: 187929 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 22869ffc1801520ea18fa5ed8b18ffadf0cc156d, data reload: false query1 917 395 359 359 query2 6464239623412341 query3 6654212 206 206 query4 24455 21294 21088 21088 query5 4165420 424 420 query6 267 197 175 175 query7 4587292 284 284 query8 242 202 188 188 query9 8650244524452445 query10 445 256 280 256 query11 14852 14267 14189 14189 query12 138 91 89 89 query13 1636375 361 361 query14 10155 842582758275 query15 253 172 176 172 query16 8169261 268 261 query17 1869567 536 536 query18 2095283 268 268 query19 237 152 150 150 query20 95 84 83 83 query21 201 138 128 128 query22 5113483648384836 query23 34246 33300 33405 33300 query24 11887 285829902858 query25 640 365 397 365 query26 1730162 154 154 query27 2916313 332 313 query28 7394206720742067 query29 992 614 599 599 query30 312 172 176 172 query31 961 762 743 743 query32 88 52 54 52 query33 747 243 242 242 query34 1049478 476 476 query35 802 687 671 671 query36 1047933 913 913 query37 169 72 71 71 query38 2904278127562756 query39 1617154315491543 query40 271 126 124 124 query41 48 41 43 41 query42 104 98 97 97 query43 620 563 563 563 query44 1223734 735 734 query45 266 249 280 249 query46 1113723 707 707 query47 1937191019151910 query48 385 312 297 297 query49 1181392 391 391 query50 772 385 391 385 query51 6917673467306730 query52 110 86 94 86 query53 354 281 279 279 query54 1047424 434 424 query55 73 74 72 72 query56 258 225 221 221 query57 1241112511641125 query58 230 195 195 195 query59 3490339630543054 query60 257 243 249 243 query61 107 107 107 107 query62 677 469 461 461 query63 314 288 286 286 query64 9895747774887477 query65 3196308930873087 query66 1400370 357 357 query67 15427 15025 15220 15025 query68 4572541 545 541 query69 494 311 319 311 query70 1160110611581106 query71 396 276 276 276 query72 7535271524832483 query73 706 328 327 327 query74 6541607361376073 query75 3383261426282614 query76 25161018909 909 query77 405 292 271 271 query78 10735 10200 10073 10073 query79 3088514 524 514 query80 1765469 460 460 query81 529 248 242 242 query82 759 105 106 105 query83 318 170 179 170 query84 274 93 94 93 query85 1836333 457 333 query86 475 368 324 324 query87 3318308931543089 query88 4412246424412441 query89 482 374 378 374 query90 2019187 192 187 query91 132 101 97 97 query92 64 50 47 47 query93 4718503 499 499 query94 1240185 197 185 query95 393 308 307 307 query96 605 274 270 270 query97 3201302929712971 query98 250 218 215 215 query99 1289904 890 890 Total cold run time: 293683 ms Total hot run time: 187929 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Improvement](pipeline) blocking tasks before putting in runnable queue [doris]
doris-robot commented on PR #34805: URL: https://github.com/apache/doris/pull/34805#issuecomment-2109247584 TPC-DS: Total hot run time: 186686 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 0f298fcefff68ad91259878f3de181fb89965987, data reload: false query1 899 361 342 342 query2 6445224522632245 query3 6654215 213 213 query4 24722 21091 21293 21091 query5 4133415 417 415 query6 258 192 164 164 query7 4583289 286 286 query8 257 190 188 188 query9 8567243923992399 query10 423 242 261 242 query11 14720 14106 14105 14105 query12 147 87 86 86 query13 1662371 368 368 query14 8780857476377637 query15 279 170 172 170 query16 8152261 246 246 query17 1872543 540 540 query18 2090271 272 271 query19 214 140 145 140 query20 91 99 84 84 query21 194 129 125 125 query22 5071485248994852 query23 34066 33644 33567 33567 query24 10718 284828552848 query25 612 385 354 354 query26 1442156 148 148 query27 2983318 323 318 query28 7238204720422042 query29 912 608 613 608 query30 284 152 157 152 query31 970 743 738 738 query32 97 53 53 53 query33 741 246 257 246 query34 1056471 471 471 query35 811 682 684 682 query36 1084923 967 923 query37 137 63 70 63 query38 2875279327612761 query39 1646156215721562 query40 267 130 124 124 query41 38 36 40 36 query42 101 93 96 93 query43 546 519 529 519 query44 1268717 723 717 query45 262 255 255 255 query46 1077705 705 705 query47 1945192618981898 query48 373 303 309 303 query49 1125396 398 396 query50 782 372 380 372 query51 6829671966876687 query52 102 89 90 89 query53 348 279 274 274 query54 956 419 416 416 query55 71 72 74 72 query56 264 220 215 215 query57 1256114611461146 query58 224 195 198 195 query59 3388308933603089 query60 258 230 235 230 query61 91 87 88 87 query62 675 477 458 458 query63 311 280 289 280 query64 9878741373227322 query65 3199310031083100 query66 1374339 346 339 query67 15561 14894 15350 14894 query68 4606526 532 526 query69 486 303 296 296 query70 1112107811641078 query71 397 283 275 275 query72 7971255124112411 query73 694 327 326 326 query74 6637625661556155 query75 3480264726262626 query76 2868921 958 921 query77 408 259 255 255 query78 10556 10202 10134 10134 query79 2484509 507 507 query80 1022438 421 421 query81 510 224 231 224 query82 703 91 99 91 query83 237 158 164 158 query84 237 92 87 87 query85 1654268 276 268 query86 515 321 308 308 query87 3278312330743074 query88 4251244424362436 query89 462 372 374 372 query90 1994179 182 179 query91 123 95 98 95 query92 62 48 47 47 query93 2040515 487 487 query94 1204180 181 180 query95 392 299 296 296 query96 597 271 272 271 query97 3208300730343007 query98 234 226 214 214 query99 1151911 905 905 Total cold run time: 286027 ms Total hot run time: 186686 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [fix](short circurt) fix return default value issue [doris]
felixwluo commented on code in PR #34186:
URL: https://github.com/apache/doris/pull/34186#discussion_r1599352464
##
be/src/vec/data_types/serde/data_type_nullable_serde.cpp:
##
@@ -238,13 +238,14 @@ void DataTypeNullableSerDe::write_one_cell_to_jsonb(const
IColumn& column, Jsonb
Arena* mem_pool, int32_t
col_id,
int row_num) const {
auto& nullable_col = assert_cast(column);
+result.writeKey(col_id);
if (nullable_col.is_null_at(row_num)) {
// do not insert to jsonb
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]
github-actions[bot] commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109246240 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]
github-actions[bot] commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109246269 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]
doris-robot commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2109244787 TPC-H: Total hot run time: 40312 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 38d623b11a871eed01a23810d2318b10e69acac4, data reload: false -- Round 1 -- q1 17898 440141934193 q2 2033191 193 191 q3 10533 122311831183 q4 10528 772 756 756 q5 7685272326572657 q6 218 135 133 133 q7 962 548 529 529 q8 9257215320882088 q9 9158664565966596 q10 9285375336343634 q11 483 247 237 237 q12 422 216 221 216 q13 17784 295929762959 q14 266 215 220 215 q15 508 473 475 473 q16 525 388 384 384 q17 957 692 749 692 q18 8054729173167291 q19 3675152614931493 q20 652 306 313 306 q21 4979380739573807 q22 353 279 279 279 Total cold run time: 116215 ms Total hot run time: 40312 ms - Round 2, with runtime_filter_mode=off - q1 4332423842024202 q2 385 270 275 270 q3 2952279727192719 q4 1841156615981566 q5 5268526752625262 q6 210 126 125 125 q7 1715136613711366 q8 3226334233143314 q9 8396830683438306 q10 3875365836143614 q11 571 488 490 488 q12 736 578 598 578 q13 17387 292729832927 q14 286 249 251 249 q15 512 481 470 470 q16 464 415 418 415 q17 1737149114641464 q18 7643749974227422 q19 1706150915481509 q20 1948173918331739 q21 4917484048764840 q22 551 494 477 477 Total cold run time: 70658 ms Total hot run time: 53322 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]
xzj7019 commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109243674 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]
doris-robot commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109243595 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]
xzj7019 opened a new pull request, #34811: URL: https://github.com/apache/doris/pull/34811 ## Proposed changes fix misunderstanding about bothSideShuffleKeysAreSameOrder, which originally should ensure the order of shuffle column lists. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]
doris-robot commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109242079 TPC-H: Total hot run time: 39964 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 2dccaa74b8b674cabd4a0b226ea121e9b311f356, data reload: false -- Round 1 -- q1 17606 432842274227 q2 2026195 186 186 q3 10659 122312561223 q4 10285 763 822 763 q5 7527269627652696 q6 220 133 133 133 q7 990 617 593 593 q8 9461210020872087 q9 8966663665966596 q10 9368363636683636 q11 466 246 229 229 q12 453 225 215 215 q13 17769 292930302929 q14 263 224 226 224 q15 507 474 467 467 q16 520 390 407 390 q17 963 758 684 684 q18 8228752274087408 q19 4243154214851485 q20 642 310 310 310 q21 4995382432103210 q22 350 273 277 273 Total cold run time: 116507 ms Total hot run time: 39964 ms - Round 2, with runtime_filter_mode=off - q1 4389419542224195 q2 368 267 277 267 q3 2991278427092709 q4 1858158716101587 q5 5288530253015301 q6 208 123 124 123 q7 2246187718571857 q8 3172335633783356 q9 8368840983668366 q10 3944369936953695 q11 586 507 494 494 q12 762 586 554 554 q13 16380 295929452945 q14 303 273 266 266 q15 536 477 474 474 q16 494 416 430 416 q17 1786146914951469 q18 7716747274837472 q19 1646157115761571 q20 1976177317201720 q21 4823484848304830 q22 579 504 492 492 Total cold run time: 70419 ms Total hot run time: 54159 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_node… [doris]
doris-robot commented on PR #34808: URL: https://github.com/apache/doris/pull/34808#issuecomment-2109241228 TeamCity be ut coverage result: Function Coverage: 35.67% (8982/25180) Line Coverage: 27.32% (74252/271741) Region Coverage: 26.55% (38356/14) Branch Coverage: 23.37% (19562/83696) Coverage Report: http://coverage.selectdb-in.cc/coverage/22869ffc1801520ea18fa5ed8b18ffadf0cc156d_22869ffc1801520ea18fa5ed8b18ffadf0cc156d/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](outfile) Fix the timing of setting the `_is_closed` flag in Parquet/ORC writer [doris]
github-actions[bot] commented on PR #34668: URL: https://github.com/apache/doris/pull/34668#issuecomment-2109240691 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](outfile) Fix the timing of setting the `_is_closed` flag in Parquet/ORC writer [doris]
github-actions[bot] commented on PR #34668: URL: https://github.com/apache/doris/pull/34668#issuecomment-2109240668 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]
github-actions[bot] commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109239856 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](short circurt) fix return default value issue [doris]
eldenmoon commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2109239624 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](short circurt) fix return default value issue [doris]
eldenmoon commented on code in PR #34186:
URL: https://github.com/apache/doris/pull/34186#discussion_r1599347871
##
be/src/vec/data_types/serde/data_type_nullable_serde.cpp:
##
@@ -238,13 +238,14 @@ void DataTypeNullableSerDe::write_one_cell_to_jsonb(const
IColumn& column, Jsonb
Arena* mem_pool, int32_t
col_id,
int row_num) const {
auto& nullable_col = assert_cast(column);
+result.writeKey(col_id);
if (nullable_col.is_null_at(row_num)) {
// do not insert to jsonb
Review Comment:
remove this comment ，since null should be written
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jdbc catalog) fix jdbc table checksum and query jdbc tvf [doris]
morningman merged PR #34779: URL: https://github.com/apache/doris/pull/34779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]
github-actions[bot] commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109238157 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_node… [doris]
doris-robot commented on PR #34808: URL: https://github.com/apache/doris/pull/34808#issuecomment-2109238193 TPC-H: Total hot run time: 41420 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 22869ffc1801520ea18fa5ed8b18ffadf0cc156d, data reload: false -- Round 1 -- q1 18128 446942534253 q2 2013180 195 180 q3 10630 122112311221 q4 10867 767 770 767 q5 7536273926882688 q6 224 137 141 137 q7 1037628 590 590 q8 9382216021152115 q9 9714722471617161 q10 9115364836773648 q11 452 238 232 232 q12 519 223 223 223 q13 17768 292729682927 q14 254 213 216 213 q15 516 489 486 486 q16 513 380 377 377 q17 950 693 760 693 q18 7926740874287408 q19 1636149114871487 q20 656 308 304 304 q21 5263406240294029 q22 345 281 287 281 Total cold run time: 115444 ms Total hot run time: 41420 ms - Round 2, with runtime_filter_mode=off - q1 4388420842144208 q2 365 264 279 264 q3 2993277227372737 q4 1878161615961596 q5 5264529652565256 q6 214 127 130 127 q7 2236186318851863 q8 3186333833193319 q9 8913895888708870 q10 3872371736523652 q11 594 489 500 489 q12 738 606 587 587 q13 16701 298229502950 q14 289 268 259 259 q15 519 472 476 472 q16 478 419 420 419 q17 1758150514781478 q18 7602759176117591 q19 1711156715771567 q20 1958176317841763 q21 4789486250034862 q22 567 493 496 493 Total cold run time: 71013 ms Total hot run time: 54822 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [fix](jdbc catalog) fix jdbc table checksum and query jdbc tvf (#34779)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new fc5cde42eea [fix](jdbc catalog) fix jdbc table checksum and query jdbc
tvf (#34779)
fc5cde42eea is described below
commit fc5cde42eeace3e7f677e5e87ff7fea5e422140c
Author: zy-kkk
AuthorDate: Tue May 14 12:04:43 2024 +0800
[fix](jdbc catalog) fix jdbc table checksum and query jdbc tvf (#34779)
Fix jdbc table checksum not being set, optimize query tvf error reporting
order
---
.../apache/doris/datasource/jdbc/JdbcExternalCatalog.java| 1 +
.../apache/doris/tablefunction/QueryTableValueFunction.java | 12 ++--
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/JdbcExternalCatalog.java
b/fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/JdbcExternalCatalog.java
index 1a8cde4d03b..e9b17497cf8 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/JdbcExternalCatalog.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/JdbcExternalCatalog.java
@@ -309,6 +309,7 @@ public class JdbcExternalCatalog extends ExternalCatalog {
jdbcTable.setJdbcPasswd(this.getJdbcPasswd());
jdbcTable.setDriverClass(this.getDriverClass());
jdbcTable.setDriverUrl(this.getDriverUrl());
+jdbcTable.setCheckSum(this.getCheckSum());
jdbcTable.setResourceName(this.getResource());
jdbcTable.setConnectionPoolMinSize(this.getConnectionPoolMinSize());
jdbcTable.setConnectionPoolMaxSize(this.getConnectionPoolMaxSize());
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/tablefunction/QueryTableValueFunction.java
b/fe/fe-core/src/main/java/org/apache/doris/tablefunction/QueryTableValueFunction.java
index 3865d0b25c6..cb0f5100229 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/tablefunction/QueryTableValueFunction.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/tablefunction/QueryTableValueFunction.java
@@ -44,12 +44,6 @@ public abstract class QueryTableValueFunction extends
TableValuedFunctionIf {
protected final String query;
public QueryTableValueFunction(Map params) throws
AnalysisException {
-if (params.size() != 2) {
-throw new AnalysisException("Query TableValueFunction must have 2
arguments: 'catalog' and 'query'");
-}
-if (!params.containsKey(CATALOG) || !params.containsKey(QUERY)) {
-throw new AnalysisException("Query TableValueFunction must have 2
arguments: 'catalog' and 'query'");
-}
String catalogName = params.get(CATALOG);
this.query = params.get(QUERY);
this.catalogIf =
Env.getCurrentEnv().getCatalogMgr().getCatalog(catalogName);
@@ -57,6 +51,12 @@ public abstract class QueryTableValueFunction extends
TableValuedFunctionIf {
public static QueryTableValueFunction
createQueryTableValueFunction(Map params)
throws AnalysisException {
+if (params.size() != 2) {
+throw new AnalysisException("Query TableValueFunction must have 2
arguments: 'catalog' and 'query'");
+}
+if (!params.containsKey(CATALOG) || !params.containsKey(QUERY)) {
+throw new AnalysisException("Query TableValueFunction must have 2
arguments: 'catalog' and 'query'");
+}
String catalogName = params.get(CATALOG);
// check priv
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]
github-actions[bot] commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109238175 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) support topn-filter for external table [doris]
doris-robot commented on PR #34674: URL: https://github.com/apache/doris/pull/34674#issuecomment-2109238117 TPC-DS: Total hot run time: 187237 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 894118585a0c5500510a41d3a0081bdad8c5c94e, data reload: false query1 905 358 337 337 query2 6458249022842284 query3 6637203 209 203 query4 23322 21191 21251 21191 query5 4134411 416 411 query6 258 168 170 168 query7 4578291 290 290 query8 246 186 202 186 query9 8733243024072407 query10 434 248 239 239 query11 14794 14255 14220 14220 query12 145 91 90 90 query13 1667390 384 384 query14 10541 768770437043 query15 214 166 167 166 query16 7822279 254 254 query17 1740550 534 534 query18 1880269 264 264 query19 211 144 145 144 query20 99 85 88 85 query21 192 126 128 126 query22 5006491247864786 query23 34194 33358 33453 33358 query24 6622297729112911 query25 540 365 367 365 query26 705 156 156 156 query27 1914315 332 315 query28 3535210720752075 query29 829 594 588 588 query30 220 157 155 155 query31 981 748 752 748 query32 93 76 53 53 query33 485 247 249 247 query34 879 476 483 476 query35 774 667 660 660 query36 1065888 878 878 query37 99 69 66 66 query38 2876280527582758 query39 1614155915661559 query40 193 125 125 125 query41 41 40 37 37 query42 103 94 95 94 query43 571 535 546 535 query44 1047717 733 717 query45 263 257 254 254 query46 1062732 728 728 query47 1975185518981855 query48 388 303 300 300 query49 772 387 385 385 query50 767 383 389 383 query51 6802670066016601 query52 103 90 95 90 query53 348 283 288 283 query54 535 441 428 428 query55 79 75 72 72 query56 248 261 223 223 query57 1279114911761149 query58 211 203 202 202 query59 3673361232663266 query60 253 234 238 234 query61 90 88 85 85 query62 590 503 474 474 query63 306 283 287 283 query64 8461753674287428 query65 3150308831143088 query66 781 346 334 334 query67 15589 15279 15125 15125 query68 4554538 521 521 query69 488 297 307 297 query70 1105112411061106 query71 401 274 267 267 query72 8160268824852485 query73 725 331 336 331 query74 7072661466136613 query75 3420272126572657 query76 2466982 956 956 query77 1504265 268 265 query78 10825 10191 10101 10101 query79 2076509 506 506 query80 1588435 428 428 query81 491 222 219 219 query82 694 96 91 91 query83 268 160 160 160 query84 267 90 83 83 query85 1733266 269 266 query86 524 290 306 290 query87 3287312231543122 query88 4341245224422442 query89 467 387 399 387 query90 2074188 190 188 query91 131 109 108 108 query92 64 50 51 50 query93 2747504 502 502 query94 1253190 186 186 query95 401 304 300 300 query96 599 272 275 272 query97 3165297529822975 query98 245 288 210 210 query99 1225895 905 895 Total cold run time: 275481 ms Total hot run time: 187237 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Improvement](pipeline) blocking tasks before putting in runnable queue [doris]
doris-robot commented on PR #34805: URL: https://github.com/apache/doris/pull/34805#issuecomment-2109237776 TPC-H: Total hot run time: 39843 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 0f298fcefff68ad91259878f3de181fb89965987, data reload: false -- Round 1 -- q1 17603 437542624262 q2 2030196 190 190 q3 10540 118711941187 q4 10676 767 768 767 q5 7571271226872687 q6 216 131 132 131 q7 1021590 573 573 q8 9392210220752075 q9 9322666864756475 q10 8954369937653699 q11 449 241 241 241 q12 488 216 219 216 q13 17814 300129652965 q14 253 216 223 216 q15 496 485 466 466 q16 532 401 379 379 q17 973 726 700 700 q18 7937750173567356 q19 2460152915281528 q20 670 307 295 295 q21 5113315839243158 q22 352 277 279 277 Total cold run time: 114862 ms Total hot run time: 39843 ms - Round 2, with runtime_filter_mode=off - q1 4322419442064194 q2 360 275 272 272 q3 2980277327602760 q4 1914159015861586 q5 5295528053045280 q6 217 124 123 123 q7 2255186818631863 q8 3187335533883355 q9 8356837783538353 q10 3895366736403640 q11 569 497 484 484 q12 791 590 566 566 q13 16303 298229782978 q14 280 260 275 260 q15 510 482 470 470 q16 472 410 413 410 q17 1783148814741474 q18 7533744073467346 q19 1647157014841484 q20 1965182818211821 q21 5007488847514751 q22 547 454 473 454 Total cold run time: 70188 ms Total hot run time: 53924 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (b9deb890218 -> 61fdbfe40cf)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from b9deb890218 [fix](runtimefilter)slot comparison bug #34791 add 61fdbfe40cf [fix](catalog) fix potential catalog cache dead lock #34609 (#34609) No new revisions were added by this update. Summary of changes: .../java/org/apache/doris/datasource/ExternalCatalog.java | 15 ++- .../org/apache/doris/datasource/ExternalDatabase.java | 15 ++- .../test/java/org/apache/doris/catalog/RefreshDbTest.java | 2 +- .../org/apache/doris/datasource/RefreshCatalogTest.java | 2 +- 4 files changed, 22 insertions(+), 12 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](catalog) fix potential catalog cache dead lock [doris]
morningman merged PR #34609: URL: https://github.com/apache/doris/pull/34609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](split) get file splits in batch mode [doris]
github-actions[bot] commented on PR #34032: URL: https://github.com/apache/doris/pull/34032#issuecomment-2109236186 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](catalog) fix potential catalog cache dead lock [doris]
github-actions[bot] commented on PR #34609: URL: https://github.com/apache/doris/pull/34609#issuecomment-2109236104 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](short circurt) fix return default value issue [doris]
github-actions[bot] commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2109233507 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]
github-actions[bot] commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109233348 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]
github-actions[bot] commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2109232160 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]
github-actions[bot] commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109231494 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Pick](repeat) fix core dump coz output slot'order on repeat node not match with pre repeat exprs [doris]
doris-robot commented on PR #34803: URL: https://github.com/apache/doris/pull/34803#issuecomment-2109230370 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit e786cdb7d0949499b96b84b8529a7ae2dbabc951 with default session variables Stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s Insert into select: 21.0 seconds inserted 1000 Rows, about 476K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](short circurt) fix return default value issue [doris]
felixwluo commented on PR #34186: URL: https://github.com/apache/doris/pull/34186#issuecomment-2109229712 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) support topn-filter for external table [doris]
doris-robot commented on PR #34674: URL: https://github.com/apache/doris/pull/34674#issuecomment-2109228862 TPC-H: Total hot run time: 41575 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 894118585a0c5500510a41d3a0081bdad8c5c94e, data reload: false -- Round 1 -- q1 9852433642404240 q2 1647190 196 190 q3 2633116511411141 q4 4998753 785 753 q5 3675288927312731 q6 219 139 140 139 q7 1045601 588 588 q8 4484212921242124 q9 6878673366836683 q10 9077392738113811 q11 463 250 226 226 q12 393 208 211 208 q13 16380 315231543152 q14 265 221 217 217 q15 517 479 475 475 q16 506 412 399 399 q17 970 632 745 632 q18 8344781679087816 q19 1642153715401537 q20 690 313 319 313 q21 5167391542063915 q22 378 285 292 285 Total cold run time: 80223 ms Total hot run time: 41575 ms - Round 2, with runtime_filter_mode=off - q1 4454437343134313 q2 376 288 284 284 q3 3146282127012701 q4 1873155115951551 q5 5292528852685268 q6 210 119 122 119 q7 2233185518961855 q8 3168332533253325 q9 8312830982728272 q10 3841369836383638 q11 608 499 493 493 q12 742 572 583 572 q13 17280 297329652965 q14 290 251 255 251 q15 519 457 474 457 q16 483 426 415 415 q17 1761149514561456 q18 7690758874397439 q19 1641154515871545 q20 1935179817411741 q21 4812476349134763 q22 565 494 471 471 Total cold run time: 71231 ms Total hot run time: 53894 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]
zhangstar333 commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2109228151 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Pick](repeat) fix core dump coz output slot'order on repeat node not match with pre repeat exprs [doris]
doris-robot commented on PR #34803: URL: https://github.com/apache/doris/pull/34803#issuecomment-2109227647 ClickBench: Total hot run time: 31.77 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit e786cdb7d0949499b96b84b8529a7ae2dbabc951, data reload: false query1 0.020.030.02 query2 0.070.030.02 query3 0.250.050.04 query4 1.800.070.06 query5 0.540.530.52 query6 1.260.680.62 query7 0.010.020.01 query8 0.030.030.02 query9 0.540.470.48 query10 0.540.520.52 query11 0.120.080.08 query12 0.110.080.08 query13 0.620.620.61 query14 0.780.810.79 query15 0.780.760.76 query16 0.390.360.36 query17 1.000.971.00 query18 0.230.250.24 query19 1.921.871.86 query20 0.010.010.01 query21 15.58 0.540.56 query22 2.042.051.57 query23 17.23 0.940.82 query24 5.072.203.43 query25 0.370.100.04 query26 0.870.160.15 query27 0.030.030.05 query28 4.740.810.71 query29 12.65 2.312.35 query30 0.560.560.53 query31 2.800.380.38 query32 3.390.500.49 query33 3.083.083.08 query34 15.28 4.784.77 query35 4.834.874.83 query36 1.051.021.02 query37 0.060.040.05 query38 0.040.010.02 query39 0.020.020.01 query40 0.160.140.14 query41 0.060.020.01 query42 0.020.010.01 query43 0.020.020.02 Total cold run time: 100.97 s Total hot run time: 31.77 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]
DarvenDuan commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109227246 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]
doris-robot commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2109226932 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]
zhangstar333 opened a new pull request, #34810: URL: https://github.com/apache/doris/pull/34810 if the user input big value of length, maybe cause some memory problem or exceeded size limit of thrift, so add this check to report error for user firstly. ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]
github-actions[bot] commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109226623 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [opt](fe) exit FE when transfer to (non)master failed [doris]
morningman opened a new pull request, #34809: URL: https://github.com/apache/doris/pull/34809 ## Proposed changes 1. If there is exception thrown when doing `transferToMaster` or `tranferToNonMaster`, we should catch it and exit the FE process. Otherwise, the statelistener thread will exit and FE will be in unknown state. The log is still rolling but user can not connect to FE. 2. Remove redundant error info to avoid error msg too long ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]
doris-robot commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109225839 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Pick](repeat) fix core dump coz output slot'order on repeat node not match with pre repeat exprs [doris]
doris-robot commented on PR #34803: URL: https://github.com/apache/doris/pull/34803#issuecomment-2109222711 TPC-DS: Total hot run time: 202378 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit e786cdb7d0949499b96b84b8529a7ae2dbabc951, data reload: false query1 927 383 369 369 query2 6542289127782778 query3 6927211 207 207 query4 20968 18022 17984 17984 query5 19727 650365056503 query6 288 213 222 213 query7 4160305 311 305 query8 268 270 258 258 query9 3142270826352635 query10 422 277 303 277 query11 11263 10618 10651 10618 query12 120 82 69 69 query13 5582692 692 692 query14 18142 13577 13261 13261 query15 376 231 221 221 query16 6453267 255 255 query17 17571462856 856 query18 2329406 405 405 query19 215 148 145 145 query20 79 75 78 75 query21 193 96 89 89 query22 5272502750655027 query23 32508 31867 31767 31767 query24 7011650765946507 query25 506 418 408 408 query26 528 163 157 157 query27 1860296 297 296 query28 6137236823112311 query29 2900266628492666 query30 245 162 168 162 query31 911 734 710 710 query32 65 63 61 61 query33 399 250 252 250 query34 852 481 475 475 query35 1109914 878 878 query36 1314108010551055 query37 96 64 58 58 query38 3023290329132903 query39 1366133313241324 query40 196 86 98 86 query41 39 35 35 35 query42 86 82 86 82 query43 662 804 778 778 query44 1122712 711 711 query45 243 232 223 223 query46 1224972 966 966 query47 1843164917911649 query48 1017725 696 696 query49 611 376 366 366 query50 873 599 592 592 query51 4693465746804657 query52 86 91 83 83 query53 453 318 317 317 query54 2649244724512447 query55 96 80 90 80 query56 236 235 218 218 query57 12511060997 997 query58 221 220 193 193 query59 4274367438723674 query60 202 196 202 196 query61 90 80 80 80 query62 825 535 483 483 query63 469 339 339 339 query64 2402150914711471 query65 3639356535733565 query66 799 373 377 373 query67 16069 15444 16115 15444 query68 8884649 653 649 query69 570 340 350 340 query70 1594146912901290 query71 403 306 320 306 query72 6564339133923391 query73 736 347 323 323 query74 6334579658665796 query75 5234366436833664 query76 5477113412031134 query77 913 253 259 253 query78 12316 11590 12121 11590 query79 7182636 644 636 query80 956 396 396 396 query81 500 237 233 233 query82 152396 100 96 query83 183 132 135 132 query84 261 70 68 68 query85 846 291 293 291 query86 315 301 295 295 query87 3255299330432993 query88 4792234523442344 query89 351 294 280 280 query90 1918208 206 206 query91 167 144 137 137 query92 59 46 52 46 query93 4593575 534 534 query94 647 207 201 201 query95 1113105810461046 query96 650 336 323 323 query97 6466627664256276 query98 182 176 175 175 query99 2864912 903 903 Total cold run time: 310200 ms Total hot run time: 202378 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [Bug](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_node… [doris]
github-actions[bot] commented on PR #34808: URL: https://github.com/apache/doris/pull/34808#issuecomment-2109222680 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
