Re: [PR] [Refactor](Variant) refactor flush logic to support partial update [doris]
doris-robot commented on PR #34925: URL: https://github.com/apache/doris/pull/34925#issuecomment-2114059723 TeamCity be ut coverage result: Function Coverage: 35.70% (9001/25215) Line Coverage: 27.36% (74476/272169) Region Coverage: 26.61% (38505/144704) Branch Coverage: 23.44% (19647/83836) Coverage Report: http://coverage.selectdb-in.cc/coverage/78b2c79c10b9ba4c07f1a00863e8b659856cbc91_78b2c79c10b9ba4c07f1a00863e8b659856cbc91/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improve](inverted index) improve performance by introducing bulk contains for bitmap in _build_index_result_column [doris]
doris-robot commented on PR #34831: URL: https://github.com/apache/doris/pull/34831#issuecomment-2114059232 TeamCity be ut coverage result: Function Coverage: 35.70% (8998/25206) Line Coverage: 27.37% (74460/272044) Region Coverage: 26.61% (38483/144644) Branch Coverage: 23.43% (19634/83802) Coverage Report: http://coverage.selectdb-in.cc/coverage/4a190ab6fb183794019991c174c806fd544d9cd7_4a190ab6fb183794019991c174c806fd544d9cd7/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](cmd) add UNSET_VARIABLE statement to set back variables [doris]
Yulei-Yang commented on PR #34949: URL: https://github.com/apache/doris/pull/34949#issuecomment-2114033568 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](cmd) add UNSET_VARIABLE statement to set back variables [doris]
doris-robot commented on PR #34949: URL: https://github.com/apache/doris/pull/34949#issuecomment-2114032790 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [feature](cmd) add UNSET_VARIABLE statement to set back variables [doris]
Yulei-Yang opened a new pull request, #34949: URL: https://github.com/apache/doris/pull/34949 ## Proposed changes bp #27552 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](exec) opt const expr exec in set operator [doris]
github-actions[bot] commented on PR #34823: URL: https://github.com/apache/doris/pull/34823#issuecomment-2114023765 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](exec) opt const expr exec in set operator [doris]
github-actions[bot] commented on PR #34823: URL: https://github.com/apache/doris/pull/34823#issuecomment-2114023739 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]
github-actions[bot] commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2114019372 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]
Gabriel39 commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2114013033 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] refactor to support partial update [doris]
eldenmoon commented on PR #34925: URL: https://github.com/apache/doris/pull/34925#issuecomment-211400 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids): fix ColumnPruningPostProcessor [doris]
jackwener commented on PR #34906: URL: https://github.com/apache/doris/pull/34906#issuecomment-2114001747 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] refactor to support partial update [doris]
github-actions[bot] commented on code in PR #34925:
URL: https://github.com/apache/doris/pull/34925#discussion_r1602588713
##
be/src/vec/common/schema_util.cpp:
##
@@ -483,25 +486,8 @@ Status get_least_common_schema(const
std::vector& schemas,
return Status::OK();
}
-Status parse_and_encode_variant_columns(Block& block, const std::vector&
variant_pos,
-const ParseContext& ctx) {
-try {
-// Parse each variant column from raw string column
-RETURN_IF_ERROR(vectorized::schema_util::parse_variant_columns(block,
variant_pos, ctx));
-vectorized::schema_util::finalize_variant_columns(block, variant_pos,
- false /*not ingore
sparse*/);
-RETURN_IF_ERROR(
-
vectorized::schema_util::encode_variant_sparse_subcolumns(block, variant_pos));
-} catch (const doris::Exception& e) {
-// TODO more graceful, max_filter_ratio
-LOG(WARNING) << "encounter execption " << e.to_string();
-return Status::InternalError(e.to_string());
-}
-return Status::OK();
-}
-
-Status parse_variant_columns(Block& block, const std::vector& variant_pos,
- const ParseContext& ctx) {
+Status _parse_variant_columns(Block& block, const std::vector&
variant_pos,
Review Comment:
warning: function '_parse_variant_columns' has cognitive complexity of 59
(threshold 50) [readability-function-cognitive-complexity]
```cpp
Status _parse_variant_columns(Block& block, const std::vector&
variant_pos,
^
```
Additional context
**be/src/vec/common/schema_util.cpp:490:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
for (int i = 0; i < variant_pos.size(); ++i) {
^
```
**be/src/vec/common/schema_util.cpp:500:** nesting level increased to 2
```cpp
auto encode_rowstore = [&]() {
^
```
**be/src/vec/common/schema_util.cpp:501:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
if (!ctx.record_raw_json_column) {
^
```
**be/src/vec/common/schema_util.cpp:505:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
if (record_raw_string_with_serialization) {
^
```
**be/src/vec/common/schema_util.cpp:508:** +4, including nesting penalty of
3, nesting level increased to 4
```cpp
for (size_t i = 0; i < var->rows(); ++i) {
^
```
**be/src/vec/common/schema_util.cpp:510:** +5, including nesting penalty of
4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(var->serialize_one_row_to_string(i,
_str));
^
```
**be/src/common/status.h:570:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do {\
^
```
**be/src/vec/common/schema_util.cpp:510:** +6, including nesting penalty of
5, nesting level increased to 6
```cpp
RETURN_IF_ERROR(var->serialize_one_row_to_string(i,
_str));
^
```
**be/src/common/status.h:572:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/common/schema_util.cpp:514:** +1, nesting level increased to 3
```cpp
} else {
^
```
**be/src/vec/common/schema_util.cpp:524:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (!var.is_scalar_variant()) {
^
```
**be/src/vec/common/schema_util.cpp:527:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(encode_rowstore());
^
```
**be/src/common/status.h:570:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do {\
^
```
**be/src/vec/common/schema_util.cpp:527:** +4, including nesting penalty of
3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(encode_rowstore());
^
```
**be/src/common/status.h:572:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/common/schema_util.cpp:532:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (WhichDataType(remove_nullable(var.get_root_type())).is_json()) {
^
```
**be/src/vec/common/schema_util.cpp:535:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(cast_column({var.get_root(),
var.get_root_type(), ""},
^
```
**be/src/common/status.h:570:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do {
Re: [PR] [opt](routine-load) optimize routine load task allocation algorithm [doris]
doris-robot commented on PR #34778: URL: https://github.com/apache/doris/pull/34778#issuecomment-2113995459 ClickBench: Total hot run time: 30.62 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit c7f0641935947a0d0bd170fe31740aba30e0a82f, data reload: false query1 0.040.040.03 query2 0.080.030.03 query3 0.240.050.04 query4 1.680.070.07 query5 0.510.520.51 query6 1.140.720.73 query7 0.020.020.01 query8 0.040.040.04 query9 0.540.490.48 query10 0.550.550.55 query11 0.140.110.11 query12 0.150.120.11 query13 0.600.580.60 query14 0.760.780.78 query15 0.840.820.81 query16 0.360.370.36 query17 1.041.041.03 query18 0.210.240.25 query19 1.821.771.82 query20 0.010.000.01 query21 15.60 0.660.64 query22 4.457.041.99 query23 18.27 1.341.27 query24 1.630.260.21 query25 0.140.080.08 query26 0.280.170.17 query27 0.090.080.08 query28 13.46 1.011.01 query29 13.30 3.323.24 query30 0.240.060.06 query31 2.860.380.39 query32 3.290.470.46 query33 2.842.872.85 query34 17.14 4.364.45 query35 4.504.514.59 query36 0.700.480.46 query37 0.170.150.15 query38 0.150.140.14 query39 0.040.030.03 query40 0.160.140.14 query41 0.090.050.05 query42 0.050.050.04 query43 0.030.030.04 Total cold run time: 110.25 s Total hot run time: 30.62 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improve](inverted index) improve performance by introducing bulk contains for bitmap in _build_index_result_column [doris]
github-actions[bot] commented on PR #34831: URL: https://github.com/apache/doris/pull/34831#issuecomment-2113993363 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](Nereids): Refactor `Eliminate_Group_By_Key` by functional dependencies [doris]
XieJiann commented on PR #34948: URL: https://github.com/apache/doris/pull/34948#issuecomment-2113992677 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](Nereids): Refactor `Eliminate_Group_By_Key` by functional dependencies [doris]
doris-robot commented on PR #34948: URL: https://github.com/apache/doris/pull/34948#issuecomment-2113992619 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [feat](Nereids): Refactor `Eliminate_Group_By_Key` by functional dependencies [doris]
XieJiann opened a new pull request, #34948: URL: https://github.com/apache/doris/pull/34948 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](memory) Fix query mem tracker log when destruction not equal to 0 [doris]
xinyiZzz commented on PR #34901: URL: https://github.com/apache/doris/pull/34901#issuecomment-2113992418 comment run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](routine-load) optimize routine load task allocation algorithm [doris]
doris-robot commented on PR #34778: URL: https://github.com/apache/doris/pull/34778#issuecomment-2113991790 TPC-DS: Total hot run time: 185241 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit c7f0641935947a0d0bd170fe31740aba30e0a82f, data reload: false query1 914 385 371 371 query2 6154249921792179 query3 6651232 238 232 query4 23018 22303 22198 22198 query5 3836442 418 418 query6 267 179 186 179 query7 4535304 308 304 query8 241 190 193 190 query9 8526238923612361 query10 414 243 249 243 query11 11916 11237 11329 11237 query12 116 87 85 85 query13 1673356 371 356 query14 11891 866386678663 query15 262 194 174 174 query16 8211271 257 257 query17 1976581 535 535 query18 1387278 267 267 query19 339 151 152 151 query20 92 85 86 85 query21 190 137 133 133 query22 5211487448274827 query23 34192 33394 33504 33394 query24 10616 292628642864 query25 582 363 352 352 query26 1141153 148 148 query27 2325316 308 308 query28 6909201220022002 query29 850 613 589 589 query30 257 174 178 174 query31 947 720 730 720 query32 94 50 50 50 query33 722 246 235 235 query34 1018489 474 474 query35 820 671 660 660 query36 1050861 931 861 query37 147 74 70 70 query38 2914277227922772 query39 1594159215581558 query40 189 120 126 120 query41 42 40 40 40 query42 105 97 96 96 query43 564 507 525 507 query44 1183722 735 722 query45 271 257 257 257 query46 1104722 686 686 query47 1948186918891869 query48 367 295 288 288 query49 846 382 379 379 query50 745 390 388 388 query51 6846676168146761 query52 103 96 98 96 query53 360 280 283 280 query54 870 413 417 413 query55 80 73 70 70 query56 246 226 217 217 query57 1220111811391118 query58 234 196 199 196 query59 3315304730793047 query60 265 231 229 229 query61 86 87 88 87 query62 682 459 492 459 query63 306 288 281 281 query64 8723740473267326 query65 3141310530833083 query66 899 339 327 327 query67 15517 14920 14856 14856 query68 5432524 535 524 query69 541 293 308 293 query70 1134114311191119 query71 461 267 265 265 query72 7904255323882388 query73 711 314 327 314 query74 6585615060036003 query75 3729264125772577 query76 3614989 976 976 query77 591 274 265 265 query78 10578 10016 10132 10016 query79 2812514 527 514 query80 1638422 425 422 query81 524 251 240 240 query82 109292 99 92 query83 206 166 168 166 query84 260 85 84 84 query85 1353272 283 272 query86 440 322 325 322 query87 3299315031293129 query88 3905232823272327 query89 461 370 368 368 query90 1956194 187 187 query91 131 107 108 107 query92 62 51 50 50 query93 2369494 488 488 query94 1123184 187 184 query95 406 303 298 298 query96 588 267 272 267 query97 3208300129992999 query98 242 220 214 214 query99 1272897 928 897 Total cold run time: 282882 ms Total hot run time: 185241 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [enhance](mtmv)Mv refresh on commit [doris]
zddr commented on code in PR #34548:
URL: https://github.com/apache/doris/pull/34548#discussion_r1602580842
##
fe/fe-core/src/main/java/org/apache/doris/event/EventProcessor.java:
##
@@ -0,0 +1,57 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.event;
+
+import com.google.common.collect.Sets;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.Objects;
+import java.util.Set;
+
+public class EventProcessor {
+
+private static final Logger LOG =
LogManager.getLogger(EventProcessor.class);
+
+private Set listeners = Sets.newHashSet();
+
+public EventProcessor(EventListener... args) {
+for (EventListener listener : args) {
+this.listeners.add(listener);
+}
+}
+
+public boolean processEvent(Event event) {
+Objects.requireNonNull(event);
+if (LOG.isDebugEnabled()) {
+LOG.debug("processEvent: {}", event);
+}
+boolean result = true;
+for (EventListener listener : listeners) {
+try {
+listener.processEvent(event);
Review Comment:
Here, we need to wait for each listener to complete its execution. If there
are many listeners, each listener can be run with one thread, and then the main
thread waits for all threads to finish executing before returning.
Currently, there is only one listener. Can we use synchronous logic to
handle it first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improve](inverted index) improve performance by introducing bulk contains for bitmap in _build_index_result_column [doris]
airborne12 commented on PR #34831: URL: https://github.com/apache/doris/pull/34831#issuecomment-2113989497 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement]Optimize GeoFunctions for const columns [doris]
github-actions[bot] commented on PR #34396: URL: https://github.com/apache/doris/pull/34396#issuecomment-2113986848 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](exchange) the sink could eos early when all queues have enough rows [doris]
doris-robot commented on PR #34541: URL: https://github.com/apache/doris/pull/34541#issuecomment-2113984789 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 6d9156a70c00e68668ae4471759e0f841ea15daa with default session variables Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s Stream load orc: 50 seconds loaded 1101869774 Bytes, about 21 MB/s Stream load parquet: 29 seconds loaded 861443392 Bytes, about 28 MB/s Insert into select: 11.9 seconds inserted 1000 Rows, about 840K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](mtmv)Mv refresh on commit [doris]
zddr commented on code in PR #34548: URL: https://github.com/apache/doris/pull/34548#discussion_r1602577487 ## fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java: ## @@ -1863,7 +1864,9 @@ public void dropPartition(Database db, OlapTable olapTable, DropPartitionClause DropPartitionInfo info = new DropPartitionInfo(db.getId(), olapTable.getId(), partitionName, isTempPartition, clause.isForceDrop(), recycleTime, version, versionTime); Env.getCurrentEnv().getEditLog().logDropPartition(info); - +Env.getCurrentEnv().getEventProcessor().processEvent( +new DropPartitionEvent(db.getCatalog().getId(), db.getId(), +olapTable.getId())); Review Comment: I changed the location where the event was generated to before writing the log, and waited for the message to be processed before writing the log. But here we don't care about the result of message processing (it's up to the specific listener to decide how to handle a failure) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](exchange) the sink could eos early when all queues have enough rows [doris]
doris-robot commented on PR #34541: URL: https://github.com/apache/doris/pull/34541#issuecomment-2113982223 ClickBench: Total hot run time: 30.46 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 6d9156a70c00e68668ae4471759e0f841ea15daa, data reload: false query1 0.030.030.04 query2 0.080.040.04 query3 0.220.050.05 query4 1.670.090.08 query5 0.510.480.49 query6 1.140.730.73 query7 0.020.010.02 query8 0.050.040.04 query9 0.520.470.48 query10 0.530.540.52 query11 0.160.120.11 query12 0.140.120.11 query13 0.590.590.61 query14 0.760.770.77 query15 0.840.820.83 query16 0.370.340.36 query17 0.961.021.02 query18 0.220.220.25 query19 1.811.691.70 query20 0.010.020.01 query21 15.54 0.710.68 query22 4.187.451.91 query23 18.34 1.461.26 query24 1.580.350.23 query25 0.150.080.08 query26 0.260.150.16 query27 0.080.080.07 query28 13.32 1.021.00 query29 13.80 3.433.34 query30 0.230.060.05 query31 2.880.370.37 query32 3.300.460.46 query33 2.812.822.87 query34 17.05 4.444.42 query35 4.494.454.55 query36 0.650.460.46 query37 0.180.170.16 query38 0.160.140.15 query39 0.040.030.04 query40 0.160.150.14 query41 0.090.040.05 query42 0.050.040.05 query43 0.030.030.04 Total cold run time: 110 s Total hot run time: 30.46 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](memory) Fix BE compile in Mac with no prefix Jemalloc [doris]
doris-robot commented on PR #34886: URL: https://github.com/apache/doris/pull/34886#issuecomment-2113981710 ClickBench: Total hot run time: 30.74 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit d4fd669ab5d55714cd1d54db76b518b72d1ddc2b, data reload: false query1 0.030.030.03 query2 0.090.040.04 query3 0.240.050.04 query4 1.680.070.08 query5 0.490.490.52 query6 1.120.730.72 query7 0.020.010.01 query8 0.050.040.04 query9 0.520.490.50 query10 0.540.540.52 query11 0.160.100.11 query12 0.140.120.12 query13 0.600.590.61 query14 0.760.780.79 query15 0.840.800.80 query16 0.360.360.35 query17 0.960.941.00 query18 0.220.240.23 query19 1.791.751.69 query20 0.010.010.02 query21 15.71 0.660.65 query22 4.186.942.39 query23 18.28 1.371.30 query24 1.890.240.20 query25 0.140.080.08 query26 0.280.180.17 query27 0.080.080.07 query28 13.30 1.001.02 query29 12.99 3.273.22 query30 0.240.060.06 query31 2.870.390.38 query32 3.300.470.48 query33 2.812.892.83 query34 17.25 4.434.38 query35 4.454.454.48 query36 0.650.460.45 query37 0.170.150.15 query38 0.160.150.14 query39 0.040.030.04 query40 0.160.140.13 query41 0.090.050.05 query42 0.060.050.05 query43 0.040.040.03 Total cold run time: 109.76 s Total hot run time: 30.74 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](spill) fuzzy spill and fix bugs [doris]
jacktengg commented on PR #33291: URL: https://github.com/apache/doris/pull/33291#issuecomment-2113979436 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [improvement](decimal) improve overflow error message (#34689)
This is an automated email from the ASF dual-hosted git repository.
jacktengg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 89d7fb14fae [improvement](decimal) improve overflow error message
(#34689)
89d7fb14fae is described below
commit 89d7fb14fae472bf38b0b8a67a340ba679c7cb15
Author: TengJianPing <18241664+jackte...@users.noreply.github.com>
AuthorDate: Thu May 16 11:57:26 2024 +0800
[improvement](decimal) improve overflow error message (#34689)
---
be/src/vec/data_types/data_type_date.h| 6 +
be/src/vec/data_types/data_type_date_time.cpp | 8 ++
be/src/vec/data_types/data_type_date_time.h | 1 +
be/src/vec/data_types/data_type_decimal.cpp | 5 +
be/src/vec/data_types/data_type_decimal.h | 131 +-
be/src/vec/data_types/data_type_ipv4.cpp | 5 +
be/src/vec/data_types/data_type_ipv4.h| 1 +
be/src/vec/data_types/data_type_ipv6.cpp | 4 +
be/src/vec/data_types/data_type_ipv6.h| 1 +
be/src/vec/data_types/data_type_number_base.cpp | 13 ++
be/src/vec/data_types/data_type_number_base.h | 1 +
be/src/vec/data_types/data_type_time.cpp | 6 +
be/src/vec/data_types/data_type_time.h| 2 +
be/src/vec/data_types/data_type_time_v2.cpp | 17 +++
be/src/vec/data_types/data_type_time_v2.h | 2 +
be/src/vec/functions/function_binary_arithmetic.h | 156 +++---
be/src/vec/functions/function_cast.h | 10 +-
be/src/vec/functions/multiply.cpp | 10 +-
18 files changed, 264 insertions(+), 115 deletions(-)
diff --git a/be/src/vec/data_types/data_type_date.h
b/be/src/vec/data_types/data_type_date.h
index 1ae78678bdc..56f74124d90 100644
--- a/be/src/vec/data_types/data_type_date.h
+++ b/be/src/vec/data_types/data_type_date.h
@@ -60,6 +60,12 @@ public:
bool equals(const IDataType& rhs) const override;
std::string to_string(const IColumn& column, size_t row_num) const
override;
void to_string(const IColumn& column, size_t row_num, BufferWritable&
ostr) const override;
+std::string to_string(Int64 int_val) const {
+doris::VecDateTimeValue value = binary_cast(int_val);
+char buf[64];
+value.to_string(buf);
+return buf;
+}
Status from_string(ReadBuffer& rb, IColumn* column) const override;
static void cast_to_date(Int64& x);
diff --git a/be/src/vec/data_types/data_type_date_time.cpp
b/be/src/vec/data_types/data_type_date_time.cpp
index 7985e4728c0..857251cd095 100644
--- a/be/src/vec/data_types/data_type_date_time.cpp
+++ b/be/src/vec/data_types/data_type_date_time.cpp
@@ -56,6 +56,14 @@ std::string DataTypeDateTime::to_string(const IColumn&
column, size_t row_num) c
return buf;
}
+std::string DataTypeDateTime::to_string(Int64 int_val) const {
+doris::VecDateTimeValue value = binary_cast(int_val);
+
+char buf[64];
+value.to_string(buf);
+// DateTime to_string the end is /0
+return buf;
+}
void DataTypeDateTime::to_string(const IColumn& column, size_t row_num,
BufferWritable& ostr) const {
auto result = check_column_const_set_readability(column, row_num);
diff --git a/be/src/vec/data_types/data_type_date_time.h
b/be/src/vec/data_types/data_type_date_time.h
index 5633449bc43..3f604a541c1 100644
--- a/be/src/vec/data_types/data_type_date_time.h
+++ b/be/src/vec/data_types/data_type_date_time.h
@@ -84,6 +84,7 @@ public:
bool equals(const IDataType& rhs) const override;
std::string to_string(const IColumn& column, size_t row_num) const
override;
+std::string to_string(Int64 value) const;
DataTypeSerDeSPtr get_serde(int nesting_level = 1) const override {
return std::make_shared(nesting_level);
diff --git a/be/src/vec/data_types/data_type_decimal.cpp
b/be/src/vec/data_types/data_type_decimal.cpp
index 384ffc83ce6..c052a8f1cbc 100644
--- a/be/src/vec/data_types/data_type_decimal.cpp
+++ b/be/src/vec/data_types/data_type_decimal.cpp
@@ -86,6 +86,11 @@ void DataTypeDecimal::to_string(const IColumn& column,
size_t row_num,
}
}
+template
+std::string DataTypeDecimal::to_string(const T& value) const {
+return value.to_string(scale);
+}
+
template
Status DataTypeDecimal::from_string(ReadBuffer& rb, IColumn* column) const {
auto& column_data = static_cast(*column).get_data();
diff --git a/be/src/vec/data_types/data_type_decimal.h
b/be/src/vec/data_types/data_type_decimal.h
index bd82ae36290..9b54a55137c 100644
--- a/be/src/vec/data_types/data_type_decimal.h
+++ b/be/src/vec/data_types/data_type_decimal.h
@@ -239,6 +239,7 @@ public:
std::string to_string(const IColumn& column, size_t row_num) const
override;
void to_string(const IColumn& column, size_t row_num, BufferWritable&
ostr) const override;
+
Re: [PR] [improvement](decimal) improve overflow error message [doris]
jacktengg merged PR #34689: URL: https://github.com/apache/doris/pull/34689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]
Vallishp commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2113978675 > Please add the document in doris-website and link 2 prs. https://github.com/apache/doris-website/pull/661 handled all, pls help to review again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](exchange) the sink could eos early when all queues have enough rows [doris]
doris-robot commented on PR #34541: URL: https://github.com/apache/doris/pull/34541#issuecomment-2113978539 TPC-DS: Total hot run time: 186617 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6d9156a70c00e68668ae4471759e0f841ea15daa, data reload: false query1 891 394 372 372 query2 6164230322682268 query3 6639206 207 206 query4 23249 21775 21980 21775 query5 3781436 413 413 query6 262 187 194 187 query7 4539310 299 299 query8 236 191 201 191 query9 8438215021562150 query10 432 237 279 237 query11 15359 14978 14852 14852 query12 119 88 89 88 query13 1556327 335 327 query14 10465 843667886788 query15 261 167 159 159 query16 8168243 233 233 query17 1770545 529 529 query18 2087257 257 257 query19 237 152 147 147 query20 90 83 89 83 query21 187 132 126 126 query22 5107478848554788 query23 34310 33730 33755 33730 query24 10761 290728732873 query25 595 354 379 354 query26 1206148 150 148 query27 2977329 330 329 query28 7258198020041980 query29 870 617 615 615 query30 270 168 175 168 query31 961 757 743 743 query32 89 49 55 49 query33 735 264 233 233 query34 1023478 469 469 query35 825 665 653 653 query36 1077987 921 921 query37 163 68 63 63 query38 2956280028492800 query39 1627157615421542 query40 195 122 122 122 query41 44 42 42 42 query42 101 100 101 100 query43 590 572 528 528 query44 1202725 730 725 query45 268 256 245 245 query46 1079692 721 692 query47 1962192718841884 query48 349 271 266 266 query49 882 387 390 387 query50 743 352 360 352 query51 6832654266386542 query52 99 93 93 93 query53 348 292 287 287 query54 858 401 401 401 query55 76 74 77 74 query56 234 218 215 215 query57 1260116811711168 query58 224 195 227 195 query59 3253311728952895 query60 259 224 225 224 query61 86 86 85 85 query62 647 459 462 459 query63 310 279 283 279 query64 8766732273227322 query65 3123307731033077 query66 1390332 325 325 query67 15453 14950 14942 14942 query68 4567527 543 527 query69 494 298 290 290 query70 1198115012111150 query71 413 266 269 266 query72 7307252823072307 query73 685 307 310 307 query74 6693634264026342 query75 3366263926162616 query76 2801914 938 914 query77 378 264 267 264 query78 10801 10423 10198 10198 query79 2232535 527 527 query80 905 430 425 425 query81 527 240 239 239 query82 1286121 97 97 query83 257 169 163 163 query84 240 85 80 80 query85 1509271 258 258 query86 479 325 315 315 query87 3385313331403133 query88 3724198319761976 query89 466 376 375 375 query90 1987189 188 188 query91 123 96 94 94 query92 62 51 48 48 query93 1979495 485 485 query94 1144176 170 170 query95 373 284 281 281 query96 568 258 257 257 query97 3283320531453145 query98 238 218 215 215 query99 1107894 901 894 Total cold run time: 282950 ms Total hot run time: 186617 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
[PR] [Enhancement] add information_schema.table_options(#32572) [doris-website]
Vallishp opened a new pull request, #661: URL: https://github.com/apache/doris-website/pull/661 add document for information_schema.table_options table. code PR https://github.com/apache/doris/pull/34384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](memory) Fix BE compile in Mac with no prefix Jemalloc [doris]
doris-robot commented on PR #34886: URL: https://github.com/apache/doris/pull/34886#issuecomment-2113978091 TPC-DS: Total hot run time: 187168 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit d4fd669ab5d55714cd1d54db76b518b72d1ddc2b, data reload: false query1 906 378 367 367 query2 6464233022972297 query3 6646217 220 217 query4 23245 21258 21260 21258 query5 4144418 412 412 query6 262 171 183 171 query7 4581293 280 280 query8 239 182 196 182 query9 8500233423252325 query10 426 244 256 244 query11 14922 14214 14278 14214 query12 140 91 87 87 query13 1662367 368 367 query14 10455 809676077607 query15 248 167 168 167 query16 8156260 258 258 query17 1877552 561 552 query18 2055269 270 269 query19 197 149 147 147 query20 92 88 91 88 query21 197 138 131 131 query22 5064489548934893 query23 34056 33585 33563 33563 query24 10898 298529782978 query25 617 386 363 363 query26 1172165 154 154 query27 3012312 339 312 query28 7575200020052000 query29 857 620 606 606 query30 281 170 174 170 query31 953 768 745 745 query32 100 52 52 52 query33 745 252 242 242 query34 1069483 479 479 query35 796 674 691 674 query36 1052906 942 906 query37 135 70 73 70 query38 2876277627362736 query39 1575155415671554 query40 208 132 126 126 query41 48 75 45 45 query42 104 95 96 95 query43 591 531 532 531 query44 1202722 728 722 query45 267 250 221 221 query46 1092744 709 709 query47 1961186918551855 query48 386 290 291 290 query49 1067379 390 379 query50 756 393 369 369 query51 6870680967496749 query52 104 94 90 90 query53 354 285 284 284 query54 859 437 415 415 query55 76 74 75 74 query56 245 225 212 212 query57 1223113611491136 query58 218 204 205 204 query59 3376323232323232 query60 250 232 233 232 query61 104 89 87 87 query62 684 482 454 454 query63 318 284 286 284 query64 8841738774257387 query65 3197312531003100 query66 1407353 370 353 query67 15441 15040 15030 15030 query68 4570516 522 516 query69 487 298 309 298 query70 1156115211371137 query71 388 276 263 263 query72 7462254523672367 query73 698 324 324 324 query74 6525615861906158 query75 3426264225782578 query76 2639981 962 962 query77 404 265 272 265 query78 10409 10121 10015 10015 query79 2357514 507 507 query80 1724440 439 439 query81 524 242 244 242 query82 694 97 96 96 query83 326 173 174 173 query84 271 86 83 83 query85 1846263 265 263 query86 499 293 292 292 query87 3279307831493078 query88 4247229723052297 query89 486 380 376 376 query90 1979180 185 180 query91 120 98 96 96 query92 57 48 47 47 query93 2488502 483 483 query94 1257176 176 176 query95 385 291 295 291 query96 586 276 264 264 query97 3194301429982998 query98 249 225 219 219 query99 1266899 883 883 Total cold run time: 285494 ms Total hot run time: 187168 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [improvement](decimal) improve overflow error message [doris]
jacktengg commented on PR #34689: URL: https://github.com/apache/doris/pull/34689#issuecomment-2113978029 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](topn) rename TTopnFilterContext to TTopnFilterDesc [doris]
github-actions[bot] commented on PR #34947: URL: https://github.com/apache/doris/pull/34947#issuecomment-2113970920 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (41c0e85978d -> 75fee8f0301)
This is an automated email from the ASF dual-hosted git repository. zykkk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 41c0e85978d [fix](nereids)LogicalPlanDeepCopier will lost some info when coping logical relation (#34894) add 75fee8f0301 [fix](memory) Fix BE compile in Mac with no prefix Jemalloc (#34886) No new revisions were added by this update. Summary of changes: build.sh | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](topn) rename TTopnFilterContext to TTopnFilterDesc [doris]
BiteThet commented on PR #34947: URL: https://github.com/apache/doris/pull/34947#issuecomment-2113966741 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](memory) Fix BE compile in Mac with no prefix Jemalloc [doris]
zy-kkk merged PR #34886: URL: https://github.com/apache/doris/pull/34886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Chore](topn) rename TTopnFilterContext to TTopnFilterDesc [doris]
BiteThet opened a new pull request, #34947: URL: https://github.com/apache/doris/pull/34947 ## Proposed changes rename TTopnFilterContext to TTopnFilterDesc ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](topn) rename TTopnFilterContext to TTopnFilterDesc [doris]
doris-robot commented on PR #34947: URL: https://github.com/apache/doris/pull/34947#issuecomment-2113966705 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids)new way to set pre-agg status [doris]
starocean999 commented on PR #34738: URL: https://github.com/apache/doris/pull/34738#issuecomment-2113966426 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](memory) Fix BE compile in Mac with no prefix Jemalloc [doris]
zy-kkk commented on PR #34886: URL: https://github.com/apache/doris/pull/34886#issuecomment-2113965766 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](decimal) improve overflow error message [doris]
github-actions[bot] commented on PR #34689: URL: https://github.com/apache/doris/pull/34689#issuecomment-2113964513 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](decimal) improve overflow error message [doris]
github-actions[bot] commented on PR #34689: URL: https://github.com/apache/doris/pull/34689#issuecomment-2113961954 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](k8s) modify docs about user privilege url [doris-website]
catpineapple opened a new pull request, #660: URL: https://github.com/apache/doris-website/pull/660 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](memory) Fix BE compile in Mac with no prefix Jemalloc [doris]
xinyiZzz commented on PR #34886: URL: https://github.com/apache/doris/pull/34886#issuecomment-2113956579 comment run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](memory) Fix BE compile in Mac with no prefix Jemalloc [doris]
github-actions[bot] commented on PR #34886: URL: https://github.com/apache/doris/pull/34886#issuecomment-2113956897 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](memory) Fix BE compile in Mac with no prefix Jemalloc [doris]
github-actions[bot] commented on PR #34886: URL: https://github.com/apache/doris/pull/34886#issuecomment-2113956849 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement]Optimize GeoFunctions for const columns [doris]
doris-robot commented on PR #34396: URL: https://github.com/apache/doris/pull/34396#issuecomment-2113956347 ClickBench: Total hot run time: 30.14 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 946b41a9279055413b2a6d0764be37ab93b1181d, data reload: false query1 0.040.040.04 query2 0.080.040.04 query3 0.230.050.05 query4 1.690.070.07 query5 0.500.470.50 query6 1.130.720.73 query7 0.020.020.01 query8 0.050.040.04 query9 0.530.490.50 query10 0.540.550.54 query11 0.150.110.11 query12 0.140.120.12 query13 0.590.590.62 query14 0.800.790.77 query15 0.820.810.81 query16 0.350.340.40 query17 0.940.961.04 query18 0.220.260.23 query19 1.821.751.79 query20 0.010.010.02 query21 15.57 0.670.64 query22 4.747.321.70 query23 18.35 1.431.31 query24 1.530.320.20 query25 0.130.080.08 query26 0.270.170.17 query27 0.080.070.08 query28 13.46 1.010.99 query29 12.82 3.353.24 query30 0.240.060.06 query31 2.900.400.38 query32 3.260.470.47 query33 2.812.872.81 query34 17.05 4.364.43 query35 4.504.464.51 query36 0.640.470.49 query37 0.170.150.16 query38 0.150.150.14 query39 0.050.040.03 query40 0.160.150.14 query41 0.090.040.04 query42 0.060.040.04 query43 0.040.030.04 Total cold run time: 109.72 s Total hot run time: 30.14 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (f7ffac07d95 -> 41c0e85978d)
This is an automated email from the ASF dual-hosted git repository. starocean999 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from f7ffac07d95 [Fix](Nereids) fix leading with cte and same subqueryalias name (#34838) add 41c0e85978d [fix](nereids)LogicalPlanDeepCopier will lost some info when coping logical relation (#34894) No new revisions were added by this update. Summary of changes: .../nereids/analyzer/UnboundOneRowRelation.java| 5 + .../doris/nereids/analyzer/UnboundRelation.java| 5 + .../doris/nereids/analyzer/UnboundTVFRelation.java | 5 + .../trees/copier/LogicalPlanDeepCopier.java| 112 + .../trees/plans/logical/LogicalCTEConsumer.java| 5 + .../logical/LogicalDeferMaterializeOlapScan.java | 6 ++ .../trees/plans/logical/LogicalEmptyRelation.java | 5 + .../nereids/trees/plans/logical/LogicalEsScan.java | 8 +- .../trees/plans/logical/LogicalFileScan.java | 10 +- .../trees/plans/logical/LogicalJdbcScan.java | 7 +- .../trees/plans/logical/LogicalOdbcScan.java | 7 +- .../trees/plans/logical/LogicalOlapScan.java | 10 ++ .../trees/plans/logical/LogicalOneRowRelation.java | 5 + .../trees/plans/logical/LogicalRelation.java | 2 + .../trees/plans/logical/LogicalSchemaScan.java | 5 + .../trees/plans/logical/LogicalTVFRelation.java| 5 + .../trees/plans/logical/LogicalTestScan.java | 5 + .../doris/nereids/jobs/RewriteTopDownJobTest.java | 6 ++ 18 files changed, 146 insertions(+), 67 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)LogicalPlanDeepCopier will lost some info when coping logical relation [doris]
starocean999 merged PR #34894: URL: https://github.com/apache/doris/pull/34894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](hive view) support inner name like _c0,_c1 for derived column in inline view for hive view [doris]
Yulei-Yang commented on PR #33193: URL: https://github.com/apache/doris/pull/33193#issuecomment-2113953351 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)LogicalPlanDeepCopier will lost some info when coping logical relation [doris]
starocean999 commented on PR #34894: URL: https://github.com/apache/doris/pull/34894#issuecomment-2113953045 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) support Iceberg time travel syntax [doris]
doris-robot commented on PR #34681: URL: https://github.com/apache/doris/pull/34681#issuecomment-2113947012 ClickBench: Total hot run time: 30.16 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit f18eb36bd4f1121530cf1b910b13b85645a36674, data reload: false query1 0.040.040.03 query2 0.080.040.04 query3 0.240.040.05 query4 1.660.070.06 query5 0.490.490.52 query6 1.120.730.72 query7 0.010.020.01 query8 0.060.040.04 query9 0.530.480.48 query10 0.540.520.53 query11 0.160.120.11 query12 0.150.120.11 query13 0.590.590.60 query14 0.770.770.79 query15 0.820.800.80 query16 0.350.370.36 query17 0.970.930.92 query18 0.220.220.26 query19 1.791.691.70 query20 0.020.010.01 query21 15.73 0.650.64 query22 4.237.671.73 query23 18.31 1.451.29 query24 1.290.450.21 query25 0.140.090.08 query26 0.270.170.18 query27 0.080.080.08 query28 13.31 1.011.00 query29 13.14 3.383.33 query30 0.240.060.06 query31 2.860.390.37 query32 3.280.470.47 query33 2.812.802.81 query34 17.04 4.394.47 query35 4.484.484.47 query36 0.710.490.48 query37 0.170.150.15 query38 0.150.140.14 query39 0.040.040.03 query40 0.160.140.14 query41 0.090.050.04 query42 0.060.040.05 query43 0.040.040.04 Total cold run time: 109.24 s Total hot run time: 30.16 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement]Optimize GeoFunctions for const columns [doris]
doris-robot commented on PR #34396: URL: https://github.com/apache/doris/pull/34396#issuecomment-2113945577 TPC-DS: Total hot run time: 186303 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 946b41a9279055413b2a6d0764be37ab93b1181d, data reload: false query1 899 383 373 373 query2 6444229522762276 query3 6652210 216 210 query4 22919 21216 21230 21216 query5 4149415 420 415 query6 262 172 170 170 query7 4589284 280 280 query8 239 197 207 197 query9 8584236423442344 query10 441 258 247 247 query11 14723 14403 14221 14221 query12 140 93 89 89 query13 1671379 359 359 query14 8871738286947382 query15 260 178 174 174 query16 8088254 249 249 query17 1741545 539 539 query18 2102276 266 266 query19 290 151 150 150 query20 94 98 85 85 query21 191 129 125 125 query22 5024486048304830 query23 34453 33613 33531 33531 query24 10583 293428752875 query25 588 367 372 367 query26 726 160 157 157 query27 2156313 328 313 query28 6201203520052005 query29 842 639 602 602 query30 265 170 175 170 query31 974 758 740 740 query32 95 53 77 53 query33 743 246 248 246 query34 1021478 474 474 query35 799 674 666 666 query36 1062940 898 898 query37 106 71 68 68 query38 2873275627982756 query39 1631156115571557 query40 201 127 123 123 query41 47 42 42 42 query42 106 96 99 96 query43 600 532 543 532 query44 1207730 740 730 query45 270 255 266 255 query46 1096703 712 703 query47 1943187618561856 query48 377 294 285 285 query49 842 398 399 398 query50 763 389 384 384 query51 6930687868236823 query52 101 94 89 89 query53 348 287 285 285 query54 856 431 438 431 query55 78 81 79 79 query56 248 228 237 228 query57 1212113911641139 query58 222 202 209 202 query59 3336319130773077 query60 256 229 239 229 query61 88 88 86 86 query62 634 468 489 468 query63 317 291 289 289 query64 8584740873747374 query65 3145309930773077 query66 790 345 337 337 query67 15466 14766 14909 14766 query68 5285540 515 515 query69 518 323 301 301 query70 1172113110781078 query71 482 270 265 265 query72 7862260523572357 query73 716 326 337 326 query74 6460609161336091 query75 3901266725942594 query76 3910928 929 928 query77 579 268 270 268 query78 10650 10185 10045 10045 query79 1393513 517 513 query80 688 441 433 433 query81 512 244 241 241 query82 926 100 101 100 query83 190 161 167 161 query84 248 84 85 84 query85 1500270 265 265 query86 471 279 316 279 query87 3279310930863086 query88 3606231623122312 query89 474 379 374 374 query90 2020192 194 192 query91 128 94 101 94 query92 54 50 50 50 query93 1853509 491 491 query94 1180179 178 178 query95 391 291 295 291 query96 583 269 263 263 query97 3151296630052966 query98 226 220 212 212 query99 1199892 909 892 Total cold run time: 279161 ms Total hot run time: 186303 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [feat](nereids) support Iceberg time travel syntax [doris]
doris-robot commented on PR #34681: URL: https://github.com/apache/doris/pull/34681#issuecomment-2113935285 TPC-DS: Total hot run time: 186741 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit f18eb36bd4f1121530cf1b910b13b85645a36674, data reload: false query1 911 388 374 374 query2 6321245623292329 query3 6654218 216 216 query4 26214 21774 21931 21774 query5 3789426 429 426 query6 280 187 171 171 query7 4542297 296 296 query8 239 186 192 186 query9 8596240524632405 query10 426 246 261 246 query11 15191 14946 14840 14840 query12 119 94 85 85 query13 1569356 372 356 query14 10273 677076656770 query15 236 168 166 166 query16 8115255 255 255 query17 1706549 526 526 query18 2085265 267 265 query19 194 151 142 142 query20 88 81 80 80 query21 186 130 129 129 query22 5099494649184918 query23 33926 33701 33356 33356 query24 10680 284128982841 query25 597 360 355 355 query26 1169152 147 147 query27 3006310 322 310 query28 7136200619951995 query29 853 635 607 607 query30 262 171 169 169 query31 987 739 748 739 query32 94 49 57 49 query33 734 245 238 238 query34 1069490 472 472 query35 774 666 651 651 query36 1045917 922 917 query37 138 70 68 68 query38 2903276428352764 query39 1595156715581558 query40 192 125 119 119 query41 47 42 41 41 query42 100 96 93 93 query43 548 551 527 527 query44 1186725 732 725 query45 266 248 258 248 query46 1068722 700 700 query47 1981188918791879 query48 365 305 292 292 query49 895 386 381 381 query50 749 376 385 376 query51 6857678968076789 query52 98 94 92 92 query53 346 280 278 278 query54 841 416 420 416 query55 75 72 72 72 query56 236 215 221 215 query57 1209117811221122 query58 214 194 196 194 query59 3368318129522952 query60 279 230 226 226 query61 86 85 88 85 query62 637 472 454 454 query63 311 280 283 280 query64 8802736973967369 query65 3096307630553055 query66 804 325 334 325 query67 15816 15012 14865 14865 query68 4531517 520 517 query69 477 300 299 299 query70 1134108510911085 query71 423 266 261 261 query72 7095259123242324 query73 719 317 319 317 query74 6611619562216195 query75 3415264126072607 query76 2702955 975 955 query77 365 261 263 261 query78 10568 10201 10017 10017 query79 2521515 508 508 query80 1052425 417 417 query81 579 240 241 240 query82 943 94 95 94 query83 260 164 163 163 query84 232 87 84 84 query85 1179264 255 255 query86 473 318 295 295 query87 3352311832013118 query88 4189230023172300 query89 467 384 390 384 query90 1938193 185 185 query91 123 97 107 97 query92 61 48 48 48 query93 1810484 484 484 query94 1145173 172 172 query95 387 293 315 293 query96 586 260 268 260 query97 3165306630143014 query98 237 227 215 215 query99 1177916 934 916 Total cold run time: 284189 ms Total hot run time: 186741 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [fix](nereids)LogicalPlanDeepCopier will lost some info when coping logical relation [doris]
doris-robot commented on PR #34894: URL: https://github.com/apache/doris/pull/34894#issuecomment-2113934617 ClickBench: Total hot run time: 30.56 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 69cb821f29a01290a559151b42de24a042dc1cf5, data reload: false query1 0.040.030.03 query2 0.080.040.04 query3 0.220.050.05 query4 1.690.080.09 query5 0.520.500.52 query6 1.130.720.71 query7 0.020.020.01 query8 0.040.030.04 query9 0.530.490.50 query10 0.540.560.53 query11 0.150.110.11 query12 0.150.120.13 query13 0.610.590.60 query14 0.790.770.78 query15 0.820.820.80 query16 0.370.360.36 query17 0.961.050.98 query18 0.220.260.25 query19 1.881.761.77 query20 0.020.010.01 query21 15.70 0.640.64 query22 3.917.272.03 query23 18.32 1.311.28 query24 1.370.400.19 query25 0.160.090.07 query26 0.260.170.17 query27 0.090.080.08 query28 13.36 1.011.00 query29 13.09 3.303.27 query30 0.240.060.06 query31 2.860.390.39 query32 3.270.490.47 query33 2.822.842.84 query34 17.06 4.374.44 query35 4.524.454.46 query36 0.660.460.46 query37 0.170.160.15 query38 0.150.140.15 query39 0.040.040.03 query40 0.160.130.13 query41 0.090.050.05 query42 0.050.050.04 query43 0.040.030.04 Total cold run time: 109.17 s Total hot run time: 30.56 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](exec) opt const expr exec in set operator [doris]
doris-robot commented on PR #34823: URL: https://github.com/apache/doris/pull/34823#issuecomment-2113934224 TeamCity be ut coverage result: Function Coverage: 35.70% (8997/25199) Line Coverage: 27.37% (74447/271976) Region Coverage: 26.61% (38486/144634) Branch Coverage: 23.42% (19633/83818) Coverage Report: http://coverage.selectdb-in.cc/coverage/be9e1441843676d0c80dcec9ddb0ead265c81e7a_be9e1441843676d0c80dcec9ddb0ead265c81e7a/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)LogicalPlanDeepCopier will lost some info when coping logical relation [doris]
doris-robot commented on PR #34894: URL: https://github.com/apache/doris/pull/34894#issuecomment-2113930693 TPC-DS: Total hot run time: 187104 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 69cb821f29a01290a559151b42de24a042dc1cf5, data reload: false query1 932 386 370 370 query2 6452232923252325 query3 6656226 220 220 query4 22994 21142 21184 21142 query5 4138414 428 414 query6 257 174 190 174 query7 4586308 285 285 query8 237 194 184 184 query9 8735236223572357 query10 453 255 266 255 query11 14772 14250 14125 14125 query12 131 92 91 91 query13 1793401 362 362 query14 10665 807084708070 query15 228 167 170 167 query16 7950249 259 249 query17 1871549 560 549 query18 2014279 256 256 query19 205 149 147 147 query20 93 83 85 83 query21 199 130 131 130 query22 4993485848854858 query23 34223 33440 33431 33431 query24 11005 279929222799 query25 612 367 369 367 query26 1174157 153 153 query27 3011324 331 324 query28 7515202520142014 query29 876 633 611 611 query30 309 175 174 174 query31 993 761 749 749 query32 93 53 56 53 query33 769 251 251 251 query34 1052486 482 482 query35 799 670 669 669 query36 1064951 899 899 query37 138 70 72 70 query38 2875278427732773 query39 1620155915441544 query40 199 123 125 123 query41 44 42 42 42 query42 101 96 99 96 query43 558 564 566 564 query44 1210733 746 733 query45 262 253 256 253 query46 1082701 701 701 query47 1925183919151839 query48 377 301 292 292 query49 1083387 399 387 query50 792 377 384 377 query51 7024684867556755 query52 109 99 121 99 query53 348 287 291 287 query54 853 430 415 415 query55 75 75 72 72 query56 240 221 218 218 query57 1225113111361131 query58 217 200 191 191 query59 3428304931683049 query60 249 231 235 231 query61 102 88 88 88 query62 681 478 465 465 query63 311 284 288 284 query64 8887734073637340 query65 3131310430863086 query66 1401344 334 334 query67 15447 15158 14948 14948 query68 4546525 524 524 query69 535 305 300 300 query70 1125106110701061 query71 401 268 266 266 query72 7919257423632363 query73 689 317 320 317 query74 6545613460436043 query75 3323261726282617 query76 2497101210021002 query77 422 269 267 267 query78 10549 10218 10171 10171 query79 1671518 507 507 query80 1028431 445 431 query81 534 245 244 244 query82 971 97 98 97 query83 239 166 165 165 query84 241 86 83 83 query85 1338327 315 315 query86 388 298 311 298 query87 3326311130733073 query88 2888232323462323 query89 486 384 390 384 query90 1910191 195 191 query91 139 108 112 108 query92 61 51 53 51 query93 1265504 502 502 query94 1227185 190 185 query95 400 303 310 303 query96 570 271 265 265 query97 3151298830282988 query98 235 225 217 217 query99 1124867 909 867 Total cold run time: 281586 ms Total hot run time: 187104 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [enhancement]Optimize GeoFunctions for const columns [doris]
doris-robot commented on PR #34396: URL: https://github.com/apache/doris/pull/34396#issuecomment-2113930647 TPC-H: Total hot run time: 41893 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 946b41a9279055413b2a6d0764be37ab93b1181d, data reload: false -- Round 1 -- q1 17611 426342114211 q2 2018198 186 186 q3 10429 126411581158 q4 10189 984 749 749 q5 7465272226942694 q6 230 138 131 131 q7 1007610 597 597 q8 9230213521262126 q9 9306671566596659 q10 9641391939333919 q11 467 240 253 240 q12 434 226 232 226 q13 17216 312631923126 q14 271 233 221 221 q15 513 460 482 460 q16 472 392 399 392 q17 979 714 768 714 q18 8361779877637763 q19 4818159415601560 q20 650 316 324 316 q21 5207420641654165 q22 351 280 285 280 Total cold run time: 116865 ms Total hot run time: 41893 ms - Round 2, with runtime_filter_mode=off - q1 4607440343634363 q2 374 269 276 269 q3 3177299830082998 q4 1924160816361608 q5 5497550655395506 q6 214 126 131 126 q7 2315194219791942 q8 3270342633713371 q9 8644869386738673 q10 3970376038303760 q11 594 511 497 497 q12 815 629 621 621 q13 15857 312331833123 q14 292 273 270 270 q15 505 491 482 482 q16 490 439 436 436 q17 1826149614991496 q18 7681770674117411 q19 3855160315231523 q20 1979177017541754 q21 4989473448504734 q22 558 480 486 480 Total cold run time: 73433 ms Total hot run time: 55443 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Update](inverted index) update clucene version to latest fix [doris]
doris-robot commented on PR #34847: URL: https://github.com/apache/doris/pull/34847#issuecomment-2113930471 TeamCity be ut coverage result: Function Coverage: 35.71% (8998/25199) Line Coverage: 27.38% (74457/271954) Region Coverage: 26.62% (38491/144616) Branch Coverage: 23.43% (19639/83806) Coverage Report: http://coverage.selectdb-in.cc/coverage/74e230fb2b4eb35fce75292fed61eec9e0a77596_74e230fb2b4eb35fce75292fed61eec9e0a77596/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](jdbc catalog) split trino jdbc executor [doris]
doris-robot commented on PR #34932: URL: https://github.com/apache/doris/pull/34932#issuecomment-2113930374 TeamCity be ut coverage result: Function Coverage: 35.70% (8996/25199) Line Coverage: 27.37% (74430/271955) Region Coverage: 26.60% (38470/144618) Branch Coverage: 23.42% (19627/83808) Coverage Report: http://coverage.selectdb-in.cc/coverage/eb9496f47df4717d5eb90c97c443da104baed26e_eb9496f47df4717d5eb90c97c443da104baed26e/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](decimal) improve overflow error message [doris]
jacktengg commented on code in PR #34689:
URL: https://github.com/apache/doris/pull/34689#discussion_r1602532377
##
be/src/vec/data_types/data_type_date.h:
##
@@ -60,6 +60,12 @@ class DataTypeDate final : public DataTypeNumberBase {
bool equals(const IDataType& rhs) const override;
std::string to_string(const IColumn& column, size_t row_num) const
override;
void to_string(const IColumn& column, size_t row_num, BufferWritable&
ostr) const override;
+std::string to_string(Int64 int_val) const {
+doris::VecDateTimeValue value = binary_cast(int_val);
+char buf[64];
Review Comment:
it's formated to datetime format, e.g. 2024-05-16 00:00:00.99，use 64 to
be large enough to contain the result string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](thrift rpc) skip handle retry in asan mode [doris]
doris-robot commented on PR #34813: URL: https://github.com/apache/doris/pull/34813#issuecomment-2113930217 TeamCity be ut coverage result: Function Coverage: 35.71% (8998/25199) Line Coverage: 27.38% (74463/271944) Region Coverage: 26.61% (38485/144611) Branch Coverage: 23.43% (19638/83802) Coverage Report: http://coverage.selectdb-in.cc/coverage/d5158687602dec856fa99eb2b602c8f4078ade78_d5158687602dec856fa99eb2b602c8f4078ade78/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] [Enhancement] statistics error lead to OOM when multi-table join scenario [doris]
yx-keith opened a new issue, #34946: URL: https://github.com/apache/doris/issues/34946 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description In multi-table join scenario, The result of intermediate join will be used as the input of the subsequent joins. During the interval between updating statistics, when we update data, statistics is not collected in time, If we run a multi-table join query within this time interval, the optimizer may choose a poor strategy because there is no correct statistics. for example: select * from example_tbl t1 join example_tbl02 t2 on t1.city=t2.city and t1.city="chengdu" join example_tbl03 t3 on t1.city=t3.city join example_tbl05 t5 on t1.city=t5.city join example_tbl04 t4 on t1.city=t4.city; this is plan:  ### Solution _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (87a7ab973b5 -> f7ffac07d95)
This is an automated email from the ASF dual-hosted git repository.
englefly pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
from 87a7ab973b5 [fix](nereids) slot mapping bug when pushing rf into cte
(#34877)
add f7ffac07d95 [Fix](Nereids) fix leading with cte and same subqueryalias
name (#34838)
No new revisions were added by this update.
Summary of changes:
.../processor/pre/PullUpSubqueryAliasToCTE.java| 11 +-
.../data/nereids_p0/hint/multi_leading.out | 2 +-
.../data/nereids_p0/hint/{t3.csv => t5.csv}| 0
.../data/nereids_p0/hint/{t4.csv => t6.csv}| 0
.../suites/nereids_p0/hint/fix_leading.groovy | 45 ++
5 files changed, 56 insertions(+), 2 deletions(-)
copy regression-test/data/nereids_p0/hint/{t3.csv => t5.csv} (100%)
copy regression-test/data/nereids_p0/hint/{t4.csv => t6.csv} (100%)
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Nereids) fix leading with cte and same subqueryalias name [doris]
englefly merged PR #34838: URL: https://github.com/apache/doris/pull/34838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Nereids) fix leading with cte and same subqueryalias name [doris]
englefly commented on PR #34838: URL: https://github.com/apache/doris/pull/34838#issuecomment-2113921813 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [tmp](pipeline) disable two phase opt by default temporialy [doris]
dataroaring commented on PR #34939: URL: https://github.com/apache/doris/pull/34939#issuecomment-2113921809 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](decimal) improve overflow error message [doris]
zhiqiang- commented on code in PR #34689:
URL: https://github.com/apache/doris/pull/34689#discussion_r1602525371
##
be/src/vec/data_types/data_type_date.h:
##
@@ -60,6 +60,12 @@ class DataTypeDate final : public DataTypeNumberBase {
bool equals(const IDataType& rhs) const override;
std::string to_string(const IColumn& column, size_t row_num) const
override;
void to_string(const IColumn& column, size_t row_num, BufferWritable&
ostr) const override;
+std::string to_string(Int64 int_val) const {
+doris::VecDateTimeValue value = binary_cast(int_val);
+char buf[64];
Review Comment:
so may be 22 bytes is enough? `INT64_MIN` is `-9223372036854775808`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Nereids) fix leading with cte and same subqueryalias name [doris]
LiBinfeng-01 commented on code in PR #34838:
URL: https://github.com/apache/doris/pull/34838#discussion_r1602525149
##
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/pre/PullUpSubqueryAliasToCTE.java:
##
@@ -79,6 +79,15 @@ public Plan visitLogicalCTE(LogicalCTE
logicalCTE, StatementCont
subQueryAlias = new
LogicalSubQueryAlias<>(subQueryAlias.getAlias(), newSubQueryAlias);
}
}
-return visitChildren(this, logicalCTE, context);
+Plan cte = visitChildren(this, logicalCTE, context);
+if (!aliasQueries.isEmpty()) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](mtmv)MTMV deal partition use name instead of id [doris]
zddr commented on PR #34910: URL: https://github.com/apache/doris/pull/34910#issuecomment-2113918629 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](cache) remove entrance of partition cache [doris]
924060929 commented on PR #34830: URL: https://github.com/apache/doris/pull/34830#issuecomment-2113917999 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](decimal) improve overflow error message [doris]
jacktengg commented on code in PR #34689:
URL: https://github.com/apache/doris/pull/34689#discussion_r1602523180
##
be/src/vec/data_types/data_type_date.h:
##
@@ -60,6 +60,12 @@ class DataTypeDate final : public DataTypeNumberBase {
bool equals(const IDataType& rhs) const override;
std::string to_string(const IColumn& column, size_t row_num) const
override;
void to_string(const IColumn& column, size_t row_num, BufferWritable&
ostr) const override;
+std::string to_string(Int64 int_val) const {
+doris::VecDateTimeValue value = binary_cast(int_val);
+char buf[64];
Review Comment:
DataTypeDate is actually DataTypeNumberBase\
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](decimal) improve overflow error message [doris]
jacktengg commented on code in PR #34689:
URL: https://github.com/apache/doris/pull/34689#discussion_r1602523180
##
be/src/vec/data_types/data_type_date.h:
##
@@ -60,6 +60,12 @@ class DataTypeDate final : public DataTypeNumberBase {
bool equals(const IDataType& rhs) const override;
std::string to_string(const IColumn& column, size_t row_num) const
override;
void to_string(const IColumn& column, size_t row_num, BufferWritable&
ostr) const override;
+std::string to_string(Int64 int_val) const {
+doris::VecDateTimeValue value = binary_cast(int_val);
+char buf[64];
Review Comment:
DataTypeDate is actually DataTypeNumberBase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve] The error log should be printed by caller [doris]
github-actions[bot] commented on PR #34935: URL: https://github.com/apache/doris/pull/34935#issuecomment-2113916458 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve] The error log should be printed by caller [doris]
github-actions[bot] commented on PR #34935: URL: https://github.com/apache/doris/pull/34935#issuecomment-2113916435 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](config) Report config name and value if value is illegal [doris]
w41ter commented on PR #34945: URL: https://github.com/apache/doris/pull/34945#issuecomment-2113914352 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](config) Report config name and value if value is illegal [doris]
doris-robot commented on PR #34945: URL: https://github.com/apache/doris/pull/34945#issuecomment-2113914315 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [improve](config) Report config name and value if value is illegal [doris]
w41ter opened a new pull request, #34945: URL: https://github.com/apache/doris/pull/34945 ## Proposed changes Issue Number: close #xxx The former implementation does not report the conf name and value when the input is illegal, just like: ``` Using Java version 17 -Djavax.security.auth.useSubjectCredsOnly=false -)XX:+UseZGC -Xmx8192m -Xms8192m -XX:+HeapDumpOnoutofMemoryError -XX:HeapDumpPath=/mnt/hdd01/ci/master-deploy/fe/log/ -Xlog:gc*:/mnt/ hdd01/ci/master-deploy/fe/log/fe.gc.log.:time -Dcom.mysql.cj.disableAbandonedConnectionCleanup=true Thu 16 May 2024 10:26:36 AM CST java.lang.IllegalArgumentException: type mismatch at org.apache.doris.common.ConfigBase.isBoolean(CoonfigBase.java:310) at org.apache.doris.common.ConfigBase.setConfigField(ConfigBase.java:254) at org.apache.doris.common.ConfigBase.setFields(ConfigBase.java:227) at org.apache.doris.common.ConfigBase.initConf(ConfigBase.java:142) at org.apache.doris.common.ConfigBase.init(ConfigBase.java:109) at org.apache.doris.DorisFE.start(DorisFE.java:106) at org.apache.doris.DorisFE.main(DorisFE.java:83 ``` This PR adds conf name and value in the exception reports to help users to locate the invalid config. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](decimal) improve overflow error message [doris]
zhiqiang- commented on code in PR #34689:
URL: https://github.com/apache/doris/pull/34689#discussion_r1602520447
##
be/src/vec/data_types/data_type_date_time.cpp:
##
@@ -56,6 +56,14 @@ std::string DataTypeDateTime::to_string(const IColumn&
column, size_t row_num) c
return buf;
}
+std::string DataTypeDateTime::to_string(Int64 int_val) const {
Review Comment:
since `to string` of decimal can not be static
##
be/src/vec/data_types/data_type_date_time.h:
##
@@ -84,6 +84,7 @@ class DataTypeDateTime final : public
DataTypeNumberBase {
bool equals(const IDataType& rhs) const override;
std::string to_string(const IColumn& column, size_t row_num) const
override;
+std::string to_string(Int64 value) const;
Review Comment:
since `to string` of decimal can not be static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](decimal) improve overflow error message [doris]
zhiqiang- commented on code in PR #34689:
URL: https://github.com/apache/doris/pull/34689#discussion_r1602520216
##
be/src/vec/data_types/data_type_date.h:
##
@@ -60,6 +60,12 @@ class DataTypeDate final : public DataTypeNumberBase {
bool equals(const IDataType& rhs) const override;
std::string to_string(const IColumn& column, size_t row_num) const
override;
void to_string(const IColumn& column, size_t row_num, BufferWritable&
ostr) const override;
+std::string to_string(Int64 int_val) const {
Review Comment:
since `to string` of decimal can not be static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](decimal) improve overflow error message [doris]
zhiqiang- commented on code in PR #34689:
URL: https://github.com/apache/doris/pull/34689#discussion_r1602510916
##
be/src/vec/data_types/data_type_date_time.cpp:
##
@@ -56,6 +56,14 @@ std::string DataTypeDateTime::to_string(const IColumn&
column, size_t row_num) c
return buf;
}
+std::string DataTypeDateTime::to_string(Int64 int_val) const {
+doris::VecDateTimeValue value = binary_cast(int_val);
+
+char buf[64];
Review Comment:
why 64?
##
be/src/vec/data_types/data_type_time_v2.cpp:
##
@@ -60,6 +60,14 @@ std::string DataTypeDateV2::to_string(const IColumn& column,
size_t row_num) con
return std::string {buf};
}
+std::string DataTypeDateV2::to_string(UInt32 int_val) const {
+DateV2Value val = binary_cast>(int_val);
+
+char buf[64];
Review Comment:
why 64
##
be/src/vec/data_types/data_type_number_base.cpp:
##
@@ -65,6 +65,19 @@ void DataTypeNumberBase::to_string(const IColumn& column,
size_t row_num,
}
}
+template
+std::string DataTypeNumberBase::to_string(const T& value) const {
+if constexpr (std::is_same::value || std::is_same::value ||
+ std::is_same::value) {
+return int128_to_string(value);
+} else if constexpr (std::is_integral::value) {
+return std::to_string(value);
+} else if constexpr (std::numeric_limits::is_iec559) {
+fmt::memory_buffer buffer; // only use in size-predictable type.
+fmt::format_to(buffer, "{}", value);
+return std::string(buffer.data(), buffer.size());
Review Comment:
return fmt::format("{}", value);
##
be/src/vec/data_types/data_type_date.h:
##
@@ -60,6 +60,12 @@ class DataTypeDate final : public DataTypeNumberBase {
bool equals(const IDataType& rhs) const override;
std::string to_string(const IColumn& column, size_t row_num) const
override;
void to_string(const IColumn& column, size_t row_num, BufferWritable&
ostr) const override;
+std::string to_string(Int64 int_val) const {
+doris::VecDateTimeValue value = binary_cast(int_val);
+char buf[64];
Review Comment:
why 64?
##
be/src/vec/data_types/data_type_date_time.h:
##
@@ -84,6 +84,7 @@ class DataTypeDateTime final : public
DataTypeNumberBase {
bool equals(const IDataType& rhs) const override;
std::string to_string(const IColumn& column, size_t row_num) const
override;
+std::string to_string(Int64 value) const;
Review Comment:
maybe static
##
be/src/vec/data_types/data_type_date.h:
##
@@ -60,6 +60,12 @@ class DataTypeDate final : public DataTypeNumberBase {
bool equals(const IDataType& rhs) const override;
std::string to_string(const IColumn& column, size_t row_num) const
override;
void to_string(const IColumn& column, size_t row_num, BufferWritable&
ostr) const override;
+std::string to_string(Int64 int_val) const {
Review Comment:
make static ?
##
be/src/vec/data_types/data_type_date_time.cpp:
##
@@ -56,6 +56,14 @@ std::string DataTypeDateTime::to_string(const IColumn&
column, size_t row_num) c
return buf;
}
+std::string DataTypeDateTime::to_string(Int64 int_val) const {
Review Comment:
maybe static?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[I] [Bug] java.lang.ClassNotFoundException: 'org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat [doris]
huangzhengshun opened a new issue, #34944: URL: https://github.com/apache/doris/issues/34944 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 2.1.3 ### What's Wrong? SemanticException java.lang.ClassNotFoundException: 'org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCStatementImpl.executeStatement(JDBCStatementImpl.java:133) at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.executeStatement(SQLQueryJob.java:582) at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.lambda$1(SQLQueryJob.java:491) at org.jkiss.dbeaver.model.exec.DBExecUtils.tryExecuteRecover(DBExecUtils.java:189) at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.executeSingleQuery(SQLQueryJob.java:498) at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.extractData(SQLQueryJob.java:934) at org.jkiss.dbeaver.ui.editors.sql.SQLEditor$QueryResultsContainer.readData(SQLEditor.java:3928) at org.jkiss.dbeaver.ui.controls.resultset.ResultSetJobDataRead.lambda$0(ResultSetJobDataRead.java:123) at org.jkiss.dbeaver.model.exec.DBExecUtils.tryExecuteRecover(DBExecUtils.java:189) at org.jkiss.dbeaver.ui.controls.resultset.ResultSetJobDataRead.run(ResultSetJobDataRead.java:121) at org.jkiss.dbeaver.ui.controls.resultset.ResultSetViewer$ResultSetDataPumpJob.run(ResultSetViewer.java:5104) at org.jkiss.dbeaver.model.runtime.AbstractJob.run(AbstractJob.java:105) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63) Caused by: org.apache.hive.service.cli.HiveSQLException: Error while compiling statement: FAILED: SemanticException java.lang.ClassNotFoundException: 'org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:256) at org.apache.hive.jdbc.Utils.verifySuccessWithInfo(Utils.java:242) at org.apache.hive.jdbc.HiveStatement.execute(HiveStatement.java:254) at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCStatementImpl.execute(JDBCStatementImpl.java:330) at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCStatementImpl.executeStatement(JDBCStatementImpl.java:131) ... 12 more Caused by: org.apache.hive.service.cli.HiveSQLException: Error while compiling statement: FAILED: SemanticException java.lang.ClassNotFoundException: 'org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat at org.apache.hive.service.cli.operation.Operation.toSQLException(Operation.java:335) at org.apache.hive.service.cli.operation.SQLOperation.prepare(SQLOperation.java:199) at org.apache.hive.service.cli.operation.SQLOperation.runInternal(SQLOperation.java:260) at org.apache.hive.service.cli.operation.Operation.run(Operation.java:247) at org.apache.hive.service.cli.session.HiveSessionImpl.executeStatementInternal(HiveSessionImpl.java:541) at org.apache.hive.service.cli.session.HiveSessionImpl.executeStatementAsync(HiveSessionImpl.java:527) at sun.reflect.GeneratedMethodAccessor48.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hive.service.cli.session.HiveSessionProxy.invoke(HiveSessionProxy.java:78) at org.apache.hive.service.cli.session.HiveSessionProxy.access$000(HiveSessionProxy.java:36) at org.apache.hive.service.cli.session.HiveSessionProxy$1.run(HiveSessionProxy.java:63) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1899) ### What You Expected? 通过doris创建hive，能在hive中正常查询 ### How to Reproduce? 通过doris创建hive表，在doris中能正常查询，但是通过hive无法查询数据，同时获取表结构，发现OUTPUTFORMAT有问题，中间有\。 --创建后hive表结构 CREATE TABLE `doris_test_v5`( `account_book` string COMMENT '', `voucher_no` string COMMENT '', `item_no` string COMMENT '', `voucher_type` string COMMENT '', `account_no` string COMMENT '', `subject_illustration` string COMMENT '', `supplier_code` string COMMENT '', `supplier_name` string COMMENT '', `posting_code` string COMMENT '', `special_gl_id` string COMMENT '', `voucher_date` string COMMENT '', `voucher_abstract` string COMMENT '', `currency_code` string COMMENT '', `original_amount` string COMMENT '', `exchange_rate` string COMMENT '', `equivalent_amount` string COMMENT '', `quantity` string COMMENT '', `unit` string COMMENT '', `project_code` string COMMENT '',
Re: [I] [Bug] java.lang.ClassNotFoundException: 'org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat [doris]
huangzhengshun closed issue #34943: [Bug] java.lang.ClassNotFoundException: 'org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat URL: https://github.com/apache/doris/issues/34943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (f237845f230 -> 87a7ab973b5)
This is an automated email from the ASF dual-hosted git repository. englefly pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from f237845f230 [refactor](jdbc catalog) split oceanbase jdbc executor (#34869) add 87a7ab973b5 [fix](nereids) slot mapping bug when pushing rf into cte (#34877) No new revisions were added by this update. Summary of changes: .../processor/post/RuntimeFilterGenerator.java | 89 + .../data/query_p0/join/rqg/rqg4442/rqg4442.out | 117 +++ .../query_p0/join/rqg/rqg4265/rqg4265.groovy | 4 +- .../query_p0/join/rqg/rqg4442/rqg4442.groovy | 221 + 4 files changed, 386 insertions(+), 45 deletions(-) create mode 100644 regression-test/data/query_p0/join/rqg/rqg4442/rqg4442.out create mode 100644 regression-test/suites/query_p0/join/rqg/rqg4442/rqg4442.groovy - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) slot mapping bug when pushing rf into cte [doris]
englefly merged PR #34877: URL: https://github.com/apache/doris/pull/34877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](cache) remove entrance of partition cache [doris]
924060929 commented on code in PR #34830:
URL: https://github.com/apache/doris/pull/34830#discussion_r1602507214
##
fe/fe-core/src/main/java/org/apache/doris/qe/cache/CacheAnalyzer.java:
##
@@ -142,11 +142,12 @@ private void checkCacheConfig() {
enableSqlCache = true;
}
}
-if (Config.cache_enable_partition_mode) {
-if (context.getSessionVariable().isEnablePartitionCache()) {
-enablePartitionCache = true;
-}
-}
+enablePartitionCache = false;
+// if (Config.cache_enable_partition_mode) {
+// if (context.getSessionVariable().isEnablePartitionCache()) {
+// enablePartitionCache = true;
+// }
+// }
Review Comment:
> remove useless code, not comment them?
I think the readers can use git blame to find this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](exec) opt const expr exec in set operator [doris]
github-actions[bot] commented on PR #34823: URL: https://github.com/apache/doris/pull/34823#issuecomment-2113904413 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](cache) remove entrance of partition cache [doris]
924060929 commented on code in PR #34830:
URL: https://github.com/apache/doris/pull/34830#discussion_r1602512568
##
fe/fe-core/src/main/java/org/apache/doris/qe/cache/CacheAnalyzer.java:
##
@@ -142,11 +142,12 @@ private void checkCacheConfig() {
enableSqlCache = true;
}
}
-if (Config.cache_enable_partition_mode) {
-if (context.getSessionVariable().isEnablePartitionCache()) {
-enablePartitionCache = true;
-}
-}
+enablePartitionCache = false;
+// if (Config.cache_enable_partition_mode) {
+// if (context.getSessionVariable().isEnablePartitionCache()) {
+// enablePartitionCache = true;
+// }
+// }
Review Comment:
maybe we will revert this comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](function) money format [doris]
github-actions[bot] commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2113903811 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Opt](Iceberg) handle count pushdown in fe side [doris]
zhangbutao commented on PR #34928: URL: https://github.com/apache/doris/pull/34928#issuecomment-2113903889 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](planner) fix unrequired slot when join node [doris]
nextdreamblue commented on PR #34923: URL: https://github.com/apache/doris/pull/34923#issuecomment-2113901492 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (1cc2c9a9b77 -> f237845f230)
This is an automated email from the ASF dual-hosted git repository. zykkk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 1cc2c9a9b77 [refactor](jdbc catalog) split clickhouse jdbc executor (#34794) add f237845f230 [refactor](jdbc catalog) split oceanbase jdbc executor (#34869) No new revisions were added by this update. Summary of changes: be/src/vec/exec/vjdbc_connector.cpp| 3 ++- .../org/apache/doris/jdbc/JdbcExecutorFactory.java | 2 ++ .../doris/datasource/jdbc/client/JdbcClient.java | 3 ++- .../doris/datasource/jdbc/client/JdbcMySQLClient.java | 6 ++ .../datasource/jdbc/client/JdbcOceanBaseClient.java| 18 ++ .../doris/datasource/jdbc/client/JdbcOracleClient.java | 5 + 6 files changed, 27 insertions(+), 10 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](jdbc catalog) split oceanbase jdbc executor [doris]
zy-kkk merged PR #34869: URL: https://github.com/apache/doris/pull/34869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](exec) opt const expr exec in set operator [doris]
HappenLee commented on PR #34823: URL: https://github.com/apache/doris/pull/34823#issuecomment-2113900478 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](jdbc catalog) split trino jdbc executor [doris]
zy-kkk commented on PR #34932: URL: https://github.com/apache/doris/pull/34932#issuecomment-2113900474 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (a17214dce89 -> 1cc2c9a9b77)
This is an automated email from the ASF dual-hosted git repository. zykkk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from a17214dce89 [Fix](inverted index) fix race condition for column reader load inverted index reader (#34922) add 1cc2c9a9b77 [refactor](jdbc catalog) split clickhouse jdbc executor (#34794) No new revisions were added by this update. Summary of changes: .../apache/doris/jdbc/ClickHouseJdbcExecutor.java | 212 + .../org/apache/doris/jdbc/JdbcExecutorFactory.java | 2 + .../jdbc/test_clickhouse_jdbc_catalog.out | Bin 5493 -> 5528 bytes 3 files changed, 214 insertions(+) create mode 100644 fe/be-java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/ClickHouseJdbcExecutor.java - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](jdbc catalog) split oceanbase jdbc executor [doris]
zy-kkk commented on PR #34869: URL: https://github.com/apache/doris/pull/34869#issuecomment-2113899695 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](jdbc catalog) split clickhouse jdbc executor [doris]
zy-kkk merged PR #34794: URL: https://github.com/apache/doris/pull/34794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
