[GitHub] [incubator-doris] morningman commented on pull request #3604: (#3464) fix Query failed when fact table has no data in join case
morningman commented on pull request #3604: URL: https://github.com/apache/incubator-doris/pull/3604#issuecomment-635962189 > I think we can set `partition join` as default when we're unable to estimate the cost accurately and broadcast join cost equals partition join cost and without user hint. This LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #3604: (#3464) fix Query failed when fact table has no data in join case
morningman commented on pull request #3604: URL: https://github.com/apache/incubator-doris/pull/3604#issuecomment-635091296 > @morningman > The key point is that it's currently impossible to accurately estimate the size of the memory footprint at runtime according to table size.Otherwise, we can choose the right join mode or the correct num backends. > At present, it seems that it can only be adjusted manually. User decide the join mode. So I think just use the `shuffle hint` is enough? No need to add new config `HASH_TBL_SPACE_OVERHEAD` or disallow broadcast large than 100MB? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #3604: (#3464) fix Query failed when fact table has no data in join case
morningman commented on pull request #3604: URL: https://github.com/apache/incubator-doris/pull/3604#issuecomment-632976533 > 1 make HASH_TBL_SPACE_OVERHEAD a configurable param,but it seems not a common solution, because I'm not sure what factors can affect the real hash table size. > 2 maybe we can disable broadcast when dim table exceeds 100M These 2 solutions looks seem, that both require manual parameter adjustment. This is no different from directly adding hints manually. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
