Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-26 Thread via GitHub


starocean999 merged PR #35323:
URL: https://github.com/apache/doris/pull/35323


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-26 Thread via GitHub


xiaokang merged PR #35385:
URL: https://github.com/apache/doris/pull/35385


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-24 Thread via GitHub


starocean999 commented on PR #35385:
URL: https://github.com/apache/doris/pull/35385#issuecomment-2129721861

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-24 Thread via GitHub


doris-robot commented on PR #35385:
URL: https://github.com/apache/doris/pull/35385#issuecomment-2129721555

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-24 Thread via GitHub


starocean999 opened a new pull request, #35385:
URL: https://github.com/apache/doris/pull/35385

   …
   pick from master https://github.com/apache/doris/pull/35074
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-23 Thread via GitHub


morrySnow merged PR #35074:
URL: https://github.com/apache/doris/pull/35074


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2128479428

   
   
   ClickBench: Total hot run time: 29.98 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit dc37fc688ee625d9982919218359f7ee299e4c9d, 
data reload: false
   
   query1   0.040.030.03
   query2   0.080.040.04
   query3   0.230.050.05
   query4   1.670.080.08
   query5   0.500.500.49
   query6   1.130.730.72
   query7   0.020.020.02
   query8   0.050.040.04
   query9   0.540.480.48
   query10  0.530.560.55
   query11  0.150.110.11
   query12  0.150.120.12
   query13  0.590.580.60
   query14  0.770.790.78
   query15  0.840.810.80
   query16  0.370.380.38
   query17  1.021.030.97
   query18  0.220.250.23
   query19  1.811.771.76
   query20  0.020.010.01
   query21  15.56   0.670.64
   query22  4.087.981.37
   query23  18.25   1.351.30
   query24  1.820.210.22
   query25  0.160.080.09
   query26  0.260.160.17
   query27  0.090.080.08
   query28  13.39   1.010.99
   query29  13.82   3.253.22
   query30  0.240.060.05
   query31  2.880.390.37
   query32  3.290.470.47
   query33  2.953.042.89
   query34  17.09   4.454.43
   query35  4.524.474.66
   query36  0.640.470.45
   query37  0.170.150.15
   query38  0.160.140.14
   query39  0.040.030.03
   query40  0.160.130.14
   query41  0.080.040.05
   query42  0.060.040.04
   query43  0.040.040.03
   Total cold run time: 110.48 s
   Total hot run time: 29.98 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2128476220

   
   
   TPC-DS: Total hot run time: 169796 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit dc37fc688ee625d9982919218359f7ee299e4c9d, 
data reload: false
   
   query1   917 384 360 360
   query2   6435243124552431
   query3   6684220 221 220
   query4   19552   17456   17286   17286
   query5   4101422 426 422
   query6   251 157 156 156
   query7   4592299 290 290
   query8   241 195 186 186
   query9   8485236523512351
   query10  454 291 267 267
   query11  10581   10177   10166   10166
   query12  143 95  91  91
   query13  1649368 369 368
   query14  10146   713377317133
   query15  231 176 174 174
   query16  7906283 278 278
   query17  1684553 533 533
   query18  1895284 279 279
   query19  209 200 157 157
   query20  95  85  85  85
   query21  203 131 130 130
   query22  4137403139273927
   query23  33528   33010   33030   33010
   query24  6872293628552855
   query25  565 361 373 361
   query26  698 167 164 164
   query27  1966331 320 320
   query28  3800202320212021
   query29  862 617 627 617
   query30  261 170 178 170
   query31  974 742 743 742
   query32  91  52  55  52
   query33  521 267 262 262
   query34  851 482 475 475
   query35  718 600 584 584
   query36  1026917 897 897
   query37  104 74  77  74
   query38  2908279327932793
   query39  832 784 760 760
   query40  202 126 130 126
   query41  46  44  42  42
   query42  104 97  97  97
   query43  552 565 552 552
   query44  1078714 736 714
   query45  185 193 162 162
   query46  1070704 739 704
   query47  1844175317761753
   query48  366 297 294 294
   query49  811 395 401 395
   query50  767 376 391 376
   query51  6889676368306763
   query52  100 93  88  88
   query53  356 288 289 288
   query54  556 454 425 425
   query55  76  75  75  75
   query56  266 245 254 245
   query57  1126105110141014
   query58  259 220 203 203
   query59  3403331531613161
   query60  297 264 253 253
   query61  93  88  87  87
   query62  577 470 447 447
   query63  313 286 294 286
   query64  8495222317811781
   query65  3131308831303088
   query66  771 327 332 327
   query67  15286   14844   14802   14802
   query68  4566544 549 544
   query69  440 275 274 274
   query70  1177112811611128
   query71  396 275 273 273
   query72  7668272226052605
   query73  720 324 321 321
   query74  6046557155645564
   query75  3332262526642625
   query76  22531054944 944
   query77  401 280 314 280
   query78  10278   980996999699
   query79  2534525 517 517
   query80  967 448 437 437
   query81  537 248 243 243
   query82  759 97  96  96
   query83  254 171 167 167
   query84  249 85  86  85
   query85  1251273 269 269
   query86  504 292 290 290
   query87  3274308331403083
   query88  4187235023212321
   query89  490 404 399 399
   query90  2063190 241 190
   query91  128 98  97  97
   query92  68  48  48  48
   query93  1863509 504 504
   query94  1130198 186 186
   query95  410 308 312 308
   query96  580 271 264 264
   query97  3215300230223002
   query98  242 221 210 210
   query99  1146828 860 828
   Total cold run time: 259315 ms
   Total hot run time: 169796 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp

Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2128468879

   
   
   TPC-H: Total hot run time: 41160 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit dc37fc688ee625d9982919218359f7ee299e4c9d, 
data reload: false
   
   -- Round 1 --
   q1   17612   430142904290
   q2   2019195 193 193
   q3   10463   126712121212
   q4   10195   748 853 748
   q5   7457269926472647
   q6   222 140 138 138
   q7   959 610 618 610
   q8   9216213420942094
   q9   9197670967436709
   q10  9114392238753875
   q11  460 243 245 243
   q12  488 227 232 227
   q13  18372   325132283228
   q14  265 227 231 227
   q15  535 492 496 492
   q16  517 406 403 403
   q17  965 637 701 637
   q18  8368787578107810
   q19  5493154814951495
   q20  651 313 320 313
   q21  5156390132833283
   q22  354 286 290 286
   Total cold run time: 118078 ms
   Total hot run time: 41160 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4505439844114398
   q2   385 273 284 273
   q3   3148294628782878
   q4   1939172716781678
   q5   5315545754995457
   q6   220 133 133 133
   q7   2205185918251825
   q8   3219338334003383
   q9   8671864387108643
   q10  4116381637033703
   q11  585 462 480 462
   q12  810 614 611 611
   q13  15990   316431043104
   q14  306 264 289 264
   q15  523 493 493 493
   q16  492 435 445 435
   q17  1834154015161516
   q18  7960760574007400
   q19  1661157315491549
   q20  1967176717921767
   q21  4889467946394639
   q22  561 500 508 500
   Total cold run time: 71301 ms
   Total hot run time: 55111 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-23 Thread via GitHub


github-actions[bot] commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2128431288

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-23 Thread via GitHub


starocean999 opened a new pull request, #35323:
URL: https://github.com/apache/doris/pull/35323

   …
   
   pick from master https://github.com/apache/doris/pull/35074
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35323:
URL: https://github.com/apache/doris/pull/35323#issuecomment-2128397674

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-23 Thread via GitHub


starocean999 commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2128394179

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2128315776

   
   
   ClickBench: Total hot run time: 30.38 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit a788620a7bf7ec1cb96f1f3263b8495914ff2de4, 
data reload: false
   
   query1   0.040.040.04
   query2   0.080.040.05
   query3   0.230.050.04
   query4   1.680.070.07
   query5   0.490.490.50
   query6   1.130.720.73
   query7   0.020.010.01
   query8   0.060.040.04
   query9   0.550.490.47
   query10  0.530.560.54
   query11  0.160.110.11
   query12  0.140.120.12
   query13  0.590.600.59
   query14  0.770.790.78
   query15  0.840.820.81
   query16  0.370.370.37
   query17  0.980.940.94
   query18  0.200.260.26
   query19  1.771.741.69
   query20  0.020.010.01
   query21  15.71   0.670.66
   query22  4.587.241.82
   query23  18.31   1.321.22
   query24  1.790.250.23
   query25  0.160.080.07
   query26  0.260.170.17
   query27  0.080.080.08
   query28  13.29   1.021.00
   query29  13.10   3.253.25
   query30  0.260.060.06
   query31  2.860.390.39
   query32  3.310.480.47
   query33  2.872.912.91
   query34  17.25   4.464.41
   query35  4.494.464.51
   query36  0.640.450.46
   query37  0.180.160.15
   query38  0.150.150.14
   query39  0.040.040.03
   query40  0.160.140.14
   query41  0.100.040.04
   query42  0.050.050.05
   query43  0.040.040.04
   Total cold run time: 110.33 s
   Total hot run time: 30.38 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2128311633

   
   
   TPC-DS: Total hot run time: 169240 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit a788620a7bf7ec1cb96f1f3263b8495914ff2de4, 
data reload: false
   
   query1   911 375 361 361
   query2   6441250823592359
   query3   6662206 208 206
   query4   19872   17060   17351   17060
   query5   4183425 422 422
   query6   260 176 166 166
   query7   4593297 293 293
   query8   237 191 187 187
   query9   8450235923712359
   query10  456 305 264 264
   query11  10731   10112   10077   10077
   query12  134 100 86  86
   query13  1635363 368 363
   query14  9296773968066806
   query15  213 180 174 174
   query16  7793261 254 254
   query17  1855527 530 527
   query18  1946270 279 270
   query19  200 167 166 166
   query20  93  90  87  87
   query21  197 129 127 127
   query22  4203403738853885
   query23  33966   33018   32981   32981
   query24  11981   285027982798
   query25  663 357 391 357
   query26  1811159 155 155
   query27  3062324 318 318
   query28  7596203420172017
   query29  1149610 607 607
   query30  287 172 173 172
   query31  975 760 760 760
   query32  81  54  55  54
   query33  760 273 263 263
   query34  1053494 487 487
   query35  734 615 597 597
   query36  1064928 916 916
   query37  281 72  76  72
   query38  2904282027292729
   query39  911 808 797 797
   query40  280 132 138 132
   query41  80  44  42  42
   query42  101 99  99  99
   query43  604 556 584 556
   query44  1244719 734 719
   query45  179 167 165 165
   query46  1071734 735 734
   query47  1831174617611746
   query48  383 288 287 287
   query49  1185395 387 387
   query50  763 407 391 391
   query51  6895687367516751
   query52  108 90  105 90
   query53  351 291 290 290
   query54  955 430 419 419
   query55  75  74  77  74
   query56  266 246 268 246
   query57  1152103910161016
   query58  258 215 215 215
   query59  3529304932833049
   query60  291 266 254 254
   query61  92  87  87  87
   query62  656 435 458 435
   query63  314 299 294 294
   query64  9789222117951795
   query65  3178306631053066
   query66  1385341 320 320
   query67  15288   14744   14777   14744
   query68  4531545 542 542
   query69  446 267 281 267
   query70  1134113811681138
   query71  393 272 277 272
   query72  7611549326962696
   query73  713 326 320 320
   query74  6117563455535553
   query75  3386265526342634
   query76  2604995 970 970
   query77  442 275 279 275
   query78  10161   987499009874
   query79  2469510 509 509
   query80  1069460 450 450
   query81  527 253 254 253
   query82  950 99  101 99
   query83  257 184 181 181
   query84  243 93  89  89
   query85  1331337 326 326
   query86  440 310 302 302
   query87  3266316031003100
   query88  4254235323352335
   query89  485 414 395 395
   query90  1970193 189 189
   query91  135 106 107 106
   query92  64  49  50  49
   query93  1689514 496 496
   query94  1286198 192 192
   query95  419 323 318 318
   query96  595 265 264 264
   query97  3170302330003000
   query98  239 221 220 220
   query99  1148844 866 844
   Total cold run time: 275486 ms
   Total hot run time: 169240 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s

Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2128304059

   
   
   TPC-H: Total hot run time: 40581 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit a788620a7bf7ec1cb96f1f3263b8495914ff2de4, 
data reload: false
   
   -- Round 1 --
   q1   18149   445444114411
   q2   2517197 215 197
   q3   11071   117511631163
   q4   10649   850 733 733
   q5   7575269326882688
   q6   219 130 134 130
   q7   959 619 600 600
   q8   9617210520672067
   q9   8846652264806480
   q10  8872372036913691
   q11  470 236 231 231
   q12  438 213 214 213
   q13  18836   295029662950
   q14  260 224 225 224
   q15  510 480 469 469
   q16  527 381 381 381
   q17  963 654 705 654
   q18  8089740474327404
   q19  6146157214931493
   q20  649 299 310 299
   q21  4886383138573831
   q22  339 282 272 272
   Total cold run time: 120587 ms
   Total hot run time: 40581 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4380423642254225
   q2   363 262 249 249
   q3   2933279326862686
   q4   1847160915671567
   q5   5239527952685268
   q6   208 122 123 122
   q7   2086171317241713
   q8   3168330332933293
   q9   8319827583428275
   q10  3851370936803680
   q11  578 494 493 493
   q12  781 610 608 608
   q13  16445   297130132971
   q14  300 259 282 259
   q15  509 476 467 467
   q16  463 441 422 422
   q17  1763145814511451
   q18  7569744174487441
   q19  1687156215981562
   q20  1963176818121768
   q21  4919472446794679
   q22  533 485 487 485
   Total cold run time: 69904 ms
   Total hot run time: 53684 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-23 Thread via GitHub


starocean999 commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2128286525

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2126763349

   
   
   ClickBench: Total hot run time: 30.72 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 6bf64202255799eff7611c4f278ee8cc148aaafe, 
data reload: false
   
   query1   0.040.030.04
   query2   0.080.040.04
   query3   0.240.060.06
   query4   1.660.090.10
   query5   0.510.500.51
   query6   1.130.730.73
   query7   0.020.010.01
   query8   0.050.040.04
   query9   0.530.480.49
   query10  0.570.550.53
   query11  0.150.110.12
   query12  0.140.120.11
   query13  0.590.590.62
   query14  0.800.760.78
   query15  0.830.810.81
   query16  0.370.360.37
   query17  0.980.950.93
   query18  0.220.260.22
   query19  1.741.701.76
   query20  0.020.010.01
   query21  15.52   0.670.66
   query22  4.806.382.15
   query23  18.23   1.381.30
   query24  1.730.230.20
   query25  0.140.080.08
   query26  0.270.170.17
   query27  0.080.080.07
   query28  13.50   1.000.99
   query29  13.23   3.353.25
   query30  0.260.060.05
   query31  2.860.400.40
   query32  3.260.470.48
   query33  2.932.932.91
   query34  17.14   4.414.50
   query35  4.504.484.52
   query36  0.650.450.46
   query37  0.170.170.16
   query38  0.150.150.14
   query39  0.050.040.03
   query40  0.170.130.14
   query41  0.100.040.04
   query42  0.060.040.05
   query43  0.040.030.04
   Total cold run time: 110.51 s
   Total hot run time: 30.72 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2126750923

   
   
   TPC-DS: Total hot run time: 169486 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 6bf64202255799eff7611c4f278ee8cc148aaafe, 
data reload: false
   
   query1   922 376 382 376
   query2   6956232523842325
   query3   6649204 207 204
   query4   19703   17493   17305   17305
   query5   4125430 429 429
   query6   263 160 157 157
   query7   4577309 290 290
   query8   252 186 188 186
   query9   8706244424312431
   query10  456 280 261 261
   query11  10490   10277   99759975
   query12  132 93  87  87
   query13  1635377 357 357
   query14  10102   706570037003
   query15  206 172 172 172
   query16  7802284 273 273
   query17  1828537 534 534
   query18  1933279 285 279
   query19  218 157 157 157
   query20  95  84  89  84
   query21  199 128 136 128
   query22  4143403039303930
   query23  33713   32945   32981   32945
   query24  12105   277828772778
   query25  675 371 383 371
   query26  1797162 163 162
   query27  2996327 321 321
   query28  7577207120952071
   query29  1124609 603 603
   query30  303 171 173 171
   query31  978 758 736 736
   query32  88  50  54  50
   query33  769 276 296 276
   query34  986 481 469 469
   query35  740 604 577 577
   query36  1055901 910 901
   query37  281 71  71  71
   query38  2899276027552755
   query39  863 793 778 778
   query40  273 140 120 120
   query41  46  46  42  42
   query42  100 96  93  93
   query43  599 526 551 526
   query44  1199708 735 708
   query45  179 160 164 160
   query46  1083730 702 702
   query47  1832175017821750
   query48  367 296 286 286
   query49  1183374 391 374
   query50  774 392 380 380
   query51  6815675067666750
   query52  96  86  88  86
   query53  345 290 287 287
   query54  975 434 425 425
   query55  75  74  71  71
   query56  264 239 238 238
   query57  1119107310131013
   query58  237 206 206 206
   query59  3291326630303030
   query60  271 257 247 247
   query61  95  90  89  89
   query62  623 469 460 460
   query63  308 280 281 280
   query64  9741225217551755
   query65  3190309831093098
   query66  1371330 331 330
   query67  15265   14836   14798   14798
   query68  4966532 544 532
   query69  477 266 270 266
   query70  1148114111281128
   query71  451 266 315 266
   query72  7696544427532753
   query73  742 320 318 318
   query74  6040560656225606
   query75  3761260125932593
   query76  3599942 962 942
   query77  625 263 255 255
   query78  10384   982498109810
   query79  2282538 528 528
   query80  1252451 439 439
   query81  529 258 249 249
   query82  104695  99  95
   query83  282 179 173 173
   query84  240 93  89  89
   query85  1567335 271 271
   query86  484 292 298 292
   query87  3288311630923092
   query88  4008242624242424
   query89  490 411 385 385
   query90  1993188 191 188
   query91  130 99  98  98
   query92  61  48  49  48
   query93  2172520 518 518
   query94  1217186 184 184
   query95  392 310 314 310
   query96  594 268 267 267
   query97  3166305830353035
   query98  244 229 215 215
   query99  1192835 853 835
   Total cold run time: 278575 ms
   Total hot run time: 169486 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe

Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2126732100

   
   
   TPC-H: Total hot run time: 39882 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 6bf64202255799eff7611c4f278ee8cc148aaafe, 
data reload: false
   
   -- Round 1 --
   q1   17860   435842094209
   q2   2022193 195 193
   q3   10798   129911321132
   q4   11179   789 703 703
   q5   7892270226442644
   q6   219 131 130 130
   q7   957 619 597 597
   q8   9577208420762076
   q9   9079657965766576
   q10  9205365537473655
   q11  458 244 233 233
   q12  499 219 206 206
   q13  17766   301429882988
   q14  253 223 228 223
   q15  509 466 471 466
   q16  533 372 375 372
   q17  952 688 666 666
   q18  8161746574847465
   q19  2929152415221522
   q20  658 309 308 308
   q21  4964323833203238
   q22  352 288 280 280
   Total cold run time: 116822 ms
   Total hot run time: 39882 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4331460442044204
   q2   366 273 270 270
   q3   2956277927262726
   q4   1854157515611561
   q5   5213528752625262
   q6   210 125 129 125
   q7   2131172217201720
   q8   3170331732843284
   q9   8311832783428327
   q10  3918365636963656
   q11  594 490 499 490
   q12  774 594 587 587
   q13  17426   298230152982
   q14  280 261 261 261
   q15  519 465 471 465
   q16  464 415 424 415
   q17  1747147214411441
   q18  7678761075457545
   q19  1640151915921519
   q20  1990180117601760
   q21  9930459947044599
   q22  559 488 475 475
   Total cold run time: 76061 ms
   Total hot run time: 53674 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-23 Thread via GitHub


starocean999 commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2126695073

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-23 Thread via GitHub


englefly commented on code in PR #35074:
URL: https://github.com/apache/doris/pull/35074#discussion_r1611330036


##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/AdjustNullable.java:
##
@@ -165,45 +165,52 @@ public Plan visitLogicalRepeat(LogicalRepeat repeat, Map replaceMap) {
 setOperation = (LogicalSetOperation) super.visit(setOperation, 
replaceMap);
-if (setOperation.children().isEmpty()) {
-return setOperation;
-}
-List inputNullable = 
setOperation.child(0).getOutput().stream()
-.map(ExpressionTrait::nullable).collect(Collectors.toList());
 ImmutableList.Builder> newChildrenOutputs = 
ImmutableList.builder();
-for (int i = 0; i < setOperation.arity(); i++) {
-List childOutput = setOperation.child(i).getOutput();
-List setChildOutput = 
setOperation.getRegularChildOutput(i);
-ImmutableList.Builder newChildOutputs = 
ImmutableList.builder();
-for (int j = 0; j < setChildOutput.size(); j++) {
-for (Slot slot : childOutput) {
-if 
(slot.getExprId().equals(setChildOutput.get(j).getExprId())) {
-inputNullable.set(j, slot.nullable() || 
inputNullable.get(j));
-newChildOutputs.add((SlotReference) slot);
-break;
+List inputNullable = null;
+if (!setOperation.children().isEmpty()) {
+inputNullable = setOperation.child(0).getOutput().stream()
+
.map(ExpressionTrait::nullable).collect(Collectors.toList());
+for (int i = 0; i < setOperation.arity(); i++) {
+List childOutput = setOperation.child(i).getOutput();
+List setChildOutput = 
setOperation.getRegularChildOutput(i);
+ImmutableList.Builder newChildOutputs = 
ImmutableList.builder();
+for (int j = 0; j < setChildOutput.size(); j++) {
+for (Slot slot : childOutput) {
+if 
(slot.getExprId().equals(setChildOutput.get(j).getExprId())) {
+inputNullable.set(j, slot.nullable() || 
inputNullable.get(j));
+newChildOutputs.add((SlotReference) slot);
+break;
+}
 }
 }
+newChildrenOutputs.add(newChildOutputs.build());
 }
-newChildrenOutputs.add(newChildOutputs.build());
 }
 if (setOperation instanceof LogicalUnion) {
 LogicalUnion logicalUnion = (LogicalUnion) setOperation;
+int consExprListSize = logicalUnion.getConstantExprsList().size();
+if (consExprListSize > 0 && inputNullable == null) {

Review Comment:
   !logicalUnion.getConstantExprsList().isEmpty() &&  
!setOperation.children().isEmpty()



##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/AdjustNullable.java:
##
@@ -165,45 +165,52 @@ public Plan visitLogicalRepeat(LogicalRepeat repeat, Map replaceMap) {
 setOperation = (LogicalSetOperation) super.visit(setOperation, 
replaceMap);
-if (setOperation.children().isEmpty()) {
-return setOperation;
-}
-List inputNullable = 
setOperation.child(0).getOutput().stream()
-.map(ExpressionTrait::nullable).collect(Collectors.toList());
 ImmutableList.Builder> newChildrenOutputs = 
ImmutableList.builder();
-for (int i = 0; i < setOperation.arity(); i++) {
-List childOutput = setOperation.child(i).getOutput();
-List setChildOutput = 
setOperation.getRegularChildOutput(i);
-ImmutableList.Builder newChildOutputs = 
ImmutableList.builder();
-for (int j = 0; j < setChildOutput.size(); j++) {
-for (Slot slot : childOutput) {
-if 
(slot.getExprId().equals(setChildOutput.get(j).getExprId())) {
-inputNullable.set(j, slot.nullable() || 
inputNullable.get(j));
-newChildOutputs.add((SlotReference) slot);
-break;
+List inputNullable = null;
+if (!setOperation.children().isEmpty()) {
+inputNullable = setOperation.child(0).getOutput().stream()
+
.map(ExpressionTrait::nullable).collect(Collectors.toList());
+for (int i = 0; i < setOperation.arity(); i++) {
+List childOutput = setOperation.child(i).getOutput();
+List setChildOutput = 
setOperation.getRegularChildOutput(i);
+ImmutableList.Builder newChildOutputs = 
ImmutableList.builder();
+for (int j = 0; j < setChildOutput.size(); j++) {
+for (Slot slot : childOutput) {
+if 
(slot.getExprId().equals(setChildOutput.get(j).getExprId())) {
+ 

Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-22 Thread via GitHub


doris-robot commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2126253280

   
   
   ClickBench: Total hot run time: 30.57 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 3067d1f7ad67da0ce7a906361146facec3bd7e26, 
data reload: false
   
   query1   0.040.030.03
   query2   0.080.030.04
   query3   0.230.040.05
   query4   1.680.070.08
   query5   0.500.490.49
   query6   1.110.720.72
   query7   0.020.010.02
   query8   0.050.040.04
   query9   0.520.500.49
   query10  0.560.560.54
   query11  0.160.110.10
   query12  0.140.120.11
   query13  0.590.590.59
   query14  0.760.780.78
   query15  0.830.810.80
   query16  0.350.370.36
   query17  1.021.061.02
   query18  0.210.200.27
   query19  1.841.791.80
   query20  0.010.020.01
   query21  15.54   0.700.69
   query22  4.017.511.99
   query23  18.34   1.341.20
   query24  1.740.290.21
   query25  0.130.090.07
   query26  0.260.170.17
   query27  0.080.080.08
   query28  13.26   1.011.00
   query29  13.15   3.243.25
   query30  0.240.060.06
   query31  2.860.370.38
   query32  3.300.460.47
   query33  2.922.812.87
   query34  17.18   4.434.43
   query35  4.514.494.53
   query36  0.660.480.47
   query37  0.170.160.15
   query38  0.150.150.14
   query39  0.040.030.04
   query40  0.150.150.15
   query41  0.090.060.05
   query42  0.050.060.05
   query43  0.040.040.04
   Total cold run time: 109.57 s
   Total hot run time: 30.57 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-22 Thread via GitHub


doris-robot commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2126248635

   
   
   TPC-DS: Total hot run time: 169070 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 3067d1f7ad67da0ce7a906361146facec3bd7e26, 
data reload: false
   
   query1   912 386 369 369
   query2   6452236423002300
   query3   6657210 209 209
   query4   19564   17329   17386   17329
   query5   4245417 417 417
   query6   244 158 161 158
   query7   4583295 301 295
   query8   235 182 191 182
   query9   8436238023472347
   query10  466 276 270 270
   query11  10668   10022   99339933
   query12  135 90  87  87
   query13  1661365 355 355
   query14  9330696772126967
   query15  209 168 172 168
   query16  7797269 269 269
   query17  1506526 527 526
   query18  1953278 275 275
   query19  206 170 159 159
   query20  91  80  88  80
   query21  192 129 131 129
   query22  4262407138713871
   query23  33424   33460   33093   33093
   query24  12296   276328382763
   query25  658 369 384 369
   query26  1834156 164 156
   query27  3081309 314 309
   query28  7691201920362019
   query29  1166606 601 601
   query30  318 173 172 172
   query31  922 746 737 737
   query32  82  53  55  53
   query33  764 281 279 279
   query34  1075480 482 480
   query35  734 656 609 609
   query36  1108941 922 922
   query37  276 71  75  71
   query38  2936278827552755
   query39  844 804 795 795
   query40  277 126 123 123
   query41  46  44  39  39
   query42  105 95  97  95
   query43  597 565 546 546
   query44  1200721 742 721
   query45  193 170 170 170
   query46  1077738 711 711
   query47  1833173917801739
   query48  367 289 302 289
   query49  1178379 386 379
   query50  789 387 382 382
   query51  6942674369086743
   query52  102 85  93  85
   query53  348 290 282 282
   query54  952 429 418 418
   query55  72  74  71  71
   query56  291 245 264 245
   query57  1115106010521052
   query58  239 206 209 206
   query59  3358309931073099
   query60  263 256 250 250
   query61  90  87  89  87
   query62  643 464 446 446
   query63  310 277 286 277
   query64  9801218217451745
   query65  3202307231143072
   query66  1388329 327 327
   query67  15339   14716   14772   14716
   query68  4494534 536 534
   query69  437 264 275 264
   query70  1177104010981040
   query71  390 262 280 262
   query72  7260539227392739
   query73  714 325 317 317
   query74  6023564955585558
   query75  3394264526542645
   query76  24441005999 999
   query77  447 264 263 263
   query78  10214   997996929692
   query79  2473510 509 509
   query80  1097432 424 424
   query81  532 248 241 241
   query82  794 96  93  93
   query83  257 172 183 172
   query84  234 97  84  84
   query85  1266268 263 263
   query86  428 300 308 300
   query87  3316313731203120
   query88  4218233823262326
   query89  477 387 367 367
   query90  2027181 181 181
   query91  122 100 99  99
   query92  64  52  49  49
   query93  1901510 491 491
   query94  1304260 180 180
   query95  402 310 305 305
   query96  600 266 271 266
   query97  3171302730083008
   query98  229 221 218 218
   query99  1085871 868 868
   Total cold run time: 274121 ms
   Total hot run time: 169070 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe

Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-22 Thread via GitHub


doris-robot commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2126237891

   
   
   TPC-H: Total hot run time: 40252 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 3067d1f7ad67da0ce7a906361146facec3bd7e26, 
data reload: false
   
   -- Round 1 --
   q1   17618   429942724272
   q2   2020191 185 185
   q3   10867   130212321232
   q4   10492   879 770 770
   q5   7831272127412721
   q6   220 134 130 130
   q7   967 605 608 605
   q8   9613211221122112
   q9   9351663066016601
   q10  9775373637043704
   q11  466 241 224 224
   q12  417 225 211 211
   q13  17753   300229702970
   q14  265 226 219 219
   q15  507 478 477 477
   q16  498 382 373 373
   q17  962 664 673 664
   q18  8120747276257472
   q19  2637156215441544
   q20  642 313 305 305
   q21  4947318833423188
   q22  347 282 273 273
   Total cold run time: 116315 ms
   Total hot run time: 40252 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4397415742094157
   q2   376 278 265 265
   q3   2975276727782767
   q4   1913160216291602
   q5   5242526452995264
   q6   213 125 123 123
   q7   2147176117121712
   q8   3210333533233323
   q9   8372830683948306
   q10  3918374037353735
   q11  579 515 495 495
   q12  776 604 620 604
   q13  16408   295229652952
   q14  290 271 267 267
   q15  527 477 469 469
   q16  481 416 411 411
   q17  1760148214871482
   q18  7740757474767476
   q19  2871157415781574
   q20  1996176217651762
   q21  4977489047534753
   q22  573 509 498 498
   Total cold run time: 71741 ms
   Total hot run time: 53997 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-22 Thread via GitHub


github-actions[bot] commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2126205448

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-22 Thread via GitHub


github-actions[bot] commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2126205428

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-22 Thread via GitHub


starocean999 commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2126188228

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-22 Thread via GitHub


morrySnow commented on code in PR #35074:
URL: https://github.com/apache/doris/pull/35074#discussion_r1609828222


##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/AdjustNullable.java:
##
@@ -165,45 +165,52 @@ public Plan visitLogicalRepeat(LogicalRepeat repeat, Map replaceMap) {
 setOperation = (LogicalSetOperation) super.visit(setOperation, 
replaceMap);
-if (setOperation.children().isEmpty()) {
-return setOperation;
-}
-List inputNullable = 
setOperation.child(0).getOutput().stream()
-.map(ExpressionTrait::nullable).collect(Collectors.toList());
 ImmutableList.Builder> newChildrenOutputs = 
ImmutableList.builder();
-for (int i = 0; i < setOperation.arity(); i++) {
-List childOutput = setOperation.child(i).getOutput();
-List setChildOutput = 
setOperation.getRegularChildOutput(i);
-ImmutableList.Builder newChildOutputs = 
ImmutableList.builder();
-for (int j = 0; j < setChildOutput.size(); j++) {
-for (Slot slot : childOutput) {
-if 
(slot.getExprId().equals(setChildOutput.get(j).getExprId())) {
-inputNullable.set(j, slot.nullable() || 
inputNullable.get(j));
-newChildOutputs.add((SlotReference) slot);
-break;
+List inputNullable = null;
+if (!setOperation.children().isEmpty()) {
+inputNullable = setOperation.child(0).getOutput().stream()
+
.map(ExpressionTrait::nullable).collect(Collectors.toList());
+for (int i = 0; i < setOperation.arity(); i++) {
+List childOutput = setOperation.child(i).getOutput();
+List setChildOutput = 
setOperation.getRegularChildOutput(i);
+ImmutableList.Builder newChildOutputs = 
ImmutableList.builder();
+for (int j = 0; j < setChildOutput.size(); j++) {
+for (Slot slot : childOutput) {
+if 
(slot.getExprId().equals(setChildOutput.get(j).getExprId())) {
+inputNullable.set(j, slot.nullable() || 
inputNullable.get(j));
+newChildOutputs.add((SlotReference) slot);
+break;
+}
 }
 }
+newChildrenOutputs.add(newChildOutputs.build());
 }
-newChildrenOutputs.add(newChildOutputs.build());
 }
 if (setOperation instanceof LogicalUnion) {
 LogicalUnion logicalUnion = (LogicalUnion) setOperation;
+int consExprListSize = logicalUnion.getConstantExprsList().size();
+if (consExprListSize > 0 && inputNullable == null) {
+int outputSize = 
logicalUnion.getConstantExprsList().get(0).size();
+inputNullable = Lists.newArrayListWithCapacity(outputSize);
+for (int i = 0; i < outputSize; i++) {
+inputNullable.add(false);

Review Comment:
   not always false, think about `insert into t values(1),(null)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-21 Thread via GitHub


doris-robot commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2122425109

   
   
   ClickBench: Total hot run time: 30.64 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit d9a04c9f43024de96985fa39b858f97cffa2126a, 
data reload: false
   
   query1   0.040.040.04
   query2   0.080.040.03
   query3   0.230.050.05
   query4   1.660.070.07
   query5   0.500.480.50
   query6   1.130.730.72
   query7   0.020.010.01
   query8   0.050.040.04
   query9   0.540.480.48
   query10  0.550.550.54
   query11  0.150.110.12
   query12  0.150.110.12
   query13  0.590.580.61
   query14  0.770.800.79
   query15  0.830.800.80
   query16  0.370.360.37
   query17  0.970.961.00
   query18  0.220.240.25
   query19  1.761.741.73
   query20  0.010.000.01
   query21  15.55   0.680.66
   query22  3.647.472.05
   query23  18.26   1.361.32
   query24  1.980.230.21
   query25  0.130.080.09
   query26  0.270.180.17
   query27  0.080.080.08
   query28  13.28   1.020.99
   query29  13.25   3.273.30
   query30  0.240.060.05
   query31  2.880.380.37
   query32  3.290.490.46
   query33  2.912.862.93
   query34  17.10   4.404.45
   query35  4.574.484.50
   query36  0.660.460.46
   query37  0.180.150.16
   query38  0.160.150.15
   query39  0.040.030.04
   query40  0.170.150.16
   query41  0.090.050.04
   query42  0.050.040.04
   query43  0.040.040.03
   Total cold run time: 109.44 s
   Total hot run time: 30.64 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-21 Thread via GitHub


doris-robot commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2122415751

   
   
   TPC-DS: Total hot run time: 181671 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit d9a04c9f43024de96985fa39b858f97cffa2126a, 
data reload: false
   
   query1   909 382 364 364
   query2   6459238523992385
   query3   6658218 214 214
   query4   24033   21225   21344   21225
   query5   4153417 432 417
   query6   263 172 168 168
   query7   4569290 276 276
   query8   235 186 192 186
   query9   8444239023882388
   query10  429 247 249 247
   query11  14783   14141   14144   14141
   query12  136 91  86  86
   query13  1637358 362 358
   query14  8865794276947694
   query15  224 173 171 171
   query16  8093281 257 257
   query17  1861536 539 536
   query18  2072281 264 264
   query19  200 147 149 147
   query20  96  85  85  85
   query21  196 126 126 126
   query22  5084488547994799
   query23  34091   33504   33691   33504
   query24  10809   293228572857
   query25  648 390 388 388
   query26  1483159 164 159
   query27  2993326 342 326
   query28  7556204720292029
   query29  938 638 621 621
   query30  313 175 172 172
   query31  983 767 765 765
   query32  93  54  56  54
   query33  761 261 250 250
   query34  1050497 480 480
   query35  803 693 667 667
   query36  1082937 946 937
   query37  151 76  77  76
   query38  2874278427612761
   query39  1632156415861564
   query40  270 125 132 125
   query41  49  46  47  46
   query42  107 105 96  96
   query43  570 593 568 568
   query44  1216725 753 725
   query45  275 252 248 248
   query46  1074707 733 707
   query47  1955188018751875
   query48  368 301 295 295
   query49  1109416 410 410
   query50  777 397 387 387
   query51  6794669068136690
   query52  106 96  97  96
   query53  351 282 287 282
   query54  944 438 424 424
   query55  74  78  77  77
   query56  244 231 237 231
   query57  1241110811321108
   query58  243 207 217 207
   query59  3630305230603052
   query60  287 242 241 241
   query61  107 106 106 106
   query62  670 468 472 468
   query63  317 289 287 287
   query64  10057   229418161816
   query65  3251314431003100
   query66  1396366 360 360
   query67  15497   14882   14825   14825
   query68  8484553 561 553
   query69  567 311 318 311
   query70  1402125211461146
   query71  508 267 286 267
   query72  7986255023642364
   query73  2150320 323 320
   query74  6695628062146214
   query75  4454265726362636
   query76  5178103110301030
   query77  628 264 268 264
   query78  10778   10042   10038   10038
   query79  7322508 526 508
   query80  1148429 429 429
   query81  518 253 244 244
   query82  238 98  99  98
   query83  201 165 183 165
   query84  260 83  84  83
   query85  1006266 259 259
   query86  348 300 283 283
   query87  3321312430853085
   query88  4897234223582342
   query89  521 384 390 384
   query90  2085187 192 187
   query91  122 98  97  97
   query92  62  52  52  52
   query93  5791484 493 484
   query94  1231177 180 177
   query95  393 298 336 298
   query96  617 263 261 261
   query97  3154301329952995
   query98  250 220 208 208
   query99  1228908 893 893
   Total cold run time: 304181 ms
   Total hot run time: 181671 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th

Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-21 Thread via GitHub


doris-robot commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2122395650

   
   
   TPC-H: Total hot run time: 40353 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit d9a04c9f43024de96985fa39b858f97cffa2126a, 
data reload: false
   
   -- Round 1 --
   q1   18028   441743574357
   q2   2621192 193 192
   q3   11121   116912011169
   q4   10484   700 813 700
   q5   8144271126312631
   q6   222 135 135 135
   q7   922 534 535 534
   q8   9247210620482048
   q9   9724706569866986
   q10  8940370637013701
   q11  447 242 233 233
   q12  447 209 210 209
   q13  17843   294829492948
   q14  265 210 220 210
   q15  518 476 484 476
   q16  498 382 378 378
   q17  948 741 711 711
   q18  8003749274537453
   q19  3496152814871487
   q20  647 302 304 302
   q21  4998321440053214
   q22  346 279 284 279
   Total cold run time: 117909 ms
   Total hot run time: 40353 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4437419541394139
   q2   377 250 263 250
   q3   2937273327092709
   q4   1877153315491533
   q5   5238526952595259
   q6   207 125 125 125
   q7   1716136513781365
   q8   3175333432783278
   q9   8862890089438900
   q10  3845367636713671
   q11  603 478 480 478
   q12  750 595 605 595
   q13  16293   295829772958
   q14  291 280 260 260
   q15  514 478 472 472
   q16  485 416 403 403
   q17  1760148714621462
   q18  7632760074007400
   q19  1628152815071507
   q20  2017179317831783
   q21  4920482148064806
   q22  552 491 496 491
   Total cold run time: 70116 ms
   Total hot run time: 53844 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-21 Thread via GitHub


starocean999 commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2122362557

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-20 Thread via GitHub


starocean999 commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2120157871

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-20 Thread via GitHub


doris-robot commented on PR #35074:
URL: https://github.com/apache/doris/pull/35074#issuecomment-2120157765

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [fix](nereids)AdjustNullable rule should handle union node with no children [doris]

2024-05-20 Thread via GitHub


starocean999 opened a new pull request, #35074:
URL: https://github.com/apache/doris/pull/35074

   
   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org