Re: [PR] [opt](thrift)update thrift to support pushing limit to local Agg [doris]
HappenLee merged PR #35204: URL: https://github.com/apache/doris/pull/35204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](thrift)update thrift to support pushing limit to local Agg [doris]
github-actions[bot] commented on PR #35204: URL: https://github.com/apache/doris/pull/35204#issuecomment-2126168447 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](thrift)update thrift to support pushing limit to local Agg [doris]
github-actions[bot] commented on PR #35204: URL: https://github.com/apache/doris/pull/35204#issuecomment-2126168424 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](thrift)update thrift to support pushing limit to local Agg [doris]
doris-robot commented on PR #35204: URL: https://github.com/apache/doris/pull/35204#issuecomment-2124447965 ClickBench: Total hot run time: 30.3 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 1b85187b22fcb61c2708c606ce3be399c8e9fb58, data reload: false query1 0.050.030.03 query2 0.080.040.04 query3 0.230.050.06 query4 1.670.090.10 query5 0.500.500.51 query6 1.130.720.72 query7 0.020.010.01 query8 0.040.040.04 query9 0.550.500.49 query10 0.540.540.54 query11 0.150.120.12 query12 0.160.120.12 query13 0.600.590.59 query14 0.770.770.75 query15 0.820.810.80 query16 0.350.350.35 query17 0.991.041.01 query18 0.220.250.24 query19 1.861.691.76 query20 0.010.010.01 query21 15.65 0.680.64 query22 4.617.051.71 query23 18.30 1.461.27 query24 1.560.370.22 query25 0.130.100.09 query26 0.260.170.17 query27 0.090.080.07 query28 13.30 1.030.99 query29 13.79 3.343.26 query30 0.240.060.05 query31 2.860.410.39 query32 3.250.480.46 query33 2.872.932.91 query34 17.18 4.404.40 query35 4.464.464.67 query36 0.650.460.47 query37 0.190.150.16 query38 0.140.140.14 query39 0.040.040.03 query40 0.170.130.14 query41 0.090.040.04 query42 0.050.050.04 query43 0.040.030.04 Total cold run time: 110.66 s Total hot run time: 30.3 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](thrift)update thrift to support pushing limit to local Agg [doris]
doris-robot commented on PR #35204: URL: https://github.com/apache/doris/pull/35204#issuecomment-2124429589 TPC-DS: Total hot run time: 168264 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 1b85187b22fcb61c2708c606ce3be399c8e9fb58, data reload: false query1 918 384 377 377 query2 6426232223992322 query3 6645202 201 201 query4 20732 17313 17397 17313 query5 4134416 414 414 query6 265 152 151 151 query7 4585293 285 285 query8 243 191 181 181 query9 8603237123502350 query10 445 298 250 250 query11 10773 10135 10214 10135 query12 139 90 88 88 query13 1639359 356 356 query14 10260 748466986698 query15 222 170 168 168 query16 7795264 250 250 query17 1785522 531 522 query18 1867257 268 257 query19 208 152 155 152 query20 100 90 87 87 query21 190 127 127 127 query22 4313407038743874 query23 33595 32865 32807 32807 query24 6726286327572757 query25 524 353 358 353 query26 706 175 155 155 query27 1977303 319 303 query28 3827202720372027 query29 857 591 595 591 query30 239 172 173 172 query31 1027791 739 739 query32 97 54 52 52 query33 500 269 256 256 query34 852 469 471 469 query35 684 620 584 584 query36 1019933 897 897 query37 108 68 72 68 query38 2901286027892789 query39 819 810 795 795 query40 204 130 123 123 query41 49 48 47 47 query42 102 96 102 96 query43 552 540 567 540 query44 1041722 743 722 query45 191 165 159 159 query46 1065700 712 700 query47 1878177818091778 query48 366 296 330 296 query49 771 375 385 375 query50 767 384 384 384 query51 6922680268106802 query52 98 94 89 89 query53 348 287 278 278 query54 529 427 421 421 query55 71 70 70 70 query56 258 237 239 237 query57 1122104710351035 query58 221 203 208 203 query59 3294306330133013 query60 285 285 255 255 query61 87 88 102 88 query62 556 446 448 446 query63 303 278 278 278 query64 8411221018001800 query65 3145307730873077 query66 793 326 315 315 query67 15344 14772 14860 14772 query68 4579520 518 518 query69 433 261 264 261 query70 1141105211281052 query71 385 266 262 262 query72 7423269125312531 query73 712 316 313 313 query74 6077563256925632 query75 3297261125772577 query76 21951017894 894 query77 399 266 279 266 query78 10200 10076 96789678 query79 2157506 509 506 query80 1007454 485 454 query81 510 249 242 242 query82 617 94 94 94 query83 232 170 170 170 query84 251 84 83 83 query85 1337263 257 257 query86 535 295 304 295 query87 3367314231553142 query88 3891231723172317 query89 475 375 364 364 query90 2029184 184 184 query91 121 95 90 90 query92 57 46 50 46 query93 2101507 487 487 query94 1212186 178 178 query95 396 300 303 300 query96 588 277 259 259 query97 3169302229932993 query98 243 226 213 213 query99 1123835 841 835 Total cold run time: 259777 ms Total hot run time: 168264 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [opt](thrift)update thrift to support pushing limit to local Agg [doris]
doris-robot commented on PR #35204: URL: https://github.com/apache/doris/pull/35204#issuecomment-2124404099 TPC-H: Total hot run time: 42085 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 1b85187b22fcb61c2708c606ce3be399c8e9fb58, data reload: false -- Round 1 -- q1 17598 440442954295 q2 2026191 191 191 q3 10460 120211941194 q4 10197 809 727 727 q5 7487272927502729 q6 223 132 139 132 q7 968 627 631 627 q8 9217217221432143 q9 9068675966836683 q10 9361392938573857 q11 436 252 246 246 q12 571 236 236 236 q13 17262 321333123213 q14 273 224 228 224 q15 521 458 487 458 q16 478 384 386 384 q17 1018649 725 649 q18 8511787278457845 q19 6686157015071507 q20 638 325 316 316 q21 5289414441714144 q22 356 285 290 285 Total cold run time: 118644 ms Total hot run time: 42085 ms - Round 2, with runtime_filter_mode=off - q1 4618443644264426 q2 365 278 274 274 q3 3169297328722872 q4 1896164616101610 q5 5592552854935493 q6 215 127 130 127 q7 2229182218341822 q8 3284343534303430 q9 8665875087098709 q10 3993378438383784 q11 612 498 504 498 q12 818 615 641 615 q13 17083 318332073183 q14 326 295 260 260 q15 534 479 490 479 q16 503 438 431 431 q17 1816152714821482 q18 7781773274957495 q19 1682159216141592 q20 1999180318051803 q21 9239478948114789 q22 556 492 488 488 Total cold run time: 76975 ms Total hot run time: 55662 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](thrift)update thrift to support pushing limit to local Agg [doris]
github-actions[bot] commented on PR #35204: URL: https://github.com/apache/doris/pull/35204#issuecomment-2124251907 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](thrift)update thrift to support pushing limit to local Agg [doris]
englefly commented on PR #35204: URL: https://github.com/apache/doris/pull/35204#issuecomment-2124241210 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](thrift)update thrift to support pushing limit to local Agg [doris]
github-actions[bot] commented on PR #35204: URL: https://github.com/apache/doris/pull/35204#issuecomment-2124153747 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](thrift)update thrift to support pushing limit to local Agg [doris]
morrySnow commented on code in PR #35204:
URL: https://github.com/apache/doris/pull/35204#discussion_r1609494698
##
gensrc/thrift/PlanNodes.thrift:
##
@@ -904,7 +904,7 @@ struct TAggregationNode {
7: optional list agg_sort_infos
8: optional bool is_first_phase
9: optional bool is_colocate
- // 9: optional bool use_fixed_length_serialization_opt
+ 10: optional TSortInfo agg_sort_info_by_group_keya
Review Comment:
```suggestion
10: optional TSortInfo agg_sort_info_by_group_key
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](thrift)update thrift to support pushing limit to local Agg [doris]
englefly commented on PR #35204: URL: https://github.com/apache/doris/pull/35204#issuecomment-2124141147 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](thrift)update thrift to support pushing limit to local Agg [doris]
doris-robot commented on PR #35204: URL: https://github.com/apache/doris/pull/35204#issuecomment-2124140956 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [opt](thrift)update thrift to support pushing limit to local Agg [doris]
englefly opened a new pull request, #35204: URL: https://github.com/apache/doris/pull/35204 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
