Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-29 Thread via GitHub


Gabriel39 merged PR #35239:
URL: https://github.com/apache/doris/pull/35239


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-29 Thread via GitHub


github-actions[bot] commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2137276605

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-29 Thread via GitHub


github-actions[bot] commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2137276670

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-28 Thread via GitHub


doris-robot commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2135650406

   
   
   ClickBench: Total hot run time: 30.88 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 3ee7fad049da3335fb98de44d1e76f02eaaf2a7f, 
data reload: false
   
   query1   0.040.030.03
   query2   0.080.040.04
   query3   0.230.060.05
   query4   1.660.090.08
   query5   0.500.490.52
   query6   1.120.730.72
   query7   0.020.010.02
   query8   0.050.040.04
   query9   0.550.480.49
   query10  0.540.560.54
   query11  0.150.120.12
   query12  0.150.120.13
   query13  0.600.580.58
   query14  0.770.790.78
   query15  0.830.810.80
   query16  0.350.360.37
   query17  0.941.001.02
   query18  0.220.230.24
   query19  1.811.771.79
   query20  0.020.010.01
   query21  15.53   0.690.66
   query22  4.026.902.23
   query23  18.25   1.451.19
   query24  1.300.430.23
   query25  0.140.080.08
   query26  0.230.170.17
   query27  0.080.080.07
   query28  13.36   1.011.00
   query29  13.20   3.333.32
   query30  0.250.060.06
   query31  2.870.400.39
   query32  3.260.480.47
   query33  2.882.922.87
   query34  17.21   4.424.39
   query35  4.454.494.44
   query36  0.660.470.48
   query37  0.180.150.16
   query38  0.150.150.15
   query39  0.040.040.04
   query40  0.170.140.16
   query41  0.100.050.04
   query42  0.060.050.04
   query43  0.040.030.04
   Total cold run time: 109.06 s
   Total hot run time: 30.88 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-28 Thread via GitHub


doris-robot commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2135634633

   
   
   TPC-DS: Total hot run time: 169390 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 3ee7fad049da3335fb98de44d1e76f02eaaf2a7f, 
data reload: false
   
   query1   914 384 383 383
   query2   6464257623502350
   query3   6665207 204 204
   query4   19042   17330   17494   17330
   query5   4131421 424 421
   query6   251 158 166 158
   query7   4585304 292 292
   query8   245 205 185 185
   query9   8605245524452445
   query10  452 278 264 264
   query11  10633   10214   10112   10112
   query12  136 91  91  91
   query13  1632369 370 369
   query14  10071   618267906182
   query15  208 193 167 167
   query16  7815269 265 265
   query17  1343515 506 506
   query18  1950273 279 273
   query19  199 154 162 154
   query20  94  89  88  88
   query21  193 139 126 126
   query22  4180419340004000
   query23  33527   33137   33078   33078
   query24  12361   296827422742
   query25  670 362 354 354
   query26  1858160 160 160
   query27  3041316 321 316
   query28  7786208720842084
   query29  1164617 631 617
   query30  289 148 154 148
   query31  956 765 776 765
   query32  97  53  52  52
   query33  761 278 281 278
   query34  1012500 469 469
   query35  747 600 604 600
   query36  1071891 921 891
   query37  276 70  68  68
   query38  2951279327332733
   query39  857 785 805 785
   query40  268 127 129 127
   query41  48  45  44  44
   query42  110 96  96  96
   query43  604 578 541 541
   query44  1251731 743 731
   query45  181 164 162 162
   query46  1070739 687 687
   query47  1867179618391796
   query48  371 298 305 298
   query49  1236380 406 380
   query50  765 377 383 377
   query51  6848676168656761
   query52  102 95  93  93
   query53  350 291 296 291
   query54  1002440 433 433
   query55  75  78  73  73
   query56  255 248 256 248
   query57  1174106710851067
   query58  266 220 210 210
   query59  3393321932973219
   query60  278 256 290 256
   query61  103 101 125 101
   query62  674 437 449 437
   query63  313 288 285 285
   query64  9813223117141714
   query65  3166307731123077
   query66  1380331 321 321
   query67  15629   14797   14641   14641
   query68  4539564 551 551
   query69  450 285 279 279
   query70  1124112811571128
   query71  408 267 289 267
   query72  7585284626872687
   query73  717 327 331 327
   query74  6052561256665612
   query75  3442264726192619
   query76  2921103910151015
   query77  412 276 275 275
   query78  10469   990897909790
   query79  3118517 511 511
   query80  1877463 480 463
   query81  531 222 218 218
   query82  753 98  91  91
   query83  322 177 178 177
   query84  277 94  94  94
   query85  1961316 321 316
   query86  495 326 297 297
   query87  3310313131293129
   query88  4439244924632449
   query89  512 405 387 387
   query90  2052191 185 185
   query91  136 108 110 108
   query92  64  51  51  51
   query93  5017535 505 505
   query94  1240198 198 198
   query95  416 324 323 323
   query96  602 273 271 271
   query97  3261309330283028
   query98  238 226 221 221
   query99  1186847 874 847
   Total cold run time: 281750 ms
   Total hot run time: 169390 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to 

Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-28 Thread via GitHub


doris-robot commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2135612217

   
   
   TPC-H: Total hot run time: 40685 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 3ee7fad049da3335fb98de44d1e76f02eaaf2a7f, 
data reload: false
   
   -- Round 1 --
   q1   17925   456642614261
   q2   2024190 190 190
   q3   10481   118112871181
   q4   10153   850 753 753
   q5   7494275026842684
   q6   213 130 130 130
   q7   944 606 591 591
   q8   9210207420692069
   q9   8786649964596459
   q10  8932371037583710
   q11  458 249 245 245
   q12  401 221 221 221
   q13  17756   298230302982
   q14  271 216 237 216
   q15  521 478 477 477
   q16  509 398 389 389
   q17  956 648 716 648
   q18  8221756775057505
   q19  7087154115131513
   q20  684 322 316 316
   q21  4961386339713863
   q22  361 292 282 282
   Total cold run time: 118348 ms
   Total hot run time: 40685 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4396422042004200
   q2   382 264 271 264
   q3   3013280527302730
   q4   1871156215981562
   q5   5276538753145314
   q6   216 125 128 125
   q7   2131178017551755
   q8   3193333233313331
   q9   8465838983708370
   q10  3924367237333672
   q11  574 487 499 487
   q12  759 565 576 565
   q13  17446   293530292935
   q14  293 255 263 255
   q15  515 474 483 474
   q16  476 424 422 422
   q17  1768146214861462
   q18  7689757475697569
   q19  1654153415431534
   q20  1954180417951795
   q21  4942460647894606
   q22  583 510 510 510
   Total cold run time: 71520 ms
   Total hot run time: 53937 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-28 Thread via GitHub


zclllyybb commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2135438002

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-28 Thread via GitHub


doris-robot commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2135103549

   
   
   ClickBench: Total hot run time: 30.61 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 20521242d5db4823ad522bea94ac2215a8866e5c, 
data reload: false
   
   query1   0.040.030.03
   query2   0.080.040.04
   query3   0.240.060.05
   query4   1.650.070.08
   query5   0.510.490.51
   query6   1.130.720.72
   query7   0.020.010.01
   query8   0.060.050.04
   query9   0.550.490.50
   query10  0.550.530.55
   query11  0.160.110.12
   query12  0.150.110.11
   query13  0.600.590.59
   query14  0.770.810.77
   query15  0.820.800.80
   query16  0.340.370.35
   query17  0.971.000.94
   query18  0.220.250.25
   query19  1.811.771.67
   query20  0.020.010.02
   query21  15.75   0.640.64
   query22  4.417.142.00
   query23  18.31   1.361.28
   query24  2.020.230.20
   query25  0.150.100.08
   query26  0.240.160.16
   query27  0.080.080.08
   query28  13.31   1.101.08
   query29  13.02   3.403.32
   query30  0.240.070.06
   query31  2.850.370.37
   query32  3.290.460.47
   query33  2.882.842.92
   query34  17.23   4.404.48
   query35  4.494.524.71
   query36  0.650.460.46
   query37  0.180.150.15
   query38  0.160.140.15
   query39  0.050.040.03
   query40  0.160.150.14
   query41  0.090.050.05
   query42  0.060.040.05
   query43  0.040.040.04
   Total cold run time: 110.35 s
   Total hot run time: 30.61 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-28 Thread via GitHub


doris-robot commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2135091885

   
   
   TPC-DS: Total hot run time: 167629 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 20521242d5db4823ad522bea94ac2215a8866e5c, 
data reload: false
   
   query1   933 386 371 371
   query2   6436250422752275
   query3   6646205 209 205
   query4   19860   17105   17236   17105
   query5   4140412 435 412
   query6   262 164 151 151
   query7   4594302 289 289
   query8   238 184 179 179
   query9   8510244924192419
   query10  441 280 260 260
   query11  10650   993899559938
   query12  133 91  86  86
   query13  1636375 377 375
   query14  10042   609382986093
   query15  250 164 160 160
   query16  7972261 267 261
   query17  1736525 516 516
   query18  2083273 265 265
   query19  196 152 161 152
   query20  91  83  88  83
   query21  199 136 136 136
   query22  4218389839783898
   query23  33513   32719   33013   32719
   query24  6634276928932769
   query25  504 358 370 358
   query26  696 155 154 154
   query27  1882321 324 321
   query28  3767210820882088
   query29  839 614 619 614
   query30  227 152 150 150
   query31  940 765 744 744
   query32  82  53  54  53
   query33  506 271 289 271
   query34  861 492 487 487
   query35  700 635 611 611
   query36  1028923 911 911
   query37  104 65  67  65
   query38  2816282527592759
   query39  834 782 807 782
   query40  193 126 126 126
   query41  46  44  44  44
   query42  101 98  98  98
   query43  601 543 546 543
   query44  1070731 753 731
   query45  178 161 159 159
   query46  1045694 705 694
   query47  1887175618171756
   query48  368 309 297 297
   query49  758 377 383 377
   query50  764 395 382 382
   query51  6939663466736634
   query52  109 87  96  87
   query53  349 290 282 282
   query54  563 435 430 430
   query55  72  72  72  72
   query56  266 240 249 240
   query57  1124105410291029
   query58  239 210 207 207
   query59  3396311431393114
   query60  267 271 290 271
   query61  91  85  89  85
   query62  549 441 461 441
   query63  310 278 289 278
   query64  3362173517701735
   query65  3155307531433075
   query66  779 334 317 317
   query67  15240   14614   14776   14614
   query68  4607546 543 543
   query69  445 271 271 271
   query70  11691145
   query71  357 272 264 264
   query72  7395514027522752
   query73  697 326 323 323
   query74  6092556456155564
   query75  3351261126362611
   query76  2215994 972 972
   query77  392 261 260 260
   query78  10372   971697449716
   query79  2577517 518 517
   query80  1089440 438 438
   query81  510 220 220 220
   query82  719 90  94  90
   query83  250 183 168 168
   query84  251 88  87  87
   query85  1327272 280 272
   query86  516 285 290 285
   query87  3421308430773077
   query88  4087243124292429
   query89  470 381 373 373
   query90  2069197 191 191
   query91  125 99  96  96
   query92  62  48  55  48
   query93  2307524 508 508
   query94  1142194 194 194
   query95  408 315 303 303
   query96  596 275 270 270
   query97  3194300630103006
   query98  247 225 216 216
   query99  1197858 851 851
   Total cold run time: 254676 ms
   Total hot run time: 167629 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the 

Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-28 Thread via GitHub


doris-robot commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2135071633

   
   
   TPC-H: Total hot run time: 41750 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 20521242d5db4823ad522bea94ac2215a8866e5c, 
data reload: false
   
   -- Round 1 --
   q1   17596   461442804280
   q2   2020197 195 195
   q3   10455   119111481148
   q4   10197   814 761 761
   q5   7478266327352663
   q6   229 130 129 129
   q7   956 614 591 591
   q8   9214213520972097
   q9   9565669167766691
   q10  9196386139263861
   q11  472 248 241 241
   q12  487 238 241 238
   q13  17450   320132923201
   q14  262 216 208 208
   q15  508 467 468 467
   q16  481 394 398 394
   q17  978 683 756 683
   q18  8347777977717771
   q19  4683154814741474
   q20  620 323 317 317
   q21  5194405640574056
   q22  355 284 289 284
   Total cold run time: 116743 ms
   Total hot run time: 41750 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4512437843884378
   q2   387 266 274 266
   q3   3177300228592859
   q4   1891160415911591
   q5   5445551655025502
   q6   214 127 123 123
   q7   2175177918111779
   q8   3226333733673337
   q9   8558867486208620
   q10  4020370537733705
   q11  588 489 496 489
   q12  790 622 627 622
   q13  17020   312631023102
   q14  303 271 283 271
   q15  516 478 491 478
   q16  499 443 450 443
   q17  1799151514841484
   q18  7787759973497349
   q19  1987154415251525
   q20  1989177917801779
   q21  4922472146784678
   q22  574 498 489 489
   Total cold run time: 72379 ms
   Total hot run time: 54869 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-28 Thread via GitHub


github-actions[bot] commented on code in PR #35239:
URL: https://github.com/apache/doris/pull/35239#discussion_r1617012677


##
be/src/vec/columns/column.h:
##
@@ -22,10 +22,9 @@
 
 #include 

Review Comment:
   warning: 'fmt/format.h' file not found [clang-diagnostic-error]
   ```cpp
   #include 
^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-28 Thread via GitHub


zclllyybb commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2134912524

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-28 Thread via GitHub


zclllyybb commented on code in PR #35239:
URL: https://github.com/apache/doris/pull/35239#discussion_r1617006335


##
be/src/vec/functions/function_ip.h:
##
@@ -137,13 +139,7 @@ static inline bool try_parse_ipv4(const char* pos, Int64& 
result_value) {
 
 template 
 ColumnPtr convert_to_ipv4(ColumnPtr column, const PaddedPODArray* 
null_map = nullptr) {
-const ColumnString* column_string = 
check_and_get_column(column.get());
-
-if (!column_string) {
-throw Exception(ErrorCode::INVALID_ARGUMENT,
-"Illegal column {} of argument of function {}, 
expected String",
-column->get_name());
-}
+const auto* column_string = 
check_and_get_column(column.get());

Review Comment:
   good advise. fixed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-28 Thread via GitHub


zclllyybb commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2134908997

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-28 Thread via GitHub


Mryange commented on code in PR #35239:
URL: https://github.com/apache/doris/pull/35239#discussion_r1616982602


##
be/src/vec/functions/function_ip.h:
##
@@ -137,13 +139,7 @@ static inline bool try_parse_ipv4(const char* pos, Int64& 
result_value) {
 
 template 
 ColumnPtr convert_to_ipv4(ColumnPtr column, const PaddedPODArray* 
null_map = nullptr) {
-const ColumnString* column_string = 
check_and_get_column(column.get());
-
-if (!column_string) {
-throw Exception(ErrorCode::INVALID_ARGUMENT,
-"Illegal column {} of argument of function {}, 
expected String",
-column->get_name());
-}
+const auto* column_string = 
check_and_get_column(column.get());

Review Comment:
   If nullptr is not checked here, then may be using assert cast?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-28 Thread via GitHub


github-actions[bot] commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2134863676

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-24 Thread via GitHub


zclllyybb commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2129081731

   wait https://github.com/apache/doris/pull/35312 merge first


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-22 Thread via GitHub


doris-robot commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2126258902

   
   
   ClickBench: Total hot run time: 31.04 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit fbeebf4b5ed5be3be2a6b7e2a4899ef229c8ea66, 
data reload: false
   
   query1   0.040.040.04
   query2   0.080.040.04
   query3   0.230.050.05
   query4   1.680.090.08
   query5   0.500.490.51
   query6   1.120.720.72
   query7   0.020.010.02
   query8   0.050.050.04
   query9   0.530.500.50
   query10  0.540.550.54
   query11  0.150.110.11
   query12  0.150.120.12
   query13  0.600.590.60
   query14  0.780.770.77
   query15  0.830.800.80
   query16  0.370.370.38
   query17  0.940.970.94
   query18  0.220.250.22
   query19  1.771.651.68
   query20  0.010.020.01
   query21  15.54   0.670.65
   query22  3.857.302.46
   query23  18.29   1.351.29
   query24  1.580.310.22
   query25  0.160.090.08
   query26  0.260.170.16
   query27  0.080.080.08
   query28  13.40   1.010.99
   query29  13.02   3.333.26
   query30  0.240.070.05
   query31  2.870.380.40
   query32  3.270.470.47
   query33  2.892.923.00
   query34  17.02   4.454.40
   query35  4.504.514.48
   query36  0.690.490.49
   query37  0.170.160.15
   query38  0.150.150.16
   query39  0.050.030.04
   query40  0.160.140.13
   query41  0.090.050.04
   query42  0.060.040.04
   query43  0.030.030.04
   Total cold run time: 108.98 s
   Total hot run time: 31.04 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-22 Thread via GitHub


doris-robot commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2126254007

   
   
   TPC-DS: Total hot run time: 168684 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit fbeebf4b5ed5be3be2a6b7e2a4899ef229c8ea66, 
data reload: false
   
   query1   923 394 364 364
   query2   6445243624612436
   query3   6652210 217 210
   query4   19350   17190   17138   17138
   query5   4200413 409 409
   query6   245 154 149 149
   query7   4587295 289 289
   query8   236 184 186 184
   query9   8394234523502345
   query10  444 273 250 250
   query11  10563   10148   10061   10061
   query12  149 93  87  87
   query13  1643397 364 364
   query14  8448696065286528
   query15  210 171 170 170
   query16  7658262 258 258
   query17  1310511 511 511
   query18  1942275 267 267
   query19  199 164 153 153
   query20  96  83  85  83
   query21  193 131 125 125
   query22  4204401538163816
   query23  33814   33146   33032   33032
   query24  7250282527852785
   query25  566 355 371 355
   query26  705 152 158 152
   query27  2172320 326 320
   query28  4493202820372028
   query29  846 614 635 614
   query30  242 169 174 169
   query31  966 758 740 740
   query32  90  52  54  52
   query33  506 274 258 258
   query34  845 475 466 466
   query35  698 603 605 603
   query36  1059943 888 888
   query37  105 71  68  68
   query38  2889279527982795
   query39  823 789 800 789
   query40  193 126 122 122
   query41  47  43  45  43
   query42  104 93  91  91
   query43  575 570 552 552
   query44  1039719 741 719
   query45  185 163 158 158
   query46  1065705 721 705
   query47  1875177417831774
   query48  365 289 300 289
   query49  871 370 376 370
   query50  768 374 385 374
   query51  6896686468756864
   query52  104 93  88  88
   query53  346 276 273 273
   query54  519 426 412 412
   query55  74  71  70  70
   query56  253 244 244 244
   query57  1124103010301030
   query58  233 230 208 208
   query59  3388321332413213
   query60  275 252 257 252
   query61  88  116 88  88
   query62  593 448 466 448
   query63  307 281 280 280
   query64  8441221917051705
   query65  3153310831453108
   query66  806 325 330 325
   query67  15182   14885   14693   14693
   query68  4536526 536 526
   query69  438 265 262 262
   query70  1204106411421064
   query71  353 268 262 262
   query72  6886534227062706
   query73  711 320 321 320
   query74  5948562356085608
   query75  3264260125922592
   query76  23211033992 992
   query77  390 262 261 261
   query78  10275   982297919791
   query79  1759516 518 516
   query80  1103425 443 425
   query81  548 247 244 244
   query82  949 97  97  97
   query83  248 175 169 169
   query84  248 91  87  87
   query85  1076267 256 256
   query86  437 304 290 290
   query87  3279308631783086
   query88  3173232223182318
   query89  477 385 383 383
   query90  2038187 181 181
   query91  123 97  94  94
   query92  59  46  47  46
   query93  2054511 496 496
   query94  1152183 179 179
   query95  398 303 310 303
   query96  602 269 265 265
   query97  3170300330673003
   query98  245 234 218 218
   query99  1129835 848 835
   Total cold run time: 255622 ms
   Total hot run time: 168684 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the 

Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-22 Thread via GitHub


doris-robot commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2126243071

   
   
   ClickBench: Total hot run time: 30.89 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit fbeebf4b5ed5be3be2a6b7e2a4899ef229c8ea66, 
data reload: false
   
   query1   0.030.030.03
   query2   0.090.040.04
   query3   0.220.050.05
   query4   1.670.100.09
   query5   0.500.500.52
   query6   1.130.720.72
   query7   0.020.020.02
   query8   0.060.040.04
   query9   0.540.490.48
   query10  0.540.540.55
   query11  0.150.110.11
   query12  0.140.120.11
   query13  0.590.580.59
   query14  0.820.770.80
   query15  0.840.800.82
   query16  0.370.360.37
   query17  0.991.010.99
   query18  0.200.270.23
   query19  1.871.691.77
   query20  0.010.010.01
   query21  15.44   0.700.67
   query22  4.676.552.20
   query23  18.29   1.421.29
   query24  1.840.210.23
   query25  0.140.100.08
   query26  0.260.160.15
   query27  0.080.080.08
   query28  13.36   1.021.00
   query29  12.85   3.333.31
   query30  0.240.050.07
   query31  2.860.390.39
   query32  3.280.470.47
   query33  2.902.902.90
   query34  17.01   4.454.46
   query35  4.494.464.60
   query36  0.640.450.46
   query37  0.180.150.16
   query38  0.150.150.14
   query39  0.050.030.03
   query40  0.160.150.14
   query41  0.090.050.04
   query42  0.050.040.04
   query43  0.040.030.04
   Total cold run time: 109.85 s
   Total hot run time: 30.89 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-22 Thread via GitHub


doris-robot commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2126243067

   
   
   TPC-H: Total hot run time: 42273 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit fbeebf4b5ed5be3be2a6b7e2a4899ef229c8ea66, 
data reload: false
   
   -- Round 1 --
   q1   17595   462642394239
   q2   2019193 194 193
   q3   10502   128612641264
   q4   10209   880 805 805
   q5   7487283627882788
   q6   220 130 132 130
   q7   962 601 620 601
   q8   9233217921072107
   q9   9129675667206720
   q10  9524387039303870
   q11  448 246 238 238
   q12  457 227 222 222
   q13  18104   320532693205
   q14  252 211 216 211
   q15  498 472 471 471
   q16  500 426 394 394
   q17  981 781 731 731
   q18  8576794778657865
   q19  4615158615631563
   q20  649 329 330 329
   q21  5199410340444044
   q22  358 283 284 283
   Total cold run time: 117517 ms
   Total hot run time: 42273 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4571442443904390
   q2   387 289 269 269
   q3   3181301928152815
   q4   1895157716771577
   q5   5511552755125512
   q6   223 125 126 125
   q7   2156180618441806
   q8   3237339733923392
   q9   8758872986198619
   q10  3943381338513813
   q11  591 520 506 506
   q12  786 635 694 635
   q13  15853   316731633163
   q14  286 270 265 265
   q15  527 473 484 473
   q16  496 432 425 425
   q17  1789149914641464
   q18  7796764874827482
   q19  1658153715841537
   q20  2035179018081790
   q21  8725480046984698
   q22  557 494 482 482
   Total cold run time: 74961 ms
   Total hot run time: 55238 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-22 Thread via GitHub


doris-robot commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2126238462

   
   
   TPC-DS: Total hot run time: 169566 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit fbeebf4b5ed5be3be2a6b7e2a4899ef229c8ea66, 
data reload: false
   
   query1   918 384 378 378
   query2   6444238224592382
   query3   6638206 207 206
   query4   19462   17423   17253   17253
   query5   4097413 423 413
   query6   263 164 147 147
   query7   4578307 293 293
   query8   234 189 178 178
   query9   8515238423462346
   query10  456 277 267 267
   query11  10538   999810040   9998
   query12  141 93  90  90
   query13  1645376 370 370
   query14  8552750175517501
   query15  210 175 176 175
   query16  7888275 277 275
   query17  1695547 555 547
   query18  1994317 275 275
   query19  206 153 152 152
   query20  94  87  84  84
   query21  197 128 128 128
   query22  4302405438913891
   query23  33642   33215   33060   33060
   query24  10457   295228342834
   query25  573 359 356 356
   query26  706 152 154 152
   query27  2187307 318 307
   query28  6013203720522037
   query29  848 617 596 596
   query30  317 174 172 172
   query31  979 758 734 734
   query32  90  51  52  51
   query33  699 271 269 269
   query34  876 483 474 474
   query35  742 598 581 581
   query36  1058897 944 897
   query37  110 71  74  71
   query38  2915279227492749
   query39  880 785 805 785
   query40  197 129 124 124
   query41  50  44  44  44
   query42  102 95  96  95
   query43  629 566 569 566
   query44  1116728 728 728
   query45  184 170 164 164
   query46  1076718 690 690
   query47  1864176017581758
   query48  361 287 297 287
   query49  934 382 378 378
   query50  760 372 391 372
   query51  6863684467186718
   query52  100 92  90  90
   query53  351 292 286 286
   query54  883 428 416 416
   query55  74  72  75  72
   query56  263 251 248 248
   query57  1109102510641025
   query58  233 214 207 207
   query59  3536318631433143
   query60  271 246 256 246
   query61  91  86  91  86
   query62  627 457 446 446
   query63  308 282 290 282
   query64  8522219517821782
   query65  3142308830703070
   query66  799 332 345 332
   query67  15084   14806   14716   14716
   query68  4544533 535 533
   query69  437 269 267 267
   query70  1184116010861086
   query71  382 267 265 265
   query72  7345272125432543
   query73  720 326 323 323
   query74  5975558456015584
   query75  3353262025962596
   query76  2664998 1007998
   query77  402 261 267 261
   query78  10256   10012   98069806
   query79  2177506 510 506
   query80  1021488 422 422
   query81  540 246 242 242
   query82  646 96  90  90
   query83  240 186 184 184
   query84  247 84  82  82
   query85  1792266 255 255
   query86  532 296 301 296
   query87  3308307531273075
   query88  4173235023342334
   query89  491 399 375 375
   query90  2033183 182 182
   query91  173 95  96  95
   query92  64  48  46  46
   query93  2194513 492 492
   query94  1226178 181 178
   query95  402 300 308 300
   query96  592 270 263 263
   query97  3201299230292992
   query98  234 217 217 217
   query99  1206861 833 833
   Total cold run time: 265442 ms
   Total hot run time: 169566 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the 

Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-22 Thread via GitHub


doris-robot commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2126228406

   
   
   TPC-H: Total hot run time: 41004 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit fbeebf4b5ed5be3be2a6b7e2a4899ef229c8ea66, 
data reload: false
   
   -- Round 1 --
   q1   17730   449442634263
   q2   2019183 202 183
   q3   10538   121311391139
   q4   10175   826 714 714
   q5   7527277427532753
   q6   217 129 131 129
   q7   984 607 613 607
   q8   9283219521522152
   q9   9246672467826724
   q10  9083378638793786
   q11  466 234 238 234
   q12  517 227 230 227
   q13  18856   318431893184
   q14  273 231 221 221
   q15  509 464 467 464
   q16  525 399 393 393
   q17  1011757 676 676
   q18  8523799777547754
   q19  2743156115931561
   q20  662 320 330 320
   q21  5203388932443244
   q22  355 276 280 276
   Total cold run time: 116445 ms
   Total hot run time: 41004 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   451942564256
   q2   370 271 274 271
   q3   2997282827122712
   q4   1857157415541554
   q5   5306523652905236
   q6   215 123 126 123
   q7   2151179216721672
   q8   3211336333403340
   q9   8426834984368349
   q10  3908371336213621
   q11  570 502 481 481
   q12  776 613 589 589
   q13  16351   300930143009
   q14  277 270 255 255
   q15  512 472 471 471
   q16  481 417 450 417
   q17  1760147814431443
   q18  7708757874467446
   q19  1672155015121512
   q20  2034176817491749
   q21  7507468947084689
   q22  569 484 469 469
   Total cold run time: 73177 ms
   Total hot run time: 53664 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-22 Thread via GitHub


github-actions[bot] commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2125377812

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-22 Thread via GitHub


zclllyybb commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2125369038

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-22 Thread via GitHub


doris-robot commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2125221546

   
   
   ClickBench: Total hot run time: 29.73 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 8cfddb973b08775c1e50bebe8a202d98c9d4ca0d, 
data reload: false
   
   query1   0.040.040.03
   query2   0.090.040.04
   query3   0.230.050.05
   query4   1.690.070.07
   query5   0.490.500.50
   query6   1.120.710.72
   query7   0.020.010.02
   query8   0.050.040.04
   query9   0.520.480.49
   query10  0.540.540.54
   query11  0.160.110.11
   query12  0.140.120.12
   query13  0.580.590.59
   query14  0.750.780.77
   query15  0.820.820.81
   query16  0.370.370.34
   query17  0.991.010.95
   query18  0.210.250.24
   query19  1.761.711.65
   query20  0.010.010.01
   query21  15.57   0.670.66
   query22  5.007.261.29
   query23  18.29   1.431.26
   query24  1.540.340.20
   query25  0.150.080.08
   query26  0.260.170.17
   query27  0.080.080.08
   query28  13.39   1.010.99
   query29  13.17   3.303.24
   query30  0.240.060.05
   query31  2.860.380.37
   query32  3.300.480.47
   query33  2.882.872.92
   query34  17.26   4.404.44
   query35  4.484.524.49
   query36  0.650.460.47
   query37  0.180.150.15
   query38  0.160.160.15
   query39  0.040.030.04
   query40  0.160.150.14
   query41  0.090.050.05
   query42  0.060.040.05
   query43  0.040.030.04
   Total cold run time: 110.43 s
   Total hot run time: 29.73 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-22 Thread via GitHub


doris-robot commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2125202176

   
   
   TPC-DS: Total hot run time: 170244 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 8cfddb973b08775c1e50bebe8a202d98c9d4ca0d, 
data reload: false
   
   query1   934 378 375 375
   query2   6461244823422342
   query3   6676219 214 214
   query4   19680   17300   17478   17300
   query5   4159420 421 420
   query6   236 153 152 152
   query7   4594296 299 296
   query8   237 183 178 178
   query9   8604237023482348
   query10  453 271 267 267
   query11  10712   10064   10117   10064
   query12  132 89  87  87
   query13  1637371 371 371
   query14  10344   762976097609
   query15  233 170 176 170
   query16  7940285 274 274
   query17  1830544 547 544
   query18  2031282 277 277
   query19  217 201 163 163
   query20  93  85  83  83
   query21  196 130 125 125
   query22  4301397339203920
   query23  33575   32970   32962   32962
   query24  12069   282128522821
   query25  658 348 369 348
   query26  1744160 164 160
   query27  2913325 321 321
   query28  7625203820442038
   query29  1025618 607 607
   query30  308 174 168 168
   query31  1018784 766 766
   query32  86  55  54  54
   query33  757 270 261 261
   query34  988 480 471 471
   query35  773 615 590 590
   query36  1075904 891 891
   query37  157 71  70  70
   query38  2915277427752774
   query39  838 786 800 786
   query40  271 125 127 125
   query41  47  44  44  44
   query42  106 98  97  97
   query43  583 552 554 552
   query44  1220729 769 729
   query45  186 161 166 161
   query46  1067726 703 703
   query47  1872175617781756
   query48  376 293 298 293
   query49  1188395 381 381
   query50  763 386 393 386
   query51  6819685368626853
   query52  99  90  91  90
   query53  360 284 287 284
   query54  1002452 425 425
   query55  73  76  74  74
   query56  263 247 241 241
   query57  1130102310311023
   query58  241 220 208 208
   query59  3394335431793179
   query60  284 261 302 261
   query61  90  86  87  86
   query62  675 456 476 456
   query63  312 294 288 288
   query64  9804223117821782
   query65  3146306530743065
   query66  1395326 322 322
   query67  15230   14845   14769   14769
   query68  5760532 551 532
   query69  490 273 276 273
   query70  1196112811141114
   query71  452 268 266 266
   query72  7968557027292729
   query73  761 325 322 322
   query74  6024571955765576
   query75  3802263626472636
   query76  34941018913 913
   query77  623 271 268 268
   query78  10219   10049   97549754
   query79  3369545 511 511
   query80  2099442 474 442
   query81  529 239 254 239
   query82  1491104 99  99
   query83  340 175 177 175
   query84  263 85  86  85
   query85  1576276 266 266
   query86  485 296 317 296
   query87  3290314430853085
   query88  4123235623392339
   query89  504 386 378 378
   query90  2000188 185 185
   query91  129 96  101 96
   query92  64  47  51  47
   query93  4496517 496 496
   query94  1218205 185 185
   query95  400 314 304 304
   query96  591 277 267 267
   query97  3243302030783020
   query98  241 229 222 222
   query99  1223824 858 824
   Total cold run time: 284683 ms
   Total hot run time: 170244 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the 

Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-22 Thread via GitHub


doris-robot commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2125171657

   
   
   TPC-H: Total hot run time: 39830 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 8cfddb973b08775c1e50bebe8a202d98c9d4ca0d, 
data reload: false
   
   -- Round 1 --
   q1   17998   434243294329
   q2   2617202 195 195
   q3   11069   116211421142
   q4   10463   757 804 757
   q5   7496265927022659
   q6   224 137 139 137
   q7   965 605 604 604
   q8   9296210220762076
   q9   8694644164666441
   q10  8782370436763676
   q11  463 239 233 233
   q12  471 231 220 220
   q13  17759   296629942966
   q14  254 218 218 218
   q15  507 479 466 466
   q16  490 377 378 377
   q17  958 684 732 684
   q18  8032754274417441
   q19  6084152814771477
   q20  668 306 322 306
   q21  4983315231963152
   q22  342 274 280 274
   Total cold run time: 118615 ms
   Total hot run time: 39830 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4329419642104196
   q2   364 266 260 260
   q3   2924279327132713
   q4   1832156615671566
   q5   5236523252255225
   q6   211 125 126 125
   q7   2076168017021680
   q8   3189329232853285
   q9   8281823983118239
   q10  3849366736283628
   q11  588 507 487 487
   q12  794 603 598 598
   q13  17436   296629822966
   q14  287 257 276 257
   q15  510 471 478 471
   q16  472 409 411 409
   q17  1778146614681466
   q18  7613764676647646
   q19  1646156215361536
   q20  1962176017641760
   q21  4921477846974697
   q22  576 503 488 488
   Total cold run time: 70874 ms
   Total hot run time: 53698 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-22 Thread via GitHub


github-actions[bot] commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2125143788

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-22 Thread via GitHub


zclllyybb commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2125133367

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-22 Thread via GitHub


doris-robot commented on PR #35239:
URL: https://github.com/apache/doris/pull/35239#issuecomment-2125133289

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [refactor](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]

2024-05-22 Thread via GitHub


zclllyybb opened a new pull request, #35239:
URL: https://github.com/apache/doris/pull/35239

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org