[GitHub] [druid] clintropolis commented on a change in pull request #9611: Use primitives instead of boxed variables when possible
clintropolis commented on a change in pull request #9611: Use primitives
instead of boxed variables when possible
URL: https://github.com/apache/druid/pull/9611#discussion_r403434803
##
File path: core/src/main/java/org/apache/druid/math/expr/Function.java
##
@@ -1910,16 +1910,10 @@ public String name()
@Override
public ExprEval apply(List args, Expr.ObjectBinding bindings)
{
- Long left = args.get(0).eval(bindings).asLong();
- Long right = args.get(1).eval(bindings).asLong();
+ long left = args.get(0).eval(bindings).asLong();
Review comment:
Hmm, I actually think this should probably be checking if either result
`isNumericNull` and returning a null result before calling `asLong`. Looking
around there are ... other places in the functions that have this issue as
well, so I don't think you need to fix here since that is a whole other can of
worms.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #9611: Use primitives instead of boxed variables when possible
clintropolis commented on a change in pull request #9611: Use primitives
instead of boxed variables when possible
URL: https://github.com/apache/druid/pull/9611#discussion_r403434803
##
File path: core/src/main/java/org/apache/druid/math/expr/Function.java
##
@@ -1910,16 +1910,10 @@ public String name()
@Override
public ExprEval apply(List args, Expr.ObjectBinding bindings)
{
- Long left = args.get(0).eval(bindings).asLong();
- Long right = args.get(1).eval(bindings).asLong();
+ long left = args.get(0).eval(bindings).asLong();
Review comment:
Hmm, I actually think this should probably be checking if either result
`isNumericNull` and returning a null result before calling `asLong`. Looking
around there are ... other places in the functions that have this issue as
well, so I don't think you need to fix here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #9610: Fix NPE in RemoteTaskRunner event handler causes JVM shutdown
clintropolis commented on a change in pull request #9610: Fix NPE in RemoteTaskRunner event handler causes JVM shutdown URL: https://github.com/apache/druid/pull/9610#discussion_r403433127 ## File path: extensions-contrib/ambari-metrics-emitter/pom.xml ## @@ -48,6 +48,18 @@ test-jar test + Review comment: what is this change about, was this relying on curator providing it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #9610: Fix NPE in RemoteTaskRunner event handler causes JVM shutdown
clintropolis commented on a change in pull request #9610: Fix NPE in
RemoteTaskRunner event handler causes JVM shutdown
URL: https://github.com/apache/druid/pull/9610#discussion_r403433584
##
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/RemoteTaskRunner.java
##
@@ -1081,6 +979,117 @@ private boolean cancelWorkerCleanup(String workerHost)
}
}
+ @VisibleForTesting
+ PathChildrenCacheListener getStatusListener(final Worker worker, final
ZkWorker zkWorker, final SettableFuture retVal)
+ {
+return (client, event) -> {
+ final String taskId;
+ final RemoteTaskRunnerWorkItem taskRunnerWorkItem;
+ synchronized (statusLock) {
+try {
+ switch (event.getType()) { // lgtm
[java/dereferenced-value-may-be-null]
+case CHILD_ADDED:
+case CHILD_UPDATED:
+ taskId = ZKPaths.getNodeFromPath(event.getData().getPath()); //
lgtm [java/dereferenced-value-may-be-null]
Review comment:
Per the PR description/linked javadocs, can this and other usages of
`event.getData()` in this switch statement be null? I guess we are relying on
an NPE happening and then the catch checking and handling there? It might be
nicer to explicitly check and throw a more useful error about the `ChildData`
for the event unexpectedly being null so that the alerted exception is more
useful
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[druid] branch 0.18.0 updated: Fix for [CVE-2020-1958]: Apache Druid LDAP injection vulnerability (#9600) (#9612)
This is an automated email from the ASF dual-hosted git repository.
cwylie pushed a commit to branch 0.18.0
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/0.18.0 by this push:
new 13b2e80 Fix for [CVE-2020-1958]: Apache Druid LDAP injection
vulnerability (#9600) (#9612)
13b2e80 is described below
commit 13b2e802489d7a48ff4b77be6633e64aebb7c3e4
Author: Jonathan Wei
AuthorDate: Fri Apr 3 23:31:06 2020 -0700
Fix for [CVE-2020-1958]: Apache Druid LDAP injection vulnerability (#9600)
(#9612)
---
LICENSE| 7
.../validator/LDAPCredentialsValidator.java| 47 +-
.../validator/LDAPCredentialsValidatorTest.java| 47 ++
licenses.yaml | 11 +
licenses/src/esapi.BSD3| 11 +
5 files changed, 122 insertions(+), 1 deletion(-)
diff --git a/LICENSE b/LICENSE
index c747d40..820819d 100644
--- a/LICENSE
+++ b/LICENSE
@@ -307,6 +307,13 @@ SOURCE/JAVA-CORE
which is available under a BSD-3-Clause License. For details, see
licenses/src/porter-stemmer.BSD3.
*
processing/src/test/java/org/apache/druid/query/extraction/JavaScriptExtractionFnTest.java
+SOURCE/EXTENSIONS/druid-basic-security
+This product contains an LDAP string encoding function from OWASP ESAPI,
copyright The OWASP Foundation
+ (https://github.com/ESAPI/esapi-java-legacy) which is available under the
BSD-3-Clause License. For details, see
+ licenses/src/esapi.BSD3.
+ *
extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication/validator/LDAPCredentialsValidator.java
+
+
Public Domain
diff --git
a/extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication/validator/LDAPCredentialsValidator.java
b/extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication/validator/LDAPCredentialsValidator.java
index 9f75d37..7a9bc0c 100644
---
a/extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication/validator/LDAPCredentialsValidator.java
+++
b/extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication/validator/LDAPCredentialsValidator.java
@@ -189,9 +189,10 @@ public class LDAPCredentialsValidator implements
CredentialsValidator
SearchControls sc = new SearchControls();
sc.setSearchScope(SearchControls.SUBTREE_SCOPE);
sc.setReturningAttributes(new String[] {ldapConfig.getUserAttribute(),
"memberOf" });
+ String encodedUsername = encodeForLDAP(username, true);
NamingEnumeration results = context.search(
ldapConfig.getBaseDn(),
- StringUtils.format(ldapConfig.getUserSearch(), username),
+ StringUtils.format(ldapConfig.getUserSearch(), encodedUsername),
sc);
try {
if (!results.hasMore()) {
@@ -293,4 +294,48 @@ public class LDAPCredentialsValidator implements
CredentialsValidator
}
}
}
+
+ /**
+ * This code is adapted from DefaultEncoder from version 2.2.0.0 of ESAPI
(https://github.com/ESAPI/esapi-java-legacy)
+ */
+ public static String encodeForLDAP(String input, boolean encodeWildcards)
+ {
+if (input == null) {
+ return null;
+}
+StringBuilder sb = new StringBuilder();
+for (int i = 0; i < input.length(); i++) {
+ char c = input.charAt(i);
+
+ switch (c) {
+case '\\':
+ sb.append("\\5c");
+ break;
+case '/':
+ sb.append(("\\2f"));
+ break;
+case '*':
+ if (encodeWildcards) {
+sb.append("\\2a");
+ } else {
+sb.append(c);
+ }
+
+ break;
+case '(':
+ sb.append("\\28");
+ break;
+case ')':
+ sb.append("\\29");
+ break;
+case '\0':
+ sb.append("\\00");
+ break;
+default:
+ sb.append(c);
+ }
+}
+return sb.toString();
+ }
+
}
diff --git
a/extensions-core/druid-basic-security/src/test/java/org/apache/druid/security/authentication/validator/LDAPCredentialsValidatorTest.java
b/extensions-core/druid-basic-security/src/test/java/org/apache/druid/security/authentication/validator/LDAPCredentialsValidatorTest.java
new file mode 100644
index 000..56aee16
--- /dev/null
+++
b/extensions-core/druid-basic-security/src/test/java/org/apache/druid/security/authentication/validator/LDAPCredentialsValidatorTest.java
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Ap
[GitHub] [druid] clintropolis merged pull request #9612: [Backport] Fix for [CVE-2020-1958]: Apache Druid LDAP injection vulnerability (#9600)
clintropolis merged pull request #9612: [Backport] Fix for [CVE-2020-1958]: Apache Druid LDAP injection vulnerability (#9600) URL: https://github.com/apache/druid/pull/9612 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #9594: Fix double count ssl connection metrics
clintropolis merged pull request #9594: Fix double count ssl connection metrics URL: https://github.com/apache/druid/pull/9594 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] clintropolis opened a new pull request #9615: [Backport] Fix double count ssl connection metrics
clintropolis opened a new pull request #9615: [Backport] Fix double count ssl connection metrics URL: https://github.com/apache/druid/pull/9615 Backport of #9594 to 0.18.0. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[druid] branch master updated: Fix double count ssl connection metrics (#9594)
This is an automated email from the ASF dual-hosted git repository.
cwylie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 4d277db Fix double count ssl connection metrics (#9594)
4d277db is described below
commit 4d277dbf9901a592789fbcc6b1dff1ebebb5e00e
Author: Clint Wylie
AuthorDate: Fri Apr 3 23:29:23 2020 -0700
Fix double count ssl connection metrics (#9594)
* fix double counted jetty/numOpenConnections metric for ssl connections
* tests
* more better
* style
---
examples/bin/dsql-main | 2 +-
.../docker/tls/generate-good-client-cert.sh| 2 +-
.../tls/generate-server-certs-and-keystores.sh | 2 +-
.../initialization/jetty/JettyServerModule.java| 15 +-
.../druid/server/initialization/BaseJettyTest.java | 70 +++
.../druid/server/initialization/JettyTest.java | 211 -
server/src/test/resources/server.jks | Bin 0 -> 1911 bytes
server/src/test/resources/truststore.jks | Bin 0 -> 1641 bytes
8 files changed, 293 insertions(+), 9 deletions(-)
diff --git a/examples/bin/dsql-main b/examples/bin/dsql-main
index 8dfe882..cf68581 100755
--- a/examples/bin/dsql-main
+++ b/examples/bin/dsql-main
@@ -400,7 +400,7 @@ def main():
parser_fmt.add_argument('--format', type=str, default='table',
choices=('csv', 'tsv', 'json', 'table'), help='Result format')
parser_fmt.add_argument('--header', action='store_true', help='Include
header row for formats "csv" and "tsv"')
parser_fmt.add_argument('--tsv-delimiter', type=str, default='\t',
help='Delimiter for format "tsv"')
- parser_oth.add_argument('--context-option', '-c', type=str, action='append',
help='Set context option for this connection, see
https://docs.imply.io/on-prem/query-data/sql for options')
+ parser_oth.add_argument('--context-option', '-c', type=str, action='append',
help='Set context option for this connection, see
https://druid.apache.org/docs/latest/querying/sql.html#connection-context for
options')
parser_oth.add_argument('--execute', '-e', type=str, help='Execute single
SQL query')
args = parser.parse_args()
diff --git a/integration-tests/docker/tls/generate-good-client-cert.sh
b/integration-tests/docker/tls/generate-good-client-cert.sh
index 895e6c3..0f16c14 100755
--- a/integration-tests/docker/tls/generate-good-client-cert.sh
+++ b/integration-tests/docker/tls/generate-good-client-cert.sh
@@ -58,5 +58,5 @@ openssl x509 -req -days 3650 -in client.csr -CA root.pem
-CAkey root.key -set_se
openssl pkcs12 -export -in client.pem -inkey client.key -out client.p12 -name
druid -CAfile root.pem -caname druid-it-root -password pass:druid123
keytool -importkeystore -srckeystore client.p12 -srcstoretype PKCS12
-destkeystore client.jks -deststoretype JKS -srcstorepass druid123
-deststorepass druid123
-# Create a Java truststore with the imply test cluster root CA
+# Create a Java truststore with the druid test cluster root CA
keytool -import -alias druid-it-root -keystore truststore.jks -file root.pem
-storepass druid123 -noprompt
diff --git
a/integration-tests/docker/tls/generate-server-certs-and-keystores.sh
b/integration-tests/docker/tls/generate-server-certs-and-keystores.sh
index 6c40a07..28bf09a 100755
--- a/integration-tests/docker/tls/generate-server-certs-and-keystores.sh
+++ b/integration-tests/docker/tls/generate-server-certs-and-keystores.sh
@@ -69,7 +69,7 @@ openssl x509 -req -days 3650 -in server.csr -CA root.pem
-CAkey root.key -set_se
openssl pkcs12 -export -in server.pem -inkey server.key -out server.p12 -name
druid -CAfile root.pem -caname druid-it-root -password pass:druid123
keytool -importkeystore -srckeystore server.p12 -srcstoretype PKCS12
-destkeystore server.jks -deststoretype JKS -srcstorepass druid123
-deststorepass druid123
-# Create a Java truststore with the imply test cluster root CA
+# Create a Java truststore with the druid test cluster root CA
keytool -import -alias druid-it-root -keystore truststore.jks -file root.pem
-storepass druid123 -noprompt
# Revoke one of the client certs
diff --git
a/server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java
b/server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java
index bbb80e4..fc6f93e 100644
---
a/server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java
+++
b/server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java
@@ -22,6 +22,7 @@ package org.apache.druid.server.initialization.jetty;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.jaxrs.json.JacksonJsonProvider;
import com.fasterxml.jackson.jaxrs.smile.JacksonSmileProvider;
+import com.google.common.annotations.VisibleForTesting;
import com.go
[GitHub] [druid] clintropolis commented on issue #9594: Fix double count ssl connection metrics
clintropolis commented on issue #9594: Fix double count ssl connection metrics URL: https://github.com/apache/druid/pull/9594#issuecomment-608983102 Thanks for review @jihoonson! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] lgtm-com[bot] commented on issue #9610: Fix NPE in RemoteTaskRunner event handler causes JVM shutdown
lgtm-com[bot] commented on issue #9610: Fix NPE in RemoteTaskRunner event handler causes JVM shutdown URL: https://github.com/apache/druid/pull/9610#issuecomment-608974968 This pull request **introduces 1 alert** when merging 258bfe476f5377789faec9bbf6ab9e1869110f99 into b5419962f0995daf0d4361a137f5f6c123fd9aa0 - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-f1d002928db975e030e78d0311f31d65f952e8ae) **new alerts:** * 1 for Dereferenced variable may be null This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] lgtm-com[bot] commented on issue #9610: Fix NPE in RemoteTaskRunner event handler causes JVM shutdown
lgtm-com[bot] commented on issue #9610: Fix NPE in RemoteTaskRunner event handler causes JVM shutdown URL: https://github.com/apache/druid/pull/9610#issuecomment-608961801 This pull request **introduces 1 alert** when merging 868176850bab929a43a7e1f3a8de4c48047afda4 into b5419962f0995daf0d4361a137f5f6c123fd9aa0 - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-587335d2ba7e7d77c40221de2683a7c35983086c) **new alerts:** * 1 for Dereferenced variable may be null This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[druid-website-src] branch add--committers updated (dcc1952 -> a594f60)
This is an automated email from the ASF dual-hosted git repository. surekha pushed a change to branch add--committers in repository https://gitbox.apache.org/repos/asf/druid-website-src.git. from dcc1952 add new committers add a594f60 fix github link No new revisions were added by this update. Summary of changes: community/index.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid-website-src] surekhasaharan opened a new pull request #119: update community page
surekhasaharan opened a new pull request #119: update community page URL: https://github.com/apache/druid-website-src/pull/119 added newest committers This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[druid-website-src] 01/01: add new committers
This is an automated email from the ASF dual-hosted git repository. surekha pushed a commit to branch add--committers in repository https://gitbox.apache.org/repos/asf/druid-website-src.git commit dcc1952317526ba9b27fe011ba37388b1ce37a79 Author: Surekha Saharan AuthorDate: Fri Apr 3 17:36:54 2020 -0700 add new committers --- community/index.md | 73 -- 1 file changed, 38 insertions(+), 35 deletions(-) diff --git a/community/index.md b/community/index.md index 36df248..802ec4e 100644 --- a/community/index.md +++ b/community/index.md @@ -87,41 +87,44 @@ by others. You don't need to be a committer to contribute- pull requests are welcome from anyone. -| Name | Organization | -| - | -- | -| [Benedict Jin](https://github.com/asdf2014) | [Alibaba](https://www.alibaba.com/)| -| [Charles Allen](https://github.com/drcrallen) | [Snap](https://www.snap.com/en-US/)| -| [Clint Wylie](https://github.com/clintropolis)| [Imply](https://imply.io/) | -| [David Lim](https://github.com/dclim) | [Imply](https://imply.io/) | -| [Daoyue Gao](https://github.com/gaodayue) | [Meituan](http://www.meituan.com/) | -| [Dylan Wylie](https://github.com/Dylan1312) | [SpotX](https://www.spotx.tv/) | -| [Egor Rashin](https://github.com/egor-ryashin)| [Snap](https://www.snap.com/en-US/)| -| [Eric Tschetter](https://github.com/cheddar) | [Splunk](https://www.splunk.com/) | -| [Fangjin Yang](https://github.com/fjy)| [Imply](https://imply.io/) | -| [Fokko Driesprong](https://github.com/Fokko) | [GoDataDriven](https://godatadriven.com/) | -| [Furkan Kamaci](https://github.com/kamaci)| [Lagom](https://lagom.ai/) | -| [Gian Merlino](https://github.com/gianm) | [Imply](https://imply.io/) | -| [Himanshu Gupta](https://github.com/himanshug)| [Splunk](https://www.splunk.com/) | -| [Jihoon Son](https://github.com/jihoonson)| [Imply](https://imply.io/) | -| [Jonathan Wei](https://github.com/jon-wei)| [Imply](https://imply.io/) | -| [Julian Hyde](https://github.com/julianhyde) | [Looker](https://looker.com/) | -| [Jun Rao](https://github.com/junrao) | [Confluent](https://www.confluent.io/) | -| [Kaijian Ding](https://github.com/kaijianding)| [Alibaba](https://www.alibaba.com/)| -| [Kurt Young](https://github.com/kurtyoung)| [Alibaba](https://www.alibaba.com/)| -| [Lijin Bin](https://github.com/binlijin) | [Alibaba](https://www.alibaba.com/)| -| [Maxime Beauchemin](https://github.com/mistercrunch) | [Lyft](http://lyft.com/) | -| [Mingming Qiu](https://github.com/QiuMM) | [Bytedance](https://bytedance.com/)| -| [Mohamed Slim Bouguerra](https://github.com/b-slim) | [Hortonworks](https://hortonworks.com/)| -| [Navis Ryu](https://github.com/navis) | [SK Telecom](https://www.sktelecom.com/index.html) | -| [Niketh Sabbineni](https://github.com/niketh) | [Oath](https://www.oath.com/) | -| [Nishant Bangarwa](https://github.com/nishantmonu51) | [Hortonworks](https://hortonworks.com/)| -| [Parag Jain](https://github.com/pjain1) | [Lyft](http://lyft.com/) | -| [P. Taylor Goetz](https://github.com/ptgoetz) | [EPAM](https://www.epam.com/) | -| [Roman Leventov](https://github.com/leventov) | [Snap](https://www.snap.com/en-US/)| -| [Surekha Saharan](https://github.com/surekhasaharan) | [Imply](https://imply.io/) | -| [Vadim Ogievetsky](https://github.com/vogievetsky)| [Imply](https://imply.io/) | -| [Xavier Léauté](https://github.com/xvrl) | [Confluent](https://www.confluent.io/) | -| [Xinyu Zhang](https://github.com/zhangxinyu1) | [Qihoo 360](https://www.360.cn/) | +| Name | Organization | +| - | -- | +| [Alexander Saydakov](https://github.com/AlexanderSaydakov)| [Oath](https://www.oat
[druid-website-src] branch add--committers created (now dcc1952)
This is an automated email from the ASF dual-hosted git repository. surekha pushed a change to branch add--committers in repository https://gitbox.apache.org/repos/asf/druid-website-src.git. at dcc1952 add new committers This branch includes the following new commits: new dcc1952 add new committers The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] lgtm-com[bot] commented on issue #9610: Fix NPE in RemoteTaskRunner event handler causes JVM shutdown
lgtm-com[bot] commented on issue #9610: Fix NPE in RemoteTaskRunner event handler causes JVM shutdown URL: https://github.com/apache/druid/pull/9610#issuecomment-608705195 This pull request **introduces 2 alerts** when merging 51106421b12a43b7f27bc2db0c033997378c85cc into b5419962f0995daf0d4361a137f5f6c123fd9aa0 - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-2b70c51039cd2e7e1381182bec789e36b8b8c975) **new alerts:** * 2 for Dereferenced variable may be null This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[druid-website-src] branch master updated (f81a5d4 -> e162e18)
This is an automated email from the ASF dual-hosted git repository. fjy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid-website-src.git. from f81a5d4 Merge pull request #116 from apache/0.17.1-docs add f0641ee Add to featured content new e162e18 Merge pull request #118 from apache/add-featured-content The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: _data/featured.yml | 12 1 file changed, 12 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid-website-src] fjy merged pull request #118: update featured content
fjy merged pull request #118: update featured content URL: https://github.com/apache/druid-website-src/pull/118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[druid-website-src] 01/01: Merge pull request #118 from apache/add-featured-content
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid-website-src.git commit e162e18e6831a6c82e4d80004ca446451c387bd6 Merge: f81a5d4 f0641ee Author: Fangjin Yang AuthorDate: Fri Apr 3 14:44:45 2020 -0700 Merge pull request #118 from apache/add-featured-content update featured content _data/featured.yml | 12 1 file changed, 12 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[druid] branch 0.18.0 updated: Suppress CVEs for jackson-mapper-asl:1.9.13 (#9604) (#9613)
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch 0.18.0 in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/0.18.0 by this push: new 7f2bce4 Suppress CVEs for jackson-mapper-asl:1.9.13 (#9604) (#9613) 7f2bce4 is described below commit 7f2bce416ea7cd08ed7dcfb26e6c206deaf1147e Author: Chi Cao Minh AuthorDate: Fri Apr 3 14:42:44 2020 -0700 Suppress CVEs for jackson-mapper-asl:1.9.13 (#9604) (#9613) The jackson-mapper-asl:1.9.13 CVEs via curator-x-discovery are all suppressed for now as fixing them requires updating the curator version. --- owasp-dependency-check-suppressions.xml | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/owasp-dependency-check-suppressions.xml b/owasp-dependency-check-suppressions.xml index ebeb371..a6433a1 100644 --- a/owasp-dependency-check-suppressions.xml +++ b/owasp-dependency-check-suppressions.xml @@ -122,17 +122,8 @@ -^pkg:maven/org\.codehaus\.jackson/jackson\-mapper\-asl@.*$ -CVE-2017-7525 -CVE-2017-15095 -CVE-2017-17485 -CVE-2018-5968 -CVE-2018-7489 -CVE-2018-14718 -CVE-2019-10172 -CVE-2019-14540 -CVE-2019-16335 -CVE-2019-17267 +^pkg:maven/org\.codehaus\.jackson/jackson\-mapper\-asl@1.9.13$ +10 - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #9613: [Backport] Suppress CVEs for jackson-mapper-asl:1.9.13 (#9604)
jihoonson merged pull request #9613: [Backport] Suppress CVEs for jackson-mapper-asl:1.9.13 (#9604) URL: https://github.com/apache/druid/pull/9613 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid-website-src] surekhasaharan opened a new pull request #118: update featured content
surekhasaharan opened a new pull request #118: update featured content URL: https://github.com/apache/druid-website-src/pull/118 add to featured content This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[druid-website-src] 01/01: Add to featured content
This is an automated email from the ASF dual-hosted git repository. surekha pushed a commit to branch add-featured-content in repository https://gitbox.apache.org/repos/asf/druid-website-src.git commit f0641ee38f723e0c6ee3afb36564e00a986abb61 Author: Surekha Saharan AuthorDate: Fri Apr 3 13:59:15 2020 -0700 Add to featured content --- _data/featured.yml | 12 1 file changed, 12 insertions(+) diff --git a/_data/featured.yml b/_data/featured.yml index b3151da..ff2f52d 100644 --- a/_data/featured.yml +++ b/_data/featured.yml @@ -1,3 +1,15 @@ + - date: 2020-03-03 +title: "How Netflix uses Druid for Real-time Insights to Ensure a High-Quality Experience" +name: "Ben Sykes" +link: https://netflixtechblog.com/how-netflix-uses-druid-for-real-time-insights-to-ensure-a-high-quality-experience-19e1e8568d06 +company: Netflix + + - date: 2020-01-30 +title: "Introducing Druid 0.17.0" +name: "Gian Merlino" +link: https://imply.io/post/announcing-druid-0.17.0 +company: Imply + - date: 2019-12-10 title: "Druid: Reflections at a Milestone" name: "Gian Merlino" - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] ccaominh commented on a change in pull request #9614: Add tests for valid and invalid datasource names
ccaominh commented on a change in pull request #9614: Add tests for valid and
invalid datasource names
URL: https://github.com/apache/druid/pull/9614#discussion_r403344786
##
File path:
server/src/test/java/org/apache/druid/segment/indexing/DataSchemaTest.java
##
@@ -54,10 +56,20 @@
import java.nio.charset.StandardCharsets;
import java.util.Arrays;
import java.util.Collections;
+import java.util.List;
import java.util.Map;
public class DataSchemaTest
{
+
+ private static final String VALID_DATASOURCE_CHARS_NAME =
"alpha123..*~!@#&%^&*()-+ Россия\\ 한국 中国!";
+ private static final String VALID_DATASOURCE_CHARS_FOR_SERIALIZER =
"alpha123..*~!@#&%^&*()-+ Россия 한국 中国!";
Review comment:
Suggest adding a helper method that escapes `VALID_DATASOURCE_CHARS_NAME`.
The helper method can be used here as well as in
`testSerializeWithInvalidDataSourceName()`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] ccaominh commented on a change in pull request #9614: Add tests for valid and invalid datasource names
ccaominh commented on a change in pull request #9614: Add tests for valid and
invalid datasource names
URL: https://github.com/apache/druid/pull/9614#discussion_r403344175
##
File path:
server/src/test/java/org/apache/druid/segment/indexing/DataSchemaTest.java
##
@@ -54,10 +56,20 @@
import java.nio.charset.StandardCharsets;
import java.util.Arrays;
import java.util.Collections;
+import java.util.List;
import java.util.Map;
public class DataSchemaTest
{
+
+ private static final String VALID_DATASOURCE_CHARS_NAME =
"alpha123..*~!@#&%^&*()-+ Россия\\ 한국 中国!";
+ private static final String VALID_DATASOURCE_CHARS_FOR_SERIALIZER =
"alpha123..*~!@#&%^&*()-+ Россия 한국 中国!";
+
+ static {
+// testTransformSpec needs NullHandling initialized.
+NullHandling.initializeForTests();
+ }
Review comment:
The test class can extend `NullHandlingTest` instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[druid-website-src] branch add-featured-content created (now f0641ee)
This is an automated email from the ASF dual-hosted git repository. surekha pushed a change to branch add-featured-content in repository https://gitbox.apache.org/repos/asf/druid-website-src.git. at f0641ee Add to featured content This branch includes the following new commits: new f0641ee Add to featured content The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] suneet-s opened a new pull request #9614: Add tests for valid and invalid datasource names
suneet-s opened a new pull request #9614: Add tests for valid and invalid datasource names URL: https://github.com/apache/druid/pull/9614 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] ccaominh commented on issue #9613: [Backport] Suppress CVEs for jackson-mapper-asl:1.9.13 (#9604)
ccaominh commented on issue #9613: [Backport] Suppress CVEs for jackson-mapper-asl:1.9.13 (#9604) URL: https://github.com/apache/druid/pull/9613#issuecomment-608668541 Clean backport This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] stale[bot] closed issue #7736: Druid keep using segment from the segment-cache the one not exists on deep storage anymore
stale[bot] closed issue #7736: Druid keep using segment from the segment-cache the one not exists on deep storage anymore URL: https://github.com/apache/druid/issues/7736 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] stale[bot] commented on issue #7736: Druid keep using segment from the segment-cache the one not exists on deep storage anymore
stale[bot] commented on issue #7736: Druid keep using segment from the segment-cache the one not exists on deep storage anymore URL: https://github.com/apache/druid/issues/7736#issuecomment-608668646 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] maytasm commented on issue #9610: Fix NPE in RemoteTaskRunner event handler causes JVM shutdown
maytasm commented on issue #9610: Fix NPE in RemoteTaskRunner event handler causes JVM shutdown URL: https://github.com/apache/druid/pull/9610#issuecomment-608645153 > PR description says curator 4.3.0, but changes upgraded to 4.2.0? Good catch. It is suppose to be 4.3.0. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)
jihoonson merged pull request #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590) URL: https://github.com/apache/druid/pull/9606 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[druid] branch 0.18.0 updated (3429e1d -> 52d79f5)
This is an automated email from the ASF dual-hosted git repository.
jihoonson pushed a change to branch 0.18.0
in repository https://gitbox.apache.org/repos/asf/druid.git.
from 3429e1d Allow Cloud Deep Storage configs without segment bucket or
path specified (#9588) (#9601)
add 52d79f5 [0.18.0] DruidInputSource can add new dimensions during
re-ingestion (#9590) (#9606)
No new revisions were added by this update.
Summary of changes:
examples/quickstart/tutorial/transform-index.json | 2 +-
.../indexing/common/ReingestionTimelineUtils.java | 32 ++
.../firehose/IngestSegmentFirehoseFactory.java | 17 +---
.../druid/indexing/input/DruidInputSource.java | 16 +--
.../{ITIndexerTest.java => ITTransformTest.java} | 82
...=> wikipedia_index_queries_with_transform.json} | 35 +++
...edia_index_task_with_inputsource_transform.json | 103
...on => wikipedia_index_task_with_transform.json} | 20 +++-
...ex_druid_input_source_task_with_transforms.json | 106
...wikipedia_reindex_queries_with_transforms.json} | 26 +++--
.../wikipedia_reindex_task_with_transforms.json| 108 +
11 files changed, 454 insertions(+), 93 deletions(-)
copy
integration-tests/src/test/java/org/apache/druid/tests/indexer/{ITIndexerTest.java
=> ITTransformTest.java} (54%)
copy
integration-tests/src/test/resources/indexer/{wikipedia_parallel_index_queries.json
=> wikipedia_index_queries_with_transform.json} (69%)
create mode 100644
integration-tests/src/test/resources/indexer/wikipedia_index_task_with_inputsource_transform.json
copy integration-tests/src/test/resources/indexer/{wikipedia_index_task.json
=> wikipedia_index_task_with_transform.json} (80%)
create mode 100644
integration-tests/src/test/resources/indexer/wikipedia_reindex_druid_input_source_task_with_transforms.json
copy
integration-tests/src/test/resources/indexer/{wikipedia_reindex_queries.json =>
wikipedia_reindex_queries_with_transforms.json} (70%)
create mode 100644
integration-tests/src/test/resources/indexer/wikipedia_reindex_task_with_transforms.json
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid-website-src] rachelpedreschi opened a new pull request #117: Update events.yml
rachelpedreschi opened a new pull request #117: Update events.yml URL: https://github.com/apache/druid-website-src/pull/117 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] averma111 commented on issue #8992: druid extension for OpenID Connect auth using pac4j lib
averma111 commented on issue #8992: druid extension for OpenID Connect auth using pac4j lib URL: https://github.com/apache/druid/pull/8992#issuecomment-608613439 Could some one send me the common runtime properties setting to implement pac4j. I have build druid 0.18 version and want to check these out. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] jihoonson commented on issue #9608: Eliminate common subfilters when converting it to a CNF
jihoonson commented on issue #9608: Eliminate common subfilters when converting it to a CNF URL: https://github.com/apache/druid/pull/9608#issuecomment-608592484 I'm tagging this PR as 0.18.0 since it could affect to Join performance significantly which is a new feature of 0.18.0. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] ccaominh opened a new pull request #9613: [Backport] Suppress CVEs for jackson-mapper-asl:1.9.13 (#9604)
ccaominh opened a new pull request #9613: [Backport] Suppress CVEs for jackson-mapper-asl:1.9.13 (#9604) URL: https://github.com/apache/druid/pull/9613 Backport #9064 to 0.18.0 to unblock the release build. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] stale[bot] closed issue #7806: Kafka index tasks failing after upgrade to 0.14.1-incubating
stale[bot] closed issue #7806: Kafka index tasks failing after upgrade to 0.14.1-incubating URL: https://github.com/apache/druid/issues/7806 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] stale[bot] commented on issue #7806: Kafka index tasks failing after upgrade to 0.14.1-incubating
stale[bot] commented on issue #7806: Kafka index tasks failing after upgrade to 0.14.1-incubating URL: https://github.com/apache/druid/issues/7806#issuecomment-608586729 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] acdn-mpreston closed issue #9391: 0.17.0 Kafka Supervisor becomes "unhealthy" due to missing inputFormat when Overlord is restarted
acdn-mpreston closed issue #9391: 0.17.0 Kafka Supervisor becomes "unhealthy" due to missing inputFormat when Overlord is restarted URL: https://github.com/apache/druid/issues/9391 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] acdn-mpreston commented on issue #9391: 0.17.0 Kafka Supervisor becomes "unhealthy" due to missing inputFormat when Overlord is restarted
acdn-mpreston commented on issue #9391: 0.17.0 Kafka Supervisor becomes "unhealthy" due to missing inputFormat when Overlord is restarted URL: https://github.com/apache/druid/issues/9391#issuecomment-608581741 I can confirm that this is resolved in the 0.17.1 branch. Closing this bug as resolved. Thank you for looking into it! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #9604: Suppress CVEs for jackson-mapper-asl:1.9.13
jihoonson merged pull request #9604: Suppress CVEs for jackson-mapper-asl:1.9.13 URL: https://github.com/apache/druid/pull/9604 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[druid] branch master updated: Suppress CVEs for jackson-mapper-asl:1.9.13 (#9604)
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new b541996 Suppress CVEs for jackson-mapper-asl:1.9.13 (#9604) b541996 is described below commit b5419962f0995daf0d4361a137f5f6c123fd9aa0 Author: Chi Cao Minh AuthorDate: Fri Apr 3 10:33:52 2020 -0700 Suppress CVEs for jackson-mapper-asl:1.9.13 (#9604) The jackson-mapper-asl:1.9.13 CVEs via curator-x-discovery are all suppressed for now as fixing them requires updating the curator version. --- owasp-dependency-check-suppressions.xml | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/owasp-dependency-check-suppressions.xml b/owasp-dependency-check-suppressions.xml index ebeb371..a6433a1 100644 --- a/owasp-dependency-check-suppressions.xml +++ b/owasp-dependency-check-suppressions.xml @@ -122,17 +122,8 @@ -^pkg:maven/org\.codehaus\.jackson/jackson\-mapper\-asl@.*$ -CVE-2017-7525 -CVE-2017-15095 -CVE-2017-17485 -CVE-2018-5968 -CVE-2018-7489 -CVE-2018-14718 -CVE-2019-10172 -CVE-2019-14540 -CVE-2019-16335 -CVE-2019-17267 +^pkg:maven/org\.codehaus\.jackson/jackson\-mapper\-asl@1.9.13$ +10 - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] ccaominh commented on issue #9610: Fix NPE in RemoteTaskRunner event handler causes JVM shutdown
ccaominh commented on issue #9610: Fix NPE in RemoteTaskRunner event handler causes JVM shutdown URL: https://github.com/apache/druid/pull/9610#issuecomment-608554699 PR description says curator 4.3.0, but changes upgraded to 4.2.0? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] jon-wei opened a new pull request #9612: [Backport] Fix for [CVE-2020-1958]: Apache Druid LDAP injection vulnerability (#9600)
jon-wei opened a new pull request #9612: [Backport] Fix for [CVE-2020-1958]: Apache Druid LDAP injection vulnerability (#9600) URL: https://github.com/apache/druid/pull/9612 Backport of #9600 to 0.18.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[druid] branch master updated: Add Integration Test for functionality of kinesis ingestion (#9576)
This is an automated email from the ASF dual-hosted git repository.
jonwei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 1852bf3 Add Integration Test for functionality of kinesis ingestion
(#9576)
1852bf3 is described below
commit 1852bf33ea43cfc155e38ede45a2a2c61b081597
Author: Maytas Monsereenusorn <52679095+mayt...@users.noreply.github.com>
AuthorDate: Fri Apr 3 06:45:22 2020 -1000
Add Integration Test for functionality of kinesis ingestion (#9576)
* kinesis IT
* Kinesis IT
* Kinesis IT
* Kinesis IT
* Kinesis IT
* Kinesis IT
* Kinesis IT
* Kinesis IT
* Kinesis IT
* Kinesis IT
* Kinesis IT
* Kinesis IT
* Kinesis IT
* Kinesis IT
* Kinesis IT
* fix kinesis timeout
* Kinesis IT
* Kinesis IT
* fix checkstyle
* Kinesis IT
* address comments
* fix checkstyle
---
.travis.yml| 4 +-
.../extensions-core/kinesis-ingestion.md | 2 +-
integration-tests/README.md| 35 +-
.../docker/environment-configs/broker | 2 +-
.../docker/environment-configs/coordinator | 2 +-
.../docker/environment-configs/historical | 2 +-
.../docker/environment-configs/middlemanager | 2 +-
.../docker/environment-configs/overlord| 2 +-
.../{router => override-examples/kinesis} | 15 +-
.../docker/environment-configs/router | 2 +-
.../environment-configs/router-custom-check-tls| 2 +-
.../environment-configs/router-no-client-auth-tls | 2 +-
.../environment-configs/router-permissive-tls | 2 +-
.../tls/generate-server-certs-and-keystores.sh | 6 +
integration-tests/pom.xml | 64 +++
integration-tests/run_cluster.sh | 23 +-
.../druid/testing/ConfigFileConfigProvider.java| 8 +
.../apache/druid/testing/DockerConfigProvider.java | 9 +
.../druid/testing/IntegrationTestingConfig.java| 2 +
.../clients/OverlordResourceTestClient.java| 95
.../testing/utils/DruidClusterAdminClient.java | 162 +++
.../druid/testing/utils/KinesisAdminClient.java| 162 +++
.../druid/testing/utils/KinesisEventWriter.java| 95
.../druid/testing/utils/StreamEventWriter.java | 29 ++
.../druid/testing/utils/StreamGenerator.java | 31 ++
.../utils/StreamVerifierEventGenerator.java| 55 +++
.../utils/StreamVerifierSyntheticEvent.java| 104 +
.../testing/utils/SyntheticStreamGenerator.java| 159 +++
.../utils/WikipediaStreamEventStreamGenerator.java | 60 +++
.../java/org/testng/DruidTestRunnerFactory.java| 44 +-
.../java/org/apache/druid/tests/TestNGGroup.java | 18 +-
.../tests/indexer/AbstractKafkaIndexerTest.java| 14 +-
.../ITKafkaIndexingServiceTransactionalTest.java | 2 +-
.../indexer/ITKinesisIndexingServiceTest.java | 480 +
...ndex_queries.json => stream_index_queries.json} | 0
...on => stream_supervisor_spec_input_format.json} | 12 +-
...n => stream_supervisor_spec_legacy_parser.json} | 12 +-
37 files changed, 1623 insertions(+), 97 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index e7582d5..d91d924 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -344,7 +344,7 @@ jobs:
name: "(Compile=openjdk8, Run=openjdk8) other integration test"
jdk: openjdk8
services: *integration_test_services
- env:
TESTNG_GROUPS='-DexcludedGroups=batch-index,perfect-rollup-parallel-batch-index,kafka-index,query,realtime-index,security,s3-deep-storage,gcs-deep-storage,azure-deep-storage,hdfs-deep-storage,s3-ingestion'
JVM_RUNTIME='-Djvm.runtime=8'
+ env:
TESTNG_GROUPS='-DexcludedGroups=batch-index,perfect-rollup-parallel-batch-index,kafka-index,query,realtime-index,security,s3-deep-storage,gcs-deep-storage,azure-deep-storage,hdfs-deep-storage,s3-ingestion,kinesis-index'
JVM_RUNTIME='-Djvm.runtime=8'
script: *run_integration_test
after_failure: *integration_test_diags
# END - Integration tests for Compile with Java 8 and Run with Java 8
@@ -383,7 +383,7 @@ jobs:
- <<: *integration_tests
name: "(Compile=openjdk8, Run=openjdk11) other integration test"
jdk: openjdk8
- env:
TESTNG_GROUPS='-DexcludedGroups=batch-index,perfect-rollup-parallel-batch-index,kafka-index,query,realtime-index,security,s3-deep-storage,gcs-deep-storage,azure-deep-storage,hdfs-deep-storage,s3-ingestion'
JVM_RUNTIME='-Djvm.runtime=11'
+ env:
TESTNG_GROUPS='-DexcludedGroups=batch-index,perfect-rollup-parallel-batch-index,kafka-index,query,realtime-index,security,s3-deep-storage,gcs-deep-storage,azure-deep-storage,hdfs-deep-storage,s
[GitHub] [druid] jon-wei merged pull request #9576: Add Integration Test for functionality of kinesis ingestion
jon-wei merged pull request #9576: Add Integration Test for functionality of kinesis ingestion URL: https://github.com/apache/druid/pull/9576 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] tsmethurst commented on issue #9380: Fine grained config and state resources
tsmethurst commented on issue #9380: Fine grained config and state resources URL: https://github.com/apache/druid/issues/9380#issuecomment-608504273 @pjain1 quick update before the weekend: I've added the CONFIG stuff as well, and made a few other changes to avoid code duplication and hardcoded resource name strings. Feel free to have a look and see if you have any thoughts on how I've done it :) https://github.com/apache/druid/compare/master...Klarrio:granular_permissions?expand=1 Enjoy the weekend! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] stale[bot] commented on issue #7908: Reindexing that results in empty partitions doesn't work properly
stale[bot] commented on issue #7908: Reindexing that results in empty partitions doesn't work properly URL: https://github.com/apache/druid/issues/7908#issuecomment-608376024 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@druid.apache.org list. Thank you for your contributions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] sekingme removed a comment on issue #8986: For total segment
sekingme removed a comment on issue #8986: For total segment URL: https://github.com/apache/druid/pull/8986#issuecomment-567303431 @jihoonson Hi, please check! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] stale[bot] commented on issue #8986: For total segment
stale[bot] commented on issue #8986: For total segment URL: https://github.com/apache/druid/pull/8986#issuecomment-608300081 This issue is no longer marked as stale. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] stale[bot] commented on issue #8986: For total segment
stale[bot] commented on issue #8986: For total segment URL: https://github.com/apache/druid/pull/8986#issuecomment-608270341 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the d...@druid.apache.org list. Thank you for your contributions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
