[GitHub] [druid] abhishekagarwal87 commented on pull request #10653: Fix post-aggregator computation when used with subtotals

2020-12-15 Thread GitBox


abhishekagarwal87 commented on pull request #10653:
URL: https://github.com/apache/druid/pull/10653#issuecomment-745130663


   Added the test for a nested groupBy query which fails in the current master. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



[GitHub] [druid] abhishekagarwal87 commented on pull request #10653: Fix post-aggregator computation when used with subtotals

2020-12-14 Thread GitBox


abhishekagarwal87 commented on pull request #10653:
URL: https://github.com/apache/druid/pull/10653#issuecomment-744659147


   > @abhishekagarwal87 Could you check the errors in 
https://travis-ci.com/github/apache/druid/jobs/456420636, including the one in 
GroupByQueryRunnerTest.testGroupByWithSubtotalsSpecWithLongDimensionColumn?
   
   It seems to be an existing bug. It can be reproduced in master by writing a 
subquery that generates null values for numeric dimensions.  
`RowBasedGrouperHelper#getValueSuppliersForDimensions` should handle the 
scenario when input can be a numeric null. 
   
   The bug occurs only when there is a subtotal or subquery used. It was caught 
here as when I removed the renaming of dimensions, I also removed the type 
change that was happening earlier (the dummy dimensions were string). 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org