[GitHub] [druid] abhishekagarwal87 commented on pull request #10767: Vectorized theta sketch aggregator.
abhishekagarwal87 commented on pull request #10767: URL: https://github.com/apache/druid/pull/10767#issuecomment-76089 I usually avoid abstract classes so there is no tight coupling. It can make unit testing easier as well. I can pass a mock helper into a vector aggregator and unit test in different ways easily. so my preference is toward the way ApproximateHistogram is implemented. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #10767: Vectorized theta sketch aggregator.
abhishekagarwal87 commented on pull request #10767: URL: https://github.com/apache/druid/pull/10767#issuecomment-760774449 Right. I was being subtle about it :) It would be nice to use the same style everywhere. If that pattern needs some modification, I can do that as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #10767: Vectorized theta sketch aggregator.
abhishekagarwal87 commented on pull request #10767: URL: https://github.com/apache/druid/pull/10767#issuecomment-760715147 By the way, I did a similar thing in https://github.com/apache/druid/pull/10304 to reduce some boilerplate code but used composition instead of inheritance. Added package-private`*BufferAggregatorHelper` classes which in turn are used by vector and buffer aggregator. The helper classes know how to work with buffers. The logic for getting an object out of selector and vectorization stuff was left out for Buffer and Vector classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
