benkrug commented on a change in pull request #10864: URL: https://github.com/apache/druid/pull/10864#discussion_r572551503
########## File path: docs/querying/datasource.md ########## @@ -272,7 +272,7 @@ GROUP BY Join datasources allow you to do a SQL-style join of two datasources. Stacking joins on top of each other allows you to join arbitrarily many datasources. -In Druid {{DRUIDVERSION}}, joins are implemented with a broadcast hash-join algorithm. This means that all tables +In Druid {{DRUIDVERSION}}, joins are implemented with a broadcast hash-join algorithm. This means that all datasources other than the leftmost "base" table must fit in memory. It also means that the join condition must be an equality. This Review comment: @techdocsmith thanks for looking at this! You're right, line 276 should also use 'datasource' rather than 'table'. I forgot that neither side of a join needs to be a table datasource. (I only caught the first because the right-hand side *can't* be a table. But the left-hand side doesn't need to be one, either.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org