[GitHub] [druid] jihoonson commented on pull request #10677: Add URI based allowPrefexList and denyPrefixList
jihoonson commented on pull request #10677: URL: https://github.com/apache/druid/pull/10677#issuecomment-995452665 > [ERROR] org.apache.druid.inputsource.hdfs.HdfsInputSourceTest$ReaderTest.testAllowPath(org.apache.druid.inputsource.hdfs.HdfsInputSourceTest$ReaderTest) > [ERROR] Run 1: HdfsInputSourceTest$ReaderTest.testAllowPath:401 » NullPointer inputSourceConf... > [ERROR] Run 2: HdfsInputSourceTest$ReaderTest.testAllowPath:401 » NullPointer inputSourceConf... > [ERROR] Run 3: HdfsInputSourceTest$ReaderTest.testAllowPath:401 » NullPointer inputSourceConf... > [ERROR] Run 4: HdfsInputSourceTest$ReaderTest.testAllowPath:401 » NullPointer inputSourceConf... > [ERROR] org.apache.druid.metadata.input.InputSourceModuleTest.testHttpInputSourceDefaultConfig(org.apache.druid.metadata.input.InputSourceModuleTest) > [ERROR] Run 1: InputSourceModuleTest.testHttpInputSourceDefaultConfig:121 » Configuration Gui... > [ERROR] Run 2: InputSourceModuleTest.testHttpInputSourceDefaultConfig:121 » Configuration Gui... > [ERROR] Run 3: InputSourceModuleTest.testHttpInputSourceDefaultConfig:121 » Configuration Gui... > [ERROR] Run 4: InputSourceModuleTest.testHttpInputSourceDefaultConfig:121 » Configuration Gui... Oh, I missed the CI failure. Those failed jobs seem legit as seen above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #10677: Add URI based allowPrefexList and denyPrefixList
jihoonson commented on pull request #10677: URL: https://github.com/apache/druid/pull/10677#issuecomment-966479433 @nishantmonu51 thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #10677: Add URI based allowPrefexList and denyPrefixList
jihoonson commented on pull request #10677: URL: https://github.com/apache/druid/pull/10677#issuecomment-966008789 Hi @nishantmonu51, any updates on this PR? I believe this will be useful from security perspective. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #10677: Add URI based allowPrefexList and denyPrefixList
jihoonson commented on pull request #10677: URL: https://github.com/apache/druid/pull/10677#issuecomment-760395019 @nishantmonu51 sorry to say, but I created a release branch yesterday. As this PR is unlikely backported (it's a feature and we backport only bug fixes since features can have bugs), I'm going to untag 0.21.0 milestone. This PR will be included in the next milestone. Since this PR didn't make it for 0.21.0, I think we cannot get rid of `HttpInputSourceConfig` immediately but keep it as deprecated for a while. I will not call out `HttpInputSourceConfig` in the release notes to discourage people from using it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #10677: Add URI based allowPrefexList and denyPrefixList
jihoonson commented on pull request #10677: URL: https://github.com/apache/druid/pull/10677#issuecomment-759700496 @nishantmonu51 I'm going to cut the branch for 0.21.0 by tonight as we are already behind the schedule (it was originally scheduled on the last Monday). I'm not sure whether we can make it or not because of the test failures. In this case, I would rather not rush but schedule this PR for a future release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #10677: Add URI based allowPrefexList and denyPrefixList
jihoonson commented on pull request #10677: URL: https://github.com/apache/druid/pull/10677#issuecomment-757043116 @nishantmonu51 BTW, since we are about to cut a branch for 0.21.0 release (scheduled on the next Monday), do you think we can get this PR merged before the branch cut? I'm asking because this change will introduce an incompatible change after the release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #10677: Add URI based allowPrefexList and denyPrefixList
jihoonson commented on pull request #10677: URL: https://github.com/apache/druid/pull/10677#issuecomment-757043116 @nishantmonu51 BTW, since we are about to cut a branch for 0.21.0 release (scheduled on the next Monday), do you think we can get this PR merged before the branch cut? I'm asking because this change will introduce an incompatible change after the release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
