[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8404: Bump HttpClient to 4.5.9
clintropolis commented on a change in pull request #8404: Bump HttpClient to 4.5.9 URL: https://github.com/apache/incubator-druid/pull/8404#discussion_r319874659 ## File path: licenses.yaml ## @@ -2807,20 +2806,6 @@ notices: --- -name: Apache HttpClient Review comment: Hmm, it could be that the license checker doesn't pick it up because nothing directly references this which just gets packed into the hadoop client folder at distribution packaging time. I pulled your branch, and definitely still see version 4.5.2 in there though: ``` .../hadoop-dependencies/hadoop-client/2.8.3/$ ls -1 | grep -C2 httpclient hadoop-yarn-server-common-2.8.3.jar htrace-core4-4.0.1-incubating.jar httpclient-4.5.2.jar httpcore-4.4.4.jar jackson-core-asl-1.9.13.jar ``` which is what this entry in the `licenses.yaml` file is for, so I still think this entry should be added back. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8404: Bump HttpClient to 4.5.9
clintropolis commented on a change in pull request #8404: Bump HttpClient to 4.5.9 URL: https://github.com/apache/incubator-druid/pull/8404#discussion_r319874659 ## File path: licenses.yaml ## @@ -2807,20 +2806,6 @@ notices: --- -name: Apache HttpClient Review comment: Hmm, it could be that the license checker doesn't pick it up because nothing directly references this which just gets packed into the hadoop client folder at distribution packaging time. I pulled your branch, and definitely still see version 4.5.2 in there though: ``` $ ls -1 | grep -C2 httpclient hadoop-yarn-server-common-2.8.3.jar htrace-core4-4.0.1-incubating.jar httpclient-4.5.2.jar httpcore-4.4.4.jar jackson-core-asl-1.9.13.jar ``` which is what this entry in the `licenses.yaml` file is for, so I still think this entry should be added back. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8404: Bump HttpClient to 4.5.9
clintropolis commented on a change in pull request #8404: Bump HttpClient to 4.5.9 URL: https://github.com/apache/incubator-druid/pull/8404#discussion_r317793323 ## File path: licenses.yaml ## @@ -2807,20 +2806,6 @@ notices: --- -name: Apache HttpClient Review comment: I would believe it is possible there are holes in the license checker scripts, especially maybe around handling dependencies that are duplicated in multiple modules, but I am not certain. I think [distribution/bin/generate-license.py](https://github.com/apache/incubator-druid/blob/master/distribution/bin/generate-license.py) would be where to look here if you are interested in digging in. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8404: Bump HttpClient to 4.5.9
clintropolis commented on a change in pull request #8404: Bump HttpClient to 4.5.9 URL: https://github.com/apache/incubator-druid/pull/8404#discussion_r317768383 ## File path: licenses.yaml ## @@ -2807,20 +2806,6 @@ notices: --- -name: Apache HttpClient Review comment: I don't believe this entry should be removed, it is for the jar in `hadoop-dependencies/hadoop-client/2.8.3/` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
