[GitHub] [incubator-druid] gianm commented on a change in pull request #7722: Upgrade various build and doc links to https.
gianm commented on a change in pull request #7722: Upgrade various build and doc links to https. URL: https://github.com/apache/incubator-druid/pull/7722#discussion_r286128710 ## File path: integration-tests/docker-base/setup.sh ## @@ -34,14 +34,30 @@ apt-get install -y mysql-server apt-get install -y supervisor # Zookeeper -wget -q -O - http://www.us.apache.org/dist/zookeeper/zookeeper-3.4.13/zookeeper-3.4.13.tar.gz | tar -xzf - -C /usr/local \ - && cp /usr/local/zookeeper-3.4.13/conf/zoo_sample.cfg /usr/local/zookeeper-3.4.13/conf/zoo.cfg \ - && ln -s /usr/local/zookeeper-3.4.13 /usr/local/zookeeper +wget -q -O /tmp/zookeeper-3.4.14.tar.gz "http://www.us.apache.org/dist/zookeeper/zookeeper-3.4.14/zookeeper-3.4.14.tar.gz; Review comment: OK, updated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] gianm commented on a change in pull request #7722: Upgrade various build and doc links to https.
gianm commented on a change in pull request #7722: Upgrade various build and doc links to https. URL: https://github.com/apache/incubator-druid/pull/7722#discussion_r286128681 ## File path: examples/quickstart/tutorial/hadoop/docker/setup-zulu-repo.sh ## @@ -0,0 +1,67 @@ +#!/bin/bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# +# Script to set up the Azul Zulu JDK yum repository. +# + +# Hardcode GPG key so we don't have to fetch it over http. Review comment: Do you mind if we keep the yum repo? That way, it'll always use the latest jdk. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] gianm commented on a change in pull request #7722: Upgrade various build and doc links to https.
gianm commented on a change in pull request #7722: Upgrade various build and doc links to https. URL: https://github.com/apache/incubator-druid/pull/7722#discussion_r286094458 ## File path: integration-tests/docker-base/setup.sh ## @@ -34,14 +34,30 @@ apt-get install -y mysql-server apt-get install -y supervisor # Zookeeper -wget -q -O - http://www.us.apache.org/dist/zookeeper/zookeeper-3.4.13/zookeeper-3.4.13.tar.gz | tar -xzf - -C /usr/local \ - && cp /usr/local/zookeeper-3.4.13/conf/zoo_sample.cfg /usr/local/zookeeper-3.4.13/conf/zoo.cfg \ - && ln -s /usr/local/zookeeper-3.4.13 /usr/local/zookeeper +wget -q -O /tmp/zookeeper-3.4.14.tar.gz "http://www.us.apache.org/dist/zookeeper/zookeeper-3.4.14/zookeeper-3.4.14.tar.gz; Review comment: Ah I didn't notice the https. I guess I can remove the shasum checks too. What do you all think? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] gianm commented on a change in pull request #7722: Upgrade various build and doc links to https.
gianm commented on a change in pull request #7722: Upgrade various build and doc links to https. URL: https://github.com/apache/incubator-druid/pull/7722#discussion_r286086695 ## File path: integration-tests/docker-base/setup.sh ## @@ -34,14 +34,30 @@ apt-get install -y mysql-server apt-get install -y supervisor # Zookeeper -wget -q -O - http://www.us.apache.org/dist/zookeeper/zookeeper-3.4.13/zookeeper-3.4.13.tar.gz | tar -xzf - -C /usr/local \ - && cp /usr/local/zookeeper-3.4.13/conf/zoo_sample.cfg /usr/local/zookeeper-3.4.13/conf/zoo.cfg \ - && ln -s /usr/local/zookeeper-3.4.13 /usr/local/zookeeper +wget -q -O /tmp/zookeeper-3.4.14.tar.gz "http://www.us.apache.org/dist/zookeeper/zookeeper-3.4.14/zookeeper-3.4.14.tar.gz; Review comment: Sure, is it better for some reason? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
