[GitHub] [incubator-druid] himanshug commented on a change in pull request #7722: Upgrade various build and doc links to https.
himanshug commented on a change in pull request #7722: Upgrade various build and doc links to https. URL: https://github.com/apache/incubator-druid/pull/7722#discussion_r286155773 ## File path: examples/quickstart/tutorial/hadoop/docker/setup-zulu-repo.sh ## @@ -0,0 +1,67 @@ +#!/bin/bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# +# Script to set up the Azul Zulu JDK yum repository. +# + +# Hardcode GPG key so we don't have to fetch it over http. Review comment: Ah, now I see why we are using yum there. sure, feel free to keep it in that case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] himanshug commented on a change in pull request #7722: Upgrade various build and doc links to https.
himanshug commented on a change in pull request #7722: Upgrade various build and doc links to https. URL: https://github.com/apache/incubator-druid/pull/7722#discussion_r286100060 ## File path: examples/quickstart/tutorial/hadoop/docker/setup-zulu-repo.sh ## @@ -0,0 +1,67 @@ +#!/bin/bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# +# Script to set up the Azul Zulu JDK yum repository. +# + +# Hardcode GPG key so we don't have to fetch it over http. Review comment: if we are using them only for jre , we can directly download same from https://cdn.azul.com/zulu/bin/zulu8.38.0.13-ca-jre8.0.212-linux_x64.tar.gz and not configure the yum repo. Ref: https://www.azul.com/downloads/zulu/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] himanshug commented on a change in pull request #7722: Upgrade various build and doc links to https.
himanshug commented on a change in pull request #7722: Upgrade various build and doc links to https. URL: https://github.com/apache/incubator-druid/pull/7722#discussion_r286095404 ## File path: integration-tests/docker-base/setup.sh ## @@ -34,14 +34,30 @@ apt-get install -y mysql-server apt-get install -y supervisor # Zookeeper -wget -q -O - http://www.us.apache.org/dist/zookeeper/zookeeper-3.4.13/zookeeper-3.4.13.tar.gz | tar -xzf - -C /usr/local \ - && cp /usr/local/zookeeper-3.4.13/conf/zoo_sample.cfg /usr/local/zookeeper-3.4.13/conf/zoo.cfg \ - && ln -s /usr/local/zookeeper-3.4.13 /usr/local/zookeeper +wget -q -O /tmp/zookeeper-3.4.14.tar.gz "http://www.us.apache.org/dist/zookeeper/zookeeper-3.4.14/zookeeper-3.4.14.tar.gz; Review comment: sure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] himanshug commented on a change in pull request #7722: Upgrade various build and doc links to https.
himanshug commented on a change in pull request #7722: Upgrade various build and doc links to https. URL: https://github.com/apache/incubator-druid/pull/7722#discussion_r286093387 ## File path: integration-tests/docker-base/setup.sh ## @@ -34,14 +34,30 @@ apt-get install -y mysql-server apt-get install -y supervisor # Zookeeper -wget -q -O - http://www.us.apache.org/dist/zookeeper/zookeeper-3.4.13/zookeeper-3.4.13.tar.gz | tar -xzf - -C /usr/local \ - && cp /usr/local/zookeeper-3.4.13/conf/zoo_sample.cfg /usr/local/zookeeper-3.4.13/conf/zoo.cfg \ - && ln -s /usr/local/zookeeper-3.4.13 /usr/local/zookeeper +wget -q -O /tmp/zookeeper-3.4.14.tar.gz "http://www.us.apache.org/dist/zookeeper/zookeeper-3.4.14/zookeeper-3.4.14.tar.gz; Review comment: because that is "https" , we can probably do same for kafka url below. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] himanshug commented on a change in pull request #7722: Upgrade various build and doc links to https.
himanshug commented on a change in pull request #7722: Upgrade various build and doc links to https. URL: https://github.com/apache/incubator-druid/pull/7722#discussion_r286093387 ## File path: integration-tests/docker-base/setup.sh ## @@ -34,14 +34,30 @@ apt-get install -y mysql-server apt-get install -y supervisor # Zookeeper -wget -q -O - http://www.us.apache.org/dist/zookeeper/zookeeper-3.4.13/zookeeper-3.4.13.tar.gz | tar -xzf - -C /usr/local \ - && cp /usr/local/zookeeper-3.4.13/conf/zoo_sample.cfg /usr/local/zookeeper-3.4.13/conf/zoo.cfg \ - && ln -s /usr/local/zookeeper-3.4.13 /usr/local/zookeeper +wget -q -O /tmp/zookeeper-3.4.14.tar.gz "http://www.us.apache.org/dist/zookeeper/zookeeper-3.4.14/zookeeper-3.4.14.tar.gz; Review comment: probably because that is "https" , we can probably do same for kafka url below. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
